[ovs-dev] [PATCH v2] ovn-trace: Possible null dereference

2017-01-29 Thread Alin Serdean
From: Alin Serdean 

Found by inspection.

Signed-off-by: Alin Gabriel Serdean 
---
v2: change paranthesis as suggested by Gurucharan Shetty 
---
 ovn/utilities/ovn-trace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c
index 307556b..b894442 100644
--- a/ovn/utilities/ovn-trace.c
+++ b/ovn/utilities/ovn-trace.c
@@ -1224,7 +1224,7 @@ execute_output(const struct ovntrace_datapath *dp, struct 
flow *uflow,
 }
 }
 
-if (port->tunnel_key != in_key || allow_loopback) {
+if ((port && port->tunnel_key != in_key) || allow_loopback) {
 struct ovntrace_node *node = ovntrace_node_append(
 super, OVNTRACE_NODE_PIPELINE,
 "egress(dp=\"%s\", inport=\"%s\", outport=\"%s\")",
-- 
2.10.2.windows.1
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [PATCH v2] ovn-trace: Possible null dereference

2017-01-30 Thread Guru Shetty
On 29 January 2017 at 23:04, Alin Serdean 
wrote:

> From: Alin Serdean 
>
> Found by inspection.
>
> Signed-off-by: Alin Gabriel Serdean 
>
Applied, thanks!


> ---
> v2: change paranthesis as suggested by Gurucharan Shetty 
> ---
>  ovn/utilities/ovn-trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/utilities/ovn-trace.c b/ovn/utilities/ovn-trace.c
> index 307556b..b894442 100644
> --- a/ovn/utilities/ovn-trace.c
> +++ b/ovn/utilities/ovn-trace.c
> @@ -1224,7 +1224,7 @@ execute_output(const struct ovntrace_datapath *dp,
> struct flow *uflow,
>  }
>  }
>
> -if (port->tunnel_key != in_key || allow_loopback) {
> +if ((port && port->tunnel_key != in_key) || allow_loopback) {
>  struct ovntrace_node *node = ovntrace_node_append(
>  super, OVNTRACE_NODE_PIPELINE,
>  "egress(dp=\"%s\", inport=\"%s\", outport=\"%s\")",
> --
> 2.10.2.windows.1
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev