Re: [ovs-dev] [PATCH v2] vconn: Count vconn_sent regardless of log level.

[Ilya Maximets]

On 1/8/24 10:37, Eelco Chaudron wrote:
> 
> 
> On 6 Jan 2024, at 10:23, Cheng Li wrote:
> 
>> vconn_sent counter is supposed to increase each time send() return
>> 0, no matter if the vconn log debug is on or off.
>>
>> Signed-off-by: Cheng Li 
> 
> Thanks for catching and fixing this! The change looks good to me.
> 
> Acked-by: Eelco Chaudron 
> 


Thanks!  Applied and backported down to 2.17.

Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v2] vconn: Count vconn_sent regardless of log level.

[Eelco Chaudron]

On 6 Jan 2024, at 10:23, Cheng Li wrote:

> vconn_sent counter is supposed to increase each time send() return
> 0, no matter if the vconn log debug is on or off.
>
> Signed-off-by: Cheng Li 

Thanks for catching and fixing this! The change looks good to me.

Acked-by: Eelco Chaudron 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2] vconn: Count vconn_sent regardless of log level.

[Cheng Li]

vconn_sent counter is supposed to increase each time send() return
0, no matter if the vconn log debug is on or off.

Signed-off-by: Cheng Li 
---

Notes:
v2: Increase vconn_sent only if send() return 0.

 lib/vconn.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/vconn.c b/lib/vconn.c
index b55676227..e9603432d 100644
--- a/lib/vconn.c
+++ b/lib/vconn.c
@@ -682,7 +682,6 @@ do_send(struct vconn *vconn, struct ofpbuf *msg)
 
 ofpmsg_update_length(msg);
 if (!VLOG_IS_DBG_ENABLED()) {
-COVERAGE_INC(vconn_sent);
 retval = (vconn->vclass->send)(vconn, msg);
 } else {
 char *s = ofp_to_string(msg->data, msg->size, NULL, NULL, 1);
@@ -693,6 +692,9 @@ do_send(struct vconn *vconn, struct ofpbuf *msg)
 }
 free(s);
 }
+if (!retval) {
+COVERAGE_INC(vconn_sent);
+}
 return retval;
 }
 
-- 
2.39.3

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev