Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to linux-prepare.sh
Hi Ilya,
Travis on Arm looks stable now, we did not observe any issue more than two
weeks. And Travis also made some adjustment on their side, you can see their
reply here: https://travis-ci.community/t/segfaults-in-arm64-environment/5617/13
Could you reconsider this patch?
Best Regards,
Wei Yanqin
> -Original Message-
> From: Lance Yang (Arm Technology China)
> Sent: Tuesday, December 17, 2019 9:54 AM
> To: Ilya Maximets ; dwilder
> Cc: ovs-dev@openvswitch.org; b...@ovn.org; Yanqin Wei (Arm Technology
> China) ; Gavin Hu (Arm Technology China)
> ; Ruifeng Wang (Arm Technology China)
> ; Jieqiang Wang (Arm Technology China)
> ; Malvika Gupta ; nd
>
> Subject: RE: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to
> linux-prepare.sh
>
>
>
> > -Original Message-
> > From: Ilya Maximets
> > Sent: Saturday, December 14, 2019 1:55 AM
> > To: dwilder ; Lance Yang (Arm Technology China)
> >
> > Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; b...@ovn.org; Yanqin
> > Wei (Arm Technology China) ; Gavin Hu (Arm
> > Technology China) ; Ruifeng Wang (Arm Technology
> > China) ; Jieqiang Wang (Arm Technology China)
> > ; Malvika Gupta ; nd
> >
> > Subject: Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon
> > packages to linux- prepare.sh
> >
> > On 06.12.2019 23:32, dwilder wrote:
> > > On 2019-12-05 19:26, Lance Yang wrote:
> > >> To enable multiple CPU architectures support, it is necessary to
> > >> move the x86-only addon packages from .travis.yml file. Otherwise,
> > >> the x86-only addon packages will break the builds on some other CPU
> architectures.
> > >>
> > >> Reviewed-by: Yanqin Wei
> > >> Reviewed-by: Malvika Gupta
> > >> Reviewed-by: Gavin Hu
> > >> Reviewed-by: Ruifeng Wang
> > >> Signed-off-by: Lance Yang
> > >> ---
> > >> .travis.yml | 2 --
> > >> .travis/linux-prepare.sh | 3 ++-
> > >> 2 files changed, 2 insertions(+), 3 deletions(-)
> > >>
> > >> diff --git a/.travis.yml b/.travis.yml index 482efd2..2dc4d43
> > >> 100644
> > >> --- a/.travis.yml
> > >> +++ b/.travis.yml
> > >> @@ -14,7 +14,6 @@ addons:
> > >>apt:
> > >> packages:
> > >>- bc
> > >> - - gcc-multilib
> > >>- libssl-dev
> > >>- llvm-dev
> > >>- libjemalloc1
> > >> @@ -26,7 +25,6 @@ addons:
> > >>- libelf-dev
> > >>- selinux-policy-dev
> > >>- libunbound-dev
> > >> - - libunbound-dev:i386
> > >>- libunwind-dev
> > >>
> > >> before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
> > >> diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh
> > >> index 9e3ac0d..6421066 100755
> > >> --- a/.travis/linux-prepare.sh
> > >> +++ b/.travis/linux-prepare.sh
> > >> @@ -18,7 +18,8 @@ pip install --user --upgrade docutils if [
> > >> "$M32" ]; then
> > >> # 32-bit and 64-bit libunwind can not be installed at the same time.
> > >> # This will remove the 64-bit libunwind and install 32-bit version.
> > >> -sudo apt-get install -y libunwind-dev:i386
> > >> +sudo apt-get install -y \
> > >> +libunwind-dev:i386 libunbound-dev:i386 gcc-multilib
> > >> fi
> > >>
> > >> # IPv6 is supported by kernel but disabled in TravisCI images:
> > >
> > > LGTM:
> > > With this patch applied ppc64le simply needs to be include into the
> > > matrix.
> > > I will submit an updated ppc64le patch to be layered on top of this one.
> > >
> > > Acked-by: David Wilder
> >
> > Thanks. First two patches of this series are good even without
> > multiarch support so I went ahead and applied them (with minor
> > visual/spelling changes) to master. We'll need to think more about
> > actual enabling of ppc/arm since they are not that stable as we would want
> them to be.
> >
> > Best regards, Ilya Maximets.
> [Lance]
>
> Hi Ilya,
>
> Thank you for all the comments. I am glad to that the patches can be merged.
>
> We reported the segment fault issue to Travis CI community. You can see the
> threads for segment faults in arm64/ppc64 environment:
> https://travis-ci.community/t/segfaults-in-arm64-environment/5617/8
> https://travis-ci.community/t/arm64-ppc64le-segfaults/6158
>
> There might be a period of time for the Travis CI community to investigate. We
> will keep you updated about the latest process.
>
> Best regards, Lance
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to linux-prepare.sh
> -Original Message-
> From: Ilya Maximets
> Sent: Saturday, December 14, 2019 1:55 AM
> To: dwilder ; Lance Yang (Arm Technology China)
>
> Cc: ovs-dev@openvswitch.org; i.maxim...@ovn.org; b...@ovn.org; Yanqin Wei (Arm
> Technology China) ; Gavin Hu (Arm Technology China)
> ; Ruifeng Wang (Arm Technology China)
> ;
> Jieqiang Wang (Arm Technology China) ; Malvika Gupta
> ; nd
> Subject: Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to
> linux-
> prepare.sh
>
> On 06.12.2019 23:32, dwilder wrote:
> > On 2019-12-05 19:26, Lance Yang wrote:
> >> To enable multiple CPU architectures support, it is necessary to move
> >> the x86-only addon packages from .travis.yml file. Otherwise, the
> >> x86-only addon packages will break the builds on some other CPU
> >> architectures.
> >>
> >> Reviewed-by: Yanqin Wei
> >> Reviewed-by: Malvika Gupta
> >> Reviewed-by: Gavin Hu
> >> Reviewed-by: Ruifeng Wang
> >> Signed-off-by: Lance Yang
> >> ---
> >> .travis.yml | 2 --
> >> .travis/linux-prepare.sh | 3 ++-
> >> 2 files changed, 2 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/.travis.yml b/.travis.yml index 482efd2..2dc4d43 100644
> >> --- a/.travis.yml
> >> +++ b/.travis.yml
> >> @@ -14,7 +14,6 @@ addons:
> >>apt:
> >> packages:
> >>- bc
> >> - - gcc-multilib
> >>- libssl-dev
> >>- llvm-dev
> >>- libjemalloc1
> >> @@ -26,7 +25,6 @@ addons:
> >>- libelf-dev
> >>- selinux-policy-dev
> >>- libunbound-dev
> >> - - libunbound-dev:i386
> >>- libunwind-dev
> >>
> >> before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
> >> diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh
> >> index 9e3ac0d..6421066 100755
> >> --- a/.travis/linux-prepare.sh
> >> +++ b/.travis/linux-prepare.sh
> >> @@ -18,7 +18,8 @@ pip install --user --upgrade docutils
> >> if [ "$M32" ]; then
> >> # 32-bit and 64-bit libunwind can not be installed at the same time.
> >> # This will remove the 64-bit libunwind and install 32-bit version.
> >> -sudo apt-get install -y libunwind-dev:i386
> >> +sudo apt-get install -y \
> >> +libunwind-dev:i386 libunbound-dev:i386 gcc-multilib
> >> fi
> >>
> >> # IPv6 is supported by kernel but disabled in TravisCI images:
> >
> > LGTM:
> > With this patch applied ppc64le simply needs to be include into the matrix.
> > I will submit an updated ppc64le patch to be layered on top of this one.
> >
> > Acked-by: David Wilder
>
> Thanks. First two patches of this series are good even without multiarch
> support so I went
> ahead and applied them (with minor visual/spelling changes) to master. We'll
> need to think
> more about actual enabling of ppc/arm since they are not that stable as we
> would want
> them to be.
>
> Best regards, Ilya Maximets.
[Lance]
Hi Ilya,
Thank you for all the comments. I am glad to that the patches can be merged.
We reported the segment fault issue to Travis CI community. You can see the
threads for segment faults in arm64/ppc64 environment:
https://travis-ci.community/t/segfaults-in-arm64-environment/5617/8
https://travis-ci.community/t/arm64-ppc64le-segfaults/6158
There might be a period of time for the Travis CI community to investigate. We
will keep you updated about the latest process.
Best regards, Lance
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to linux-prepare.sh
On 06.12.2019 23:32, dwilder wrote:
> On 2019-12-05 19:26, Lance Yang wrote:
>> To enable multiple CPU architectures support, it is necessary to move the
>> x86-only addon packages from .travis.yml file. Otherwise, the x86-only
>> addon packages will break the builds on some other CPU architectures.
>>
>> Reviewed-by: Yanqin Wei
>> Reviewed-by: Malvika Gupta
>> Reviewed-by: Gavin Hu
>> Reviewed-by: Ruifeng Wang
>> Signed-off-by: Lance Yang
>> ---
>> .travis.yml | 2 --
>> .travis/linux-prepare.sh | 3 ++-
>> 2 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/.travis.yml b/.travis.yml
>> index 482efd2..2dc4d43 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -14,7 +14,6 @@ addons:
>> apt:
>> packages:
>> - bc
>> - - gcc-multilib
>> - libssl-dev
>> - llvm-dev
>> - libjemalloc1
>> @@ -26,7 +25,6 @@ addons:
>> - libelf-dev
>> - selinux-policy-dev
>> - libunbound-dev
>> - - libunbound-dev:i386
>> - libunwind-dev
>>
>> before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
>> diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh
>> index 9e3ac0d..6421066 100755
>> --- a/.travis/linux-prepare.sh
>> +++ b/.travis/linux-prepare.sh
>> @@ -18,7 +18,8 @@ pip install --user --upgrade docutils
>> if [ "$M32" ]; then
>> # 32-bit and 64-bit libunwind can not be installed at the same time.
>> # This will remove the 64-bit libunwind and install 32-bit version.
>> - sudo apt-get install -y libunwind-dev:i386
>> + sudo apt-get install -y \
>> + libunwind-dev:i386 libunbound-dev:i386 gcc-multilib
>> fi
>>
>> # IPv6 is supported by kernel but disabled in TravisCI images:
>
> LGTM:
> With this patch applied ppc64le simply needs to be include into the matrix.
> I will submit an updated ppc64le patch to be layered on top of this one.
>
> Acked-by: David Wilder
Thanks. First two patches of this series are good even without multiarch
support so I went ahead and applied them (with minor visual/spelling changes)
to master. We'll need to think more about actual enabling of ppc/arm since
they are not that stable as we would want them to be.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to linux-prepare.sh
On 2019-12-05 19:26, Lance Yang wrote:
To enable multiple CPU architectures support, it is necessary to move
the
x86-only addon packages from .travis.yml file. Otherwise, the x86-only
addon packages will break the builds on some other CPU architectures.
Reviewed-by: Yanqin Wei
Reviewed-by: Malvika Gupta
Reviewed-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Signed-off-by: Lance Yang
---
.travis.yml | 2 --
.travis/linux-prepare.sh | 3 ++-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 482efd2..2dc4d43 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,7 +14,6 @@ addons:
apt:
packages:
- bc
- - gcc-multilib
- libssl-dev
- llvm-dev
- libjemalloc1
@@ -26,7 +25,6 @@ addons:
- libelf-dev
- selinux-policy-dev
- libunbound-dev
- - libunbound-dev:i386
- libunwind-dev
before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh
index 9e3ac0d..6421066 100755
--- a/.travis/linux-prepare.sh
+++ b/.travis/linux-prepare.sh
@@ -18,7 +18,8 @@ pip install --user --upgrade docutils
if [ "$M32" ]; then
# 32-bit and 64-bit libunwind can not be installed at the same
time.
# This will remove the 64-bit libunwind and install 32-bit
version.
-sudo apt-get install -y libunwind-dev:i386
+sudo apt-get install -y \
+libunwind-dev:i386 libunbound-dev:i386 gcc-multilib
fi
# IPv6 is supported by kernel but disabled in TravisCI images:
LGTM:
With this patch applied ppc64le simply needs to be include into the
matrix.
I will submit an updated ppc64le patch to be layered on top of this one.
Acked-by: David Wilder
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v2 2/3] travis: Move x86-only addon packages to linux-prepare.sh
To enable multiple CPU architectures support, it is necessary to move the
x86-only addon packages from .travis.yml file. Otherwise, the x86-only
addon packages will break the builds on some other CPU architectures.
Reviewed-by: Yanqin Wei
Reviewed-by: Malvika Gupta
Reviewed-by: Gavin Hu
Reviewed-by: Ruifeng Wang
Signed-off-by: Lance Yang
---
.travis.yml | 2 --
.travis/linux-prepare.sh | 3 ++-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/.travis.yml b/.travis.yml
index 482efd2..2dc4d43 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -14,7 +14,6 @@ addons:
apt:
packages:
- bc
- - gcc-multilib
- libssl-dev
- llvm-dev
- libjemalloc1
@@ -26,7 +25,6 @@ addons:
- libelf-dev
- selinux-policy-dev
- libunbound-dev
- - libunbound-dev:i386
- libunwind-dev
before_install: ./.travis/${TRAVIS_OS_NAME}-prepare.sh
diff --git a/.travis/linux-prepare.sh b/.travis/linux-prepare.sh
index 9e3ac0d..6421066 100755
--- a/.travis/linux-prepare.sh
+++ b/.travis/linux-prepare.sh
@@ -18,7 +18,8 @@ pip install --user --upgrade docutils
if [ "$M32" ]; then
# 32-bit and 64-bit libunwind can not be installed at the same time.
# This will remove the 64-bit libunwind and install 32-bit version.
-sudo apt-get install -y libunwind-dev:i386
+sudo apt-get install -y \
+libunwind-dev:i386 libunbound-dev:i386 gcc-multilib
fi
# IPv6 is supported by kernel but disabled in TravisCI images:
--
2.7.4
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
