Re: [ovs-dev] [PATCH v2 2/4] Don't convert EAGAIN to EPROTO for unix sockets

[0-day Robot]

Bleep bloop.  Greetings Ihar Hrachyshka, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: The subject summary should end with a dot.
Subject: Don't convert EAGAIN to EPROTO for unix sockets
Lines checked: 32, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v2 2/4] Don't convert EAGAIN to EPROTO for unix sockets

[Ihar Hrachyshka]

Unix sockets also have listener backlog. Returning EAGAIN is valid to
allow the caller handle the non-blocking temporary failure to connect()
gracefully.

Signed-off-by: Ihar Hrachyshka 
---
 lib/socket-util-unix.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/socket-util-unix.c b/lib/socket-util-unix.c
index 59f63fcce..0053a61b1 100644
--- a/lib/socket-util-unix.c
+++ b/lib/socket-util-unix.c
@@ -376,9 +376,6 @@ make_unix_socket(int style, bool nonblock,
 return fd;
 
 error:
-if (error == EAGAIN) {
-error = EPROTO;
-}
 if (bind_path) {
 fatal_signal_unlink_file_now(bind_path);
 }
-- 
2.41.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev