Re: [ovs-dev] [PATCH v2 ovn 0/3] Handle LB VIPs that share backends and make flows offloadable.
On 2/24/21 7:19 PM, Numan Siddique wrote: On Wed, Feb 24, 2021 at 9:40 PM Dumitru Ceara wrote: Patch 1/3 fixes a bug when using learn() action to generate hairpin reply flows for different VIPs that share backends. It also addresses backwards compatibility in order to avoid having issues during upgrades. Patches 2/3 and 3/3 use the new OVS registers populated by patch 1/3 to simplify the hairpin flows and to avoid matching on conntrack original tuple fields or ct.dnat as tests have shown that these are not offloadable on specific NICs (e.g., MLX-CX5). Changes in V2: - Addressed Numan's comments. - Added Numan's acks. Dumitru Ceara (3): Properly handle hairpin traffic for VIPs with shared backends. lflow: Avoid matching on conntrack original tuple if possible. northd: Avoid matching on ct.dnat flags for load balancers. Thanks Dumitru for addressing the comments. I applied the patch series to the main branch. Along with the 1st patch I also applied the other 2 patches to the newly created branch 21.03 as I thought it makes sense to apply the whole series rather than just the 1st patch. Thanks Numan Great, thank you! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 ovn 0/3] Handle LB VIPs that share backends and make flows offloadable.
On Wed, Feb 24, 2021 at 9:40 PM Dumitru Ceara wrote: > > Patch 1/3 fixes a bug when using learn() action to generate hairpin > reply flows for different VIPs that share backends. It also addresses > backwards compatibility in order to avoid having issues during upgrades. > > Patches 2/3 and 3/3 use the new OVS registers populated by patch 1/3 to > simplify the hairpin flows and to avoid matching on conntrack original > tuple fields or ct.dnat as tests have shown that these are not offloadable > on specific NICs (e.g., MLX-CX5). > > Changes in V2: > - Addressed Numan's comments. > - Added Numan's acks. > > Dumitru Ceara (3): > Properly handle hairpin traffic for VIPs with shared backends. > lflow: Avoid matching on conntrack original tuple if possible. > northd: Avoid matching on ct.dnat flags for load balancers. Thanks Dumitru for addressing the comments. I applied the patch series to the main branch. Along with the 1st patch I also applied the other 2 patches to the newly created branch 21.03 as I thought it makes sense to apply the whole series rather than just the 1st patch. Thanks Numan > > > controller/lflow.c | 107 +- > include/ovn/logical-fields.h |8 + > lib/lb.c |3 > lib/lb.h |3 > northd/ovn-northd.8.xml | 53 +++-- > northd/ovn-northd.c | 143 +++--- > ovn-sb.xml |6 + > tests/ofproto-macros.at |2 > tests/ovn-northd.at | 57 - > tests/ovn.at | 443 > +- > tests/system-ovn.at | 40 ++-- > 11 files changed, 642 insertions(+), 223 deletions(-) > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v2 ovn 0/3] Handle LB VIPs that share backends and make flows offloadable.
Patch 1/3 fixes a bug when using learn() action to generate hairpin reply flows for different VIPs that share backends. It also addresses backwards compatibility in order to avoid having issues during upgrades. Patches 2/3 and 3/3 use the new OVS registers populated by patch 1/3 to simplify the hairpin flows and to avoid matching on conntrack original tuple fields or ct.dnat as tests have shown that these are not offloadable on specific NICs (e.g., MLX-CX5). Changes in V2: - Addressed Numan's comments. - Added Numan's acks. Dumitru Ceara (3): Properly handle hairpin traffic for VIPs with shared backends. lflow: Avoid matching on conntrack original tuple if possible. northd: Avoid matching on ct.dnat flags for load balancers. controller/lflow.c | 107 +- include/ovn/logical-fields.h |8 + lib/lb.c |3 lib/lb.h |3 northd/ovn-northd.8.xml | 53 +++-- northd/ovn-northd.c | 143 +++--- ovn-sb.xml |6 + tests/ofproto-macros.at |2 tests/ovn-northd.at | 57 - tests/ovn.at | 443 +- tests/system-ovn.at | 40 ++-- 11 files changed, 642 insertions(+), 223 deletions(-) ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
