Re: [ovs-dev] [PATCH v2 ovn 0/4] respin CoPP series

2021-06-03 Thread Lorenzo Bianconi
> On 24/05/2021 19:44, Lorenzo Bianconi wrote:
> > This series respin CoPP support introduced here [0] by Dumitru rebasing on 
> > top
> > of ovn master branch and adding some missing meters (e.g. bfd or acl 
> > reject).
> > The main goal of this series is to continue the discussion about the 
> > proposed
> > approach and to align on CMS APIs.
> > For the moment no ddlog support has been added.
> > Related bz:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1947913
> > https://bugzilla.redhat.com/show_bug.cgi?id=1946610
> 
> I mentioned the possibility of adding a tutorial. Is that something you
> will do in a separate patch?

Hi Mark,

yes, my intention is to add it in a dedicated patch (sorry to not be clear on
it).

Regards,
Lorenzo

> > 
> > Changes since v1:
> > - merge patch 3/5 and 4/5
> > - cosmetics
> > - improve naming conventions
> > - add more unit-tests/system-tests
> > - remove duplicated flow
> > - remove some leftover entries in ovn-nbctl.8.xml
> > - add metering for sctp abort packets
> > 
> > Changes since RFC:
> > - drop per-port metering
> > - add unit/system tests
> > - add reject action metering
> > 
> > [0] 
> > https://patchwork.ozlabs.org/project/openvswitch/list/?series=140778=*
> > 
> > Dumitru Ceara (4):
> >   ovn-controller: Add support for Logical_Flow control meters
> >   ovn-northd: Add support for CoPP.
> >   ovn-northd: Add CoPP policies for flows that punt packets to
> > ovn-controller.
> >   NEWS: Add CoPP support.
> > 
> >  NEWS  |   1 +
> >  controller/lflow.c|  40 ++-
> >  controller/ofctrl.c   |  55 ++--
> >  controller/ofctrl.h   |  21 +-
> >  controller/physical.c |   7 +-
> >  include/ovn/actions.h |   3 +-
> >  lib/actions.c | 116 -
> >  lib/automake.mk   |   2 +
> >  lib/copp.c| 143 ++
> >  lib/copp.h|  59 +
> >  northd/ovn-northd.c   | 535 --
> >  ovn-nb.ovsschema  |  16 +-
> >  ovn-nb.xml|  81 ++
> >  ovn-sb.ovsschema  |   6 +-
> >  ovn-sb.xml|   6 +
> >  tests/atlocal.in  |   3 +
> >  tests/ovn-controller.at   |  48 
> >  tests/ovn-northd.at   |  81 ++
> >  tests/ovn.at  |   4 +-
> >  tests/system-ovn.at   | 135 ++
> >  utilities/ovn-nbctl.8.xml | 119 +
> >  utilities/ovn-nbctl.c | 178 +
> >  22 files changed, 1360 insertions(+), 299 deletions(-)
> >  create mode 100644 lib/copp.c
> >  create mode 100644 lib/copp.h
> > 
> 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [PATCH v2 ovn 0/4] respin CoPP series

2021-06-03 Thread Mark Gray
On 24/05/2021 19:44, Lorenzo Bianconi wrote:
> This series respin CoPP support introduced here [0] by Dumitru rebasing on top
> of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
> The main goal of this series is to continue the discussion about the proposed
> approach and to align on CMS APIs.
> For the moment no ddlog support has been added.
> Related bz:
> https://bugzilla.redhat.com/show_bug.cgi?id=1947913
> https://bugzilla.redhat.com/show_bug.cgi?id=1946610

I mentioned the possibility of adding a tutorial. Is that something you
will do in a separate patch?
> 
> Changes since v1:
> - merge patch 3/5 and 4/5
> - cosmetics
> - improve naming conventions
> - add more unit-tests/system-tests
> - remove duplicated flow
> - remove some leftover entries in ovn-nbctl.8.xml
> - add metering for sctp abort packets
> 
> Changes since RFC:
> - drop per-port metering
> - add unit/system tests
> - add reject action metering
> 
> [0] 
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=140778=*
> 
> Dumitru Ceara (4):
>   ovn-controller: Add support for Logical_Flow control meters
>   ovn-northd: Add support for CoPP.
>   ovn-northd: Add CoPP policies for flows that punt packets to
> ovn-controller.
>   NEWS: Add CoPP support.
> 
>  NEWS  |   1 +
>  controller/lflow.c|  40 ++-
>  controller/ofctrl.c   |  55 ++--
>  controller/ofctrl.h   |  21 +-
>  controller/physical.c |   7 +-
>  include/ovn/actions.h |   3 +-
>  lib/actions.c | 116 -
>  lib/automake.mk   |   2 +
>  lib/copp.c| 143 ++
>  lib/copp.h|  59 +
>  northd/ovn-northd.c   | 535 --
>  ovn-nb.ovsschema  |  16 +-
>  ovn-nb.xml|  81 ++
>  ovn-sb.ovsschema  |   6 +-
>  ovn-sb.xml|   6 +
>  tests/atlocal.in  |   3 +
>  tests/ovn-controller.at   |  48 
>  tests/ovn-northd.at   |  81 ++
>  tests/ovn.at  |   4 +-
>  tests/system-ovn.at   | 135 ++
>  utilities/ovn-nbctl.8.xml | 119 +
>  utilities/ovn-nbctl.c | 178 +
>  22 files changed, 1360 insertions(+), 299 deletions(-)
>  create mode 100644 lib/copp.c
>  create mode 100644 lib/copp.h
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


[ovs-dev] [PATCH v2 ovn 0/4] respin CoPP series

2021-05-24 Thread Lorenzo Bianconi
This series respin CoPP support introduced here [0] by Dumitru rebasing on top
of ovn master branch and adding some missing meters (e.g. bfd or acl reject).
The main goal of this series is to continue the discussion about the proposed
approach and to align on CMS APIs.
For the moment no ddlog support has been added.
Related bz:
https://bugzilla.redhat.com/show_bug.cgi?id=1947913
https://bugzilla.redhat.com/show_bug.cgi?id=1946610

Changes since v1:
- merge patch 3/5 and 4/5
- cosmetics
- improve naming conventions
- add more unit-tests/system-tests
- remove duplicated flow
- remove some leftover entries in ovn-nbctl.8.xml
- add metering for sctp abort packets

Changes since RFC:
- drop per-port metering
- add unit/system tests
- add reject action metering

[0] https://patchwork.ozlabs.org/project/openvswitch/list/?series=140778=*

Dumitru Ceara (4):
  ovn-controller: Add support for Logical_Flow control meters
  ovn-northd: Add support for CoPP.
  ovn-northd: Add CoPP policies for flows that punt packets to
ovn-controller.
  NEWS: Add CoPP support.

 NEWS  |   1 +
 controller/lflow.c|  40 ++-
 controller/ofctrl.c   |  55 ++--
 controller/ofctrl.h   |  21 +-
 controller/physical.c |   7 +-
 include/ovn/actions.h |   3 +-
 lib/actions.c | 116 -
 lib/automake.mk   |   2 +
 lib/copp.c| 143 ++
 lib/copp.h|  59 +
 northd/ovn-northd.c   | 535 --
 ovn-nb.ovsschema  |  16 +-
 ovn-nb.xml|  81 ++
 ovn-sb.ovsschema  |   6 +-
 ovn-sb.xml|   6 +
 tests/atlocal.in  |   3 +
 tests/ovn-controller.at   |  48 
 tests/ovn-northd.at   |  81 ++
 tests/ovn.at  |   4 +-
 tests/system-ovn.at   | 135 ++
 utilities/ovn-nbctl.8.xml | 119 +
 utilities/ovn-nbctl.c | 178 +
 22 files changed, 1360 insertions(+), 299 deletions(-)
 create mode 100644 lib/copp.c
 create mode 100644 lib/copp.h

-- 
2.31.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev