Re: [ovs-dev] [PATCH v3] dpif-netdev: log rxq assignment in isolated pmd
Thanks for a new version. Applied to master. BTW, few nits about patch submission for a next time: * Commonly in OVS patch subject should start with a capital letter and end with a period, i.e. 'dpif-netdev: Log ... pmd.' * Please, don't send patches in reply to the previous version. This breaks the way people manages their inbox. The only mail-list that uses this scheme is a dpdk-dev. * Few more inline. On 09.11.2019 4:11, Gowrishankar Muthukrishnan wrote: > There is no log about isolated rxq assignment in a pmd today, which > sometimes could be useful to trace rxq/pmd pinning, when debugging > with log. Ovs-appctl dpif-netdev/pmd-rxq-show reports about it > already, but logging is helpful to trace pinning in time. > > Changes: > v3: correction on pmd unref and numa_id. Change log should not be part of a commit message. It should go after the cut line. > > Reported-at: https://bugzilla.redhat.com/1728616 This issue is not public, i.e. useless. Be sure that issue is public before giving the link. > Signed-off-by: Gowrishankar Muthukrishnan > --- <-- here should be the change log. > lib/dpif-netdev.c | 4 > 1 file changed, 4 insertions(+) Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v3] dpif-netdev: log rxq assignment in isolated pmd
There is no log about isolated rxq assignment in a pmd today, which sometimes could be useful to trace rxq/pmd pinning, when debugging with log. Ovs-appctl dpif-netdev/pmd-rxq-show reports about it already, but logging is helpful to trace pinning in time. Changes: v3: correction on pmd unref and numa_id. Reported-at: https://bugzilla.redhat.com/1728616 Signed-off-by: Gowrishankar Muthukrishnan --- lib/dpif-netdev.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 4546b55e8..aeae66aea 100644 --- a/lib/dpif-netdev.c +++ b/lib/dpif-netdev.c @@ -4572,6 +4572,10 @@ rxq_scheduling(struct dp_netdev *dp, bool pinned) OVS_REQUIRES(dp->port_mutex) } else { q->pmd = pmd; pmd->isolated = true; +VLOG_INFO("Core %d on numa node %d assigned port \'%s\' " + "rx queue %d.", pmd->core_id, pmd->numa_id, + netdev_rxq_get_name(q->rx), + netdev_rxq_get_queue_id(q->rx)); dp_netdev_pmd_unref(pmd); } } else if (!pinned && q->core_id == OVS_CORE_UNSPEC) { -- 2.17.2 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev