Re: [ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.
On Mon, Aug 19, 2019 at 8:08 PM Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > From: Mark Michelson > > From: Mark Michelson > > Controller event action is leaking its genopts. This corrects the error. > > Signed-off-by: Mark Michelson > Signed-off-by: Lorenzo Bianconi > I applied this patch of this series to master. I edited the commit message as there was "From" tag at the start of the commit body. Thanks Numan > --- > lib/actions.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/actions.c b/lib/actions.c > index 81950e7df..08c589ab3 100644 > --- a/lib/actions.c > +++ b/lib/actions.c > @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, > } > > static void > -ovnact_controller_event_free(struct ovnact_controller_event *event > OVS_UNUSED) > +ovnact_controller_event_free(struct ovnact_controller_event *event) > { > +free_gen_options(event->options, event->n_options); > } > > static void > -- > 2.21.0 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.
Bleep bloop. Greetings Lorenzo Bianconi, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Lorenzo Bianconi Lines checked: 33, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH v3 ovn 1/3] OVN: Repair memory leak for OVN controller events.
From: Mark Michelson From: Mark Michelson Controller event action is leaking its genopts. This corrects the error. Signed-off-by: Mark Michelson Signed-off-by: Lorenzo Bianconi --- lib/actions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/actions.c b/lib/actions.c index 81950e7df..08c589ab3 100644 --- a/lib/actions.c +++ b/lib/actions.c @@ -1760,8 +1760,9 @@ parse_trigger_event(struct action_context *ctx, } static void -ovnact_controller_event_free(struct ovnact_controller_event *event OVS_UNUSED) +ovnact_controller_event_free(struct ovnact_controller_event *event) { +free_gen_options(event->options, event->n_options); } static void -- 2.21.0 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev