Re: [ovs-dev] [PATCH v3 ovn 6/9] northd: remove dead code in build_lrouter_nat_defrag_and_lb

2021-07-02 Thread Dumitru Ceara 
On 6/30/21 11:34 AM, Lorenzo Bianconi wrote:
> Remove if condition that is never executed in
> build_lrouter_nat_defrag_and_lb routine
> 
> Signed-off-by: Lorenzo Bianconi 
> ---

Acked-by: Dumitru Ceara 

Thanks!

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v3 ovn 6/9] northd: remove dead code in build_lrouter_nat_defrag_and_lb

2021-06-30 Thread Lorenzo Bianconi 
Remove if condition that is never executed in
build_lrouter_nat_defrag_and_lb routine

Signed-off-by: Lorenzo Bianconi 
---
 northd/ovn-northd.c | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index 2e69394b3..d1507d4b5 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -12012,13 +12012,6 @@ build_lrouter_nat_defrag_and_lb(struct ovn_datapath 
*od,
   "ip", "flags.loopback = 1; ct_dnat;");
 }
 
-/* Load balancing and packet defrag are only valid on
- * Gateway routers or router with gateway port. */
-if (!smap_get(&od->nbr->options, "chassis") && !od->l3dgw_port) {
-sset_destroy(&nat_entries);
-return;
-}
-
 build_lrouter_lb_flows(lflows, od, lbs, match);
 
 sset_destroy(&nat_entries);
-- 
2.31.1

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev