Re: [ovs-dev] [PATCH v4 0/3] Extend the CT flush with mark and labels fields

[Ilya Maximets]

On 11/28/23 07:27, Ales Musil wrote:
> 
> 
> On Mon, Nov 27, 2023 at 7:36 PM Ilya Maximets  > wrote:
> 
> On 11/16/23 16:08, Ales Musil wrote:
> > The CT flush is not capable of partial flush based
> > on the touples and zone combinations. Extend it
> > so it also accepts mark and labels. As part of this
> > series unify parsing of arguments in dpctl and ovs-ofctl
> > for the ct flush command.
> 
> Hi, Ales.  Thanks for the new version!
> 
> Are you planning to send a fix for unknown properties?
> I think, we need to get it before extending the functionality
> as we'll also need to backport it.
> 
> 
> I was under the impression that we want to do it after, my bad. I'll send a 
> fix so that this extension can be rebased on top later on.

Thanks!  I applied that separate fix and also the other set for
CT limits.  Please, rebase this patch set on top of the current
master, so we can continue from that.

BTW, there is a rebase artifact in the NEWS file in the patch #3.
And the trailing whitespace unrelated changes returned there.

Best regards, Ilya Maximets.

>  
> 
> 
> Best regards, Ilya Maximets.
> 
> >
> > Ales Musil (3):
> >   ofp-prop: Add helper for parsing and storing of ovs_u128.
> >   dpctl, ovs-ofctl: Unify parsing of ct-flush arguments.
> >   openflow: Allow CT flush to match on mark and labels.
> >
> >  NEWS                           |   4 +
> >  include/openflow/nicira-ext.h  |   4 +
> >  include/openvswitch/ofp-ct.h   |  14 ++-
> >  include/openvswitch/ofp-prop.h |   5 +
> >  lib/ct-dpif.c                  |  12 ++-
> >  lib/dpctl.c                    |  46 ++---
> >  lib/ofp-ct.c                   | 182 -
> >  lib/ofp-prop.c                 |  42 
> >  tests/ofp-print.at              |  85 
> +++
> >  tests/ovs-ofctl.at              |  42 +++-
> >  tests/system-traffic.at         | 112 
> +---
> >  utilities/ovs-ofctl.8.in        |  31 +++---
> >  utilities/ovs-ofctl.c          |  49 +++--
> >  13 files changed, 489 insertions(+), 139 deletions(-)
> >
> 
> 
> Thanks,
> Ales
> 
> -- 
> 
> Ales Musil
> 
> Senior Software Engineer - OVN Core
> 
> Red Hat EMEA 
> 
> amu...@redhat.com  
> 
> 
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 0/3] Extend the CT flush with mark and labels fields

[Ales Musil]

On Mon, Nov 27, 2023 at 7:36 PM Ilya Maximets  wrote:

> On 11/16/23 16:08, Ales Musil wrote:
> > The CT flush is not capable of partial flush based
> > on the touples and zone combinations. Extend it
> > so it also accepts mark and labels. As part of this
> > series unify parsing of arguments in dpctl and ovs-ofctl
> > for the ct flush command.
>
> Hi, Ales.  Thanks for the new version!
>
> Are you planning to send a fix for unknown properties?
> I think, we need to get it before extending the functionality
> as we'll also need to backport it.
>
>
I was under the impression that we want to do it after, my bad. I'll send a
fix so that this extension can be rebased on top later on.


>
> Best regards, Ilya Maximets.
>
> >
> > Ales Musil (3):
> >   ofp-prop: Add helper for parsing and storing of ovs_u128.
> >   dpctl, ovs-ofctl: Unify parsing of ct-flush arguments.
> >   openflow: Allow CT flush to match on mark and labels.
> >
> >  NEWS   |   4 +
> >  include/openflow/nicira-ext.h  |   4 +
> >  include/openvswitch/ofp-ct.h   |  14 ++-
> >  include/openvswitch/ofp-prop.h |   5 +
> >  lib/ct-dpif.c  |  12 ++-
> >  lib/dpctl.c|  46 ++---
> >  lib/ofp-ct.c   | 182 -
> >  lib/ofp-prop.c |  42 
> >  tests/ofp-print.at |  85 +++
> >  tests/ovs-ofctl.at |  42 +++-
> >  tests/system-traffic.at| 112 +---
> >  utilities/ovs-ofctl.8.in   |  31 +++---
> >  utilities/ovs-ofctl.c  |  49 +++--
> >  13 files changed, 489 insertions(+), 139 deletions(-)
> >
>
>
Thanks,
Ales

-- 

Ales Musil

Senior Software Engineer - OVN Core

Red Hat EMEA 

amu...@redhat.com

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v4 0/3] Extend the CT flush with mark and labels fields

[Ilya Maximets]

On 11/16/23 16:08, Ales Musil wrote:
> The CT flush is not capable of partial flush based
> on the touples and zone combinations. Extend it
> so it also accepts mark and labels. As part of this
> series unify parsing of arguments in dpctl and ovs-ofctl
> for the ct flush command.

Hi, Ales.  Thanks for the new version!

Are you planning to send a fix for unknown properties?
I think, we need to get it before extending the functionality
as we'll also need to backport it.

Best regards, Ilya Maximets.

> 
> Ales Musil (3):
>   ofp-prop: Add helper for parsing and storing of ovs_u128.
>   dpctl, ovs-ofctl: Unify parsing of ct-flush arguments.
>   openflow: Allow CT flush to match on mark and labels.
> 
>  NEWS   |   4 +
>  include/openflow/nicira-ext.h  |   4 +
>  include/openvswitch/ofp-ct.h   |  14 ++-
>  include/openvswitch/ofp-prop.h |   5 +
>  lib/ct-dpif.c  |  12 ++-
>  lib/dpctl.c|  46 ++---
>  lib/ofp-ct.c   | 182 -
>  lib/ofp-prop.c |  42 
>  tests/ofp-print.at |  85 +++
>  tests/ovs-ofctl.at |  42 +++-
>  tests/system-traffic.at| 112 +---
>  utilities/ovs-ofctl.8.in   |  31 +++---
>  utilities/ovs-ofctl.c  |  49 +++--
>  13 files changed, 489 insertions(+), 139 deletions(-)
> 

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v4 0/3] Extend the CT flush with mark and labels fields

[Ales Musil]

The CT flush is not capable of partial flush based
on the touples and zone combinations. Extend it
so it also accepts mark and labels. As part of this
series unify parsing of arguments in dpctl and ovs-ofctl
for the ct flush command.

Ales Musil (3):
  ofp-prop: Add helper for parsing and storing of ovs_u128.
  dpctl, ovs-ofctl: Unify parsing of ct-flush arguments.
  openflow: Allow CT flush to match on mark and labels.

 NEWS   |   4 +
 include/openflow/nicira-ext.h  |   4 +
 include/openvswitch/ofp-ct.h   |  14 ++-
 include/openvswitch/ofp-prop.h |   5 +
 lib/ct-dpif.c  |  12 ++-
 lib/dpctl.c|  46 ++---
 lib/ofp-ct.c   | 182 -
 lib/ofp-prop.c |  42 
 tests/ofp-print.at |  85 +++
 tests/ovs-ofctl.at |  42 +++-
 tests/system-traffic.at| 112 +---
 utilities/ovs-ofctl.8.in   |  31 +++---
 utilities/ovs-ofctl.c  |  49 +++--
 13 files changed, 489 insertions(+), 139 deletions(-)

-- 
2.41.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev