Re: [ovs-dev] [RFC 2/3] dpif-netlink: fix report_loss() message

2021-06-30 Thread Mark Gray 
On 28/05/2021 20:49, Flavio Leitner wrote:
> On Fri, Apr 30, 2021 at 11:31:28AM -0400, Mark Gray wrote:
>> Signed-off-by: Mark Gray 
> This looks like a bug fix for this commit:
> 1579cf677fcb dpif-linux: Implement the API functions to allow multiple ...
> 
> If you agree, please add the Fixes: tag.
> 
> fbl
> 

I agree. I will add the tag.

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [RFC 2/3] dpif-netlink: fix report_loss() message

2021-05-28 Thread Flavio Leitner 
On Fri, Apr 30, 2021 at 11:31:28AM -0400, Mark Gray wrote:
> Signed-off-by: Mark Gray 

This looks like a bug fix for this commit:
1579cf677fcb dpif-linux: Implement the API functions to allow multiple ...

If you agree, please add the Fixes: tag.

fbl

> ---
>  lib/dpif-netlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index 50520f8c0687..2ded5fdd01b3 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -4662,7 +4662,7 @@ report_loss(struct dpif_netlink *dpif, struct 
> dpif_channel *ch, uint32_t ch_idx,
>time_msec() - ch->last_poll);
>  }
>  
> -VLOG_WARN("%s: lost packet on port channel %u of handler %u",
> -  dpif_name(&dpif->dpif), ch_idx, handler_id);
> +VLOG_WARN("%s: lost packet on port channel %u of handler %u%s",
> +  dpif_name(&dpif->dpif), ch_idx, handler_id, ds_cstr(&s));
>  ds_destroy(&s);
>  }
> -- 
> 2.27.0
> 
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

-- 
fbl
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [RFC 2/3] dpif-netlink: fix report_loss() message

2021-04-30 Thread Mark Gray 
Signed-off-by: Mark Gray 
---
 lib/dpif-netlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 50520f8c0687..2ded5fdd01b3 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -4662,7 +4662,7 @@ report_loss(struct dpif_netlink *dpif, struct 
dpif_channel *ch, uint32_t ch_idx,
   time_msec() - ch->last_poll);
 }
 
-VLOG_WARN("%s: lost packet on port channel %u of handler %u",
-  dpif_name(&dpif->dpif), ch_idx, handler_id);
+VLOG_WARN("%s: lost packet on port channel %u of handler %u%s",
+  dpif_name(&dpif->dpif), ch_idx, handler_id, ds_cstr(&s));
 ds_destroy(&s);
 }
-- 
2.27.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev