Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] conntrack: Support global drop statistics.
Thanks Aaron
I think this is a valid error.
I had 2 patch series touching common lines from the same working branch; I
intended to check the git context boundaries, but forgot :-)
I will roll up the 2 series.
Darrell
On Wed, Jun 27, 2018 at 8:06 AM, Aaron Conole wrote:
> Hi Darrell,
>
> 0-day Robot writes:
>
> > Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out
> your patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't expecting. See the details below.
> >
> >
> > checkpatch:
> > ERROR: Too many signoffs; are you missing Co-authored-by lines?
> > Lines checked: 29, Warnings: 0, Errors: 1
>
> Sorry for the splat the misleading email. I've fixed the bot so it will
> actually print what goes wrong.
>
> In this case, it was a failure of git-am. I'm pasting it here (because
> I can read Bender's logs):
>
> fatal: sha1 information is lacking or useless (lib/conntrack.c).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 conntrack: Support global drop statistics.
> The copy of the patch that failed is found in:
>/var/lib/jenkins/jobs/upstream_build_from_pw/
> workspace/.git/rebase-apply/patch
> When you have resolved this problem, run "git am --resolved".
> If you prefer to skip this patch, run "git am --skip" instead.
> To restore the original branch and stop patching, run "git am --abort".
>
> The bot was applying your patch on top of commit sha:
> d8552339c5b0 ("AUTHORS: Add Neal Shrader")
>
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] conntrack: Support global drop statistics.
Hi Darrell,
0-day Robot writes:
> Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> ERROR: Too many signoffs; are you missing Co-authored-by lines?
> Lines checked: 29, Warnings: 0, Errors: 1
Sorry for the splat the misleading email. I've fixed the bot so it will
actually print what goes wrong.
In this case, it was a failure of git-am. I'm pasting it here (because
I can read Bender's logs):
fatal: sha1 information is lacking or useless (lib/conntrack.c).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 conntrack: Support global drop statistics.
The copy of the patch that failed is found in:
/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/.git/rebase-apply/patch
When you have resolved this problem, run "git am --resolved".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
The bot was applying your patch on top of commit sha:
d8552339c5b0 ("AUTHORS: Add Neal Shrader")
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] dpdk: Support both shared and per port mempools.
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Comment with 'xxx' marker #506 FILE: lib/netdev-dpdk.c:591: * XXX: this is a really rough method of provisioning memory. WARNING: Comment with 'xxx' marker #519 FILE: lib/netdev-dpdk.c:604: * XXX: rough estimation of number of mbufs required for this port: Lines checked: 891, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: *
0-day Robot writes: > Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out > your patch > with message ID > Thanks for your contribution. I'm disabling the distcheck output until the tests can run consistently on the system. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] dpdk: Support both shared and per port mempools.
On Wed, Jun 27, 2018 at 10:52:06AM +0100, Ian Stokes wrote:
> On 6/25/2018 7:56 PM, 0-day Robot wrote:
> >Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your
> >patch.
> >Thanks for your contribution.
> >
> >I encountered some error that I wasn't expecting. See the details below.
> >
> >
> >checkpatch:
> >== Checking d0b5c881a538 ("dpdk: Support both shared and per port
> >mempools.") ==
> >WARNING: Comment with 'xxx' marker
> >#506 FILE: lib/netdev-dpdk.c:591:
> > * XXX: this is a really rough method of provisioning memory.
> >
> >WARNING: Comment with 'xxx' marker
> >#519 FILE: lib/netdev-dpdk.c:604:
> > * XXX: rough estimation of number of mbufs required for this port:
> >
> >Lines checked: 890, Warnings: 2, Errors: 0
> >
>
> Hi Aaron,
>
> These warnings were flagged in an earlier review but I was going to leave
> the markers as there are some new features being introduced in DPDK that
> would allow us to add hugepage memory at runtime, we'll get this
> functionality if/when we move to DPDK 18.11, I feel it would warrant
> re-examining these values then as we may be able to request more accurate
> memory requirements at that point.
Not all warnings need to be fixed before applying a patch. I think that
"XXX" warnings are a good example. I still like to see checkpatch call
them out because sometimes they should be fixed before applying.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: *
Bleep bloop. Greetings Eelco Chaudron, I am a robot and I have tried out your patch with message ID Thanks for your contribution. I encountered a 'make distcheck' failure. See the details below. 2613: mcast - check multicasts to trunk ports are not duplicated ok 2614: mcast - delete the port mdb when vlan configuration changed ok 2615: mcast - delete the port mdb when port destroyed ok packet-type-aware pipeline 2616: ptap - legal flow entries in ptap bridgeok 2617: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok 2618: ptap - check decap() prerequisits ok 2619: ptap - check encap/decap VLAN tagged Ethernet frame ok 2620: ptap - L3 over patch port ok 2621: ptap - recirculate after packet_type change ok network service header (NSH) 2622: nsh - matching ok 2623: nsh - md1 encap over a veth linkok 2624: nsh - md2 encap over a veth linkok 2625: nsh - double encap over veth link using groups ok 2626: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok ## - ## ## Test results. ## ## - ## ERROR: 2183 tests were run, 2 failed unexpectedly. 347 tests were skipped. ## -- ## ## testsuite.log was created. ## ## -- ## Please send `tests/testsuite.log' and all information you think might help: To: Subject: [openvswitch 2.9.90] testsuite: 345 1074 failed You may investigate any problem if you feel able to do so, in which case the test suite provides a good starting point. Its output may be found below `tests/testsuite.dir'. make[4]: *** [check-local] Error 1 make[4]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[3]: *** [check-am] Error 2 make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[1]: *** [check] Error 2 make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make: *** [distcheck] Error 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] dpdk: Support both shared and per port mempools.
On 6/25/2018 7:56 PM, 0-day Robot wrote:
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking d0b5c881a538 ("dpdk: Support both shared and per port mempools.") ==
WARNING: Comment with 'xxx' marker
#506 FILE: lib/netdev-dpdk.c:591:
* XXX: this is a really rough method of provisioning memory.
WARNING: Comment with 'xxx' marker
#519 FILE: lib/netdev-dpdk.c:604:
* XXX: rough estimation of number of mbufs required for this port:
Lines checked: 890, Warnings: 2, Errors: 0
Hi Aaron,
These warnings were flagged in an earlier review but I was going to
leave the markers as there are some new features being introduced in
DPDK that would allow us to add hugepage memory at runtime, we'll get
this functionality if/when we move to DPDK 18.11, I feel it would
warrant re-examining these values then as we may be able to request more
accurate memory requirements at that point.
Ian
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: *
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch with message ID Thanks for your contribution. I encountered a 'make distcheck' failure. See the details below. 2613: mcast - check multicasts to trunk ports are not duplicated ok 2614: mcast - delete the port mdb when vlan configuration changed ok 2615: mcast - delete the port mdb when port destroyed ok packet-type-aware pipeline 2616: ptap - legal flow entries in ptap bridgeok 2617: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok 2618: ptap - check decap() prerequisits ok 2619: ptap - check encap/decap VLAN tagged Ethernet frame ok 2620: ptap - L3 over patch port ok 2621: ptap - recirculate after packet_type change ok network service header (NSH) 2622: nsh - matching ok 2623: nsh - md1 encap over a veth linkok 2624: nsh - md2 encap over a veth linkok 2625: nsh - double encap over veth link using groups ok 2626: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok ## - ## ## Test results. ## ## - ## ERROR: 2183 tests were run, 1 failed unexpectedly. 347 tests were skipped. ## -- ## ## testsuite.log was created. ## ## -- ## Please send `tests/testsuite.log' and all information you think might help: To: Subject: [openvswitch 2.9.90] testsuite: 454 failed You may investigate any problem if you feel able to do so, in which case the test suite provides a good starting point. Its output may be found below `tests/testsuite.dir'. make[4]: *** [check-local] Error 1 make[4]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[3]: *** [check-am] Error 2 make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[1]: *** [check] Error 2 make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make: *** [distcheck] Error 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] conntrack: Support global drop statistics.
Bleep bloop. Greetings Darrell Ball, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 29, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: AUTHORS: Update email-id of Manohar K C
0-day Robot writes: > Bleep bloop. Greetings Manohar Krishnappa Chidambaraswamy, I am a > robot and I have tried out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: No signatures found. > Lines checked: 38, Warnings: 0, Errors: 1 I've submitted a patch so that checkpatch will properly handle a line full of dashes in the commit message. Sorry for the noise. > Please check this out. If you feel there has been an error, please > email acon...@bytheb.org > > Thanks, > 0-day Robot > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: *
Bleep bloop. Greetings Manohar Krishnappa Chidambaraswamy, I am a robot and I have tried out your patch with message ID Thanks for your contribution. I encountered a 'make distcheck' failure. See the details below. 2613: mcast - check multicasts to trunk ports are not duplicated ok 2614: mcast - delete the port mdb when vlan configuration changed ok 2615: mcast - delete the port mdb when port destroyed ok packet-type-aware pipeline 2616: ptap - legal flow entries in ptap bridgeok 2617: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok 2618: ptap - check decap() prerequisits ok 2619: ptap - check encap/decap VLAN tagged Ethernet frame ok 2620: ptap - L3 over patch port ok 2621: ptap - recirculate after packet_type change ok network service header (NSH) 2622: nsh - matching ok 2623: nsh - md1 encap over a veth linkok 2624: nsh - md2 encap over a veth linkok 2625: nsh - double encap over veth link using groups ok 2626: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok ## - ## ## Test results. ## ## - ## ERROR: 2183 tests were run, 1 failed unexpectedly. 347 tests were skipped. ## -- ## ## testsuite.log was created. ## ## -- ## Please send `tests/testsuite.log' and all information you think might help: To: Subject: [openvswitch 2.9.90] testsuite: 454 failed You may investigate any problem if you feel able to do so, in which case the test suite provides a good starting point. Its output may be found below `tests/testsuite.dir'. make[4]: *** [check-local] Error 1 make[4]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[3]: *** [check-am] Error 2 make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[1]: *** [check] Error 2 make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make: *** [distcheck] Error 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: AUTHORS: Update email-id of Manohar K C
Bleep bloop. Greetings Manohar Krishnappa Chidambaraswamy, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: No signatures found. Lines checked: 38, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ofp-actions: Avoid buffer overread in BUNDLE action decoding.
Ben Pfaff writes:
> This seems to be no error at all?
:-/ This is another trigger from the subject. Sorry about that.
Now that the series is applied, I've updated the job only to use the
'-q' specifier. It shouldn't trigger again (but I'll do some testing
with it on 'dry-run mode').
> On Mon, Jun 25, 2018 at 05:31:02PM -0400, 0-day Robot wrote:
>> Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out
>> your patch.
>> Thanks for your contribution.
>>
>> I encountered some error that I wasn't expecting. See the details below.
>>
>>
>> checkpatch:
>> == Checking 8685e83b5f68 ("ofp-actions: Avoid buffer overread in
>> BUNDLE action decoding.") ==
>> Lines checked: 39, no obvious problems found
>>
>>
>> Please check this out. If you feel there has been an error, please
>> email acon...@bytheb.org
>>
>> Thanks,
>> 0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ofp-actions: Fix buffer overread in decode_LEARN_specs().
On Mon, Jun 25, 2018 at 05:01:33PM -0400, Aaron Conole wrote:
> 0-day Robot writes:
>
> > Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your
> > patch.
> > Thanks for your contribution.
> >
> > I encountered some error that I wasn't expecting. See the details below.
> >
> >
> > checkpatch:
> > == Checking 913dd37571cf ("ofp-actions: Fix buffer overread in
> > decode_LEARN_specs().") ==
> > Lines checked: 30, no obvious problems found
>
> Sorry for the noise. This will be resolved once the checkpatch change
> at https://mail.openvswitch.org/pipermail/ovs-dev/2018-June/348444.html
> gets merged (and then -q can squelch the title - the grep for 'err'
> picked up "overread" - I guess I'll be less lazy when writing the tests,
> too).
Thanks for the hint, I pushed that series.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ofp-actions: Avoid buffer overread in BUNDLE action decoding.
This seems to be no error at all?
On Mon, Jun 25, 2018 at 05:31:02PM -0400, 0-day Robot wrote:
> Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> == Checking 8685e83b5f68 ("ofp-actions: Avoid buffer overread in BUNDLE
> action decoding.") ==
> Lines checked: 39, no obvious problems found
>
>
> Please check this out. If you feel there has been an error, please email
> acon...@bytheb.org
>
> Thanks,
> 0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: *
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your patch with message ID Thanks for your contribution. I encountered a 'make distcheck' failure. See the details below. 2613: mcast - check multicasts to trunk ports are not duplicated ok 2614: mcast - delete the port mdb when vlan configuration changed ok 2615: mcast - delete the port mdb when port destroyed ok packet-type-aware pipeline 2616: ptap - legal flow entries in ptap bridgeok 2617: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok 2618: ptap - check decap() prerequisits ok 2619: ptap - check encap/decap VLAN tagged Ethernet frame ok 2620: ptap - L3 over patch port ok 2621: ptap - recirculate after packet_type change ok network service header (NSH) 2622: nsh - matching ok 2623: nsh - md1 encap over a veth linkok 2624: nsh - md2 encap over a veth linkok 2625: nsh - double encap over veth link using groups ok 2626: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok ## - ## ## Test results. ## ## - ## ERROR: 2183 tests were run, 1 failed unexpectedly. 347 tests were skipped. ## -- ## ## testsuite.log was created. ## ## -- ## Please send `tests/testsuite.log' and all information you think might help: To: Subject: [openvswitch 2.9.90] testsuite: 454 failed You may investigate any problem if you feel able to do so, in which case the test suite provides a good starting point. Its output may be found below `tests/testsuite.dir'. make[4]: *** [check-local] Error 1 make[4]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[3]: *** [check-am] Error 2 make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[1]: *** [check] Error 2 make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make: *** [distcheck] Error 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: ofp-actions: Avoid buffer overread in BUNDLE action decoding.
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking 8685e83b5f68 ("ofp-actions: Avoid buffer overread in BUNDLE action
decoding.") ==
Lines checked: 39, no obvious problems found
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ofp-actions: Fix buffer overread in decode_LEARN_specs().
0-day Robot writes:
> Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> == Checking 913dd37571cf ("ofp-actions: Fix buffer overread in
> decode_LEARN_specs().") ==
> Lines checked: 30, no obvious problems found
Sorry for the noise. This will be resolved once the checkpatch change
at https://mail.openvswitch.org/pipermail/ovs-dev/2018-June/348444.html
gets merged (and then -q can squelch the title - the grep for 'err'
picked up "overread" - I guess I'll be less lazy when writing the tests,
too).
> Please check this out. If you feel there has been an error, please email
> acon...@bytheb.org
>
> Thanks,
> 0-day Robot
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: ofp-actions: Fix buffer overread in decode_LEARN_specs().
Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking 913dd37571cf ("ofp-actions: Fix buffer overread in
decode_LEARN_specs().") ==
Lines checked: 30, no obvious problems found
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn: Allow for automatic dynamic updates of IPAM
On 06/25/2018 04:08 PM, Aaron Conole wrote:
0-day Robot writes:
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried
out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking a417a986243d ("ovn: Allow for automatic dynamic updates of IPAM") ==
WARNING: Line is 83 characters long (recommended limit is 79)
#372 FILE: ovn/northd/ovn-northd.c:1337:
if (!od->ipam_info.allocated_ipv4s &&
!od->ipam_info.ipv6_prefix_set) {
Lines checked: 694, Warnings: 1, Errors: 0
I'm thinking of turning off the line-length checks for the bot. They're
usually not something I'd seriously object over (unless it's well over
100 characters and easily split or something).
Thoughts?
I disagree. If our checkpatch utility will complain about something,
then the bot should complain about the same things.
I appreciate being called out by the bot in this case because I clearly
didn't run checkpatch before submitting my patch.
Please check this out. If you feel there has been an error, please
email acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn: Allow for automatic dynamic updates of IPAM
0-day Robot writes:
> Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried
> out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> == Checking a417a986243d ("ovn: Allow for automatic dynamic updates of IPAM")
> ==
> WARNING: Line is 83 characters long (recommended limit is 79)
> #372 FILE: ovn/northd/ovn-northd.c:1337:
> if (!od->ipam_info.allocated_ipv4s &&
> !od->ipam_info.ipv6_prefix_set) {
>
> Lines checked: 694, Warnings: 1, Errors: 0
I'm thinking of turning off the line-length checks for the bot. They're
usually not something I'd seriously object over (unless it's well over
100 characters and easily split or something).
Thoughts?
> Please check this out. If you feel there has been an error, please
> email acon...@bytheb.org
>
> Thanks,
> 0-day Robot
> ___
> dev mailing list
> d...@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: *
0-day Robot writes: > Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your > patch > with message ID > Thanks for your contribution. > > I encountered a 'make distcheck' failure. See the details below. > 2613: mcast - check multicasts to trunk ports are not duplicated ok > 2614: mcast - delete the port mdb when vlan configuration changed ok > 2615: mcast - delete the port mdb when port destroyed ok > > packet-type-aware pipeline > > 2616: ptap - legal flow entries in ptap bridgeok > 2617: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok > 2618: ptap - check decap() prerequisits ok > 2619: ptap - check encap/decap VLAN tagged Ethernet frame ok > 2620: ptap - L3 over patch port ok > 2621: ptap - recirculate after packet_type change ok > > network service header (NSH) > > 2622: nsh - matching ok > 2623: nsh - md1 encap over a veth linkok > 2624: nsh - md2 encap over a veth linkok > 2625: nsh - double encap over veth link using groups ok > 2626: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok > > ## - ## > ## Test results. ## > ## - ## > > ERROR: 2183 tests were run, > 1 failed unexpectedly. > 347 tests were skipped. > ## -- ## > ## testsuite.log was created. ## > ## -- ## > > Please send `tests/testsuite.log' and all information you think might help: > >To: >Subject: [openvswitch 2.9.90] testsuite: 454 failed > > You may investigate any problem if you feel able to do so, in which > case the test suite provides a good starting point. Its output may > be found below `tests/testsuite.dir'. > It may be time to ruminate on this test more. I've seen it fail before. Currently, RECHECK=yes when doing the make distcheck for the bot. Also, looks like I need to fix the cover-letter parsing code. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn.at: Add stateful test for ACL on port groups.
0-day Robot writes:
> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
> patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> checkpatch:
> == Checking 6cbdf56ce88d ("datapath-windows: Compute ct hash based on
> 5-tuple and zone") ==
> ERROR: Too many signoffs; are you missing Co-authored-by lines?
> Lines checked: 320, Warnings: 0, Errors: 1
Sorry for the noise. I'll debug this error.
> Please check this out. If you feel there has been an error, please
> email acon...@bytheb.org
>
> Thanks,
> 0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn.at: Add stateful test for ACL on port groups.
Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking 6cbdf56ce88d ("datapath-windows: Compute ct hash based on 5-tuple
and zone") ==
ERROR: Too many signoffs; are you missing Co-authored-by lines?
Lines checked: 320, Warnings: 0, Errors: 1
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: [ovs-dev, v2] ovn: Allow for automatic dynamic updates of IPAM
Bleep bloop. Greetings Mark Michelson, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking a417a986243d ("ovn: Allow for automatic dynamic updates of IPAM") ==
WARNING: Line is 83 characters long (recommended limit is 79)
#372 FILE: ovn/northd/ovn-northd.c:1337:
if (!od->ipam_info.allocated_ipv4s &&
!od->ipam_info.ipv6_prefix_set) {
Lines checked: 694, Warnings: 1, Errors: 0
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: *
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your patch with message ID Thanks for your contribution. I encountered a 'make distcheck' failure. See the details below. 2613: mcast - check multicasts to trunk ports are not duplicated ok 2614: mcast - delete the port mdb when vlan configuration changed ok 2615: mcast - delete the port mdb when port destroyed ok packet-type-aware pipeline 2616: ptap - legal flow entries in ptap bridgeok 2617: ptap - triangle bridge setup with L2 and L3 GRE tunnels ok 2618: ptap - check decap() prerequisits ok 2619: ptap - check encap/decap VLAN tagged Ethernet frame ok 2620: ptap - L3 over patch port ok 2621: ptap - recirculate after packet_type change ok network service header (NSH) 2622: nsh - matching ok 2623: nsh - md1 encap over a veth linkok 2624: nsh - md2 encap over a veth linkok 2625: nsh - double encap over veth link using groups ok 2626: nsh - triangle PTAP bridge setup with NSH over vxlan-gpe ok ## - ## ## Test results. ## ## - ## ERROR: 2183 tests were run, 1 failed unexpectedly. 347 tests were skipped. ## -- ## ## testsuite.log was created. ## ## -- ## Please send `tests/testsuite.log' and all information you think might help: To: Subject: [openvswitch 2.9.90] testsuite: 454 failed You may investigate any problem if you feel able to do so, in which case the test suite provides a good starting point. Its output may be found below `tests/testsuite.dir'. make[4]: *** [check-local] Error 1 make[4]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[3]: *** [check-am] Error 2 make[3]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[2]: *** [check-recursive] Error 1 make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make[1]: *** [check] Error 2 make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/openvswitch-2.9.90/_build' make: *** [distcheck] Error 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: [ovs-dev, v1] dpdk: Support both shared and per port mempools.
Bleep bloop. Greetings Ian Stokes, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
== Checking d0b5c881a538 ("dpdk: Support both shared and per port mempools.") ==
WARNING: Comment with 'xxx' marker
#506 FILE: lib/netdev-dpdk.c:591:
* XXX: this is a really rough method of provisioning memory.
WARNING: Comment with 'xxx' marker
#519 FILE: lib/netdev-dpdk.c:604:
* XXX: rough estimation of number of mbufs required for this port:
Lines checked: 890, Warnings: 2, Errors: 0
Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
Justin Pettit writes: >> On Jun 20, 2018, at 8:47 AM, Ben Pfaff wrote: >> >>> On Wed, Jun 20, 2018 at 08:20:19AM -0700, Justin Pettit wrote: >>> On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: 0-day Robot writes: > Bleep bloop. Greetings Justin Pettit, I am a robot and I have > tried out your patch > with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > == Checking ".patch" == > ERROR: Too many signoffs; are you missing Co-authored-by lines? > Lines checked: 118, Warnings: 0, Errors: 1 I'll fix the sign off check in checkpatch. It shouldn't flag on these kinds of patches. Sorry for the noise. >>> >>> No problem. Thanks for setting it up. I agree that it shouldn't flag >>> on this issue, however, the bigger concern I have is that the warning >>> seems to be separated from the file names, which is a bit confusing. >>> And, I imagine it would be very confusing if someone had multiple >>> patches flagged, since it wouldn't be clear which error list applied >>> to which patch. >> >> What file names? Sign-offs aren't associated with files. > > Sorry, I meant patch name. I'll work on the job a bit more. I've made it manually triggered. I'll try and fix a few flaws I've found (mostly false positives). Thanks for not flaming me :) > —Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
> On Jun 20, 2018, at 8:47 AM, Ben Pfaff wrote: > >> On Wed, Jun 20, 2018 at 08:20:19AM -0700, Justin Pettit wrote: >> >>> On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: >>> >>> 0-day Robot writes: >>> Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: == Checking ".patch" == ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 118, Warnings: 0, Errors: 1 >>> >>> I'll fix the sign off check in checkpatch. It shouldn't flag on these >>> kinds of patches. >>> >>> Sorry for the noise. >> >> No problem. Thanks for setting it up. I agree that it shouldn't flag >> on this issue, however, the bigger concern I have is that the warning >> seems to be separated from the file names, which is a bit confusing. >> And, I imagine it would be very confusing if someone had multiple >> patches flagged, since it wouldn't be clear which error list applied >> to which patch. > > What file names? Sign-offs aren't associated with files. Sorry, I meant patch name. —Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
On Wed, Jun 20, 2018 at 08:20:19AM -0700, Justin Pettit wrote: > > > On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: > > > > 0-day Robot writes: > > > >> Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out > >> your patch > >> with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> > >> Thanks for your contribution. > >> > >> I encountered some error that I wasn't expecting. See the details below. > >> > >> > >> checkpatch: > >> == Checking ".patch" == > >> ERROR: Too many signoffs; are you missing Co-authored-by lines? > >> Lines checked: 118, Warnings: 0, Errors: 1 > > > > I'll fix the sign off check in checkpatch. It shouldn't flag on these > > kinds of patches. > > > > Sorry for the noise. > > No problem. Thanks for setting it up. I agree that it shouldn't flag > on this issue, however, the bigger concern I have is that the warning > seems to be separated from the file names, which is a bit confusing. > And, I imagine it would be very confusing if someone had multiple > patches flagged, since it wouldn't be clear which error list applied > to which patch. What file names? Sign-offs aren't associated with files. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
> On Jun 20, 2018, at 8:15 AM, Aaron Conole wrote: > > 0-day Robot writes: > >> Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out >> your patch >> with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> >> Thanks for your contribution. >> >> I encountered some error that I wasn't expecting. See the details below. >> >> >> checkpatch: >> == Checking ".patch" == >> ERROR: Too many signoffs; are you missing Co-authored-by lines? >> Lines checked: 118, Warnings: 0, Errors: 1 > > I'll fix the sign off check in checkpatch. It shouldn't flag on these > kinds of patches. > > Sorry for the noise. No problem. Thanks for setting it up. I agree that it shouldn't flag on this issue, however, the bigger concern I have is that the warning seems to be separated from the file names, which is a bit confusing. And, I imagine it would be very confusing if someone had multiple patches flagged, since it wouldn't be clear which error list applied to which patch. --Justin ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
0-day Robot writes: > Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your > patch > with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > == Checking ".patch" == > ERROR: Too many signoffs; are you missing Co-authored-by lines? > Lines checked: 118, Warnings: 0, Errors: 1 I'll fix the sign off check in checkpatch. It shouldn't flag on these kinds of patches. Sorry for the noise. > > Please check this out. If you feel there has been an error, please email me > back. > > Thanks, > 0-day Robot > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: ...
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch with message ID <1529454160-88413-1-git-send-email-jpet...@ovn.org> Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: == Checking ".patch" == ERROR: Too many signoffs; are you missing Co-authored-by lines? Lines checked: 118, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email me back. Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: ...
Bleep bloop. Greetings Justin Pettit, I am a robot and I have tried out your patch with message ID <1529442677-70672-1-git-send-email-jpet...@ovn.org> Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Applying: datapath: Fix compiler warning for HAVE_RHEL7_MAX_MTU. Please check this out. If you feel there has been an error, please email me back. Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
On Tue, Jun 19, 2018 at 05:20:08PM -0400, 0-day Robot wrote: > Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out > your patch > with message ID > <1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com> > Thanks for your contribution. Watch out. It's a short step from "I have tried out your patch" to "Kill all humans!" ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] Automated robotic reply. Re: ...
0-day Robot writes: > Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out > your patch > with message ID > <1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com> > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > == Checking ".patch" == > WARNING: Line is 84 characters long (recommended limit is 79) > #159 FILE: lib/dpif-netdev.c:5222: > /* Flow batching should be performed only after fast-path > processing > > WARNING: Line is 93 characters long (recommended limit is 79) > #253 FILE: lib/dpif-netdev.c:5485: > dp_netdev_queue_batches(map->packet, map->flow, map->tcp_flags, > batches, &n_batches); > > Lines checked: 265, Warnings: 2, Errors: 0 > > > Please check this out. If you feel there has been an error, please email me > back. Oops. I need to update the template. Please don't reply to the bot - all messages for it go to the bit bucket. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] Automated robotic reply. Re: ...
Bleep bloop. Greetings Vishal Deep Ajmera, I am a robot and I have tried out your patch with message ID <1529202111-20855-1-git-send-email-vishal.deep.ajm...@ericsson.com> Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: == Checking ".patch" == WARNING: Line is 84 characters long (recommended limit is 79) #159 FILE: lib/dpif-netdev.c:5222: /* Flow batching should be performed only after fast-path processing WARNING: Line is 93 characters long (recommended limit is 79) #253 FILE: lib/dpif-netdev.c:5485: dp_netdev_queue_batches(map->packet, map->flow, map->tcp_flags, batches, &n_batches); Lines checked: 265, Warnings: 2, Errors: 0 Please check this out. If you feel there has been an error, please email me back. Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
