Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
Bleep bloop. Greetings Matthias May via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author should not be mailing list. Lines checked: 47, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
On 14/02/2019 11:59, 0-day Robot wrote: > Bleep bloop. Greetings Matthias May via dev, I am a robot and I have tried > out your patch. > Thanks for your contribution. > > I encountered some error that I wasn't expecting. See the details below. > > > checkpatch: > ERROR: Author should not be mailing list. > Lines checked: 47, Warnings: 0, Errors: 1 > > > Please check this out. If you feel there has been an error, please email > acon...@bytheb.org > > Thanks, > 0-day Robot > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > What is this supposed to mean? Is the Signed-off-by not enough? BR Matthias ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
Hi Ben, This is another patch with From: field altered to be ovs-dev@openvswitch.org. [...] From: Matthias May via dev Reply-To: Matthias May If the patch gets applied as is, the commit's Author will have the wrong email. Just FYI because before Sriharsha and Neal had the same issue and we haven't identified the root cause back then. Matthias, could you describe to where exactly you sent out the patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something else? Thanks, fbl On Thu, Feb 14, 2019 at 12:18:11PM +0100, Matthias May via dev wrote: > On 14/02/2019 11:59, 0-day Robot wrote: > > Bleep bloop. Greetings Matthias May via dev, I am a robot and I have tried > > out your patch. > > Thanks for your contribution. > > > > I encountered some error that I wasn't expecting. See the details below. > > > > > > checkpatch: > > ERROR: Author should not be mailing list. > > Lines checked: 47, Warnings: 0, Errors: 1 > > > > > > Please check this out. If you feel there has been an error, please email > > acon...@bytheb.org > > > > Thanks, > > 0-day Robot > > ___ > > dev mailing list > > d...@openvswitch.org > > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > > > > What is this supposed to mean? > Is the Signed-off-by not enough? > > BR > Matthias > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
On 14/02/2019 14:34, Flavio Leitner wrote: > > Hi Ben, > > This is another patch with From: field altered to be > ovs-dev@openvswitch.org. > > [...] > From: Matthias May via dev > Reply-To: Matthias May > > If the patch gets applied as is, the commit's Author will have the > wrong email. > > Just FYI because before Sriharsha and Neal had the same issue and we > haven't identified the root cause back then. > > Matthias, could you describe to where exactly you sent out the > patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something > else? > > Thanks, > fbl > > > On Thu, Feb 14, 2019 at 12:18:11PM +0100, Matthias May via dev wrote: >> On 14/02/2019 11:59, 0-day Robot wrote: >>> Bleep bloop. Greetings Matthias May via dev, I am a robot and I have tried >>> out your patch. >>> Thanks for your contribution. >>> >>> I encountered some error that I wasn't expecting. See the details below. >>> >>> >>> checkpatch: >>> ERROR: Author should not be mailing list. >>> Lines checked: 47, Warnings: 0, Errors: 1 >>> >>> >>> Please check this out. If you feel there has been an error, please email >>> acon...@bytheb.org >>> >>> Thanks, >>> 0-day Robot >>> ___ >>> dev mailing list >>> d...@openvswitch.org >>> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >>> >> >> What is this supposed to mean? >> Is the Signed-off-by not enough? >> >> BR >> Matthias >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev > Hi Flavio Some info: * git version 2.20.1 * (Reproduced) trace of what I entered: ``` maym@CHD500279:~/git/ovs$ git send-email send-email/ --no-chain-reply send-email/0001-rstp-add-ability-to-receive-VLAN-tagged-BPDUs.patch To whom should the emails be sent (if anyone)? ovs-dev@openvswitch.org Message-ID to be used as In-Reply-To for the first email (if any)? (mbox) Adding cc: Matthias May from line 'From: Matthias May ' (body) Adding cc: Matthias May from line 'Signed-off-by: Matthias May ' From: Matthias May To: ovs-dev@openvswitch.org Cc: Matthias May Subject: [PATCH] rstp: add ability to receive VLAN-tagged BPDUs Date: Thu, 14 Feb 2019 15:01:34 +0100 Message-Id: <20190214140134.16754-1-matthias@neratec.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Cc list above has been expanded by additional addresses found in the patch commit message. By default send-email prompts before sending whenever this occurs. This behavior is controlled by the sendemail.confirm configuration setting. For additional information, run 'git send-email --help'. To retain the current behavior, but squelch this message, run 'git config --global sendemail.confirm auto'. Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y ``` This obviously has a different Message-Id then the mail sent before. BR Matthias ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
On 14/02/2019 14:34, Flavio Leitner wrote: > > Hi Ben, > > This is another patch with From: field altered to be > ovs-dev@openvswitch.org. > > [...] > From: Matthias May via dev > Reply-To: Matthias May > > If the patch gets applied as is, the commit's Author will have the > wrong email. > > Just FYI because before Sriharsha and Neal had the same issue and we > haven't identified the root cause back then. > > Matthias, could you describe to where exactly you sent out the > patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something > else? > > Thanks, > fbl > > *thread snipped* Maybe this is related to the SRS settings on mailman. Looks to me a bit like "munge" is used instead of "wrap". BR Matthias ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
On Thu, Feb 14, 2019 at 03:14:26PM +0100, Matthias May wrote: > On 14/02/2019 14:34, Flavio Leitner wrote: > > > > Hi Ben, > > > > This is another patch with From: field altered to be > > ovs-dev@openvswitch.org. > > > > [...] > > From: Matthias May via dev > > Reply-To: Matthias May > > > > If the patch gets applied as is, the commit's Author will have the > > wrong email. > > > > Just FYI because before Sriharsha and Neal had the same issue and we > > haven't identified the root cause back then. > > > > Matthias, could you describe to where exactly you sent out the > > patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something > > else? > > > > Thanks, > > fbl > > > > > *thread snipped* > Maybe this is related to the SRS settings on mailman. > Looks to me a bit like "munge" is used instead of "wrap". I guess that you're talking about the mailman setting for "from_is_list (general): Replace the From: header address with the list's posting address to mitigate issues stemming from the original From: domain's DMARC or similar policies." This is set to "no", to avoid changing From: addresses at all. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
On Thu, Feb 14, 2019 at 03:06:33PM +0100, Matthias May via dev wrote: > On 14/02/2019 14:34, Flavio Leitner wrote: > > Matthias, could you describe to where exactly you sent out the > > patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something > > else? > Some info: > * git version 2.20.1 > * (Reproduced) trace of what I entered: > ``` > maym@CHD500279:~/git/ovs$ git send-email send-email/ --no-chain-reply > send-email/0001-rstp-add-ability-to-receive-VLAN-tagged-BPDUs.patch > To whom should the emails be sent (if anyone)? ovs-dev@openvswitch.org > > Message-ID to be used as In-Reply-To for the first email (if any)? > > (mbox) Adding cc: Matthias May from line 'From: > Matthias May ' > (body) Adding cc: Matthias May from line > 'Signed-off-by: Matthias May ' > > From: Matthias May > To: ovs-dev@openvswitch.org > Cc: Matthias May > Subject: [PATCH] rstp: add ability to receive VLAN-tagged BPDUs > Date: Thu, 14 Feb 2019 15:01:34 +0100 > Message-Id: <20190214140134.16754-1-matthias@neratec.com> > X-Mailer: git-send-email 2.20.1 > MIME-Version: 1.0 > Content-Transfer-Encoding: 8bit > > The Cc list above has been expanded by additional > addresses found in the patch commit message. By default > send-email prompts before sending whenever this occurs. > This behavior is controlled by the sendemail.confirm > configuration setting. > > For additional information, run 'git send-email --help'. > To retain the current behavior, but squelch this message, > run 'git config --global sendemail.confirm auto'. > > Send this email? ([y]es|[n]o|[e]dit|[q]uit|[a]ll): y > > ``` > > This obviously has a different Message-Id then the mail sent before. Do you mind to send the same patch to d...@openvswitch.org to see if that happens again? I don't know how the list is configured but so far it only happened with ovs-dev@ and not with dev@. Thanks, fbl ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
Bleep bloop. Greetings Matthias May via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author should not be mailing list. Lines checked: 50, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] rstp: add ability to receive VLAN-tagged BPDUs
On 14/02/2019 16:51, Ben Pfaff wrote: > On Thu, Feb 14, 2019 at 03:14:26PM +0100, Matthias May wrote: >> On 14/02/2019 14:34, Flavio Leitner wrote: >>> >>> Hi Ben, >>> >>> This is another patch with From: field altered to be >>> ovs-dev@openvswitch.org. >>> >>> [...] >>> From: Matthias May via dev >>> Reply-To: Matthias May >>> >>> If the patch gets applied as is, the commit's Author will have the >>> wrong email. >>> >>> Just FYI because before Sriharsha and Neal had the same issue and we >>> haven't identified the root cause back then. >>> >>> Matthias, could you describe to where exactly you sent out the >>> patch? ovs-dev@openvswitch.org or d...@openvswitch.org or something >>> else? >>> >>> Thanks, >>> fbl >>> >>> >> *thread snipped* >> Maybe this is related to the SRS settings on mailman. >> Looks to me a bit like "munge" is used instead of "wrap". > > I guess that you're talking about the mailman setting for "from_is_list > (general): Replace the From: header address with the list's posting > address to mitigate issues stemming from the original From: domain's > DMARC or similar policies." > > This is set to "no", to avoid changing From: addresses at all. > Hi Flavio, Ben Sending the mail via dev instead of ovs-dev didn't seem to make a difference. I looked at the DMARC entry of neratec.com https://mxtoolbox.com/SuperTool.aspx?action=dmarc%3aneratec.com&run=toolpage The policy is set to quarantine. I went back in the archive and checked the other occurrences of the "Author should not be mailing list". All of the domains involved have their policy set to "quarantine". So I guess this is the root cause. I seems that the used mailman is on version 2.1.12 According to https://wiki.list.org/DEV/DMARC starting with 2.1.16/18 there are more options to handle this. Maybe it's time to update? BR Matthias ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
