Re: [ovs-dev] [PATCH] Testing: Introduce "bring your own lab" as an additional test option
"Stokes, Ian" writes: >> Two big changes are announced here, and the first pertains to >> allowing other developers and labs to report patch status in the >> ozlabs patchwork UI to assist maintainers making decisions on >> patch inclusion. >> >> To make this as easy as possible, the robot will take a known form >> of email sent to the ovs-bu...@openvswitch.org mailing list and >> push the information into patchwork. This information can be browsed >> either via the web UI or programmatically via the checks API. >> >> The second change is to de-emphasize the use of Travis-CI as a project >> wide resource. Travis-CI might still be useful for individual developers >> testing small patches, but can no longer fulfill the role of project-wide >> continuous integration service. Remove the badge from the front page, and >> note the other CI services that OVS supports. Rather than completely drop >> all references to travis, simply emphasize using GitHub Actions as the >> preferred CI solution. >> > > Hi Aaron, thanks for driving this. A few comments below but overall agree > with this process. > >> Signed-off-by: Aaron Conole >> Refs: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384040.html >> --- >> .../contributing/submitting-patches.rst | 8 +- >> Documentation/topics/testing.rst | 122 -- >> NEWS | 3 + >> README.rst| 2 - >> 4 files changed, 90 insertions(+), 45 deletions(-) >> >> diff --git a/Documentation/internals/contributing/submitting-patches.rst >> b/Documentation/internals/contributing/submitting-patches.rst >> index 4a6780371d..a6a10f8d89 100644 >> --- a/Documentation/internals/contributing/submitting-patches.rst >> +++ b/Documentation/internals/contributing/submitting-patches.rst >> @@ -68,10 +68,10 @@ Testing is also important: >>feature. A bug fix patch should preferably add a test that would >>fail if the bug recurs. >> >> -If you are using GitHub, then you may utilize the travis-ci.org and the >> GitHub >> -Actions CI build systems. They will run some of the above tests >> automatically >> -when you push changes to your repository. See the "Continuous Integration >> with >> -Travis-CI" in :doc:`/topics/testing` for details on how to set it up. >> +If you are using GitHub, then you may utilize the the GitHub Actions CI >> build >> +systems. They will run some of the above tests automatically when you push >> +changes to your repository. See the "Continuous Integration" section in >> +:doc:`/topics/testing` for details on continuous integration. >> >> Email Subject >> - >> diff --git a/Documentation/topics/testing.rst >> b/Documentation/topics/testing.rst >> index 951fe9e851..7e0ced8855 100644 >> --- a/Documentation/topics/testing.rst >> +++ b/Documentation/topics/testing.rst >> @@ -416,45 +416,89 @@ You should invoke scan-view to view analysis results. >> The last line of output >> from ``clang-analyze`` will list the command (containing results directory) >> that you should invoke to view the results on a browser. >> >> -Continuous Integration with Travis CI >> -- >> - >> -A .travis.yml file is provided to automatically build Open vSwitch with >> various >> -build configurations and run the testsuite using Travis CI. Builds will be >> -performed with gcc, sparse and clang with the -Werror compiler flag >> included, >> -therefore the build will fail if a new warning has been introduced. >> - >> -The CI build is triggered via git push (regardless of the specific branch) >> or >> -pull request against any Open vSwitch GitHub repository that is linked to >> -travis-ci. >> - >> -Instructions to setup travis-ci for your GitHub repository: >> - >> -1. Go to https://travis-ci.org/ and sign in using your GitHub ID. >> -2. Go to the "Repositories" tab and enable the ovs repository. You may >> disable >> - builds for pushes or pull requests. >> -3. In order to avoid forks sending build failures to the upstream mailing >> list, >> - the notification email recipient is encrypted. If you want to receive >> email >> - notification for build failures, replace the encrypted string: >> - >> - 1. Install the travis-ci CLI (Requires ruby >=2.0): gem install travis >> - 2. In your Open vSwitch repository: travis encrypt myl...@mydomain.org >> - 3. Add/replace the notifications section in .travis.yml and fill in the >> - secure string as returned by travis encrypt:: >> - >> - notifications: >> -email: >> - recipients: >> -- secure: "." >> - >> - .. note:: >> -You may remove/omit the notifications section to fall back to default >> -notification behaviour which is to send an email directly to the author >> and >> -committer of the failing commit. Note that the email is only sent if the >> -author/committer have com
Re: [ovs-dev] [PATCH] Testing: Introduce "bring your own lab" as an additional test option
> Two big changes are announced here, and the first pertains to > allowing other developers and labs to report patch status in the > ozlabs patchwork UI to assist maintainers making decisions on > patch inclusion. > > To make this as easy as possible, the robot will take a known form > of email sent to the ovs-bu...@openvswitch.org mailing list and > push the information into patchwork. This information can be browsed > either via the web UI or programmatically via the checks API. > > The second change is to de-emphasize the use of Travis-CI as a project > wide resource. Travis-CI might still be useful for individual developers > testing small patches, but can no longer fulfill the role of project-wide > continuous integration service. Remove the badge from the front page, and > note the other CI services that OVS supports. Rather than completely drop > all references to travis, simply emphasize using GitHub Actions as the > preferred CI solution. > Hi Aaron, thanks for driving this. A few comments below but overall agree with this process. > Signed-off-by: Aaron Conole > Refs: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384040.html > --- > .../contributing/submitting-patches.rst | 8 +- > Documentation/topics/testing.rst | 122 -- > NEWS | 3 + > README.rst| 2 - > 4 files changed, 90 insertions(+), 45 deletions(-) > > diff --git a/Documentation/internals/contributing/submitting-patches.rst > b/Documentation/internals/contributing/submitting-patches.rst > index 4a6780371d..a6a10f8d89 100644 > --- a/Documentation/internals/contributing/submitting-patches.rst > +++ b/Documentation/internals/contributing/submitting-patches.rst > @@ -68,10 +68,10 @@ Testing is also important: >feature. A bug fix patch should preferably add a test that would >fail if the bug recurs. > > -If you are using GitHub, then you may utilize the travis-ci.org and the > GitHub > -Actions CI build systems. They will run some of the above tests > automatically > -when you push changes to your repository. See the "Continuous Integration > with > -Travis-CI" in :doc:`/topics/testing` for details on how to set it up. > +If you are using GitHub, then you may utilize the the GitHub Actions CI build > +systems. They will run some of the above tests automatically when you push > +changes to your repository. See the "Continuous Integration" section in > +:doc:`/topics/testing` for details on continuous integration. > > Email Subject > - > diff --git a/Documentation/topics/testing.rst > b/Documentation/topics/testing.rst > index 951fe9e851..7e0ced8855 100644 > --- a/Documentation/topics/testing.rst > +++ b/Documentation/topics/testing.rst > @@ -416,45 +416,89 @@ You should invoke scan-view to view analysis results. > The last line of output > from ``clang-analyze`` will list the command (containing results directory) > that you should invoke to view the results on a browser. > > -Continuous Integration with Travis CI > -- > - > -A .travis.yml file is provided to automatically build Open vSwitch with > various > -build configurations and run the testsuite using Travis CI. Builds will be > -performed with gcc, sparse and clang with the -Werror compiler flag included, > -therefore the build will fail if a new warning has been introduced. > - > -The CI build is triggered via git push (regardless of the specific branch) or > -pull request against any Open vSwitch GitHub repository that is linked to > -travis-ci. > - > -Instructions to setup travis-ci for your GitHub repository: > - > -1. Go to https://travis-ci.org/ and sign in using your GitHub ID. > -2. Go to the "Repositories" tab and enable the ovs repository. You may > disable > - builds for pushes or pull requests. > -3. In order to avoid forks sending build failures to the upstream mailing > list, > - the notification email recipient is encrypted. If you want to receive > email > - notification for build failures, replace the encrypted string: > - > - 1. Install the travis-ci CLI (Requires ruby >=2.0): gem install travis > - 2. In your Open vSwitch repository: travis encrypt myl...@mydomain.org > - 3. Add/replace the notifications section in .travis.yml and fill in the > - secure string as returned by travis encrypt:: > - > - notifications: > -email: > - recipients: > -- secure: "." > - > - .. note:: > -You may remove/omit the notifications section to fall back to default > -notification behaviour which is to send an email directly to the author > and > -committer of the failing commit. Note that the email is only sent if the > -author/committer have commit rights for the particular GitHub repository. > - > -4. Pushing a commit to the repository which breaks the build or the > - testsuite wil
Re: [ovs-dev] [PATCH] Testing: Introduce "bring your own lab" as an additional test option
Bleep bloop. Greetings Aaron Conole, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 81 characters long (recommended limit is 79) #162 FILE: Documentation/topics/testing.rst:491: on the outcome of the test. This value is case-sensitive. PATCHID should be the WARNING: Line is 82 characters long (recommended limit is 79) #163 FILE: Documentation/topics/testing.rst:492: patch for which the test was executed, and ONE LINE DESCRIPTION should be a simple WARNING: Line is 100 characters long (recommended limit is 79) #174 FILE: Documentation/topics/testing.rst:503: Subject: |success| pw1497375 [ovs-dev] [PATCH v2] checkpatch: Ignore macro definitions of FOR_EACH Lines checked: 214, Warnings: 3, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
