Re: [ovs-dev] [PATCH] ovn-northd: Add flows in DHCP_OPTIONS pipeline to support renew requests
On Wed, Jan 25, 2017 at 1:40 AM, Russell Bryant wrote: > > > On Tue, Jan 24, 2017 at 1:58 PM, Numan Siddique > wrote: > >> ovn-northd adds the flows to send the DHCPv4 packets to ovn-controller >> only with the match ip4.src = 0.0.0.0 and ip4.dst = 255.255.255.255. >> >> When a DHCPv4 lease is about to expire, before sending a DHCPDISCOVER >> packet, the client can send a DHCPREQUEST packet to renew its ip >> with ip4.src set to its offered ip and ip4.dst set to the DHCP server >> ip or broadcast ip. >> >> This patch supports this missing scenario by adding the necessary >> flows in DHCP_OPTIONS ingress pipeline. >> >> Signed-off-by: Numan Siddique > > > Thanks for working on this, Numan! > > I see some DHCP test cases in tests/ovn.at. Could you look at extending > those to cover this case as well? > Thanks for the review. Done. I just posted v2 Numan > Thanks, > > -- > Russell Bryant > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH] ovn-northd: Add flows in DHCP_OPTIONS pipeline to support renew requests
On Tue, Jan 24, 2017 at 1:58 PM, Numan Siddique wrote: > ovn-northd adds the flows to send the DHCPv4 packets to ovn-controller > only with the match ip4.src = 0.0.0.0 and ip4.dst = 255.255.255.255. > > When a DHCPv4 lease is about to expire, before sending a DHCPDISCOVER > packet, the client can send a DHCPREQUEST packet to renew its ip > with ip4.src set to its offered ip and ip4.dst set to the DHCP server > ip or broadcast ip. > > This patch supports this missing scenario by adding the necessary > flows in DHCP_OPTIONS ingress pipeline. > > Signed-off-by: Numan Siddique Thanks for working on this, Numan! I see some DHCP test cases in tests/ovn.at. Could you look at extending those to cover this case as well? Thanks, -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
