Re: [ovs-dev] [PATCH branch-2.12] ovn-controller: Add missing port group lflow references.
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Han Zhou Lines checked: 232, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH branch-2.12] ovn-controller: Add missing port group lflow references.
On Tue, Dec 03, 2019 at 10:56:54AM +0100, Dumitru Ceara wrote: > The commit that adds incremental processing for port-group changes > doesn't store logical flow references for port groups. If a port group > is updated (e.g., a port is added) no logical flow recalculation will be > performed. > > To fix this, when parsing the flow expression also store the referenced > port groups and bind them to the logical flows that depend on them. If > the port group is updated then the logical flows referring them will > also be reinstalled. > > Reported-by: Daniel Alvarez > Reported-at: https://bugzilla.redhat.com/1778164 > CC: Han Zhou > Fixes: 978f5e90af0a ("ovn-controller: Incremental processing for port-group > changes.") > Tested-By: Daniel Alvarez > Signed-off-by: Dumitru Ceara > Signed-off-by: Han Zhou > > (cherry picked from ovn commit bbcac48d443e98cbe47d3941f7e192c9c3443cb5) Thanks, applied to branch-2.12. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH branch-2.12] ovn-controller: Add missing port group lflow references.
On Tue, Dec 3, 2019 at 8:07 PM Ben Pfaff wrote: > > On Tue, Dec 03, 2019 at 10:56:54AM +0100, Dumitru Ceara wrote: > > The commit that adds incremental processing for port-group changes > > doesn't store logical flow references for port groups. If a port group > > is updated (e.g., a port is added) no logical flow recalculation will be > > performed. > > > > To fix this, when parsing the flow expression also store the referenced > > port groups and bind them to the logical flows that depend on them. If > > the port group is updated then the logical flows referring them will > > also be reinstalled. > > > > Reported-by: Daniel Alvarez > > Reported-at: https://bugzilla.redhat.com/1778164 > > CC: Han Zhou > > Fixes: 978f5e90af0a ("ovn-controller: Incremental processing for port-group > > changes.") > > Tested-By: Daniel Alvarez > > Signed-off-by: Dumitru Ceara > > Signed-off-by: Han Zhou > > > > (cherry picked from ovn commit bbcac48d443e98cbe47d3941f7e192c9c3443cb5) > > Thanks, applied to branch-2.12. > Thanks! ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev