Re: [ovs-dev] [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to the header
On Mon, 6 Feb 2023 18:13:12 +0200 Andy Shevchenko wrote: > +static inline bool string_is_valid(const char *s, int len) > +{ > + return memchr(s, '\0', len) ? true : false; > +} I was tempted to suggest adding a kdoc, but perhaps the function doesn't have an obvious enough name? Maybe we should call the helper string_is_terminated(), instead? ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH net-next v2 1/3] string_helpers: Move string_is_valid() to the header
On Wed, Feb 8, 2023 at 6:29 AM Jakub Kicinski wrote: > On Mon, 6 Feb 2023 18:13:12 +0200 Andy Shevchenko wrote: > > +static inline bool string_is_valid(const char *s, int len) > > +{ > > + return memchr(s, '\0', len) ? true : false; > > +} > > I was tempted to suggest adding a kdoc, but perhaps the function > doesn't have an obvious enough name? Maybe we should call the helper > string_is_terminated(), instead? Sure. -- With Best Regards, Andy Shevchenko ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev