On Mon, Jul 29, 2019 at 5:05 PM 0-day Robot wrote:
>
> Bleep bloop. Greetings Han Zhou, I am a robot and I have tried out your
patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting. See the details below.
>
>
> build:
> depbase=`echo controller/ofctrl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./ovs/include -I
./ovs/include -I ./ovs/lib -I ./ovs/lib -I ./ovs -I ./ovs -I ./lib -I ./lib
-Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
-Wshadow -Werror -Werror -g -O2 -MT controller/ofctrl.o -MD -MP -MF
$depbase.Tpo -c -o controller/ofctrl.o controller/ofctrl.c &&\
> mv -f $depbase.Tpo $depbase.Po
> depbase=`echo controller/pinctrl.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./ovs/include -I
./ovs/include -I ./ovs/lib -I ./ovs/lib -I ./ovs -I ./ovs -I ./lib -I ./lib
-Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
-Wshadow -Werror -Werror -g -O2 -MT controller/pinctrl.o -MD -MP -MF
$depbase.Tpo -c -o controller/pinctrl.o controller/pinctrl.c &&\
> mv -f $depbase.Tpo $depbase.Po
> depbase=`echo controller/patch.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./ovs/include -I
./ovs/include -I ./ovs/lib -I ./ovs/lib -I ./ovs -I ./ovs -I ./lib -I ./lib
-Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
-Wshadow -Werror -Werror -g -O2 -MT controller/patch.o -MD -MP -MF
$depbase.Tpo -c -o controller/patch.o controller/patch.c &&\
> mv -f $depbase.Tpo $depbase.Po
> depbase=`echo controller/ovn-controller.o | sed
's|[^/]*$|.deps/&|;s|\.o$||'`;\
> gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./ovs/include -I
./ovs/include -I ./ovs/lib -I ./ovs/lib -I ./ovs -I ./ovs -I ./lib -I ./lib
-Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith
-Wformat -Wformat-security -Wswitch-enum -Wunused-parameter
-Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition
-Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing
-Wshadow -Werror -Werror -g -O2 -MT controller/ovn-controller.o -MD -MP
-MF $depbase.Tpo -c -o controller/ovn-controller.o
controller/ovn-controller.c &&\
> mv -f $depbase.Tpo $depbase.Po
> controller/ovn-controller.c: In function ‘main’:
> controller/ovn-controller.c:2001:33: error: implicit declaration of
function ‘engine_set_abort_recompute’
[-Werror=implicit-function-declaration]
> engine_set_abort_recompute(true);
> ^
> controller/ovn-controller.c:2002:48: error: void value not ignored as it
ought to be
> engine_aborted =
engine_run(&en_flow_output,
> ^
> cc1: all warnings being treated as errors
> make[2]: *** [controller/ovn-controller.o] Error 1
> make[2]: Leaving directory
`/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/OVN'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory
`/var/lib/jenkins/jobs/upstream_build_from_pw/workspace/OVN'
> make: *** [all] Error 2
>
>
> Please check this out. If you feel there has been an error, please email
acon...@bytheb.org
>
> Thanks,
> 0-day Robot
I was resending the patch that has been sent over OVS repo. However, the
compile failed due to the header file path problem:
-#include "ovn/lib/inc-proc-eng.h"
+#include "lib/inc-proc-eng.h"
I updated with a new patch series:
https://patchwork.ozlabs.org/project/openvswitch/list/?series=122106
Thanks,
Han
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
