Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings
On Thu, Oct 24, 2019 at 10:56 PM Numan Siddique wrote: > > > > On Fri, Oct 25, 2019, 7:59 AM Numan Siddique wrote: >> >> >> >> On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote: >>> >>> This log message was introduced in commit 5344f24ecb. It may be more >>> appropriate as a deubg message, but as a warning, it breaks this test suite. >>> Filtering it out of the logs gets these tests passing for me. >>> >>> A sample of the messages encountered in a test run are: >>> >>> 2019-10-25T01:06:53.026Z|00010|chassis|WARN|Could not find Chassis : stored >>> (hv1) ovs (hv1) >>> 2019-10-25T01:06:53.026Z|00011|chassis|WARN|Could not find Chassis : stored >>> (hv1) ovs (hv1) >>> 2019-10-25T01:06:53.026Z|00013|chassis|WARN|Could not find Chassis : stored >>> (hv1) ovs (hv1) >>> 2019-10-25T01:06:53.026Z|00014|chassis|WARN|Could not find Chassis : stored >>> (hv1) ovs (hv1) >> >> >> Hi Russell, >> >> Could you please provide the signed off tag > > > Acked-by: Numan Siddique > > Forgot that will take care of the tag while committing. Thanks for the review! Sorry I didn't see that you had submitted the same patch earlier. I think I'm not going to apply this though in favor of just removing this log message, since I don't think it's really helpful, at least as a warning. -- Russell Bryant ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings
On Fri, Oct 25, 2019, 7:59 AM Numan Siddique wrote: > > > On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote: > >> This log message was introduced in commit 5344f24ecb. It may be more >> appropriate as a deubg message, but as a warning, it breaks this test >> suite. >> Filtering it out of the logs gets these tests passing for me. >> >> A sample of the messages encountered in a test run are: >> >> 2019-10-25T01:06:53.026Z|00010|chassis|WARN|Could not find Chassis : >> stored (hv1) ovs (hv1) >> 2019-10-25T01:06:53.026Z|00011|chassis|WARN|Could not find Chassis : >> stored (hv1) ovs (hv1) >> 2019-10-25T01:06:53.026Z|00013|chassis|WARN|Could not find Chassis : >> stored (hv1) ovs (hv1) >> 2019-10-25T01:06:53.026Z|00014|chassis|WARN|Could not find Chassis : >> stored (hv1) ovs (hv1) >> > > Hi Russell, > > Could you please provide the signed off tag > Acked-by: Numan Siddique Forgot that will take care of the tag while committing. Thanks Numan > Thanks > > --- >> tests/system-ovn.at | 33 ++--- >> 1 file changed, 22 insertions(+), 11 deletions(-) >> >> diff --git a/tests/system-ovn.at b/tests/system-ovn.at >> index f88ad31e4..d6ec19bab 100644 >> --- a/tests/system-ovn.at >> +++ b/tests/system-ovn.at >> @@ -173,7 +173,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- 2 LRs connected via LS, gateway router, easy SNAT]) >> @@ -283,7 +284,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- multiple gateway routers, SNAT and DNAT]) >> @@ -503,7 +505,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- load-balancing]) >> @@ -650,7 +653,8 @@ as northd >> OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> -OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d"]) >> +OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- load-balancing - same subnet.]) >> @@ -757,7 +761,8 @@ as northd >> OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> -OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d"]) >> +OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- load balancing in gateway router]) >> @@ -908,7 +913,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- multiple gateway routers, load-balancing]) >> @@ -1077,7 +1083,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- load balancing in router with gateway router port]) >> @@ -1218,7 +1225,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- DNAT and SNAT on distributed router - N/S]) >> @@ -1367,7 +1375,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- DNAT and SNAT on distributed router - E/W]) >> @@ -1544,7 +1553,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> >> AT_SETUP([ovn -- 2 LSs IGMP]) >> @@ -1663,5 +1673,6 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) >> >> as >> OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d >> -/connection dropped.*/d"]) >> +/connection dropped.*/d >> +/Could not find Chassis.*/d"]) >> AT_CLEANUP >> -- >> 2.21.0 >> >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings
On Fri, Oct 25, 2019, 6:56 AM Russell Bryant wrote: > This log message was introduced in commit 5344f24ecb. It may be more > appropriate as a deubg message, but as a warning, it breaks this test > suite. > Filtering it out of the logs gets these tests passing for me. > > A sample of the messages encountered in a test run are: > > 2019-10-25T01:06:53.026Z|00010|chassis|WARN|Could not find Chassis : > stored (hv1) ovs (hv1) > 2019-10-25T01:06:53.026Z|00011|chassis|WARN|Could not find Chassis : > stored (hv1) ovs (hv1) > 2019-10-25T01:06:53.026Z|00013|chassis|WARN|Could not find Chassis : > stored (hv1) ovs (hv1) > 2019-10-25T01:06:53.026Z|00014|chassis|WARN|Could not find Chassis : > stored (hv1) ovs (hv1) > Hi Russell, Could you please provide the signed off tag. Thanks --- > tests/system-ovn.at | 33 ++--- > 1 file changed, 22 insertions(+), 11 deletions(-) > > diff --git a/tests/system-ovn.at b/tests/system-ovn.at > index f88ad31e4..d6ec19bab 100644 > --- a/tests/system-ovn.at > +++ b/tests/system-ovn.at > @@ -173,7 +173,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- 2 LRs connected via LS, gateway router, easy SNAT]) > @@ -283,7 +284,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- multiple gateway routers, SNAT and DNAT]) > @@ -503,7 +505,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- load-balancing]) > @@ -650,7 +653,8 @@ as northd > OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > -OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d"]) > +OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- load-balancing - same subnet.]) > @@ -757,7 +761,8 @@ as northd > OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > -OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d"]) > +OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- load balancing in gateway router]) > @@ -908,7 +913,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- multiple gateway routers, load-balancing]) > @@ -1077,7 +1083,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- load balancing in router with gateway router port]) > @@ -1218,7 +1225,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- DNAT and SNAT on distributed router - N/S]) > @@ -1367,7 +1375,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- DNAT and SNAT on distributed router - E/W]) > @@ -1544,7 +1553,8 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > > AT_SETUP([ovn -- 2 LSs IGMP]) > @@ -1663,5 +1673,6 @@ OVS_APP_EXIT_AND_WAIT([ovn-northd]) > > as > OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d > -/connection dropped.*/d"]) > +/connection dropped.*/d > +/Could not find Chassis.*/d"]) > AT_CLEANUP > -- > 2.21.0 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] tests/system-ovn: Ignore some ovn-controller warnings
Bleep bloop. Greetings Russell Bryant, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Russell Bryant needs to sign off. Lines checked: 135, Warnings: 0, Errors: 1 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
