Re: [ovs-dev] [PATCH ovn v2] pinctrl: Don't send gARPs for localports
On Thu, Mar 25, 2021 at 2:42 PM Daniel Alvarez Sanchez wrote: > > On Thu, Mar 25, 2021 at 8:58 AM Dumitru Ceara wrote: > > > On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote: > > > Ports of type 'localport' are present on every hypervisor and > > > ovn-controller is sending gARPs for them which makes upstream > > > switches to see its MAC address flapping. > > > > > > In order to avoid this behavior, the current patch is skipping > > > localports when sending gARP/RARP packets. > > > > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1939470 > > > > > > Signed-off-by: Daniel Alvarez Sanchez > > > > 0-day robot was complaining because this misses: > > > > Co-authored-by: Dumitru Ceara > > > > But I guess that, if the patch is accepted, this can be added at commit > > time. > > > > Right, if you think it's best I can send a v3 replacing your 'Signed-off' > by 'Co-authored'. Thanks Daniel and Dumitru. I added the Co-authored-by tag and applied the patch to main branch and branch-21.03. I suppose we should also backport to other branches. I'll backport them in some time. Thanks Numan > > thanks! > daniel > > > > > Regards, > > Dumitru > > > > > Signed-off-by: Dumitru Ceara > > > --- > > > > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] pinctrl: Don't send gARPs for localports
On Thu, Mar 25, 2021 at 8:58 AM Dumitru Ceara wrote: > On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote: > > Ports of type 'localport' are present on every hypervisor and > > ovn-controller is sending gARPs for them which makes upstream > > switches to see its MAC address flapping. > > > > In order to avoid this behavior, the current patch is skipping > > localports when sending gARP/RARP packets. > > > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1939470 > > > > Signed-off-by: Daniel Alvarez Sanchez > > 0-day robot was complaining because this misses: > > Co-authored-by: Dumitru Ceara > > But I guess that, if the patch is accepted, this can be added at commit > time. > Right, if you think it's best I can send a v3 replacing your 'Signed-off' by 'Co-authored'. thanks! daniel > > Regards, > Dumitru > > > Signed-off-by: Dumitru Ceara > > --- > > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] pinctrl: Don't send gARPs for localports
On 3/24/21 6:23 PM, Daniel Alvarez Sanchez wrote: > Ports of type 'localport' are present on every hypervisor and > ovn-controller is sending gARPs for them which makes upstream > switches to see its MAC address flapping. > > In order to avoid this behavior, the current patch is skipping > localports when sending gARP/RARP packets. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1939470 > > Signed-off-by: Daniel Alvarez Sanchez 0-day robot was complaining because this misses: Co-authored-by: Dumitru Ceara But I guess that, if the patch is accepted, this can be added at commit time. Regards, Dumitru > Signed-off-by: Dumitru Ceara > --- ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn v2] pinctrl: Don't send gARPs for localports
Bleep bloop. Greetings Daniel Alvarez Sanchez, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Dumitru Ceara Lines checked: 107, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
