Re: [ovs-dev] [PATCH ovn v5 10/12] lib: Add infrastructure for plug providers.
On Tue, Oct 5, 2021 at 4:48 AM Numan Siddique wrote: > > On Tue, Sep 28, 2021 at 8:58 AM Frode Nordahl > wrote: > > > > New lib/plug-provider module contains the infrastructure for > > registering plug provider classes which may be hosted inside or > > outside the core OVN repository. > > > > New controller/plug module adds internal interface for interacting > > with the plug providers. > > > > Extend build system to allow enabling building of built-in plugging > > providers and linking an externally built plugging provider. > > > > Signed-off-by: Frode Nordahl > > --- > > Documentation/automake.mk | 2 + > > Documentation/topics/index.rst| 1 + > > Documentation/topics/plug_providers/index.rst | 32 + > > .../topics/plug_providers/plug-providers.rst | 196 ++ > > acinclude.m4 | 49 ++ > > configure.ac | 2 + > > controller/automake.mk| 4 +- > > controller/plug.c | 636 ++ > > controller/plug.h | 80 +++ > > controller/test-plug.c| 70 ++ > > lib/automake.mk | 10 +- > > lib/plug-provider.c | 204 ++ > > lib/plug-provider.h | 164 + > > lib/plug_providers/dummy/plug-dummy.c | 121 > > ovn-architecture.7.xml| 35 +- > > tests/automake.mk | 13 +- > > tests/ovn-plug.at | 8 + > > 17 files changed, 1611 insertions(+), 16 deletions(-) > > create mode 100644 Documentation/topics/plug_providers/index.rst > > create mode 100644 Documentation/topics/plug_providers/plug-providers.rst > > create mode 100644 controller/plug.c > > create mode 100644 controller/plug.h > > create mode 100644 controller/test-plug.c > > create mode 100644 lib/plug-provider.c > > create mode 100644 lib/plug-provider.h > > create mode 100644 lib/plug_providers/dummy/plug-dummy.c > > create mode 100644 tests/ovn-plug.at > > > > diff --git a/Documentation/automake.mk b/Documentation/automake.mk > > index b3fd3d62b..ff245d218 100644 > > --- a/Documentation/automake.mk > > +++ b/Documentation/automake.mk > > @@ -28,6 +28,8 @@ DOC_SOURCE = \ > > Documentation/topics/ovn-news-2.8.rst \ > > Documentation/topics/role-based-access-control.rst \ > > Documentation/topics/debugging-ddlog.rst \ > > + Documentation/topics/plug_providers/index.rst \ > > + Documentation/topics/plug_providers/plug-providers.rst \ > > Documentation/howto/index.rst \ > > Documentation/howto/docker.rst \ > > Documentation/howto/firewalld.rst \ > > diff --git a/Documentation/topics/index.rst b/Documentation/topics/index.rst > > index d58d5618b..12bd113b7 100644 > > --- a/Documentation/topics/index.rst > > +++ b/Documentation/topics/index.rst > > @@ -41,6 +41,7 @@ OVN > > high-availability > > role-based-access-control > > ovn-news-2.8 > > + plug_providers/index > > testing > > > > .. list-table:: > > diff --git a/Documentation/topics/plug_providers/index.rst > > b/Documentation/topics/plug_providers/index.rst > > new file mode 100644 > > index 0..837eeae15 > > --- /dev/null > > +++ b/Documentation/topics/plug_providers/index.rst > > @@ -0,0 +1,32 @@ > > +.. > > + Licensed under the Apache License, Version 2.0 (the "License"); you > > may > > + not use this file except in compliance with the License. You may > > obtain > > + a copy of the License at > > + > > + http://www.apache.org/licenses/LICENSE-2.0 > > + > > + Unless required by applicable law or agreed to in writing, software > > + distributed under the License is distributed on an "AS IS" BASIS, > > WITHOUT > > + WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See > > the > > + License for the specific language governing permissions and > > limitations > > + under the License. > > + > > + Convention for heading levels in OVN documentation: > > + > > + === Heading 0 (reserved for the title in a document) > > + --- Heading 1 > > + ~~~ Heading 2 > > + +++ Heading 3 > > + ''' Heading 4 > > + > > + Avoid deeper levels because they do not render well. > > + > > +== > > +Plug Providers > > +== > > + > > + > > +.. toctree:: > > + :maxdepth: 2 > > + > > + plug-providers > > diff --git a/Documentation/topics/plug_providers/plug-providers.rst > > b/Documentation/topics/plug_providers/plug-providers.rst > > new file mode 100644 > > index 0..a0a638d1b > > --- /dev/null > > +++ b/Documentation/topics/plug_providers/plug-providers.rst > > @@ -0,0 +1,196 @@ > > +.. > > + Licensed under the Apache License, Version 2.0 (the "License"); you > > may >
Re: [ovs-dev] [PATCH ovn v5 10/12] lib: Add infrastructure for plug providers.
On Tue, Sep 28, 2021 at 8:58 AM Frode Nordahl wrote: > > New lib/plug-provider module contains the infrastructure for > registering plug provider classes which may be hosted inside or > outside the core OVN repository. > > New controller/plug module adds internal interface for interacting > with the plug providers. > > Extend build system to allow enabling building of built-in plugging > providers and linking an externally built plugging provider. > > Signed-off-by: Frode Nordahl > --- > Documentation/automake.mk | 2 + > Documentation/topics/index.rst| 1 + > Documentation/topics/plug_providers/index.rst | 32 + > .../topics/plug_providers/plug-providers.rst | 196 ++ > acinclude.m4 | 49 ++ > configure.ac | 2 + > controller/automake.mk| 4 +- > controller/plug.c | 636 ++ > controller/plug.h | 80 +++ > controller/test-plug.c| 70 ++ > lib/automake.mk | 10 +- > lib/plug-provider.c | 204 ++ > lib/plug-provider.h | 164 + > lib/plug_providers/dummy/plug-dummy.c | 121 > ovn-architecture.7.xml| 35 +- > tests/automake.mk | 13 +- > tests/ovn-plug.at | 8 + > 17 files changed, 1611 insertions(+), 16 deletions(-) > create mode 100644 Documentation/topics/plug_providers/index.rst > create mode 100644 Documentation/topics/plug_providers/plug-providers.rst > create mode 100644 controller/plug.c > create mode 100644 controller/plug.h > create mode 100644 controller/test-plug.c > create mode 100644 lib/plug-provider.c > create mode 100644 lib/plug-provider.h > create mode 100644 lib/plug_providers/dummy/plug-dummy.c > create mode 100644 tests/ovn-plug.at > > diff --git a/Documentation/automake.mk b/Documentation/automake.mk > index b3fd3d62b..ff245d218 100644 > --- a/Documentation/automake.mk > +++ b/Documentation/automake.mk > @@ -28,6 +28,8 @@ DOC_SOURCE = \ > Documentation/topics/ovn-news-2.8.rst \ > Documentation/topics/role-based-access-control.rst \ > Documentation/topics/debugging-ddlog.rst \ > + Documentation/topics/plug_providers/index.rst \ > + Documentation/topics/plug_providers/plug-providers.rst \ > Documentation/howto/index.rst \ > Documentation/howto/docker.rst \ > Documentation/howto/firewalld.rst \ > diff --git a/Documentation/topics/index.rst b/Documentation/topics/index.rst > index d58d5618b..12bd113b7 100644 > --- a/Documentation/topics/index.rst > +++ b/Documentation/topics/index.rst > @@ -41,6 +41,7 @@ OVN > high-availability > role-based-access-control > ovn-news-2.8 > + plug_providers/index > testing > > .. list-table:: > diff --git a/Documentation/topics/plug_providers/index.rst > b/Documentation/topics/plug_providers/index.rst > new file mode 100644 > index 0..837eeae15 > --- /dev/null > +++ b/Documentation/topics/plug_providers/index.rst > @@ -0,0 +1,32 @@ > +.. > + Licensed under the Apache License, Version 2.0 (the "License"); you may > + not use this file except in compliance with the License. You may obtain > + a copy of the License at > + > + http://www.apache.org/licenses/LICENSE-2.0 > + > + Unless required by applicable law or agreed to in writing, software > + distributed under the License is distributed on an "AS IS" BASIS, > WITHOUT > + WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See > the > + License for the specific language governing permissions and limitations > + under the License. > + > + Convention for heading levels in OVN documentation: > + > + === Heading 0 (reserved for the title in a document) > + --- Heading 1 > + ~~~ Heading 2 > + +++ Heading 3 > + ''' Heading 4 > + > + Avoid deeper levels because they do not render well. > + > +== > +Plug Providers > +== > + > + > +.. toctree:: > + :maxdepth: 2 > + > + plug-providers > diff --git a/Documentation/topics/plug_providers/plug-providers.rst > b/Documentation/topics/plug_providers/plug-providers.rst > new file mode 100644 > index 0..a0a638d1b > --- /dev/null > +++ b/Documentation/topics/plug_providers/plug-providers.rst > @@ -0,0 +1,196 @@ > +.. > + Licensed under the Apache License, Version 2.0 (the "License"); you may > + not use this file except in compliance with the License. You may obtain > + a copy of the License at > + > + http://www.apache.org/licenses/LICENSE-2.0 > + > + Unless required by applicable law or agreed to in writing, software > + distributed under the License is distributed on
Re: [ovs-dev] [PATCH ovn v5 10/12] lib: Add infrastructure for plug providers.
Bleep bloop. Greetings Frode Nordahl, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: sphinx-build -b html -W -n -d ./Documentation/_build/doctrees ./Documentation ./Documentation/_build/html && touch docs-check Running Sphinx v1.1.3 Cannot find 'ovs-sphinx-theme' package. Falling back to default theme. loading pickled environment... done building [html]: targets for 1 source files that are out of date updating environment: 2 added, 1 changed, 0 removed reading sources... [ 33%] topics/index reading sources... [ 66%] topics/plug_providers/index reading sources... [100%] topics/plug_providers/plug-providers looking for now-outdated files... none found pickling environment... done checking consistency... done preparing documents... done writing output... [ 25%] contents writing output... [ 50%] topics/index writing output... [ 75%] topics/plug_providers/index writing output... [100%] topics/plug_providers/plug-providers Warning, treated as error: /var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace/Documentation/topics/plug_providers/plug-providers.rst:174: WARNING: Pygments lexer name u'C' is not known make[1]: *** [docs-check] Error 1 make[1]: Leaving directory `/var/lib/jenkins/jobs/0day_robot_upstream_build_ovn_from_pw/workspace' make: *** [all] Error 2 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
