Re: [ovs-dev] [PATCH v2 2/8] windows: Add default value for VSTUDIO_CONFIG
On 9/21/20 3:32 AM, Alin Gabriel Serdean wrote: > VSTUDIO_CONFIG is used when generating the windows installer. > > If the parameter passed to configure `--with-vstudiotarget` is not specified > to configure we default it to `Default`. > > Fixes bug: vstudiotarget/vstudiotargetver should be available only on Windows. > > Signed-off-by: Alin Gabriel Serdean > --- > m4/openvswitch.m4 | 93 --- > 1 file changed, 47 insertions(+), 46 deletions(-) Hi, Alin. Thanks for the series! However it still breaks the linux build with the following error: configure: error: conditional "VSTUDIO_WIN8" was never defined. Usually this means the macro was only invoked conditionally. Details here: https://travis-ci.org/github/ovsrobot/ovs/builds/728856195 [Alin] Ooops. Thanks a lot for letting me know. I sent a new series here: https://patchwork.ozlabs.org/project/openvswitch/list/?series=203845 Also I sent a PR to check if CIs are ok: https://github.com/openvswitch/ovs/pull/338 Hopefully everything is ok this time. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH v2 2/8] windows: Add default value for VSTUDIO_CONFIG
On 9/21/20 3:32 AM, Alin Gabriel Serdean wrote: > VSTUDIO_CONFIG is used when generating the windows installer. > > If the parameter passed to configure `--with-vstudiotarget` is not specified > to configure we default it to `Default`. > > Fixes bug: vstudiotarget/vstudiotargetver should be available only on Windows. > > Signed-off-by: Alin Gabriel Serdean > --- > m4/openvswitch.m4 | 93 --- > 1 file changed, 47 insertions(+), 46 deletions(-) Hi, Alin. Thanks for the series! However it still breaks the linux build with the following error: configure: error: conditional "VSTUDIO_WIN8" was never defined. Usually this means the macro was only invoked conditionally. Details here: https://travis-ci.org/github/ovsrobot/ovs/builds/728856195 Best regards, Ilya Maximets. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev