Re: [ovs-dev] [PATCH v3 2/8] userspace: Support for push_eth and pop_eth actions

2017-04-24 Thread Ben Pfaff
On Mon, Apr 24, 2017 at 09:43:27AM +, Zoltán Balogh wrote:
>  
> > I am very disappointed that, apparently, 7 people from 6 different
> > companies have contributed to this code without ever using a simple
> > build tool, recommended by the OVS documentation, that finds real bugs.
> > Please install sparse and use it.  Then, after you fix the bugs that
> > sparse finds automatically for you, please resubmit the series.
> > 
> > Thanks,
> > 
> > Ben.
> 
> Hi Ben,
> 
> This was my fault, my build script did not pass "C=1" to make. I'm sorry.
> I'm fixing the warnings, rebasing the code to latest master and sending a new 
> patch set to the list.

Thank you!
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev


Re: [ovs-dev] [PATCH v3 2/8] userspace: Support for push_eth and pop_eth actions

2017-04-24 Thread Zoltán Balogh
 
> I am very disappointed that, apparently, 7 people from 6 different
> companies have contributed to this code without ever using a simple
> build tool, recommended by the OVS documentation, that finds real bugs.
> Please install sparse and use it.  Then, after you fix the bugs that
> sparse finds automatically for you, please resubmit the series.
> 
> Thanks,
> 
> Ben.

Hi Ben,

This was my fault, my build script did not pass "C=1" to make. I'm sorry.
I'm fixing the warnings, rebasing the code to latest master and sending a new 
patch set to the list.

Best regards,
Zoltan
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev