Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features

2022-10-13 Thread Paolo Abeni 
On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
> git tree:   upstream
> console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de04288
> kernel config:  https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
> dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
> compiler:   Debian clang version 
> 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU ld (GNU 
> Binutils for Debian) 2.35.2
> syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=12173a3488
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1792461a88
> 
> Downloadable assets:
> disk image: 
> https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
> vmlinux: 
> https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
> 
> The issue was bisected to:
> 
> commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
> Author: Alexander Aring 
> Date:   Wed Jun 22 18:45:23 2022 +
> 
> fs: dlm: don't use deprecated timeout features by default

This commit is not really relevant for the issue, but it makes the
reproducer fail, since it changes the genl_family registration order
and the repro hard-codes the ovs genl family id.
> 
> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c88
> final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c88
> console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c88
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+31cde0bef4bbf8ba2...@syzkaller.appspotmail.com
> Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by 
> default")
> 
> [ cut here ]
> Dropping previously announced user features
> WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619 
> ovs_dp_reset_user_features+0x1bc/0x240 net/openvswitch/datapath.c:1619
> Modules linked in:
> CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 
> 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> Google 09/22/2022
> RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 
> net/openvswitch/datapath.c:1619
> Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f 5d c3 e8 
> c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f> 0b eb c7 44 89 f1 
> 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
> RSP: 0018:c90003b8f370 EFLAGS: 00010246
> RAX: e794c0e413340e00 RBX: 8880175cae68 RCX: 88801c069d80
> RDX:  RSI: 8000 RDI: 
> RBP: 0008 R08: 816c58ad R09: ed1017364f13
> R10: ed1017364f13 R11: 111017364f12 R12: dc00
> R13: 8880175ca450 R14: 111002eb95cd R15: c90003b8f6b0
> FS:  57276300() GS:8880b9b0() knlGS:
> CS:  0010 DS:  ES:  CR0: 80050033
> CR2: 2916 CR3: 1ed81000 CR4: 003506e0
> DR0:  DR1:  DR2: 
> DR3:  DR6: fffe0ff0 DR7: 0400
> Call Trace:
>  
>  ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
>  genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
>  genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
>  genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
>  netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
>  genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
>  netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
>  netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
>  netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
>  sock_sendmsg_nosec net/socket.c:714 [inline]
>  sock_sendmsg net/socket.c:734 [inline]
>  sys_sendmsg+0x597/0x8e0 net/socket.c:2482
>  ___sys_sendmsg net/socket.c:2536 [inline]
>  __sys_sendmsg+0x28e/0x390 net/socket.c:2565
>  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>  do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
>  entry_SYSCALL_64_after_hwframe+0x63/0xcd
> RIP: 0033:0x7fc51f29de89
> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48 89 f7 48 
> 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 
> 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
> RSP: 002b:7ffd99ec6ed8 EFLAGS: 0246 ORIG_RAX: 002e
> RAX: ffda RBX: a2c4 RCX: 7fc51f29de89
> RDX:  RSI: 2100 RDI: 0003
> RBP:  R08: 7ffd99ec7078 R09: 7ffd99ec7078
> R10: 7ffd99ec6950 R11: 0246 R12: 7ffd99ec6eec
> R13: 431bde82d7b634db R14:  R15: 
>  
> 
In this specific case it looks like the warning is caused by the fact
that ovs allows an 'outdated' datapath to set u

Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features

2022-10-17 Thread Aaron Conole 
Paolo Abeni  writes:

> On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
>> Hello,
>> 
>> syzbot found the following issue on:
>> 
>> HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of git://git...
>> git tree:   upstream
>> console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de04288
>> kernel config:  https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
>> dashboard link: https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
>> compiler: Debian clang version
>> 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU
>> ld (GNU Binutils for Debian) 2.35.2
>> syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=12173a3488
>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1792461a88
>> 
>> Downloadable assets:
>> disk image: 
>> https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
>> vmlinux: 
>> https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
>> 
>> The issue was bisected to:
>> 
>> commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
>> Author: Alexander Aring 
>> Date:   Wed Jun 22 18:45:23 2022 +
>> 
>> fs: dlm: don't use deprecated timeout features by default
>
> This commit is not really relevant for the issue, but it makes the
> reproducer fail, since it changes the genl_family registration order
> and the repro hard-codes the ovs genl family id.

I have an easy reproducer at:

http://git.bytheb.org/cgit/kselftest.git/commit/?id=97800e452e2cea1fafb45058120128e902d8970e

(PS: I do plan to do some cleanup and then post this kselftest stuff)

>> 
>> bisection log:  https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c88
>> final oops: https://syzkaller.appspot.com/x/report.txt?x=12d5787c88
>> console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c88
>> 
>> IMPORTANT: if you fix the issue, please add the following tag to the commit:
>> Reported-by: syzbot+31cde0bef4bbf8ba2...@syzkaller.appspotmail.com
>> Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by 
>> default")
>> 
>> [ cut here ]
>> Dropping previously announced user features
>> WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619
>> ovs_dp_reset_user_features+0x1bc/0x240
>> net/openvswitch/datapath.c:1619
>> Modules linked in:
>> CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 
>> 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
>> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
>> Google 09/22/2022
>> RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 
>> net/openvswitch/datapath.c:1619
>> Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f
>> 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f>
>> 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
>> RSP: 0018:c90003b8f370 EFLAGS: 00010246
>> RAX: e794c0e413340e00 RBX: 8880175cae68 RCX: 88801c069d80
>> RDX:  RSI: 8000 RDI: 
>> RBP: 0008 R08: 816c58ad R09: ed1017364f13
>> R10: ed1017364f13 R11: 111017364f12 R12: dc00
>> R13: 8880175ca450 R14: 111002eb95cd R15: c90003b8f6b0
>> FS:  57276300() GS:8880b9b0() knlGS:
>> CS:  0010 DS:  ES:  CR0: 80050033
>> CR2: 2916 CR3: 1ed81000 CR4: 003506e0
>> DR0:  DR1:  DR2: 
>> DR3:  DR6: fffe0ff0 DR7: 0400
>> Call Trace:
>>  
>>  ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
>>  genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
>>  genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
>>  genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
>>  netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
>>  genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
>>  netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
>>  netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
>>  netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
>>  sock_sendmsg_nosec net/socket.c:714 [inline]
>>  sock_sendmsg net/socket.c:734 [inline]
>>  sys_sendmsg+0x597/0x8e0 net/socket.c:2482
>>  ___sys_sendmsg net/socket.c:2536 [inline]
>>  __sys_sendmsg+0x28e/0x390 net/socket.c:2565
>>  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>>  do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
>>  entry_SYSCALL_64_after_hwframe+0x63/0xcd
>> RIP: 0033:0x7fc51f29de89
>> Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 89 f8 48
>> 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48>
>> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
>> RSP: 002b:7ffd99ec6ed8 EFLAGS: 0246 ORIG_RAX: 002e
>> RAX: ffda RBX: a2c4 RCX: 7fc51f29de89
>> RDX:  RSI: 2100 RDI: 0003
>> RBP: 0

Re: [ovs-dev] [syzbot] WARNING in ovs_dp_reset_user_features

2022-10-17 Thread Paolo Abeni 
On Mon, 2022-10-17 at 09:26 -0400, Aaron Conole wrote:
> Paolo Abeni  writes:
> > On Wed, 2022-10-12 at 10:43 -0700, syzbot wrote:
> > > Hello,
> > > 
> > > syzbot found the following issue on:
> > > 
> > > HEAD commit:e8bc52cb8df8 Merge tag 'driver-core-6.1-rc1' of 
> > > git://git...
> > > git tree:   upstream
> > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=134de04288
> > > kernel config:  https://syzkaller.appspot.com/x/.config?x=7579993da6496f03
> > > dashboard link: 
> > > https://syzkaller.appspot.com/bug?extid=31cde0bef4bbf8ba2d86
> > > compiler: Debian clang version
> > > 13.0.1-++20220126092033+75e33f71c2da-1~exp1~20220126212112.63, GNU
> > > ld (GNU Binutils for Debian) 2.35.2
> > > syz repro:  https://syzkaller.appspot.com/x/repro.syz?x=12173a3488
> > > C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=1792461a88
> > > 
> > > Downloadable assets:
> > > disk image: 
> > > https://storage.googleapis.com/syzbot-assets/4dc25a89bfbd/disk-e8bc52cb.raw.xz
> > > vmlinux: 
> > > https://storage.googleapis.com/syzbot-assets/16c9ca5fd754/vmlinux-e8bc52cb.xz
> > > 
> > > The issue was bisected to:
> > > 
> > > commit 6b0afc0cc3e9a9a91f5a76d0965d449781441e18
> > > Author: Alexander Aring 
> > > Date:   Wed Jun 22 18:45:23 2022 +
> > > 
> > > fs: dlm: don't use deprecated timeout features by default
> > 
> > This commit is not really relevant for the issue, but it makes the
> > reproducer fail, since it changes the genl_family registration order
> > and the repro hard-codes the ovs genl family id.
> 
> I have an easy reproducer at:
> 
> http://git.bytheb.org/cgit/kselftest.git/commit/?id=97800e452e2cea1fafb45058120128e902d8970e
> 
> (PS: I do plan to do some cleanup and then post this kselftest stuff)
> 
> > > 
> > > bisection log:  
> > > https://syzkaller.appspot.com/x/bisect.txt?x=10d5787c88
> > > final oops: 
> > > https://syzkaller.appspot.com/x/report.txt?x=12d5787c88
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=14d5787c88
> > > 
> > > IMPORTANT: if you fix the issue, please add the following tag to the 
> > > commit:
> > > Reported-by: syzbot+31cde0bef4bbf8ba2...@syzkaller.appspotmail.com
> > > Fixes: 6b0afc0cc3e9 ("fs: dlm: don't use deprecated timeout features by 
> > > default")
> > > 
> > > [ cut here ]
> > > Dropping previously announced user features
> > > WARNING: CPU: 1 PID: 3608 at net/openvswitch/datapath.c:1619
> > > ovs_dp_reset_user_features+0x1bc/0x240
> > > net/openvswitch/datapath.c:1619
> > > Modules linked in:
> > > CPU: 1 PID: 3608 Comm: syz-executor162 Not tainted 
> > > 6.0.0-syzkaller-07994-ge8bc52cb8df8 #0
> > > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS 
> > > Google 09/22/2022
> > > RIP: 0010:ovs_dp_reset_user_features+0x1bc/0x240 
> > > net/openvswitch/datapath.c:1619
> > > Code: 00 c7 03 00 00 00 00 eb 05 e8 d0 be 67 f7 5b 41 5c 41 5e 41 5f
> > > 5d c3 e8 c2 be 67 f7 48 c7 c7 00 92 e3 8b 31 c0 e8 74 7a 2f f7 <0f>
> > > 0b eb c7 44 89 f1 80 e1 07 fe c1 38 c1 0f 8c f1 fe ff ff 4c 89
> > > RSP: 0018:c90003b8f370 EFLAGS: 00010246
> > > RAX: e794c0e413340e00 RBX: 8880175cae68 RCX: 88801c069d80
> > > RDX:  RSI: 8000 RDI: 
> > > RBP: 0008 R08: 816c58ad R09: ed1017364f13
> > > R10: ed1017364f13 R11: 111017364f12 R12: dc00
> > > R13: 8880175ca450 R14: 111002eb95cd R15: c90003b8f6b0
> > > FS:  57276300() GS:8880b9b0() 
> > > knlGS:
> > > CS:  0010 DS:  ES:  CR0: 80050033
> > > CR2: 2916 CR3: 1ed81000 CR4: 003506e0
> > > DR0:  DR1:  DR2: 
> > > DR3:  DR6: fffe0ff0 DR7: 0400
> > > Call Trace:
> > >  
> > >  ovs_dp_cmd_new+0x8f6/0xc80 net/openvswitch/datapath.c:1822
> > >  genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
> > >  genl_family_rcv_msg net/netlink/genetlink.c:808 [inline]
> > >  genl_rcv_msg+0x11ca/0x1670 net/netlink/genetlink.c:825
> > >  netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2540
> > >  genl_rcv+0x24/0x40 net/netlink/genetlink.c:836
> > >  netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
> > >  netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
> > >  netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
> > >  sock_sendmsg_nosec net/socket.c:714 [inline]
> > >  sock_sendmsg net/socket.c:734 [inline]
> > >  sys_sendmsg+0x597/0x8e0 net/socket.c:2482
> > >  ___sys_sendmsg net/socket.c:2536 [inline]
> > >  __sys_sendmsg+0x28e/0x390 net/socket.c:2565
> > >  do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> > >  do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
> > >  entry_SYSCALL_64_after_hwframe+0x63/0xcd
> > > RIP: 0033:0x7fc51f29de89
> > > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 b1 14 00 00 90 48 8