[ovs-discuss] Running the unit test suite against a real netdev?

2019-03-28 Thread Scott Cheloha 
Hi,

I read through the official test documentation here:

http://docs.openvswitch.org/en/latest/topics/testing/

I think (thought?) I understand the intent of each of
the different test suites.

But then I looked at the unit test suite, the one you run
via the "check" target, and I noticed that all tests (unless I
missed any) are run with the dummy netdev.

There doesn't seem to be an option to run those tests against a
different, real netdev though.  Why?

... could I run the unit tests (all ~2700 of them) against a
real netdev, e.g. a userspace or kernel datapath?

My intuition says that running all those tests against a real
netdev would be a stronger demonstration of that netdev's
correctness.  You know, more tests passing means it probably
works correctly more often.  More tests means more opportunities
to find bugs in that netdev, right?

Sorry if this has been answered somewhere.

Best,

--
Scott Cheloha
___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss

[ovs-discuss] ovs 2.8.2 crash

2019-03-28 Thread Anil Kumar Koli via discuss 
Hello OVS team,

 

I have a ovs-vswitched crash of ovs version 2.8.2. I don't have the flow
which has lead to this crash, but from the backtrace I could see that the
crash is because of double locking. The ofproto_mutex lock is acquired in
handle_packet_out() and the same lock is being tried to acquire in
ofproto_flow_mod_learn().  I have the following questions?

1.  Can we have a flow which can have both OFPACT_OUTPUT and OFPACT_LEARN to
the same packet? If yes then we will a case of double lock issue.

 

2.  I have not seen any such issue reported in upstream yet and this is a
general case of controller to ovs communication. 

 

3.  Ofproto_muxtex locking in ofproto_flow_mod_learn() is obvious because,
the pmd thread will be performing the actions. 

 

4.  Any usecase where we might hit this kind of open flow actions.

 

 

root@ubuntu16:/home/sdn/openvswitch# ovs-vsctl --version

ovs-vsctl (Open vSwitch) 2.8.2

DB Schema 7.15.0

 

root@ubuntu16:/home/sdn/openvswitch# gdb /usr/sbin/ovs-vswitchd
../../core.compute-0-7.domain.tld.1552010169.ovs-vswitchd.66327

GNU gdb (Ubuntu 7.11.1-0ubuntu1~16.5) 7.11.1

Copyright (C) 2016 Free Software Foundation, Inc.

License GPLv3+: GNU GPL version 3 or later


This is free software: you are free to change and redistribute it.

There is NO WARRANTY, to the extent permitted by law.  Type "show copying"

and "show warranty" for details.

This GDB was configured as "x86_64-linux-gnu".

Type "show configuration" for configuration details.

For bug reporting instructions, please see:

.

Find the GDB manual and other documentation resources online at:

.

For help, type "help".

Type "apropos word" to search for commands related to "word"...

Reading symbols from /usr/sbin/ovs-vswitchd...Reading symbols from
/usr/lib/debug/.build-id/34/7e6150fd3a987639b05b2c297955d248b4d624.debug...d
one.

done.

[New LWP 66327]

[New LWP 66340]

[New LWP 66339]

[New LWP 66341]

[New LWP 66342]

[New LWP 66328]

[New LWP 66332]

[New LWP 66333]

[New LWP 66334]

[New LWP 66343]

[New LWP 66344]

[New LWP 66371]

[New LWP 66335]

[New LWP 66372]

[Thread debugging using libthread_db enabled]

Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Core was generated by `ovs-vswitchd unix:/var/run/openvswitch/db.sock
-vconsole:emer -vsyslog:err -vfi'.

Program terminated with signal SIGABRT, Aborted.

#0  0x7f2f021e7428 in __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:54

54  ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.

[Current thread is 1 (Thread 0x7f2f0397cb00 (LWP 66327))]

(gdb) bt

#0  0x7f2f021e7428 in __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:54

#1  0x7f2f021e902a in __GI_abort () at abort.c:89

#2  0x0078de4e in ovs_abort_valist (err_no=,
format=, args=args@entry=0x7ffc2630db28) at lib/util.c:347

#3  0x0078ded7 in ovs_abort (err_no=,
format=format@entry=0x8cd4e9 "%s: pthread_%s_%s failed") at lib/util.c:339

#4  0x0075f439 in ovs_mutex_lock_at (l_=l_@entry=0xbc3c80
, where=where@entry=0x8a1cd3 "ofproto/ofproto.c:5117") at
lib/ovs-thread.c:76

#5  0x006a155f in ofproto_flow_mod_learn
(ofm=ofm@entry=0x7ffc2630eab0, keep_ref=, limit=, below_limitp=below_limitp@entry=0x7ffc2630ea50) at
ofproto/ofproto.c:5117

#6  0x006bd704 in xlate_learn_action (ctx=ctx@entry=0x7ffc26311f00,
learn=learn@entry=0x32eab58) at ofproto/ofproto-dpif-xlate.c:5216

#7  0x006c06e3 in do_xlate_actions (ofpacts=,
ofpacts_len=, ctx=ctx@entry=0x7ffc26311f00,
group_bucket_action=group_bucket_action@entry=false)

at ofproto/ofproto-dpif-xlate.c:6580

#8  0x006c1f70 in xlate_recursively (deepens=false, rule=0x32ea9b0,
ctx=0x7ffc26311f00) at ofproto/ofproto-dpif-xlate.c:4005

#9  xlate_table_action (ctx=0x7ffc26311f00, in_port=,
table_id=, may_packet_in=,
honor_table_miss=, with_ct_orig=)

at ofproto/ofproto-dpif-xlate.c:4131

#10 0x006bfdb1 in do_xlate_actions (ofpacts=,
ofpacts_len=, ctx=ctx@entry=0x7ffc26311f00,
group_bucket_action=group_bucket_action@entry=false)

at ofproto/ofproto-dpif-xlate.c:6631

#11 0x006c1f70 in xlate_recursively (deepens=false, rule=0x31ae620,
ctx=0x7ffc26311f00) at ofproto/ofproto-dpif-xlate.c:4005

#12 xlate_table_action (ctx=0x7ffc26311f00, in_port=,
table_id=, may_packet_in=,
honor_table_miss=, with_ct_orig=)

at ofproto/ofproto-dpif-xlate.c:4131

#13 0x006bfdb1 in do_xlate_actions (ofpacts=,
ofpacts_len=, ctx=ctx@entry=0x7ffc26311f00,
group_bucket_action=group_bucket_action@entry=false)

at ofproto/ofproto-dpif-xlate.c:6631

#14 0x006c1f70 in xlate_recursively (deepens=false, rule=0x330e350,
ctx=0x7ffc26311f00) at ofproto/ofproto-dpif-xlate.c:4005

#15 xlate_table_action (ctx=0x7ffc26311f00, in_port=,
table_id=, may_packet_in=,
honor_table_miss=, with_

Re: [ovs-discuss] Latest maintenace release not announced or available for download

2019-03-28 Thread Justin Pettit 

> On Mar 25, 2019, at 5:10 AM, Jaime Caamaño Ruiz  wrote:
> 
> Hello
> 
> In the meantime, two related questions:
> 
> - Would github releases be safe to use? For exmaple
> 
> https://github.com/openvswitch/ovs/archive/v2.5.7.tar.gz
> 
> - Is 2.5.7 going to replace 2.5.6 as LTS release?

As I mentioned in a separate message, I plan to do a new release tomorrow, so 
I'd just hold off for 2.5.8.

--Justin


___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss

Re: [ovs-discuss] Latest maintenace release not announced or available for download

2019-03-28 Thread Justin Pettit 
Someone had wanted to get a bug fix in, so it just ended up being a soft 
release.  I plan to do a new release tomorrow with new versions of all our 
supported branches.

--Justin


> On Mar 19, 2019, at 10:15 AM, Ben Pfaff  wrote:
> 
> Justin, you had some information on this, can you follow up?
> 
> On Tue, Mar 19, 2019 at 11:41:03AM +0100, Jaime Caamaño Ruiz wrote:
>> Missing 2.9.4, 2.8.6, 2.7.8, 2.6.5, 2.5.7.
>> 
>> I don't know if they can actually be considered released and I guess
>> that's what I am really asking. I do see them in the relases section in
>> github.
>> 
>> BR
>> Jaime.
>> 
>> 
>> -Original Message-
>> From: Ben Pfaff 
>> To: jcaam...@suse.de
>> Cc: ovs-discuss@openvswitch.org
>> Subject: Re: [ovs-discuss] Latest maintenace release not announced or
>> available for download
>> Date: Mon, 18 Mar 2019 13:22:43 -0700
>> 
>> On Mon, Mar 18, 2019 at 12:09:07PM +0100, Jaime Caamaño Ruiz wrote:
>>> Is there any reason why the latest maintenance releases have not been
>>> announced yet and are not available for download at the usual URL
>>> 
>>> https://www.openvswitch.org/releases/
>> 
>> What versions are missing?
>> 

___
discuss mailing list
disc...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-discuss