Re: [ovs-discuss] [ovs-dev] OVS 2.12/2.13 compilation on Ubuntu Bionic
On Tue, Jul 7, 2020 at 8:39 AM Maciej Jozefczyk wrote: > Hello, > > Thank you for your responses! > > Is there any reason not to use the in-tree openvswitch kernel module >> provided in the Ubuntu kernels? Ubuntu stopped shipping DKMS modules as >> part of OVS quite a long time ago as the openvswitch module in the kernel >> is well maintained and generally up-to-date - and also to avoid this type >> of breaking change. >> > > Yes. QoS for OVN wasn't really working before until the OVN team started > using OVS meter actions. Those type of actions are not working properly > with OVS kernel module shipped by Ubuntu Bionic (up to kernel 4.18.0 [1]), > so to test this functionality in Neutron upstream gates we compile the > module from OVS source. > As an alternative you could use the HWE kernels provided for Ubuntu 18.04 LTS: linux-image-generic-hwe-18.04-edge (5.4) linux-image-generic-hwe-18.04 (5.3) however that may mean that the default images used for testing in openinfra might need to be updated to use the latest kernel versions > This patch is actually on branch-2.12 and branch-2.13. >> The only thing that is missing is a new stable release (tags). >> We're going to release new stable versions on all previous branches soon. > > > That is great news. Thank You! > > Maciej > > On Mon, Jul 6, 2020 at 7:58 PM Ilya Maximets wrote: > >> On 6/29/20 8:45 PM, Gregory Rose wrote: >> > >> > >> > On 6/26/2020 4:57 AM, Maciej Jozefczyk wrote: >> >> Hello! >> >> >> >> I would like to kindly ask You if there is a possibility to cherry-pick >> >> patch [1] to stable branches OVS 2.12, OVS 2.13 and release new tags >> for it? >> >> >> >> Without this patch we're now unable to compile OVS 2.12 in OpenStack >> >> Neutron stable releases CI, because it recently started to fail on >> Ubuntu >> >> Bionic with an error: >> >> >> >> 2020-06-24 14:50:13.975917 | primary | >> >> /opt/stack/new/ovs/datapath/linux/geneve.c: In function >> >> ‘geneve_get_v6_dst’: >> >> 2020-06-24 14:50:13.975993 | primary | >> >> /opt/stack/new/ovs/datapath/linux/geneve.c:966:15: error: ‘const >> >> struct ipv6_stub’ has no member named ‘ipv6_dst_lookup’ >> >> 2020-06-24 14:50:13.976026 | primary | if >> >> (ipv6_stub->ipv6_dst_lookup(geneve->net, gs6->sock->sk, , fl6)) { >> >> 2020-06-24 14:50:13.976049 | primary |^ >> >> 2020-06-24 14:50:14.010809 | primary | scripts/Makefile.build:285: >> >> recipe for target '/opt/stack/new/ovs/datapath/linux/geneve.o' failed >> >> >> >> The same happens for OVN 2.13. For now this blocks your CI pipelines. >> >> >> >> Can I ask You to backport this patch? >> >> This patch is actually on branch-2.12 and branch-2.13. >> The only thing that is missing is a new stable release (tags). >> We're going to release new stable versions on all previous branches soon. >> >> Best regards, Ilya Maximets. >> >> >> >> >> Thanks, >> >> Maciej >> >> >> >> [1] >> >> >> https://github.com/openvswitch/ovs/commit/5519e384f6a17f564fef4c5eb39e471e16c77235 >> >> >> >> >> >> ___ >> >> discuss mailing list >> >> disc...@openvswitch.org >> >> https://mail.openvswitch.org/mailman/listinfo/ovs-discuss >> >> >> > >> > Adding OVS Dev list where maybe the maintainers might see this sooner. >> > >> > - Greg >> >> > > -- > Best regards, > Maciej Józefczyk > ___ > discuss mailing list > disc...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-discuss > ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
Re: [ovs-discuss] [ovs-dev] OVS 2.12/2.13 compilation on Ubuntu Bionic
Hello, Thank you for your responses! Is there any reason not to use the in-tree openvswitch kernel module > provided in the Ubuntu kernels? Ubuntu stopped shipping DKMS modules as > part of OVS quite a long time ago as the openvswitch module in the kernel > is well maintained and generally up-to-date - and also to avoid this type > of breaking change. > Yes. QoS for OVN wasn't really working before until the OVN team started using OVS meter actions. Those type of actions are not working properly with OVS kernel module shipped by Ubuntu Bionic (up to kernel 4.18.0 [1]), so to test this functionality in Neutron upstream gates we compile the module from OVS source. This patch is actually on branch-2.12 and branch-2.13. > The only thing that is missing is a new stable release (tags). > We're going to release new stable versions on all previous branches soon. That is great news. Thank You! Maciej On Mon, Jul 6, 2020 at 7:58 PM Ilya Maximets wrote: > On 6/29/20 8:45 PM, Gregory Rose wrote: > > > > > > On 6/26/2020 4:57 AM, Maciej Jozefczyk wrote: > >> Hello! > >> > >> I would like to kindly ask You if there is a possibility to cherry-pick > >> patch [1] to stable branches OVS 2.12, OVS 2.13 and release new tags > for it? > >> > >> Without this patch we're now unable to compile OVS 2.12 in OpenStack > >> Neutron stable releases CI, because it recently started to fail on > Ubuntu > >> Bionic with an error: > >> > >> 2020-06-24 14:50:13.975917 | primary | > >> /opt/stack/new/ovs/datapath/linux/geneve.c: In function > >> ‘geneve_get_v6_dst’: > >> 2020-06-24 14:50:13.975993 | primary | > >> /opt/stack/new/ovs/datapath/linux/geneve.c:966:15: error: ‘const > >> struct ipv6_stub’ has no member named ‘ipv6_dst_lookup’ > >> 2020-06-24 14:50:13.976026 | primary | if > >> (ipv6_stub->ipv6_dst_lookup(geneve->net, gs6->sock->sk, , fl6)) { > >> 2020-06-24 14:50:13.976049 | primary |^ > >> 2020-06-24 14:50:14.010809 | primary | scripts/Makefile.build:285: > >> recipe for target '/opt/stack/new/ovs/datapath/linux/geneve.o' failed > >> > >> The same happens for OVN 2.13. For now this blocks your CI pipelines. > >> > >> Can I ask You to backport this patch? > > This patch is actually on branch-2.12 and branch-2.13. > The only thing that is missing is a new stable release (tags). > We're going to release new stable versions on all previous branches soon. > > Best regards, Ilya Maximets. > > >> > >> Thanks, > >> Maciej > >> > >> [1] > >> > https://github.com/openvswitch/ovs/commit/5519e384f6a17f564fef4c5eb39e471e16c77235 > >> > >> > >> ___ > >> discuss mailing list > >> disc...@openvswitch.org > >> https://mail.openvswitch.org/mailman/listinfo/ovs-discuss > >> > > > > Adding OVS Dev list where maybe the maintainers might see this sooner. > > > > - Greg > > -- Best regards, Maciej Józefczyk ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss
Re: [ovs-discuss] [ovs-dev] OVS 2.12/2.13 compilation on Ubuntu Bionic
On 6/29/20 8:45 PM, Gregory Rose wrote: > > > On 6/26/2020 4:57 AM, Maciej Jozefczyk wrote: >> Hello! >> >> I would like to kindly ask You if there is a possibility to cherry-pick >> patch [1] to stable branches OVS 2.12, OVS 2.13 and release new tags for it? >> >> Without this patch we're now unable to compile OVS 2.12 in OpenStack >> Neutron stable releases CI, because it recently started to fail on Ubuntu >> Bionic with an error: >> >> 2020-06-24 14:50:13.975917 | primary | >> /opt/stack/new/ovs/datapath/linux/geneve.c: In function >> ‘geneve_get_v6_dst’: >> 2020-06-24 14:50:13.975993 | primary | >> /opt/stack/new/ovs/datapath/linux/geneve.c:966:15: error: ‘const >> struct ipv6_stub’ has no member named ‘ipv6_dst_lookup’ >> 2020-06-24 14:50:13.976026 | primary | if >> (ipv6_stub->ipv6_dst_lookup(geneve->net, gs6->sock->sk, , fl6)) { >> 2020-06-24 14:50:13.976049 | primary | ^ >> 2020-06-24 14:50:14.010809 | primary | scripts/Makefile.build:285: >> recipe for target '/opt/stack/new/ovs/datapath/linux/geneve.o' failed >> >> The same happens for OVN 2.13. For now this blocks your CI pipelines. >> >> Can I ask You to backport this patch? This patch is actually on branch-2.12 and branch-2.13. The only thing that is missing is a new stable release (tags). We're going to release new stable versions on all previous branches soon. Best regards, Ilya Maximets. >> >> Thanks, >> Maciej >> >> [1] >> https://github.com/openvswitch/ovs/commit/5519e384f6a17f564fef4c5eb39e471e16c77235 >> >> >> ___ >> discuss mailing list >> disc...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-discuss >> > > Adding OVS Dev list where maybe the maintainers might see this sooner. > > - Greg ___ discuss mailing list disc...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-discuss