Re: [Owncloud] Setting up owncloud with PostgreSQL (SOLVED)
Thanks for your tests... in fact the setup is a bit special for the connection... i've made some changes on the master... can you test those and report any pbm ? Thanks Regards, eMerzh ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud
Re: [Owncloud] regarding quality
On Saturday 30 Jun 2012 22:52:48 eMerzh wrote: May be the automatic test (with a good coverage!) may help us here.. but we have a lng job to make everything testable :/ Exactly. ownCloud development is moving extremely fast - developing at this speed without unit tests understandably results in many bugs. There are currently very few unit tests and very few people writing unit tests because it is currently so difficult to write them. We should aim for all devs to be writing unit tests by default, because its easy, and because it makes their development process more efficient. To achieve this we need better documentation (both manual in inline), and refactoring to reduce the prevalence of close coupling and singleton objects. Currently these make writing unit tests painful. Refactoring isn't glamorous, but it will make OC simpler to work with, more testable, and easier to contribute to. Whilst we're on the subject, can I ask why we're using simpletest rather than PHPUnit? Best, Sam. signature.asc Description: This is a digitally signed message part. ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud
Re: [Owncloud] Move to GitHub
For the record I'm still against a move to GitHub, and I don't think that the decision should be made by vote. Such a move concerns business strategy and politics and must be decided by the project / company leaders. Best, Sam. signature.asc Description: This is a digitally signed message part. ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud
Re: [Owncloud] regarding quality
Am Dienstag, dem 03.07.2012 um 14:09 schrieb Sam Tuke: On Saturday 30 Jun 2012 22:52:48 eMerzh wrote: May be the automatic test (with a good coverage!) may help us here.. but we have a lng job to make everything testable :/ Exactly. ownCloud development is moving extremely fast - developing at this speed without unit tests understandably results in many bugs. There are currently very few unit tests and very few people writing unit tests because it is currently so difficult to write them. We should aim for all devs to be writing unit tests by default, because its easy, and because it makes their development process more efficient. To achieve this we need better documentation (both manual in inline), and refactoring to reduce the prevalence of close coupling and singleton objects. Currently these make writing unit tests painful. Refactoring isn't glamorous, but it will make OC simpler to work with, more testable, and easier to contribute to. Whilst we're on the subject, can I ask why we're using simpletest rather than PHPUnit? I'd like to jump in on this as well and point out that code coverage with PHPUnit will work out of the box. With simpletest some custom coding is necessary (and recycling of PHPUnit-Code ;-)) In addition PHPUnit has some support for BDD-Testing afaik - which could help building up the acceptance test suite. Tom Best, Sam. ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud
Re: [Owncloud] regarding quality
Am Sonntag, dem 01.07.2012 um 18:13 schrieb Klaas Freitag: On 29.06.2012 21:18, Thomas Müller wrote: Am Freitag, dem 29.06.2012 um 14:20 schrieb Frank Karlitschek: Hi everybody, the main problem our users mention about ownCloud is the number of bugs we have. I think we have to be more careful in the future about code quality if we want that more users use our software to manage their important documents and data. We got a lot of bad press and feedback for ownCloud 4 and it took us several weeks to fix the major bugs in 4.0.4. We have to be way better in ownCloud 5. Robin, Thomas and others are working on automated unit tests. This will help us a bit in the future. But automated test have only a limited effectivity in complex client/server/web environments like ours. So every developer is full responsible for the bugs and security problems a commit might introduce. You can´t rely on a unit test or a different developer or user to find and fix your stuff. After building up the unit test suite to a necessary extend we shall start to think about going into integration testing and maybe even think about behavior driven test cases built on top of e.g. selenium. I read a bit about Selenium and I think that might help us a lot and it feels lightweight to me for what its providing. Have you set it up and used it in another project yet? I think we really should work towards using that midterm. I used BDD in my two last rails projects. The used tools have been cucumber(for user stories) and webrat/capybara (for plain http and html processing). Due to the little javascript in these projects there was no need to use selenium. But selenium will/would have been plugged in underneath the BDD layer. Due to the heavy use of javascript in owncloud we must use selenium. For sure all these ruby tools can be used for acceptance testing a php project as well. But PHPUnit has support for selenium as well: http://www.phpunit.de/manual/3.1/en/selenium.html We need to dig into this topic - another developer meeting would be great! ;-) Tom regards, Klaas ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud
Re: [Owncloud] regarding quality
One thing that could be cool too is to have auto tests for different OS / config and databases ...beause testing everything on every db is hard... wasn't there already someone working on a jenkins or smth? Another place where we must do something is js... selenium will clearly help, but js should be testable too! as i write that, i have no experience in js or selenium testing :-) And i'm interested about way to test methods with queries to db ... (is there a way to make them test friendly?) Regards, eMerzh ___ Owncloud mailing list Owncloud@kde.org https://mail.kde.org/mailman/listinfo/owncloud
