[jira] [Updated] (HDDS-2475) Unregister ContainerMetadataScrubberMetrics on thread exit

2019-12-01 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated HDDS-2475:
-
Labels: pull-request-available  (was: )

> Unregister ContainerMetadataScrubberMetrics on thread exit
> --
>
> Key: HDDS-2475
> URL: https://issues.apache.org/jira/browse/HDDS-2475
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Datanode
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Major
>  Labels: pull-request-available
>
> {{ContainerMetadataScanner}} thread should call 
> {{ContainerMetadataScrubberMetrics#unregister}} before exiting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #286: HDDS-2475. Unregister ContainerMetadataScrubberMetrics on thread exit

2019-12-01 Thread GitBox
adoroszlai opened a new pull request #286: HDDS-2475. Unregister 
ContainerMetadataScrubberMetrics on thread exit
URL: https://github.com/apache/hadoop-ozone/pull/286
 
 
   ## What changes were proposed in this pull request?
   
   Unregister `ContainerMetadataScrubberMetrics` when 
`ContainerMetadataScanner` thread exits to avoid leak.
   
   https://issues.apache.org/jira/browse/HDDS-2475
   
   ## How was this patch tested?
   
   Added unit test case.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Created] (HDDS-2656) Prefer execute() over submit() if the returned Future is ignored

2019-12-01 Thread Attila Doroszlai (Jira)
Attila Doroszlai created HDDS-2656:
--

 Summary: Prefer execute() over submit() if the returned Future is 
ignored
 Key: HDDS-2656
 URL: https://issues.apache.org/jira/browse/HDDS-2656
 Project: Hadoop Distributed Data Store
  Issue Type: Improvement
Reporter: Attila Doroszlai
Assignee: Attila Doroszlai


{{Future submit(Runnable)}} and {{void execute(Runnable)}} in 
{{ExecutorService}} have the same result.  If the returned {{Future}} is 
ignored, {{execute}} can be used instead of {{submit}} to avoid creating some 
objects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[GitHub] [hadoop-ozone] adoroszlai commented on issue #238: HDDS-2588. Consolidate compose environments

2019-12-01 Thread GitBox
adoroszlai commented on issue #238: HDDS-2588. Consolidate compose environments
URL: https://github.com/apache/hadoop-ozone/pull/238#issuecomment-560268499
 
 
   Changes in last two commits besides README update:
   
   1. fix `freon-*.yaml`:
   * versions need to match other yamls
   * monitoring config is required for getting Freon spans
   2. set `safemode.min.datanode` and `ozone.replication` to value of 
`OZONE_REPLICATION_FACTOR` environment variable
   3. add `run.sh` to make startup simpler (`--scale` datanodes based on 
`OZONE_REPLICATION_FACTOR`)
   
   So `docker-compose up` without `--scale` still starts a cluster with 1 
datanode, but `ozone sh key put` works OK, whereas previously it required 
explicit `-r ONE`.  And getting a 3-datanode cluster is as simple as 
`OZONE_REPLICATION_FACTOR=3 ./run.sh`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[GitHub] [hadoop-ozone] adoroszlai commented on issue #277: HDDS-2628. Make AuditMessage parameters strongly typed

2019-12-01 Thread GitBox
adoroszlai commented on issue #277: HDDS-2628. Make AuditMessage parameters 
strongly typed
URL: https://github.com/apache/hadoop-ozone/pull/277#issuecomment-560268017
 
 
   Thanks @dineshchitlangia for reviewing and merging it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Commented] (HDDS-2534) scmcli container delete not working

2019-12-01 Thread luhuachao (Jira)


[ 
https://issues.apache.org/jira/browse/HDDS-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16985845#comment-16985845
 ] 

luhuachao commented on HDDS-2534:
-

[~nanda] [~adoroszlai] [~elek] Thanks if give some comments on this PR.

> scmcli container delete not working
> ---
>
> Key: HDDS-2534
> URL: https://issues.apache.org/jira/browse/HDDS-2534
> Project: Hadoop Distributed Data Store
>  Issue Type: Bug
>  Components: SCM
>Reporter: luhuachao
>Assignee: luhuachao
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:java}
> java.lang.IllegalArgumentException: Unknown command type: DeleteContainer
> at 
> org.apache.hadoop.hdds.scm.protocol.StorageContainerLocationProtocolServerSideTranslatorPB.processRequest(StorageContainerLocationProtocolServerSideTranslatorPB.java:219)
> at 
> org.apache.hadoop.hdds.server.OzoneProtocolMessageDispatcher.processRequest(OzoneProtocolMessageDispatcher.java:72)
> at 
> org.apache.hadoop.hdds.scm.protocol.StorageContainerLocationProtocolServerSideTranslatorPB.submitRequest(StorageContainerLocationProtocolServerSideTranslatorPB.java:112)
> at 
> org.apache.hadoop.hdds.protocol.proto.StorageContainerLocationProtocolProtos$StorageContainerLocationProtocolService$2.callBlockingMethod(StorageContainerLocationProtocolProtos.java:30454)
> at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:524)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:1025)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:876)
> at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:822)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2682)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Updated] (HDDS-2628) Make AuditMessage parameters strongly typed

2019-12-01 Thread Dinesh Chitlangia (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dinesh Chitlangia updated HDDS-2628:

Fix Version/s: 0.5.0
   Resolution: Fixed
   Status: Resolved  (was: Patch Available)

> Make AuditMessage parameters strongly typed
> ---
>
> Key: HDDS-2628
> URL: https://issues.apache.org/jira/browse/HDDS-2628
> Project: Hadoop Distributed Data Store
>  Issue Type: Improvement
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 0.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Improve type safety in {{AuditMessage$Builder}} for methods {{forOperation}} 
> and {{withResult}} by using existing {{interface AuditAction}} and {{enum 
> AuditEventStatus}} respectively instead of Strings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[GitHub] [hadoop-ozone] dineshchitlangia merged pull request #277: HDDS-2628. Make AuditMessage parameters strongly typed

2019-12-01 Thread GitBox
dineshchitlangia merged pull request #277: HDDS-2628. Make AuditMessage 
parameters strongly typed
URL: https://github.com/apache/hadoop-ozone/pull/277
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org



[jira] [Assigned] (HDDS-2475) Unregister ContainerMetadataScrubberMetrics on thread exit

2019-12-01 Thread Attila Doroszlai (Jira)


 [ 
https://issues.apache.org/jira/browse/HDDS-2475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Doroszlai reassigned HDDS-2475:
--

Assignee: Attila Doroszlai

> Unregister ContainerMetadataScrubberMetrics on thread exit
> --
>
> Key: HDDS-2475
> URL: https://issues.apache.org/jira/browse/HDDS-2475
> Project: Hadoop Distributed Data Store
>  Issue Type: Sub-task
>  Components: Ozone Datanode
>Reporter: Attila Doroszlai
>Assignee: Attila Doroszlai
>Priority: Major
>
> {{ContainerMetadataScanner}} thread should call 
> {{ContainerMetadataScrubberMetrics#unregister}} before exiting.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org