[GitHub] [hadoop-ozone] elek commented on a change in pull request #534: HDDS-2987. Add metrics to OM DoubleBuffer.
elek commented on a change in pull request #534: HDDS-2987. Add metrics to OM
DoubleBuffer.
URL: https://github.com/apache/hadoop-ozone/pull/534#discussion_r377671317
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##
@@ -145,7 +146,10 @@ private void flushTransactions() {
}
});
+long startTime = Time.monotonicNowNanos();
omMetadataManager.getStore().commitBatchOperation(batchOperation);
+ozoneManagerDoubleBufferMetrics.updateFlushTime(
Review comment:
> think that is fine right because anyway we got an exception, so missing
updateFlushTime is fine I believe.
Fair enough. Thanks to help to understand it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #534: HDDS-2987. Add metrics to OM DoubleBuffer.
elek commented on a change in pull request #534: HDDS-2987. Add metrics to OM
DoubleBuffer.
URL: https://github.com/apache/hadoop-ozone/pull/534#discussion_r377090569
##
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##
@@ -145,7 +146,10 @@ private void flushTransactions() {
}
});
+long startTime = Time.monotonicNowNanos();
omMetadataManager.getStore().commitBatchOperation(batchOperation);
+ozoneManagerDoubleBufferMetrics.updateFlushTime(
Review comment:
Do we need a finally block here?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
