[GitHub] [hadoop-ozone] linyiqun commented on pull request #1437: HDDS-4222: [OzoneFS optimization] Provide a mechanism for efficient path lookup
linyiqun commented on pull request #1437: URL: https://github.com/apache/hadoop-ozone/pull/1437#issuecomment-696588382 > > Hi @rakeshadr , some initial review comments below. > > In additional, one question from me: this is the first task of dir cache, there will be other further subtasks. But this part of work depends on [HDDS-2939](https://issues.apache.org/jira/browse/HDDS-2939) be completed. So that means [HDDS-4222](https://issues.apache.org/jira/browse/HDDS-4222) tasks cannot be merged immediately and be blocked for a long time? How do we plan to coordinate with [HDDS-2939](https://issues.apache.org/jira/browse/HDDS-2939) and [HDDS-4222](https://issues.apache.org/jira/browse/HDDS-4222) feature development works? > > Good comment. yes, cache should be integrated eventually(case-by-case) to get full benefit. But [HDDS-4222](https://issues.apache.org/jira/browse/HDDS-4222) can be upstreamed separately and not blocked, I feel. > > Cache can be integrated once [HDDS-2949](https://issues.apache.org/jira/browse/HDDS-2949) is finished. During dir creation, it checks the [DIR_EXISTS](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMDirectoryCreateRequest.java#L185) and cache can be integrated into this call path. > > Later, while implementing File, lookups tasks, delete, rename etc will integrate into that areas. Get it, sounds good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] linyiqun commented on pull request #1437: HDDS-4222: [OzoneFS optimization] Provide a mechanism for efficient path lookup
linyiqun commented on pull request #1437: URL: https://github.com/apache/hadoop-ozone/pull/1437#issuecomment-696588382 > > Hi @rakeshadr , some initial review comments below. > > In additional, one question from me: this is the first task of dir cache, there will be other further subtasks. But this part of work depends on [HDDS-2939](https://issues.apache.org/jira/browse/HDDS-2939) be completed. So that means [HDDS-4222](https://issues.apache.org/jira/browse/HDDS-4222) tasks cannot be merged immediately and be blocked for a long time? How do we plan to coordinate with [HDDS-2939](https://issues.apache.org/jira/browse/HDDS-2939) and [HDDS-4222](https://issues.apache.org/jira/browse/HDDS-4222) feature development works? > > Good comment. yes, cache should be integrated eventually(case-by-case) to get full benefit. But [HDDS-4222](https://issues.apache.org/jira/browse/HDDS-4222) can be upstreamed separately and not blocked, I feel. > > Cache can be integrated once [HDDS-2949](https://issues.apache.org/jira/browse/HDDS-2949) is finished. During dir creation, it checks the [DIR_EXISTS](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMDirectoryCreateRequest.java#L185) and cache can be integrated into this call path. > > Later, while implementing File, lookups tasks, delete, rename etc will integrate into that areas. Get it, sounds good to me. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
