[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl
xiaoyuyao commented on a change in pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#discussion_r454525325 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java ## @@ -78,7 +78,7 @@ description = "The size of the raft segment used by Apache Ratis on" + " SCM. (16 KB by default)" ) - private long raftSegmentSize = 16L * 1024L; + private double raftSegmentSize = 16L * 1024L; Review comment: I see. Thanks for the details. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl
xiaoyuyao commented on a change in pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#discussion_r451155274 ## File path: hadoop-ozone/recon/pom.xml ## @@ -108,6 +108,7 @@ pnpm config set store-dir ~/.pnpm-store + false Review comment: This change seems unrelated. Can you merge it from master? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
[GitHub] [hadoop-ozone] xiaoyuyao commented on a change in pull request #1151: HDDS-3191: switch from SCMPipelineManager to PipelineManagerV2Impl
xiaoyuyao commented on a change in pull request #1151: URL: https://github.com/apache/hadoop-ozone/pull/1151#discussion_r451149178 ## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAConfiguration.java ## @@ -78,7 +78,7 @@ description = "The size of the raft segment used by Apache Ratis on" + " SCM. (16 KB by default)" ) - private long raftSegmentSize = 16L * 1024L; + private double raftSegmentSize = 16L * 1024L; Review comment: Is there a reason to change long to double here and force conversion later? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: ozone-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: ozone-issues-h...@hadoop.apache.org
