Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi Hideo-san, On Wed, Dec 16, 2009 at 11:11:45AM +0900, renayama19661...@ybb.ne.jp wrote: Hi all, Thank you for understanding of all of you. Yes, though that means changing all plugins. I can assist the revision of the plug in. That would be great since I'm overwhelmed with other business now. And please open a bugzilla if there isn't any so that we can track this. Cheers, Dejan Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Lars, On Tue, Dec 15, 2009 at 02:24:42PM +0100, Lars Ellenberg wrote: On Tue, Dec 15, 2009 at 11:25:41AM +0100, Dejan Muhamedagic wrote: Hi Hideo-san, On Tue, Dec 15, 2009 at 09:22:35AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, Are node names uppercase? And then stonith doesn't work? The node name is a small letter. Well, why would they put in uppercase names then? stonith acts, but it is not carried out because it is not found an target node. It is caused by a mistake of the setting obviously. However, for a user, some kind of measures are necessary. Sorry, this smells like wontfix :) Hm. let me try to summarize my understanding of this thread. Hostnames are in general case insensitive. In pacemaker/openais/heartbeat, in most places, this is correctly taken care of by using strcasecmp(3) or tolower(3) in C code where appropriate. Correctly :) We have a bugzilla open for this, because it breaks configurations with node names which contain uppercase letters. But I doubt that that will be fixed. Basically, the only way is to just have lowercase host names. some stonith plugins however seem to be case sensitive, and will just break when one uses hostnames with inappropriate case. Hideo-san proposes to fix that stonith plugin, to make it deal with hostnames case insensitive as well (as the rest of the cluster stack and dns and whatever does), but to warn about the fact that there is some case mismatch between spelling in some config file and hostlist detection of the stonith plugin. My understanding was that the user placed uppercase node names in the stonith configuration, but the node names are actually lowercase. But if your understanding is correct, then we may fix this. Hideo-san, if my understanding of your proposal is correct, then I think that should just be done. makes the code more robust, follows principle of least surprise etc. there may even be plugins that can only autodetect in all caps because of limitations in the firmware of the hardware used. I don't know. Right, could be, but that should be dealt with in the plugin. but either folding hostnames to all lowercase, or using strcasecmp, sounds reasonable. Yes, though that means changing all plugins. Cheers, Dejan Thanks, -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD召・and LINBIT召・are registered trademarks of LINBIT, Austria. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi Dejan, That would be great since I'm overwhelmed with other business now. And please open a bugzilla if there isn't any so that we can track this. All right. Please wait Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Hideo-san, On Wed, Dec 16, 2009 at 11:11:45AM +0900, renayama19661...@ybb.ne.jp wrote: Hi all, Thank you for understanding of all of you. Yes, though that means changing all plugins. I can assist the revision of the plug in. That would be great since I'm overwhelmed with other business now. And please open a bugzilla if there isn't any so that we can track this. Cheers, Dejan Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Lars, On Tue, Dec 15, 2009 at 02:24:42PM +0100, Lars Ellenberg wrote: On Tue, Dec 15, 2009 at 11:25:41AM +0100, Dejan Muhamedagic wrote: Hi Hideo-san, On Tue, Dec 15, 2009 at 09:22:35AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, Are node names uppercase? And then stonith doesn't work? The node name is a small letter. Well, why would they put in uppercase names then? stonith acts, but it is not carried out because it is not found an target node. It is caused by a mistake of the setting obviously. However, for a user, some kind of measures are necessary. Sorry, this smells like wontfix :) Hm. let me try to summarize my understanding of this thread. Hostnames are in general case insensitive. In pacemaker/openais/heartbeat, in most places, this is correctly taken care of by using strcasecmp(3) or tolower(3) in C code where appropriate. Correctly :) We have a bugzilla open for this, because it breaks configurations with node names which contain uppercase letters. But I doubt that that will be fixed. Basically, the only way is to just have lowercase host names. some stonith plugins however seem to be case sensitive, and will just break when one uses hostnames with inappropriate case. Hideo-san proposes to fix that stonith plugin, to make it deal with hostnames case insensitive as well (as the rest of the cluster stack and dns and whatever does), but to warn about the fact that there is some case mismatch between spelling in some config file and hostlist detection of the stonith plugin. My understanding was that the user placed uppercase node names in the stonith configuration, but the node names are actually lowercase. But if your understanding is correct, then we may fix this. Hideo-san, if my understanding of your proposal is correct, then I think that should just be done. makes the code more robust, follows principle of least surprise etc. there may even be plugins that can only autodetect in all caps because of limitations in the firmware of the hardware used. I don't know. Right, could be, but that should be dealt with in the plugin. but either folding hostnames to all lowercase, or using strcasecmp, sounds reasonable. Yes, though that means changing all plugins. Cheers, Dejan Thanks, -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD召・and LINBIT召・are registered trademarks of LINBIT, Austria. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi Dejan, I registered. http://developerbugs.linux-foundation.org/show_bug.cgi?id=2292 Best Regards, Hideo Yamauchi. --- renayama19661...@ybb.ne.jp wrote: Hi Dejan, That would be great since I'm overwhelmed with other business now. And please open a bugzilla if there isn't any so that we can track this. All right. Please wait Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Hideo-san, On Wed, Dec 16, 2009 at 11:11:45AM +0900, renayama19661...@ybb.ne.jp wrote: Hi all, Thank you for understanding of all of you. Yes, though that means changing all plugins. I can assist the revision of the plug in. That would be great since I'm overwhelmed with other business now. And please open a bugzilla if there isn't any so that we can track this. Cheers, Dejan Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Lars, On Tue, Dec 15, 2009 at 02:24:42PM +0100, Lars Ellenberg wrote: On Tue, Dec 15, 2009 at 11:25:41AM +0100, Dejan Muhamedagic wrote: Hi Hideo-san, On Tue, Dec 15, 2009 at 09:22:35AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, Are node names uppercase? And then stonith doesn't work? The node name is a small letter. Well, why would they put in uppercase names then? stonith acts, but it is not carried out because it is not found an target node. It is caused by a mistake of the setting obviously. However, for a user, some kind of measures are necessary. Sorry, this smells like wontfix :) Hm. let me try to summarize my understanding of this thread. Hostnames are in general case insensitive. In pacemaker/openais/heartbeat, in most places, this is correctly taken care of by using strcasecmp(3) or tolower(3) in C code where appropriate. Correctly :) We have a bugzilla open for this, because it breaks configurations with node names which contain uppercase letters. But I doubt that that will be fixed. Basically, the only way is to just have lowercase host names. some stonith plugins however seem to be case sensitive, and will just break when one uses hostnames with inappropriate case. Hideo-san proposes to fix that stonith plugin, to make it deal with hostnames case insensitive as well (as the rest of the cluster stack and dns and whatever does), but to warn about the fact that there is some case mismatch between spelling in some config file and hostlist detection of the stonith plugin. My understanding was that the user placed uppercase node names in the stonith configuration, but the node names are actually lowercase. But if your understanding is correct, then we may fix this. Hideo-san, if my understanding of your proposal is correct, then I think that should just be done. makes the code more robust, follows principle of least surprise etc. there may even be plugins that can only autodetect in all caps because of limitations in the firmware of the hardware used. I don't know. Right, could be, but that should be dealt with in the plugin. but either folding hostnames to all lowercase, or using strcasecmp, sounds reasonable. Yes, though that means changing all plugins. Cheers, Dejan Thanks, -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD召・and LINBIT召・are registered trademarks of LINBIT, Austria. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi Hideo-san, On Tue, Dec 15, 2009 at 09:22:35AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, Are node names uppercase? And then stonith doesn't work? The node name is a small letter. Well, why would they put in uppercase names then? stonith acts, but it is not carried out because it is not found an target node. It is caused by a mistake of the setting obviously. However, for a user, some kind of measures are necessary. Sorry, this smells like wontfix :) Cheers, Dejan Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Hideo-san, On Mon, Dec 14, 2009 at 09:39:41AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, What is RULE? It is a description of rule in cib.xml. I can't really follow. Can you please give me an example. OK. It is assumed that there are two nodes.(hostname : node-a and node-b) The user can write a node name in rule of cib.xml in capital letters. - rsc_location id=domU-xen1-node1 rsc=domU-xen1 rule id=domU-xen1-node1-rule-1 score=200 expression attribute=#uname id=domU-xen1-node1-rule-1-expression-1 operation=eq value=NODEA/ /rule /rsc_location rsc_location id=domU-xen1-node2 rsc=domU-xen1 rule id=domU-xen1-node2-rule-1 score=100 expression attribute=#uname id=domU-xen1-node2-rule-1-expression-1 operation=eq value=NODEB/ /rule /rsc_location - Rule works definitely. But, hostlist of stonith does not work definitely when I wrote it in capital letters. - primitive class=stonith id=Stonith1 type=external/ibmrsa-telnet instance_attributes id=prmStonith1-2-instance_attributes nvpair id=prmStonith1-2-priority name=priority value=2/ nvpair id=prmStonith1-2-stonith-timeout name=stonith-timeout value=60s/ nvpair id=prmStonith1-2-ip_address name=ip_address value=192.168.18.115/ nvpair id=prmStonith1-2-nodename name=nodename value=NODEA/ (snip) - Are node names uppercase? And then stonith doesn't work? Thanks, Dejan Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Hideo-san, Sorry, missed somehow this post. On Thu, Dec 03, 2009 at 03:08:32PM +0900, renayama19661...@ybb.ne.jp wrote: Hi, We committed the following mistakes. * The host name is a small letter. You mean converted to lowercase. Yes, somebody even complained about it lately. * The host name of RULE is a capital letter. What is RULE? * The host name of STONITH(hostlist) is a capital letter. I can't really follow. Can you please give me an example. By this setting, the resource is arranged definitely, but fails in STONITH(fence opration). The cause is STONITH distinguishes a node name by a small and capital letter, and to process it. I think that it is good not to distinguish it in the same way as rule setting. I created a patch for stonithd. Forgot to attach it? But, the part revision of stonith-RA becomes necessary for the solution of the problem, too. I show a revision example of RA of ssh/external next. external/ssh reset) h_target=`echo $2 | tr A-Z a-z` for h in $hostlist do h_list=`echo $h | tr A-Z a-z` if [ $h_list != $h_target ] then continue fi -- I understand that there is somewhere a mismatch in hostname case handling, but still don't know where. Cheers, Dejan Please teach it if there is the revision method that, besides, is good. Best Regards, Hideo Yamauchi. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi all, Thank you for understanding of all of you. Yes, though that means changing all plugins. I can assist the revision of the plug in. Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Lars, On Tue, Dec 15, 2009 at 02:24:42PM +0100, Lars Ellenberg wrote: On Tue, Dec 15, 2009 at 11:25:41AM +0100, Dejan Muhamedagic wrote: Hi Hideo-san, On Tue, Dec 15, 2009 at 09:22:35AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, Are node names uppercase? And then stonith doesn't work? The node name is a small letter. Well, why would they put in uppercase names then? stonith acts, but it is not carried out because it is not found an target node. It is caused by a mistake of the setting obviously. However, for a user, some kind of measures are necessary. Sorry, this smells like wontfix :) Hm. let me try to summarize my understanding of this thread. Hostnames are in general case insensitive. In pacemaker/openais/heartbeat, in most places, this is correctly taken care of by using strcasecmp(3) or tolower(3) in C code where appropriate. Correctly :) We have a bugzilla open for this, because it breaks configurations with node names which contain uppercase letters. But I doubt that that will be fixed. Basically, the only way is to just have lowercase host names. some stonith plugins however seem to be case sensitive, and will just break when one uses hostnames with inappropriate case. Hideo-san proposes to fix that stonith plugin, to make it deal with hostnames case insensitive as well (as the rest of the cluster stack and dns and whatever does), but to warn about the fact that there is some case mismatch between spelling in some config file and hostlist detection of the stonith plugin. My understanding was that the user placed uppercase node names in the stonith configuration, but the node names are actually lowercase. But if your understanding is correct, then we may fix this. Hideo-san, if my understanding of your proposal is correct, then I think that should just be done. makes the code more robust, follows principle of least surprise etc. there may even be plugins that can only autodetect in all caps because of limitations in the firmware of the hardware used. I don't know. Right, could be, but that should be dealt with in the plugin. but either folding hostnames to all lowercase, or using strcasecmp, sounds reasonable. Yes, though that means changing all plugins. Cheers, Dejan Thanks, -- : Lars Ellenberg : LINBIT | Your Way to High Availability : DRBD/HA support and consulting http://www.linbit.com DRBD召・and LINBIT召・are registered trademarks of LINBIT, Austria. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi Dejan, Are node names uppercase? And then stonith doesn't work? The node name is a small letter. stonith acts, but it is not carried out because it is not found an target node. It is caused by a mistake of the setting obviously. However, for a user, some kind of measures are necessary. Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Hideo-san, On Mon, Dec 14, 2009 at 09:39:41AM +0900, renayama19661...@ybb.ne.jp wrote: Hi Dejan, What is RULE? It is a description of rule in cib.xml. I can't really follow. Can you please give me an example. OK. It is assumed that there are two nodes.(hostname : node-a and node-b) The user can write a node name in rule of cib.xml in capital letters. - rsc_location id=domU-xen1-node1 rsc=domU-xen1 rule id=domU-xen1-node1-rule-1 score=200 expression attribute=#uname id=domU-xen1-node1-rule-1-expression-1 operation=eq value=NODEA/ /rule /rsc_location rsc_location id=domU-xen1-node2 rsc=domU-xen1 rule id=domU-xen1-node2-rule-1 score=100 expression attribute=#uname id=domU-xen1-node2-rule-1-expression-1 operation=eq value=NODEB/ /rule /rsc_location - Rule works definitely. But, hostlist of stonith does not work definitely when I wrote it in capital letters. - primitive class=stonith id=Stonith1 type=external/ibmrsa-telnet instance_attributes id=prmStonith1-2-instance_attributes nvpair id=prmStonith1-2-priority name=priority value=2/ nvpair id=prmStonith1-2-stonith-timeout name=stonith-timeout value=60s/ nvpair id=prmStonith1-2-ip_address name=ip_address value=192.168.18.115/ nvpair id=prmStonith1-2-nodename name=nodename value=NODEA/ (snip) - Are node names uppercase? And then stonith doesn't work? Thanks, Dejan Best Regards, Hideo Yamauchi. --- Dejan Muhamedagic deja...@fastmail.fm wrote: Hi Hideo-san, Sorry, missed somehow this post. On Thu, Dec 03, 2009 at 03:08:32PM +0900, renayama19661...@ybb.ne.jp wrote: Hi, We committed the following mistakes. * The host name is a small letter. You mean converted to lowercase. Yes, somebody even complained about it lately. * The host name of RULE is a capital letter. What is RULE? * The host name of STONITH(hostlist) is a capital letter. I can't really follow. Can you please give me an example. By this setting, the resource is arranged definitely, but fails in STONITH(fence opration). The cause is STONITH distinguishes a node name by a small and capital letter, and to process it. I think that it is good not to distinguish it in the same way as rule setting. I created a patch for stonithd. Forgot to attach it? But, the part revision of stonith-RA becomes necessary for the solution of the problem, too. I show a revision example of RA of ssh/external next. external/ssh reset) h_target=`echo $2 | tr A-Z a-z` for h in $hostlist do h_list=`echo $h | tr A-Z a-z` if [ $h_list != $h_target ] then continue fi -- I understand that there is somewhere a mismatch in hostname case handling, but still don't know where. Cheers, Dejan Please teach it if there is the revision method that, besides, is good. Best Regards, Hideo Yamauchi. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
Re: [Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.
Hi Dejan, About this matter, how do you think? Please tell me your opinion. Best Regards, Hideo Yamauchi. --- renayama19661...@ybb.ne.jp wrote: Hi, We committed the following mistakes. * The host name is a small letter. * The host name of RULE is a capital letter. * The host name of STONITH(hostlist) is a capital letter. By this setting, the resource is arranged definitely, but fails in STONITH(fence opration). The cause is STONITH distinguishes a node name by a small and capital letter, and to process it. I think that it is good not to distinguish it in the same way as rule setting. I created a patch for stonithd. But, the part revision of stonith-RA becomes necessary for the solution of the problem, too. I show a revision example of RA of ssh/external next. external/ssh reset) h_target=`echo $2 | tr A-Z a-z` for h in $hostlist do h_list=`echo $h | tr A-Z a-z` if [ $h_list != $h_target ] then continue fi -- Please teach it if there is the revision method that, besides, is good. Best Regards, Hideo Yamauchi. ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker ___ Pacemaker mailing list Pacemaker@oss.clusterlabs.org http://oss.clusterlabs.org/mailman/listinfo/pacemaker
