[Bug 561761] Review Request: perl-HTML-Entities-Numbered - Conversion of numbered HTML entities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561761 --- Comment #3 from Xavier Bachelot xav...@bachelot.org 2010-02-08 04:42:47 EST --- New version : - Remove unwanted Requires: perl(Test::More). Spec URL: http://www.bachelot.org/fedora/SPECS/perl-HTML-Entities-Numbered.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-HTML-Entities-Numbered-0.04-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226331] Merge Review: pydict
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226331 Parag pnem...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NOTABUG Flag|fedora-review? | --- Comment #8 from Parag pnem...@redhat.com 2010-02-08 04:41:35 EST --- Officially Retired this Package now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561470] Review Request: beakerlib - shell-level integration testing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561470 --- Comment #7 from Petr Šplíchal pspli...@redhat.com 2010-02-08 04:44:55 EST --- Can the .spec summary be made more specific? Presently, it says An operating system integration testing harness. Is that the correct summary for beakerlib? What about using the summary from the wiki? Should be quite up-to-date and more specific: Summary: A shell-level integration testing library Description: BeakerLib is a shell-level integration testing library, providing convenience functions which simplify writing, running and analysis of integration and blackbox tests. The essential features are: * Journal - uniform logging mechanism (saved in XML format) * Phases - clear separation of setup / test / cleanup * Asserts - common checks (exit codes, check file existence content) * Common operations - managing services, backup restore * MUST: The License field in the package spec file must match the actual license. FAIL - * I can't tell by looking at the code what the license is. You may wish to include a LICENSE file. I'll add the LICENSE file as part of the documentation update patch. * The Makefile lists '# License: GPL v2 or later', but the package is listed as GPLv2. if this is the case, you may wish to change the .spec file License: GPLv2+ * src/staf-rhts/BEAKERLIB.pm shows Eclipse Public License (EPL) V1.0 which is not compatible with the GPLv2 (see http://fedoraproject.org/wiki/Licensing#SoftwareLicenses). The staf-rhts directory should be removed altogether I guess. This is Beaker-Staff integration stuff which has not been used AFAIK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 495693] Review Request: perl-Syntax-Highlight-Perl6 - Perl 6 Syntax Highlighter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495693 --- Comment #11 from Marcela Mašláňová mmasl...@redhat.com 2010-02-08 05:04:02 EST --- It stays only these warnings: perl-Syntax-Highlight-Perl6.src: W: spelling-error %description -l en_US html - HTML, ht ml, ht-ml perl-Syntax-Highlight-Perl6.src: W: spelling-error %description -l en_US pm's - Pm's, om's, em's perl-Syntax-Highlight-Perl6.src:19: W: unversioned-explicit-provides perl(STD) perl-Syntax-Highlight-Perl6.src:19: W: unversioned-explicit-provides perl(mangle.pl) I hate unversioned provides, but as you said, they have no releases in package. New version: http://mmaslano.fedorapeople.org/review/perl-Syntax-Highlight-Perl6-0.78-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562785] New: Package Review: perl-Debug-Client - client side code for perl debugger
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Package Review: perl-Debug-Client - client side code for perl debugger https://bugzilla.redhat.com/show_bug.cgi?id=562785 Summary: Package Review: perl-Debug-Client - client side code for perl debugger Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mmasl...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- SRPM: http://mmaslano.fedorapeople.org/review/perl-Debug-Client-0.11-1.fc13.src.rpm Spec: http://mmaslano.fedorapeople.org/review/perl-Debug-Client.spec Description: client side code for perl debugger -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524437] Review Request: nss_updatedb - Maintains a local cache of network directory user and group information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524437 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Flag||fedora-review+ --- Comment #8 from Parag AN(पराग) panem...@gmail.com 2010-02-08 06:28:44 EST --- + Ok - Need work Review: + package builds in mock (rawhide i686). koji Build =http://koji.fedoraproject.org/koji/taskinfo?taskID=1968557 + rpmlint is silent for SRPM and for RPM. nss_updatedb.src: W: no-cleaning-of-buildroot %install nss_updatedb.src: W: no-buildroot-tag == no issues as long as not wanted to use in EPEL. + source files match upstream url (sha1sum) 4dbe7daacd8580bb896a7e6ee5006ad3d16dc646 nss_updatedb.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226321] Merge Review: psgml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226321 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Flag||needinfo?(al...@users.sourc ||eforge.net) --- Comment #5 from Christoph Wickert cwick...@fedoraproject.org 2010-02-08 07:05:18 EST --- Any news here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524437] Review Request: nss_updatedb - Maintains a local cache of network directory user and group information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524437 Kashyap Chamarthy kcham...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555018] Review Request: gnac - An audio converter for GNOME (first package, seeking sponsor)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555018 Michael Schwendt mschwe...@gmail.com changed: What|Removed |Added Status|ASSIGNED|NEW CC|mschwe...@gmail.com | AssignedTo|mschwe...@gmail.com |nob...@fedoraproject.org Flag|fedora-review? | --- Comment #11 from Michael Schwendt mschwe...@gmail.com 2010-02-08 07:25:53 EST --- intltool Yeah, you managed to confuse me by not increasing the Release value of the package. The gnac-0.2.1-1.fc12.src.rpm I got was not the latest. Rule of thumb: Everytime you modify the .spec file to build a new src.rpm, increase the Release tag and add a %changelog entry. gstreamer-plugins-ugly That one is installed, and still something went wrong after keeping Gnac open and performing some tests to examine app behaviour. It's not a blocker for the review process, but it might be that a bug is lurking in the code. [...] As I don't know when I will find the time to do more reviews of this one or other packages, I reset the flags of this ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562158] Review Request: dfish (a generic front-end for selecting files)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562158 --- Comment #2 from Daniel Novotny dnovo...@redhat.com 2010-02-08 07:38:16 EST --- OK, changes applied - BuildRoot changed - %doc instead of cp-ing the docs - man page added - new upstream version with version in tarball and directory name SPEC: http://people.fedoraproject.org/~dnovotny/f/dfish.spec SRPM: http://people.fedoraproject.org/~dnovotny/f/dfish-1.3-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533887] Review Request: raw-thumbnailer - thumbnailer for raw images on gnome
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533887 --- Comment #8 from Victor Bogado bog...@bogado.net 2010-02-08 07:55:55 EST --- Made the changes, I did not yet tested them, since I don't have full access to my fedora machine right now (just a ssh connection) but it did compiled well, and passed the rpmlint test (with the exception of the false positive you noted above). Spec URL: http://static.bogado.net/rpm/raw-thumbnailer.spec SRPM URL: http://static.bogado.net/rpm/raw-thumbnailer-0.99.1-4.bog12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561470] Review Request: beakerlib - shell-level integration testing library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=561470
--- Comment #8 from Michael Schwendt mschwe...@gmail.com 2010-02-08 07:55:40
EST ---
BuildArch:noarch
%{_libdir}/%{name}/python/rlMemAvg.py*
Bzzz! Noarch plus %_libdir won't fly, since the value of %_libdir would change
with the build host.
Source0:%{name}-%{version}.tar.gz
This is no valid URL where to download the tarball. If the tarball cannot be
downloaded anywhere, please add a comment on how to construct it from a scm
repository.
https://fedorahosted.org/git/beakerlib.git
That redirects to:
https://fedorahosted.org/web/410
No such project.
The requested project does not exist on Fedora Hosted.
Obsoletes: rhtslib beaker-lib
Provides: rhtslib beaker-lib
Have you tried rpmlint -i ... on the rpms?
It's common practise to specify a max. version in Obsoletes tags in order to
not occupy a namespace completely. And to specify an explicit EVR in Provides.
Example:
Obsoletes: rhtslib 1.0
Provides: rhtslib = %{version}-%{release}
If not doing that, this pair of Obsoletes/Provides becomes much more
questionable. Look! On Fedora 12:
$ repoquery --whatprovides rhtslib
$ repoquery --whatprovides beaker-lib
$
Nothing provides these so far. Even if it may be old names: IMO, it's being
frowned upon to provide alternative virtual package names just for fun. My
suggestion: keep the Obsoletes with proper max. version, but don't add the
Provides. It's silly to run with multiple alternative/competing packages names,
whether virtual or not.
%makeinstall DESTDIR=$RPM_BUILD_ROOT
Please prefer make DESTDIR=$RPM_BUILD_ROOT install over %makeinstall unless
the normal make install ... doesn't work. The macro redefines many values,
which bears a risk.
/usr/lib/beakerlib/python/journal-compare.py*
Which packages owns /usr/lib/beakerlib/python/?
/usr/lib/beakerlib/perl/deja-summarize
Which packages owns /usr/lib/beakerlib/perl/?
http://fedoraproject.org/wiki/Packaging:UnownedDirectories
%{_mandir}/man1/beakerlib*1.gz
Since man pages typically are compressed transparently by rpmbuild, prefer a
wildcard over a file extension such as .gz:
%{_mandir}/man1/beakerlib*1*
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560732] Review Request: plasmoid-publictransport - Applet that shows departure/arrival board for a given stop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560732 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added CC||ke...@tigcc.ticalc.org AssignedTo|nob...@fedoraproject.org|ke...@tigcc.ticalc.org --- Comment #1 from Kevin Kofler ke...@tigcc.ticalc.org 2010-02-08 08:13:44 EST --- LOL, the spelling errors and the suggested fixes are quite funny. This sounds cool and it claims to support all cities here in Austria, I guess I'll just have to review this. :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560732] Review Request: plasmoid-publictransport - Applet that shows departure/arrival board for a given stop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560732 --- Comment #2 from Kevin Kofler ke...@tigcc.ticalc.org 2010-02-08 08:22:49 EST --- First observation: Your specfile claims License: GPLv3+, but according to the headers on the source files, this is actually LGPLv2+. (Don't ask me why it ships only with a GPLv3 COPYING, I don't see a copy of the LGPLv3 nor any version of he LGPLv2 (2 or 2.1), but the source file headers should normally be trusted more. Still, getting upstream to ship a copy of at least one version of the LGPL would be nice.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545408] Review Request: scantailor - post-processing tool for scanned pages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545408 --- Comment #3 from Jan Horak jho...@redhat.com 2010-02-08 08:30:36 EST --- Sorry for long delay, I've got a couple things on higher priority that this. Sending hopefully fixed spec and srpm: Spec URL: http://xhorak.fedorapeople.org/scantailor.spec SRPM URL: http://xhorak.fedorapeople.org/scantailor-0.9.7.2-1.fc12.src.rpm I'm not sure about licence and debuginfo. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561549] Review Request: eclipse-collabnet-merge - CollabNet Merge Client for Subclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561549 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2010-02-08 09:06:47 EST --- I'll take this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561549] Review Request: eclipse-collabnet-merge - CollabNet Merge Client for Subclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561549 --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-02-08 09:10:57 EST --- Mat, I'll wait for 2.0 before reviewing (http://subclipse.tigris.org/ds/viewMessage.do?dsForumId=1043dsMessageId=2444916) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561549] Review Request: eclipse-collabnet-merge - CollabNet Merge Client for Subclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561549 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562158] Review Request: dfish (a generic front-end for selecting files)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562158 Daniel Novotny dnovo...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Daniel Novotny dnovo...@redhat.com 2010-02-08 09:13:20 EST --- New Package CVS Request === Package Name: dfish Short Description: A generic file selection front-end Owners: dnovotny Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560732] Review Request: plasmoid-publictransport - Applet that shows departure/arrival board for a given stop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560732 --- Comment #3 from Thomas Janssen thom...@fedoraproject.org 2010-02-08 09:17:59 EST --- SRPM Url: http://thomasj.fedorapeople.org/reviews/plasmoid-publictransport-0.6.9-1.fc12.src.rpm SPEC Url: http://thomasj.fedorapeople.org/reviews/plasmoid-publictransport.spec - New upstream source 0.6.9 - Changed License to LGPLv2+ - Sent mail to upstream for correct license inclusion (via kde-look.org interface) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558741] Merge Review: mock
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558741 Marcela Mašláňová mmasl...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Marcela Mašláňová mmasl...@redhat.com 2010-02-08 09:24:32 EST --- ACCEPT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 512170] Review Request: pidgin-sipe - Pidgin plugin for connecting to MS Communications Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512170 --- Comment #38 from Fedora Update System upda...@fedoraproject.org 2010-02-08 09:35:07 EST --- pidgin-sipe-1.8.0-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pidgin-sipe-1.8.0-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 512170] Review Request: pidgin-sipe - Pidgin plugin for connecting to MS Communications Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512170 --- Comment #39 from Fedora Update System upda...@fedoraproject.org 2010-02-08 09:35:15 EST --- pidgin-sipe-1.8.0-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pidgin-sipe-1.8.0-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560071] Review Request: php-pecl-augeas - PHP bindings to the Augeas API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560071 --- Comment #7 from Pedro Padron ppad...@w3p.com.br 2010-02-08 09:45:36 EST --- Remi, thanks for the comments! Here's the changelog for the new release: * Mon Feb 08 2010 Pedro Padron ppad...@w3p.com.br - 0.6.0-2 - Changes based on initial package review by Remi Collet - Added CREDITS file - Removed explicit Requires: augeas-libs - Changed Requires: php to Requires: php-common = 5.2.0 - Removed conditional Requires for php(api) - Added check section with a module load test - pecl_name and __install macros are now used properly About the tests, I added the load test you suggested. For the next release (0.7.0) I'll convert the PHPUnit tests to .phpt, which makes more sense when it comes to PECL extensions. I believe that the Wiki entry about PHP packaging could use an update based on your comments. I'll try to do that today (don't know if I can actually edit the page, though). http://fedoraproject.org/wiki/Packaging/PHP Here are the new links: SPEC URL: http://ppadron.blog.br/rpm/specs/php-pecl-augeas.spec SRPM URL: http://ppadron.blog.br/rpm/srpms/php-pecl-augeas-0.6.0-2.fc12.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1968752 Just a question... Your rpmlint output differs from what I got here. Even for the first release, rpmlint did not complain about anything. Do you have additional filters? Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 512170] Review Request: pidgin-sipe - Pidgin plugin for connecting to MS Communications Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512170 --- Comment #40 from David Woodhouse dw...@infradead.org 2010-02-08 09:52:44 EST --- hm, calendar support? What does that do? I found a 'Republish calendar' option in the pidgin menus, but that just made it segfault... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498194 Bug 498194 depends on bug 498837, which changed state. Bug 498837 Summary: Release of libvmime to EPEL-5 https://bugzilla.redhat.com/show_bug.cgi?id=498837 What|Old Value |New Value Status|NEW |CLOSED Resolution||CURRENTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498197] Review Request: zarafa-webaccess-mobile - Zarafa Webaccess Mobile is a simple web interface for mobile phones
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498197 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added Status|NEW |CLOSED Resolution||DEFERRED --- Comment #3 from Robert Scheck redhat-bugzi...@linuxnetz.de 2010-02-08 10:10:18 EST --- Upstream treats zarafa-webaccess-mobile package as dead in favor of z-push, so closing the review hereby. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562847] New: Review Request: bfa-firmware - Brocade Fibre Channel HBA Firmware
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: bfa-firmware - Brocade Fibre Channel HBA Firmware https://bugzilla.redhat.com/show_bug.cgi?id=562847 Summary: Review Request: bfa-firmware - Brocade Fibre Channel HBA Firmware Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: tcall...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://www.auroralinux.org/people/spot/review/new/bfa-firmware.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/bfa-firmware-2.1.2.1-1.fc13.src.rpm Description: Brocade Fibre Channel HBA Firmware. Reviewer note: This is firmware, so there is no source available. This firmware enables the use of Brocade Fibre Channel HBA cards (which use the bfa driver). The license for the firmware meets the criteria for Binary Firmware, set up here: https://fedoraproject.org/wiki/Licensing#Binary_Firmware -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498194 --- Comment #29 from Fedora Update System upda...@fedoraproject.org 2010-02-08 10:15:39 EST --- zarafa-6.30.10-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/zarafa-6.30.10-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498194 --- Comment #31 from Fedora Update System upda...@fedoraproject.org 2010-02-08 10:16:51 EST --- zarafa-6.30.10-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/zarafa-6.30.10-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498194 --- Comment #30 from Fedora Update System upda...@fedoraproject.org 2010-02-08 10:15:42 EST --- zarafa-6.30.10-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/zarafa-6.30.10-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561549] Review Request: eclipse-collabnet-merge - CollabNet Merge Client for Subclipse
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561549 --- Comment #3 from Mat Booth fed...@matbooth.co.uk 2010-02-08 10:33:11 EST --- Hi Alex, 2.0.0 requires Subclipse 1.6.6, which is not available in F12, which is why I submitted version 1.10.0. I was going to update the package to 2.0.0 for Rawhide only after importing, but I can include a 2.0.0 package in this review as well, if you don't mind reviewing two versions. I am out of the country until Wednesday, so I will upload a 2.0.0 package on Thursday. Thanks, Mat -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 544016] Review Request: cbpolicyd - Postfix anti-spam policy server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=544016 --- Comment #3 from Chris St. Pierre chris.a.st.pie...@gmail.com 2010-02-08 10:52:17 EST --- There was a bug in 2.0.10 that prevented recently-autowhitelisted hosts from sending properly, with policyd producing a database error and returning DEFER. I've uploaded a new specfile that includes a patch to fix this bug, and a new SRPM for it: http://www.nebrwesleyan.edu/people/stpierre/cbpolicyd.spec http://www.nebrwesleyan.edu/people/stpierre/cbpolicyd-2.0.10-3.fc12.src.rpm I've also added a cron entry to automatically clean up old entries. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 512170] Review Request: pidgin-sipe - Pidgin plugin for connecting to MS Communications Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=512170 --- Comment #41 from Stefan Becker stefan.bec...@nokia.com 2010-02-08 11:52:17 EST --- (In reply to comment #40) hm, calendar support? What does that do? Despite that it's a M$ product, OCS isn't connected to Exchange. So it doesn't know anything about your calender state, e.g. do not disturb - in a meeting until 12:00. It is the clients' responsibility to provide such information. The client consults the calendar source (currently only Exchange Web Service, but pier11 is already looking into Lotus/Domino support) and then publishes that to OCS. Additionally pidgin-sipe now knows how to handle calendar data in OCS buddy information and shows it in the hover-popup/info windows. I found a 'Republish calendar' option in the pidgin menus, but that just made it segfault... *Ouch* I'm guessing the auto-discovery fails in your case. Can you take a log with pidgin --debug and open a bug report here: https://sourceforge.net/tracker/?group_id=194563atid=949931 Or sent the log directly to me and I'll have a look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-review? --- Comment #2 from Terje Røsten terje...@phys.ntnu.no 2010-02-08 12:29:16 EST --- Review coming up soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560071] Review Request: php-pecl-augeas - PHP bindings to the Augeas API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560071 --- Comment #8 from Remi Collet fed...@famillecollet.com 2010-02-08 12:30:59 EST --- You cannot edit the PHP Guidelines. Changes must be reviewed / approved by FPC See: http://fedoraproject.org/wiki/Packaging/Committee But some changes are already written and approved (just waiting to be moved to official Guidelines) http://fedoraproject.org/wiki/PackagingDrafts/PHP What do you think is missing there ? Your rpmlint output differs from what I .. No, standard rpmlint. I'll convert the PHPUnit tests to .phpt Well, I think PHPUnit is really a good tool ;) probably a better one than .phpt. But that is only your (upstream) choice. I encounter an issue on my machine : httpd segfault on launch when augeas extension is enabled (no problem with php-cli). I need to check if this can be reproduce on another computer (I run PHP 5.3.2-dev) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #3 from Terje Røsten terje...@phys.ntnu.no 2010-02-08 12:42:16 EST --- rpmlint is clean, source tarball has correct check sum, no licenses issues. noarch is correct, own dirs as it should, perms are good. it builds in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1969293 However, there are some minor things to fix, all of which I have created a patch for: - Add python-setuptools to buildreq - Explicit file list - Use version macro in source url The only issue I see is the name, would python-git be a better package name? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #4 from Terje Røsten terje...@phys.ntnu.no 2010-02-08 12:43:50 EST --- Created an attachment (id=389585) -- (https://bugzilla.redhat.com/attachment.cgi?id=389585) Patch to build in koji -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|terje...@phys.ntnu.no -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557546] Review Request: telepathy-sunshine - Gadu-Gadu connection manager for telepathy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557546 Patrick Dignan dignan.patr...@gmail.com changed: What|Removed |Added Flag||needinfo?(beleg...@gmail.co ||m) --- Comment #4 from Patrick Dignan dignan.patr...@gmail.com 2010-02-08 12:56:22 EST --- I tried this one in a new F12 VM that is up-to-date, but I still didn't see an option for adding Gadu-Gadu accounts once I removed telepathy-haze. I can try it in my rawhide VM as well if you'd like. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560170
--- Comment #4 from Mohammed Morsi mmo...@redhat.com 2010-02-08 13:49:17 EST
---
Looks good for most part, builds find in mock/koji and passes most review
guidelines.
A couple of specifics though:
Even though this is in the orphaned specfile, the following line doesn't work
(try it yourself):
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this if you want:
find \( -name '*.class' -o -name '*.jar' \) -exec rm -rf {} \;
or this:
find ./ -name '*.jar' -exec rm -f '{}' \;
find ./ -name '*.class' -exec rm -f '{}' \;
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jcodings/F-11/jcodings.spec?view=markup
I would leave those in and add a bit about gcj support being removed for
jcodings. I had tried getting gcj/jcodings working myself to no avail,
aot-compile-rpm blocks indefinetly, consuming more and more resources. If you
can figure out the problem, adding gcj support is easy, if not just add a note
to the changelog.
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562504
--- Comment #10 from Thomas Spura toms...@fedoraproject.org 2010-02-08
14:02:40 EST ---
(In reply to comment #8)
Furthermore the %check is ran in the build dir, so PYTHONPATH should be set to
PYTHONPATH=openmpi/
for the Open MPI version etc.
If ever, than it should be PYTHONPATH=openmpi/lib.linux-x86_64-2.6, so maybe
PYTHONPATH=openmpi/lib.linux-* ?
I don't like that '*' and would prefer running it, when installed.
Or how do you like the '*' from above?
(In reply to comment #9)
Doesn't work locally, either:
+ mpd --daemon
configuration file /builddir/.mpd.conf not found
A file named .mpd.conf file must be present in the user's home
directory (/etc/mpd.conf if root) with read and write access
only for the user, and must contain at least a line with:
MPD_SECRETWORD=secretword
One way to safely create this file is to do the following:
cd $HOME
touch .mpd.conf
chmod 600 .mpd.conf
and then use an editor to insert a line like
MPD_SECRETWORD=mr45-j9z
into the file. (Of course use some other secret word than mr45-j9z.)
error: Bad exit status from /var/tmp/rpm-tmp.L5Y4a4 (%check)
Bad exit status from /var/tmp/rpm-tmp.L5Y4a4 (%check)
RPM build errors:
ok, I already have such a file here :(
I don't want to add such a file on the buildsystem and without it won't work.
How about disabling the mpich2 testsuite, till there is a 'sane' possibility?
You should run the mpd command right after %{_mpich2_load}. The MPICH2 package
is still blatantly in violation of the guidelines, which is why you can run
MPICH2 commands without loading the MPICH2 module.
Done, works for me locally, but in koji fails becaus openmpi can't be
initialized...
+
PYTHONPATH=/builddir/build/BUILDROOT/mpi4py-1.2-5.fc13.x86_64/usr/lib64/python2.6/site-packages/openmpi
+ python test/runalltest.py
[x86-03.phx2.fedoraproject.org:18162] [[INVALID],INVALID] ORTE_ERROR_LOG: Not
found in file ess_hnp_module.c at line 161
--
It looks like orte_init failed for some reason; your parallel process is
likely to abort. There are many reasons that a parallel process can
fail during orte_init; some of which are due to configuration or
environment problems. This failure appears to be an internal failure;
here's some additional information (which may only be relevant to an
Open MPI developer):
orte_plm_base_select failed
-- Returned value Not found (-13) instead of ORTE_SUCCESS
--
[x86-03.phx2.fedoraproject.org:18162] [[INVALID],INVALID] ORTE_ERROR_LOG: Not
found in file runtime/orte_init.c at line 132
--
It looks like orte_init failed for some reason; your parallel process is
likely to abort. There are many reasons that a parallel process can
fail during orte_init; some of which are due to configuration or
environment problems. This failure appears to be an internal failure;
here's some additional information (which may only be relevant to an
Open MPI developer):
orte_ess_set_name failed
-- Returned value Not found (-13) instead of ORTE_SUCCESS
--
[x86-03.phx2.fedoraproject.org:18162] [[INVALID],INVALID] ORTE_ERROR_LOG: Not
found in file orted/orted_main.c at line 323
[x86-03.phx2.fedoraproject.org:18161] [[INVALID],INVALID] ORTE_ERROR_LOG:
Unable to start a daemon on the local node in file ess_singleton_module.c at
line 381
[x86-03.phx2.fedoraproject.org:18161] [[INVALID],INVALID] ORTE_ERROR_LOG:
Unable to start a daemon on the local node in file ess_singleton_module.c at
line 143
[x86-03.phx2.fedoraproject.org:18161] [[INVALID],INVALID] ORTE_ERROR_LOG:
Unable to start a daemon on the local node in file runtime/orte_init.c at line
132
RPM build errors:
--
It looks like orte_init failed for some reason; your parallel process is
likely to abort. There are many reasons that a parallel process can
fail during orte_init; some of which are due to configuration or
environment problems. This failure appears to be an internal failure;
here's some additional information (which may only be relevant to an
Open MPI developer):
orte_ess_set_name failed
-- Returned value Unable to start a daemon on the local node (-128) instead
of ORTE_SUCCESS
Don't know what to do here, except disabling the tests complete...
Disabled for now:
Spec URL: http://tomspur.fedorapeople.org/review/mpi4py.spec
SRPM URL: http://tomspur.fedorapeople.org/review/mpi4py-1.2-5.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
[Bug 548795] Review Request: belier - Generates scripts allowing you to chain many ssh connections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=548795 Florent Le Coz lo...@louiz.org changed: What|Removed |Added CC||lo...@louiz.org Flag||needinfo?(fab...@bernewirel ||ess.net) --- Comment #5 from Florent Le Coz lo...@louiz.org 2010-02-08 14:00:28 EST --- Any news here? Is the package ok, any new comment/review or anything? Fabian Affolter, what did you meant with - Your package provides an egg. Please have a look at the following page -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558685] Review Request: gloobus-preview - A file previewer for
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558685 --- Comment #7 from Patrick Dignan dignan.patr...@gmail.com 2010-02-08 14:08:53 EST --- Spec URL: http://git.dignan.net/gloobus-rpm.git/blob_plain/HEAD:/gloobus-preview.spec Source1 URL: http://git.dignan.net/packaging/README.fedora.tar.gz SRPM URL: http://git.dignan.net/packaging/gloobus-preview-0.4.1-4.fc12.src.rpm Patch0: http://git.dignan.net/gloobus-rpm.git/blob_plain/HEAD:/gloobus-location-prereconf.patch Fixed desktop file issue. Updated -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560169] Review Request: bytelist - A java library for lists of bytes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560169 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560169] Review Request: bytelist - A java library for lists of bytes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560169
--- Comment #2 from Mohammed Morsi mmo...@redhat.com 2010-02-08 14:11:07 EST
---
Looks good for most part, builds find in mock and passes most review
guidelines.
A couple of specifics though:
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
Also I was able to compile the bytelist rpm w/ the java-gcj features. See the
guidelines / my bytelist spec for how to do so:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
http://mo.morsi.org/files/jruby/bytelist.spec
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/bytelist/F-11/bytelist.spec?view=markup
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562504 --- Comment #11 from Jussi Lehtola jussi.leht...@iki.fi 2010-02-08 14:16:12 EST --- Does the check work in your local build? Check what libraries the python modules link to. My guess is that you've linked also the Open MPI version against mpich2, and it fails due to that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560172
Mohammed Morsi mmo...@redhat.com changed:
What|Removed |Added
CC||mmo...@redhat.com
--- Comment #1 from Mohammed Morsi mmo...@redhat.com 2010-02-08 14:19:55 EST
---
Looks good for most part, builds find in mock and passes most review
guidelines.
A couple of specifics though:
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup
Also I didn't try, but if it works w/ gcj (java-devel = 1.5) adding gcj
support to the spec is relatively easy:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560172 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560170] Review Request: jcodings - Java-based codings helper classes for Joni and JRuby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560170 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added CC||toms...@fedoraproject.org --- Comment #5 from Thomas Spura toms...@fedoraproject.org 2010-02-08 14:47:28 EST --- Jesse, what is this programm for? dist-git? (Just want to know, what work needs to be done, to switch to python3 sometime. This does not build for python3 even after 2to3 running on it :( ) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 495693] Review Request: perl-Syntax-Highlight-Perl6 - Perl 6 Syntax Highlighter
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495693 Iain Arnell iarn...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #12 from Iain Arnell iarn...@gmail.com 2010-02-08 14:45:19 EST --- When did rpmlint start complaining about bad spelling? For the record, I think there's some nasty namespace pollution, but there's nothing conflicting, and nothing technically wrong, so APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558685] Review Request: gloobus-preview - A file previewer for
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558685 --- Comment #8 from Julian Sikorski beleg...@gmail.com 2010-02-08 15:39:04 EST --- Sorry I forgot to tell you earlier, but you need to add icon cache scriptlets: https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache What is more, you need to add libtool to BuildRequres, package does not build in Koji otherwise. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226321] Merge Review: psgml
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226321 Alex Lancaster al...@users.sourceforge.net changed: What|Removed |Added Flag|needinfo?(al...@users.sourc | |eforge.net) | --- Comment #6 from Alex Lancaster al...@users.sourceforge.net 2010-02-08 15:47:53 EST --- (In reply to comment #5) Any news here? I'll try to look at it this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559699] Review Request: RE-REVIEW of qpid-cpp (rename of qpidc)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559699 --- Comment #4 from Nuno Santos nsan...@redhat.com 2010-02-08 16:25:13 EST --- Fabio, as you had requested earlier, I isolated the changes related to the package renaming and applied them to the sources and specfile currently present in F12. The revised SRPM and specfile are available for your review at: SRPM: http://people.redhat.com/~nsantos/qpid-cpp-0.5.829175-4.fc13.src.rpm spec: http://people.redhat.com/~nsantos/qpid-cpp.spec There are two patches to allow compilation under rawhide, they are being (or are already) integrated upstream. Thanks, Nuno -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478683] Review Request: perl-Net-Google-AuthSub - Provides interface to interact with sites that implement Google style AuthSub
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478683 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-02-08 16:51:10 EST --- perl-Net-Google-AuthSub-0.5-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Net-Google-AuthSub-0.5-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 478683] Review Request: perl-Net-Google-AuthSub - Provides interface to interact with sites that implement Google style AuthSub
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=478683 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-02-08 16:51:15 EST --- perl-Net-Google-AuthSub-0.5-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Net-Google-AuthSub-0.5-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559653] Review Request: perl-Class-Generate - Generate Perl class hierarchies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559653 Pedro Padron ppad...@w3p.com.br changed: What|Removed |Added Alias||perl-Class-Generate --- Comment #2 from Pedro Padron ppad...@w3p.com.br 2010-02-08 17:00:09 EST --- Changelog for new release: - Removed Provides: filter in prep section - Added cpan_name macro Spec URL: http://ppadron.blog.br/rpm/specs/perl-Class-Generate.spec SRPM URL: http://ppadron.blog.br/rpm/srpms/perl-Class-Generate-1.10-2.fc12.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1970313 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 551913] Review Request: monodevelop-vala - A vala plugin for monodevelop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=551913 --- Comment #9 from Paul Lange pala...@gmx.de 2010-02-08 17:07:22 EST --- Paul, think you should set the cvs-request flag to '?' !? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562977] Review Request: vifm - Lightweight file manager with vi like keybindings
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562977 Pierre Dorbais pierre.dorb...@free.fr changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559686] Review Request: perl-Nmap-Scanner - Perform and manipulate nmap scans using perl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559686 --- Comment #1 from Pedro Padron ppad...@w3p.com.br 2010-02-08 17:16:03 EST --- Changelog for new release: - Added explicit 'Provides' for the subpackages RPM cannot detect This change was based on the discussion at Fedora Packaging mailing list: http://lists.fedoraproject.org/pipermail/packaging/2010-February/006860.html Spec URL: http://ppadron.blog.br/rpm/specs/perl-Nmap-Scanner.spec SRPM URL: http://ppadron.blog.br/rpm/srpms/perl-Nmap-Scanner-1.0-2.fc12.src.rpm Cannot create a Koji scratch build since it depends on a package that hasn't been approved yet (perl-Class-Generate - Bug #559653). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540617] Review Request: django-lint - lint for (python) django web-framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540617 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name --- Comment #8 from Till Maas opensou...@till.name 2010-02-08 17:45:58 EST --- Did you perform some unofficial reviews on other packages? This is usually done by new people seeking sponsorship to show, that they know the packaging guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226321] Merge Review: psgml
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226321
--- Comment #7 from Alex Lancaster al...@users.sourceforge.net 2010-02-08
17:48:00 EST ---
(In reply to comment #2)
New build here:
http://koji.fedoraproject.org/koji/buildinfo?buildID=155021
Diff between new spec and old spec in CVS:
http://cvs.fedoraproject.org/viewvc/rpms/psgml/devel/psgml.spec?r1=1.24r2=1.25
Summary: No dot at the end please
Fixed.
name: Capital letter at the beginning
Fixed.
Prereq: should not be used, I doubt it really is one. sgml-common is a
Requires and BuildRequires.
Fixed.
Is the license tag really correct? I could not find anything in the sources.
URL tag is missing
Added.
BuildRoot: is invalid, should be
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
see https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
Fixed.
Prefix: /usr: drop this completely. Will be set automatically and using
absolute paths is strictly forbidden
Dropped.
Requires: emacs is missing
Added.
%define psgmldir %{prefix}/share/emacs/site-lisp/psgml/: use %global, see
https://fedoraproject.org/wiki/PackagingDrafts/global_preferred_over_define
%{prefix}/share/ should be %{_datadir} here
Fixed.
%description: line breaks at 80 characters
Line breaking was at 70 chars, now at 80 chars.
%build:
PATH=/usr/bin:$PATH this is most likely unnecessary
Removed.
./configure --prefix=/usr: Hardcoded paths are strictly forbidden, just use
%configure here.
Done.
Use parallel make if possible. If not, write a comment, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make
During build I see a lot of errors like this one:
Warning: !! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon. See (elisp)Backquote in the manual.
Please look into this.
psgml is a very old and currently unmaintained upstream AFAIK. I will look
into whether it's possible to easily fix this in a later revision.
%install:
When creating psgml-init.el you should also use macros, %{psgmldir} instead
of
/usr/share/emacs/site-lisp/psgml, %{_sysconfdir} instead of /etc and so on
mkdir -p $RPM_BUILD_ROOT/%{prefix}/share/sgml/cdtd: use %{_datadir} instead of
%{prefix}/share
Used %{_datadir} and %{_sysconfdir} throughout .spec
Timestamps are not preserved during install, add INSTALL=install -p
The install-info scriptlets lack the || : at the end of the line and the
%postun scriptlet is wrong, should be run in %preun, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo
Added || : and made postun script a preun script as per above link.
%files:
%defattr should be (-,root,root,-)
Fixed
%{prefix}/share/sgml/cdtd should be %{_datadir}/sgml/cdtd
Fixed.
ChangeLog and psgml.texi are missing from %doc
Added.
ChangeLog, psgml.texi and psgml.info.gz are not UTF-8, please convert them as
described in
https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Convert_encoding_to_UTF-8
Fixed.
Now the full checklist. All FIX or ??? items are explained above.
FIX - MUST: rpmlint
$ rpmlint noarch/psgml-1.2.5-9.fc12.noarch.rpm
psgml.noarch: W: summary-ended-with-dot A GNU Emacs major mode for editing
SGML
documents.
psgml.noarch: E: tag-not-utf8 %changelog
psgml.noarch: W: no-url-tag
psgml.noarch: W: file-not-utf8 /usr/share/info/psgml.info.gz
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
New rpmlint run:
rpmlint noarch/psgml-1.2.5-12.fc13.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
FIX - MUST: The package meets the Packaging Guidelines.
Should be fixed now.
??? - MUST: The License field in the package spec file matches the actual
license.
Headers in .el files contain GPLv2+ license, e.g.:
;; This program is free software; you can redistribute it and/or
;; modify it under the terms of the GNU General Public License
;; as published by the Free Software Foundation; either version 2
;; of the License, or (at your option) any later version.
which is GPLv2+ AFAIK.
FIX - MUST: The license file from the source package is included in %doc.
Upstream didn't include separate COPYING file, not strictly necessary and since
upstream is dead, not much point in filing a bug there.
.
FIX - MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
I think this should be fixed now.
SHOULD Items:
??? - SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
See above.
FIX - SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity.
Should be fixed now.
--
Configure bugmail:
[Bug 562992] New: Review Request: rubygem-syntax - Ruby library for performing simple syntax highlighting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-syntax - Ruby library for performing simple syntax highlighting https://bugzilla.redhat.com/show_bug.cgi?id=562992 Summary: Review Request: rubygem-syntax - Ruby library for performing simple syntax highlighting Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mmo...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://mo.morsi.org/files/gems/rubygem-syntax.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-syntax-1.0.0-1.fc12.src.rpm Description: Syntax is a Ruby library for performing simple syntax highlighting. rpmlint rpmbuild/RPMS/noarch/rubygem-syntax-1.0.0-1.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint rpmbuild/SRPMS/rubygem-syntax-1.0.0-1.fc12.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1970399 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498194 Pavel Lisý pavel.l...@gmail.com changed: What|Removed |Added CC||pavel.l...@gmail.com --- Comment #32 from Pavel Lisý pavel.l...@gmail.com 2010-02-08 19:09:05 EST --- How can I help to push it in repository? I want to test it (and make karma better) but there is many packages, can I install it through repository somehow? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563001] New: Review Request: remmina-xfce - Xfce panel plugin for remmina remote desktop client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: remmina-xfce - Xfce panel plugin for remmina remote desktop client https://bugzilla.redhat.com/show_bug.cgi?id=563001 Summary: Review Request: remmina-xfce - Xfce panel plugin for remmina remote desktop client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cwick...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://cwickert.fedorapeople.org/review/remmina-xfce.spec SRPM URL: http://cwickert.fedorapeople.org/review/remmina-xfce-0.7.1-1.fc13.src.rpm Description: Remmina is a remote desktop client written in GTK+, aiming to be useful for system administrators and travellers, who need to work with lots of remote computers in front of either large monitors or tiny netbooks. Remmina supports multiple network protocols in an integrated and consistant user interface. Currently RDP, VNC, XDMCP and SSH are supported. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563001] Review Request: remmina-xfce - Xfce panel plugin for remmina remote desktop client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563001 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Depends on||553402 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563000] New: Review Request: rubygem-compass - A Sass-based CSS Meta-Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rubygem-compass - A Sass-based CSS Meta-Framework https://bugzilla.redhat.com/show_bug.cgi?id=563000 Summary: Review Request: rubygem-compass - A Sass-based CSS Meta-Framework Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mmo...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://mo.morsi.org/files/gems/rubygem-compass.spec SRPM URL: http://mo.morsi.org/files/gems/rubygem-compass-0.8.17-1.fc12.src.rpm Description: A Sass-based CSS Meta-Framework that allows you to mix and match any of the following CSS frameworks: Compass Core, Blueprint, 960, Susy, YUI, and others. rpmlint rpmbuild/RPMS/noarch/rubygem-compass-0.8.17-1.fc12.noarch.rpm rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/ProjectBase/explicit_config_file_must_be_readable%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Tree/NodeInsertion/descendant%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Support/mac%3f-c.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Configuration/relative_assets%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Sass/Plugin/exact_stylesheet_needs_update%3f-c.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Cache/Common/has_child%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Exec/Compass/parse%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Tree/Node/%3c%3d%3e-i.yaml %3c rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/CreateProject/is_project_creation%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Support/carbon_core%3f-c.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Configuration/set_defaults%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Installers/Base/compilation_required%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/NilClass/blank%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/InstallerCommand/configure%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/StampPattern/is_project_creation%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/ConfigHelpers/configure_sass_plugin%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Installers/StandAloneInstaller/config_files_exist%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/WriteConfiguration/explicit_config_file_must_be_readable%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Frameworks/%5b%5d-i.yaml %5b rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Exec/Compass/perform%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/ProjectBase/configure%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Installers/RailsInstaller/config_files_exist%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Cache/descendant%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Installers/StandAloneInstaller/compilation_required%3f-i.yaml %3f rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/Compass/Commands/ProjectBase/assert_project_directory_exists%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro /usr/lib/ruby/gems/1.8/doc/compass-0.8.17/ri/FSSM/Cache/Common/child%21-i.yaml %21 rubygem-compass.noarch: W: misspelled-macro
[Bug 562992] Review Request: rubygem-syntax - Ruby library for performing simple syntax highlighting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562992 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Blocks||562997 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562997] Review Request: rubygem-maruku - Markdown-superset interpreter written in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562997 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Blocks||562998 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562998] Review Request: rubygem-haml - An elegant, structured XHTML/XML templating engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562998 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Depends on||562993 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562998] Review Request: rubygem-haml - An elegant, structured XHTML/XML templating engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562998 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Depends on||562997 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562998] Review Request: rubygem-haml - An elegant, structured XHTML/XML templating engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562998 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Blocks||563000 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563000] Review Request: rubygem-compass - A Sass-based CSS Meta-Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563000 Mohammed Morsi mmo...@redhat.com changed: What|Removed |Added Depends on||562998 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 491790] Review Request: mediawiki-SpamBlacklist - An extension to provide a Spam Blacklist management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491790 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |CLOSED Blocks|182235(FE-Legal)|201449(FE-DEADREVIEW) Resolution||NOTABUG --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2010-02-08 19:26:32 EST --- I'm going ahead and closing this given the AWOL status of the submitter. Should anyone wish to resubmit, please address the legal issue first. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 208250] Review Request: piklab - Development environment for applications based on PIC and dsPIC microcontrollers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=208250 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #37 from Kevin Fenzi ke...@tummy.com 2010-02-08 19:32:44 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545004 --- Comment #7 from Kevin Fenzi ke...@tummy.com 2010-02-08 19:35:39 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562158] Review Request: dfish (a generic front-end for selecting files)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562158 --- Comment #5 from Kevin Fenzi ke...@tummy.com 2010-02-08 19:36:19 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524437] Review Request: nss_updatedb - Maintains a local cache of network directory user and group information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524437 --- Comment #10 from Kevin Fenzi ke...@tummy.com 2010-02-08 19:34:47 EST --- CVS done (by process-cvs-requests.py). Note: we are not yet doing F-13 branches. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560169] Review Request: bytelist - A java library for lists of bytes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560169
--- Comment #3 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-08
20:14:24 EST ---
(In reply to comment #2)
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
fixed according to the Specfile Template for ant
https://fedoraproject.org/wiki/Packaging:Java#ant_2
Also I was able to compile the bytelist rpm w/ the java-gcj features. See the
guidelines / my bytelist spec for how to do so:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
http://mo.morsi.org/files/jruby/bytelist.spec
Clarification why the gcj bits was removed is here:
https://bugzilla.redhat.com/show_bug.cgi?id=560170#c5
Also, please note, the Specfile Template for ant doesn't contain gcj bits.
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
fixed.
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/bytelist/F-11/bytelist.spec?view=markup
fixed.
The second release is prepared for review:
Spec URL: http://victorv.fedorapeople.org/files/bytelist.spec
SRPM URL: http://victorv.fedorapeople.org/files/bytelist-1.0.3-2.fc13.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #7 from Jesse Keating jkeat...@redhat.com 2010-02-08 20:19:21 EST --- This is for dist-git yes. Hrm, this builds in koji fine, why does it need python-setuptools as a BuildRequirement ? I used GitPython as that is the upstream project name. That seems to fall under the naming guidelines for python http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 since GitPython has Py in the name. I'll look at the other issues and re-post. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545004] Review Request: wqy-microhei-fonts - compact Chinese font
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545004 Jens Petersen peter...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #8 from Jens Petersen peter...@redhat.com 2010-02-08 20:20:08 EST --- Thanks for the review: package is imported and built. Thanks to wenq.org for microhei. http://koji.fedoraproject.org/koji/taskinfo?taskID=1970500 I think phuang is considering microhei as a potential Chinese default font instead of zenhei. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563013] New: Review Request: gnome-applet-remmina - GNOME panel applet for Remmina remote desktop client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: gnome-applet-remmina - GNOME panel applet for Remmina remote desktop client https://bugzilla.redhat.com/show_bug.cgi?id=563013 Summary: Review Request: gnome-applet-remmina - GNOME panel applet for Remmina remote desktop client Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: cwick...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://cwickert.fedorapeople.org/review/gnome-applet-remmina.spec SRPM URL: http://cwickert.fedorapeople.org/review/gnome-applet-remmina-0.7.1-1.fc13.src.rpm Description: Remmina is a remote desktop client written in GTK+, aiming to be useful for system administrators and travelers, who need to work with lots of remote computers in front of either large monitors or tiny netbooks. Remmina supports multiple network protocols in an integrated and consistent user interface. Currently RDP, VNC, XDMCP and SSH are supported. This package includes the GNOME panel applet for Remmina. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553402] Review Request: remmina - A GTK+ Remote Desktop Client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553402 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Blocks||563013 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563013] Review Request: gnome-applet-remmina - GNOME panel applet for Remmina remote desktop client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563013 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Depends on||553402 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563001] Review Request: xfce4-remmina-plugin - Xfce panel plugin for remmina remote desktop client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563001 Christoph Wickert cwick...@fedoraproject.org changed: What|Removed |Added Summary|Review Request: |Review Request: |remmina-xfce - Xfce panel |xfce4-remmina-plugin - Xfce |plugin for remmina remote |panel plugin for remmina |desktop client |remote desktop client --- Comment #1 from Christoph Wickert cwick...@fedoraproject.org 2010-02-08 20:29:14 EST --- I decided to rename this to xfce4-remmina-plugin for more consistency with the other Xfce plugins. I also added a virtual provides on the upstream name for easier installation. Spec: http://cwickert.fedorapeople.org/review/xfce4-remmina-plugin.spec SRPM: http://cwickert.fedorapeople.org/review/xfce4-remmina-plugin-0.7.1-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562445] Review Request: GitPython - Python Git Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562445 --- Comment #8 from Jesse Keating jkeat...@redhat.com 2010-02-08 20:42:46 EST --- Spec URL: http://jkeating.fedorapeople.org/review/GitPython.spec SRPM URL: http://jkeating.fedorapeople.org/review/GitPython-0.1.6-2.fc12.src.rpm Updated with suggested changes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560172] Review Request: jvyamlb - YAML processor for JRuby
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=560172
--- Comment #2 from Victor G. Vasilyev victor.vasil...@sun.com 2010-02-08
21:13:43 EST ---
(In reply to comment #1)
The following line doesn't work as intended:
find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;
You can replace it w/ this:
find \( -name '*.jar' -o -name '*.class' \) -exec rm -rf {} \;
fixed according to the Specfile Template for ant
https://fedoraproject.org/wiki/Packaging:Java#ant_2
As far as the changelog you have a typo, Jun 2010 should be Jan 2010.
fixed
Also why did you remove the previous entries from the changelog
http://cvs.fedoraproject.org/viewvc/rpms/jvyamlb/F-11/jvyamlb.spec?view=markup
No, changelog in the release 0.2.5-3 contains full history.
Also I didn't try, but if it works w/ gcj (java-devel = 1.5) adding gcj
support to the spec is relatively easy:
http://fedoraproject.org/wiki/Packaging/GCJGuidelines
Releases of the package was never containing gcj bits.
We shouldn't add stuff of the deprecated technology into this package.
Clarification is here:
https://bugzilla.redhat.com/show_bug.cgi?id=560170#c5
The release 4 is prepared for review:
Spec URL: http://victorv.fedorapeople.org/files/jvyamlb.spec
SRPM URL: http://victorv.fedorapeople.org/files/jvyamlb-0.2.5-4.fc13.noarch.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559856] Review Request: libbsd - Library providing BSD-compatible functions for portability
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559856 Eric Smith e...@brouhaha.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #19 from Eric Smith e...@brouhaha.com 2010-02-08 22:03:39 EST --- New Package CVS Request === Package Name: libbsd Short Description: Library providing BSD-compatible functions for portability Owners: brouhaha Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562330] Review Request: libnih - Lightweight application development library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=562330
--- Comment #5 from Eric Smith e...@brouhaha.com 2010-02-08 22:20:37 EST ---
I've confirmed that it now builds with mock for Fedora 12 x86_64, the resulting
RPMs install, and nih-dbus-tool works at least as far as getting a usage
message. (I don't know how to test beyond that.) I agree that everything but
the rpmlint hardcoded-library-path error and the licensing issue have been
fixed.
rpmlint reports:
libnih.spec:63: E: hardcoded-library-path in %{_prefix}/lib/pkgconfig/*
libnih.x86_64: W: unused-direct-shlib-dependency /lib64/libnih-dbus.so.1.0.0
/lib64/libpthread.so.0
3 packages and 1 specfiles checked; 1 errors, 1 warnings.
I'm not sure why it's getting the warning.
The package looks good other than the hardcoded-library-path and the licensing
issue. Have you submitted a ticked upstream to get the licensing fixed? I
don't think I can approve the package with either issue (I've already been
chastised once for approving a package where I overlooked some source files
without copyright/license information), but if another reviewer is willing to
do it, they should feel free to reassign this review request to themself.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563044] New: Review Request: system-setup-keyboard - Hal keyboard layout callout
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: system-setup-keyboard - Hal keyboard layout callout https://bugzilla.redhat.com/show_bug.cgi?id=563044 Summary: Review Request: system-setup-keyboard - Hal keyboard layout callout Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: peter.hutte...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://fedorapeople.org/~whot/system-setup-keyboard.spec SRPM URL: http://fedorapeople.org/~whot/system-setup-keyboard-0.7-1.fc12.src.rpm Description: system-setup-keyboard gets invoked by hal to apply the keyboard layout defined in /etc/sysconfig/keyboard. This is a package rename request. Current package name is fedora-setup-keyboard. Since this package will be used in other distributions too, the package was renamed upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563044] Review Request: system-setup-keyboard - Hal keyboard layout callout
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563044 Peter Hutterer peter.hutte...@redhat.com changed: What|Removed |Added CC||adel.gadl...@gmail.com Blocks||560811 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553483] Review Request: dogtag-pki-console-ui - The Dogtag PKI Console User Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553483 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.3.0-4.fc11|1.3.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553845] Review Request: dogtag-pki-tks-ui - The Dogtag Token Key Service User Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553845 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.3.0-4.fc11|1.3.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553843] Review Request: dogtag-pki-ocsp-ui The Dogtag Online Certificate Status Protocol User Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553843 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|1.3.0-4.fc11|1.3.0-4.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553843] Review Request: dogtag-pki-ocsp-ui The Dogtag Online Certificate Status Protocol User Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553843 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-02-08 22:57:21 EST --- dogtag-pki-ocsp-ui-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553483] Review Request: dogtag-pki-console-ui - The Dogtag PKI Console User Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553483 --- Comment #26 from Fedora Update System upda...@fedoraproject.org 2010-02-08 22:56:39 EST --- dogtag-pki-console-ui-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553845] Review Request: dogtag-pki-tks-ui - The Dogtag Token Key Service User Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553845 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-02-08 22:56:56 EST --- dogtag-pki-tks-ui-1.3.0-4.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
