[Bug 566529] Review Request: perl-Config-MVP - Multivalue-property package-oriented configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566529 --- Comment #5 from Fedora Update System 2010-02-21 02:49:22 EST --- perl-Config-MVP-0.093350-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/perl-Config-MVP-0.093350-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566529] Review Request: perl-Config-MVP - Multivalue-property package-oriented configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566529 --- Comment #6 from Fedora Update System 2010-02-21 02:49:26 EST --- perl-Config-MVP-0.093350-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Config-MVP-0.093350-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566529] Review Request: perl-Config-MVP - Multivalue-property package-oriented configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566529 --- Comment #4 from Fedora Update System 2010-02-21 02:49:16 EST --- perl-Config-MVP-0.093350-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Config-MVP-0.093350-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561985] Review Request: php-phpunit-phpdcd - Dead Code Detector (DCD) for PHP code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561985 Remi Collet changed: What|Removed |Added CC||fed...@famillecollet.com AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review+ --- Comment #1 from Remi Collet 2010-02-21 02:33:45 EST --- REVIEW + rpmlint php-phpunit-phpdcd.spec: I: checking-url http://pear.phpunit.de/get/phpdcd-0.9.2.tgz (timeout 10 seconds) php-phpunit-phpdcd.src: I: checking php-phpunit-phpdcd.src: I: checking-url http://github.com/sebastianbergmann/phpdcd (timeout 10 seconds) php-phpunit-phpdcd.src: I: checking-url http://pear.phpunit.de/get/phpdcd-0.9.2.tgz (timeout 10 seconds) php-phpunit-phpdcd.noarch: I: checking php-phpunit-phpdcd.noarch: I: checking-url http://github.com/sebastianbergmann/phpdcd (timeout 10 seconds) php-phpunit-phpdcd.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 1 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources is provided + sources match the upstream sources 328c7d9e95fc9b0078b180bbb8c532d1 PHP_TokenStream-0.9.1.tgz + Source URL ok + build on F12.x86_64 + BuildRequires ok php-pear >= 1:1.8.1 php-channel(pear.phpunit.de) + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + no %define + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + no test suite (Tests dir in git not provided in tarball) + scriptlets ok - Final Requires /usr/bin/pear /usr/bin/php php-channel(pear.phpunit.de) php-common >= 5.2.0 php-pear(components.ez.no/ConsoleTools) >= 1.6 php-pear(pear.phpunit.de/File_Iterator) >= 1.1.0 php-pear(pear.phpunit.de/PHP_TokenStream) >= 0.9.1 + Final Provides ok php-pear(pear.phpunit.de/phpdcd) = 0.9.2 php-phpunit-phpdcd = 0.9.2-1.fc8 * APPROVED * -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 --- Comment #18 from Mamoru Tasaka 2010-02-21 02:24:24 EST --- fedora-cvs flag is not needed currently. This package already exists on Fedora and the owner is already changed correctly. (CVS request not needed either) Jens, please follow http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)". Then next "Check out the module" and import your srpm into Fedora CVS and rebuild them on koji. And also check http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 --- Comment #15 from Mamoru Tasaka 2010-02-21 02:25:12 EST --- When you write CVS admin request here, please set fedora-cvs flag to ? again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 537363] Review Request: lv2-c++-tools - Support library for writing LV2 plugins in C++
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=537363 Orcan 'oget' Ogetbil changed: What|Removed |Added Blocks||567028 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567028] Review Request: lv2-ll-plugins - Collection of LV2 plugins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567028 Orcan 'oget' Ogetbil changed: What|Removed |Added Depends on||537363 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 --- Comment #14 from Mamoru Tasaka 2010-02-21 02:18:50 EST --- Jens, please follow http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure and write CVS admin request here. Current valid branches are F-11/12/13 EL-4/5 (I don't know about OLPC well). devel branch is implicitly added. After CVS admins set fedora-cvs flag to +, please follow http://fedoraproject.org/wiki/PackageMaintainers/Join again as I wrote in comment 9. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567028] New: Review Request: lv2-ll-plugins - Collection of LV2 plugins
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: lv2-ll-plugins - Collection of LV2 plugins https://bugzilla.redhat.com/show_bug.cgi?id=567028 Summary: Review Request: lv2-ll-plugins - Collection of LV2 plugins Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: oget.fed...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://oget.fedorapeople.org/review/lv2-ll-plugins.spec SRPM URL: http://oget.fedorapeople.org/review/lv2-ll-plugins-0.2.8-1.fc12.src.rpm Description: lv2-ll-plugins is a small collection of LV2 plugins, including an arpeggiator, a MIDI keyboard, a drum-machine, a peak meter; and a host that runs them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561981] Review Request: php-phpunit-PHP-TokenStream - Wrapper around PHP's tokenizer extension
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561981 Remi Collet changed: What|Removed |Added CC||fed...@famillecollet.com AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review+ --- Comment #1 from Remi Collet 2010-02-21 02:16:39 EST --- REVIEW + rpmlint php-phpunit-PHP-TokenStream.spec: I: checking-url http://pear.phpunit.de/get/PHP_TokenStream-0.9.1.tgz (timeout 10 seconds) php-phpunit-PHP-TokenStream.src: I: checking php-phpunit-PHP-TokenStream.src: W: spelling-error Summary(en_US) PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.src: W: spelling-error Summary(en_US) tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.src: W: spelling-error %description -l en_US PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.src: W: spelling-error %description -l en_US tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.src: I: checking-url http://github.com/sebastianbergmann/php-token-stream (timeout 10 seconds) php-phpunit-PHP-TokenStream.src: I: checking-url http://pear.phpunit.de/get/PHP_TokenStream-0.9.1.tgz (timeout 10 seconds) php-phpunit-PHP-TokenStream.noarch: I: checking php-phpunit-PHP-TokenStream.noarch: W: spelling-error Summary(en_US) PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.noarch: W: spelling-error Summary(en_US) tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.noarch: W: spelling-error %description -l en_US PHP's -> HP's, PCP's, P HP's php-phpunit-PHP-TokenStream.noarch: W: spelling-error %description -l en_US tokenizer -> tokenism, token, patronizer php-phpunit-PHP-TokenStream.noarch: I: checking-url http://github.com/sebastianbergmann/php-token-stream (timeout 10 seconds) php-phpunit-PHP-TokenStream.noarch: W: no-documentation 2 packages and 1 specfiles checked; 0 errors, 9 warnings. + package name ok + spec file name ok + package meet the PHP Guidelines + License ok : BSD + License is upstream + spec in english and legible + no license file in sources is provided + sources match the upstream sources 328c7d9e95fc9b0078b180bbb8c532d1 PHP_TokenStream-0.9.1.tgz + Source URL ok + build on F12.x86_64 + BuildRequires ok php-pear >= 1:1.8.1 php-channel(pear.phpunit.de) + no locale + no .so + own all directories that it creates + no duplicate file + %defattr ok + %clean section + use macros consistently + no %define + contain code + no documentation + no devel + no pkgconfig + no sub-package + no GUI + don't own files or directories already owned by other packages + %install start with rm -rf + valid UTF-8 + build in koji + no test suite (Tests dir in git not provided,) + scriptlets ok - Final Requires /usr/bin/pear php-channel(pear.phpunit.de) php-common >= 5.2.0 php-tokenizer + Final Provides ok php-pear(pear.phpunit.de/PHP_TokenStream) = 0.9.1 php-phpunit-PHP-TokenStream = 0.9.1-1.fc8 + Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2002482 removing the PHP's in sumnary should be fine. * APPROVED * -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567027] Review Request: flowcanvas - Interactive widget for "boxes and lines" environments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567027 Orcan 'oget' Ogetbil changed: What|Removed |Added CC||alibo...@gmail.com --- Comment #1 from Orcan 'oget' Ogetbil 2010-02-21 01:54:13 EST --- *** Bug 524190 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524190] Review Request: flowcanvas - an interactive Gtkmm/Gnomecanvasmm widget for “boxes and lines” environments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524190 Orcan 'oget' Ogetbil changed: What|Removed |Added Resolution|NOTABUG |DUPLICATE --- Comment #12 from Orcan 'oget' Ogetbil 2010-02-21 01:54:13 EST --- *** This bug has been marked as a duplicate of bug 567027 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567027] New: Review Request: flowcanvas - Interactive widget for "boxes and lines" environments
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: flowcanvas - Interactive widget for "boxes and lines" environments https://bugzilla.redhat.com/show_bug.cgi?id=567027 Summary: Review Request: flowcanvas - Interactive widget for "boxes and lines" environments Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: oget.fed...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://oget.fedorapeople.org/review/flowcanvas.spec SRPM URL: http://oget.fedorapeople.org/review/flowcanvas-0.6.0-1.fc12.src.rpm Description: FlowCanvas is an interactive Gtkmm/Gnomecanvasmm widget for graph-based interfaces (patchers, modular synthesizers, finite state automata, interactive graphs, etc). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546451] Review Request: php-pear-HTML-Template-IT - Simple template API.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=546451
--- Comment #6 from Remi Collet 2010-02-21 01:52:56
EST ---
You need to fix :
- replace %define by %global
- remove PEAR from sumnary
- review description (line breaks are randomly and poorly set). Upstream
description seems quite strange (I noticed... you...).
- %{pear_phpdir}/HTML must be owned (not owned by another required package)
- %{pear_phpdir}/HTML/Template must be owned
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563481] Review Request: aduna-commons-i18n - Internationalization and localization utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=563481
Orcan 'oget' Ogetbil changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||oget.fed...@gmail.com
AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
Flag||fedora-review+
--- Comment #2 from Orcan 'oget' Ogetbil 2010-02-21
01:46:37 EST ---
I reviewed this package. There are a few minor things but none of them are
blockers. Please read through and modify the specfile if there is need before
you commit
! rpmlint says:
aduna-commons-i18n.src:123: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
This can be ignored. By the way you can get rid of the
"%attr(-,root,root)" part
aduna-commons-i18n.x86_64: W: no-documentation
This can be ignored
aduna-commons-i18n.x86_64: W: non-conffile-in-etc
/etc/maven/fragments/aduna-commons-i18n
This can be ignored
! %description for javadoc subpackage should not be the same description for
the main package.
? This looks like a SUSE convention
%{_javadocdir}/%{name}-%{version}
%{_javadocdir}/%{name}
Do we have this in Fedora? If not, please remove the symlink.
! It looks like the following BR's are not really needed:
BuildRequires: maven2
BuildRequires: maven2-plugin-compiler
BuildRequires: maven2-plugin-javadoc
BuildRequires: maven-plugin-bundle
These will be pulled in by other dependencies so it won't do harm to leave them
but the following , I think, is absolutely not needed.
BuildRequires: maven-surefire-provider-junit
-
This package (aduna-commons-i18n) is APPROVED by oget
-
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565916] Review Request: php-ezc-Graph - A component for creating pie charts, line graphs and other kinds of diagrams
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565916 Remi Collet changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Remi Collet 2010-02-21 01:40:25 EST --- New Package CVS Request === Package Name: php-ezc-Graph Short Description: A component for creating charts, graphs and diagrams Owners: remi Branches: F-11 F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565916] Review Request: php-ezc-Graph - A component for creating pie charts, line graphs and other kinds of diagrams
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565916 --- Comment #2 from Remi Collet 2010-02-21 01:38:42 EST --- Thanks for the review. Yes "date()" are only warning. Perhaps we should investigate on hos to avoid this... (define the TZ in the builder ?) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540761] Review Request: deja-dup - Simple backup tool and frontend for duplicity
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540761 Matthias Clasen changed: What|Removed |Added CC||mcla...@redhat.com --- Comment #24 from Matthias Clasen 2010-02-20 23:24:45 EST --- any update on this ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566962
--- Comment #3 from Chen Lei 2010-02-20 23:02:54 EST ---
> Since I'm not approved, I'm able to give you an unofficial review
>
> rpmlint polipo-1.0.4.1-1.fc12.src.rpm polipo.spec
> polipo.src: W: spelling-error %description -l en_US pipelining -> pipe lining,
> pipe-lining, pipeline
Not spelling error indeed,See http://en.wikipedia.org/wiki/HTTP_pipelining
> polipo.src: W: invalid-url URL www.pps.jussieu.fr/~jch/software/polipo/
Fixed
> polipo.src: W: strange-permission polipo.init 0755
most files in the /etc/rc.d/init.d should be 0755.
> polipo.src:65: W: mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 1)
Fixed
> polipo.spec:65: W: mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 1)
> 1 packages and 1 specfiles checked; 0 errors, 5 warnings.
>
Fixed
> Looking deeper to the spec-file:
>
> - URL-Entry should start with http://
Fixed
> - yum provides /sbin/install-info lists info as package providing
> /sbin/install-info. If you definitely need it for pre and post-section, take
> info. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires Lists
> info as package, that doesn't need to be included.
Modified based on
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo
> - $RPM_BUILD_ROOT and %{buildroot}-Macros should not be mixed.
> (https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS)
Fixed
>
> Mock builds fine.
> Ok, looking deeper:
> +:ok, =:needs attention, -:needs fixing
>
> [+] MUST: rpmlint must be run on every package.
> (see above)
> [+] MUST: The package must be named according to the Package Naming
> Guidelines.
> [+] MUST: The spec file name must match the base package %{name}
> [=] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this
> list and more]
> [+] MUST: The package must be licensed with a Fedora approved license and meet
> the Licensing Guidelines.
> [+] MUST: The License field in the package spec file must match the actual
> license.
> [+] MUST: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package must be included in %doc.
> [+] MUST: The spec file must be written in American English.
> [+] MUST: The spec file for the package MUST be legible.
> [+] MUST: The sources used to build the package must match the upstream
> source,
> as provided in the spec URL.
> <>
> [+] MUST: The package must successfully compile and build into binary rpms on
> at least one supported architecture.
> [+] MUST: If the package does not successfully compile, build or work on an
> architecture, then those architectures should be listed in the spec in
> ExcludeArch.
> [-] MUST: All build dependencies must be listed in BuildRequires
Which dependencies are missing in BuildRequires?
> [=] MUST: The spec file MUST handle locales properly. This is done by using
> the
> %find_lang macro.
> [*] MUST: Every binary RPM package which stores shared library files (not just
> symlinks) in any of the dynamic linker's default paths, must call ldconfig in
> %post and %postun.
> [*] MUST: If the package is designed to be relocatable, the packager must
> state
> this fact in the request for review
> [-] MUST: A package must own all directories that it creates. If it does not
> create a directory that it uses, then it should require a package which does
> create that directory.
How to fix it? I think I already own all directories.
> [+] MUST: A package must not contain any duplicate files in the %files
> listing.
> [+] MUST: Permissions on files must be set properly. Executables should be set
> with executable permissions, for example. Every %files section must include a
> %defattr(...) line.
> [+] MUST: Each package must have a %clean section, which contains rm -rf
> %{buildroot} (or $RPM_BUILD_ROOT).
> [-] MUST: Each package must consistently use macros, as described in the
> macros
Fixed
> section of Packaging Guidelines.
> [+] MUST: The package must contain code, or permissible content. This is
> described in detail in the code vs. content section of Packaging Guidelines.
> [+] MUST: Large documentation files should go in a doc subpackage.
> [+] MUST: If a package includes something as %doc, it must not affect the
> runtime of the application.
> [+] MUST: Header files must be in a -devel package.
> [+] MUST: Static libraries must be in a -static package.
> [+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
> (for directory ownership and usability).
> [+] MUST: If a package contains library files with a suffix (e.g.
> libfoo.so.1.1), then library files that end in .so (without suffix) must go in
> a -devel package.
> [+] MUST: In the vast majority of c
[Bug 539388] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539388 Thomas Kowaliczek changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #17 from Thomas Kowaliczek 2010-02-20 21:32:47 EST --- This Packages is Apporved by me. @Bryan O'Sullivan: Please make an CVS Request http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure @Mamoru Tasaka: Thank you for you help :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566163] Review Request: sugar-logos - Boot splash imagery for Sugar on a Stick
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566163
Christoph Wickert changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||cwick...@fedoraproject.org
AssignedTo|nob...@fedoraproject.org|cwick...@fedoraproject.org
Flag||fedora-review?
--- Comment #1 from Christoph Wickert 2010-02-20
21:01:12 EST ---
OK - MUST: $ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/sugar-logos-2-1.fc14.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines: GPLv2+
OK - MUST: License field in spec file matches the actual license
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
687fc657bcb1cf01a2b47093063e2dc5
OK - MUST: successfully compiles and builds into binary rpms on all
architectures
OK - MUST: all build dependencies are listed in BuildRequires: none
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT
OK - MUST: consistently uses macros
OK - MUST: package contains permissible content
OK - MUST: no large documentation files for a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
OK - MUST: The package does not contain any .la libtool archives.
OK - MUST: package does not own files or directories already owned by other
packages.
OK - MUST: at the beginning of %install, the package runs rm -rf
$RPM_BUILD_ROOT
OK - MUST: all filenames valid UTF-8
SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described
Other items:
OK - latest stable version
OK - SourceURL valid
OK - Timestamps match upstream source and are preserved during %install
Issues:
Is this GPLv2 or GPLv2+? I couldn't find any info in the source. You are the
author, please clarify the license and add an AUTHORS file in the next release.
I wonder if "sugar-logos" is the proper name for this package. Usually a
*-logos package contains *all* the branding. Is this already sufficient for
SOAS or are you planning to enhance the source with more graphics so it becomes
a full counterpart to fedora-logos/generic-logos? If so, you need to add
"Provides: system-logos".
IMHO this package should be named "plymouth-theme-sugar" to be in line with the
rest of our packages. Even if you include more icons in the source, you should
package the plymouth theme separately I think.
soas.plymouth contains a hardcoded path with /usr/share/. Fix this upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 554714] Review Request: python-psutil - A process utilities module for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=554714 ELMORABITY Mohamed changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from ELMORABITY Mohamed 2010-02-20 20:43:32 EST --- New Package CVS Request === Package Name: python-psutil Short Description: A process utilities module for Python Owners: melmorabity Branches: F-11 F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566745] Review Request: gnome-paint - Easy to use paint program for GNOME
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566745 Christoph Wickert changed: What|Removed |Added CC||cwick...@fedoraproject.org --- Comment #1 from Christoph Wickert 2010-02-20 20:33:04 EST --- First of all congratulations to this package. The spec looks really good! You have learned a lot since you submitted your first package. I'm glad I sponsored you. But I'd like to warn you: gnome-paint is still in early stages of development, only 3 of the tools are working and the menu entries are ether missing of non-functional. Do you think this is mature enough to be packaged in Fedora? If you maintain it, you will surely receive a lot of bug reports and complainants. Are you sure you take that burden? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 523715] Review Request: logiweb - a system for electronic distribution of mathematics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=523715 --- Comment #32 from Klaus Grue 2010-02-20 18:34:18 EST --- Once again sorry the package does not just build smoothly. I will look into this problem. I noticed one thing, however, in http://koji.fedoraproject.org/koji/taskinfo?taskID=2001323 > In bytes: > info.totalram 2044669 > info.mem_unit 4096 > In cells: > info.totalram 170389 > info.mem_unit 4096 Since 2044669/170389=12 it means that type 'cell' in lgwam.c is 12 bytes. A 'cell' consists of three pointers, so one pointer is 4 bytes or 32 bits which is bad when the computer has 8 gigabyte. For pointers I do not use 'real' pointers. Rather, I use uintptr_t from stdint.h, where a uintptr_t is the type of an unsigned integer large enough to hold a pointer. So the problem could be in stdint.h. I will make a new version which makes a sanity check on uintptr_t. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562374] Review Request: perl-MooseX-Role-WithOverloading - Roles which support overloading
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562374 Chris Weyl changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Chris Weyl 2010-02-20 18:12:03 EST --- Thanks for the review! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562351] Review Request: perl-Data-Dumper-Concise - A convenient way to reproduce a set of Dumper options
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562351 Chris Weyl changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #4 from Chris Weyl 2010-02-20 18:12:01 EST --- Thanks for the review! :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 550582] Review Request: dpkg - Package maintenance system for Debian Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=550582 --- Comment #30 from Fedora Update System 2010-02-20 17:51:03 EST --- dpkg-1.15.5.6-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dpkg'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1740 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 539388] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539388 --- Comment #16 from Bryan O'Sullivan 2010-02-20 17:31:37 EST --- Thanks, folks. URLs remain the same, but I added the forgotten changelog comment. Spec URL: http://www.serpentine.com/bos/files/xmlrpc-epi.spec SRPM URL: http://www.serpentine.com/bos/files/xmlrpc-epi-0.54.1-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 --- Comment #13 from Jason Tibbitts 2010-02-20 17:25:28 EST --- The fedora-cvs flag is set, but I can find no CVS request to process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562351] Review Request: perl-Data-Dumper-Concise - A convenient way to reproduce a set of Dumper options
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562351 --- Comment #3 from Jason Tibbitts 2010-02-20 17:23:59 EST --- CVS done (by process-cvs-requests.py). I added an F-13 branch since that seems to have been missed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562374] Review Request: perl-MooseX-Role-WithOverloading - Roles which support overloading
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562374 --- Comment #3 from Jason Tibbitts 2010-02-20 17:24:23 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 --- Comment #17 from Jason Tibbitts 2010-02-20 17:26:32 EST --- The fedora-cvs flag is set, but I can find no CVS request to process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566983] New: Review Request: pulsecaster - A PulseAudio-based podcast recorder
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pulsecaster - A PulseAudio-based podcast recorder https://bugzilla.redhat.com/show_bug.cgi?id=566983 Summary: Review Request: pulsecaster - A PulseAudio-based podcast recorder Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: sticks...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://pfrields.fedorapeople.org/packages/SPECS/pulsecaster.spec SRPM URL: http://pfrields.fedorapeople.org/packages/SRPMS/pulsecaster-0.1.4-1.fc12.src.rpm Description: PulseCaster is a simple PulseAudio-based tool for making podcast interviews. It is designed for ease of use and simplicity. The user makes a call with a preferred PulseAudio-compatible Voice-over-IP (VoIP) softphone application such as Ekiga or Twinkle, and then starts PulseCaster to record the conversation to a multimedia file. The resulting file can be published as a podcast or distributed in other ways. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 Jens Maucher changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 539388] Review Request: xmlrpc-epi - An implementation of the XML-RPC protocol in C.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539388 --- Comment #15 from Thomas Kowaliczek 2010-02-20 17:00:09 EST --- Bryan O'Sullivan @ Please fix/add the last one and i will approve this :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 --- Comment #12 from Jens Maucher 2010-02-20 17:00:50 EST --- Now it works, and switched to ?. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 Jens Maucher changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565958] Review Request: SynapticsConfig - tool for configuring touchpads
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565958 --- Comment #9 from Michal Klich 2010-02-20 16:44:11 EST --- Please find link to koji buld https://koji.fedoraproject.org/koji/taskinfo?taskID=2001833 And also attached build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565958] Review Request: SynapticsConfig - tool for configuring touchpads
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565958 --- Comment #10 from Michal Klich 2010-02-20 16:44:47 EST --- Created an attachment (id=395293) --> (https://bugzilla.redhat.com/attachment.cgi?id=395293) koji build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565949] Review Request: perl-VOMS-Lite - Perl extension for VOMS Attribute certificate creation
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=565949
Chris Weyl changed:
What|Removed |Added
CC||cw...@alumni.drew.edu
--- Comment #1 from Chris Weyl 2010-02-20 16:40:11 EST
---
A couple comments --
There's a new filtering system in place, invoked via macros. The preferred way
is to filter as below (before the %description section):
%{?perl_default_filter:
%filter_from_provides /^perl(Win32::API)/d
%perl_default_filter
}
PERL_INSTALL_ROOT should really be DESTDIR.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 524277] Review Request: dbacl - Digramic Bayesian text classifier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=524277 Jason Tibbitts changed: What|Removed |Added Status|NEW |CLOSED Blocks||201449(FE-DEADREVIEW) Resolution||NOTABUG Status Whiteboard|NotReady BuildFails | Flag|needinfo?(xiash...@gmail.co | |m) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505813] Review Request: ballview - Molecule and protein visualisation and analysis
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505813 Jason Tibbitts changed: What|Removed |Added Status Whiteboard|NotReady BuildFails | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553281] Review Request: netsniff-ng - high performance linux network sniffer for packet inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553281 Kevin Fenzi changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|ke...@tummy.com Flag||fedora-review? --- Comment #12 from Kevin Fenzi 2010-02-20 16:23:37 EST --- I'll go ahead and take this for review. James: Do you have any other packages to submit? Or can you do some 'pre-reviews' of some existing pending package reviews to show your understanding of the guidelines? Look for a review here soon... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566750] Review Request: MUMPS - A MUltifrontal Massively Parallel sparse direct Solver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566750 Jason Tibbitts changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #1 from Jason Tibbitts 2010-02-20 16:17:21 EST --- I'm curious as to how this can be in the public domain, when as far as I've understood the situation, French citizens cannot place things in the public domain. Perhaps the software dates from a time when that was possible, although I don't think so. Blocking FE-Legal for an opinion. I would consider the ldconfig symlink issue a problem worth fixing. Are the contents of the .so files in the -devel package and the versioned .so files in the main package the same? If so, why not simply replace the .so files with symlinks? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516528] Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516528 --- Comment #4 from Steve Traylen 2010-02-20 16:14:03 EST --- I agree, a dummy.org URL makes no sense at all. I misinterpreted the results. bug #566978 is completely valid. I guess what needs to worked on is full URL for such a download/extract -> tar ball. Will review in the morning. Steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 --- Comment #11 from Jason Tibbitts 2010-02-20 16:13:29 EST --- It may take an hour or so before your elevated permissions propagate to bugzilla. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565958] Review Request: SynapticsConfig - tool for configuring touchpads
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565958 --- Comment #8 from Michal Klich 2010-02-20 16:05:09 EST --- Thank you for your suggestions. I have altered my SPEC file and rebuilt SRPM file. Both are know hosted on http://rudebwoy.fedorapeople.org/. Please do not use locations from my first comment. http://rudebwoy.fedorapeople.org/SynapticsConfig.spec http://rudebwoy.fedorapeople.org/SynapticsConfig-0.1.3-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566962
Matthias Runge changed:
What|Removed |Added
CC||mru...@fedoraproject.org
--- Comment #2 from Matthias Runge 2010-02-20
16:04:58 EST ---
Since I'm not approved, I'm able to give you an unofficial review
rpmlint polipo-1.0.4.1-1.fc12.src.rpm polipo.spec
polipo.src: W: spelling-error %description -l en_US pipelining -> pipe lining,
pipe-lining, pipeline
polipo.src: W: invalid-url URL www.pps.jussieu.fr/~jch/software/polipo/
polipo.src: W: strange-permission polipo.init 0755
polipo.src:65: W: mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 1)
polipo.spec:65: W: mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 1)
1 packages and 1 specfiles checked; 0 errors, 5 warnings.
Looking deeper to the spec-file:
- URL-Entry should start with http://
- yum provides /sbin/install-info lists info as package providing
/sbin/install-info. If you definitely need it for pre and post-section, take
info. https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires Lists
info as package, that doesn't need to be included.
- $RPM_BUILD_ROOT and %{buildroot}-Macros should not be mixed.
(https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS)
Mock builds fine.
Ok, looking deeper:
+:ok, =:needs attention, -:needs fixing
[+] MUST: rpmlint must be run on every package.
(see above)
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[=] MUST: The package must meet the Packaging Guidelines. [FIXME?: covers this
list and more]
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.
<>
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[-] MUST: All build dependencies must be listed in BuildRequires
[=] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[*] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[*] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review
[-] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[-] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containing GUI applications must include a %{name}
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 --- Comment #10 from Jens Maucher 2010-02-20 16:06:09 EST --- I did, but i can't set the cvs-flag to ?. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516528] Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516528
--- Comment #3 from Mattias Ellert 2010-02-20
16:00:35 EST ---
New rpmlint version bringing new surprises.
The new rpmlint is not complaining about Source vs. Source0, your suggested
"fix" does not resolve the issue rpmlint is complaining about.
I can make the warning go away by creating a dummy URL like:
Source0: http://dummy.org/%{_name}-%{version}.tar.gz
But this seems to be a really stupid thing to do. The auto QA tests that
download the sources and compares them with the ones in the look-aside cache
will report errors for this, since the URL does not exist.
To me, this behaviour of the new rpmlint version doesn't make sense. I have
submitted a bug report (bug #566978).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562351] Review Request: perl-Data-Dumper-Concise - A convenient way to reproduce a set of Dumper options
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562351 --- Comment #2 from Chris Weyl 2010-02-20 15:44:38 EST --- New Package CVS Request === Package Name: perl-Data-Dumper-Concise Short Description: A convenient way to reproduce a set of Dumper options Owners: cweyl Branches: F-11 F-12 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562374] Review Request: perl-MooseX-Role-WithOverloading - Roles which support overloading
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562374 --- Comment #2 from Chris Weyl 2010-02-20 15:45:20 EST --- New Package CVS Request === Package Name: perl-MooseX-Role-WithOverloading Short Description: Roles which support overloading Owners: cweyl Branches: F-11 F-12 F-13 devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562374] Review Request: perl-MooseX-Role-WithOverloading - Roles which support overloading
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562374 Chris Weyl changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566974] CalculiX cgx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566974 Manfred Spraul changed: What|Removed |Added Depends on||566977 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562351] Review Request: perl-Data-Dumper-Concise - A convenient way to reproduce a set of Dumper options
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562351 Chris Weyl changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566977] libSNL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566977 Manfred Spraul changed: What|Removed |Added Blocks||566974 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566977] New: libSNL library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: libSNL library https://bugzilla.redhat.com/show_bug.cgi?id=566977 Summary: libSNL library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: manf...@colorfullife.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora libSNL is a library for manipulating NURBS surfaces. Base packages: - exists as project on sourceforge - http://sourceforge.net/projects/libsnl/ - no updates in the last 3 years - no files were ever released, only an svn tree exists. - there is no documentation on the package - C++ language - license: GPLv2+ rpm package: - the svn snapshot from Feb 13th 2010 is used for the package - two rpms are created: one with the dynamic library, one with the header files. - the header files are stored under /usr/include/SNL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566379] Review Request: perl-Ham-Reference-QRZ - Ham::Reference::QRZ perl modul
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566379 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 564588] Review Request: callgit - A tool for Ham Radio Operators to look up callsigns on the web
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=564588 Mamoru Tasaka changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #9 from Mamoru Tasaka 2010-02-20 15:39:39 EST --- Please fix %changelog entry (now release is 3) This package (callgit) is APPROVED by mtasaka Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)". Now I am sponsoring you. If you want to import this package into Fedora 11/12/13, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Removing NEEDSPONSOR. Note: - If you cannot set fedora-cvs flag on this bug to ?, try re-logining to this RedHat bugzilla with the email registered on Fedora Account System. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 Mamoru Tasaka changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #16 from Mamoru Tasaka 2010-02-20 15:34:01 EST --- Okay, thank you, Kevin. Now I am sponsoring Jens. Jens, please visit https://admin.fedoraproject.org/pkgdb/packages/name/pisg and take over the maintainership of this package. Setting fedora-review to plus. Dominic, thank you for pre-review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566974] New: CalculiX cgx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: CalculiX cgx https://bugzilla.redhat.com/show_bug.cgi?id=566974 Summary: CalculiX cgx Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: manf...@colorfullife.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora CalculiX cgx is a pre- and postprocessor for FEM solvers. It supports multiple file formats, among them the ABAQUS input file format that is used by CalculiX ccx and the ccx result file format. Base Package: - http://www.dhondt.de/ - the source tar ball contains the cgx sources and the sources of two libraries: glut and libSNL. - License: GPLv2 Package: - http://sourceforge.net/projects/calculix-rpm/files/fedora/cgx-2.0-3.fc12.src.rpm/download - builds two packages: main package with executable and documentation and the examples. - glut and libSNL are removed in %prep stage, the executable links against separate packages. - freeglut is already in fedora, libSNL would be new. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558535] CalculiX (ccx, cgx)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558535 Manfred Spraul changed: What|Removed |Added Depends on||566974 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566974] CalculiX cgx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566974 Manfred Spraul changed: What|Removed |Added Blocks||558535 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558535] CalculiX (ccx, cgx)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558535 --- Comment #5 from Jason Tibbitts 2010-02-20 15:33:34 EST --- Would it be possible for you to follow the same template that essentially all other package review tickets follow? We have scripts that parse them, and if you'd like to increase the possibility that your packages out of the hundreds of others are reviewed, it would benefit you to follow the template. This sort of happens automatically if you use the package submission recommended by our documentation at http://fedoraproject.org/wiki/Join_the_package_collection_maintainers Please at least use a summary like: Review Request: packagename - description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566964] SPOOLES library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566964 Manfred Spraul changed: What|Removed |Added Blocks|558535 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566972] CalculiX ccx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566972 Manfred Spraul changed: What|Removed |Added Blocks||558535 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566964] SPOOLES library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566964 Manfred Spraul changed: What|Removed |Added Blocks||566972 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558535] CalculiX (ccx, cgx)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558535 --- Comment #4 from Manfred Spraul 2010-02-20 15:26:41 EST --- Ok. I'm creating the dependence hierarchy, sorry for any noise. At the end, this bug will remain as the placeholder for CalculiX, it can be closed immediately when all dependencies are closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558535] CalculiX (ccx, cgx)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558535 Manfred Spraul changed: What|Removed |Added Depends on|566964 |566972 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566972] CalculiX ccx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566972 Manfred Spraul changed: What|Removed |Added Depends on||566964 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 --- Comment #15 from Kevin Fenzi 2010-02-20 15:25:18 EST --- I just freed it up in pkgdb. Feel free to take ownership of it. I can add myself in as co-maintainer afer you do so. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566972] New: CalculiX ccx
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: CalculiX ccx https://bugzilla.redhat.com/show_bug.cgi?id=566972 Summary: CalculiX ccx Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: manf...@colorfullife.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora CalculiX is a 2D and 3D FEM solver. Base package: - http://www.dhondt.de/ - License: GPLv2 - multiple matrix solvers are supported, some of them non-free. rpm spec file: - http://sourceforge.net/projects/calculix-rpm/files/fedora/ccx-2.0-4.fc12.src.rpm/download - generates two rpms: one with the executable and documentation, one with the examples. - no dependence between the examples and the base package: the examples are useful even without the base package - two iterative matrix solvers and the SPOOLES library [both serial and parallel] are enabled. The non-free solvers [e.g. sgi] are disabled. - the package depends on ARPACK and libspooles. ARPACK already exists in Fedora, libspooles would be new. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 --- Comment #14 from Jens Maucher 2010-02-20 15:22:29 EST --- To Kevin: Yes, i would like to be co-maintainer of pisg. I'd really appreciate that. Thanks in advance. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562388] Review Request: pisg - IRC statistics generator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562388 --- Comment #13 from Kevin Fenzi 2010-02-20 15:15:33 EST --- Yes, thats excellent. ;) I will go release ownership of it now. Jens: If you have any questions or issues or would like a co-maintainer, I would be happy to help you with pisg. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565232] Review Request: perl-Log-Any - Bringing loggers and listeners together
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565232 Steve Traylen changed: What|Removed |Added Flag||fedora-review+ --- Comment #4 from Steve Traylen 2010-02-20 14:37:35 EST --- Review of perl-Log-Any, February 20th. yes: rpmlint. $ rpmlint perl-Log-Any.spec \ ../RPMS/noarch/perl-Log-Any-0.11-1.fc12.noarch.rpm \ ../SRPMS/perl-Log-Any-0.11-1.fc12.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. yes: package name good for perl. yes: .spec file name good. yes: meets pkg guidelines. yes: spec has gpl+ or Artistic. yes: yes source is same as perl so as above. yes: english .spec file. yes: .spec is legible. yes: matches upstream. $ md5sum Log-Any-0.11.tar.gz SOURCES/Log-Any-0.11.tar.gz 9186d94ee2ae7cada408fc5faf86d975 Log-Any-0.11.tar.gz 9186d94ee2ae7cada408fc5faf86d975 SOURCES/Log-Any-0.11.tar.gz yes: compiles fine. yes: buildrequires sane. yes: no locale. yes: no shared libs. yes: no system libs. yes: not relocatable. yes: Owns all directories. yes: no duplicates. yes: %clean actually cleans. yes: No large docs. yes: No -devel package. yes: no pkgconfig yes: no sub-packages. yes: no gui. yes: does not own directories from other packages. yes: %install rm -rf first. yes: UTF8 Builds in mock-rawhide (F14!) Basically a very simple cpanspec generated package. APPROVED. Steve p.s. (I've got a perl module perl-VOMS-Lite, up for review if you have time to review.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566171] Review Request: libhid - A userspace USB HID acess library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566171 --- Comment #3 from Manuel F Martinez 2010-02-20 14:19:53 EST --- Thank your for your advise. Here the changes I've made: 1. I removed the "A" article. 2. The GPL Version 3 comes from automake at build time, but looking at the upstream website http://libhid.alioth.debian.org/, they claim libhid is released under the terms of the GPLVersion 2, so I've fixed it to GPLv2 3. The upstream says -devel includes static libraries, but the Package Gideline says to put static on a -static package, and take this action only if static is really necessary, so I'm removed static libraries, no I'm removing "static library" statement from -devel description. 4. I'm removing --force from libtoolize, I just copied the whole command with parameters as "autogen.sh" does, but now I'm using "make DESTDIR=$RPM_BUILD_ROOT install" as suggested in the link provided by you. 5. %deffattr(0644,root,root) I left because I was getting trouble with manpages, but then I create a patch and forgot to remove %deffattr, sorry, my bad. 6. libusb-devel added to libhid-devel. I rebuild release 2 on Koji and the build was completed successfully. http://koji.fedoraproject.org/koji/tasks?state=closed&owner=manpaz Once again, thank you for your advise. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566964] New: SPOOLES library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: SPOOLES library https://bugzilla.redhat.com/show_bug.cgi?id=566964 Summary: SPOOLES library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: manf...@colorfullife.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora spooles is a library for working with sparse matrices. It is not yet supported by Fedora. Link to .srpm: http://sourceforge.net/projects/calculix-rpm/files/fedora/libspooles-2.2-1.fc12.src.rpm/download Details on the base package: - http://www.netlib.org/linalg/spooles/spooles.2.2.html - the spooles library is in the public domain. - one IO file [Utilities/src/iohb.c] uses a BSD license. It probably could be removed. - it works on 32-bit and 64-bit platforms. The debug printf's might be broken on 64-bit archs - there are serial, parallel [pthread] and MPI functions. Details on the .rpm: - two rpms: libspooles and libspooles-devel - header files are copied into /usr/include/spooles/ The same path is used by debian. - the serial and parallel version are built as a shared library (/usr/lib/libspooles.so) - MPI is not included. As far as I understand the packaging guidelines (http://fedoraproject.org/wiki/PackagingDrafts/MPI), MPI libraries should be separate rpms and should be provided for all supported MPI implementations. This is a binary incompatibility to the debian .deb file: debian builds one big .so file with serial, parallel and mpi. - the documentation [provided as .tex files, fixes necessary - at least psfig must be replaced] is not built. - the license is set to BSD as the most restrictive license. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 558535] CalculiX (ccx, cgx)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=558535 Manfred Spraul changed: What|Removed |Added Depends on||566964 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566964] SPOOLES library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566964 Manfred Spraul changed: What|Removed |Added Blocks||558535 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565232] Review Request: perl-Log-Any - Bringing loggers and listeners together
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565232 --- Comment #3 from Steven Pritchard 2010-02-20 14:02:58 EST --- Yeah, the box crashed last night some time. :-( I copied them here: Spec URL: http://steve.fedorapeople.org/rpms/perl-Log-Any/perl-Log-Any.spec SRPM URL: http://steve.fedorapeople.org/rpms/perl-Log-Any-0.11-1.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #10 from Jan F. Chadima 2010-02-20 13:41:28
EST ---
the problem with the debuginfo is the problem with %{_libdir}/* it includes the
debuginfo into the regular package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516528] Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=516528
--- Comment #2 from Steve Traylen 2010-02-20 13:29:12
EST ---
1)
Source: %{_name}-%{version}.tar.gz
should be
Source0: %{_name}-%{version}.tar.gz
mainly just to keep rpmlint happy.
$ rpmlint globus-gram-client-tools.spec
globus-gram-client-tools.spec: W: invalid-url Source0:
globus_gram_client_tools-7.3.tar.gz
Other than that looks trivial to approve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #9 from Steve Grubb 2010-02-20 13:26:29 EST ---
New srpm is located here since name changed while adding %{?dist}:
http://people.redhat.com/sgrubb/files/suricata/suricata-0.8.1-1.fc12.src.rpm
Added libtool BR.
debuginfo as I understand it is something out of my control. Its rpm or build
system doing it.
The binary is now called out by name. The library will likely change versions,
so I am not calling it out by name. I have libhtp-* instead.
The init script is now working with the app. However, it looks like I need to
work with upstream on the config file and verbosity in daemon mode.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566962 --- Comment #1 from Chen Lei 2010-02-20 13:19:10 EST --- Tor Browser Bundle contains Tor + Vidalia + Torbutton +Polipo + Firefox. All of them now are in the repo of fedora except polipo. See http://www.torproject.org/download.html.en -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566962 Chen Lei changed: What|Removed |Added Version|12 |rawhide Alias||polipo -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516528] Review Request: globus-gram-client-tools - Globus Toolkit - Job Management Tools (globusrun)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516528 Steve Traylen changed: What|Removed |Added Status|NEW |ASSIGNED CC||steve.tray...@cern.ch AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566962] New: Review Request: polipo - Lightweight Caching Web Proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: polipo - Lightweight Caching Web Proxy https://bugzilla.redhat.com/show_bug.cgi?id=566962 Summary: Review Request: polipo - Lightweight Caching Web Proxy Product: Fedora Version: 12 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: supercy...@163.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Description: Polipo is a lightweight caching Web proxy that was designed as a personal cache. It is able to cache incomplete objects and will complete them using range requests. It will use HTTP/1.1 pipelining if supported by the remote server. SPEC: http://dl.dropbox.com/u/1338197/1/polipo.spec SRPM: http://dl.dropbox.com/u/1338197/1/polipo-1.0.4.1-1.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566695] Review Request: goddard-kde-theme - Goddard KDE Theme
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566695 --- Comment #5 from Jason Tibbitts 2010-02-20 13:03:12 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561086] Review Request: perl-String-Escape - String::Escape Perl module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561086 --- Comment #11 from Jason Tibbitts 2010-02-20 13:02:12 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467641] Review Request: sugar-maze - Maze for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467641 --- Comment #24 from Jason Tibbitts 2010-02-20 13:01:32 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508441] Review Request: sugar-view-slides - Image serie viewer for Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508441 --- Comment #9 from Jason Tibbitts 2010-02-20 13:01:52 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566529] Review Request: perl-Config-MVP - Multivalue-property package-oriented configuration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566529 --- Comment #3 from Jason Tibbitts 2010-02-20 13:02:53 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 456774] Review Request: libanculus-sharp - Reusable utility library written in C#
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=456774
--- Comment #1 from Steve Traylen 2010-02-20 12:54:30
EST ---
(I've not checked yet if there are any mono guidelines in particular)
1)
$ rpmlint libanculus-sharp.spec
libanculus-sharp.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 16, tab:
line 3)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.
2)
$ rpmlint ../SRPMS/libanculus-sharp-0.3.1-1.fc12.src.rpm
libanculus-sharp.src: W: strange-permission libanculus-sharp.spec 0777
libanculus-sharp.src: W: strange-permission libanculus-sharp-0.3.1.tar.bz2 0777
3)
$ rpmlint *x86_64.rpm
libanculus-sharp.x86_64: E: no-binary
libanculus-sharp.x86_64: W: only-non-binary-in-usr-lib
libanculus-sharp-devel.x86_64: W: no-documentation
libanculus-sharp-doc.x86_64: W: only-non-binary-in-usr-lib
libanculus-sharp-doc.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 1 errors, 4 warnings.
As you say I think these are okay, I need to check a bit myself.
4) Packaage contains:
/usr/lib64/libanculus-sharp/Anculus.Core.Extended.dll
/usr/lib64/libanculus-sharp/Anculus.Core.dll
/usr/lib64/libanculus-sharp/Anculus.Gui.dll
but that directory is not owned or in a package that is pulled in.
5) Similar story for
/usr/lib64/mono/libanculus-sharp
6) Similar also for
/usr/lib64/mono/gac/Anculus.Core.Extended/0.3.1.0__f53db44f7305a799
Please check all the others.
7) Line 31 of the .spec file. The spacing is different to the other lines.
8) I would guess that with
%{__chmod} 755 autogen.sh
sh autogen.sh --prefix=%{_prefix} --libdir=%{_libdir}
if you call it with sh you don't need to chmod it first.
9) In the -doc package the files are not marked as %doc which
is possibly okay. They are needed at runntime?
10) The -doc package looks to be noarch so at least this sub package
could me marked as noarch.
11) Why are the docs in
/usr/lib64/monodoc
rather than /usr/share or something? Though this starts to
cross into why monodoc itself is in there.
Steve
p.s The monodoc package needs a bug.
$ rpm -qf /usr/lib64/monodoc/monodoc.xml /usr/lib64/monodoc/
monodoc-2.4.3.1-1.fc12.x86_64
file /usr/lib64/monodoc is not owned by any package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566171] Review Request: libhid - A userspace USB HID acess library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566171
Michael Schwendt changed:
What|Removed |Added
CC||mschwe...@gmail.com
--- Comment #2 from Michael Schwendt 2010-02-20 12:57:36
EST ---
> Summary:A userspace USB HID access library
It's wide-spread taste practise to omit leading articles, such as "A" or "The":
Summary: Userspace USB HID access library
> License:GPLv3+
Doesn't seem to be true.
[...@faldor libhid-0.2.17]$ grep -i "version 3" * -R|wc -l
0
[...@faldor libhid-0.2.17]$ grep -i "version 2" * -R|wc -l
22
* %description of -devel packages mentions "static" libraries, which are not
included.
> # Force use of system libtool
The big question here is: Why?
> %makeinstall
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
> %defattr(0644,root,root)
> %{_mandir}/man1/*
The extra %defattr here is acceptable, but dangerous. It wouldn't be the first
time somebody adds files somewhere below and overlooks the 0644 mode. If you
need to fix the man page permissions, chmod after %setup is safer.
* libhid-devel is missing "Requires: libusb-devel", since it depends on usb.h
and libhid.pc needs -lusb.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #7 from Jan F. Chadima 2010-02-20 12:54:21
EST ---
It's not recommended to have %{_bindir}/* or %{_libdir}/* in %files section,
better is to have all files pointed by name.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566819
--- Comment #8 from Jan F. Chadima 2010-02-20 12:55:28
EST ---
It's reconended to use %{?dist} in %release
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #6 from Jan F. Chadima 2010-02-20 12:48:46 EST --- rpmlint i386.rpm suricata.i686: W: spelling-error %description -l en_US Multi -> Mulch, Mufti suricata.i686: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip suricata.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/libhtp-0.2.so.1.0.2.debug suricata.i686: E: shared-lib-without-dependency-information /usr/lib/debug/usr/lib/libhtp-0.2.so.1.0.2.debug suricata.i686: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/suricata.debug suricata.i686: E: statically-linked-binary /usr/lib/debug/usr/bin/suricata.debug suricata.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id suricata.i686: W: hidden-file-or-dir /usr/lib/debug/.build-id suricata.i686: E: non-standard-dir-perm /var/log/suricata 0750L suricata.i686: E: non-readable /etc/sysconfig/suricata 0600L suricata.i686: E: non-readable /etc/suricata.yaml 0600L suricata.i686: E: non-standard-dir-perm /etc/suricata/rules 0750L suricata.i686: E: non-standard-dir-perm /etc/suricata 0750L It seems that /usr/lib/debug is in both the debugifo and the main package I understand the unstardard permissions, I'll disscuss it with fedora people. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #5 from Jan F. Chadima 2010-02-20 12:37:22 EST --- build the package suricata failed on rawhide/x86-64 autoreconf: running: /usr/bin/autoconf --force configure.ac:70: error: possibly undefined macro: AM_PROG_LIBTOOL If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. autoreconf: /usr/bin/autoconf failed with exit status: 1 build info on http://koji.fedoraproject.org/koji/taskinfo?taskID=2001609 maybe missing libtool in BuldRequires -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
