[Bug 556988] Review Request: ibus-fbterm - IBus front-end for fbterm
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=556988
--- Comment #13 from Ding-Yi Chen dc...@redhat.com 2010-02-26 03:07:33 EST ---
MUST:
- rpmlint output is acceptable.
W: incoherent-version-in-changelog 0.9.1-6.fc14 ['0.9.1-6.fc12', '0.9.1-6']
Remove the .fc14 part
+ Package meets naming and packaging guidelines.
+ Package meets licensing guidelines, and match the source license.
+ Source files match upstream.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ BuildRoot is proper.
+ BuildRequires are proper.
+ Requires are proper.
+ %install starts with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
+ %clean contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
+ %doc files present.
+ %doc files do not interfere runtime application.
+ Macros are consistently used.
+ Package builds in koji.
+ Package contains code or permissible content.
+ Package installed properly.
+ No system library is bundled.
+ Not relocatable, unless proper justification is presented.
+ %files section must include a %defattr(...) line, and file permissions are
correct.
+ No duplication in %files
+ File names are in valid UTF-8.
+ Own all directory it creates.
+ Files or directories are not owned by other packages.
+ Large documentation files goes in a -doc subpackage.
+ No .la libtool archives exists.
SHOULD:
+ License text are in separate files.
+ Translations for supported non-English languages if available.
+ Package build in mock.
+ Package can build in all supported architectures.
+ Package runs properly.
+ Scriptlets are sane.
+ Subpackages Requires: %{name} = %{version}-%{release}
+ .pc is in devel subpackage.
+ No direct files dependencies, unless they are in either /etc, /bin, /sbin,
/usr/bin, or /usr/sbin
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556988] Review Request: ibus-fbterm - IBus front-end for fbterm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556988 --- Comment #14 from Ding-Yi Chen dc...@redhat.com 2010-02-26 03:09:14 EST --- Summary: 1. W: incoherent-version-in-changelog 0.9.1-6.fc14 ['0.9.1-6.fc12', '0.9.1-6'] Remove the .fc14 part 2. Consider change the Group to: Application/System, as it seems more appropriate. Otherwise looks like a pass to me. Regards, -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 --- Comment #19 from Jan F. Chadima jchad...@redhat.com 2010-02-26 03:16:19 EST --- aprooved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568638] Review Request: smx - httpd server macro language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568638 erik aronesty e...@q32.com changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Jan F. Chadima jchad...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568638] New: Review Request: smx - httpd server macro language
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: smx - httpd server macro language https://bugzilla.redhat.com/show_bug.cgi?id=568638 Summary: Review Request: smx - httpd server macro language Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: low Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: e...@q32.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Created an attachment (id=396490) -- (https://bugzilla.redhat.com/attachment.cgi?id=396490) rpmlint output Spec URL: http://www.smxlang.org/smx.spec SRPM URL: http://smx.googlecode.com/files/smx-1.1.4-437.src.rpm Description: SMX is a text-embedded macro processing language with extended support for inclusion in web-pages. Core features include database access and image manipulation. - this is my first package, and i am seeking a sponsor - rpmlint spews a ton of lint for the installed %macro documentation since macros contain percent signs. i'd like to keep the man %func as a feature which users seem to like, but not if everyone here hates it... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] New: Review request - lldpad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review request - lldpad https://bugzilla.redhat.com/show_bug.cgi?id=568641 Summary: Review request - lldpad Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: jzel...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- SPEC: http://jzeleny.fedorapeople.org/packages/lldpad/lldpad.spec SRPM: http://jzeleny.fedorapeople.org/packages/lldpad/lldpad-0.9.26-1.fc12.src.rpm This is substitude for original dcbd package, it has the same functionality plus it adds lldp protocol support. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567872 Hans de Goede hdego...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Hans de Goede hdego...@redhat.com 2010-02-26 03:38:06 EST --- Looks good now: Approved! One small issue though (but not a blocker). Could you change the description from: gtk-v4l is a Video4Linux Web camera control app to: gtk-v4l is a Video4Linux device control app As this will work for example with tv cards too. The same goes for the README (to be fixed in a next release). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request - lldpad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 Jan Vcelak jvce...@redhat.com changed: What|Removed |Added CC||jvce...@redhat.com AssignedTo|nob...@fedoraproject.org|jvce...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 Andrea Francia andrea.fran...@gmx.it changed: What|Removed |Added CC||andrea.fran...@gmx.it --- Comment #19 from Andrea Francia andrea.fran...@gmx.it 2010-02-26 03:46:55 EST --- Hi, I'm the upstream developer -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566342] Review Request: dogtag-pki - Meta-package for Dogtag PKI Suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566342 Didier Moens didier.mo...@dmbr.ugent.be changed: What|Removed |Added CC||didier.mo...@dmbr.ugent.be --- Comment #16 from Didier Moens didier.mo...@dmbr.ugent.be 2010-02-26 03:46:35 EST --- (In reply to comment #13) dogtag-pki-1.3.0-1.el5 pulls in pki-ra-1.3.0-6.el5 and pki-tps-1.3.0-8, which both depend on mod_nss = 1.0.7 . mod_nss = 1.0.7 is not available in EPEL or EPEL-testing, hence dogtag-pki installation fails. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 --- Comment #20 from Rahul Sundaram methe...@gmail.com 2010-02-26 03:54:50 EST --- Hello I have send you a mail with the details but in brief trash has been renamed to trash-put but docs don't match necessarily esp man page and the description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567872 --- Comment #5 from Huzaifa S. Sidhpurwala huzai...@redhat.com 2010-02-26 03:59:29 EST --- Makes sense thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483730 --- Comment #60 from Fedora Update System upda...@fedoraproject.org 2010-02-26 04:33:04 EST --- kde-plasma-translatoid-1.1.90_20100122svn-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483730 --- Comment #61 from Fedora Update System upda...@fedoraproject.org 2010-02-26 04:33:18 EST --- kde-plasma-translatoid-1.1.90_20100122svn-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483730 --- Comment #62 from Fedora Update System upda...@fedoraproject.org 2010-02-26 04:33:26 EST --- kde-plasma-translatoid-1.1.90_20100122svn-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kde-plasma-translatoid-1.1.90_20100122svn-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568315] Review Request: xapply - Parallel Execution tool ala xargs/apply
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568315 --- Comment #3 from Terje Røsten terje...@phys.ntnu.no 2010-02-26 04:34:48 EST --- Sure, it was joke, Open Source is so serious and boring these days :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565616] Review Request: libeina - Data Type Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565616 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-02-26 05:04:54 EST --- libeina-0.9.9.063-6.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libeina-0.9.9.063-6.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565616] Review Request: libeina - Data Type Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565616 --- Comment #15 from Fedora Update System upda...@fedoraproject.org 2010-02-26 05:05:06 EST --- libeina-0.9.9.063-6.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libeina-0.9.9.063-6.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565616] Review Request: libeina - Data Type Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565616 --- Comment #16 from Fedora Update System upda...@fedoraproject.org 2010-02-26 05:05:11 EST --- libeina-0.9.9.063-6.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libeina-0.9.9.063-6.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567872 Huzaifa S. Sidhpurwala huzai...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #59 from Henrique LonelySpooky Junior henrique...@gmail.com 2010-02-26 05:12:49 EST --- Yes, it is normal when you try to build in a dirt /home/Sylvestre/rpmbuild/BUILD (from previous attempts). When Koji builds the packages it uses always a clean directory, but I can solve this because it is annoying. Maybe Chen Lei could guide me through this rpmlint issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567872 --- Comment #6 from Huzaifa S. Sidhpurwala huzai...@redhat.com 2010-02-26 05:15:44 EST --- New Package CVS Request === Package Name: gtk-v4l Short Description: gtk-v4l is a Video4Linux device control app Owners: huzaifas Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562467] Review Request: openvas-libraries - Support libraries for Open Vulnerability Assessment (OpenVAS) Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562467 --- Comment #3 from Stjepan Gros stjepan.g...@gmail.com 2010-02-26 05:15:11 EST --- I cleaned up spec file and synchronized the libraries with a new upstream version. As for review request, I did it this way because it was easier for me. I think I am co-maintainer for some parts of the openvas, though I don't know which. Despite this, I didn't want to try to change OpenVAS since it is quite large change in question. Spec URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-libraries.spec SRPM URL: http://www.zemris.fer.hr/~sgros/stuff/fedora/openvas3/openvas-libraries-3.0.3-1.fc12.src.rpm Description: Anyway, Huzaifa is free to do or suggest anything he thinks is the best. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request - lldpad
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568641
Jan Vcelak jvce...@redhat.com changed:
What|Removed |Added
Flag||needinfo?(jzel...@redhat.co
||m)
--- Comment #1 from Jan Vcelak jvce...@redhat.com 2010-02-26 05:14:48 EST ---
[ ] rpmlint
$ rpmlint -i ./*.rpm
lldpad.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 9)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
lldpad.x86_64: E: incoherent-subsys /etc/rc.d/init.d/lldpad dcbd
The filename of your lock file in /var/lock/subsys/ is incoherent with your
actual init script name. For example, if your script name is httpd, you have
to use 'httpd' as the filename in your subsys directory. It is also possible
that rpmlint gets this wrong, especially if the init script contains
nontrivial shell variables and/or assignments. These cases usually manifest
themselves when rpmlint reports that the subsys name starts a with '$'; in
these cases a warning instead of an error is reported and you should check the
script manually.
4 packages and 0 specfiles checked; 1 errors, 1 warnings.
[*] meets Naming Guidelines
[*] meets Licensing Guilelines
[*] sources match upstream version
[?] all patches have upstream bug link or comment
No comments at all (although the meaning is quite obvious from their names).
[*] license specified in specfile, license file included
[*] specfile in American English
[*] specfile is legible
[*] valid BuildRoot
[*] buildroot cleanup before %install
[ ] uses macros consitently
Please, use either %{xxx} style or $XXX style macros. Pick a style and use it
consistently throughout your packaging.
I suggest replacing $RPM_BUILD_ROOT with %{buildroot}
Example from your specfile: mkdir -p $RPM_BUILD_ROOT%{_initddir}
[*] pkgconfig files in -devel subpackage
[*] no static libraries included
[*] no staticly linked executables
[*] scriptlets requirements splitted
[*] %preun, %postun scriptlets running only in certain situations
[*] scriptlets are sane
[*] package is relocatable
[*] all files and directories included
[*] permissions and ownership specified
[*] all filenames valid UTF-8
[*] contains code, or permissible content
[*] documentation doesn't need separate package
[*] %doc does not affect runtime
[*] subpackages with fully versioned dependency
[*] builds in koji
Package rename requirements:
[*] Provides is correct
[*] Obsoletes is correct
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request - lldpad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 Jan Zeleny jzel...@redhat.com changed: What|Removed |Added Flag|needinfo?(jzel...@redhat.co | |m) | --- Comment #2 from Jan Zeleny jzel...@redhat.com 2010-02-26 05:28:42 EST --- Updated SPEC: http://jzeleny.fedorapeople.org/packages/lldpad/lldpad.spec Updated SRPM: http://jzeleny.fedorapeople.org/packages/lldpad/lldpad-0.9.26-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #60 from James Heather j.heat...@surrey.ac.uk 2010-02-26 05:25:21 EST --- (In reply to comment #59) Yes, it is normal when you try to build in a dirt /home/Sylvestre/rpmbuild/BUILD (from previous attempts). When Koji builds the packages it uses always a clean directory, but I can solve this because it is annoying. I suspect this is related to the rpmlint warning: jogl.src: W: no-cleaning-of-buildroot %install Is this something to with not having an %install section? I am not quite sure what's going on there. I expected to see an %install but there isn't one. Maybe the %clean isn't being fired for some reason. That ought to be getting rid of the previous build attempts. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439630
--- Comment #61 from James Heather j.heat...@surrey.ac.uk 2010-02-26 05:28:01
EST ---
In fact, I think it's normal to start the %install section with
%install
rm -rf %{buildroot}
That would make rpmlint happier, and also solve your problem. At the moment,
you'll hit this issue if the previous build failed, because %clean won't get
executed, and the next build will get confused because of the existing files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #62 from Henrique LonelySpooky Junior henrique...@gmail.com 2010-02-26 05:34:55 EST --- Thanks, James. Soon I post an update here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562467] Review Request: openvas-libraries - Support libraries for Open Vulnerability Assessment (OpenVAS) Server
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562467 --- Comment #4 from Huzaifa S. Sidhpurwala huzai...@redhat.com 2010-02-26 05:55:13 EST --- Thanks, i will commit it soon, I have a having issues with static libs since --disable-static was not working. http://bugs.openvas.org/855 http://bugs.openvas.org/1125 Are you sure the parser is linked with the dynamic libs and not the static ones, which you are deleting? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request - lldpad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 Jan Vcelak jvce...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #3 from Jan Vcelak jvce...@redhat.com 2010-02-26 06:13:19 EST --- Thank you. ACCEPT. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567872 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-26 06:25:38 EST --- gtk-v4l-0.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gtk-v4l-0.1-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 556216] Review Request: bangarang - A media player for the KDE SC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=556216 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-02-26 06:48:07 EST --- bangarang-1.0-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bangarang'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2973 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-02-26 06:50:20 EST --- constantine-backgrounds-12.1.1-3.fc13, goddard-backgrounds-12.91.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498194 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||zarafa-6.30.10-2.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566290] Review Request: goddard-backgrounds - Goddard desktop backgrounds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566290 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||constantine-backgrounds-12. ||1.1-3.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566687] Review Request: perl-MooseX-Types-DateTimeX - Extensions to MooseX::Types::DateTime::ButMaintained
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566687 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-26 06:54:24 EST --- perl-MooseX-Types-DateTimeX-0.06-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566687] Review Request: perl-MooseX-Types-DateTimeX - Extensions to MooseX::Types::DateTime::ButMaintained
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566687 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||perl-MooseX-Types-DateTimeX ||-0.06-3.fc13 Resolution|RAWHIDE |ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request - lldpad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 --- Comment #4 from Jan Vcelak jvce...@redhat.com 2010-02-26 07:22:52 EST --- Just to be clear: I'm aware of the fact that this is a re-review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=439630
--- Comment #63 from Henrique LonelySpooky Junior henrique...@gmail.com
2010-02-26 07:29:33 EST ---
SPEC: http://lonelyspooky.com/uploads/SRPMs/jogj/1.1.1-2/jogl.spec
SRPM:
http://lonelyspooky.com/uploads/SRPMs/jogj/1.1.1-2/jogl-1.1.1-2.fc11.src.rpm
rpmlint is a bit more happy now:
[virt...@localhost SPECS]$ rpmlint ../RPMS/i586/jogl*
jogl.i586: W: unstripped-binary-or-object /usr/lib/libjogl_awt.so
jogl.i586: W: no-soname /usr/lib/libjogl_awt.so
jogl.i586: W: unstripped-binary-or-object /usr/lib/libjogl.so
jogl.i586: W: no-soname /usr/lib/libjogl.so
jogl.i586: W: no-documentation
jogl-debuginfo.i586: E: empty-debuginfo-package
jogl-javadoc.i586: W: dangerous-command-in-%post rm
4 packages and 0 specfiles checked; 1 errors, 6 warnings.
[virt...@localhost SPECS]$ rpmlint ../SRPMS/jogl-1.1.1-2.fc11.src.rpm
jogl.src:75: W: rpm-buildroot-usage %build rm -rf %{buildroot}
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #64 from Chen Lei supercy...@163.com 2010-02-26 07:38:37 EST --- I wonder that Source2: gluegen-1.0.20102502svn.tar.gz is not needed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request - lldpad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 Jan Zeleny jzel...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Jan Zeleny jzel...@redhat.com 2010-02-26 07:47:45 EST --- New Package CVS Request === Package Name: lldpad Short Description: This package contains the Linux user space daemon and configuration tool for Intel LLDP Agent with Enhanced Ethernet support for the Data Center. Owners: jzeleny Branches: F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #65 from James Heather j.heat...@surrey.ac.uk 2010-02-26 08:19:12 EST --- Do you really need the %post section? It seems odd. It looks as though the ln -s in the %install, and the %ghost line in %files, should be enough to create the symlink without needing to rm and ln -s in %post. Do you need to use restorecon to set the selinux contexts, by the way? I've noticed that in some spec files before. But maybe it all happens automatically. Might be worth installing the rpm, and then trying restorecon -v $(rpm -ql jogl jogl-javadoc jogl-manual) If it tells you it's changing anything, that probably means you need to use restorecon in %post. James -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557917] Review Request: gnome-activity-journal - GUI to browse and search your Zeitgeist activities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557917 --- Comment #6 from Mads Villadsen m...@krakoa.dk 2010-02-26 08:51:47 EST --- I have made a new version of the spec file and updated to the latest version of gnome-activity-journal. Spec URL: http://krakoa.dk/fedora/gnome-activity-journal.spec SRPM URL: http://krakoa.dk/fedora/gnome-activity-journal-0.3.3-1.fc12.src.rpm I also made a scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2015931 I have addressed the things you mentioned with the exception of the buildroot as removing that gave an rpmlint warning. I have made a more comprehensive patch to the installation of gnome-activity-journal (the get rid of the symlinks among other things) and I have sent it to their mailing list for comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562504 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #30 from Thomas Spura toms...@fedoraproject.org 2010-02-26 09:20:29 EST --- The scratch build has right permissions: http://koji.fedoraproject.org/koji/taskinfo?taskID=2015955 Now doing the right build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2015966 Also with right permissions. _ There are remaining problems with the testsuite, that will hopefully be shoot down in the future. e.g. mpich2 currently can't be tested, because it needs a DNS lookup, what the buildsystem blocks. Maybe that's why openmpi also bracks. (It seems, both are not designed to work in a non-network atm...) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557917] Review Request: gnome-activity-journal - GUI to browse and search your Zeitgeist activities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=557917
Matthias Clasen mcla...@redhat.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #7 from Matthias Clasen mcla...@redhat.com 2010-02-26 09:40:49
EST ---
Thanks, looks much better now.
Builds fine in mock, rpmlint says:
$ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/gnome-activity-journal-0.3.3-1.fc14.noarch.rpm
gnome-activity-journal.noarch: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-activity-journal.schemas
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
I personally find %{__python} and %{__install} silly, but that doesn't prevent
me from moving this to APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557917] Review Request: gnome-activity-journal - GUI to browse and search your Zeitgeist activities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557917 --- Comment #8 from Matthias Clasen mcla...@redhat.com 2010-02-26 10:10:32 EST --- Oh, I forgot one thing I wanted to point out: Please update the icon cache handling to the current recommendation: https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565902] Review Request: csync - a bidirectional file synchronizer for roaming home directories
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565902 --- Comment #10 from Andreas Schneider a...@redhat.com 2010-02-26 10:21:19 EST --- ping -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557917] Review Request: gnome-activity-journal - GUI to browse and search your Zeitgeist activities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557917 Mads Villadsen m...@krakoa.dk changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Mads Villadsen m...@krakoa.dk 2010-02-26 10:26:49 EST --- New Package CVS Request === Package Name: gnome-activity-journal Short Description: Browse and search your Zeitgeist activities Owners: maxx Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226388] Merge Review: sane-backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226388 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|nphil...@redhat.com Flag||fedora-review? --- Comment #1 from Nils Philippsen nphil...@redhat.com 2010-02-26 10:41:12 EST --- http://cvs.fedoraproject.org/viewcvs/devel/sane-backends/ This has been lying around for too long already, I'll do it myself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226389] Merge Review: sane-frontends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226389 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|nphil...@redhat.com Flag||fedora-review? --- Comment #5 from Nils Philippsen nphil...@redhat.com 2010-02-26 10:42:54 EST --- http://cvs.fedoraproject.org/viewcvs/devel/sane-frontends/ This has been lying around for too long already, I'll do the review myself. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567733] Review Request: marave - A Simple text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567733 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-02-26 11:13:50 EST --- marave-0.7-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/marave-0.7-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567733] Review Request: marave - A Simple text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567733 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-02-26 11:14:31 EST --- marave-0.7-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/marave-0.7-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226389] Merge Review: sane-frontends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226389 --- Comment #6 from Nils Philippsen nphil...@redhat.com 2010-02-26 11:22:44 EST --- - PASS: rpmlint sane-frontends.src: W: spelling-error Summary(en_US) frontend - fronted, front end, front-end sane-frontends.src: W: spelling-error %description -l en_US scanadf - scandal, scanned, scandium sane-frontends.src: W: spelling-error %description -l en_US xcam - cam, scam, x cam sane-frontends.x86_64: W: spelling-error Summary(en_US) frontend - fronted, front end, front-end 2 packages and 0 specfiles checked; 0 errors, 4 warnings. frontend is a usual form of spelling this term, scanadf and xcam are names of binaries - GOOD: package is named according to Package Naming Guidelines - GOOD: spec file named correctly - GOOD: package meets Packaging Guidelines - GOOD: licensed with approved license and meets Licensing Guidelines - GOOD: license field matches actual license - BAD: license text not contained as documentation - GOOD: spec file written in American English - GOOD: spec file is legible - GOOD: source matches upstream - GOOD: package already build multiple times in koji - GOOD: all build dependencies listed - N/A: no locale files included - N/A: no libraries in system paths included - GOOD: does not bundle copies of system libraries - N/A: not relocatable - BAD: does not own all directories it creates: /usr/share/sane/sane-style.rc - GOOD: no duplicate file listings - GOOD: file permissions set properly - GOOD: has %clean - BAD: inconsistently uses $RPM_BUILD_ROOT, %buildroot - GOOD: contains code - N/A: no large documentation - GOOD: %doc doesn't affect runtime - N/A: no header files - N/A: no static libs - N/A: no pkgconfig files - N/A: no library files - N/A: no devel package - N/A: no libtool archives - BAD: no desktop files for GUIish xcam program, no explanation either - GOOD: doesn't own files of other packages - GOOD: removes buildroot in %install - GOOD: all file names valid UTF-8 -- recommendations: 1. add license file COPYING to %doc, consider adding AUTHORS, README as well 2. don't distribute /usr/share/sane/sane-style.rc since it's only used by xscanimage (which we don't ship) 3. use either %buildroot or $RPM_BUILD_ROOT consistently 4. explain why xcam has no desktop file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555162] Review Request: blast - Berkeley Lazy Abstraction Software Verification Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555162 --- Comment #8 from David A. Wheeler dwhee...@dwheeler.com 2010-02-26 11:26:44 EST --- Good news! On Thu, 25 Feb 2010 14:45:56 -0800, Rupak Majumdar ( rupak /at/ CS, dot, UCLA , dot, EDU send to me this email: = David, I am the original developer of Blast (the only other tool I know that used Vampyre and is available) and we have gotten rid of vampyre dependencies. The latest version of Blast (not depending on vampyre) is at http://www.cs.ucla.edu/~rupak/b2/ I will also relicense vampyre, but will only get to it next week. = This latest version of BLAST is really a follow-on project, with a new project name B2. It's released under the Apache 2.0 license, which is uncontroversially FLOSS. If you package B2, I suggest opening a different review request... it's a different name, different developer, etc. Once vampyre is released as FLOSS, you can continue with the BLAST packaging. I still think it's great to get vampyre released as FLOSS, even if you decide to not package BLAST itself and just package B2 or something else instead. As we package other stuff, I suspect we'll find other vampyre users :-). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567733] Review Request: marave - A Simple text editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567733 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-02-26 11:29:32 EST --- marave-0.7-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/marave-0.7-3.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566379] Review Request: perl-Ham-Reference-QRZ - Ham::Reference::QRZ perl modul
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566379 --- Comment #9 from Jens Maucher jensm.fed...@online.de 2010-02-26 12:03:04 EST --- New Package CVS Request === Package Name: perl-Ham-Reference-QRZ Short Description: An object oriented front end for the QRZ.COM Amateur Radio call-sign database Owners: jensm Branches: F-12 F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 --- Comment #21 from David A. Wheeler dwhee...@dwheeler.com 2010-02-26 12:07:08 EST --- I still don't have the right .src.rpm to review. Please upload the .src.rpm you intend for me to review, and post the correct URL. Comment #18 *cannot* be correct. Please let me explain why. Comment #18 asks me to review: http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-1.fc12.src.rpm But this can't be right: 1. The spec file embedded in the .src.rpm is NOT the same as the spec file as posted in comment #18: http://sundaram.fedorapeople.org/packages/trash-cli.spec 2. The .src.rpm filename URL is *still* release -1 (notice the -1 near the end), but we are at release -2. I tried to work around this myself by loading: http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-2.fc12.src.rpm That *did* load a file, but the spec file in this .src.rpm is *also* not the same as: http://sundaram.fedorapeople.org/packages/trash-cli.spec For example, the RPM spec file description in this .src.rpm file says trash replaces rm, but the package actually packages trash-put and *NOT* trash. You've posted a .spec file: http://sundaram.fedorapeople.org/packages/trash-cli.spec But neither .src.rpm that I have includes this spec file; they both include something *different*, and in both cases they can't be right. Please do an rpmbuild -bs trash.spec, post the resulting file, and post the resulting .src.rpm file URL. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226388] Merge Review: sane-backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226388 --- Comment #3 from Nils Philippsen nphil...@redhat.com 2010-02-26 12:10:45 EST --- (In reply to comment #2) sane-backends-devel.x86_64: W: spurious-executable-perm /usr/lib64/pkgconfig/sane-backends.pc - fix permissions [...] - GOOD: file permissions set properly obviously: BAD: fix permissions on pkgconfig file -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506425 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506425 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 506425] Review Request: lightsquid - a light, small and fast log analyzer for squid proxy
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=506425 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added AssignedTo|gareth.l.j...@googlemail.co |nob...@fedoraproject.org |m | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 515164] Review Request: gnomenu - A consolidated menu for gnome that brings eye candy to the world of the Gnome menu's
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=515164 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added CC||gareth.l.j...@googlemail.co ||m --- Comment #16 from Gareth John gareth.l.j...@googlemail.com 2010-02-26 12:24:42 EST --- (In reply to comment #15) Well, with GNOME reaching 3.0, gnomenu will be useless. Maybe packaging it should be a waste of time. Dont you think, guys? Don't think so! I won't be using gnome 3.0, buti don't use gnome 2.0. I will reveiw for you if you still want to go ahead! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 --- Comment #23 from Rahul Sundaram sunda...@redhat.com 2010-02-26 12:27:52 EST --- I have deleted and reuploaded everything now http://sundaram.fedorapeople.org/packages/trash-cli.spec http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225686] Merge Review: device-mapper-multipath
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225686 Jonathan Earl Brassow jbras...@redhat.com changed: What|Removed |Added CC||jbras...@redhat.com AssignedTo|nob...@fedoraproject.org|jbras...@redhat.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 511204] Review Request: wicd - A wireless and wired network manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=511204 Gareth John gareth.l.j...@googlemail.com changed: What|Removed |Added CC||gareth.l.j...@googlemail.co ||m --- Comment #15 from Gareth John gareth.l.j...@googlemail.com 2010-02-26 12:32:22 EST --- (In reply to comment #11) I'm going to review this package when Rangeen gives us an updated spec. I really like to see this in Fedora ASAP, but first we need to fix selinux-policy-targeted. Please take up the this package as I am not able to dedicate enough time towards packaging and Fedora in general ( Little busy with my job). You can put me as a co maintainer. If you want I can also review the package at some point of time. By the way, if this package can wait for some time then I will take up the task after some time, once I have sufficient time. I will offer help in anyway if anybody would like it. May be work together on spec and co-maintain? I will await for any updates. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226389] Merge Review: sane-frontends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226389 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||sane-frontends-1.0.14-10.fc ||14 Resolution||RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #7 from Nils Philippsen nphil...@redhat.com 2010-02-26 12:36:22 EST --- fixed in sane-frontends-1.0.14-10.fc14, approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568833] New: Review Request: OpenLP - Church projection software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: OpenLP - Church projection software https://bugzilla.redhat.com/show_bug.cgi?id=568833 Summary: Review Request: OpenLP - Church projection software Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: h...@trarbentley.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: spec info here SRPM URL: srpm info here Description: OpenLP is free church presentation software, or lyrics projection software, used to display slides of songs, Bible verses, videos, images, and even presentations (if PowerPoint is installed) for church worship using a computer and a data projector. The latest version 2.x is being developed in PYQT for cross platform support. Details of the project can be found on OpenLP.org. Need hosting access under account trb143 to upload the spec and srpms files -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566379] Review Request: perl-Ham-Reference-QRZ - Ham::Reference::QRZ perl modul
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566379 --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 12:53:30 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 557917] Review Request: gnome-activity-journal - GUI to browse and search your Zeitgeist activities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=557917 --- Comment #10 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 12:53:07 EST --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568833] Review Request: OpenLP - Church projection software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568833 Thomas Spura toms...@fedoraproject.org changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567872] Review Request: gtk-v4l : Video4Linux Preferences tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567872 --- Comment #8 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 12:54:16 EST --- This package already seems to be in the repository. Am I missing something? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request: lldpad - Daemon and configuration tool for Intel LLDP Agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Summary|Review request - lldpad |Review request: lldpad - ||Daemon and configuration ||tool for Intel LLDP Agent --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 12:57:46 EST --- If your short description wraps onto three lines, it's not really short. I'll use Daemon and configuration tool for Intel LLDP Agent. Of course, it would be really nice if your %description actually included some mention of what an LLDP agent actually is. This is the kind of thing that's supposed to be noticed as part of the package review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568641] Review request: lldpad - Daemon and configuration tool for Intel LLDP Agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568641 --- Comment #7 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 13:00:32 EST --- CVS done (by process-cvs-requests.py). I also added an F-13 branch as that seems to have been missed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568833] Review Request: OpenLP - Church projection software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568833 --- Comment #2 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 13:08:39 EST --- I cleaned up the duplicate submission and gave you the necessary access so that you will have access to fedorapeople to upload the spec and srpm. It may take up to an hour for that to propagate. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568833] Review Request: OpenLP - Church projection software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568833 --- Comment #1 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 13:07:37 EST --- *** Bug 568834 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568834] Review Request: OpenLP - Church projection software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568834 Jason Tibbitts ti...@math.uh.edu changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE --- Comment #1 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 13:07:37 EST --- *** This bug has been marked as a duplicate of bug 568833 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226388] Merge Review: sane-backends
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226388 Nils Philippsen nphil...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Fixed In Version||sane-backends-1.0.20-12.fc1 ||4 Resolution||RAWHIDE Flag|fedora-review? |fedora-review+ --- Comment #4 from Nils Philippsen nphil...@redhat.com 2010-02-26 13:26:34 EST --- Issues fixed in sane-backends-1.0.20-12.fc14, approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568833] Review Request: OpenLP - Church projection software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568833 --- Comment #4 from Jason Tibbitts ti...@math.uh.edu 2010-02-26 13:41:34 EST --- Don't think it works that way. Did you read the documentation at fedorapeople.org, create your web space, and put the files there? You'll need to post actual links to the spec and srpm if anyone's to be able to look at them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555162] Review Request: blast - Berkeley Lazy Abstraction Software Verification Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555162 --- Comment #10 from David A. Wheeler dwhee...@dwheeler.com 2010-02-26 14:02:23 EST --- I got more information from Rupak about B2 (his replacement for BLAST); B2 can work without Simplify. Thus, it *appears* that we could package B2, but we'll need to package dpt (and hope that there aren't any MORE license problems). Here is his Rupak's response: There is a compile time option to get rid of simplify. At the moment, there are backends to Simplify, Yices (also not FLOSS) and DPT (FLOSS, dpt.sourceforge.net). There is a component called Foci also not FLOSS, but an alternate CSISAT which is FLOSS. Again, there is a compile time way to take out Foci. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 David A. Wheeler dwhee...@dwheeler.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508750 --- Comment #24 from David A. Wheeler dwhee...@dwheeler.com 2010-02-26 14:16:10 EST --- Hooray! I downloaded the files per comment #23, and everything works fine now. The only rpmlint warnings are ones that are overtaken by events (the new guidelines render them unnecessary). The RPM spec's %description correctly notes that trash-put (not trash) can be used instead of rm, and man trash-put works too. The man page contents aren't quite right (they still say trash and not trash-put), but that's an upstream matter. Andrea Francia: Could you fix that in a future version? Anyway, thanks for packaging this! APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567110] Review Request: libucil - Library to render text and graphic overlays onto video images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567110 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2010-02-26 14:38:30 EST --- libucil-0.9.8-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567110] Review Request: libucil - Library to render text and graphic overlays onto video images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567110 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-02-26 14:41:04 EST --- libucil-0.9.8-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567110] Review Request: libucil - Library to render text and graphic overlays onto video images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567110 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-02-26 14:40:38 EST --- libucil-0.9.8-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567110] Review Request: libucil - Library to render text and graphic overlays onto video images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567110 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-02-26 14:39:45 EST --- libucil-0.9.8-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567110] Review Request: libucil - Library to render text and graphic overlays onto video images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567110 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555059] Review Request: clamsmtp - 1.10-1
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=555059
--- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-02-26
15:03:10 EST ---
Some notes for morpheusv's 1.10-1
! Note
From next time please change the release number of your spec file
every time you modify your spec file (if version number does not change).
* Stripping binaries
- rpmlint complains:
-
clamsmtp-debuginfo.i686: E: empty-debuginfo-package
-
You must not strip binaries by yourself and let find-debuginfo.sh
create correct debuginfo rpm:
https://fedoraproject.org/wiki/Packaging:Debuginfo#Checking_your_debuginfo_package_for_usefulness
* Timestamp
- When using install or cp commands, add -p option to
keep timestamps on installed files:
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
- Also please consider to use
--
make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p
--
to keep timestamps on installed files as much as possible.
This method usually works for Makefiles generated by recent
autotools.
* Consistent macros usage
- If you want to use install command with macro (i.e. if you want
to use %{__install}), change other commands also to macro,
like %{__make} , %{__rm} , %{__mkdir_p} , etc)
- Please choose to use one from $RPM_BUILD_ROOT and %{buildroot},
and don't use both:
https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
- Use %{_localstatedir} or %{_var} instead of using /var .
https://fedoraproject.org/wiki/Packaging/RPMMacros
- Use %{_initddir} instead of %{_initrddir}:
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Initscripts_on_the_filesystem
* Requires
- For written %postun script, proper Requires(post) is needed, ref:
https://fedoraproject.org/wiki/Packaging/SysVInitScript#InitscriptScriptlets
* Documents
- Please also add AUTHORS COPYING ChangeLog to %doc
* Some issues with installed rcsysv scripts
By the way:
- Installed rcsysv scripts have names clamsmtpd and clamd-clamsmtp,
however your spec file reads
---
84 /sbin/service clamd.clamsmtp stop /dev/null || :
90 /sbin/service %{name} condrestart /dev/null || :
---
( note: %name here is expanded as clamsmtp, not clamsmtpd )
- Installed %{_initddir}/clamsmtpd does not support condrestart
actually.
- Installed /etc/sysconfig/clamsmtpd don't seem to be source'd
by any installed rcsysv scripts (i.e. clamsmtpd rcsysv script does not
seem to source /etc/sysconfig/clamsmtpd).
- %{_initddir}/clamd-clamsmtp seem to require
/usr/share/clamav/clamd-wrapper,
which is in clamav-server but this package does not require clamav-server.
- My system does not have clamav group. clamav-filesystem seem to
create clamupdate user/group instead.
- As far as I read /usr/share/clamav/clamd-wrapper, clamd-clamsmtp tries
to create pid file under /var/run/clamav.clamsmtp/, however this package
does not own (i.e. does not create) this directory.
- Your logrotate file /etc/logrotate.d/clamsmtp contains:
-
7 killall -HUP clamd.clamsmtp 2/dev/null || :
-
However actually this does nothing.
! Note:
/usr/share/clamav/clamd-wrapper reads:
-
42 start () {
43 echo -n $Starting $prog:
44 daemon --pidfile=${CLAMD_PIDFILE} \
45 exec -a $procname /usr/sbin/clamd \
46 ${CLAMD_CONFIGFILE:+-c $CLAMD_CONFIGFILE} ${CLAMD_OPTIONS}
--pid ${CLAMD_PIDFILE}
-
i.e. when $ service clamav-clamsmtp start is typed, actually
binary /usr/sbin/clamd is executed with argv[0] changed to
clamad.clamsmtp. With this killall clamd.clamsmtp won't
work as the executed binary is actually clamd
(i.e. /proc/pid number/exe points to /usr/sbin/clamd. Also
Please check man bash and see -a option of exec
builtin command )
example:
--
[tasa...@localhost ~]$ ps ww 28450
PID TTY STAT TIME COMMAND
28450 pts/17 S 0:01 foo
[tasa...@localhost ~]$ ls -al /proc/28450/exe
lrwxrwxrwx. 1 tasaka1
[Bug 553281] Review Request: netsniff-ng - high performance linux network sniffer for packet inspection
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553281 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #16 from Kevin Fenzi ke...@tummy.com 2010-02-26 15:00:22 EST --- Yeah, I have no idea why rpmlint is complaining there. ;( I am seeing no further blockers, although if 0.5.5.0 is going to be released soon, you could just wait for that and the spec would be a good deal simpler. ;) This package is APPROVED. I will go ahead and sponsor you. If you have any questions at all with the process or steps, feel free to email me or catch me on irc. You can continue the process from: https://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_CVS_and_Set_Owner -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 439630] Review Request: jogl - Java bindings for OpenGL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=439630 --- Comment #66 from Henrique LonelySpooky Junior henrique...@gmail.com 2010-02-26 15:42:13 EST --- (In reply to comment #64) I wonder that Source2: gluegen-1.0.20102502svn.tar.gz is not needed. As described here[1] JOGL relies on gluegen's source tree: Check out the GlueGen source tree: JOGL relies on the GlueGen project to autogenerate most of the Java and JNI code for the OpenGL interface. The jogl/ and gluegen/ workspaces must be side-by-side in order for JOGL to build properly. So, it is not enough to have gluegen packaged in order to build JOGL, we'll need gluegen's source in the first stage. Here goes the error message: [lon...@localhost make]$ ant Buildfile: build.xml BUILD FAILED /home/lonely/jogl/jogl/make/build.xml:62: Cannot find ../../gluegen/make/gluegen-cpptasks.xml imported from /home/lonely/jogl/jogl/make/build.xml (In reply to comment #65) Do you really need the %post section? It seems odd. It looks as though the ln -s in the %install, and the %ghost line in %files, should be enough to create the symlink without needing to rm and ln -s in %post. You are completely right, I didn't noticed it. restorecon -v $(rpm -ql jogl jogl-javadoc jogl-manual) restorecon returns nothing: restorecon -v $(rpm -ql jogl jogl-javadoc jogl-manual) [lon...@localhost ~]$ restorecon -v $(rpm -ql jogl jogl-javadoc jogl-manual) [lon...@localhost ~]$ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566819] Review Request: suricata - IDS Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566819 Steve Grubb sgr...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #20 from Steve Grubb sgr...@redhat.com 2010-02-26 16:24:22 EST --- New Package CVS Request === Package Name: suricata Short Description: Intrusion Detection System Owners: sgrubb Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 433679] Review Request: clustermon - cluster monitor component of conga
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=433679 Lon Hohberger l...@redhat.com changed: What|Removed |Added Keywords|Reopened| Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 433678] Review Request: ricci - cluster and systems management agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=433678 Bug 433678 depends on bug 433679, which changed state. Bug 433679 Summary: Review Request: clustermon - cluster monitor component of conga https://bugzilla.redhat.com/show_bug.cgi?id=433679 What|Old Value |New Value Status|CLOSED |ASSIGNED Resolution|RAWHIDE | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 433678] Review Request: ricci - cluster and systems management agent
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=433678 Bug 433678 depends on bug 433679, which changed state. Bug 433679 Summary: Review Request: clustermon - cluster monitor component of conga https://bugzilla.redhat.com/show_bug.cgi?id=433679 What|Old Value |New Value Status|MODIFIED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 433679] Review Request: clustermon - cluster monitor component of conga
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=433679 Lon Hohberger l...@redhat.com changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566171] Review Request: libhid - A userspace USB HID acess library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=566171
--- Comment #5 from Michael Schwendt mschwe...@gmail.com 2010-02-26 17:33:37
EST ---
A closer look at the package:
2.
I still don't understand why it was GPLv3+, as the license of any
autoconf/automake or libtool files typically is not included in the rpm's
License tag.
4.
The comment Force use of system libtool is misleading. Actually, you don't
want to enforce anything. You just want to build an initial autotools/libtool
framework, because the svn snapshot doesn't include those files. Running the
included autogen.sh script would work, but it would also execute ./configure
directly.
Copying from autogen.sh works, but should be done in %prep section after
%setup, as it is a form of source preparation to be executed once only (just
like applying patches). Doing it %prep would also be beneficial for
--short-circuit builds.
And instead of running all the tools manually, you could run just autoreconf
-i.
--enable-maintainer-mode
Why do you enable it? (especially for this svn snapshot where you regenerate
the files already)
rm -rf $RPM_BUILD_ROOT%{_libdir}/*.la
The .la file in %{python_sitearch}/*/*.la should be deleted, too. Btw, it's
broken anyway if you delete the other one in %_libdir.
sed -ie /pkgpy/s/libhid/hid/g Makefile # Use 'hid' module name
instead 'libhid'
sed -ie /pkgpy/s/libhid/hid/g swig/Makefile # Use 'hid' module name
instead 'libhid'
The comment is insufficient. *Why* is this done? And it substitutes more than
intended in swig/Makefile. Take a look at the diff against the original file.
Both modifications ought to be applied as %patch files instead, which is less
fragile. These two sed substitutions would fail silently, and your %files
section is not explicit enough due to wildcards and would include _any_ Python
module and not just 'hid'.
* The diff against -1.fc12:
-BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
+BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-)
Why that change? The new one doesn't match the guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
-make CFLAGS=$CFLAGS
-
+make CFLAGS=$CFLAGS
The extra CFLAGS definition here should not be necessary and would be the wrong
place where to do it. As can be seen in rpm --eval %configure, CFLAGS are
defined and exported already when running the configure script. [If you
needed to fix the CFLAGS usage, the proper place would be to fix the
configure script and/or the Makefiles.]
make should also be run as make %{?_smp_mflags}:
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
%defattr(-,root,root)
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
+%ifnarch i686
%{python_sitearch}/*
+%endif
I guess this is because rpmbuild warns about duplicate file entries on
platforms (not limited to i686) where %{python_sitearch} and %{python_sitelib}
are the same.
But actually this is completely harmless _as long as_ you include the Python
files in the same subpackage. And rpmbuild then does not include any file more
than once.
https://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files
is merely important for packages with multiple subpackages and multiple %files
sections, where files may be included in _more than one_ subpackage by
accident.
If you have strong feelings about it, you could do
%{python_sitelib}/*
%ifarch x86_64 ppc64 sparc64 s390x
%{python_sitearch}/*
%endif
to cover more platforms correctly, but it doesn't add much value. A brief
comment instead would be fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567111] Review Request: libunicapgtk - Library to build graphical widgets for the unicap library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567111 --- Comment #4 from Fedora Update System upda...@fedoraproject.org 2010-02-26 17:36:27 EST --- libunicapgtk-0.9.8-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libunicapgtk-0.9.8-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567111] Review Request: libunicapgtk - Library to build graphical widgets for the unicap library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567111 --- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-02-26 17:37:13 EST --- libunicapgtk-0.9.8-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libunicapgtk-0.9.8-1.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567111] Review Request: libunicapgtk - Library to build graphical widgets for the unicap library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567111 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-02-26 17:38:50 EST --- libunicapgtk-0.9.8-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libunicapgtk-0.9.8-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567111] Review Request: libunicapgtk - Library to build graphical widgets for the unicap library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567111 Robert Scheck redhat-bugzi...@linuxnetz.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
