[Bug 572512] Review Request: gluegen - Java/JNI glue code generator to call out to ANSI C
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=572512
--- Comment #45 from Chen Lei 2010-04-28 23:21:02 EDT ---
(In reply to comment #3)
> (In reply to comment #2)
> > Please follow http://fedoraproject.org/wiki/Packaging/Java.
> > JAR files that require JNI shared objects MUST be installed in
> > %{_libdir}/%{name}. The JNI shared objects themselves must also be
> > installed in
> > %{_libdir}/%{name}.
> >
> > Also, you maybe need to take a look at
> > https://fedoraproject.org/wiki/Packaging/SourceURL
>
> Thank you. I'm fixing it.
Still not fixed, they should be installed into %{_libdir}/%{name}.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505360] Review Request: JSCookMenu - Javascript GUI-like web menus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505360 Caius 'kaio' Chance changed: What|Removed |Added Flag||fedora-review+ --- Comment #12 from Caius 'kaio' Chance 2010-04-28 23:17:21 EDT --- All MUST are passed. Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 505360] Review Request: JSCookMenu - Javascript GUI-like web menus
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=505360 --- Comment #11 from Caius 'kaio' Chance 2010-04-28 23:07:18 EDT --- $ rpmlint SPECS/JSCookMenu.spec SRPMS/JSCookMenu-2.0.4-2.fc12.src.rpm JSCookMenu.src: W: spelling-error Summary(en_US) Javascript -> JavaScript, Java script, Java-script 1 packages and 1 specfiles checked; 0 errors, 1 warnings. # Ignorable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476234] Review Request: mindi-busybox - Busybox version suited for Mindi
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=476234
Caius 'kaio' Chance changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|ccha...@redhat.com
Flag||fedora-review?,
||needinfo?(bruno_cor...@hp.c
||om)
--- Comment #9 from Caius 'kaio' Chance 2010-04-28
22:54:37 EDT ---
MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]
# Need a bug filed in bugzilla and put the number next to the ExcludeArch line.
MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
# gcc is in exceptions which is not needed.
MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.[9]
# Need a line "%find_lang %{name}" in %install section.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540127] Review Request: qterm - BBS client designed for BBS browsing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540127 Chen Lei changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 539948] Review Request: fqterm ---BBS client based on Qt library in linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539948 --- Comment #9 from Chen Lei 2010-04-28 22:44:12 EDT --- Thanks for review. Update to 0.9.6.8 SPEC: http://dl.dropbox.com/u/1338197/1/fqterm.spec SRPM: http://dl.dropbox.com/u/1338197/1/fqterm-0.9.6.8-1.fc12.src.rpm rpmlint fqterm-0.9.6.8-1.fc12.i686.rpm fqterm-debuginfo-0.9.6.8-1.fc12.i686.rpm fqterm.i686: W: spelling-error %description -l en_US login -> loin, logic, lo gin fqterm.i686: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/address.cfg.orig fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/language.cfg.orig fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/fqterm.cfg.orig .orig file are useful in this package, they are backup files for user configurable data. See /usr/share/FQTerm/userconf/README.txt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 476234] Review Request: mindi-busybox - Busybox version suited for Mindi
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=476234 Caius 'kaio' Chance changed: What|Removed |Added CC||ccha...@redhat.com --- Comment #8 from Caius 'kaio' Chance 2010-04-28 22:34:28 EDT --- ./SPECS/mindi-busybox.spec:20: W: setup-not-quiet 0 packages and 1 specfiles checked; 0 errors, 1 warnings. # You might need a '-q' for setup. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563844] Review Request: zim - A Desktop Wiki Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563844 --- Comment #40 from Jason Tibbitts 2010-04-28 22:26:38 EDT --- The one problem I have here, and the reason I can't do CVS right now, is that the guidelines expressly forbid two packages in the distro with names that differ only by case. I don't really know how to handle this. I don't even know if the tools will properly handle the obsolete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581913] Review Request: python-simplegeneric - Simple generic functions (similar to Python's own len(), pickle.dump(), etc.)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581913 --- Comment #5 from Jason Tibbitts 2010-04-28 22:12:58 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581164] Review Request: maven-timestamp-plugin - Provides formatted timestamps for maven builds
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581164 --- Comment #9 from Jason Tibbitts 2010-04-28 22:12:32 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585754] Review Request: dbusmenu-qt - A Qt implementation of the DBusMenu protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585754 --- Comment #5 from Jason Tibbitts 2010-04-28 22:13:54 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585073] Review Request: perl-Dist-Zilla - Distribution builder; installer not included!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585073 --- Comment #3 from Jason Tibbitts 2010-04-28 22:13:14 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578290] Review Request: mj - Mah-Jong program with network option
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578290 --- Comment #23 from Jason Tibbitts 2010-04-28 22:12:00 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585138] Review Request: python-hwdata - Python bindings to hwdata package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585138 --- Comment #5 from Jason Tibbitts 2010-04-28 22:13:32 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 572512] Review Request: gluegen - Java/JNI glue code generator to call out to ANSI C
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=572512 --- Comment #44 from Jason Tibbitts 2010-04-28 22:09:24 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563318] Review Request: ceph - User space components of the CEPH file system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563318 --- Comment #20 from Jason Tibbitts 2010-04-28 22:07:57 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561448] Review Request: jffi - Java Foreign Function Interface
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561448 --- Comment #16 from Jason Tibbitts 2010-04-28 22:07:02 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 526567] Review Request: mongodb - high-performance, open source, schema-free document-oriented database
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=526567 Silas Sewell changed: What|Removed |Added CC||si...@sewell.ch --- Comment #10 from Silas Sewell 2010-04-28 21:53:28 EDT --- An updated spec if anyone is interested: http://github.com/silas/rpms/blob/master/mongodb/mongodb.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 251805] Review Request: orafce - Implementation of some Oracle functions into PostgreSQL
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=251805 --- Comment #30 from Jason Tibbitts 2010-04-28 21:43:44 EDT --- CVS done (by process-cvs-requests.py). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225250] Merge Review: antlr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225250 Caius 'kaio' Chance changed: What|Removed |Added CC||ccha...@redhat.com --- Comment #11 from Caius 'kaio' Chance 2010-04-28 21:22:29 EDT --- Sorry for my wrong bug info changing. And ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 580554] Review Request: ghc-packedstring - A packedstring library for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580554 Jens Petersen changed: What|Removed |Added CC||peter...@redhat.com --- Comment #5 from Jens Petersen 2010-04-28 20:50:54 EDT --- It only seems to be used in one file: ForSyDe-3.0/src/Language/Haskell/TH/Lift.hs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 580554] Review Request: ghc-packedstring - A packedstring library for Haskell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580554 --- Comment #6 from Shakthi Kannan 2010-04-28 21:06:03 EDT --- @Jens: Yes. So, as suggested by Bryan, we could patch ForSyDe when packaging? If yes, please close this review request. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 214751] Review Request: xview - XView widget libraries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=214751 Caius 'kaio' Chance changed: What|Removed |Added CC||ccha...@redhat.com --- Comment #27 from Caius 'kaio' Chance 2010-04-28 21:05:19 EDT --- Ping? I would suggest to close this ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553345] Review Request: ibus-table-tv - The Thai and (Viqr) Vietnamese tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553345 Caius 'kaio' Chance changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||WONTFIX --- Comment #12 from Caius 'kaio' Chance 2010-04-28 20:58:16 EDT --- Will be replaced by ibus-table-others. Closing this bug ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 553231] Review Request: ibus-table-cyrillic - Cyrillics tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=553231 Caius 'kaio' Chance changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||WONTFIX --- Comment #15 from Caius 'kaio' Chance 2010-04-28 20:57:48 EDT --- Will be replaced by ibus-table-others. Closing this bug ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518910] Review Request: ibus-table-cantonese - Cantonese input method table for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=518910 Caius 'kaio' Chance changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||WONTFIX --- Comment #10 from Caius 'kaio' Chance 2010-04-28 20:57:19 EDT --- Will be replaced by ibus-table-cangcan. Closing this bug ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587011] Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587011 Miloslav Trmač changed: What|Removed |Added Flag|fedora-review? |fedora-review- --- Comment #1 from Miloslav Trmač 2010-04-28 20:18:50 EDT --- rpmlint: > tboot.src: W: spelling-error %description -l en_US pre -> per, ore, pee False positive. > tboot.src: E: description-line-too-long C Trusted Boot (tboot) is an open > source, pre-kernel/VMM module that uses Intel(R) Trusted Execution Technology > (Intel(R) TXT) to perform a measured and verified launch of an OS kernel/VMM. Please fix. > tboot.x86_64: W: incoherent-version-in-changelog 20100401-1 > ['20100427-1.fc12', '20100427-1'] Please fix. > tboot.x86_64: W: wrong-file-end-of-line-encoding > /usr/share/doc/tboot-20100427/README Not that important IMHO, but if you can fix it... Licensing incompatibility: AFAICS tboot/* includes code under GPL by various copyright holders (including the FSF and Linus Toarvalds), and common/sha1.c, which are incompatible; therefore the compiled binary can not be distributed. (Stopping the review here, for now.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473037] Review Request: tinycc - Tiny C Compiler
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473037 --- Comment #34 from Henry Kroll 2010-04-28 19:42:11 EDT --- Thanks. I'm going fishing for the summer, so I won't be able to help much. :) Stealth update. Fixed minor typos. Added comments to Makefile. Pushed changes upstream: git push ssh://m...@repo.or.cz/srv/git/tinycc.git mybranch:mob The above SRPM generates the following: tinycc-cross-git20100114-2.fc13.x86_64.rpm tinycc-debuginfo-git20100114-2.fc13.x86_64.rpm tinycc-git20100114-2.fc13.x86_64.rpm (provides tinycc-devel, header files) tinycc-libs-git20100114-2.fc13.x86_64.rpm (shared lib, libtcc.so.1.0) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587011] Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587011 Miloslav Trmač changed: What|Removed |Added CC||m...@redhat.com AssignedTo|nob...@fedoraproject.org|m...@redhat.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 Emmanuel Seyman changed: What|Removed |Added Keywords||Reopened Status|CLOSED |ASSIGNED Resolution|ERRATA | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579375] Review Request: perl-CGI-PSGI - Enable your CGI.pm aware applications to adapt PSGI protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579375 Emmanuel Seyman changed: What|Removed |Added Status|ON_QA |CLOSED Resolution||ERRATA --- Comment #6 from Emmanuel Seyman 2010-04-28 19:05:37 EDT --- Pushed to stable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 Emmanuel Seyman changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 Bug 579376 depends on bug 579375, which changed state. Bug 579375 Summary: Review Request: perl-CGI-PSGI - Enable your CGI.pm aware applications to adapt PSGI protocol https://bugzilla.redhat.com/show_bug.cgi?id=579375 What|Old Value |New Value Status|ON_QA |CLOSED Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 576431] Package Review: skipfish - Web application security scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576431 --- Comment #38 from Michal Ambroz 2010-04-28 19:00:47 EDT --- Hello Tomas, thanks for the fix of patch. It seems to work now. SPEC URL: http://rebus.fedorapeople.org/12/SPECS/skipfish.spec SRPM URL: http://rebus.fedorapeople.org/12/SRPMS/skipfish-1.32-0.4.b.fc12.src.rpm Koji FC12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2144434 Koji FC13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2144431 Output from rpmlint: $ rpmlint skipfish-1.32-0.4.b.fc12.i686.rpm skipfish-debuginfo-1.32-0.4.b.fc12.i686.rpm skipfish-1.32-0.4.b.fc12.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 Fedora Update System changed: What|Removed |Added Status|NEW |CLOSED Fixed In Version||perl-CGI-PSGI-0.10-1.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 --- Comment #8 from Fedora Update System 2010-04-28 18:43:58 EDT --- perl-CGI-PSGI-0.10-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 --- Comment #9 from Fedora Update System 2010-04-28 18:44:12 EDT --- perl-CGI-PSGI-0.10-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 --- Comment #10 from Fedora Update System 2010-04-28 18:44:38 EDT --- perl-CGI-PSGI-0.10-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-CGI-PSGI-0.10-1.fc11 |perl-CGI-PSGI-0.10-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579376] Review Request: perl-CGI-Application-PSGI - PSGI Adapter for CGI::Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579376 Fedora Update System changed: What|Removed |Added Fixed In Version|perl-CGI-PSGI-0.10-1.fc12 |perl-CGI-PSGI-0.10-1.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 583251] Review Request: dcfldd - Improved dd, useful for forensics and security
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583251 --- Comment #8 from Michal Ambroz 2010-04-28 18:18:53 EDT --- Hello, I have update the package with the license statements as recommended by Tom "spot" Callaway. SPEC URL: http://rebus.fedorapeople.org/12/SPECS/dcfldd.spec SRPM URL: http://rebus.fedorapeople.org/12/SRPMS/dcfldd-1.3.4.1-4.fc12.src.rpm Output from rpmlint: $ rpmlint dcfldd-1.3.4.1-4.fc12.src.rpm dcfldd-1.3.4.1-4.fc12.i686.rpm dcfldd-debuginfo-1.3.4.1-4.fc12.i686.rpm dcfldd.src: W: invalid-license Copyright Only dcfldd.i686: W: invalid-license Copyright Only dcfldd-debuginfo.i686: W: invalid-license Copyright Only 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Koji build F12: http://koji.fedoraproject.org/koji/taskinfo?taskID=2144215 Koji build F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2144225 Best regards Michal Ambroz -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578290] Review Request: mj - Mah-Jong program with network option
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578290 Göran Uddeborg changed: What|Removed |Added Flag||fedora-cvs? --- Comment #22 from Göran Uddeborg 2010-04-28 17:04:17 EDT --- That's correct, I'm already a seasoned packager with a total of one previous package in Fedora. :-) Seriously, thanks a lot for all your comments! Time to request a CVS module. New Package CVS Request === Package Name: mj Short Description: Mah-Jong program with network option Owners: goeran Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587056] Review Request: hntool - Open source hardening tool for Unix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587056 Allisson Azevedo changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #2 from Allisson Azevedo 2010-04-28 17:04:38 EDT --- [+] source files match upstream: [+] package meets naming and versioning guidelines. [+] license field matches the actual license. [+] license text included in package. [+] latest version is being packaged. [+] BuildRequires are proper. [+] compiler flags are appropriate. This is a noarch package. [+] %clean is present. [+] package builds in koji. http://koji.fedoraproject.org/koji/taskinfo?taskID=2144155 [+] package installs properly. [+] rpmlint is silent. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [+] no scriptlets present. [+] documentation is small, so no -docs subpackage is necessary. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587056] Review Request: hntool - Open source hardening tool for Unix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587056 Allisson Azevedo changed: What|Removed |Added Status|NEW |ASSIGNED CC||allis...@gmail.com AssignedTo|nob...@fedoraproject.org|allis...@gmail.com --- Comment #1 from Allisson Azevedo 2010-04-28 16:42:30 EDT --- I'll make this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587087] New: Review Request: Spawning - A HTTP server for hosting WSGI python web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Spawning - A HTTP server for hosting WSGI python web applications https://bugzilla.redhat.com/show_bug.cgi?id=587087 Summary: Review Request: Spawning - A HTTP server for hosting WSGI python web applications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ke...@tummy.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.scrye.com/~kevin/fedora/Spawning/Spawning.spec SRPM URL: http://www.scrye.com/~kevin/fedora/Spawning/Spawning-0.9.3-0.rc2.1.fc13.src.rpm Description: Spawning is a wsgi server which supports multiple processes, multiple threads, green threads, non-blocking HTTP io, and automatic graceful upgrading of code. rpmlint says: Spawning.noarch: W: spelling-error %description -l en_US wsgi -> swig, wigs Spawning.noarch: W: spelling-error %description -l en_US io -> oi, Io, ii Spawning.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/spawning/spawning_controller.py 0644L /usr/bin/env Spawning.noarch: E: non-executable-script /usr/lib/python2.6/site-packages/spawning/spawning_child.py 0644L /usr/bin/env Spawning.noarch: W: no-manual-page-for-binary spawning Spawning.src: W: spelling-error %description -l en_US wsgi -> swig, wigs Spawning.src: W: spelling-error %description -l en_US io -> oi, Io, ii All of which I think can be ignored. I can fix the non-executable-scripts if reviewer wishes. Koji scratch build at: http://koji.fedoraproject.org/koji/taskinfo?taskID=2144136 Note that we are renaming the /usr/bin/spawn command to /usr/bin/spawning. spawn conficts with the already existing spawn package and upstream has already commited to renaming to 'spawning'. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566757] Review Request: strongswan - IKEv1 and IKEv2 based VPN suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566757 --- Comment #9 from Bill Nottingham 2010-04-28 15:29:18 EDT --- (In reply to comment #3) > well, they both use /etc/ipsec.d, /etc/ipsec.conf and /etc/ipsec.secrets, both > provide /usr/sbin/ipsec and both provide a daemon named pluto that binds to > the > same port to name a few. > > it would basically mean renaming almost everything to make it non-conflicting > and tbh i don't much see the point of having both openswan and strongswan on > the same machine. Right, the point being is if there's 90-95% feature overlap, why couldn't the missing feature just be added into openswan, to save effort and confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561243] Review Request: meshlab - A system for processing and editing unstructured 3D triangular meshes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561243 --- Comment #5 from Martin Gieseking 2010-04-28 15:12:13 EDT --- The tarball contains a copy of getopt (/vcglib/wrap/system/getopt.*). As far as I see, it's not used but you should remove it in the %prep section to be sure. The source files in meshlab/src/meshlabplugins/filter_poisson/src are licensed under a variant of the BSD license. Some of the shaders are also licensed under BSD. Hence, the license of the package is "GPLv2+ and BSD". The license file meshlab/src/meshlabplugins/filter_poisson/license.txt must be added to %doc. Finally, there's a typo in a comment of the spec file: backage => package :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586913] Review Request: strongswan - An OpenSource IPsec implementation for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586913 Tareq Al Jurf changed: What|Removed |Added Status|NEW |CLOSED Resolution||DUPLICATE --- Comment #4 from Tareq Al Jurf 2010-04-28 15:07:47 EDT --- So, what's the problem with the package *** This bug has been marked as a duplicate of bug 566757 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566757] Review Request: strongswan - IKEv1 and IKEv2 based VPN suite
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566757 Tareq Al Jurf changed: What|Removed |Added CC||talj...@fedoraproject.org --- Comment #8 from Tareq Al Jurf 2010-04-28 15:07:47 EDT --- *** Bug 586913 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578024] Review Request: ingres - Relational DBMS Server and Utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578024 --- Comment #12 from Jay Hankinson 2010-04-28 15:01:08 EDT --- Update: Not sleeping on this, just waiting for changes to get into upstream before posting... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516284] Review Request: mod_auth_cas - Apache 2.0/2.2 compliant module that supports the CASv1 and CASv2 protocols
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=516284 --- Comment #3 from Adam Miller 2010-04-28 15:01:11 EDT --- Spec URL: http://maxamillion.fedorapeople.org/mod_auth_cas.spec SRPM URL: http://maxamillion.fedorapeople.org/mod_auth_cas-1.0.8.1-1.fc12.src.rpm Sorry, the bugzilla email must have gotten lost in my inbox. Many thanks for taking the time to review! I fixed the two review points as well as updated to latest upstream release. -AdamM -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530473] Review Request: lessfs - Lessfs is an inline data deduplicating filesystem.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530473 --- Comment #39 from Adam Miller 2010-04-28 14:54:25 EDT --- Michael, I would enjoy having help, help is always good! Once this makes it through review I'll happily accept your co-ownership in pkgdb. -AdamM -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585754] Review Request: dbusmenu-qt - A Qt implementation of the DBusMenu protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585754 Rex Dieter changed: What|Removed |Added Flag||fedora-cvs? --- Comment #4 from Rex Dieter 2010-04-28 14:52:45 EDT --- New Package CVS Request === Package Name: dbusmenu-qt Short Description: A Qt implementation of the DBusMenu protocol Owners: rdieter than kkofler Branches: F-12 F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587056] Review Request: hntool - Open source hardening tool for Unix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587056 Filipe Rosset changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587056] New: Review Request: hntool - Open source hardening tool for Unix
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: hntool - Open source hardening tool for Unix https://bugzilla.redhat.com/show_bug.cgi?id=587056 Summary: Review Request: hntool - Open source hardening tool for Unix Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: rosset.fil...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://filiperosset.fedorapeople.org/packages/hntool/hntool.spec SRPM URL: http://filiperosset.fedorapeople.org/packages/hntool/hntool-0.1.1-1.fc13.src.rpm Description: HnTool is an open source (GPLv2) hardening tool for Unix. It scans your system for vulnerabilities or problems in configuration files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586913] Review Request: strongswan - An OpenSource IPsec implementation for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586913 --- Comment #3 from Bill Nottingham 2010-04-28 14:29:25 EDT --- It is a (different) fork of FreeS/WAN that's already in Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 531051] Review Request: glite-security-util-java - Java Utilities for GSI Credentials
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531051 --- Comment #17 from Fedora Update System 2010-04-28 14:25:09 EDT --- glite-security-util-java-2.5.5-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/glite-security-util-java-2.5.5-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585754] Review Request: dbusmenu-qt - A Qt implementation of the DBusMenu protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585754
Thomas Janssen changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Thomas Janssen 2010-04-28
14:16:17 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. (uses provides)
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
LGPLv2+
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
40f74fd1ebc9a9a9643aab629bdfcfae
NN - Package needs ExcludeArch
OK - BuildRequires correct
NN - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
NN - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
NN - Package is a GUI app and has a .desktop file
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
OK - final provides and requires are sane
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486570 --- Comment #17 from Aldrey Galindo 2010-04-28 14:07:09 EDT --- Yes, so I made the corrections that needed to be seen. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 542715] Review Request: RabbitVCS - Easy version control
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=542715 --- Comment #17 from Juan Manuel Rodriguez 2010-04-28 14:04:21 EDT --- Sorry for the extremely long delay. SPEC: http://nushio.fedorapeople.org/rabbitvcs/rabbitvcs.spec SRPM: http://nushio.fedorapeople.org/rabbitvcs/rabbitvcs-0.13.1-1.fc12.src.rpm RPMs: http://nushio.fedorapeople.org/rabbitvcs/i686/ Changes: Using cp instead of mv to prevent the --short-cicuit breakage Removing "Obsoletes" Updated to the latest RabbitVCS, 0.13.1 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469931] Review Request: ipmiutil - IPMI Management Utilities
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469931
Terje Røsten changed:
What|Removed |Added
Flag|needinfo? |
--- Comment #31 from Terje Røsten 2010-04-28 13:56:39
EDT ---
Hi Andy,
things are getting better.
There are some small style issues, only some hangups I have that is not
important.
However there are still problems with the scripts.
Let's looking at it line by line.
> %pre
%pre is empty, so remove that tag.
> %post
> pdir=%{_sbindir}
This don't make sense, why define pdir as %{_sbindir},
use %{_sbindir} directly (if needed).
> # echo "Installing IPMI Management Utilities %{version} ..."
rpms should not generate any output (unless something wrong happens).
Remove this line.
> # POST_INSTALL
post install in %post, well we know that, remove.
> # check if chroot, which will not have /proc instances
> if [ -f /proc/devices ]
> then
> isroot=1
> else
> isroot=0
> fi
> if [ "$1" = "1" ]
> then
> # doing rpm -i, first time
> if [ $isroot -eq 1 ]
> then
> # detects IPMI interface type, output to %{_datadir}/%{name}/ipmi_if.txt
> %{_datadir}/%{name}/ipmi_if.sh
>
> # Run some ipmiutil command to see if any IPMI interface works.
> $pdir/ipmiutil wdt >/dev/null 2>&1
> fIPMIret=$?
> else
> # else chroot, set as if IPMI is not supported
> fIPMIret=1
> fi
>
> # If fIPMIret==0, the IPMI cmd was successful, and IPMI is enabled.
> if [ $fIPMIret -eq 0 ]
> then
You should move all this logic to the init scripts itself.
When a user is adding the ipmtutil package, he/she will be surprised
if the init scripts are not registered in the chkconfig system.
If something goes when starting e.g. ipmi_port let the scripts
itself return the correct error message and exit status code.
More about init scripts in full glory details here:
https://fedoraproject.org/wiki/Packaging:SysVInitScript
> # IPMI_IS_ENABLED
> # Enable services: ipmi_port reserves the IPMI RMCP port from portmap
> if [ -x /sbin/chkconfig ]; then
> /sbin/chkconfig --add ipmi_port
> /sbin/chkconfig --add ipmiutil_wdt
> /sbin/chkconfig --add ipmiutil_asy
> fi
> # Capture a snapshot of IPMI sensor data for later reuse.
> sensorout=%{_datadir}/%{name}/sensor_out.txt
> if [ ! -f $sensorout ]
> then
>echo "Saving a sensor snapshot to $sensorout ..."
>$pdir/ipmiutil sensor >$sensorout
Why are you doing this? And again, rpms should not produce any output.
> fi
> fi
> fi
> echo "done `date`"
Please remove this too.
> %preun
> # before uninstall
> echo "Uninstalling ipmiutil-%{version} package ..."
yum/rpm will inform the user any way, remove this
> # arg1 = 1 if rpm -U, arg1 = 0 if rpm -e
> if [ "$1" = "0" ]
>then
> if [ -x %{_initrddir}/ipmi_port ]
> then
> %{_initrddir}/ipmi_port stop >/dev/null 2>&1
> %{_initrddir}/ipmiutil_wdt stop >/dev/null 2>&1
> %{_initrddir}/ipmiutil_asy stop >/dev/null 2>&1
> if [ -x /sbin/chkconfig ]; then
> /sbin/chkconfig --del ipmi_port >/dev/null 2>&1
> /sbin/chkconfig --del ipmiutil_wdt >/dev/null 2>&1
> /sbin/chkconfig --del ipmiutil_asy >/dev/null 2>&1
> fi
> fi
>fi
This is better than %post, however not according to policy:
https://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets
> %postun
Same as %pre, remove.
One more thing, I had look at the script
%{_datadir}/%{name}/ipmi_if.txt
First it seems to require dmidecode, so add a requires on the dmidecode
package.
Then there is security issue:
dmiout=/tmp/dmi.out
[snip]
dmidecode >$dmiout
Remember the system is running this script as root, if a user does
$ ln -s /etc/passwd /tmp/dmi.out
before ipmutil is installed, the system is broken after impiutil is installed.
A simple fix is to use this trick:
dmiout=$(mktemp /tmp/impiutil.XX)
You also have
ifdir=/usr/share/ipmiutil
ifout=$ifdir/ipmi_if.txt
and writes to this file, however you should not write to files in /usr subdirs.
If you want to write to files, use /var/lib/ e.g.
/var/lib/ipmiutil/ipmi_if.txt
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586913] Review Request: strongswan - An OpenSource IPsec implementation for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586913 --- Comment #2 from Tareq Al Jurf 2010-04-28 13:54:05 EDT --- Isn't openswan another program? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586913] Review Request: strongswan - An OpenSource IPsec implementation for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586913 --- Comment #1 from Bill Nottingham 2010-04-28 13:27:07 EDT --- Any reason that openswan won't work for these cases? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587011] Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587011 Bill Nottingham changed: What|Removed |Added Blocks||182235(FE-Legal) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585336] Review Request: perl-Sys-CPU - Getting CPU information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585336 --- Comment #5 from Shakthi Kannan 2010-04-28 12:28:38 EDT --- Haven't yet received a reply from upstream. In the CPU.xs file, it has been mentioned that: All code contained herein in free to use and edit under the same licence as Perl itself. So, the GPL+ or Artistic License mentioned in the .spec file holds good? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587011] New: Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM https://bugzilla.redhat.com/show_bug.cgi?id=587011 Summary: Review Request: tboot - uses Intel(R) TXT to perform a measured and verified launch of a kernel/VMM Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: joseph.cih...@intel.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Group: private Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://sourceforge.net/projects/tboot/files/tboot/tboot.spec/download SRPM URL: http://sourceforge.net/projects/tboot/files/tboot/tboot-20100427-1.fc12.src.rpm/download Description: Trusted Boot (tboot) is an open source, pre-kernel/VMM module that uses Intel(R) Trusted Execution Technology (Intel(R) TXT) to perform a measured and verified launch of an OS kernel/VMM. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532534] Review request: xml-im-exporter - XML Im-/Exporter
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=532534
--- Comment #5 from Mary Ellen Foster 2010-04-28 11:54:25
EDT ---
Hi -- sorry about the delay. :( I've changed the license and made a couple of
other minor changes to the spec (clean up sourceforge URL, update buildroot,
use macros for %{mavenpomdir}, add proper Requires to the javadoc package)
Here's the new stuff:
Spec URL: http://www.macs.hw.ac.uk/~mef3/review/xml-im-exporter.spec
SRPM URL:
http://www.macs.hw.ac.uk/~mef3/review/xml-im-exporter-1.1-6.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581220 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Flag||fedora-review? Bug 581220 depends on bug 582864, which changed state. Bug 582864 Summary: Review Request: qtlockedfile - QFile extension with advisory locking functions https://bugzilla.redhat.com/show_bug.cgi?id=582864 What|Old Value |New Value Status|ASSIGNED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED --- Comment #6 from Rex Dieter 2010-04-28 11:01:33 EDT --- Looks good, comments follow: naming: good, though I'm curious why upstream tacks on _1 in the tarball name. ? sources: ok md5sum *.gz 902795eb13ecedbdc112f00d7ec22949 qtsingleapplication-2.6_1-opensource.tar.gz patches: please document patches (short .spec comment will suffice) , and preferably consult upstream about them. $ rpmlint *.rpm x86_64/*.rpm qtsingleapplication.src:52: W: configure-without-libdir-spec qtsingleapplication.x86_64: E: non-standard-executable-perm /usr/lib64/libQtSolutions_SingleApplication-2.6.so.1.0.0 0775L 4 packages and 0 specfiles checked; 1 errors, 1 warnings. I suppose using 'install -p -m755' instead of 'cp -a' can workaround this one, but you can choose whatever solution works best for you. license: ok scriptlets: ok macros: ok dependencies: ok %files: ok please address these comments, and I'll evaluate for final approval. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 539948] Review Request: fqterm ---BBS client based on Qt library in linux
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=539948
Rex Dieter changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #8 from Rex Dieter 2010-04-28 10:59:18 EDT
---
I can review this,
naming: ok
licensing: ok, though please confirm with upstream, sources contain GPLv2+ (or
later) clause.
runtime: ok, though I'd suggest adding a runtime dependency,
%{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}}
$ rpmlint *.rpm x86_64/*.rpm
fqterm.src: W: spelling-error %description -l en_US login -> loin, logic, lo
gin
fqterm.src: W: spelling-error %description -l en_US encodings -> encoding,
encoding s, encodes
fqterm.src: W: invalid-url Source0:
http://fqterm.googlecode.com/files/fqterm-0.9.6.3.tar.gz HTTP Error 404: Not
Found
fqterm.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo
gin
fqterm.x86_64: W: spelling-error %description -l en_US encodings -> encoding,
encoding s, encodes
fqterm.x86_64: E: backup-file-in-package
/usr/share/FQTerm/userconf/address.cfg.orig
fqterm.x86_64: E: non-executable-script /usr/share/FQTerm/fqterm.sh 0644L
/bin/sh
fqterm.x86_64: E: backup-file-in-package
/usr/share/FQTerm/userconf/language.cfg.orig
fqterm.x86_64: E: backup-file-in-package
/usr/share/FQTerm/userconf/fqterm.cfg.orig
3 packages and 0 specfiles checked; 4 errors, 5 warnings.
These seem mostly harmless, though probably should omit the *.orig files from
packaging.
sources: ok
$ md5sum *.gz
d9415c20eb1df1be168a465025e41fbc fqterm-0.9.6.3.tar.gz
.desktop file: ok, though I see you're using legacy/deprecated
/usr/share/pixmaps for icon. I'd recommend using the newer, themeable
/usr/share/icons instead.
%build: please document why -DBUILD_SHARED_LIBS:BOOL=OFF is used. a short
.spec comment is sufficient
macros: ok
scriptlets: ok
please address items raised here, and we'll be close to approval.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 539948] Review Request: fqterm ---BBS client based on Qt library in linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=539948 Rex Dieter changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559552] Review Request: qca-pkcs11 - Smartcard integration for QCA
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=559552
--- Comment #6 from Alon Bar-Lev 2010-04-28 10:47:21
EDT ---
Thanks!
Are you sure that the Qt developers solved the bug of vsprintf("%s", NULL) with
all Qt version this package depends?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559552] Review Request: qca-pkcs11 - Smartcard integration for QCA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559552 --- Comment #5 from Rex Dieter 2010-04-28 10:34:09 EDT --- it's in the src.rpm, posted here for convenience too: http://rdieter.fedorapeople.org/rpms/pca-pkcs11/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 561459] Review Request: jgrapht - A free Java graph library that provides mathematical graph objs and algorithms
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=561459 Alexander Kurtakov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Alexander Kurtakov 2010-04-28 10:24:53 EDT --- Thanks, This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559552] Review Request: qca-pkcs11 - Smartcard integration for QCA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=559552 --- Comment #4 from Alon Bar-Lev 2010-04-28 10:23:15 EDT --- > patches: please document the need for qca-pkcs11.cpp.vsnprintf.patch , and > please consult upstream. Where can I find the patch? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582686] Review Request: jcharts - A java based charts library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582686 Alexander Kurtakov changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com Flag||fedora-review? --- Comment #6 from Alexander Kurtakov 2010-04-28 10:20:18 EDT --- I'm taking this one. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585707] Review Request: guayadeque - Music player based on wxWidgets
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585707
Mohammed Imran changed:
What|Removed |Added
CC||imran...@gmail.com
--- Comment #1 from Mohammed Imran 2010-04-28 10:07:24 EDT
---
Please set BLOCKS to FE-NEEDSPONSOR,so that sponsors can find you.
This is a informal review
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
Need to Fix these
=
1) Summary is too short Media Player,try to expand it.
2) GROUP should be Applications/Multimedia not Application/media
3)Add gstreamer-devel in Buildrequires too and remove gcc-c++,by default gcc
will handle it
4)Source should be
http://downloads.sourceforge.net/guayadeque/guayadeque-0.2.5.tar.gz
pleas refer https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
4)Description's each line should be <79 chars
5)Use either tabs or spaces,not both(together)
6)Remove taglib from requires,its handled by rpm
7)README says it needs sqlite3
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec
[x] Package meets the Packaging Guidelines.
[X] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on:
[!] Rpmlint output:
guayadeque.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
guayadeque.src: E: description-line-too-long Music Player with the aims to be
intuitive, easy to use and fast even for huge music collections. Developed for
Linux with wxWidgets for GTK under Gnome.
guayadeque.src: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
guayadeque.i586: E: explicit-lib-dependency taglib
guayadeque.i586: E: description-line-too-long Music Player with the aims to be
intuitive, easy to use and fast even for huge music collections. Developed for
Linux with wxWidgets for GTK under Gnome.
2 packages and 1 specfiles checked; 3 errors, 2 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:GPLv2
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package:4faeeb53f83a0b8329e2bc26b9b992ab
MD5SUM upstream package:4faeeb53f83a0b8329e2bc26b9b992ab
[x] Package is not known to require ExcludeArch, OR:
Arches excluded:
Why:
[!] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[x] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 583327] Review Request: clementine - A music player and library organiser
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583327 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Bug 583327 depends on bug 577601, which changed state. Bug 577601 Summary: Review Request: libqxt - Qt extension library https://bugzilla.redhat.com/show_bug.cgi?id=577601 What|Old Value |New Value Status|ASSIGNED|ON_QA Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 559552] Review Request: qca-pkcs11 - Smartcard integration for QCA
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=559552
--- Comment #3 from Rex Dieter 2010-04-28 10:09:18 EDT
---
MUST: naming, should follow pre-release naming guidelines, and use something
like
Release: 0.1.beta2
MUST: %build, use -no-separate-debug-info build option, so that the usual
-debuginfo pkg makes sense
SHOULD: add runtime dependency,
%{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}}
licensing: should be License: LGPLv2+
$ rpmlint *.rpm x86_64/*.rpm
qca-pkcs11.src: W: spelling-error Summary(en_US) Smartcard -> Smart card,
Smart-card, Smartness
qca-pkcs11.src: W: spelling-error %description -l en_US pkcs -> pecs, pics, pk
cs
qca-pkcs11.src: W: spelling-error %description -l en_US smartcard -> smart
card, smart-card, smartness
qca-pkcs11.src: W: spelling-error %description -l en_US decryption ->
encryption, deception, description
qca-pkcs11.src:36: W: configure-without-libdir-spec
qca-pkcs11.x86_64: W: spelling-error Summary(en_US) Smartcard -> Smart card,
Smart-card, Smartness
qca-pkcs11.x86_64: W: spelling-error %description -l en_US pkcs -> pecs, pics,
pk cs
qca-pkcs11.x86_64: W: spelling-error %description -l en_US smartcard -> smart
card, smart-card, smartness
qca-pkcs11.x86_64: W: spelling-error %description -l en_US decryption ->
encryption, deception, description
qca-pkcs11-debuginfo.x86_64: W: spelling-error Summary(en_US) pkcs -> pecs,
pics, pk cs
qca-pkcs11-debuginfo.x86_64: W: spelling-error %description -l en_US pkcs ->
pecs, pics, pk cs
3 packages and 0 specfiles checked; 0 errors, 11 warnings.
patches: please document the need for qca-pkcs11.cpp.vsnprintf.patch , and
please consult upstream.
The rest looks pretty simple and clean. address these items, and I think we
have a winner.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586913] Review Request: strongswan - An OpenSource IPsec implementation for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586913 Tareq Al Jurf changed: What|Removed |Added Version|rawhide |13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586913] New: Review Request: strongswan - An OpenSource IPsec implementation for Linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: strongswan - An OpenSource IPsec implementation for Linux https://bugzilla.redhat.com/show_bug.cgi?id=586913 Summary: Review Request: strongswan - An OpenSource IPsec implementation for Linux Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: talj...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://taljurf.fedorapeople.org/Packages/i686/strongswan/strongswan.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/strongswan/strongswan-4.3.6-1.fc13.src.rpm Description: strongSwan is an OpenSource IPsec implementation for the Linux operating system. It is based on the discontinued FreeS/WAN project and the X.509 patch which we developped over the last three years. In order to have a stable IPsec platform to base our future extensions of the X.509 capability on, we decided to lauch the strongSwan project. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486570 --- Comment #16 from Itamar Reis Peixoto 2010-04-28 09:54:46 EDT --- (In reply to comment #15) Aldrey, are you willing to continue ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532590 --- Comment #9 from Peter Lemenkov 2010-04-28 09:54:19 EDT --- FYI - yaws 1.88 is out -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=486570 --- Comment #15 from Rex Dieter 2010-04-28 09:51:14 EDT --- So, who's the submitter here? Aldrey or Itamar? both? Are you going to co-maintain this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585467] Review Request: mozilla-googlesharing - Anonymizing proxy service for google sharing system
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=585467
--- Comment #7 from Thomas Spura 2010-04-28
07:50:54 EDT ---
(In reply to comment #4)
> -Used pushd and popd
> -Fixed typo google
> -Removed %define debug_package %{nil} from spec file
So you are not interessted to make this programm starting for seamonkey users?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563318] Review Request: ceph - User space components of the CEPH file system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563318 --- Comment #19 from Josef Bacik 2010-04-28 09:20:03 EDT --- Ahh perfect thanks Neil, thats a bit cleaner than what I had come up with. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 549296] Review Request: lshell - Python-based limited Shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=549296 Fabian Affolter changed: What|Removed |Added Flag|needinfo?(fab...@bernewirel | |ess.net)| --- Comment #4 from Fabian Affolter 2010-04-28 07:09:43 EDT --- Sorry for the delay. Yes, I'm back. 0.9.10 was released. Time for an update and a test with python3 according your comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586433] Review Request: Xnoise, a media player for gtk+ written in vala
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=586433 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk AssignedTo|nob...@fedoraproject.org|lkund...@v3.sk Flag||fedora-review? --- Comment #4 from Lubomir Rintel 2010-04-28 07:46:21 EDT --- Taking this for review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586433] Review Request: Xnoise, a media player for gtk+ written in vala
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=586433
--- Comment #5 from Lubomir Rintel 2010-04-28 08:09:54 EDT ---
This is definitely not ready for review yet. I understand this is your first
package, please take a look at existing packages or completed reviews and
ensure you're familiar with the packaging guidelines [1].
[1] http://fedoraproject.org/wiki/Packaging/Guidelines
Thank you.
1.) Summary:A media player for gtk+
It's GTK+, not gtk+ according to http://www.gtk.org/
2.) Getting the source file is not exactly correct
> #Get xnoise from the repository
> # hg clone https://xnoise.googlecode.com/hg/ xnoise
> # cd xnoise
> # hg up -C default
You need to specify _exact_ revision which you packed and exactly how did you
create the tarball.
Also, you can use version macro in the source file name:
xnoise-%{version}.tar.gz
3.) Long lines harm legibility:
> BuildRequires: vala, vala-devel, intltool, libtool, autogen,
> automake >= 1.11, > gnome-common, gtk2-devel, sqlite-devel,
> taglib-devel, unique-devel, gstreamer-devel,
> gstreamer-plugins-base-devel, gettext, desktop-file-utils
You can write these on separate lines:
BuildRequires: vala
BuildRequires: vala-devel
..
Also, note that vala is probably redundant; vala-devel will drag it in.
4.) Description is rather illegible:
> %description
> Xnoise is a media player for gtk+
> Xnoise is written in vala
> Xnoise can play every kind of audio/video data that gstreamer can handle
Please be more descriptive here and write complete sentences. What you wrote in
your blog entry [1] could fit here.
[1]
http://ratnadeepdebnath.wordpress.com/2010/04/28/rpm-packaging-xnoise-for-fedora/
Imagine how will this look in packagekit.
5.) No useless comments please:
> #%package devel
> #Summary:Development files for %{name}
...
Either add a devel package, or delete them.
Also, please delete the extra line breaks or use them consistently.
6.) No devel files in main package
> %{_libdir}/pkgconfig/xnoise-1.0.pc
Either place this in a -devel subpackage, or %exclude it.
7.) Missing revision number in changelog
> * Tue Apr 27 2010 rtnpro 0.1.2
This is what rpmlint complains about. Add -1 there.
8.) Use macros consistently
%{buildroot} vs. $RPM_BUILD_ROOT
http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS
9.) Extra dependencies
> Requires: gstreamer, gstreamer-plugins-base, gtk2, gettext
I'm quite sure most of these (libraries) will be depended on automatically.
Have you checked? Is gettext really required at runtime?
10.) Arch specific?
> BuildArch: i686
Why is this only for i686?
11.) Are you sure about the license?
src/plugins/lyricsfly/xnoise-lyricsfly-registration.vala:
> * This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> * the Free Software Foundation; either version 2 of the License, or
> * (at your option) any later version.
That looks like GPLv2+, not GPLv2
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 527549] Review Request: osm2go - A simple openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=527549 --- Comment #13 from Fabian Affolter 2010-04-28 07:11:40 EDT --- Thanks Martin your comments. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586777] Review Request: glyphtracer - Program for creating fonts from images
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=586777
Thomas Spura changed:
What|Removed |Added
CC||toms...@fedoraproject.org
--- Comment #1 from Thomas Spura 2010-04-28
07:27:46 EDT ---
As already discussed on IRC, it would be better to make a library here:
I think this could be usefull for other packages too, so other could simply
import this and then work with it.
So you could install it in %{python3_sitelib} and set up a starter script (I'm
sure upstream will incorporate it).
e.g.:
#!/usr/bin/python3
from glyphtracer import start_program
start_program()
(Currently untested, but should work)
(By the way, is this python3 or python2, you BR python3, but it starts with
python2...)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585928] Review Request: R-gdata - Various R programming tools for data manipulation
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585928 Kashyap Chamarthy changed: What|Removed |Added CC||kcham...@redhat.com --- Comment #2 from Kashyap Chamarthy 2010-04-28 05:12:58 EDT --- SPEC is file not accessible. Clicking on the spec files says it's a BIN file. Please fix that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 586777] New: Review Request: glyphtracer - Program for creating fonts from images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: glyphtracer - Program for creating fonts from images https://bugzilla.redhat.com/show_bug.cgi?id=586777 Summary: Review Request: glyphtracer - Program for creating fonts from images Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pnem...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/glyphtracer.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/glyphtracer-0-0.1.r68.fc13.src.rpm Description: Glyphtracer takes an image of letters. It detects all letter forms and allows the user to tag them. They are then vectorised and passed on to Fontforge for fine tuning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578290] Review Request: mj - Mah-Jong program with network option
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578290 --- Comment #19 from Klaus Grue 2010-04-28 04:22:55 EDT --- > Here's my next try ... Perfect. Sorry for not responding before. As a new packager, I do not know if I can approve your package, but as far as I am concerned: - This package (mj) is APPROVED by grue - http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored says: Review and approval for the first package for new packagers must be done by registered sponsors. Subsequent reviews can be done by any package maintainer. Informal reviews can always be done by anyone interested. http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_Sponsored also says: When the package is approved by the reviewer, you must separately obtain member sponsorship in order to check in and build your package. I do not really know what you (or I) should do from here. But I suppose next step will be you find a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582974] Review Request: dnsenum - DNSenum is a penetration testing tool created to enumerate DNS info about domains
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582974 --- Comment #11 from Mohammed Imran 2010-04-28 06:42:58 EDT --- Pre-Review https://bugzilla.redhat.com/show_bug.cgi?id=570829 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570829] Review Request: ruby-PlugMan - A simple and effective plug-in framework for Ruby application
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=570829
Mohammed Imran changed:
What|Removed |Added
CC||imran...@gmail.com
--- Comment #1 from Mohammed Imran 2010-04-28 06:30:41 EDT
---
This is a informal review.Note that iam in need of sponsor
Package Review
==
Key:
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines.
[!] Rpmlint output:
ruby-PlugMan.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
where are README PlugMan.pdf ?
[x] Package is not relocatable.
[x] Buildroot is correct
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type:Ruby
[x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package:77203c501e2cf674fbc59ecb5a013c17
MD5SUM upstream package:77203c501e2cf674fbc59ecb5a013c17
[x] Package is not known to require ExcludeArch, OR:
Arches excluded:
Why:
[!] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
why BUILDREQUIRES:ruby ? ruby(abi) =1.8 is enough
also there is no need for ruby(gems) for doc package.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[x] Large documentation files are in a -doc subpackage, if required.
[x] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[x] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[x] All filenames in rpm packages must be valid UTF-8
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 578290] Review Request: mj - Mah-Jong program with network option
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578290 Klaus Grue changed: What|Removed |Added Flag||fedora-review+ --- Comment #21 from Klaus Grue 2010-04-28 06:16:36 EDT --- > Göran is already in fedora packager's group and already has > a sponsor, so if you think this package can be approved, > you can set fedora-review flag to +. OK. Thanks. Done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 585151] Review Request: R-sciplot - Scientific Graphing Functions for Factorial Designs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=585151 Pierre-YvesChibon changed: What|Removed |Added CC||pin...@pingoured.fr --- Comment #1 from Pierre-YvesChibon 2010-04-28 05:57:21 EDT --- Quickly: - Fix version The version of this package is 1.0.7 not 1.0 cf http://fedoraproject.org/wiki/Packaging:R#R_version - Fix %check - Fix %changelog Please update the format of the changelog, the version-release should be on the same line as the changelog entree. - Please include the README and the CHANGELOG as doc -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584988] Review Request: R-lme4 - Linear mixed-effects models using S4 classes
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=584988
Pierre-YvesChibon changed:
What|Removed |Added
CC||pin...@pingoured.fr
--- Comment #1 from Pierre-YvesChibon 2010-04-28 05:49:03
EDT ---
Having a quick look at it:
- Fix version
The version of this package is 0.999375.33 not 0.999375 cf
http://fedoraproject.org/wiki/Packaging:R#R_version
- Fix %changelog
Please update the format of the changelog, the version-release should be on
the same line as the changelog entree.
- Fix Requires
You might want to have Requires: R-core >= %{Rversion} instead of just R
- Fix %check
Although, this show that there are dependencies missing for this package:
> Packages required but not available:
> mlmRev MEMSS
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 572233] Review Request: compat-tracker - Compatibilty libraries and tools for tracker-0.6.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=572233 --- Comment #49 from Hicham HAOUARI 2010-04-28 05:45:02 EDT --- (In reply to comment #48) > > That is the whole point of paperbox, rely on tracker indexing to view > > documents > > by tags and other metadata. > > There's a difference between tags, which you manually add, and automatic > indexing of all files. I haven't tried the program, but judging from the UI in > their screenshot, it seems to focus on tags, not so much on indexed metadata. > But of course it's quite possible that disabling the automatic indexing would > significantly degrade its functionality. Are you familiar with PaperBox? > I don't use it, but its page says "detects your documents using tracker". What is that supposed to mean other than indexing ? > > As for FESCo, we didn't actually vote on this because we got the impression > the > issue at hand was already resolved. If you want this to be addressed, please > reopen the FESCo ticket or file a new one, either way with a clear proposal of > what you want FESCo to decide (e.g. revoke the approval of compat-tracker and > retire paperbox). Of course I can't tell you in advance whether the vote will > end up in favor of your proposal or not. It also depends on how well you can > make your case. Well, I would rather respect paperbox' packager decision, he is the owner of the package after all ( if he is still alive ). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 584974] Review Request: R-combinat - R routines for combinatorics
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=584974 Pierre-YvesChibon changed: What|Removed |Added CC||pin...@pingoured.fr --- Comment #1 from Pierre-YvesChibon 2010-04-28 05:39:33 EDT --- Having no answer from you on the devel mailing-list I only went quickly through this package. There are the few remarks I have: - Fix version The version of this package is 0.0.7 not 0.0 cf http://fedoraproject.org/wiki/Packaging:R#R_version (Why did you change compare to R-bitops ?) - Fix %check Package builds fine with the %check here - Fix %changelog Please update the format of the changelog, the version-release should be on the same line as the changelog entry. This point is valid for at least R-bitops to. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
