[Bug 593069] Review Request: pynie - Implementation of Python 3 on top of the Parrot virtual machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593069 --- Comment #3 from Gerd Pokorra g...@zimt.uni-siegen.de 2010-05-21 02:37:47 EDT --- Parrot is a virtual machine. It is general designed as a targed for dynamic languages. All HLL can use Parrot. It has a powerful suite of compiler tools. It would be nice if some Python programmers could be activated to implemening a Python compiler on Parrot. I think announcing Pynie would motivate Python programmers to join Parrot. Where are the best places to accounce Pynie in the Python community? Dave: Would you do that? May be http://bitbucket.org/allison/pynie is a place where Python programmers can hacking on an implemention of a Python compiler on top of Parrot. (Vision: http://www.pynie.org) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581509] Review Request: yacas - easy to use, general purpose Computer Algebra System
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=581509
--- Comment #9 from Ankur Sinha sanjay.an...@gmail.com 2010-05-21 03:11:34
EDT ---
review:
? - issue
+ - OK
- - NA
* - checking
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
at line 102, forgot brackets around buildroot :P
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
+ Sources match upstream md5sum:
[an...@localhost rpmbuild]$ md5sum SOURCES/yacas-1.2.2.tar.gz
329f149ca3ceb976a7e596b56fc3cba5 SOURCES/yacas-1.2.2.tar.gz
[an...@localhost rpmbuild]$ md5sum yacas-1.2.2.tar.gz
329f149ca3ceb976a7e596b56fc3cba5 yacas-1.2.2.tar.gz
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
+ Headers/static libs in -devel subpackage.
+ Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
? -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
- Package compiles and builds on at least one arch.
- Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk and
anything provided by glibc.)
SHOULD Items:
* Should build in mock.
* Should build on all supported archs
* Should function as described.
- Should have sane scriptlets.
? Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
+ check for outstanding bugs on package. (For core merge reviews)
Issues:
1.I see that miniLZO has been bundled along with yacas. That isn't permitted :(
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
You'll have to take care of that, since it's a library. It should be packaged
separately and reviewed. yacas should then mention it as a build requires IMO.
2. The requires on the base package need to be versioned.
3. Short comments on the requires you've added is advised.
I'm checking the should items, you should meanwhile correct the above. The
bundled lib is a blocker. The package cannot be approved until that is
corrected
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 583102] Review Request: radiotray - Radio Tray is a streaming player for listening to online radios
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583102 --- Comment #9 from Ankur Sinha sanjay.an...@gmail.com 2010-05-21 03:15:08 EDT --- (In reply to comment #8) The guidelines just ask you to add a comment in the spec file and explain why explicit dependencies are needed. In this case they are needed, because there are no automatic dependencies for the needed Python modules. [...] With regard to eliminating redundant Requires (e.g. pygobject2 -- pygtk2, although radiotray directly imports the gobject module, too), it's not necessary to trim such Requires, and in other cases it may even bear a risk. Thanks for pitching in Michael :) Jean, please submit the updated spec and srpm and we can get this one approved quick. :) Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell chalmers-lava2000 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #10 from Jens Petersen peter...@redhat.com 2010-05-21 03:16:07 EDT --- Is lava.vhd needed at runtime or is it more a demo/devel file? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell chalmers-lava2000 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #11 from Shakthi Kannan shakthim...@gmail.com 2010-05-21 03:38:18 EDT --- From upstream: When you use writeVhdl to convert a circuit to VHDL, the generated file will use definitions from lava.vhd. So your VHDL project must import both lava.vhd as well as the generated file. So, it is useful for demo/development. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593661] Review Request: maven-enforcer - Maven Enforcer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593661 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #5 from Alexander Kurtakov akurt...@redhat.com 2010-05-21 03:51:04 EDT --- Built in koji: http://koji.fedoraproject.org/koji/buildinfo?buildID=174403 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell chalmers-lava2000 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #12 from Jens Petersen peter...@redhat.com 2010-05-21 03:57:52 EDT --- Thanks - do you have a small example file? Just wondering if it will look for lava.vhd in a particular place. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell hardware description library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #14 from Jens Petersen peter...@redhat.com 2010-05-21 04:03:48 EDT --- (In reply to comment #12) Just wondering if it will look for lava.vhd in a particular place. Or maybe it just assumes the copied has been copied to the cwd? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell hardware description library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 Jens Petersen peter...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |ghc-chalmers-lava2000 - |ghc-chalmers-lava2000 - |Haskell chalmers-lava2000 |Haskell hardware |library |description library -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell hardware description library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #16 from Jens Petersen peter...@redhat.com 2010-05-21 04:38:48 EDT --- OK thanks if you are happy with the patch then please post an updated package. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593607] Review Request: plexus-active-collections - Plexus Container-Backed Active Collections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593607 Yang Yong yy...@redhat.com changed: What|Removed |Added Flag|fedora-cvs+ |fedora-cvs? --- Comment #9 from Yang Yong yy...@redhat.com 2010-05-21 04:46:54 EDT --- New Package CVS Request === Package Name: plexus-active-collections Short Description: Plexus Container-Backed Active Collections Owners: yyang Branches: devel InitialCC: akurtako huwang liweinan Sorry for that the name is wrong in previous cvs request, please create cvs for this package again with the correct name, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594481] Review Request: orion-ssh2 - SSH-2 protocol implementation in pure Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594481 --- Comment #8 from Lubomir Rintel lkund...@v3.sk 2010-05-21 04:48:57 EDT --- (In reply to comment #6) Lubomir, Have you tried getting http://www.cleondris.ch/contact/ to join your work? Nope. orion-ssh2 is not my project, I merely helped ajmas to do a release and merge known forks into it. At the time, both trilead-ssh2 and ganymed-ssh2 were unmaintained, so I did not bother letting them know. Moreover, ganymed-ssh2 does not seem compatible with trilead-ssh2; at the very least they use a different name space. Purpose of orion-ssh2 is to pick up the work where trilead stopped, put and end to dozens of random trilead-ssh2 forks that came to an existence. (In reply to comment #7) ... it is a guess that SVNKit plans to use it, I remember the first time I wrote on the SVNKit mailing list about the dead of trilead-ssh2 that someone told me that if needed they will host it That list merely enumerates software that uses trilead-ssh2's private forks or was in danger of doing so. Plan is to give those projects a chance to migrate to a community maintained code base so that their contributions don't get lost. (In reply to comment #5) Robert, Can you dedicate some time to make svnkit work with orion-ssh2 and making upstream svnkit use it. I will to that. If I recall correctly, the only change was a single added method and one with the same functionality went in via another merger of another fork, thus getting svnkit to use it is utterly trivial. (In reply to comment #5) Lubomir, Please drop this gcj parts, it's not nice to sneak gcj in when I just want svnkit. I will do that only if Robert agrees, I based this on his package, I wish that he maintained this, and will not remove functionality without his consent (despite none of the my packages that are meant to use orion-ssh2 use those). Robert? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593841
--- Comment #7 from leigh scott leigh123li...@googlemail.com 2010-05-21
04:46:05 EDT ---
I believe you should also validate the autostart desktop file.
desktop-file-install \
--dir %{buildroot}%{_sysconfdir}/xdg/autostart \
%{buildroot}%{_sysconfdir}/xdg/autostart/wicd-tray.desktop
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593274] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-05-21 05:36:39 EDT --- rubygem-will_paginate-2.3.12-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-will_paginate-2.3.12-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell hardware description library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=546376 --- Comment #17 from Shakthi Kannan shakthim...@gmail.com 2010-05-21 05:39:51 EDT --- I was able to test the package with First.hs example from tutorial.ps and it runs fine! Updated: SPEC: http://shakthimaan.fedorapeople.org/SPECS/ghc-chalmers-lava2000.spec SRPM: http://shakthimaan.fedorapeople.org/SRPMS/ghc-chalmers-lava2000-1.1.1-4.fc12.src.rpm Successful Koji builds for F-13 and F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2200757 http://koji.fedoraproject.org/koji/taskinfo?taskID=2200762 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593274] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-05-21 05:43:53 EDT --- rubygem-will_paginate-2.3.12-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-will_paginate-2.3.12-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593274] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-05-21 05:49:36 EDT --- rubygem-will_paginate-2.3.12-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-will_paginate-2.3.12-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593839] Review Request: python-urwid - Console user interface library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593839
--- Comment #13 from Christoph Wickert cwick...@fedoraproject.org 2010-05-21
05:52:36 EDT ---
(In reply to comment #9)
%{__rm} -f tmpl_tutorial.html
%{__mkdir} examples
%{__cp} -p *.py examples
%{__rm} examples/test_urwid.py
Please don't use macros for trivial things like rm, mkdir or cp. This was
discussed on fedora-devel recently and people agreed these macros offer no
benefit, see
http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594040] Review Request: apache-commons-fileupload - rename of jakarta-commons-fileupload
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594040 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #7 from Stanislav Ochotnicky socho...@redhat.com 2010-05-21 05:56:12 EDT --- Thanks. Package built- Closing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592770] Review Request: texmakerx - LaTex Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592770 --- Comment #3 from hannes johannes.l...@googlemail.com 2010-05-21 05:57:13 EDT --- Hello Rafael, this program isn't equal to the normal texmaker (mind the little x at the end) ;) The new dependency is something to think about. Greetings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593839] Review Request: python-urwid - Console user interface library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593839
--- Comment #14 from Chen Lei supercyp...@gmail.com 2010-05-21 06:03:05 EDT
---
(In reply to comment #13)
(In reply to comment #9)
%{__rm} -f tmpl_tutorial.html
%{__mkdir} examples
%{__cp} -p *.py examples
%{__rm} examples/test_urwid.py
Please don't use macros for trivial things like rm, mkdir or cp. This was
discussed on fedora-devel recently and people agreed these macros offer no
benefit, see
http://lists.fedoraproject.org/pipermail/devel/2010-March/133466.html
I agree with you to not use those macros, but someone may not be agree with
this.
See https://bugzilla.redhat.com/show_bug.cgi?id=592670
I use those macros here just to keep packaging style close to David :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 459892] Review Request: rubygem-mocha - Mocking and stubbing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459892 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Blocks||593274 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 459892] Review Request: rubygem-mocha - Mocking and stubbing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459892 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added CC||mfoj...@redhat.com --- Comment #36 from Michal Fojtik mfoj...@redhat.com 2010-05-21 06:11:22 EDT --- Could you please build package also for EL-5 ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593274] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added Depends on||459892 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593839] Review Request: python-urwid - Console user interface library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593839 --- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 06:24:54 EDT --- and who banned using such macros? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 459892] Review Request: rubygem-mocha - Mocking and stubbing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459892 --- Comment #37 from Fedora Update System upda...@fedoraproject.org 2010-05-21 06:51:05 EDT --- rubygem-mocha-0.9.7-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-mocha-0.9.7-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587198] Review Request: jgraphx - Java Graph Drawing Component
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587198 --- Comment #9 from Sylvestre Ledru sylvestre.le...@scilab.org 2010-05-21 07:38:55 EDT --- For your information, jgraphx is regularly breaking backward compatibility (the compilation will work but the application based on jgraphx will fails). If you package jgraphx 1.4.0.2, it will break some behavior of Scilab. Scilab 5.2.2 expects jgraphx 1.2.0.8. I can ask to the developer of the Scilab jgraphx-based component for a patch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590522 --- Comment #14 from Mat Booth fed...@matbooth.co.uk 2010-05-21 07:42:21 EDT --- Hmm, I rebuilt your SPRM again myself, and this time it failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=2200828 Also, in both our builds, it fails to get this pom file: JPP/maven2/default_poms/JPP-apache-commons-logging.pom Seems like it should be finding this one first anyway: JPP/maven2/poms/JPP-commons-logging.pom What's going on there? Also, please provide a valid url in the spec file URL tag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593879] Review Request: libvpx - VP8 Video Codec SDK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593879 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Tom spot Callaway tcall...@redhat.com 2010-05-21 07:48:36 EDT --- New Package CVS Request === Package Name: libvpx Short Description: VP8 Video Codec SDK Owners: spot Branches: F-11 F-12 F-13 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566560 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Tom spot Callaway tcall...@redhat.com 2010-05-21 07:50:46 EDT --- New Package CVS Request === Package Name: libaesgm Short Description: Library implementation of AES (Rijndael) cryptographic methods Owners: spot Branches: F-11 F-12 F-13 devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590522 --- Comment #16 from Mat Booth fed...@matbooth.co.uk 2010-05-21 08:05:27 EDT --- No problem, thanks for your attention Stanislav :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590522 --- Comment #17 from Stanislav Ochotnicky socho...@redhat.com 2010-05-21 08:18:36 EDT --- Just to explain (might be useful for future): One of the dependencies that plexus-cipher pulls in is using old jakarta-commons-logging package I assume. It had wrong groupId (commons-logging instead of org.apache.commons) so I had to fix it when I renamed package to apache-commons-logging. I tried to keep backward compatibility but I forgot to change one call to use correct name... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592208] Review Request: apache-commons-daemon - rename of jakarta-commons-daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592208 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-05-21 08:13:04 EDT --- (In reply to comment #1) I can do this one. when you take a package you're supposed to change the status to Assigned -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592208] Review Request: apache-commons-daemon - rename of jakarta-commons-daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592208 Mat Booth fed...@matbooth.co.uk changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592770] Review Request: texmakerx - LaTex Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592770 --- Comment #4 from Rafael Aquini aqu...@linux.com 2010-05-21 08:17:21 EDT --- Hello Hannes, As I said before, it's just an informal review. However, consider the following observation, please. (In reply to comment #3) this program isn't equal to the normal texmaker (mind the little x at the end) ;) So, it would be better if you have said that TexMakerX is a fork of Texmaker IDE in your Spec description. Also, you should evidence TexMakerX's differences/improvements regarding to TexMaker. Think how confusingly could be to an ordinary user trying to choose which of two packages to install and the only difference he/she is noticing is a little 'x' in package's name. Best regards. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592208] Review Request: apache-commons-daemon - rename of jakarta-commons-daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592208 --- Comment #3 from Stanislav Ochotnicky socho...@redhat.com 2010-05-21 08:33:36 EDT --- Also set the fedora-review flag to '?' :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593274] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 --- Comment #14 from Michal Fojtik mfoj...@redhat.com 2010-05-21 08:34:52 EDT --- Actually, EL-5 is blocked by rubygem-mocha. I contacted maintainer of this package and requested a build for EL-5. I'll build this package for this branch as soon as this dependency will be included in updates. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594744] New: Review Request: zint - A barcode generator and library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: zint - A barcode generator and library https://bugzilla.redhat.com/show_bug.cgi?id=594744 Summary: Review Request: zint - A barcode generator and library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: martin.giesek...@uos.de QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~mgieseki/zint/zint.spec SRPM URL: http://fedorapeople.org/~mgieseki/zint/zint-2.3.1-1.fc12.src.rpm Description: Zint is a C library for encoding data in several barcode variants. The bundled command-line utility provides a simple interface to the library. Features of the library: - Over 50 symbologies including all ISO/IEC standards, like QR codes. - Unicode translation for symbologies which support Latin-1 and Kanji character sets. - Full GS1 support including data verification and automated insertion of FNC1 characters. - Support for encoding binary data including NULL (ASCII 0) characters. - Health Industry Barcode (HIBC) encoding capabilities. - Output in PNG, EPS and SVG formats with user adjustable sizes and colors. - Verification stage for SBN, ISBN and ISBN-13 data. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594481] Review Request: orion-ssh2 - SSH-2 protocol implementation in pure Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594481 --- Comment #9 from Robert Marcano rob...@marcanoonline.com 2010-05-21 09:52:59 EDT --- Moreover, ganymed-ssh2 does not seem compatible with trilead-ssh2; at the very least they use a different name space. Purpose of orion-ssh2 is to pick up the work where trilead stopped, put and end to dozens of random trilead-ssh2 forks that came to an existence. there is a reason for that, ganymed-ssh2 is the original implementation and trilead-ssh2 was the first to change package names, as I mentioned there are still old packages that depends on the original implementation. (In reply to comment #5) Robert, Can you dedicate some time to make svnkit work with orion-ssh2 and making upstream svnkit use it. I will to that. If I recall correctly, the only change was a single added method and one with the same functionality went in via another merger of another fork, thus getting svnkit to use it is utterly trivial. I sent an email to Christian Plattner (ganymed-ssh2 author) telling about this bug report, we should give him the opportunity to know about orion-ssh2 and maybe join it or orion-ssh2 people to join the original codebase project (In reply to comment #5) Lubomir, Please drop this gcj parts, it's not nice to sneak gcj in when I just want svnkit. I will do that only if Robert agrees, I based this on his package, I wish that he maintained this, and will not remove functionality without his consent (despite none of the my packages that are meant to use orion-ssh2 use those). Robert? No problem for me, I always maintained gcj bits thinking in PowerPC users, but now that PowerPC is not a primary target platform, and OpenJDK zero assembler JIT are maturing we think we can remove the GCJ dependency -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594756] New: Review Request: apache-commons-beanutils - rename of jakarta-commons-beanutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: apache-commons-beanutils - rename of jakarta-commons-beanutils https://bugzilla.redhat.com/show_bug.cgi?id=594756 Summary: Review Request: apache-commons-beanutils - rename of jakarta-commons-beanutils Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: socho...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: --- Spec URL: http://sochotni.fedorapeople.org/apache-commons-beanutils.spec SRPM URL: http://sochotni.fedorapeople.org/apache-commons-beanutils-1.8.3-1.fc12.src.rpm Description: The scope of this package is to create a package of Java utility methods for accessing and modifying the properties of arbitrary JavaBeans. No dependencies outside of the JDK are required, so the use of this package is very lightweight. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594756] Review Request: apache-commons-beanutils - rename of jakarta-commons-beanutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594756 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Blocks||588764 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593069] Review Request: pynie - Implementation of Python 3 on top of the Parrot virtual machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593069 --- Comment #4 from Dave Malcolm dmalc...@redhat.com 2010-05-21 10:27:02 EDT --- I think announcing Pynie would motivate Python programmers to join Parrot. Where are the best places to accounce Pynie in the Python community? (FWIW I heard about it via Allison's talk at PyCon in Atlanta, 3 months ago) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591982] Review Request: batti - Simple battery monitor for the system tray
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591982 Martin Gieseking martin.giesek...@uos.de changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #2 from Martin Gieseking martin.giesek...@uos.de 2010-05-21 10:52:24 EDT --- Hi Christoph, here are some quick comments: - the package license seems to be GPLv2+, not GPLv3+ - file COPYING is missing in %doc - if I understand the guidelines correctly, BR: python-devel is not sufficient any longer, but an explicitly given Python version number is required (https://fedoraproject.org/wiki/Packaging:Python#BuildRequires) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593607] Review Request: plexus-active-collections - Plexus Container-Backed Active Collections
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593607 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi ke...@tummy.com 2010-05-21 11:05:59 EDT --- I did create the correct name. ;) However, it didn't finish properly. It should all be there now. Can you try and confirm? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590522] Review Request: plexus-cipher-1.4-1 - Plexus Cipher: encryption/decryption Component
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590522 --- Comment #18 from Mat Booth fed...@matbooth.co.uk 2010-05-21 11:05:41 EDT --- Ok the commons-logging thing has been fixed, but it still fails to build for me: http://koji.fedoraproject.org/koji/taskinfo?taskID=2201405 [INFO] [ERROR] BUILD ERROR [INFO] [INFO] Internal error in the plugin manager executing goal 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc': Unable to find the mojo 'org.apache.maven.plugins:maven-javadoc-plugin:2.4:javadoc' in the plugin 'org.apache.maven.plugins:maven-javadoc-plugin' org.apache.maven.doxia.logging.LogEnabled [INFO] I'm not sure what Unable to find the mojo means, is it a problem with this package or a problem in the maven javadoc plugin? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593879] Review Request: libvpx - VP8 Video Codec SDK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593879 Dennis Gilmore den...@ausil.us changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #16 from Dennis Gilmore den...@ausil.us 2010-05-21 11:11:08 EDT --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587320] Review Request: gnome-icon-theme-symbolic - Symbolic GNOME icons
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587320 Bastien Nocera bnoc...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE --- Comment #7 from Bastien Nocera bnoc...@redhat.com 2010-05-21 11:34:42 EDT --- Built in rawhide, thanks. gnome-icon-theme-symbolic-2.30.0-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591222] gtk3 - version 3 of GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591222 --- Comment #9 from Bastien Nocera bnoc...@redhat.com 2010-05-21 11:37:13 EDT --- Builds properly: http://koji.fedoraproject.org/koji/taskinfo?taskID=2201276 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592614] Review Request: apache-commons-launcher - A cross platform Java application launcher
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592614
--- Comment #3 from Mat Booth fed...@matbooth.co.uk 2010-05-21 11:40:43 EDT
---
(In reply to comment #2)
Since this is required I acknowledge that this is re-review
OK: rpmlint must be run on every package. The output should be posted in the
review.
apache-commons-launcher.src: W: invalid-url Source0:
commons-launcher-1.2-src.tar.gz
apache-commons-launcher.noarch: W: non-conffile-in-etc
/etc/maven/fragments/apache-commons-launcher
apache-commons-launcher-javadoc.noarch: W: obsolete-not-provided
jakarta-commons-launcher-javadoc
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
False positives, Source0 explained and OK too. I would like to see at
least part of that reasoning in the spec file so perhaps next
maintainer will know he can start using normal release instead of SVN
Yes, I should have just added that text to the SPEC file. Best to be explicit
about what I've done.
FAIL: The package must be named according to the Package Naming Guidelines .
Check the package naming guidelines on snapshot please.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#SnapshotPackages
From your explanation I believe this is not pre-relase, but post
release package. Therefore there should be something like:
Release: 1.20100518svn936225
Fair enough, I've changed this.
You can drop the release number of course..
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work
on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: All build dependencies must be listed in BuildRequires, except for any
that
are listed in the exceptions section of the Packaging Guidelines ; inclusion
of
those as BuildRequires is optional. Apply common sense.
OK: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create
a
directory that it uses, then it should require a package which does create
that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: Packages must not own files or directories already owned by other
packages.
The rule of thumb here is that the first package to be installed should own
the
files or directories that other packages may rely upon. This means, for
example, that no package in Fedora should ever share ownership with any of the
files or directories owned by the filesystem or man package. If you feel that
you have a good reason to own a file or directory that another package owns,
then please present that at package review time.
OK: All filenames in rpm packages must be valid UTF-8.
Other:
I checked
[Bug 591222] gtk3 - version 3 of GTK+
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591222
Bastien Nocera bnoc...@redhat.com changed:
What|Removed |Added
AssignedTo|nob...@fedoraproject.org|bnoc...@redhat.com
--- Comment #10 from Bastien Nocera bnoc...@redhat.com 2010-05-21 12:24:32
EDT ---
210 # Input method frameworks want this•
211 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d•
212 cp %{SOURCE3} $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d•
This is already install in gtk2.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 570457] Review Request: rubygem-right_rackspace - Interface classes for Rackspace
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=570457 --- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:45:31 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Adam Young ayo...@redhat.com changed: What|Removed |Added Flag|needinfo?(ayo...@redhat.com | |) | --- Comment #13 from Adam Young ayo...@redhat.com 2010-05-21 12:48:11 EDT --- Just one of many buildr related rubygems. PLus, I've been diverted to other tasks. I'll get to this, or someone from the candlepin team will, in the near future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588435] Review Request: rubygem-libxml-ruby - libxml support for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588435 Adam Young ayo...@redhat.com changed: What|Removed |Added Flag|needinfo?(ayo...@redhat.com | |) | --- Comment #14 from Adam Young ayo...@redhat.com 2010-05-21 12:47:10 EDT --- Mamoru, Sorry, I was expecting that Matthew would post a corrected SRPM. I'll rebuild and post one later on today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587438] Review Request: rubygem-snmp - A Ruby implementation of SNMP (the Simple Network Management Protocol)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587438 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(mastah...@gmail.c ||om) --- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:47:04 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569198] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=569198 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |CLOSED Blocks|177841(FE-NEEDSPONSOR) |201449(FE-DEADREVIEW) Resolution||NOTABUG Flag|needinfo?(adrian.jo...@fedo | |raproject.ro) | --- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:52:21 EDT --- Once closing. If someone wants to import this package into Fedora, please submit a new review request and mark this bug as a duplicate of the new one, thank you! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588435] Review Request: rubygem-libxml-ruby - libxml support for ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588435 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(ayo...@redhat.com ||) --- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:39:29 EDT --- What is the status of this bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592770] Review Request: texmakerx - LaTex Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592770 --- Comment #5 from hannes johannes.l...@googlemail.com 2010-05-21 12:55:41 EDT --- Ok I added another description. Just noticed today that this description was the one of texmaker. I added the description of the texmakerx guys which is presented on their homepage. I hope this is going to improve the package. Anyway thanks for your comments. Greetings -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473184] Review Request: clamz - Amazon Downloader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473184 Jonathan Dieter jdie...@gmail.com changed: What|Removed |Added Flag||fedora-review+ --- Comment #24 from Jonathan Dieter jdie...@gmail.com 2010-05-21 12:58:19 EDT --- Seeing as the only thing that needs to be done is adding a Requires: shared-mime-info, I'm approving this contingent on that being done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473184] Review Request: clamz - Amazon Downloader
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=473184
--- Comment #23 from Jonathan Dieter jdie...@gmail.com 2010-05-21 12:56:38
EDT ---
Legend:
X = Good
- = Not so good
N/A = Not applicable
[ X ] MUST: rpmlint must be run on every package
clamz.src: W: spelling-error %description -l en_US
com's - con's, om's, come's
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
clamz.x86_64: W: spelling-error %description -l en_US
com's - con's, om's, come's
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
rpmlint doesn't like the com in Amazon.com. Maybe they'll change
their name to make rpmlink happy. Or not. :)
[ X ] MUST: The package must be named according to the Package Naming
Guidelines
[ X ] MUST: The spec file name must match the base package %{name} [...]
[ ] MUST: The package must meet the Packaging Guidelines
[ X ] MUST: The package must be licensed with a Fedora approved license
and meet the Licensing Guidelines
[ X ] MUST: The License field in the package spec file must match the
actual license
[ X ] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of
the license(s) for the package must be included in %doc
[ X ] MUST: The spec file must be written in American English.
[ X ] MUST: The spec file for the package MUST be legible.
[ X ] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL.
(sha256sum)
ecc09d09ad329f2e24c9381983a56de3c944e3a933183ca342d25d5917f34968
clamz-0.4.tar.gz
[ X ] MUST: The package MUST successfully compile and build into binary
rpms on at least one primary architecture (x86_64)
[N/A] MUST: If the package does not successfully compile, build or work on
an architecture, then those architectures should be listed in the
spec in ExcludeArch.
[ X ] MUST: All build dependencies must be listed in BuildRequires
[N/A] MUST: The spec file MUST handle locales properly.
[N/A] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review.
[ - ] MUST: A package must own all directories that it creates. If it does
not create a directory that it uses, then it should require a package
which does create that directory.
$ rpm -qf /usr/share/mime/packages
shared-mime-info-0.71-1.fc13.x86_64
It seems that according to the Guidelines, we need to add Require:
shared-mime-info
[ X ] MUST: A package must not contain any duplicate files in the %files
listing.
[ X ] MUST: Permissions on files must be set properly.
[ X ] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot}
[ X ] MUST: Each package must consistently use macros.
[ X ] MUST: The package must contain code, or permissable content.
[N/A] MUST: Large documentation files must go in a -doc subpackage.
[ X ] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[N/A] MUST: Header files must be in a -devel package.
[N/A] MUST: Static libraries must be in a -static package.
[N/A] MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'
[N/A] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix)
must go in a -devel package.
[N/A] MUST: In the vast majority of cases, devel packages must require the
base package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
[N/A] MUST: Packages must NOT contain any .la libtool archives, these must
be removed in the spec if they are built.
[ X ] MUST: Packages containing GUI applications must include a
%{name}.desktop file, and that file must be properly installed with
desktop-file-install in the %install section.
[ X ] MUST: Packages must not own files or directories already owned by
other packages.
[ X ] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot}
[ X ] MUST: All filenames in rpm packages must be valid UTF-8.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591222] gtk3 - version 3 of GTK+
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=591222
Bastien Nocera bnoc...@redhat.com changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #11 from Bastien Nocera bnoc...@redhat.com 2010-05-21 13:04:42
EDT ---
$ rpmlint /home/hadess/Projects/packages/SRPMS/gtk3-2.90.0-4.fc13.src.rpm
gtk3.src: W: spelling-error %description -l en_US multi - mulch, mufti
gtk3.src: W: strange-permission update-gdk-pixbuf-loaders-3.0 0755L
gtk3.src: W: strange-permission update-gtk-immodules-3.0 0755L
gtk3.src:286: W: macro-in-comment %{_mandir}
gtk3.src:287: W: macro-in-comment %{_mandir}
gtk3.src:288: W: macro-in-comment %{_mandir}
gtk3.src:325: W: macro-in-comment %{_mandir}
gtk3.src:326: W: macro-in-comment %{_mandir}
gtk3.src: W: no-cleaning-of-buildroot %clean
gtk3.src: W: no-buildroot-tag
gtk3.src: W: no-%clean-section
gtk3.src:123: W: mixed-use-of-spaces-and-tabs (spaces: line 123, tab: line 123)
1 packages and 0 specfiles checked; 0 errors, 12 warnings.
Apart from the tabs/spaces mix, this is all fine.
$ rpmlint gtk3*rpm
gtk3.x86_64: W: spelling-error %description -l en_US multi - mulch, mufti
gtk3.x86_64: W: incoherent-version-in-changelog 2.9.0.0-4 ['2.90.0-4.fc14',
'2.90.0-4']
gtk3.x86_64: W: shared-lib-calls-exit /usr/lib64/libgdk-x11-3.0.so.0.9000.0
e...@glibc_2.2.5
gtk3.x86_64: W: shared-lib-calls-exit
/usr/lib64/libgdk_pixbuf_xlib-3.0.so.0.9000.0 e...@glibc_2.2.5
gtk3.x86_64: W: shared-lib-calls-exit /usr/lib64/libgtk-x11-3.0.so.0.9000.0
e...@glibc_2.2.5
gtk3.x86_64: W: no-manual-page-for-binary gtk-query-immodules-3.0-64
gtk3.x86_64: W: no-manual-page-for-binary update-gtk-immodules-3.0
gtk3.x86_64: W: no-manual-page-for-binary gtk-update-icon-cache-3.0
gtk3.x86_64: W: no-manual-page-for-binary update-gdk-pixbuf-loaders-3.0
gtk3.x86_64: W: no-manual-page-for-binary gdk-pixbuf-query-loaders-3.0-64
gtk3-devel.x86_64: W: spelling-error %description -l en_US amd - mad, and, am
gtk3-devel.x86_64: W: no-documentation
gtk3-devel.x86_64: W: no-manual-page-for-binary gdk-pixbuf-csource-3.0
gtk3-devel.x86_64: W: no-manual-page-for-binary gtk3-demo
gtk3-devel.x86_64: W: no-manual-page-for-binary gtk-builder-convert-3.0
gtk3-devel-docs.x86_64: W: file-not-utf8
/usr/share/doc/gtk3-devel-docs-2.90.0/examples/calendar/calendar.c
gtk3-immodules.x86_64: W: spelling-error %description -l en_US gtk - gt, gt k,
GTE
gtk3-immodules.x86_64: W: non-coherent-filename
getfile?taskID=2201277name=gtk3-immodules-2.90.0-4.fc14.x86_64.rpm
gtk3-immodules-2.90.0-4.fc14.x86_64.rpm
gtk3-immodules.x86_64: W: no-documentation
gtk3-immodules.x86_64: W: non-conffile-in-etc
/etc/X11/xinit/xinput.d/im-cedilla.conf
gtk3-immodule-xim.x86_64: W: spelling-error %description -l en_US gtk - gt, gt
k, GTE
gtk3-immodule-xim.x86_64: W: no-documentation
The typo is real, and calendar.c should be fixed as well (probably upstream).
package name: ok
spec file name: ok
packaging guidelines: see above
license: ok
license field: ok
license file: ok
spec file language: ok
spec file legibility: ok
Do this upstream?
# fight unused direct deps
sed -i -e 's/ -shared / -Wl,-O1,--as-needed\0/g' libtool
# truncate NEWS
awk '/^Overview of Changes/ { seen+=1 }
{ if (seen 2) print }
{ if (seen == 2) { print For older news, see
http://git.gnome.org/cgit/gtk+/plain/NEWS;; exit } }' NEWS tmp; mv tmp NEWS
#
# Make cleaned-up versions of tutorials, examples, and faq for installation
#
mkdir -p tmpdocs
cp -aR docs/tutorial/html tmpdocs/tutorial
cp -aR docs/faq/html tmpdocs/faq
for dir in examples/* ; do
if [ -d $dir ] ; then
mkdir -p tmpdocs/$dir
for file in $dir/* ; do
install -m 0644 $file tmpdocs/$dir
done
fi
done
Use install -D
# Input method frameworks want this
mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d
cp %{SOURCE3} $RPM_BUILD_ROOT%{_sysconfdir}/X11/xinit/xinput.d
upstream sources: nak
buildable: yes, runs fine in scratch
excludearch: n/a
build deps: ok
locale handling: ok
ldconfig: ok
relocatable: n/a
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
content: permissible
documentation: ok
headers: ok
static libs: ok
pkgconfig files: ok
shared libraries: ok
devel package: ok
libtool archives: ok
gui apps: n/a
file ownership: ok
%install: ok
utf8 filenames: ok
Looks fine apart from the items mentioned above, and some upstream TODO items
mentioned in the spec file.
Feel free to ask for CVS when those items are fixed.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
[Bug 592772] Review Request: drobo-utils - Utilities for managing Drobo storage systems
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592772 --- Comment #2 from Jameson imntr...@gmail.com 2010-05-21 13:10:40 EDT --- rpmlint is quiet except for a spelling warning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563844] Review Request: zim - A Desktop Wiki Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563844 --- Comment #46 from Chen Lei supercyp...@gmail.com 2010-05-21 13:19:21 EDT --- (In reply to comment #45) I'm sorry this has languished so long. ;( I have mailed Chris again. If I don't hear anything back from him by next week, we will just move forward without him. Has anyone bothered to test/reply to Tibbs concern in comment #40? If there is a tooling issue there, it may be better to just keep using the 'Zim' name/package and just change maintainers to allow you to push the python one out. There seems some packages diff only in case is sucessfully fedora renamed . See http://koji.fedoraproject.org/koji/search?match=globtype=packageterms=*AppTools* http://cvs.fedoraproject.org/viewvc/rpms/python-Apptools was completely removed in cvs. I think cvadmin may need remove Zim in cvs completely before creating new zim branch. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594756] Review Request: apache-commons-beanutils - rename of jakarta-commons-beanutils
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=594756
Alexander Kurtakov akurt...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #3 from Alexander Kurtakov akurt...@redhat.com 2010-05-21
13:21:33 EDT ---
Review:
OK: rpmlint must be run on every package. Output:
apache-commons-beanutils-javadoc.noarch: W: obsolete-not-provided
jakarta-commons-beanutils-javadoc
apache-commons-beanutils.noarch: W: non-conffile-in-etc
/etc/maven/fragments/apache-commons-beanutils
Not a problem.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of
the application.
OK: Packages must not own files or directories already owned by other packages.
OK: All filenames in rpm packages must be valid UTF-8.
OK: I'm aware this is a rename and obsoletes/provides are good.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594756] Review Request: apache-commons-beanutils - rename of jakarta-commons-beanutils
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=594756 --- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2010-05-21 13:22:48 EDT --- This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577974] Review Request: glite-security-trustmanager - Java trustmanager interface supporting a GSI grid name space
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=577974
Mattias Ellert mattias.ell...@fysast.uu.se changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|mattias.ell...@fysast.uu.se
Flag||fedora-review?
--- Comment #2 from Mattias Ellert mattias.ell...@fysast.uu.se 2010-05-21
13:26:53 EDT ---
Fedora review glite-security-trustmanager 2010-05-21
rpmlint output:
$ rpmlint ~/rpmbuild/RPMS/*/glite-security-trustmanager-*
../glite-security-trustmanager-2.5.5-1.fc12.src.rpm
glite-security-trustmanager-javadoc.noarch: W: spelling-error Summary(en_US)
javadocs - java docs, java-docs, Javanese
glite-security-trustmanager-tomcat5.noarch: W: spelling-error %description -l
en_US util - til, until, u til
glite-security-trustmanager-tomcat5.noarch: W: spelling-error %description -l
en_US nescesary - necessary, necessarily, Nescafe
glite-security-trustmanager-tomcat5.noarch: W: log-files-without-logrotate
/var/log/glite-security-trustmanager
glite-security-trustmanager.x86_64: W: spelling-error %description -l en_US
util - til, until, u til
glite-security-trustmanager.src: W: spelling-error %description -l en_US util
- til, until, u til
glite-security-trustmanager.src:170: W: libdir-macro-in-noarch-package (main
package) %attr(-,root,root) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.*
glite-security-trustmanager.src: W: invalid-url Source0:
glite-security-trustmanager-2.5.5.tar.gz
5 packages and 0 specfiles checked; 0 errors, 8 warnings.
The spelling error nescesary → necessary should be fixed, otherwise OK.
+ Java package with a single jarfile → package name equals name of jar
+ Specfile is named after package
+ License ASL 2.0 is a Fedora approved license
+ The license tag in the spec file corresponds to the license of the sources
+ License file is included in %doc
+ Specfile is written in legible English
+ Sources matches upstream
+ Package compiles successfully (Fedora 13)
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=2201657
+ BuildRequires are sane
+ No bundled libraries
- Package should own the directory /usr/lib64/gcj/glite-security-trustmanager
+ No duplicate files
? Permissions are sane and %files has %defattr
Marking the gcj aot files with %attr(-,root,root) seems redundant though,
since this is covered by the %defattr
+ Specfile uses macros consistently
+ %doc is not runtime essential
+ Package does not own others directories
The /etc/grid-security directory is owned by many packages, but there is
no master package on which all the others depend on, so this is fine
? Do you need vomsjapi in the list of java libraries that get put in
the tomcat server lib repository in the %post scriptlet?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582106] Review Request: lifeograph - Private digital diary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582106 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(graja...@redhat.c ||om) --- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:40:05 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567678] Review Request: Cameramonitor - Notification icon when webcam is active
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567678 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(ading...@redhat.c ||om) --- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:44:29 EDT --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563844] Review Request: zim - A Desktop Wiki Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563844 --- Comment #45 from Kevin Fenzi ke...@tummy.com 2010-05-21 12:40:35 EDT --- I'm sorry this has languished so long. ;( I have mailed Chris again. If I don't hear anything back from him by next week, we will just move forward without him. Has anyone bothered to test/reply to Tibbs concern in comment #40? If there is a tooling issue there, it may be better to just keep using the 'Zim' name/package and just change maintainers to allow you to push the python one out. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593274] Review Request: rubygem-will_paginate - Most awesome pagination solution for Rails
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593274 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:36:16 EDT --- Closing (as this package is built on Fedora branches and updates were submitted) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594806] New: Review Request: jbcrypt - Strong password hashing for Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: jbcrypt - Strong password hashing for Java https://bugzilla.redhat.com/show_bug.cgi?id=594806 Summary: Review Request: jbcrypt - Strong password hashing for Java Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: sebast...@when.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://sdz.fedorapeople.org/etherpad/jbcrypt.spec SRPM URL: http://sdz.fedorapeople.org/etherpad/jbcrypt-0.3-1.fc12.src.rpm Description: This package is needed for the effort of packaging Etherpad. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588437] Review Request: rubygem-fakefs - A fake filesystem for Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588437 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||needinfo?(ayo...@redhat.com ||) --- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 12:43:44 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 563844] Review Request: zim - A Desktop Wiki Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=563844 --- Comment #47 from Robin Lee robinlee.s...@gmail.com 2010-05-21 13:55:36 EDT --- I think 'zim' will be the unique acceptable name for this new implementation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555990] Review Request: rubygems-acts-as-list - Sorting and reordering capabilities for ActiveRecord model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555990 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-21 14:01:20 EDT --- This package seems almost okay. Well, * Documents - I think test/ tasks/ directories should also be marked as %doc. * activerecord dependendency [tasa...@localhost ~]$ irb irb(main):001:0 require rubygems = true irb(main):002:0 require acts_as_list NameError: uninitialized constant ActiveRecord from /usr/lib/ruby/gems/1.8/gems/acts-as-list-0.1.2/lib/acts_as_list.rb:254 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `gem_original_require' from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require' from (irb):2 from /usr/lib/ruby/site_ruby/1.8/rubygems/exceptions.rb:91 - I think lib/acts_as_list.rb should explicitly have 'require active_record'. How do you think? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594839] New: Review Request: kpartsplugin - KParts technology to embed file viewers into non-KDE browsers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: kpartsplugin - KParts technology to embed file viewers into non-KDE browsers https://bugzilla.redhat.com/show_bug.cgi?id=594839 Summary: Review Request: kpartsplugin - KParts technology to embed file viewers into non-KDE browsers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: thom...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://thomasj.fedorapeople.org/reviews/kpartsplugin.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/kpartsplugin-0.0.1-0.1.20100521.fc12.src.rpm Description: This software implements a plug-in for Netscape-compatible browsers in a Unix environment. This plug-in uses KDE's KParts technology to embed file viewers (e.g. for PDF files) into non-KDE browsers. Tested browsers include both Mozilla Firefox and Opera. With this plug-in, you can e.g. view PDF files in Firefox using Okular as an embedded plug-in. ScratchBuild: http://koji.fedoraproject.org/koji/taskinfo?taskID=2201898 rpmlint kpartsplugin.spec ../SRPMS/kpartsplugin-0.0.1-0.1.20100521.fc12.src.rpm ../RPMS/x86_64/kpartsplugin-* kpartsplugin.src: W: spelling-error Summary(en_US) KParts - K Parts, KP arts, KP-arts kpartsplugin.x86_64: W: spelling-error Summary(en_US) KParts - K Parts, KP arts, KP-arts 3 packages and 1 specfiles checked; 0 errors, 2 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 555990] Review Request: rubygems-acts-as-list - Sorting and reordering capabilities for ActiveRecord model
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=555990 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 594844] New: Review Request: iec16022 - Generate ISO/IEC 16022 2D barcodes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: iec16022 - Generate ISO/IEC 16022 2D barcodes https://bugzilla.redhat.com/show_bug.cgi?id=594844 Summary: Review Request: iec16022 - Generate ISO/IEC 16022 2D barcodes Product: Fedora Version: 12 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: talj...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/iec16022/iec16022-0.2.4-3.fc12.src.rpm Description: iec16022 is a program for producing ISO/IEC 16022 2D barcodes, also known as Data Matrix. These barcodes are defined in the ISO/IEC 16022 standard. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-05-21 14:58:27 EDT --- kanjistrokeorders-fonts-2.014-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/kanjistrokeorders-fonts-2.014-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 579369] Review Request: kanjistrokeorders-fonts - Font to view stroke order diagrams for Kanji, Kana and etc...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=579369 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-05-21 14:58:32 EDT --- kanjistrokeorders-fonts-2.014-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kanjistrokeorders-fonts-2.014-4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 587438] Review Request: rubygem-snmp - A Ruby implementation of SNMP (the Simple Network Management Protocol)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=587438 Michael Stahnke mastah...@gmail.com changed: What|Removed |Added Flag|needinfo?(mastah...@gmail.c | |om) | --- Comment #4 from Michael Stahnke mastah...@gmail.com 2010-05-21 15:07:52 EDT --- http://stahnma.fedorapeople.org/reviews/rubygem-snmp-1.0.2-2.fc12.src.rpm http://stahnma.fedorapeople.org/reviews/rubygem-snmp.spec I think I took care of each issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 485652] Review Request: navit - Car navigation system with routing engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485652 --- Comment #64 from Adam Williamson awill...@redhat.com 2010-05-21 16:02:49 EDT --- Indeed. Sorry for the late follow-up, I've been busy with F13. http://adamwill.fedorapeople.org/navit/navit.spec http://adamwill.fedorapeople.org/navit/navit-0.1.2-0.3.20100521svn3291.aw_fc12.src.rpm new build. Current SVN, with fixes for the identified problems with system-wide resources: as mentioned on the upstream ticket, it now uses system shapelib, and mdbtools usage has been removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 473184] Review Request: clamz - Amazon Downloader
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473184 --- Comment #25 from Jim Radford radf...@blackbean.org 2010-05-21 17:14:07 EDT --- Great, thanks. shared-mime-info is also required for %post and %postun. Spec URL: http://blackbean.org/review/clamz.spec SRPM URL: http://blackbean.org/review/clamz-0.4-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 528288] Review Request: python-blist - A faster list implementation for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528288 --- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:22:47 EDT --- python-blist-1.1.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-blist-1.1.1-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593879] Review Request: libvpx - VP8 Video Codec SDK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593879 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:35:06 EDT --- libvpx-0.9.0-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libvpx-0.9.0-5.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593879] Review Request: libvpx - VP8 Video Codec SDK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593879 --- Comment #17 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:35:01 EDT --- libvpx-0.9.0-5.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libvpx-0.9.0-5.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566560 --- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:36:51 EDT --- libaesgm-20090429-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libaesgm-20090429-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566560 --- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:37:03 EDT --- libaesgm-20090429-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libaesgm-20090429-2.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566560] Review Request: libaesgm - Library implementation of AES (Rijndael) cryptographic methods
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566560 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:37:08 EDT --- libaesgm-20090429-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libaesgm-20090429-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593879] Review Request: libvpx - VP8 Video Codec SDK
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593879 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-05-21 17:35:11 EDT --- libvpx-0.9.0-5.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libvpx-0.9.0-5.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592579] Review Request: Frama-c - Framework for source code analysis of C software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592579 --- Comment #3 from David A. Wheeler dwhee...@dwheeler.com 2010-05-21 18:27:06 EDT --- My first step in reviewing the package was reviewing the rpmlint errors from the spec file and the 2 generated binary RPMs, which on my system produced 2 errors and 5 warnings. I'd *really* like input from an OCaml expert (PSST: RICHARD JONES!) for the unstripped-binary-or-object messages, esp. for /usr/lib/frama-c/plugins/Ltl_to_acsl.cmxs. Ignoring that warning is easy enough, but *should* it be ignored? With that, here are some initial comments: * frama-c.i586: E: devel-dependency gtksourceview-devel You need to fix some Requires: lines in the .spec file. In particular, the problem is that you've specifically included as Requires statements some -devel libraries as Requires. You should *not* make Requires statements unless you have to; rpm will figure them out, and will typically do a better job anyway. The *big* case where you need requires statements is if you need to state that specific version (minimums) are required. So, please change the spec as follows, which improves the spec and gets rid of this rpmlint error: Requires: graphviz = 2.0.0 -Requires: gtksourceview = 1.0.0, gtksourceview-devel -Requires: ocaml = 3.11.0, ocaml-findlib-devel, ocaml-lablgtk-devel, ocaml-ocamlgraph-devel +Requires: gtksourceview = 1.0.0 +Requires: ocaml = 3.11.0 * frama-c.i586: W: invalid-license QPL with modifications * frama-c-devel.i586: W: invalid-license QPL with modifications The term QPL with modifications is not one of the valid licenses known to rpmlint. I looked into what's going on, and I think this software license is clearly FLOSS, as I describe below. However, you're going to have to get legal to approve it, as described in: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines The License: field must be filled with the appropriate license Short License identifier(s) from the Good License tables on the Fedora Licensing page. If your license does not appear in the tables, it needs to be sent to fedora-legal-l...@redhat.com (note that this list is moderated, only members may directly post). If the license is approved, it will be added to the appropriate table. They'll also need to approve some sort of short name, since QPL with modifications is not on the approved list. I'm not a lawyer, but I *did* look at this, and here's what I learned in the hope that it helps. At issue seems to be this license: ~/rpmbuild/BUILD/frama-c-Beryllium-20090902/licenses/Q_MODIFIED_LICENSE It's QPL version 1.0, an already-approved FLOSS license, with some modifications. I only found 2 modifications: 1. An *additional* permission. If you DON'T release to your program to the general public, you don't have to comply with QPL requirement 6c. (You must ensure that all modifications included in the machine-executable forms are available under the terms of this license.) I don't see how giving ADDITIONAL permissions makes a FLOSS license non-FLOSS. 2. A choice of venue (This license is governed by the Laws of France.) I'm not crazy about choice-of-venue clauses, but other FLOSS licenses have them (e.g., CeCILL), so that cannot make it non-FLOSS. Here's the actual text from the license that shows these modifications: == In the following, the Library refers to the following file: standard.mly and the Generator refers to all files marked Copyright INRIA in the root directory. The Generator is distributed under the terms of the Q Public License version 1.0 with a change to choice of law (included below). The Library is distributed under the terms of the GNU Library General Public License version 2 (included below). As a special exception to the Q Public Licence, you may develop application programs, reusable components and other software items that link with the original or modified versions of the Generator and are not made available to the general public, without any of the additional requirements listed in clause 6c of the Q Public licence. As a special exception to the GNU Library General Public License, you may link, statically or dynamically, a work that uses the Library with a publicly distributed version of the Library to produce an executable file containing portions of the Library, and distribute that executable file under terms of your choice, without any of the additional requirements listed in clause 6 of the GNU Library General Public License. By a publicly distributed version of the Library, we mean either the unmodified Library as distributed by INRIA, or a modified version of the Library that is distributed under the conditions defined in clause 3 of the GNU Library General Public License. This exception does not however invalidate any other
[Bug 592645] Review Request: mkgmap - Convert OpenStreetMap data for Garmin GPSes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592645 --- Comment #1 from Bruce Cowan b...@bcowan.me.uk 2010-05-21 18:37:36 EDT --- Builds on koji http://koji.fedoraproject.org/koji/taskinfo?taskID=2201997 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 577951] Review Request: mingw32-wine-gecko - MinGW Gecko library required for Wine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=577951 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added CC||or...@cora.nwra.com --- Comment #6 from Orion Poplawski or...@cora.nwra.com 2010-05-21 18:42:43 EDT --- I'm seeing a build failure on F-13 now, though F-14 (rawhide) seem okay. http://koji.fedoraproject.org/koji/taskinfo?taskID=2202453 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593839] Review Request: python-urwid - Console user interface library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593839 --- Comment #16 from David Cantrell dcantr...@redhat.com 2010-05-21 18:54:30 EDT --- I have updated the spec file and SRPM with the changes noted in comments 9 through 15. Here's a summary: 1) Discontinue the use of basic command macros. 2) Creation and inclusion of the examples/ in the %doc list. 3) Change to using the slightly different sed command to remove the #! line. One concern raised is whether or not python-urwid should require python-twisted-core or pygobject2. I cannot tell what the conclusion on that was, so I did not add either. My personal take on it that since the module wraps the import statements in try/except blocks, python-urwid should be fine. If users want the twisted functionality, they can install the python-twisted-core package. If anything dependent on python-urwid requires the twisted usage inside python-urwid, then that package can Require both python-urwid and python-twisted-core. New spec and SRPM: http://dcantrel.fedorapeople.org/python-urwid/python-urwid.spec http://dcantrel.fedorapeople.org/python-urwid/python-urwid-0.9.9.1-1.fc13.src.rpm Thanks for all the review feedback! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #8 from David Cantrell dcantr...@redhat.com 2010-05-21 19:19:19 EDT --- I have updated the spec file and SRPM addressing all of the issues in comments 6 and 7. One concernq: The wicd service cannot be running at the same time as NetworkManager. I am not sure how to best handle that, which is one reason I did not add in the scriptlets for the init scripts the first time. It is technically possible to have both NetworkManager and wicd installed at the same time, but you can only run one at a time. I imagine some people may want to have both installed and retain the ability to switch over to the other one without needing to uninstall one package and install another. The scriptlets for the wicd init script are fine, but I think if the package has that, it will need to also disable NetworkManager if installed or prevent the concurrent installation of both NetworkManager and wicd. Chen, I have no problems adding wicd to F-13 and EPEL-6. I will make sure to request those branches when the review is completed. I will add you as a maintainer for those branches too. New spec file and SRPM: http://dcantrel.fedorapeople.org/wicd/wicd.spec http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm Thanks for all the review feedback! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 560176] Review Request: clpbar - Show information about a data transfer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=560176 David Cantrell dcantr...@redhat.com changed: What|Removed |Added Flag||needinfo?(rpan...@redhat.co ||m) --- Comment #14 from David Cantrell dcantr...@redhat.com 2010-05-21 19:20:36 EDT --- Any updates on this review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592770] Review Request: texmakerx - LaTex Editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592770 --- Comment #6 from Rafael Aquini aqu...@linux.com 2010-05-21 19:34:32 EDT --- Johannes, As a best practice, you should change the release number of you package every time you modify the spec file in order to avoid confusion. Also, it would be nice if you could submit a new comment on this bug, with the URL for the new SRPM built on those Spec modifications. Regards -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593841
--- Comment #9 from Christoph Wickert cwick...@fedoraproject.org 2010-05-21
20:00:33 EDT ---
You are not to disable NetworkManager or even to turn on wicd by default, see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we
You are already making 3 packages. Why not make a 4th one for the pm-utils
scripts so that all the other stuff can be noarch as it should?
How about naming the base package wicd-common instead of just wicd? The common
indicated that it's not the full wicd package but just shared files between
other packages.
You should pass more options to configure, at least --distro=redhat. I think
other options like --share or --lib should be passed as well, then somebody can
build the package with rpmbuild --rebuild --define=_datadir /foo/shared.
Please don't specify the extension of manpages. Imagine we switch from gz to
bz2.
The files in %{_datadir}/man/nl must be tagged with %lang(nl)
The package must not own %{_datadir}/icons/hicolor and folders below. It only
should own the icons. For directory ownership you can require
hicolor-icon-theme, but this is not needed as it is already required by gtk2
(through pygtk2)
%dir %{_datadir}/wicd/curses
%{_datadir}/wicd/curses/*
is the same as
%{_datadir}/wicd/
Using %dir here only makes sense if you want to exclude certain files (because
they should go into another package).
%{_sysconfdir}/xdg/autostart/wicd-tray.desktop is not a config file. Changes
are made in the private ~/.config/autostart namespace.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593841
--- Comment #10 from leigh scott leigh123li...@googlemail.com 2010-05-21
20:35:16 EDT ---
There is a problem here, it can't own this directory as it belongs to
hicolor-icon-theme (the others listed are due to bad packaging)
%dir %{_datadir}/icons/hicolor
[le...@localhost Desktop]$ rpm -qf /usr/share/icons/hicolor
hicolor-icon-theme-0.12-1.fc13.noarch
krb5-auth-dialog-0.15-1.fc13.x86_64
fedora-logos-13.0.2-1.fc13.noarch
setroubleshoot-2.2.83-1.fc13.x86_64
[le...@localhost Desktop]$
Change it from
%files gtk
%defattr(-,root,root,-)
%dir %{_datadir}/wicd/gtk
%dir %{_datadir}/pixmaps/wicd
%dir %{_datadir}/icons/hicolor
%config(noreplace) %{_sysconfdir}/xdg/autostart/wicd-tray.desktop
%{_datadir}/wicd/gtk/*
%{_datadir}/pixmaps/wicd/*
%{_datadir}/pixmaps/wicd-gtk.xpm
%{_bindir}/wicd-gtk
%{_datadir}/icons/hicolor
to
%files gtk
%defattr(-,root,root,-)
%dir %{_datadir}/wicd/gtk
%dir %{_datadir}/pixmaps/wicd
%config(noreplace) %{_sysconfdir}/xdg/autostart/wicd-tray.desktop
%{_datadir}/wicd/gtk/*
%{_datadir}/pixmaps/wicd/*
%{_datadir}/pixmaps/wicd-gtk.xpm
%{_bindir}/wicd-gtk
%{_datadir}/icons/hicolor/*/apps/wicd-gtk.png
%{_datadir}/icons/hicolor/scalable/apps/wicd-gtk.svg
There are still some rpmlint errors that need correcting ( mainly shebangs )
wicd.src: W: spelling-error %description -l en_US cli - cl, clii, clip
wicd.src: W: spelling-error %description -l en_US frontend - fronted, front
end, front-end
wicd.x86_64: E: explicit-lib-dependency dbus-glib
wicd.x86_64: W: spelling-error %description -l en_US frontend - fronted, front
end, front-end
wicd.x86_64: E: no-binary
wicd.x86_64: E: executable-marked-as-config-file
/etc/acpi/suspend.d/50-wicd-suspend.sh
wicd.x86_64: E: non-executable-script /usr/share/wicd/cli/wicd-cli.py 0644L
/usr/bin/python
wicd.x86_64: E: non-executable-script /usr/share/wicd/daemon/wicd-daemon.py
0644L /usr/bin/env
wicd.x86_64: E: non-executable-script /usr/share/wicd/backends/be-external.py
0644L /usr/bin/env
wicd.x86_64: E: non-executable-script /usr/share/wicd/backends/be-ioctl.py
0644L /usr/bin/env
wicd.x86_64: E: non-executable-script
/usr/lib/python2.6/site-packages/wicd/logfile.py 0644L /usr/bin/python
wicd.x86_64: E: wrong-script-end-of-line-encoding
/usr/lib/python2.6/site-packages/wicd/logfile.py
wicd.x86_64: E: executable-marked-as-config-file
/etc/acpi/resume.d/80-wicd-connect.sh
wicd.x86_64: W: log-files-without-logrotate /var/log/wicd
wicd-curses.x86_64: E: non-executable-script
/usr/share/wicd/curses/curses_misc.py 0644L /usr/bin/env
wicd-curses.x86_64: E: non-executable-script
/usr/share/wicd/curses/netentry_curses.py 0644L /usr/bin/env
wicd-curses.x86_64: E: non-executable-script
/usr/share/wicd/curses/prefs_curses.py 0644L /usr/bin/env
wicd-gtk.x86_64: W: no-documentation
wicd-gtk.x86_64: E: non-executable-script /usr/share/wicd/gtk/gui.py 0644L
/usr/bin/python
wicd-gtk.x86_64: E: non-executable-script /usr/share/wicd/gtk/prefs.py 0644L
/usr/bin/python
wicd-gtk.x86_64: E: non-executable-script /usr/share/wicd/gtk/wicd-client.py
0644L /usr/bin/env
4 packages and 0 specfiles checked; 16 errors, 5 warnings.
As for the networkmanager issue, would this work?
%post
if [ $1 -eq 1 ]; then
/sbin/chkconfig --add wicd
/sbin/chkconfig --level 2345 wicd on
/sbin/chkconfig --level 2345 NetworkManager off
/sbin/service NetworkManager stop /dev/null 21
fi
%preun
if [ $1 -eq 0 ]; then
/sbin/service wicd stop /dev/null 21
/sbin/chkconfig --del wicd
/sbin/chkconfig --level 2345 NetworkManager on
/sbin/service NetworkManager start /dev/null 21
fi
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #11 from leigh scott leigh123li...@googlemail.com 2010-05-21 20:39:49 EDT --- (In reply to comment #9) You are not to disable NetworkManager or even to turn on wicd by default, see https://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we I didn't know that, thanks for the info -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 565251] Review Request: coan - A commandline tool for simplifying the preprocessor conditionals in source code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=565251 --- Comment #8 from Eric Smith e...@brouhaha.com 2010-05-21 20:49:18 EDT --- Mike confirms that there is not actually anything in the coan package covered by the GPL. It's all BSD. Apparently the COPYING file in question shouldn't be there, and he's going to remove it. I'll update my spec and SRPM when he's got a new release ready. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=593841
--- Comment #12 from David Cantrell dcantr...@redhat.com 2010-05-21 20:47:07
EDT ---
(In reply to comment #9)
You are not to disable NetworkManager or even to turn on wicd by default, see
https://fedoraproject.org/wiki/Packaging/SysVInitScript#Why_don.27t_we
I've removed the line that did the chkconfig on for wicd.
You are already making 3 packages. Why not make a 4th one for the pm-utils
scripts so that all the other stuff can be noarch as it should?
How about naming the base package wicd-common instead of just wicd? The common
indicated that it's not the full wicd package but just shared files between
other packages.
Good idea. I have implemented what I think is a nice way to accomplish this
split in the packages. First, I do want to keep a package named 'wicd' because
that's what the software is called and I think at least one package should be
named wicd.
Second, having some noarch packages and some arch packages built from one spec
file becomes difficult to manage, so here's how I split things:
1) The 'wicd' package contains the architecture dependent parts of wicd, which
is limited to the pm-utils script right now. This could change as wicd gains
more functionality.
2) The 'wicd-common' package contains what was in the wicd package: the
daemon, command line client, lang files, and docs.
3) The 'wicd' and 'wicd-common' packages require each other, so you will always
need to have both installed. If we want to, I could drop the requirement from
wicd-common so that people could have wicd-common installed without the
arch-dependent wicd package.
This effectively splits things in to arch/noarch pieces and keeps a package
named 'wicd'.
You should pass more options to configure, at least --distro=redhat. I think
other options like --share or --lib should be passed as well, then somebody
can
build the package with rpmbuild --rebuild --define=_datadir /foo/shared.
Changed.
Please don't specify the extension of manpages. Imagine we switch from gz to
bz2.
Changed.
The files in %{_datadir}/man/nl must be tagged with %lang(nl)
Changed.
The package must not own %{_datadir}/icons/hicolor and folders below. It only
should own the icons. For directory ownership you can require
hicolor-icon-theme, but this is not needed as it is already required by gtk2
(through pygtk2)
Changed.
%dir %{_datadir}/wicd/curses
%{_datadir}/wicd/curses/*
is the same as
%{_datadir}/wicd/
Using %dir here only makes sense if you want to exclude certain files (because
they should go into another package).
Changed.
%{_sysconfdir}/xdg/autostart/wicd-tray.desktop is not a config file. Changes
are made in the private ~/.config/autostart namespace.
Changed.
New spec file and SRPM:
http://dcantrel.fedorapeople.org/wicd/wicd.spec
http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm
Thanks for all the review feedback!
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
