[Bug 597137] Review Request: perl-CPAN-Meta - Distribution metadata for a CPAN dist

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597137

--- Comment #2 from Iain Arnell iarn...@gmail.com 2010-05-29 01:58:17 EDT ---
New Package CVS Request
===
Package Name: perl-CPAN-Meta
Short Description: Distribution metadata for a CPAN dist
Owners: iarnell
Branches: F-12 F-13
InitialCC: perl-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597137] Review Request: perl-CPAN-Meta - Distribution metadata for a CPAN dist

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597137

Iain Arnell iarn...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 593800] Review Request: python-keyring - keyring module for python

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593800

--- Comment #9 from Rangeen Basu Roy Chowdhury sherry...@gmail.com 2010-05-29 
02:32:37 EDT ---
Please modify the ownership of the files. The package is architecture specific
as it has C and CPP files. Please take care of those while packaging.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 593800] Review Request: python-keyring - keyring module for python

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593800

--- Comment #10 from Ratnadeep Debnath rtn...@gmail.com 2010-05-29 02:37:06 
EDT ---
Update the spec and srpm file
Spec URL: http://rtnpro.fedorapeople.org/Packages/SPECS/python-keyring.spec
SRPM URL:
http://rtnpro.fedorapeople.org/Packages/SRPMS/python-keyring-0.2-1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 592864] Review Request: kmyfirewall - IPTables Based Firewall

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592864

Gowrishankar Rajaiyan graja...@redhat.com changed:

   What|Removed |Added

 CC||graja...@redhat.com

--- Comment #2 from Gowrishankar Rajaiyan graja...@redhat.com 2010-05-29 
02:40:52 EDT ---
Pre-review:

* Doesn't build, please fix the following:
checking for Qt... configure: error: Qt (= Qt 3.2 and  4.0) (library qt-mt)
not found. Please check your installation!
For more details about this problem, look at the end of config.log.

rpm -q qt
qt-4.6.2-17.fc12.x86_64
---


Once you fix the above please check the following too:

* Using %name / %version macro in SourceURL
  - Using %name / %version (especially %version) in SourceURL
is generally useful:
https://fedoraproject.org/wiki/Packaging/SourceURL#Using_.25.7Bversion.7D

* %{_datadir}/icons/hicolor
contains the directory %_datadir/icons/hicolor and all files/directories/etc
under this directory. 

* %{_datadir}/icons/Locolor
contains the directory %_datadir/icons/hicolor and all files/directories/etc
under this directory.

* If BuildArch: i686 only, then
 
http://fedoraproject.org/wiki/Packaging/Guidelines#Architecture_Build_Failures

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590329] Review Request: perl-MooseX-Traits - Automatically apply roles at object creation time

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590329

Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

--- Comment #5 from Chris Weyl cw...@alumni.drew.edu 2010-05-29 02:41:38 EDT 
---
Thanks for the review! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 582106] Review Request: lifeograph - Private digital diary.

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=582106

--- Comment #12 from Gowrishankar Rajaiyan graja...@redhat.com 2010-05-29 
02:48:12 EDT ---
Hi Mamoru,


As promised here is my first pre-review:
https://bugzilla.redhat.com/show_bug.cgi?id=592864#c2

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583102] Review Request: radiotray - Radio Tray is a streaming player for listening to online radios

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583102

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #11 from Ankur Sinha sanjay.an...@gmail.com 2010-05-29 03:08:43 
EDT ---
hey,

[an...@mether SPECS]$ rpmlint radiotray.spec
/var/lib/mock/fedora-rawhide-i386/result/*.rpm
radiotray.spec: W: invalid-url Source0:
http://downloads.sourceforge.net/radiotray/radiotray-0.5.1.tar.gz urlopen
error timed out
radiotray.noarch: W: no-manual-page-for-binary radiotray
radiotray.src: W: invalid-url Source0:
http://downloads.sourceforge.net/radiotray/radiotray-0.5.1.tar.gz urlopen
error timed out
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

Only one worth looking at is the second one. I'd suggest writing a man page for
the package. 

You could also try to make this work on python3. 

Apart from this, it looks good :)

XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583102] Review Request: radiotray - Radio Tray is a streaming player for listening to online radios

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583102

--- Comment #13 from Ankur Sinha sanjay.an...@gmail.com 2010-05-29 03:18:34 
EDT ---
hey,

[ankur@ SPECS]$ rpmlint radiotray.spec
/var/lib/mock/fedora-rawhide-i386/result/*.rpm
radiotray.spec: W: invalid-url Source0:
http://downloads.sourceforge.net/radiotray/radiotray-0.5.1.tar.gz urlopen
error timed out
radiotray.noarch: W: no-manual-page-for-binary radiotray
radiotray.src: W: invalid-url Source0:
http://downloads.sourceforge.net/radiotray/radiotray-0.5.1.tar.gz urlopen
error timed out
2 packages and 1 specfiles checked; 0 errors, 3 warnings.

I'd advise you to write up a small man page if you can. Also, have a look if
you can append python3 support to the spec.

Rest looks cool.

XXX APPROVED XXX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 584111] Review Request: cmatrix - Simulate the display from The Matrix

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=584111

--- Comment #14 from Ankur Sinha sanjay.an...@gmail.com 2010-05-29 03:24:06 
EDT ---
hey,

next step:

http://fedoraproject.org/w/index.php?title=PackageMaintainers/HowToGetSponsoredredirect=no

regards,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597484] Review Request: gFotoStat - A photograph statistics application

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597484

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

 CC||sanjay.an...@gmail.com
 Blocks||177841(FE-NEEDSPONSOR)
Summary|Review Request: gFotoStat |Review Request: gFotoStat -
   |- A photograph statistics  |A photograph statistics
   |application|application

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594943

Jussi Lehtola jussi.leht...@iki.fi changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi

--- Comment #26 from Jussi Lehtola jussi.leht...@iki.fi 2010-05-29 04:48:58 
EDT ---
Patch0 is missing a comment in the spec file. What does it do?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 592628] Review Request: key-mon - Utility to show live keyboard and mouse status

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592628

--- Comment #2 from Rahul Sundaram methe...@gmail.com 2010-05-29 04:51:39 EDT 
---

You can drop the following:
- python macro definition on top
- Buildroot definition
- no need to clean the buildroot in install section
- clean section

The su patch requires a comment as per

http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

You could run sed in a loop 

License status is unclear.  Source files don't have a proper license
attribution and does not specify the version.  LGPL also requires that you
include a copy of the license along with the source.  Please contact upstream
and ask them to fix these issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 578759] Review request: django-mako - Mako Templates Plugin for Django

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578759

Rakesh Pandit rpan...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag||fedora-cvs?

--- Comment #8 from Rakesh Pandit rpan...@redhat.com 2010-05-29 05:40:36 EDT 
---
New Package CVS Request
===
Package Name: django-mako
Short Description: Mako Templates Plugin for Django
Owners: rakesh
Branches: F-12 F-13 EL-6
InitialCC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597315] Review Request: bwa - Burrows-Wheeler Alignment tool

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597315

--- Comment #2 from Adam Huffman bl...@verdurin.com 2010-05-29 05:52:03 EDT 
---
I've addressed these problems in version 2 - thanks for taking a look so
quickly.

Spec URL: http://verdurin.org.uk/~verdurin/fedora/reviews/bwa/bwa.spec
SRPM URL:
http://verdurin.org.uk/~verdurin/fedora/reviews/bwa/bwa-0.5.7-2.fc12.src.rpm

rpmlint reports the following warning, which I think can be ignored:

bwa.src: W: spelling-error %description -l en_US bp - BP, b, p

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596746

--- Comment #5 from Terje Røsten terje...@phys.ntnu.no 2010-05-29 05:52:12 
EDT ---
Thanks.

I don't like abbreviation as GUI in summary, but it's up to you.

Desktop file don't have icon shipped, could you take e.g.

 https://launchpadlibrarian.net/28245614/bazaar-explorer-64.png

and put into /usr/share/pixmaps/ and adjust desktop file to use it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 597315] Review Request: bwa - Burrows-Wheeler Alignment tool

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597315

Chen Lei supercyp...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|supercyp...@gmail.com
   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Chen Lei supercyp...@gmail.com 2010-05-29 06:25:15 EDT ---
rpmlint bwa-*
bwa.x86_64: W: spelling-error %description -l en_US bp - BP, b, p
bwa.x86_64: W: no-manual-page-for-binary qualfa2fq.pl
bwa.x86_64: W: no-manual-page-for-binary solid2fastq.pl
2 packages and 0 specfiles checked; 0 errors, 3 warnings.


Those warings are all harmless, this package is approved .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596746

--- Comment #6 from Julian Aloofi julian.fed...@googlemail.com 2010-05-29 
06:31:11 EDT ---
The icon looks good, but I'll rather ask upstream first which icon they'd like
to see being used.

Regarding the description, it's in line with Debian and Ubuntu (and the desktop
file), but I also think Graphical may sound a bit better. I'll change this as
well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583869] Review Request: python-plwm - Modular X window manager for keyboard-loving programmers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583869

Bug 583869 depends on bug 583459, which changed state.

Bug 583459 Summary: Version String is set to 0.12 instead of 0.14
https://bugzilla.redhat.com/show_bug.cgi?id=583459

   What|Old Value   |New Value

 Status|ON_QA   |CLOSED
 Resolution||ERRATA

--- Comment #5 from Rangeen Basu Roy Chowdhury sherry...@gmail.com 2010-05-29 
06:27:24 EDT ---
Updated. the source.
http://sherry151.fedorapeople.org/python-plwm.spec
http://sherry151.fedorapeople.org/python-plwm-2.7-0.1.rc1.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583869] Review Request: plwm - Modular X window manager for keyboard-loving programmers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583869

Rangeen Basu Roy Chowdhury sherry...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: python-plwm |Review Request: plwm -
   |- Modular X window manager  |Modular X window manager
   |for keyboard-loving |for keyboard-loving
   |programmers |programmers

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 491090] Review Request: linux-firmware - firmware files for use with Linux kernel

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491090

Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||ERRATA

--- Comment #21 from Peter Lemenkov lemen...@gmail.com 2010-05-29 09:29:49 
EDT ---
I think we should close this ticket now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 546704] Review Request: python-whoosh - Fast, pure-Python full text indexing, search, and spell checking library

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546704

--- Comment #5 from Thomas Spura toms...@fedoraproject.org 2010-05-29 
09:50:46 EDT ---
Ping, are you still interessted in packaging this?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 546704] Review Request: python-whoosh - Fast, pure-Python full text indexing, search, and spell checking library

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546704

Allisson Azevedo allis...@gmail.com changed:

   What|Removed |Added

   Flag|needinfo?(allis...@gmail.co |
   |m)  |

--- Comment #6 from Allisson Azevedo allis...@gmail.com 2010-05-29 10:14:26 
EDT ---
Hi, i'll make a update soon.

And yes, i interessted in packaging this.

Regards,

Allisson.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597564] New: Review Request: main package name here - short summary here

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: main package name here - short summary here

https://bugzilla.redhat.com/show_bug.cgi?id=597564

   Summary: Review Request: main package name here - short
summary here
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: lbj...@broadpark.no
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: spec info here
SRPM URL: srpm info here
Description: description here

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597564] Review Request: main package name here - short summary here

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597564

Jason Tibbitts ti...@math.uh.edu changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG

--- Comment #1 from Jason Tibbitts ti...@math.uh.edu 2010-05-29 12:11:53 EDT 
---
There's nothing here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 592864] Review Request: kmyfirewall - IPTables Based Firewall

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592864

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 CC||mtas...@ioa.s.u-tokyo.ac.jp

--- Comment #3 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-29 
12:59:54 EDT ---
Well, this package builds at least on F-14 and F-13.
Some comments from me

- For sourceforge hosted packages, please check
  https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- Some BuildRequires are redundant. For example, zlib-devel always
  require zlib, so with BR: zlib-devel, BR: zlib is not needed.

  Also kdelibs3-devel requires qt3-devel, so BR: qt3-devel is redundant.

- For Fedora BuildRoot tag is no longer needed (EPEL build still
  needs this)
  https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- Please explain why you restrict BuildArch to i686. If build
  really fails on x86_64 please try to fix it.

- Currently Fedora specific compilation flags are not honored
  and generated debuginfo rpm is incomplete.
  Please make it sure that Fedora specific compilation flags are
  honored correctly.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

- There are some %files list mistakes on directory ownership issue.
  For example, the directory %{_datadir}/apps/%{name}/ itself
  is not owned by any packages.
  Please check the following wiki page and make it sure that all
  directories which are created newly by installing this pacakges
  are owned by this package:
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes

  ! Note
This package need not own the directory %{_datadir}/icons/ directories
or so themselves, so %files entry
--
%{_datadir}/icons/hicolor/16x16/apps/%{name}.png
%{_datadir}/icons/hicolor/22x22/apps/%{name}.png
.
--
are correct (however using wildcard will make this part more
readable)

- It seems that files under %{_datadir}/icons/Locolor should be moved
  to under {_datadir}/icons/locolor (the latter directory is owned by
  kde-filesystem)

- make clean in %clean stage is unneeded as the directory
  where tarball is expanded is anyway deleted.
  Also on Fedora 13 and above, writing %clean section is completely
  unneeded:
  https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

- Usually INSTALL file is for people trying to compile and install
  softwares by themselves and not needed for people using rpm (or
  other package manager)

- The rebuilt binary contains rpaths (you can check this by
  using rpmlint command (in rpmlint rpm). Please check your srpm /
  rebuilt binary rpms / installed rpm by rpmlint).
---
kmyfirewall.i686: E: binary-or-shlib-defines-rpath /usr/lib/libkmfcore.so.0.0.0
['/usr/lib', '/usr/lib/qt-3.3/lib']
kmyfirewall.i686: E: binary-or-shlib-defines-rpath
/usr/lib/kde3/libkmfruletargetoptionedit_tos.so ['/usr/lib',
'/usr/lib/qt-3.3/lib']
kmyfirewall.i686: E: binary-or-shlib-defines-rpath /usr/bin/kmyfirewall
['/usr/lib', '/usr/lib/qt-3.3/lib']
kmyfirewall.i686: E: binary-or-shlib-defines-rpath
/usr/lib/kde3/libkmfruleoptionedit_mac.so ['/usr/lib', '/usr/lib/qt-3.3/lib']
..
---
  And this type of rpaths are not allowed on Fedora. Please remove rpaths
  on these binaries:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath

  Note using chrpath binary for removing rpaths must be regarded
  as a last resort.

- Please explain why header files under %_includedir/%name are needed for
  runtime. These files are usually needed only for building software and
  are not needed for runtime.
  https://fedoraproject.org/wiki/Packaging/Guidelines#Devel_Packages

  Also %_libdir/libkmfwidgets.so is usually for development files and
  not needed for runtime.

- .la libtool files or .a static archives should be removed unless
  some reason exists:
 
https://fedoraproject.org/wiki/Packaging/Guidelines#Packaging_Static_Libraries

- Files under %_syscondir should usually be marked as %config(noreplace),
  ref:
  https://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files

- Please include some needed scriptlets
  - /sbin/ldconfig must be called for %_libdir/lib***.so.* :
https://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

  - GTK icon cache must be updated:
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

  - As the desktop under %_datadir/applications/kde contains Mimetype key,
desktop database must be updated:

[Bug 582106] Review Request: lifeograph - Private digital diary.

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=582106

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Blocks|177841(FE-NEEDSPONSOR)  |
   Flag|fedora-review?  |fedora-review+

--- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-29 
13:12:00 EDT ---
Well, I checked the above review request and actually the above
review has a lot of things to fix. I posted some comments on
the bug, please check those.

Anyway I will sponsor you.

-
This package (lifeograph) is APPROVED by mtasaka
-

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from Install the Client Tools (Koji).

Now I am sponsoring you.

If you want to import this package into Fedora 12/13, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Removing NEEDSPONSOR.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 546376] Review Request: ghc-chalmers-lava2000 - Haskell hardware description library

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546376

Shakthi Kannan shakthim...@gmail.com changed:

   What|Removed |Added

   Flag|needinfo?(shakthim...@gmail |
   |.com)   |

--- Comment #21 from Shakthi Kannan shakthim...@gmail.com 2010-05-29 14:02:10 
EDT ---
Thanks for the second patch. I have updated and tested the package. Looks good!

SPEC: http://shakthimaan.fedorapeople.org/SPECS/ghc-chalmers-lava2000.spec
SRPM:
http://shakthimaan.fedorapeople.org/SRPMS/ghc-chalmers-lava2000-1.1.1-5.fc12.src.rpm

Successful Koji builds for F-13, F-14 respectively:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2217429
http://koji.fedoraproject.org/koji/taskinfo?taskID=2217430

$ rpmlint ghc-chalmers-lava2000.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../SRPMS/ghc-chalmers-lava2000-1.1.1-5.fc12.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint ../RPMS/i686/ghc-chalmers-lava2000-1.1.1-5.fc12.i686.rpm 
ghc-chalmers-lava2000.i686: W: unstripped-binary-or-object
/usr/lib/ghc-6.12.2/chalmers-lava2000-1.1.1/libHSchalmers-lava2000-1.1.1-ghc6.12.2.so
ghc-chalmers-lava2000.i686: W: executable-stack
/usr/lib/ghc-6.12.2/chalmers-lava2000-1.1.1/libHSchalmers-lava2000-1.1.1-ghc6.12.2.so
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597596] New: Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

https://bugzilla.redhat.com/show_bug.cgi?id=597596

   Summary: Review Request: alsa-patch-bay - Simple GUI for ALSA
sequencers
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mostawesomed...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://people.freedesktop.org/~csimpson/alsa-patch-bay.spec
SRPM URL:
http://people.freedesktop.org/~csimpson/alsa-patch-bay-1.0.0-1.fc12.src.rpm
Description: alsa-patch-bay is a simple, plain GUI tool for patching together
ALSA sequencers.

I found this tool during the Planet CCRMA days and fell in love with it, but it
hasn't been maintained. I've got a github
(http://github.com/MostAwesomeDude/alsa-patch-bay) with all the patches, and
I'm waiting for upstream to get back to me on this.

My SPEC file is probably pretty iffy; I am very new to RPM as opposed to DEB,
and auto-br-rpmbuild appears to have been a bit too eager in picking deps.
Additionally, this package can be built against GTKMM and JACK in a
mix'n'match; I should depend on (GTKMM || FLTK)  (ALSA || JACK) instead of
what I've got now.

Thanks!

~ C.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597597] New: Review Request: liblouis - A Braille translator and back-translator.

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: liblouis - A Braille translator and back-translator.

https://bugzilla.redhat.com/show_bug.cgi?id=597597

   Summary: Review Request: liblouis - A Braille translator and
back-translator.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: lbj...@broadpark.no
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://lamasti.net/filer/liblouis.spec
SRPM URL: http://lamasti.net/filer/liblouis-1.8.0-1.fc12.src.rpm
Description: Liblouis is an open-source braille translator and
back-translator based on the translation routines in the BRLTTY
screenreader for Linux. It has, however, gonefar beyond these
routines. It is named in honor of Louis Braille. In Linux and Mac OSX
it is a shared library, and in Windows it is a DLL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597596] Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597596

Corbin Simpson mostawesomed...@gmail.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

--- Comment #1 from Corbin Simpson mostawesomed...@gmail.com 2010-05-29 
14:07:29 EDT ---
I should add that this is my first package review request in Fedora, and that I
am looking for a sponsor, per
https://fedoraproject.org/wiki/PackageMaintainers/Join .

~ C.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597597] Review Request: liblouis - A Braille translator and back-translator. FE-NEEDSPONSOR

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597597

Lars Bjorndal lbj...@broadpark.no changed:

   What|Removed |Added

Summary|Review Request: liblouis -  |Review Request: liblouis -
   |A Braille translator and|A Braille translator and
   |back-translator.|back-translator.
   ||FE-NEEDSPONSOR

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596746

Alexander Belchenko alexander.belche...@gmail.com changed:

   What|Removed |Added

 CC||alexander.belche...@gmail.c
   ||om

--- Comment #7 from Alexander Belchenko alexander.belche...@gmail.com 
2010-05-29 14:39:15 EDT ---
Hi, I'm one the of maintainers of Bazaar Explorer.

I'm not quite sure about extended in the following line:
Functionality of this package can be extended by installing bzr-gtk.

Actually Bazaar Explorer is front-end application which can use either QBzr or
bzr-gtk for executing specific actions. In the same time QBzr is strongly
required to run Bazaar Explorer, because Explorer using some code from QBzr. In
the same time QBzr dialogs used in Explorer (I think by default).

So maybe it will be better to say that user can use bzr-gtk if he/she want
different action dialogs.

Feel free to ask if you need additional clarifications.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580447] Review Request: perl-Module-Build - Build and install Perl modules

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580447

--- Comment #4 from Chris Weyl cw...@alumni.drew.edu 2010-05-29 15:09:12 EDT 
---
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2217469

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580447] Review Request: perl-Module-Build - Build and install Perl modules

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580447

Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|cw...@alumni.drew.edu

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580447] Review Request: perl-Module-Build - Build and install Perl modules

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580447

Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597596] Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597596

--- Comment #2 from Corbin Simpson mostawesomed...@gmail.com 2010-05-29 
16:38:31 EDT ---
I read more docs and did some rpmlint. I have the unstripped binary issue, and
also the no-documentation issue. These are all warnings, but I should fix them
once I know how. Incidentally, no documentation exists on these.

I also actually tried installing this RPM, and it appears to work. I'm kind of
amazed, actually. Anyway, links to the new stuff:

SPEC: http://people.freedesktop.org/~csimpson/alsa-patch-bay.spec
RPM:
http://people.freedesktop.org/~csimpson/alsa-patch-bay-1.0.0-2.fc12.i386.rpm
SRPM:
http://people.freedesktop.org/~csimpson/alsa-patch-bay-1.0.0-2.fc12.src.rpm

~ C.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=596746

--- Comment #10 from Terje Røsten terje...@phys.ntnu.no 2010-05-29 16:56:28 
EDT ---
Easy to fix, patch to convert to png and ship bzr.png:


+++ bzr-explorer.spec   2010-05-29 22:54:54.0 +0200
@@ -21,6 +21,8 @@
 BuildRequires: python-distutils-extra
 BuildRequires: gettext
 BuildRequires: desktop-file-utils
+# For convert
+BuildRequires: ImageMagick

 Requires:  qbzr = 0.18
 Requires:  bzr = 2.1
@@ -40,6 +42,7 @@

 %build
 %{__python} setup.py build
+convert extras/bzr-48.bmp bzr.png


 %install
@@ -56,6 +59,7 @@
 #put the locale into the right dir, see issue mentioned at Patch0
 mkdir -p %{buildroot}%{_datadir}
 mv %{buildroot}%{python_sitelib}/bzrlib/plugins/%{explorer}/locale
%{buildroot}%{_datadir}
+install -D -p -m 0644 bzr.png %{buildroot}%{_datadir}/pixmaps/bzr.png

 %find_lang %{explorer}

@@ -70,6 +74,7 @@
 %{python_sitelib}/bzrlib/plugins/%{explorer}/
 %{python_sitelib}/*.egg-info
 %{_datadir}/applications/%{name}.desktop
+%{_datadir}/pixmaps/bzr.png
 %doc README.txt COPYING.txt NEWS doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 597596] Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597596

--- Comment #3 from Thomas Spura toms...@fedoraproject.org 2010-05-29 
17:48:31 EDT ---
*** Bug 597592 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597592] Review Request: alsa-patch-bay - Simple gui for ALSA sequencers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597592

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||toms...@fedoraproject.org
 Resolution||DUPLICATE

--- Comment #1 from Thomas Spura toms...@fedoraproject.org 2010-05-29 
17:48:31 EDT ---


*** This bug has been marked as a duplicate of bug 597596 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580447] Review Request: perl-Module-Build - Build and install Perl modules

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580447

Chris Weyl cw...@alumni.drew.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #5 from Chris Weyl cw...@alumni.drew.edu 2010-05-29 17:57:01 EDT 
---
There's a couple things going on here:

In %files, we need to use %{perl_privlib} rather than %{perl_vendorlib} (as
this is duallifed/core).

I'd feel a touch better if we invoked %{perl_default_filter}, but it's not
strictly required. :)

While we don't need to do this for the subpackage, for this independent package
we should BR the extra bits to fully exercise the test suite (except for the
scary bits marked EXPERIMENTAL):

perl(PAR::Dist)
perl(Archive::Tar)

I didn't check the TEST_SIGNATURE parts, but if it works sanely in the
buildsys (might not if it needs, say, network access to keyservers or somesuch)
we should enable it as well.

A newer version has been released; normally I wouldn't consider this a blocker
for you, but as long as we're making these other changes...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597632] New: Review Request: SOPE - web app framework used by SOGo groupware

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: SOPE - web app framework used by SOGo groupware

https://bugzilla.redhat.com/show_bug.cgi?id=597632

   Summary: Review Request: SOPE - web app framework used by SOGo
groupware
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: hava...@pvv.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://www.pvv.org/~havardw/files/fedora/sope-4.9.0.0_20100529svn-1.spec
SRPM URL:
http://www.pvv.org/~havardw/files/fedora/sope-4.9.0.0_20100529svn-1.fc13.src.rpm
Description: SOPE is a web app framework in Objective-C. This is a dependency
for SOGo (Scalable OpenGroupware.org), which I'll create another review request
for shortly.

The spec file is based on the upstream spec file, and cleaned up to (hopefully)
meet Fedora standards. I've kept the division in sub-packages to keep closer to
upstream, but will be willing to reduce the number of sub-packages if that
should be a requirement.

rpmlint:
 rpmlint -iv ~/build/SPECS/sope.spec
/home/havardw/build/SPECS/sope.spec:248: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

0 packages and 1 specfiles checked; 0 errors, 1 warnings.

 rpmlint ~/build/RPMS/x86_64/sope*20100529*
sope-appserver.x86_64: W: no-documentation
sope-appserver-devel.x86_64: W: no-documentation
sope-appserver-devel.x86_64: W: no-manual-page-for-binary wod
sope-appserver-tools.x86_64: W: no-documentation
sope-appserver-tools.x86_64: W: no-manual-page-for-binary xmlrpc_call
sope-appserver-tools.x86_64: W: no-manual-page-for-binary sope-4.9
sope-core.x86_64: W: spelling-error %description -l en_US io - oi, Io, ii
sope-core.x86_64: W: no-documentation
sope-core-devel.x86_64: W: no-documentation
sope-gdl1.x86_64: W: no-documentation
sope-gdl1.x86_64: W: no-manual-page-for-binary load-EOAdaptor
sope-gdl1.x86_64: W: no-manual-page-for-binary connect-EOAdaptor
sope-gdl1-devel.x86_64: W: no-documentation
sope-gdl1-mysql.x86_64: W: no-documentation
sope-gdl1-postgresql.x86_64: W: no-documentation
sope-gdl1-sqlite.x86_64: W: no-documentation
sope-ical.x86_64: W: spelling-error %description -l en_US iCalendar - i
Calendar, calendar, calender
sope-ical.x86_64: W: spelling-error %description -l en_US vCard - v Card,
card, Cardin
sope-ical.x86_64: W: no-documentation
sope-ical-devel.x86_64: W: no-documentation
sope-ldap.x86_64: W: no-documentation
sope-ldap-devel.x86_64: W: no-documentation
sope-ldap-tools.x86_64: W: spelling-error Summary(en_US) dsml - dismal,
dismay, damsel
sope-ldap-tools.x86_64: W: spelling-error %description -l en_US dsml - dismal,
dismay, damsel
sope-ldap-tools.x86_64: W: spelling-error %description -l en_US login - loin,
logic, lo gin
sope-ldap-tools.x86_64: W: no-documentation
sope-ldap-tools.x86_64: W: no-manual-page-for-binary ldapls
sope-ldap-tools.x86_64: W: no-manual-page-for-binary ldapchkpwd
sope-ldap-tools.x86_64: W: no-manual-page-for-binary ldap2dsml
sope-mime.x86_64: W: no-documentation
sope-mime-devel.x86_64: W: no-documentation
sope-xml.x86_64: W: no-documentation
sope-xml-devel.x86_64: W: no-documentation
sope-xml-tools.x86_64: W: no-documentation
sope-xml-tools.x86_64: W: no-manual-page-for-binary domxml
sope-xml-tools.x86_64: W: no-manual-page-for-binary xmln
sope-xml-tools.x86_64: W: no-manual-page-for-binary saxxml
21 packages and 0 specfiles checked; 0 errors, 37 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597596] Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597596

--- Comment #4 from Corbin Simpson mostawesomed...@gmail.com 2010-05-29 
19:02:07 EDT ---
And now it builds on koji! Amazing what can get done when there's a take-home
final sitting above one's head. Links:

SPEC: http://people.freedesktop.org/~csimpson/alsa-patch-bay.spec
SRPM:
http://people.freedesktop.org/~csimpson/alsa-patch-bay-1.0.0-3.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 546738] Review Request: accerciser - An interactive Python accessibility explorer for the GNOME desktop

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546738

Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

 CC||mcla...@redhat.com

--- Comment #1 from Matthias Clasen mcla...@redhat.com 2010-05-29 19:35:43 
EDT ---
Builds fine in mock.

rpmlint says:
accerciser.noarch: E: explicit-lib-dependency libgail-gnome
accerciser.noarch: W: spelling-error %description -l en_US assistive -
assistance, assisted, assistant
accerciser.noarch: E: non-executable-script
/usr/share/accerciser/plugins/ipython_view.py 0644L /usr/bin/python
accerciser.noarch: W: non-conffile-in-etc /etc/gconf/schemas/accerciser.schemas
accerciser.src: W: spelling-error %description -l en_US assistive -
assistance, assisted, assistant
2 packages and 0 specfiles checked; 2 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 593841] Review Request: wicd - Wireless and wired network connection manager

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593841

David Cantrell dcantr...@redhat.com changed:

   What|Removed |Added

 Attachment #417799|application/octet-stream|text/plain
  mime type||

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 546738] Review Request: accerciser - An interactive Python accessibility explorer for the GNOME desktop

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546738

Matthias Clasen mcla...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|mcla...@redhat.com

--- Comment #3 from Matthias Clasen mcla...@redhat.com 2010-05-29 20:19:49 
EDT ---
package name: ok
spec file name: ok
packaging guidelines:
 - the rm -rf at the top of %install is no longer necessary
 - %clean is no longer necessary
 - the handling of the icon cache should be updated to follow
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
 - the desktop file has no MimeType entry, so the update-desktop-database call
is unnecessary
license: ok
license field: ok
license file: ok
spec file language: ok
spec file readability: ok
upstream sources: ok
buildable: ok
excludearch: ok
buildrequires: ok
locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
permissions: ok
macro use: ok
permissable content: ok
large docs: ok
%doc content: ok
headers: ok
static libs: ok
shared libs: ok
devel package: ok
libtool archives: ok
gui app: 
 - need to call desktop-file-validate on the installed desktop file
directory ownership: ok
utf8 filenames: ok

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594943

--- Comment #28 from Robin Norwood robin.norw...@gmail.com 2010-05-29 
20:32:19 EDT ---
I'll include a comment to that effect in the next release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 594943] Review Request: libnoise - A general-purpose library that generates three-dimensional coherent noise

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594943

--- Comment #27 from Robin Norwood robin.norw...@gmail.com 2010-05-29 
20:31:53 EDT ---
Jussi: The upstream makefile doesn't work with current versions of libtool. 
Also, it doesn't respect Fedora's compiler flags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581509] Review Request: yacas - easy to use, general purpose Computer Algebra System

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581509

--- Comment #10 from Henrique LonelySpooky Junior henrique...@gmail.com 
2010-05-29 23:10:34 EDT ---
Thanks for the kind review, Ankur, I was just waiting for F13 to be released,
now, I'm back to work.
Again, thank you so much, I'll be fixing this issues ASAP.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 508351] Review Request: josm - java openstreetmap editor

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351

--- Comment #45 from Alex Lancaster al...@users.sourceforge.net 2010-05-29 
23:10:54 EDT ---
(In reply to comment #44)
 Unblocking FE-NEEDSPONSOR - I just sponsored Cédric OLIVIER.

OK, now that you are his sponsor, you need to complete the formal review.  (All
sponsors must be the reviewer of the sponsorees first package).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 597681] New: Review Request: kupfer - A free software launcher

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: kupfer - A free software launcher

https://bugzilla.redhat.com/show_bug.cgi?id=597681

   Summary: Review Request: kupfer - A free software launcher
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: rtn...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://rtnpro.fedorapeople.org/Packages/SPECS/kupfer.spec
SRPM URL: 
Description:

I am packaging kupfer for fedora. I have already packaged
python-keyring which is a dependency for kupfer.

http://rtnpro.fedorapeople.org/Packages/SRPMS/python-keyring-0.2-1.fc12.src.rpm

kupfer SPEC used : http://rtnpro.fedorapeople.org/Packages/SPECS/kupfer.spec
kupfer src : http://kaizer.se/publicfiles/kupfer/kupfer-v200.tar.gz
kupfer uses the waf build system. While
./waf configure
works from the source folder of kupfer
#
[rtn...@xps kupfer-v200]$ waf configure
Check for program python : /usr/bin/python
Checking for Python version = 2.6.0 : ok 2.6.2
Check for program gcc or cc  : /usr/lib/ccache/gcc
Check for program cpp: /usr/bin/cpp
Check for program ar : /usr/bin/ar
Check for program ranlib : /usr/bin/ranlib
Check for program msgfmt : /usr/bin/msgfmt
Check for program intltool-merge : /usr/bin/intltool-merge
Checking for header locale.h : ok
Check for program xml2po : /usr/bin/xml2po
Installing python modules into: /usr/local/share/kupfer
Checking for Python module gio   : ok
Checking for Python module gtk   : ok
Checking for Python module xdg   : ok
Checking for Python module dbus  : ok
Checking for Python module keyring   : ok
Checking optional dependencies:
Check for program dbus-send  : /bin/dbus-send
Check for program rst2man: not found
Optional, allows: Generate and install man page
Checking for Python module keybinder : not found
Python module keybinder is recommended
Please see README
Checking for Python module wnck  : ok
Checking for Python module gnome : ok
'configure' finished successfully (0.808s)

But while I am doing rpmbuild, it says that
Python gtk module not found

#
[rtn...@xps SPECS]$ rpmbuild -ba kupfer.spec
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.AtQBIg
+ umask 022
+ cd /home/rtnpro/rpmbuild/BUILD
+ LANG=C
+ export LANG
+ unset DISPLAY
+ cd /home/rtnpro/rpmbuild/BUILD
+ rm -rf kupfer-v200
+ /usr/bin/gzip -dc /home/rtnpro/rpmbuild/SOURCES/kupfer-v200.tar.gz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd kupfer-v200
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.sxcUp9
+ umask 022
+ cd /home/rtnpro/rpmbuild/BUILD
+ cd kupfer-v200
+ LANG=C
+ export LANG
+ unset DISPLAY
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m32 -march=i686
-mtune=atom -fasynchronous-unwind-tables'
+ LDFLAGS=-lm
+ waf configure --prefix=/usr
Check for program python : /usr/bin/python
Checking for Python version = 2.6.0 : ok 2.6.2
Check for program gcc or cc  : /usr/lib/ccache/gcc
Check for program cpp: /usr/bin/cpp
Check for program ar : /usr/bin/ar
Check for program ranlib : /usr/bin/ranlib
Check for program msgfmt : /usr/bin/msgfmt
Check for program intltool-merge : /usr/bin/intltool-merge
Checking for header locale.h : ok
Check for program xml2po : /usr/bin/xml2po
Installing python modules into: /usr/share/kupfer
Checking for Python module gio   : ok
Checking for Python module gtk   : not found
/home/rtnpro/rpmbuild/BUILD/kupfer-v200/wscript:143: error: Could not
find the python module 'gtk'
error: Bad exit status from /var/tmp/rpm-tmp.sxcUp9 (%build)


RPM build errors:
   Bad exit status from /var/tmp/rpm-tmp.sxcUp9 (%build)

I am not able to figure out why this is happening.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597681] Review Request: kupfer - A free software launcher

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597681

Ratnadeep Debnath rtn...@gmail.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 593800] Review Request: python-keyring - keyring module for python

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593800

Ratnadeep Debnath rtn...@gmail.com changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 570457] Review Request: rubygem-right_rackspace - Interface classes for Rackspace

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570457

--- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-30 
01:35:39 EDT ---
Again ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 578269] Review Request: xgospel - An X11 client for Internet Go Server

2010-05-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578269

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag||needinfo?(jin...@yahoo.com)

--- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-05-30 
01:36:10 EDT ---
ping?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review