[Bug 578024] Review Request: ingres - Relational DBMS Server and Utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=578024 --- Comment #23 from Jay Hankinson jeremy.hankin...@ingres.com 2010-06-03 01:57:22 EDT --- Seem to be having an odd problem with ldconfig. If I don't specify the directory (/usr/lib/ingres) when running ldconfig from %post in ingres-client, I get a load of undefined references when running the utilities. I've left it in for now, will investigate further tomorrow and mail the devel list if I need to. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599324] Review Request: rotoscope - A program to rotoscope images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599324 Tareq Al Jurf talj...@fedoraproject.org changed: What|Removed |Added Version|rawhide |12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599324] New: Review Request: rotoscope - A program to rotoscope images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: rotoscope - A program to rotoscope images https://bugzilla.redhat.com/show_bug.cgi?id=599324 Summary: Review Request: rotoscope - A program to rotoscope images Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: talj...@fedoraproject.org QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://taljurf.fedorapeople.org/Packages/i686/rotoscope/rotoscope.spec SRPM URL: http://taljurf.fedorapeople.org/Packages/i686/rotoscope/rotoscope-0.2-1.fc12.src.rpm Description: Rotoscope is a free software rotoscoping application that can be used to give photos a cartoon-like appearance. This is similar to the technique used in movies such as Waking Life and A Scanner Darkly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 492165] Review Request: rotoscope - A free rotoscoping application.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492165 Tareq Al Jurf talj...@fedoraproject.org changed: What|Removed |Added CC||talj...@fedoraproject.org Resolution|NOTABUG |DUPLICATE --- Comment #7 from Tareq Al Jurf talj...@fedoraproject.org 2010-06-03 02:27:06 EDT --- *** This bug has been marked as a duplicate of bug 599324 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599324] Review Request: rotoscope - A program to rotoscope images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599324 Tareq Al Jurf talj...@fedoraproject.org changed: What|Removed |Added CC||yansta...@googlemail.com --- Comment #1 from Tareq Al Jurf talj...@fedoraproject.org 2010-06-03 02:27:06 EDT --- *** Bug 492165 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 487241] Review Request: ntlmaps - NTLM Authentication Proxy Service
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487241 Sanne Grinovero sanne.grinov...@gmail.com changed: What|Removed |Added CC||sanne.grinov...@gmail.com Flag||needinfo?(matt_dom...@dell. ||com) --- Comment #3 from Sanne Grinovero sanne.grinov...@gmail.com 2010-06-03 02:48:11 EDT --- Hi Matt, are you not maintainig this any more? This package is very useful; Big enterprises often require this kind of authorization and I would be totally stuck in a windows vm without it. Please have it integrated in Fedora's repositories; Ubuntu is having it, and provides the required init scripts. thanks Sanne -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598376] Review Request: maven-one-plugin - Maven One Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598376 --- Comment #5 from Yang Yong yy...@redhat.com 2010-06-03 03:08:10 EDT --- Added changelog, and used bz2, please review. Spec URL: http://yyang.fedorapeople.org/maven2/maven-one-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-one-plugin-1.2-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598138] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598138 --- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-03 03:07:00 EDT --- Then would you once relogin to bugzilla with the same email as FAS one for confirmation? When doing something related to packaging review, logining to bugzilla with the same address as FAS one (or with FAS account name@fedorapeoject.org) is needed on some process. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599316] Review Request: input-pad - Input Pad
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599316 fujiwara tfuji...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599097 --- Comment #2 from Ankur Sinha sanjay.an...@gmail.com 2010-06-03 03:50:10 EDT --- Ticket at the yorba trac regarding the configure script: http://trac.yorba.org:8000/ticket/2001 Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598138] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598138 Shreyank Gupta shreya...@gmail.com changed: What|Removed |Added CC||shreya...@gmail.com --- Comment #15 from Shreyank Gupta shreya...@gmail.com 2010-06-03 03:59:48 EDT --- (In reply to comment #14) Then would you once relogin to bugzilla with the same email as FAS one for confirmation? When doing something related to packaging review, logining to bugzilla with the same address as FAS one (or with FAS account name@fedorapeoject.org) is needed on some process. This would be the Bugzilla account that has the same email as my FAS account. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] New: Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: arcjobtool - ARC Job Submission Tool https://bugzilla.redhat.com/show_bug.cgi?id=599414 Summary: Review Request: arcjobtool - ARC Job Submission Tool Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mattias.ell...@fysast.uu.se QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.grid.tsl.uu.se/review/arcjobtool.spec SRPM URL: http://www.grid.tsl.uu.se/review/arcjobtool-0.3.0-0.rc5.fc12.1.src.rpm Description: This is a graphical user interface for the Advanced Resource Connector (ARC) grid middleware client. It offers among other things bulk job handling and easy job description creation. Since it uses the plug-in based ARC client library, it also supports submitting jobs to non-ARC grid-services like e.g. gLite CREAM provided the appropriate plug-ins are installed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599414] Review Request: arcjobtool - ARC Job Submission Tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599414 Mattias Ellert mattias.ell...@fysast.uu.se changed: What|Removed |Added Depends on||530684 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 530684] Review Request: nordugrid-arc-nox - Advanced Resource Connector
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530684 Mattias Ellert mattias.ell...@fysast.uu.se changed: What|Removed |Added Blocks||599414 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598929] Review Request: maven-remote-resources-plugin - Maven Remote Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598929 Guido Grazioli guido.grazi...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #4 from Guido Grazioli guido.grazi...@gmail.com 2010-06-03 04:01:52 EDT --- Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599097 --- Comment #3 from Ankur Sinha sanjay.an...@gmail.com 2010-06-03 04:23:42 EDT --- hi, updated: * Thu Jun 03 2010 Ankur Sinha ankursinha AT fedoraproject DOT org - 0.0.90-2 - some fixes in spec - moved *.vapi to devel - removed INSTALL from doc - added comment to yorba ticket link - corrected typo in description http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2.spec http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2-0.0.90-2.fc13.src.rpm mock build results at http://ankursinha.fedorapeople.org/libgexiv2/ regards, Ankur -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598138] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598138 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #16 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-03 04:25:31 EDT --- Thanks. Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from Add Package to CVS and Set Owner. Now I am sponsoring you. If you want to import this package into Fedora 12/13, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Removing NEEDSPONSOR. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597709] Review Request: rubygem-ncursesw - Hacked up version of ncurses gem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597709 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-03 04:26:18 EDT --- (removing NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598980] Review Request: rubygem-lockfile - Ruby library for creating NFS safe lockfiles
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598980 Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed: What|Removed |Added Blocks|177841(FE-NEEDSPONSOR) | --- Comment #2 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-03 04:27:02 EDT --- (Removing NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598058] Review Request: maven-docck-plugin - Maven Documentation Checker Plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598058
--- Comment #9 from huwang huw...@redhat.com 2010-06-03 04:35:29 EDT ---
(In reply to comment #8)
NEEDSWORK: rpmlint must be run on every package. The output should be posted
in
the review.
maven-docck-plugin.src: W: invalid-url Source0: maven-docck-plugin-1.0.tar.gz
maven-docck-plugin.noarch: W: self-obsoletion maven2-plugin-docck = 0:2.0.8
obsoletes maven2-plugin-docck = 1.0-1.fc13
maven-docck-plugin.noarch: W: no-documentation
maven-docck-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-docck-plugin
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
Everything except self-obsoletion is false-positive. You need to fix
that self-obsoletion (by adding epoch 1 to provides) though.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work
on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
OK: All build dependencies must be listed in BuildRequires, except for any
that
are listed in the exceptions section of the Packaging Guidelines ; inclusion
of
those as BuildRequires is optional. Apply common sense.
OK: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK: A package must own all directories that it creates. If it does not create
a
directory that it uses, then it should require a package which does create
that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
OK: If a package includes something as %doc, it must not affect the runtime of
the application. To summarize: If it is in %doc, the program must run properly
if it is not present.
OK: Packages must not own files or directories already owned by other
packages.
The rule of thumb here is that the first package to be installed should own
the
files or directories that other packages may rely upon. This means, for
example, that no package in Fedora should ever share ownership with any of the
files or directories owned by the filesystem or man package. If you feel that
you have a good reason to own a file or directory that another package owns,
then please present that at package review time.
OK: All filenames in rpm packages must be valid UTF-8.
Other notes:
You are using gzip compression to create tarball from SVN. Using xz
compression creates smaller archives (saving space on dist machines)
and is fully supported. You can create xz archive by doing:
tar acf maven-docck-plugin-1.0.tar.xz maven-docck-plugin-1.0/
(don't forget to change Source0 URL afterwards)
Another (tiny) thing to be careful about for future is to try to be
consistent in every way possible. For example you are using 0755 in
one place and few lines down you use 755. Pick one style and stick
with it.
A small tip. It's also possible to install file and create all the
directories in one step. For example:
[Bug 598361] Review Request: maven-rar-plugin - Maven Rar plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598361 --- Comment #3 from Yang Yong yy...@redhat.com 2010-06-03 04:33:32 EDT --- Spec URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-rar-plugin-2.2-2.src.rpm Please review again, changlog: - Format description - Fix Obsoletes and Provides - Use bz2 to compress source - Add reason for ignore failure of test -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598891] Review Request: maven-help-plugin - Plugin to to get relative information about a project or the system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598891 Yang Yong yy...@redhat.com changed: What|Removed |Added Flag||fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599291] Review Request: maven-ear-plugin - Maven EAR Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599291 huwang huw...@redhat.com changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593959] Review Request: maven-assembly-plugin - Maven Assembly Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593959 --- Comment #5 from Yang Yong yy...@redhat.com 2010-06-03 05:10:04 EDT --- Please review again. Spec URL: http://yyang.fedorapeople.org/maven2/maven-assembly-plugin.spec SRPM URL: http://yyang.fedorapeople.org/maven2/maven-assembly-plugin-2.2-0.2.beta5.src.rpm Changelog: - Chmod 0644 for depmap.xml - Fix Obsoletes and Provides - Change to BR java -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 --- Comment #13 from Chen Lei supercyp...@gmail.com 2010-06-03 06:13:59 EDT --- (In reply to comment #10) Possible, but since I don't know how to make that determination, and this package might be of use to future packages, I see no reason not to do the whole shebang. I think packaging lzma-sdk is a bit complicated and may need some time to consider how to do is the best. Also, considring lzma 4.x is dead in upstream, it'll be must appropriate to package lzma 9.x. Once, upx support lzma 9.x, we can switch from bundled lzma to lzma source in the repo. I think bundling a dead upstream source is harmless. Since you already ship lzma in upx 3.04, I suggest you also ship lzma 4.65 in upx 3.05 as well temporary， this won't introduce new bugs. Considering upx 3.05 is a pure bugfix release, updating to the latest version will fix some bugs in upx 3.04 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598929] Review Request: maven-remote-resources-plugin - Maven Remote Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598929 huwang huw...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598929] Review Request: maven-remote-resources-plugin - Maven Remote Resources Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598929 --- Comment #5 from huwang huw...@redhat.com 2010-06-03 06:36:22 EDT --- New Package CVS Request === Package Name: maven-remote-resources-plugin Short Description: Maven Remote Resources Plugin Owners: huwang Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598138] Review Request: rubygem-rmail - A MIME mail parsing and generation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598138 Shreyank Gupta shreya...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #17 from Shreyank Gupta shreya...@gmail.com 2010-06-03 06:50:03 EDT --- New Package CVS Request === Package Name: rubygem-rmail Short Description: A MIME mail parsing and generation library Owners: shreyankg Branches: F-13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588461] Review Request: rubygem-net-ssh - A Ruby ssh client library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588461 --- Comment #2 from Shreyank Gupta shreya...@gmail.com 2010-06-03 07:14:34 EDT --- Please use the following Spec URL while reviewing this request: Spec URL: http://github.com/admiyo/MySpecs/raw/master/rubygem-net-ssh.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599506] New: Review Request: maven-war-plugin - Maven WAR Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: maven-war-plugin - Maven WAR Plugin https://bugzilla.redhat.com/show_bug.cgi?id=599506 Summary: Review Request: maven-war-plugin - Maven WAR Plugin Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: w...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://weli.fedorapeople.org/packages/fedora-14/maven-war-plugin/maven-war-plugin.spec SRPM URL: http://weli.fedorapeople.org/packages/fedora-14/maven-war-plugin/maven-war-plugin-2.1-0.1.b1.src.rpm Description: Builds a Web Application Archive (WAR) file from the project output and its dependencies. Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2226988 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598376] Review Request: maven-one-plugin - Maven One Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598376 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03 07:58:52 EDT --- I re-checked. Package seems good. Make only two corrections before you commit to CVS: * fix comment about creating tarball. It still has instructions for tar.bz. * remove epoch from changelog. Your package is providing old name (maven2-plugin-one) with epoch 1 but itself it has no epoch. Sorry I didn't notice before.. These issues are not serious and can be fixed easily... This package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599506] Review Request: maven-war-plugin - Maven WAR Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=599506 --- Comment #1 from Weinan Li w...@redhat.com 2010-06-03 08:02:34 EDT --- The above scratch build is incorrect, please use this one: http://koji.fedoraproject.org/koji/taskinfo?taskID=2227001 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598376] Review Request: maven-one-plugin - Maven One Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598376 --- Comment #7 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03 08:04:04 EDT --- Oh, and also there is a small typo in the changelog (privodes) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598058] Review Request: maven-docck-plugin - Maven Documentation Checker Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598058 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #10 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03 08:10:04 EDT --- Package looks good. One small thing though. To really create tar.bz2 archive you have to use 'j' instead of 'z' when calling tar. So update the comment accordingly and re-create your srpm before importing to CVS. Package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598902] Review Request: PXZ - Parallel LZMA compressor compatible with XZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598902 Jussi Lehtola jussi.leht...@iki.fi changed: What|Removed |Added Status|NEW |ASSIGNED CC||jussi.leht...@iki.fi AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi Flag||fedora-review? --- Comment #1 from Jussi Lehtola jussi.leht...@iki.fi 2010-06-03 08:20:27 EDT --- Assigning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598361] Review Request: maven-rar-plugin - Maven Rar plugin
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598361
Stanislav Ochotnicky socho...@redhat.com changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03
08:19:53 EDT ---
Package looks OK. Two small things though:
* spelling error (applicationuses - quite funny looking to me :-) )
* please update comment about Source0 to actually create tar.bz2 format ('j'
instead of 'z' and proper suffix)
All in all, those issues are cosmetic. Package is APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592443] Review Request: antlrworks - Grammar development environment for ANTLR v3 grammars
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592443 Stanislav Ochotnicky socho...@redhat.com changed: What|Removed |Added CC||socho...@redhat.com Flag||fedora-review? --- Comment #1 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03 08:28:28 EDT --- I can do the review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598902] Review Request: PXZ - Parallel LZMA compressor compatible with XZ
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598902
--- Comment #2 from Jussi Lehtola jussi.leht...@iki.fi 2010-06-03 08:28:58
EDT ---
rpmlint output:
pxz.x86_64: W: incoherent-version-in-changelog 4.999.9-0.1.20100526.beta
['4.999.9-0.1.beta.20100602git.fc13', '4.999.9-0.1.beta.20100602git']
pxz.x86_64: W: no-manual-page-for-binary pxz
pxz-debuginfo.x86_64: E: debuginfo-without-sources
3 packages and 0 specfiles checked; 1 errors, 2 warnings.
The error is caused by optflags not being used:
gcc -Wall -Wshadow -Wcast-align -Winline -Wextra -Wmissing-noreturn
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -DPXZ_BUILD_DATE=\`date +%Y%m%d`\
-DPXZ_VERSION=\4.999.9beta\ -O2 -fopenmp -llzma pxz.c -o pxz
Change
CFLAGS=%{optflags}
to
export CFLAGS=%{optflags}
and it works.
However, I recommend patching out
CFLAGS+=-O2 -fopenmp
from the makefile, and using
export CFLAGS=%{optflags} -fopenmp
instead.
The man page warning can be omitted. Although, I see you are also upstream, so
I'd recommend you create a man page.
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
NEEDSWORK
- License is GPLv2+, not LGPLv2+.
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. NEEDSWORK
- See above.
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. NEEDSWORK
- See above.
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592443] Review Request: antlrworks - Grammar development environment for ANTLR v3 grammars
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592443 --- Comment #2 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03 08:31:44 EDT --- Before I start official review...Spec file you lined to and spec file inside SRPM don't match. Fix this please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596746 --- Comment #24 from Julian Aloofi julian.fed...@googlemail.com 2010-06-03 08:36:52 EDT --- Sure thing! New Spec: http://julian.fedorapeople.org/bzr-explorer/bzr-explorer.spec New SRPM: http://julian.fedorapeople.org/bzr-explorer/bzr-explorer-1.0.2-1.fc13.src.rpm Note: Still requires bzr from updates-testing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596746 Terje Røsten terje...@phys.ntnu.no changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #25 from Terje Røsten terje...@phys.ntnu.no 2010-06-03 09:04:07 EDT --- Thanks, formal review: ok rpmlint, only harmless spelling warnings ok naming of package and spec ok spec file include doc/ROADMAP.txt and doc/overview.txt? ok license approved and tag ok. GPL2+, all files seems to have license header ok license in %doc ok correct language ok sha1sum on sources and ok url sha1sum bzr-explorer-1.0.2.tar.gz* ad57c9cbcde2004af76ed29b520ddd075c2d15fe bzr-explorer-1.0.2.tar.gz ad57c9cbcde2004af76ed29b520ddd075c2d15fe bzr-explorer-1.0.2.tar.gz.orig ok koji build with correct buildreq http://koji.fedoraproject.org/koji/taskinfo?taskID=2227301 ok excludearch ok locale files - ldconfig ok no bundling ok owns, dirs and perms and only once ok macros ok code or content - large docs ok %doc not affect the runtime - headers|static in devel|static - .so in devel - devel dep on base - no .la|.a file ok gui with desktop file ok own just not owned ok utf-8 file names Thanks for working with upstream and fixing the issues that was discovered. The package bzr-explorer is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596461] Review Request: lzma - SDK for lzma compression
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596461 --- Comment #14 from Jon Ciesla l...@jcomserv.net 2010-06-03 09:30:38 EDT --- What's complicated about it? Are there specific issues not addressed by the package as is? I see no reason not to go ahead with it and stop bundling it in upx. WRT 9.x, I agree, but I don't think waiting for that is the appropriate solution. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596746 Julian Aloofi julian.fed...@googlemail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #26 from Julian Aloofi julian.fed...@googlemail.com 2010-06-03 09:37:32 EDT --- New Package CVS Request === Package Name: bzr-explorer Short Description: Graphical application for using Bazaar Owners: julian Branches: F-13 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467324] Review Request: mingw32-portablexdr - MinGW Windows PortableXDR XDR / RPC library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467324 --- Comment #25 from Richard W.M. Jones rjo...@redhat.com 2010-06-03 10:18:35 EDT --- Don't worry, if Bugzilla runs out of bits keeping this bug open, I'll buy us a few more. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592443] Review Request: antlrworks - Grammar development environment for ANTLR v3 grammars
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=592443
Stanislav Ochotnicky socho...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|nob...@fedoraproject.org|socho...@redhat.com
--- Comment #3 from Stanislav Ochotnicky socho...@redhat.com 2010-06-03
10:37:38 EDT ---
Ah well...I checked spec differences and they were cosmetic, but please be more
careful next time :-)
OK: rpmlint must be run on every package. The output should be posted in the
antlrworks.src: W: spelling-error %description -l en_US nondeterminisms -
determinism, deterministic, indeterminably
antlrworks.src: W: spelling-error %description -l en_US nondeterministic - non
deterministic, non-deterministic, deterministic
antlrworks.src: W: spelling-error %description -l en_US refactoring - re
factoring, re-factoring, factoring
antlrworks.noarch: E: devel-dependency java-devel
antlrworks.noarch: W: spelling-error %description -l en_US nondeterminisms -
determinism, deterministic, indeterminably
antlrworks.noarch: W: spelling-error %description -l en_US nondeterministic -
non deterministic, non-deterministic, deterministic
antlrworks.noarch: W: spelling-error %description -l en_US refactoring - re
factoring, re-factoring, factoring
antlrworks.noarch: W: no-manual-page-for-binary antlrworks
2 packages and 0 specfiles checked; 1 errors, 7 warnings.
You explained the devel dependency and it's OK.
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. .
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK(mock): The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory.
OK: A Fedora package must not list a file more than once in the spec file's
%files listings.
OK: Permissions on files must be set properly. Executables should be set with
executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: Large documentation files must go in a -doc subpackage. (The definition of
large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity).
NEEDSWORK: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.
You have to use desktop-file-install, not just desktop-file-validate
since you are installing the file yourself. You also have to Require
hicolor-icon-theme since you are using its directories.
OK: Packages must not own files or directories already owned by other packages.
The rule of thumb here is that the first package to be installed should own the
files or directories that other packages may rely upon. This means, for
example, that no package in Fedora should ever share ownership with any of the
files or directories owned by the filesystem or man package. If you feel that
you have a good reason to own a file or directory that another package owns,
then please present that at package review time.
OK: All filenames in rpm packages must be valid UTF-8.
Other:
* patch1 has a small typo for suffix browers :-)
* readme and release.txt should
[Bug 596746] Review Request: bzr-explorer - GUI application for using Bazaar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=596746 --- Comment #27 from Julian Aloofi julian.fed...@googlemail.com 2010-06-03 10:43:24 EDT --- Thanks for reviewing, by the way! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467324] Review Request: mingw32-portablexdr - MinGW Windows PortableXDR XDR / RPC library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467324 --- Comment #26 from Tom spot Callaway tcall...@redhat.com 2010-06-03 10:45:04 EDT --- Well, I would like to get this off the FE-Legal blocker ticket. Can you at least post a SRPM with the relicensing changes applied. Change any references to the SUN RPC license to this: /* * Copyright (c) 2009, Sun Microsystems, Inc. * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * - Redistributions of source code must retain the above copyright notice, * this list of conditions and the following disclaimer. * - Redistributions in binary form must reproduce the above copyright notice, * this list of conditions and the following disclaimer in the documentation * and/or other materials provided with the distribution. * - Neither the name of Sun Microsystems, Inc. nor the names of its * contributors may be used to endorse or promote products derived * from this software without specific prior written permission. * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS AS IS * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. */ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597709] Review Request: rubygem-ncursesw - Hacked up version of ncurses gem
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=597709 Shreyank Gupta shreya...@gmail.com changed: What|Removed |Added CC||shreya...@gmail.com --- Comment #8 from Shreyank Gupta shreya...@gmail.com 2010-06-03 10:49:30 EDT --- Koji Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2227505 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 554464] Review Request: python-pebl - Python Environment for Bayesian Learning
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=554464
--- Comment #8 from Tadej Janež tadej.ja...@tadej.hicsalta.si 2010-06-03
10:52:48 EDT ---
Thanks for a quick reply!
(In reply to comment #7)
There are some rpmlint warnings (just posting the relevant ones, which are not
ignorable):
python-pebl.src:56: W: macro-in-comment %check
python-pebl.src:57: W: macro-in-comment %{__python}
- ignorable, because they remind you to add %check again
I left the %check disabled and added a comment to the .spec file saying why it
is currently disabled.
python-pebl.src:61: W: macro-in-comment %{buildroot}
python-pebl.src:62: W: macro-in-comment %{python_sitelib}
- Better prefix an %, so this won't show up anymore
Ok, fixed.
python-pebl.x86_64: W: private-shared-object-provides
/usr/lib64/python2.6/site-packages/pebl/_network.so _network.so()(64bit)
python-pebl.x86_64: W: private-shared-object-provides
/usr/lib64/python2.6/site-packages/pebl/_cpd.so _cpd.so()(64bit)
- A solution for this is e.g. in bug 537983 comment 27.
Ok, I tried your solution, however, I don't know if I used it correctly.
The output log of rpmbuild still indicates these unnecessary provides:
Finding Provides: /usr/lib/rpm/find-provides | grep -v -e
'_cpd.so|_network.so'
Finding Requires: /usr/lib/rpm/find-requires | grep -v -e
'_cpd.so|_network.so'
Provides: _cpd.so _network.so
Requires(rpmlib): rpmlib(PartialHardlinkSets) = 4.0.4-1 rpmlib(FileDigests) =
4.6.0-1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 rpmlib(CompressedFileNames) =
3.0.4-1
Requires: /usr/bin/python libc.so.6 libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.3.4) libpthread.so.0 libpython2.6.so.1.0
However, rpmlint doesn't give the above 2 warnings anymore. What is happening
here?
python-pebl.x86_64: W: unstripped-binary-or-object
/usr/lib64/python2.6/site-packages/pebl/_network.so
python-pebl.x86_64: W: unstripped-binary-or-object
/usr/lib64/python2.6/site-packages/pebl/_cpd.so
This is a bit strange... Do you have a debuginfo package? I'm wondering, why
there isn't one here...
Yes, I see a separate python-pebl-debuginfo-1.0.2-2.fc13.i686.rpm package built
on my system. Also, that is why I don't see the above rpmlint error messages.
There is /usr/lib64/python2.6/site-packages/pebl/test/
Is that needed at runtime? If not, it would be nice, if you'd delete that (or
ask upstream to do so).
Ok, I removed test and test.manual from the final rpm file.
See the new .spec file and .src.rpm at http://tadej.fedorapeople.org/.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598902] Review Request: PXZ - Parallel LZMA compressor compatible with XZ
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598902 --- Comment #3 from Jindrich Novy jn...@redhat.com 2010-06-03 10:52:44 EDT --- Thanks! All of the mentioned fixes should be addressed now. http://jnovy.fedorapeople.org/pxz/pxz.spec http://jnovy.fedorapeople.org/pxz/pxz-4.999.9-0.1.beta.20100603git.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532276] Review Request: python-googlevoice - Python language bindings for the Google Voice API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532276 --- Comment #20 from Fedora Update System upda...@fedoraproject.org 2010-06-03 10:59:01 EDT --- python-googlevoice-0.5-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532276] Review Request: python-googlevoice - Python language bindings for the Google Voice API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532276 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-googlevoice-0.5-1.fc |python-googlevoice-0.5-1.el |13 |5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 576839] Review Request: bdii - The Berkeley Database Information Index (BDII)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576839 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-06-03 11:00:41 EDT --- bdii-5.1.5-1.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bdii'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/bdii-5.1.5-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575185 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-bunch-1.0.0-1.fc11 |python-bunch-1.0.0-1.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575185] Review Request: python-bunch - python dictionary with attribute-style access
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575185 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-06-03 11:01:05 EDT --- python-bunch-1.0.0-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581278] Review Request: erlang-etap - Erlang testing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581278 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-06-03 10:59:43 EDT --- erlang-etap-0.3.4-2.el5, couchdb-0.10.2-8.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-etap couchdb'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.el5,couchdb-0.10.2-8.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581278] Review Request: erlang-etap - Erlang testing library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581278 --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-06-03 10:58:40 EDT --- erlang-etap-0.3.4-2.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-etap'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/erlang-etap-0.3.4-2.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599597] New: Review Request: amule - The all-platform eMule p2p client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: amule - The all-platform eMule p2p client https://bugzilla.redhat.com/show_bug.cgi?id=599597 Summary: Review Request: amule - The all-platform eMule p2p client Product: Fedora Version: 13 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: supercyp...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Description of problem: aMule is an easy to use multi-platform client for ED2K Peer-to-Peer Network. It is a fork of xMule, whis was based on eMule for Windows. aMule currently supports (but is not limited to) the following platforms: Linux, *BSD and MacOS X. SPEC: http://dl.dropbox.com/u/1338197/1/amule.spec SRPM: http://dl.dropbox.com/u/1338197/1/amule-2.2.6-2.fc13.src.rpm Heavily modified from spec in the rpmfusion, I'll give owner or co-maintainship for the original maintainer in rpmfusion once the package is reviewed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 576839] Review Request: bdii - The Berkeley Database Information Index (BDII)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=576839 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-06-03 11:01:19 EDT --- bdii-5.1.5-1.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update bdii'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/bdii-5.1.5-1.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467324] Review Request: mingw32-portablexdr - MinGW Windows PortableXDR XDR / RPC library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467324 Richard W.M. Jones rjo...@redhat.com changed: What|Removed |Added Blocks|182235(FE-Legal)| --- Comment #27 from Richard W.M. Jones rjo...@redhat.com 2010-06-03 11:12:36 EDT --- There's no Sun code in PortableXDR, because I replaced it. I've removed the blocker on FE-LEGAL. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599606] New: Review Request: maven-invoker-plugin - Maven Invoker Plugin
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: maven-invoker-plugin - Maven Invoker Plugin https://bugzilla.redhat.com/show_bug.cgi?id=599606 Summary: Review Request: maven-invoker-plugin - Maven Invoker Plugin Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: w...@redhat.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://weli.fedorapeople.org/packages/fedora-14/maven-invoker-plugin/maven-invoker-plugin.spec SRPM URL: http://weli.fedorapeople.org/packages/fedora-14/maven-invoker-plugin/maven-invoker-plugin-1.5-1.src.rpm Description: The Maven Invoker Plugin is used to run a set of Maven projects. Note: this needs to be built in the dist-f14-maven221 koji tag. Here is a successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2227551 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 581619] Review Request: mlterm - Multi Lingual TERMinal emulator on X
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=581619 --- Comment #12 from Muayyad Alsadi als...@ojuba.org 2010-06-03 11:42:20 EDT --- the latest .src.rpm with the suggested patch http://www.ojuba.org/downloads/updates/testing/4/SRPMS/mlterm-3.0.0-3.oj4.src.rpm to test it, I've built it on F13 http://www.ojuba.org/downloads/updates/testing/4/x86_64/mlterm-3.0.0-3.oj4.x86_64.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599324] Review Request: rotoscope - A program to rotoscope images
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=599324
Martin Gieseking martin.giesek...@uos.de changed:
What|Removed |Added
CC||martin.giesek...@uos.de
--- Comment #2 from Martin Gieseking martin.giesek...@uos.de 2010-06-03
11:49:06 EDT ---
Hi Tareq, here are some quick comments:
- the license seems to be GPLv2+ (according to the source headers)
- use %{version} in Source0 to simplify future package updates
- COPYING is missing in %doc
- drop empty file NEWS from %doc
$ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm
rotoscope.i686: W: name-repeated-in-summary C rotoscope
rotoscope.i686: W: spelling-error %description -l en_US rotoscoping -
arthroscopic, stroboscopic, gyroscopic
rotoscope.i686: E: zero-length /usr/share/doc/rotoscope-0.2/NEWS
rotoscope.src: W: name-repeated-in-summary C rotoscope
rotoscope.src: W: spelling-error %description -l en_US rotoscoping -
arthroscopic, stroboscopic, gyroscopic
3 packages and 0 specfiles checked; 1 errors, 4 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 479598] Review Request: aopalliance - AOP offers a better solution to many problems than do existing technologies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479598 --- Comment #21 from Frank Ch. Eigler f...@redhat.com 2010-06-03 12:14:05 EDT --- Is redhat/fedora legal also advising that an american law dictionary entry is sufficiently relevant to the stated intentions of a french author? Just curious whether we're holding back because of an overabundance of caution. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590244] Review Request: pinta - Simple Paint Application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590244 --- Comment #4 from Paul Lange pala...@gmx.de 2010-06-03 12:24:36 EDT --- Sorry for the long delay, didn't have much time. Recently pinta upstream got autotools support. I think it would be clever to wait for the next release? Comments? Anyway, I'm not a bash pro, how do I correctly escape $@? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599324] Review Request: rotoscope - A program to rotoscope images
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=599324
--- Comment #3 from Tareq Al Jurf talj...@fedoraproject.org 2010-06-03
12:42:24 EDT ---
(In reply to comment #2)
Hi Tareq, here are some quick comments:
- the license seems to be GPLv2+ (according to the source headers)
- use %{version} in Source0 to simplify future package updates
- COPYING is missing in %doc
- drop empty file NEWS from %doc
$ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm
rotoscope.i686: W: name-repeated-in-summary C rotoscope
rotoscope.i686: W: spelling-error %description -l en_US rotoscoping -
arthroscopic, stroboscopic, gyroscopic
rotoscope.i686: E: zero-length /usr/share/doc/rotoscope-0.2/NEWS
rotoscope.src: W: name-repeated-in-summary C rotoscope
rotoscope.src: W: spelling-error %description -l en_US rotoscoping -
arthroscopic, stroboscopic, gyroscopic
3 packages and 0 specfiles checked; 1 errors, 4 warnings.
Thx martin,
*First warning fixed.
*Second warning could be ignored since rotoscoping is a word
http://en.wikipedia.org/wiki/Rotoscoping
*Error fixed
Spec URL:
http://taljurf.fedorapeople.org/Packages/i686/rotoscope/rotoscope.spec
SRPM URL:
http://taljurf.fedorapeople.org/Packages/i686/rotoscope/rotoscope-0.2-2.fc12.src.rpm
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 479598] Review Request: aopalliance - AOP offers a better solution to many problems than do existing technologies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=479598 --- Comment #22 from Tom spot Callaway tcall...@redhat.com 2010-06-03 12:43:31 EDT --- Well, you asked for a definition of what Public Domain means. That's what it means. It has the same meaning in Europe, except that you CANT just put works in the Public Domain in most of Europe, because those countries (notably France) do not permit copyright holders to waive their moral rights. CC-0 exists specifically because this is a problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599638] New: Review Request: perl-YAPE-Regex - Yet Another Parser/Extractor for Regular Expressions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-YAPE-Regex - Yet Another Parser/Extractor for Regular Expressions Alias: perl-YAPE-Regex https://bugzilla.redhat.com/show_bug.cgi?id=599638 Summary: Review Request: perl-YAPE-Regex - Yet Another Parser/Extractor for Regular Expressions Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/YAPE-Regex/ OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: iarn...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~iarnell/review/perl-YAPE-Regex.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-YAPE-Regex-3.04-1.fc14.src.rpm Description: This module is yet another parser and tree-builder for Perl regular expressions. It builds a tree out of a regex, but at the moment, the extent of the extraction tool for the tree is quite limited. However, the tree can be useful to extension modules. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2227764 *rt-0.10_01 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 569492] Review Request: Ailurus - Install software + Configure Linux + Study Linux skills
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=569492
Ankur Sinha sanjay.an...@gmail.com changed:
What|Removed |Added
CC||sanjay.an...@gmail.com
--- Comment #6 from Ankur Sinha sanjay.an...@gmail.com 2010-06-03 12:46:09
EDT ---
hey,
a quick look:
- use http://fedoraproject.org/wiki/Packaging/Python#Macros for the python
macros
- You don't need all the defines at the beginning. Please get rid of them? It's
just doing it twice :)
- no need for unmangled_version, it looks same as version
- prefix is not to be defined in a tag
- vendor tag is obsolete
have a look at
https://fedoraproject.org/wiki/A_Short_RPM_Tutorial#A_complete_hello.spec_file
for the tags to be used.
You should add comments rationalizing the Requires as per
https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires
- use cflags so the build section would go:
%build
CFLAGS=$RPM_OPT_FLAGS %{__python} setup.py build
- similiarly the install section would go
%{__python} setup.py install --skip-build
Please go through the fedora packaging guidelines at the above mentioned links
and then maybe we can do a complete review.
regards,
Ankur
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 592443] Review Request: antlrworks - Grammar development environment for ANTLR v3 grammars
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=592443 --- Comment #4 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-06-03 12:57:16 EDT --- Thanks for your review, and sorry for the discordance between the .spec file and the SRPM, I thought I uploaded the good SRPM for the review. It should be OK now. Here are the new .spec and SRPM with all your suggestions: Spec URL: http://melmorabity.fedorapeople.org/packages/antlrworks/antlrworks.spec SRPM URL: http://melmorabity.fedorapeople.org/packages/antlrworks/antlrworks-1.4-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598299] Review Request: systemd - A System and Session Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598299 --- Comment #12 from Lennart Poettering lpoet...@redhat.com 2010-06-03 13:23:18 EDT --- /cgroup should definitely not be owned by systemd. It has uses outside of systemd too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 467324] Review Request: mingw32-portablexdr - MinGW Windows PortableXDR XDR / RPC library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467324 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC|tcall...@redhat.com | --- Comment #28 from Tom spot Callaway tcall...@redhat.com 2010-06-03 12:36:30 EDT --- That works for me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598299] Review Request: systemd - A System and Session Manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=598299 --- Comment #13 from Adel Gadllah adel.gadl...@gmail.com 2010-06-03 13:37:29 EDT --- (In reply to comment #12) /cgroup should definitely not be owned by systemd. It has uses outside of systemd too. OK, that makes sense, filed a bug against filesystem to get it added there: https://bugzilla.redhat.com/show_bug.cgi?id=599664 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 562470] Review Request: openvas-client - Client component of Open Vulnerability Assessment (OpenVAS) Scanner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=562470 --- Comment #22 from Stjepan Gros stjepan.g...@gmail.com 2010-06-03 13:52:51 EDT --- I fixed Source0 and License tags. But rpmlint shows the following warnings: $ rpmlint openvas-client-3.0.0-7.fc13.x86_64.rpm openvas-client.x86_64: W: unstripped-binary-or-object /usr/bin/OpenVAS-Client openvas-client.x86_64: W: unstripped-binary-or-object /usr/bin/omp-cli openvas-client.x86_64: W: manual-page-warning /usr/share/man/man1/OpenVAS-Client.1.gz 243: warning: `UR' not defined openvas-client.x86_64: W: manual-page-warning /usr/share/man/man1/openvasclient-mkcert.1.gz 31: warning: `UR' not defined openvas-client.x86_64: W: manual-page-warning /usr/share/man/man1/openvasclient-mkcert.1.gz 33: warning: `UE' not defined openvas-client.x86_64: W: no-manual-page-for-binary omp-cli 1 packages and 0 specfiles checked; 0 errors, 6 warnings. I think that warnings about manual pages could be ignored, but what about unstripped binary? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 583102] Review Request: radiotray - Radio Tray is a streaming player for listening to online radios
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583102 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #18 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:04:52 EDT --- radiotray-0.5.1-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update radiotray'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/radiotray-0.5.1-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591828] Review Request: php-pecl-solr - Object oriented API to Apache Solr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591828 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:06:13 EDT --- php-pecl-solr-0.9.10-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573345] Review Request: php-pear-CAS - Central Authentication Service client library in php
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573345 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:10:35 EDT --- php-pear-CAS-1.1.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573345] Review Request: php-pear-CAS - Central Authentication Service client library in php
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573345 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-pear-CAS-1.1.1-1.fc12 |php-pear-CAS-1.1.1-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 528288] Review Request: python-blist - A faster list implementation for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528288 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:07:10 EDT --- python-blist-1.1.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590777] Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590777 --- Comment #13 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:10:56 EDT --- php-domxml-php4-php5-1.21.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590777] Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590777 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-domxml-php4-php5-1.21.1 ||-2.fc13 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591828] Review Request: php-pecl-solr - Object oriented API to Apache Solr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591828 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-pecl-solr-0.9.10-2.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 528288] Review Request: python-blist - A faster list implementation for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528288 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-blist-1.1.1-1.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573345] Review Request: php-pear-CAS - Central Authentication Service client library in php
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573345 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||php-pear-CAS-1.1.1-1.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 583102] Review Request: radiotray - Radio Tray is a streaming player for listening to online radios
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=583102 --- Comment #19 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:13:26 EDT --- radiotray-0.5.1-3.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update radiotray'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/radiotray-0.5.1-3.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 528288] Review Request: python-blist - A faster list implementation for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528288 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:11:29 EDT --- python-blist-1.1.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 528288] Review Request: python-blist - A faster list implementation for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=528288 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-blist-1.1.1-1.fc12 |python-blist-1.1.1-1.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575485] Review Request: libharu - C library for generating PDF files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575485 --- Comment #12 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:16:50 EDT --- libharu-2.1.0-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590777] Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590777 --- Comment #14 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:16:04 EDT --- php-domxml-php4-php5-1.21.1-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591828] Review Request: php-pecl-solr - Object oriented API to Apache Solr
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591828 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2010-06-03 14:16:20 EDT --- php-pecl-solr-0.9.10-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 590777] Review Request: php-domxml-php4-php5 - XML transition from PHP4 domxml to PHP5 dom module
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=590777 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|php-domxml-php4-php5-1.21.1 |php-domxml-php4-php5-1.21.1 |-2.fc13 |-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 508351] Review Request: josm - java openstreetmap editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=508351 --- Comment #46 from Cédric OLIVIER cedric.oliv...@free.fr 2010-06-03 14:45:39 EDT --- It was a little mistake in the install section. I was done an install -d 755 Source. So a 755 directory was made wrongly. It's now corrected : http://cedric.olivier.free.fr/rpms/josm-3208-2/josm-0-0.2.3208svn.fc13.src.rpm http://cedric.olivier.free.fr/rpms/josm-3208-2/josm.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 598902] Review Request: PXZ - Parallel LZMA compressor compatible with XZ
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=598902
Jussi Lehtola jussi.leht...@iki.fi changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Jussi Lehtola jussi.leht...@iki.fi 2010-06-03 14:49:18
EDT ---
This is a package review, not a merge review ;)
$ rpmlint pxz-*
pxz.x86_64: W: incoherent-version-in-changelog 4.999.9-0.1.20100603.beta
['4.999.9-0.1.beta.20100603git.fc13', '4.999.9-0.1.beta.20100603git']
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
so the change log EVR entries should be of the style
4.999.9-0.1.beta.20100603git
not
4.999.9-0.1.20100603.beta
- I abhor wildcards where they are not needed. Please change
%{_mandir}/man1/*.1*
to
%{_mandir}/man1/pxz.1*
- Please change URL to
http://jnovy.fedorapeople.org/pxz
as that's a *lot* easier to paste from the spec file.
Otherwise, my earlier comments seem to have been taken into account. One final
comment: now the compilation does not use the -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE flags. Are these not necessary on Fedora?
The final changes are cosmetic, so you can consider this package
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 529278] Review Request: eclipse-ptp - Eclipse Parallel Tools Platform
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=529278 Andrew Overholt overh...@redhat.com changed: What|Removed |Added CC||overh...@redhat.com --- Comment #13 from Andrew Overholt overh...@redhat.com 2010-06-03 14:55:31 EDT --- I'm not going to be able to get to this until Eclipse Helios is released upstream. At first glance, though, things look good. rpmlint is quite unhappy with a lot of stuff, though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=599097
Aleš Koval a...@regnet.cz changed:
What|Removed |Added
CC||a...@regnet.cz
--- Comment #4 from Aleš Koval a...@regnet.cz 2010-06-03 14:56:35 EDT ---
Hi,
provided source rpm cannot be build on x86_64 arch due this error:
error: File not found by glob: /home/als/rpmbuild/BUILDROOT
libgexiv2-0.0.90-2.fc13.x86_64/usr/lib64/*.so.*
You using correct %{_libdir} macro in spec file in files section, but there is
hardcoded $(DESTDIR)$(PREFIX)/lib path in source Makefile in install section.
Regards Als
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599709] New: Review Request: python26-greenlet - Lightweight in-process concurrent programming
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python26-greenlet - Lightweight in-process concurrent programming https://bugzilla.redhat.com/show_bug.cgi?id=599709 Summary: Review Request: python26-greenlet - Lightweight in-process concurrent programming Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ke...@tummy.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.scrye.com/~kevin/fedora/python26-greenlet/python26-greenlet.spec SRPM URL: http://www.scrye.com/~kevin/fedora/python26-greenlet/python26-greenlet-0.3.1-3.el5.src.rpm Description: The greenlet package is a spin-off of Stackless, a version of CPython that supports micro-threads called tasklets. Tasklets run pseudo-concurrently (typically in a single or a few OS-level threads) and are synchronized with data exchanges on channels. NOTE: This package is for EPEL-5's python26 stack only. See python-greenlet review at bug 580964 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599715] New: Review Request: python26-eventlet - Highly concurrent networking library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python26-eventlet - Highly concurrent networking library https://bugzilla.redhat.com/show_bug.cgi?id=599715 Summary: Review Request: python26-eventlet - Highly concurrent networking library Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ke...@tummy.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.scrye.com/~kevin/fedora/python26-eventlet/python26-eventlet.spec SRPM URL: http://www.scrye.com/~kevin/fedora/python26-eventlet/python26-eventlet-0.9.9-1.el5.src.rpm Description: Eventlet is a networking library written in Python. It achieves high scalability by using non-blocking io while at the same time retaining high programmer usability by using coroutines to make the non-blocking io operations appear blocking at the source code level. NOTE: This package is for the python26 stack in EPEL-5 only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599720] New: Review Request: Spawning26 - A HTTP server for hosting WSGI python web applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: Spawning26 - A HTTP server for hosting WSGI python web applications https://bugzilla.redhat.com/show_bug.cgi?id=599720 Summary: Review Request: Spawning26 - A HTTP server for hosting WSGI python web applications Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ke...@tummy.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.scrye.com/~kevin/fedora/Spawning26/Spawning26.spec SRPM URL: http://www.scrye.com/~kevin/fedora/Spawning26/Spawning26-0.9.3-0.rc2.5.el5.src.rpm Description: Spawning is a wsgi server which supports multiple processes, multiple threads, green threads, non-blocking HTTP io, and automatic graceful upgrading of code. NOTE: This package is intended for the python26 stack in EPEL5 only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597709] Review Request: rubygem-ncursesw - Hacked up version of ncurses gem
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=597709
Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #9 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-03
15:36:38 EDT ---
2 issues
* rpmlint issue for -debuginfo rpm related
--
rubygem-ncursesw-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/rubygem-ncursesw-1.2.4.1/usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/ncurses_wrap.c
rubygem-ncursesw-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/rubygem-ncursesw-1.2.4.1/usr/lib/ruby/gems/1.8/gems/ncursesw-1.2.4.1/panel_wrap.h
--
- To avoid this rpmlint complaint, please add below at the end
of %build:
--
pushd ./%{geminstdir}
chmod 0644 *.h *.c
popd
--
* License
- Please change the license tag on -doc subpacakge to
LGPLv2+ and LDPL
ref:
http://lists.fedoraproject.org/pipermail/legal/2010-June/001290.html
Please fix the above issue when importing this package into
Fedora CVS.
--
This package (rubygem-ncursesw) is APPROVED by mtasaka
--
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 599723] New: Review Request: pyjamas26 - A python to Javascript compiler, Widget set, Framework and Toolkit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: pyjamas26 - A python to Javascript compiler, Widget set, Framework and Toolkit https://bugzilla.redhat.com/show_bug.cgi?id=599723 Summary: Review Request: pyjamas26 - A python to Javascript compiler, Widget set, Framework and Toolkit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: ke...@tummy.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://www.scrye.com/~kevin/fedora/pyjamas26/pyjamas26.spec SRPM URL: http://www.scrye.com/~kevin/fedora/pyjamas26/pyjamas26-0.7-3.el5.src.rpm Description: Pyjamas is a python to Javascript compiler, Widget set, Framework and Toolkit for Application development that runs on Web browsers. The developer need not know anything about AJAX: all the AJAX tricks, for all major browsers, are entirely taken care of. NOTE: This is intended for the python26 stack in EPEL5 only. Its been changed to use that python stack, but is otherwise the same as the already approved pyjamas version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
