[Bug 602356] Review Request: gst123 - Command line multimedia player based on gstreamer

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602356

Randall Berry randyn3...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #4 from Randall Berry randyn3...@gmail.com 2010-06-10 02:20:29 
EDT ---
mock rawhide build errors:

checking for GSTREAMER_GTK... no
configure: error: Package requirements (gstreamer-base-0.10 gtk+-2.0
gstreamer-interfaces-0.10 gstreamer-video-0.10) were not met:
No package 'gstreamer-interfaces-0.10' found
No package 'gstreamer-video-0.10' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables GSTREAMER_GTK_CFLAGS
and GSTREAMER_GTK_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.0s5O7P (%build)
Bad exit status from /var/tmp/rpm-tmp.0s5O7P (%build)
Child returncode was: 1

mock F13 build errors:

checking for GSTREAMER_GTK... configure: error: Package requirements
(gstreamer-base-0.10 gtk+-2.0 gstreamer-interfaces-0.10 gstreamer-video-0.10)
were not met:
No package 'gstreamer-interfaces-0.10' found
No package 'gstreamer-video-0.10' found
Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.
Alternatively, you may set the environment variables GSTREAMER_GTK_CFLAGS
and GSTREAMER_GTK_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.Obhft8 (%build)
Bad exit status from /var/tmp/rpm-tmp.Obhft8 (%build)
Child returncode was: 1


Fails to build on Koji for rawhide. (same as above)
https://koji.fedoraproject.org/koji/taskinfo?taskID=2242021

Fails to build on Koji for F13. (same as above)
https://koji.fedoraproject.org/koji/taskinfo?taskID=2242028

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: sup - A console-based email client written in ruby

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #7 from Shreyank Gupta shreya...@gmail.com 2010-06-10 03:10:48 
EDT ---
Koji scratch:
---

http://koji.fedoraproject.org/koji/taskinfo?taskID=2242063

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602356] Review Request: gst123 - Command line multimedia player based on gstreamer

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602356

Randall Berry randyn3...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #6 from Randall Berry randyn3...@gmail.com 2010-06-10 04:02:05 
EDT ---

Key:

[P] Pass
[F] Fail See [n]
[-] Not applicable
[?] Questions (see comments)



[P]  MUST: rpmlint must be run on every package. The output should be
 posted in the review.

 gst123.i686: W: spelling-error Summary(en_US) gstreamer
 gst123.i686: W: spelling-error %description -l en_US gst
 gst123.i686: W: spelling-error %description -l en_US ogg
 gst123.i686: W: spelling-error %description -l en_US gstreamer
 gst123.src: W: spelling-error Summary(en_US) gstreamer
 gst123.src: W: spelling-error %description -l en_US gst
 gst123.src: W: spelling-error %description -l en_US ogg
 gst123.src: W: spelling-error %description -l en_US gstreamer
 gst123-debuginfo.i686: W: spelling-error Summary(en_US) gst
 gst123-debuginfo.i686: W: spelling-error %description -l en_US gst

 3 packages and 1 specfiles checked; 0 errors, 10 warnings.

 Ignoring warnings spelling is intentional.

[P]  MUST: The package must be named according to the Package Naming
 Guidelines.

[P]  MUST: The spec file name must match the base package %{name},
 in the format %{name}.spec unless your package has an exemption.

[P]  MUST: The package must meet the Packaging Guidelines.

[P]  MUST: The package must be licensed with a Fedora approved
 license and meet the Licensing Guidelines.

 LGPLv2

[P]  MUST: The License field in the package spec file must match
 the actual license.

 LGPLv2

[P]  MUST: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of
 the license(s) for the package must be included in %doc.

[P]  MUST: The spec file must be written in American English.

[P]  MUST: The spec file for the package MUST be legible.

[P]  MUST: The sources used to build the package must match the upstream
 source, as provided in the spec URL. Reviewers should use md5sum for
 this task. If no upstream URL can be specified for this package,
 please see the Source URL Guidelines for how to deal with this.

 325431884db1a913ccfed19e95d8a59d

[P]  MUST: The package MUST successfully compile and build into binary
 rpms on at least one primary architecture.

[-]  MUST: If the package does not successfully compile, build or work on
 an architecture, then those architectures should be listed in the spec
 in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug
 filed in bugzilla, describing the reason that the package does not
 compile/build/work on that architecture. The bug number MUST be
 placed in a comment, next to the corresponding ExcludeArch line.

[P]  MUST: All build dependencies must be listed in BuildRequires,
 except for any that are listed in the exceptions section of the
 Packaging Guidelines ; inclusion of those as BuildRequires is
 optional. Apply common sense.

[-]  MUST: The spec file MUST handle locales properly. This is done by
 using the %find_lang macro. Using %{_datadir}/locale/[ ] is strictly
 forbidden.

[-]  MUST: Every binary RPM package (or sub package) which stores shared
 library files (not just symlinks) in any of the dynamic linker's
 default paths, must call ldconfig in %post and %postun.

[P]  MUST: If the package is designed to be relocatable, the packager
 must state this fact in the request for review, along with the
 rationalization for relocation of that specific package.
 Without this, use of Prefix: /usr is considered a blocker.

[P]  MUST: A package must own all directories that it creates. If it does not
 create a directory that it uses, then it should require a package which
 does create that directory. Refer to the Guidelines for examples.

[P]  MUST: A package must not contain any duplicate files in the %files
 listing.

[P]  MUST: Permissions on files must be set properly. Executables should
 be set with executable permissions, for example. Every %files section
 must include a %defattr(...) line.

[P]  MUST: Each package must have a %clean section, which contains
 rm -rf %{buildroot} ( or $RPM_BUILD_ROOT ).

[P]  MUST: Each package must consistently use macros, as described in the
 macros section of Packaging Guidelines.

[P]  MUST: The package must contain code, or permissible content.
 This is described in detail in the code vs. content section
 of Packaging Guidelines.


[Bug 595551] Review Request: ibus-table-mathwriter - ibus-table-mathwriter provides input method for writing Unicode Math symbols

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595551

Naveen Kumar nku...@redhat.com changed:

   What|Removed |Added

   Flag|needinfo?(nku...@redhat.com |
   |)   |

--- Comment #2 from Naveen Kumar nku...@redhat.com 2010-06-10 04:27:23 EDT ---
(In reply to comment #1)
 Hey Naveen,
 
 As this is a GPLv3 licensed table, how about include that into
 ibus-table-others?
 
 http://github.com/kaio/ibus-table-others/
 
 I could add you commit permissions to the repository and pkgdb (once that is
 approved for CVS).

Hi Kaio,

Sorry for replying late as I was on a leave for some time. I do not have any
issues with adding it (ibus-table-mathwriter) to ibus-table-others. But I would
need access (checkout  commit) to this table as the work is not fully complete
yet. 

Also there is also something that I would like to add, that I might write an
engine for mathematical input method using ibus API's in near future. In that
case I would like you to suggest me the best possible course whether to merge
it with ibus-table-others or keep it as a separate package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602356] Review Request: gst123 - Command line multimedia player based on gstreamer

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602356

--- Comment #7 from Siddhesh Poyarekar spoya...@redhat.com 2010-06-10 
04:34:37 EDT ---
Thanks, will request a cvs module now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602356] Review Request: gst123 - Command line multimedia player based on gstreamer

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602356

Siddhesh Poyarekar spoya...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Siddhesh Poyarekar spoya...@redhat.com 2010-06-10 
04:37:12 EDT ---
New Package CVS Request
===
Package Name: gst123
Short Description: Command line multimedia player based on gstreamer
Owners: siddhesh
Branches: F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602574] New: Review Request: patchelf - a utility for patching ELF binaries

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: patchelf - a utility for patching ELF binaries

https://bugzilla.redhat.com/show_bug.cgi?id=602574

   Summary: Review Request: patchelf - a utility for patching ELF
binaries
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jer...@jeremysanders.net
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://barmag.net/tmp/patchelf.spec
SRPM URL: http://barmag.net/tmp/patchelf-0.5-2.fc12.src.rpm
Description: PatchELF is a simple utility for modifying existing ELF
executables
and libraries.  It can change the dynamic loader (ELF interpreter)
of executables and change the RPATH of executables and libraries.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484598] Review Request: grin - Grep-like tool for source code

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484598

--- Comment #9 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info 
2010-06-10 04:46:29 EDT ---
I built it on El5 and El6 it seams no problem there. If you do not argue, I can
co-maintain it for epel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 573932] Review Request: perl-IO-Compress - IO::Compress Perl module

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573932

--- Comment #20 from Paul Howarth p...@city-fan.org 2010-06-10 04:49:43 EDT 
---
Marcela, can you build and push the F-13 version now? It'll satisfy the broken
dependency on IO::Uncompress::Bunzip2 for cpanspec.

Scratch build is now working:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2242148

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 595551] Review Request: ibus-table-mathwriter - ibus-table-mathwriter provides input method for writing Unicode Math symbols

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595551

--- Comment #3 from Chen Lei supercyp...@gmail.com 2010-06-10 04:55:09 EDT ---

 
 Also there is also something that I would like to add, that I might write an
 engine for mathematical input method using ibus API's in near future. In that
 case I would like you to suggest me the best possible course whether to merge
 it with ibus-table-others or keep it as a separate package.

If you want to write an new engine for ibus, then ibus-table-mathwriter seems
not a proper name for this new engine. You may need another name for this
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #7 from Adam Tkac at...@redhat.com 2010-06-10 05:02:35 EDT ---
(In reply to comment #6)
 For packages that are not usually pulled in by using the package name as the
 dependency such as library only packages (which are pulled in through library
 soname depenencies), there's usually no need to add the Provides. Note however
 that the -devel subpackages of lib packages are pulled in as build 
 dependencies
 using the package name, so adding the Provides is often appropriate there. 
 
 So for libjpeg-turbo and libjpeg-turbo-tools provides are not needed. Upgrade
 path is not related to provides at all.

Your analysis seems valid for me, I modified the obsoletes/provides as you
suggested.

New spec + SRPM:
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo.spec
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo-0.0.93-3.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 595551] Review Request: ibus-table-mathwriter - ibus-table-mathwriter provides input method for writing Unicode Math symbols

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595551

--- Comment #4 from Naveen Kumar nku...@redhat.com 2010-06-10 05:10:17 EDT ---
(In reply to comment #3)
  
  Also there is also something that I would like to add, that I might write an
  engine for mathematical input method using ibus API's in near future. In 
  that
  case I would like you to suggest me the best possible course whether to 
  merge
  it with ibus-table-others or keep it as a separate package.
 
 If you want to write an new engine for ibus, then ibus-table-mathwriter seems
 not a proper name for this new engine. You may need another name for this
 package.

Yep, I think for the time being let us move it to ibus-table-others as I am not
certain of writing it now. I will package it with different name then, because
then it would be more than ibus-table-*  probably the behaviour  table format
may also not be the same.

@kaio Please direct me with the next step.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

--- Comment #1 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
05:14:15 EDT ---
[mru...@mrungexp SPECS]$ rpmlint
../RPMS/noarch/perl-IPC-signal-1.00-1.fc13.noarch.rpm
../SRPMS/perl-IPC-signal-1.00-1.fc13.src.rpm perl-IPC-signal.spec 
perl-IPC-signal.noarch: W: spelling-error %description -l en_US versa - avers,
verse, verso
perl-IPC-signal.src: W: spelling-error %description -l en_US versa - avers,
verse, verso
2 packages and 1 specfiles checked; 0 errors, 2 warnings.


I think, vice versa is correct, the hint to change versa to something else is
wrong.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] New: Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-IPC-signal - Utility functions dealing with 
signals

https://bugzilla.redhat.com/show_bug.cgi?id=602587

   Summary: Review Request: perl-IPC-signal - Utility functions
dealing with signals
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mru...@matthias-runge.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.matthias-runge.de/fedora/perl-IPC-signal.spec
SRPM URL:
http://www.matthias-runge.de/fedora/perl-IPC-signal-1.00-1.fc13.src.rpm
Description: 
This Perl module contains utility functions for dealing with signals.
Currently these are just translating between signal names and signal
numbers and vice versa.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601577] Review Request: liblockfile - This library implements a number of functions found in -lmail on SysV systems

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Depends on||602587

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Blocks||589867

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Depends on||602587

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Blocks||601577

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #9 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
05:22:09 EDT ---
I see, it looks like much work to review logcheck or it's dependencies.
Luckily those dependants are really small and any help is greately appreciated.

Thanks anyway!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589482] Review Request: perl-IO-Compress-Lzma - Read and write lzma compressed data

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589482

--- Comment #5 from Paul Howarth p...@city-fan.org 2010-06-10 05:28:02 EDT ---
Built for Rawhide in dist-f14-perltest; F-13 build awaiting perl-IO-Compress
2.0.27 (Bug #573932).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602597] New: Review Request: perl-Package-Stash - Routines for manipulating stashes

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Package-Stash - Routines for manipulating stashes

https://bugzilla.redhat.com/show_bug.cgi?id=602597

   Summary: Review Request: perl-Package-Stash - Routines for
manipulating stashes
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: p...@city-fan.org
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Package-Stash/branches/fedora/perl-Package-Stash.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Package-Stash/perl-Package-Stash-0.03-1.fc14.src.rpm
Description:

Manipulating stashes (Perl's symbol tables) is occasionally necessary, but
incredibly messy, and easy to get wrong. This module hides all of that behind
a simple API.

This package is needed for Class::MOP 1.03.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602598] Review Request: perl-libproc-waitstat - Interpret and act on wait() status values

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602598

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Depends on||602587

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Blocks||602598

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602598] New: Review Request: perl-libproc-waitstat - Interpret and act on wait() status values

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-libproc-waitstat - Interpret and act on wait() 
status values

https://bugzilla.redhat.com/show_bug.cgi?id=602598

   Summary: Review Request: perl-libproc-waitstat - Interpret and
act on wait() status values
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mru...@matthias-runge.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.matthias-runge.de/fedora/perl-libproc-waitstat.spec
SRPM URL:
http://www.matthias-runge.de/fedora/perl-libproc-waitstat-1.00-1.fc13.src.rpm
Description: This module contains functions for interpreting and acting on wait
status values.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602598] Review Request: perl-libproc-waitstat - Interpret and act on wait() status values

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602598

--- Comment #1 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
05:38:40 EDT ---
[mru...@mrungexp SPECS]$ rpmlint
../SRPMS/perl-libproc-waitstat-1.00-1.fc13.src.rpm
../RPMS/noarch/perl-libproc-waitstat-1.00-1.fc13.noarch.rpm
perl-libproc-waitstat.spec
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #10 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
05:41:45 EDT ---
I've submitted all dependand packages for review, in total 5 dependant
packages. As I already wrote in #c9 , those are really small and any help is
grateful taken

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599316] Review Request: input-pad - Input Pad

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599316

--- Comment #8 from Parag AN(पराग) panem...@gmail.com 2010-06-10 05:44:42 EDT 
---

Suggestions:
1) Please add more specific words of summary for this package. Like you can add
An on-screen input pad used to input symbols easily.


2) Before building in Fedora remove following un-necessary lines from SPEC
Requires:  glib2= %glib2_version
Requires:  gtk2
Requires:  libX11
Requires:  libxkbfile
Requires:  libxklavier  = %libxklavier_version
Requires:  libxml2  = %libxml2_version

3) You can remove redundant BuildRequires
BuildRequires:  glib2-devel = %glib2_version
BuildRequires:  libX11-devel
as gtk2-devel will install them.
However, I see gtk2-devel specifies glib2 version 2.23.6 and you specified 2.8

4) for have_python_devel, you should be using macros
%if ! (0%{?fedora}  12 || 0%{?rhel}  5)
%{!?python_sitearch: %global python_sitearch %(%{__python} -c from
distutils.sysconfig import get_python_lib; print(get_python_lib(1)))}
%endif

5) You should actually use following in %build to preserve upstream file's
timestamps. Not mandatory by reviewguidelines but suggested a good fix by
packaging guidelines.

make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p

6) Make sure each change,if no new upstream version used then you bump the
release and provide new SPEC and SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #8 from Chen Lei supercyp...@gmail.com 2010-06-10 05:48:33 EDT ---
Mock building for libjpeg-turbo fails on ppc/ppc64, since libjpeg is a critical
path package in fedora, I think it should be fixed and build cleanly on most
secondary architectures.


See http://koji.fedoraproject.org/koji/taskinfo?taskID=2242161

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #46 from Paul Howarth p...@city-fan.org 2010-06-10 05:46:44 EDT 
---
(In reply to comment #45)
 I can't see this message in rawhide. Originally I planned this feature for
 rawhide.
 
 I will check later with F12 for curiosity.

I see the same thing on F-13 too. And it turns up in logwatch reports as well:

 - sendmail Begin (detail=3)  



 SENDMAIL CONFIGURATION
 --

 Warning: STARTTLS file errors:
 CRLFile missing

 SASL database Errors:
In file /usr/lib64/sasl2/Sendmail.conf:
   No such file or directory: 2 Time(s)
...

Of course it's not a problem if it doesn't happen on Rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484598] Review Request: grin - Grep-like tool for source code

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484598

--- Comment #10 from Terje Røsten terje...@phys.ntnu.no 2010-06-10 05:51:59 
EDT ---
Great, thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

 CC||p...@city-fan.org
 AssignedTo|nob...@fedoraproject.org|p...@city-fan.org
   Flag||fedora-review?

--- Comment #2 from Paul Howarth p...@city-fan.org 2010-06-10 06:03:22 EDT ---
A few quick comments on the spec to start with:

The README has the usual license statement:
 All rights reserved.  This program is free software; you can
  redistribute it and/or modify it under the same terms as Perl
  itself.
That makes the license GPL+ or Artistic, not Artistic 2.0.

You can drop the boilerplate comments from the spec template, and should take
notice of them too: this is a noarch package so including
`OPTIMIZE=$RPM_OPT_FLAGS' is redundant, as is the `find' of empty `.bs'
files.

Use an upstream release location for Source0, not a copy from another
downstream distribution's ftp server. I suggest one of these:
http://www.cpan.org/modules/by-module/IPC/IPC-Signal-%{version}.tar.gz
http://www.cpan.org/modules/by-module/IPC/ROSCH/IPC-Signal-%{version}.tar.gz
http://search.cpan.org/CPAN/authors/id/R/RO/ROSCH/IPC-Signal-%{version}.tar.gz

I would be more specific with the %files list; rather than:
%{perl_vendorlib}/*
%{_mandir}/man3/*.3*
I would have:
%{perl_vendorlib}/IPC/
%{_mandir}/man3/IPC::Signal.3pm*
This form make it easier to spot significant changes in the package's contents
in any future versions but it's not a blocker - your original format is still
acceptable if that's what you prefer.

Include Changes and README in %doc. The latter is particularly important as it
contains the terms under which the package is licensed.

I agree with you about the rpmlint complaint.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

 CC||p...@city-fan.org

--- Comment #11 from Paul Howarth p...@city-fan.org 2010-06-10 06:19:45 EDT 
---
(In reply to comment #2)
 no need to list %dir %{_datadir}/logtail, just %{_datadir}/logtail/* is enough

Not quite. You actually need:

%{_datadir}/logtail/

This includes the directory and its contents. Using just %{_datadir}/logtail/*
would mean that the package did not own the directory itself, which would be
wrong since none of the package's dependencies own it either.

Similarly you should add:
%dir %{_sysconfdir}/%{name}/
for ownership of this directory. The %dir is needed here because you want to
mark the contents of the directory as %config(noreplace).

 replace
 %{_sbindir}/logcheck
 %{_sbindir}/logtail
 %{_sbindir}/logtail2
 
 with %{_sbindir}/*

That's a matter of style and I would personally prefer the original form.

I wouldn't use logcheck as the default group in %defattr as it will make it
the default group for everything, including the binaries, documentation, cron
scripts etc., which is probably not what you want.

I would have your package create and own the /var/lib/logcheck directory rather
than having useradd create it in %pre, so that the directory gets removed if
the package is removed from the system.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

--- Comment #3 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
06:25:32 EDT ---
Thank you for your quick comments. Obviously, you're right, I changed the spec,
as you suggested.

Updated versions are under
Spec URL: http://www.matthias-runge.de/fedora/perl-IPC-signal.spec
SRPM URL:
http://www.matthias-runge.de/fedora/perl-IPC-signal-1.00-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

--- Comment #4 from Paul Howarth p...@city-fan.org 2010-06-10 06:35:04 EDT ---
You changed the URL tag (which was OK) instead of the Source0 tag (which
wasn't), and the comment about possibly using Module::Build is still there...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #9 from Adam Tkac at...@redhat.com 2010-06-10 06:43:42 EDT ---
(In reply to comment #8)
 Mock building for libjpeg-turbo fails on ppc/ppc64, since libjpeg is a 
 critical
 path package in fedora, I think it should be fixed and build cleanly on most
 secondary architectures.

Seems I was dazzled by performance improvement on x86  x64 and I forgot to
test SRPM on secondary archs :)

Following SRPM should be fine:
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo.spec
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo-0.0.93-4.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 573932] Review Request: perl-IO-Compress - IO::Compress Perl module

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573932

--- Comment #21 from Fedora Update System upda...@fedoraproject.org 
2010-06-10 06:41:54 EDT ---
perl-IO-Compress-2.027-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-IO-Compress-2.027-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

--- Comment #5 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
06:50:51 EDT ---
fixed.

Updated versions are under
Spec URL: http://www.matthias-runge.de/fedora/perl-IPC-signal.spec
SRPM URL:
http://www.matthias-runge.de/fedora/perl-IPC-signal-1.00-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 573932] Review Request: perl-IO-Compress - IO::Compress Perl module

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573932

--- Comment #22 from Marcela Mašláňová mmasl...@redhat.com 2010-06-10 
06:51:10 EDT ---
(In reply to comment #20)
 Marcela, can you build and push the F-13 version now? It'll satisfy the broken
 dependency on IO::Uncompress::Bunzip2 for cpanspec.
 
 Scratch build is now working:
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2242148

Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

Michel Alexandre Salim michael.silva...@gmail.com changed:

   What|Removed |Added

 CC||michael.silva...@gmail.com

--- Comment #10 from Michel Alexandre Salim michael.silva...@gmail.com 
2010-06-10 06:53:57 EDT ---
Chen Lei, will you be doing the package review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 595551] Review Request: ibus-table-mathwriter - ibus-table-mathwriter provides input method for writing Unicode Math symbols

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595551

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

  Status Whiteboard||NotReady

--- Comment #5 from Jens Petersen peter...@redhat.com 2010-06-10 07:11:27 EDT 
---
In that case probably you could close this bug or
reassign it to ibus-table-other to track the progress.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #12 from Matthias Runge mru...@matthias-runge.de 2010-06-10 
07:12:40 EDT ---

 %{_datadir}/logtail/

That suits me better.
 

 
 I wouldn't use logcheck as the default group in %defattr as it will make it
 the default group for everything, including the binaries, documentation, cron
 scripts etc., which is probably not what you want.
 
 I would have your package create and own the /var/lib/logcheck directory 
 rather
 than having useradd create it in %pre, so that the directory gets removed if
 the package is removed from the system.

That's a little difficult. First of all, I fully agree with you, but what
happens with the logcheck-user when the package is removed. Created users
should be left on the system, afaik. When the user is left, why remove his home
dir?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #48 from Paul Howarth p...@city-fan.org 2010-06-10 07:19:36 EDT 
---
It's logged in /var/log/maillog at daemon startup:

Jun 10 10:44:17 roary sendmail[18035]: gethostbyaddr(192.168.122.1) failed: 1
Jun 10 10:44:17 roary sendmail[18035]: error:
safesasl(/usr/lib64/sasl2/Sendmail.conf) failed: No such file or directory
Jun 10 10:44:17 roary sendmail[18036]: starting daemon (8.14.4):
smtp+queue...@01:00:00
Jun 10 10:44:17 roary sendmail[18036]: STARTTLS: ServerCertFile missing
Jun 10 10:44:17 roary sendmail[18036]: started as: /usr/sbin/sendmail -bd -q1h
Jun 10 10:44:17 roary sm-msp-queue[18045]: starting daemon (8.14.4):
queue...@01:00:00

The SASL config still works for me (at least using CRAM-MD5 auth).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599316] Review Request: input-pad - Input Pad

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599316

--- Comment #9 from fujiwara tfuji...@redhat.com 2010-06-10 07:32:59 EDT ---
Revised spec file:
http://github.com/fujiwarat/input-pad/commit/188f838f1ce0a8beb259c9df59dcd92b7e5a8eb4

Spec URL:
http://fujiwara.fedorapeople.org/ibus/input-pad/input-pad.spec
SRPM URL:
http://fujiwara.fedorapeople.org/ibus/input-pad/srpms/input-pad-0.1.0.20100608-2.fc13.src.rpm
 

(In reply to comment #8)
 1) Please add more specific words of summary for this package. Like you can 
 add
 An on-screen input pad used to input symbols easily.

I accept this in this time since other issues are also reported.

 2) Before building in Fedora remove following un-necessary lines from SPEC
 Requires:  glib2= %glib2_version
 Requires:  gtk2
 Requires:  libX11
 Requires:  libxkbfile
 Requires:  libxklavier  = %libxklavier_version
 Requires:  libxml2  = %libxml2_version
 

I didn't notice Linux rpmbuild has the feature of auto-dependency.
I accept this useful suggestion now.
Thanks.

 5) You should actually use following in %build to preserve upstream file's
 timestamps. Not mandatory by reviewguidelines but suggested a good fix by
 packaging guidelines.
 
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p

Cool. -p is useful.

 6) Make sure each change,if no new upstream version used then you bump the
 release and provide new SPEC and SRPM.

OK, I will remember the Fedora policy.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #47 from Jaroslav Škarvada jskar...@redhat.com 2010-06-10 
07:14:41 EDT ---
Interesting, thank you for pointing this out, I will look on it.

I tested only on rawhide. I also tested the SASL auth with various SASL configs
and it worked as expected. What I did (on rawhide):

# /etc/init.d/sendmail stop
# /etc/init.d/sendmail start
# echo test | sendmail root
# sync
# logwatch --range today --detail 10 --print --service All
# grep -r sasl2 /var/log/*

And I can not see this error on rawhide. I am also going to check the F12/F13.
Please can you point me directly to place where this error is logged? And also
for the F12/F13 is the SASL config working for you even in case of this error?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602279] Review Request: libraw - Library for reading RAW files obtained from digital photo cameras

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602279

--- Comment #1 from Siddhesh Poyarekar spoya...@redhat.com 2010-06-10 
07:41:10 EDT ---
Modified build to disable lcms and openmp support. Upstream does not enable
them by default and this can break applications building against libraw, since
they need extra linker flags then. Updated spec and srpm:

http://siddhesh.fedorapeople.org/libraw/0.9.1-2/libraw.spec
http://siddhesh.fedorapeople.org/libraw/0.9.1-2/libraw-0.9.1-2.fc14.src.rpm

And a correction to the above comment: shotwell git trunk (future 0.6 release)
requires libraw, not the 0.5 release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588194] Review Request: quickly - Command line tools to ease the creation of a new project

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588194

--- Comment #7 from Ankur Sinha sanjay.an...@gmail.com 2010-06-10 07:48:56 
EDT ---
(In reply to comment #6)
 Thanks for the review Ankur
 
 Please use the following koji build rpm,since package needs
 python-distutils-extra = 2.18
 
 http://kojipkgs.fedoraproject.org/packages/python-distutils-extra/2.19/1.fc14/noarch/python-distutils-extra-2.19-1.fc14.noarch.rpm
 
 Updated 
 
 spec : http://github.com/downloads/matriux/fedora/quickly.spec
 srpm : 
 http://github.com/downloads/matriux/fedora/quickly-0.4.2-3.fc12.src.rpm


hi,

It doesn't build in mock here. Have you tried building it in mock?

Error log is attached.( Failure is not because of a wrong
python-distutils-extra )

regards,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #13 from Paul Howarth p...@city-fan.org 2010-06-10 07:47:48 EDT 
---
(In reply to comment #12)
  I wouldn't use logcheck as the default group in %defattr as it will make 
  it
  the default group for everything, including the binaries, documentation, 
  cron
  scripts etc., which is probably not what you want.
  
  I would have your package create and own the /var/lib/logcheck directory 
  rather
  than having useradd create it in %pre, so that the directory gets removed if
  the package is removed from the system.
 
 That's a little difficult. First of all, I fully agree with you, but what
 happens with the logcheck-user when the package is removed. Created users
 should be left on the system, afaik. When the user is left, why remove his 
 home
 dir?

The user would be left on the system, but wouldn't be actively used for
anything - it would just own any files that may have been left around from the
running of the program - if any. The absence of a home directory wouldn't
matter for that purpose.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588194] Review Request: quickly - Command line tools to ease the creation of a new project

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588194

--- Comment #8 from Ankur Sinha sanjay.an...@gmail.com 2010-06-10 07:49:58 
EDT ---
Created an attachment (id=422879)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=422879)
build log for failed build

config was fedora-rawhide-i386

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602659] New: Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP client services for test cases

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP 
client services for test cases

https://bugzilla.redhat.com/show_bug.cgi?id=602659

   Summary: Review Request: perl-Test-POE-Client-TCP - POE
Component providing TCP client services for test cases
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://ppisar.fedorapeople.org/perl-Test-POE-Client-TCP/perl-Test-POE-Client-TCP.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-Test-POE-Client-TCP/perl-Test-POE-Client-TCP-1.08-1.fc13.src.rpm
Description:
Test::POE::Client::TCP is a POE component that provides a TCP client
framework for inclusion in client component test cases, instead of having
to roll your own.

This new package is required for further versions of
perl-POE-Component-Server-SimpleHTTP.

This package compiles and tests cleanly only of Fedora 14 where required
dependencies exist
(http://koji.fedoraproject.org/koji/taskinfo?taskID=2242312). This package is
not intended to emerge in F-13 or lower distributions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602659] Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP client services for test cases

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602659

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Blocks||602616

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602659] Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP client services for test cases

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602659

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

URL||http://search.cpan.org/dist
   ||/Test-POE-Client-TCP/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598299] Review Request: systemd - A System and Session Manager

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

Richard Hughes rhug...@redhat.com changed:

   What|Removed |Added

 CC||rhug...@redhat.com

--- Comment #15 from Richard Hughes rhug...@redhat.com 2010-06-10 08:55:31 
EDT ---
Rahul, by putting --with-rootdir=/usr the systemd binary gets put in /usr/bin
rather than /bin -- I'm pretty sure something as low level as an init system
deserves to be in /bin. :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590832] Review Request: iapetal - A 2D space rescue game

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590832

Jon Ciesla l...@jcomserv.net changed:

   What|Removed |Added

   Flag|needinfo?(l...@jcomserv.net |
   |)   |

--- Comment #6 from Jon Ciesla l...@jcomserv.net 2010-06-10 09:03:18 EDT ---
http://zanoni.jcomserv.net/fedora/iapetal/iapetal-1.0-3.fc13.src.rpm

I sorta forgot that I upgraded to f13. :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602659] Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP client services for test cases

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602659

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Blocks||602674

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602659] Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP client services for test cases

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602659

Yanko Kaneti yan...@declera.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||yan...@declera.com
 AssignedTo|nob...@fedoraproject.org|yan...@declera.com
   Flag||fedora-review+

--- Comment #1 from Yanko Kaneti yan...@declera.com 2010-06-10 09:22:10 EDT 
---
Source matches
License matches

Builds fine. rpmlint is silent.
No crazy provides or requires.
Owns everything it should.
Necessary docs included.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 253249] Review Request: classads - a powerful and flexible, semi-structured representation of data

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=253249

Steve Traylen steve.tray...@cern.ch changed:

   What|Removed |Added

 CC||steve.tray...@cern.ch
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #11 from Steve Traylen steve.tray...@cern.ch 2010-06-10 09:24:34 
EDT ---
Package Change Request
==
Package Name: classads
New Branches: EL-4 EL-5 EL-6
Owners: matt stevetraylen

I've been in touch with Matt in Bug #599144 and he is happy to co-maintain 
classads with me in EPEL.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583531] Review Request: mozilla-firetray - A system tray addon for mozilla

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583531

--- Comment #10 from Hicham HAOUARI hicham.haou...@gmail.com 2010-06-10 
09:31:25 EDT ---
i can silence the dangling symlinks warnings by explicity providing the
required targets in core, and requiring them in the other subpackages, but i
don't know if it is worth it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581619] Review Request: mlterm - Multi Lingual TERMinal emulator on X

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581619

--- Comment #17 from Hicham HAOUARI hicham.haou...@gmail.com 2010-06-10 
09:38:59 EDT ---
By the way, why did you prefer imlib over gdk-pixbuf ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581619] Review Request: mlterm - Multi Lingual TERMinal emulator on X

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581619

--- Comment #16 from Hicham HAOUARI hicham.haou...@gmail.com 2010-06-10 
09:38:00 EDT ---
(In reply to comment #14)
  1) Please provide a direct link to the spec everytime you update the 
  package.
 
 no problem, I'll do that
 
  2)The %{_libexecdir}/* should be replaced IMHO with the corresponding files 
  separately.
 
 is there a reason for that ? they are files that might change from version to
 another
that discards the whole point of explicitely specifying files in the %files
section, please fix that
 
  3)You forgot to update the changelog.
 ok
 
  4)BuildRequires : gtk+-devel, better put gtk2-devel
 
 we can't do that, the config window of mlterm is a gtk1 application
 

The build i have done on comment 14 is not using gtk1

  5)Patch should be upstreamed ( put a link to the corresponding upstream
 bugzilla bug report )
 
 if you are referring to your patch in #11 then it just -lx11 to build option,
 it could be missed because of many reasons, and BTW it used to build in F11 
 and
 F12 without this patch, so if the upstream is using fedora13 he won't be
 convinced that there is any problem

All sane upstreams projects will understand the importance of the change in
Fedora policy about dso linking

 
 
  6)As mentioned above, change sed -i -re 's/#ifdef  HAVE_ISASTREAM/#ifdef
 HAVE_STROPTS_H/' kiklib/src/kik_pty_streams.c to a patch and upstream it. 
 Same
 for fribidi-config
 
 the fribidi-config patch is no longer needed that's why it's commented (it was
 needed because the upstream used to use fribidi-config instead of pkg-config
 which is in fedora)
 
 and the sed change is needed to build it, try building without it.
 the function it uses isastream is from stropts.h I guess both are not in
 fedora so HAVE_STROPTS_H is equivalent to HAVE_ISASTREAM
 
 http://www.opengroup.org/onlinepubs/009695399/functions/isastream.html
Then the code should check for either one of them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602659] Review Request: perl-Test-POE-Client-TCP - POE Component providing TCP client services for test cases

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602659

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Petr Pisar ppi...@redhat.com 2010-06-10 09:53:27 EDT ---
New Package CVS Request
===
Package Name: perl-Test-POE-Client-TCP
Short Description: POE Component providing TCP client services for test
Owners: ppisar mmaslano
Branches: 
InitialCC: perl-sig

Only devel (F-14) branch is enough. There is no plan to add this package to
older distributions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602703] New: Review Request: HTTP-Parser - Parse HTTP/1.1 request into HTTP::Request/Response object

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: HTTP-Parser - Parse HTTP/1.1 request into 
HTTP::Request/Response object

https://bugzilla.redhat.com/show_bug.cgi?id=602703

   Summary: Review Request: HTTP-Parser - Parse HTTP/1.1 request
into HTTP::Request/Response object
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://ppisar.fedorapeople.org/perl-HTTP-Parser/perl-HTTP-Parser.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-HTTP-Parser/perl-HTTP-Parser-0.04-1.fc13.src.rpm
Description:
This is an HTTP request parser. It takes chunks of text as received and
returns a 'hint' as to what is required, or returns the HTTP::Request when
a complete request has been read. HTTP/1.1 chunking is supported. It dies
if it finds an error.

Notice to reviewer regarding spelling: rpmlint does not know `chunking',
despite it's regular English word.

This spec file builds on F14--12.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602703] Review Request: HTTP-Parser - Parse HTTP/1.1 request into HTTP::Request/Response object

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602703

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Blocks||602674

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602703] Review Request: HTTP-Parser - Parse HTTP/1.1 request into HTTP::Request/Response object

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602703

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

URL||http://search.cpan.org/dist
   ||/HTTP-Parser/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598299] Review Request: systemd - A System and Session Manager

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

David Hollis dhol...@davehollis.com changed:

   What|Removed |Added

 CC||dhol...@davehollis.com

--- Comment #16 from David Hollis dhol...@davehollis.com 2010-06-10 10:27:01 
EDT ---
I encountered a few errors while trying to build this:
1) It's not 2009 any more (git_date)
2) The x86_64 lib workaround didn't seem to fly, I workaround it by
(re)defining _libdir to /lib unconditionally
3) /etc/init.d didn't exist so it bombed in %install
4) Redefining _bindir to /bin and clearing the --with-rootdir= part managed to
get the binaries in the right place

I'll attach a diff of the spec that I got working

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598299] Review Request: systemd - A System and Session Manager

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

--- Comment #17 from David Hollis dhol...@davehollis.com 2010-06-10 10:28:15 
EDT ---
Created an attachment (id=422929)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=422929)
Patch to get the package to build on a standard F13 x86_64 system

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598299] Review Request: systemd - A System and Session Manager

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

Jeffrey C. Ollie j...@ocjtech.us changed:

   What|Removed |Added

 CC||j...@ocjtech.us

--- Comment #18 from Jeffrey C. Ollie j...@ocjtech.us 2010-06-10 10:33:03 EDT 
---
I just tried the scratch build mentioned in comment 14 by installing the
systemd RPM on my rawhide box and then naïvely rebooting and adding
init=/usr/bin/systemd to the kernel command line.  Right after mounting the
cgroup file systems it looked like systemd segfaulted and then I got a kernel
panic.  Is there some other magic that I need to do to try out systemd or am I
encountering an actual bug.  What's the best way to debug this problem other
than posting screenshots of the kernel panic?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602703] Review Request: perl-HTTP-Parser - Parse HTTP/1.1 request into HTTP::Request/Response object

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602703

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

 CC||p...@city-fan.org
Summary|Review Request: HTTP-Parser |Review Request:
   |- Parse HTTP/1.1 request|perl-HTTP-Parser - Parse
   |into HTTP::Request/Response |HTTP/1.1 request into
   |object  |HTTP::Request/Response
   ||object

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Flag|fedora-review?  |fedora-review+

--- Comment #6 from Paul Howarth p...@city-fan.org 2010-06-10 11:10:19 EDT ---
Review Checklist:
- rpmlint OK
- package and spec file naming OK
- package meets guidelines
- license is same as perl, whcih is OK for Fedora
- package license tag is correct: GPL+ or Artistic
- no license text file to include
- spec file is legible and written in English
- source matches upstream
- package builds OK in mock for rawhide x86_64
- buildreqs OK
- no locale data to include
- no shared or static libraries included
- package not intended to be relocatable
- directory owndership is OK
- no duplicate files
- %defattr(...) present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no subpackages
- not a GUI app so no desktop file needed
- filenames are all ASCII
- no scriptlets
- requires and provides are OK
- manpage provided

Source SHA-256 hashes:
7c21f9c8c2d0c0f0f0f46e77de7c3d879dd562668ddf0525875c38cef2076fd0  Upstream
IPC-Signal-1.00.tar.gz
7c21f9c8c2d0c0f0f0f46e77de7c3d879dd562668ddf0525875c38cef2076fd0  Package 
IPC-Signal-1.00.tar.gz

Test suite:
$ make test
PERL_DL_NONLAZY=1 /usr/bin/perl -MExtUtils::Command::MM -e test_harness(0,
'blib/lib', 'blib/arch') t/*.t
t/signal.t .. ok
All tests successful.
Files=1, Tests=7,  0 wallclock secs ( 0.02 usr +  0.00 sys =  0.02 CPU)
Result: PASS

Provides:
perl(IPC::Signal) = 1.00
perl-IPC-signal = 1.00-3.fc14

Requires:
perl(:MODULE_COMPAT_5.10.1)  
rpmlib(FileDigests) = 4.6.0-1
rpmlib(PayloadFilesHavePrefix) = 4.0-1
rpmlib(CompressedFileNames) = 3.0.4-1
rpmlib(VersionedDependencies) = 3.0.3-1
perl = 0:5.003_94
perl(Exporter)  
perl(strict)  
perl(vars)  
rpmlib(VersionedDependencies) = 3.0.3-1
rpmlib(PayloadIsXz) = 5.2-1

rpmlint:
perl-IPC-signal.noarch: W: spelling-error %description -l en_US versa - avers,
verse, verso
perl-IPC-signal.src: W: spelling-error %description -l en_US versa - avers,
verse, verso
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

CPAN RT:
One outstanding issue, which is a feature request rather than a bug.
https://rt.cpan.org/Public/Bug/Display.html?id=11464

Nits:
- please maintain the timestamp of the upstream tarball (use wget or spectool
  to download it - it's dated 1998!)
- a better URL for the upstream project would be:
  http://search.cpan.org/dist/IPC-Signal/
  since it's not version or author specific


Nothing to worry about then. The nits aren't blockers but you might fix them
anyway.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 593841] Review Request: wicd - Wireless and wired network connection manager

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593841

David Cantrell dcantr...@redhat.com changed:

   What|Removed |Added

   Flag||needinfo?(leigh123li...@goo
   ||glemail.com)

--- Comment #30 from David Cantrell dcantr...@redhat.com 2010-06-10 11:13:57 
EDT ---
Fixed the curses %files list.

New spec and srpm uploaded:
http://dcantrel.fedorapeople.org/wicd/wicd.spec
http://dcantrel.fedorapeople.org/wicd/wicd-1.7.0-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #49 from Jaroslav Škarvada jskar...@redhat.com 2010-06-10 
11:30:42 EDT ---
For me the error message doesn't appear after daemon restart but after every:

# /usr/sbin/sendmail -O LogLevel=14 -bs -Am

Thus it seems to be filtered out by default loglevel. Confirmed for F13 and
also for rawhide. The good thing is that the functionality is not affected by
this message. I will investigate the source.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 225708] Merge Review: dovecot

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225708

--- Comment #18 from Michal Hlavinka mhlav...@redhat.com 2010-06-10 11:32:41 
EDT ---
no objections from me, it's another two months, I think you can take it

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602737] New: Review Request: sugar-abacus - A simple abacus activity for Sugar

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sugar-abacus - A simple abacus activity for Sugar

https://bugzilla.redhat.com/show_bug.cgi?id=602737

   Summary: Review Request: sugar-abacus - A simple abacus
activity for Sugar
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pbrobin...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
Blocks: 601827
   Estimated Hours: 0.0
Classification: Fedora


SPEC: http://pbrobinson.fedorapeople.org/sugar-abacus.spec
SRPM: http://pbrobinson.fedorapeople.org/sugar-abacus-12-1.fc14.src.rpm

Description:
Abacus lets the learner explore different representations of numbers using 
different mechanical counting systems developed by the ancient Romans and 
Chinese. There are several different variants available for exploration: a 
suanpan, the traditional Chinese abacus with 2 beads on top and 5 beads below; 
a soroban, the traditional Japanese abacus with 1 bead on top and 4 beads
below;
 the schety, the traditional Russian abacus, with 10 beads per column, with the 
exception of one column with just 4 beads used for counting in fourths; and the 
nepohualtzintzin, the traditional Mayan abacus, with 3 beads on top and 4 beads 
below (it uses base 20).

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2243075

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #50 from Jaroslav Škarvada jskar...@redhat.com 2010-06-10 
11:36:40 EDT ---
Looks like the 'paranoia' safesasl check inside the sendmail code doesn't count
with /etc/sasl2. Probably patching will be needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 226407] Merge Review: sendmail

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #51 from Paul Howarth p...@city-fan.org 2010-06-10 11:45:36 EDT 
---
(In reply to comment #49)
 For me the error message doesn't appear after daemon restart but after every:
 
 # /usr/sbin/sendmail -O LogLevel=14 -bs -Am
 
 Thus it seems to be filtered out by default loglevel. Confirmed for F13 and
 also for rawhide. The good thing is that the functionality is not affected by
 this message. I will investigate the source.

Ah, right. Didn't occur to me to mention that I had:

define(`confLOG_LEVEL',`13')dnl

in my .mc file. Sorry about that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #11 from Adam Goode a...@spicenitz.org 2010-06-10 12:53:32 EDT ---
Do you want the disttag in the obsoletes/provides? I don't think fc12 looks
right there.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590832] Review Request: iapetal - A 2D space rescue game

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590832

Randall Berry randyn3...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Randall Berry randyn3...@gmail.com 2010-06-10 13:01:25 
EDT ---
Looks good to me. 

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602348] Review Request: rubygem-net-ssh - A Ruby ssh client library

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602348

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?

--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-10 
13:07:46 EDT ---
Well,

* Test
  - It seems that rake test does not do any test.
test/README.txt says that to execute tests actually the following
command is needed:
---
ruby -Ilib -Itest -rrubygems test/test_all.rb
---
Note:
- test/common.rb contains:
---
 2  gem test-unit #
http://rubyforge.org/pipermail/test-unit-tracker/2009-July/75.html
---
  However with ruby 1.8.x test/unit is in ruby core (i.e.
  in ruby-libs rpm) and this line is not needed (for 
  ruby 1.8.x).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602767] New: Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols 
as methods

https://bugzilla.redhat.com/show_bug.cgi?id=602767

   Summary: Review Request: perl-MooseX-MarkAsMethods - Mark
overload code symbols as methods
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://ppisar.fedorapeople.org/perl-MooseX-MarkAsMethods/perl-MooseX-MarkAsMethods.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-MooseX-MarkAsMethods/perl-MooseX-MarkAsMethods-0.08-1.fc13.src.rpm
Description:
MooseX::MarkAsMethods allows one to easily mark certain functions as Moose
methods. This will allow other packages such as namespace::autoclean to
operate without blowing away your overloads. After using
MooseX::MarkAsMethods your overloads will be recognized by Class::MOP as
being methods, and class extension as well as composition from roles with
overloads will just work.

This package is required to upgrade perl-Archive-RPM to 0.05 version.

Package compiles on F14--13. F12 has too old perl-Moose.

I'm not sure whether include both README and README.mkdn into %doc. They are
similar but the latter one is generated at compile time. Current spec file
includes both of them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602737] Review Request: sugar-abacus - A simple abacus activity for Sugar

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602737

--- Comment #1 from Peter Robinson pbrobin...@gmail.com 2010-06-10 13:34:57 
EDT ---
SRPM: http://pbrobinson.fedorapeople.org/sugar-abacus-13-1.fc13.src.rpm

New upstream release

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602767] Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602767

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Blocks||599859

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Iain Arnell iarn...@gmail.com changed:

   What|Removed |Added

 CC||iarn...@gmail.com
   Flag|fedora-review+  |

--- Comment #7 from Iain Arnell iarn...@gmail.com 2010-06-10 13:39:44 EDT ---
Paul, sorry to step on your toes, but I'm resetting approval.

There's one blocker. The package name doesn't follow our convention of matching
the CPAN's use of upper/lower case. (Strangely, though, I couldn't find this
codified anywhere in packaging guidelines).

Please rename this package to perl-IPC-Signal with an uppercase letter S.

(and Matthias, same applies to your other review requests for perl modules -
they should all be named like perl-Upstream-DistributionName)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598299] Review Request: systemd - A System and Session Manager

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598299

--- Comment #19 from Rahul Sundaram methe...@gmail.com 2010-06-10 13:39:25 
EDT ---
Thanks David Hollis

http://sundaram.fedorapeople.org/packages/systemd.spec
http://sundaram.fedorapeople.org/packages/systemd-0-0.1.20100610git2f198e.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

--- Comment #8 from Iain Arnell iarn...@gmail.com 2010-06-10 13:44:13 EDT ---
Typical - no sooner do I hit the button and I remember where it's written
(though it could be a bit more explicit about matching case rather than relying
on examples to make the point). 

http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28perl_modules.29

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602348] Review Request: rubygem-net-ssh - A Ruby ssh client library

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602348

--- Comment #6 from Shreyank Gupta shreya...@gmail.com 2010-06-10 13:50:06 
EDT ---
Fixed and Updated:
--

Spec URL:
http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh.spec
SRPM URL:
http://shreyankg.fedorapeople.org/packaging/net-ssh/rubygem-net-ssh-2.0.23-3.fc13.src.rpm

Koji Build:
---

http://koji.fedoraproject.org/koji/taskinfo?taskID=2243303

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601160] Review Request: rubygem-rdiscount - Fast Implementation of Gruber's Markdown in C

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601160

--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-10 
14:08:34 EDT ---
Well,

* ruby(abi) dependency
  - must be strict equality (i.e. R: ruby(abi) = 1.8)

* rubygem module related dependency
  - For rubygem module related dependency, please use 
(Build)Requires: rubygem(foo) style.

ref: (althogh this for perl guideline:)
https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

* Dependency for -doc subpackage
  - -doc subpackage should depend on main package for directory
ownership issue (also see below)

* Directory for non-arch-dependent ruby scripts
  - As I said, arch-dependent files (like C extentsion modules) must
be moved to %ruby_sitearch.

On the other hand, non-arch-dependent ruby scripts must not
be moved from %geminstdir.

* Movement of files under %_builddir
  - Currently build.log says in %check section:
--
   199  + rake test
   200  rm -f 
   201  touch ext/ruby-54f732744bed984d9d0d133997bf4128
   202  cd ext
   203  (in
/builddir/build/BUILD/rubygem-rdiscount-1.6.3.2/usr/lib/ruby/gems/1.8/gems/rdiscount-1.6.3.2)
   204  /usr/bin/ruby extconf.rb
   205  checking for random()... yes
   206  checking for srandom()... yes


   211  cd ext  make clean  make
   212  gcc -I. -I. -I/usr/lib/ruby/1.8/i386-linux -I. -DHAVE_RANDOM
-DHAVE_SRANDOM -DHAVE_RAND -DHAVE_SRAND  -D_FILE_OFFSET_BITS=64 -fPIC -O2 -g
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -fno-strict-aliasing  -fPIC  -c Csio.c

   264  cp -p ext/rdiscount.so lib/
   265  /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in
`gem_original_require': no such file to load -- markdown (LoadError)
--
So currently rake test
- tries to compile rdiscont.so again which was actually built
  in %build
- and finally fails because lib/markdown.rb is not found (under
  %_builddir/%gemname-%version/%geminstdir).

This is because rdiscount.so is moved to %ruby_sitearch before
the tree is copied into %buildroot. You must
- first copy the whole tree to %buildroot
- then move files under %buildroot if needed.
! Note that as said above lib/markdown should not be moved to
  %ruby_sitearch.

* rake test
  - For this gem rake test fails because the needed test/MarkdownTest_1.0.3
is missing. Please replace this with rake test:unit

* Issues in %files
  - As %geminstdir is explicitly defined, please use the macro also
in %files

  - The directory %geminstdir itself is not owned by any packages:
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes

* %doc tag in -doc subpackage
  - Usually I think %doc attribute in -doc subpackage is just redundant
because the name of the rpm already says that this is for documentation.

* %exclude'ing ext/ directory
  - Leaves ext/rdiscount.so.debug files in -debuginfo rpm, which is not needed.
Please remove ext/ directory from %buildroot completely (not from
%_builddir) instead of using %exclude to avoid this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602348] Review Request: rubygem-net-ssh - A Ruby ssh client library

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602348

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-10 
14:15:51 EDT ---
Well, I think keeping BR: rubygem(rake) and rake test lines is
safer, however not a blocker.

-
This package (rubygem-net-ssh) is APPROVED by mtasaka
-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-Signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |perl-IPC-signal - Utility   |perl-IPC-Signal - Utility
   |functions dealing with  |functions dealing with
   |signals |signals

--- Comment #9 from Paul Howarth p...@city-fan.org 2010-06-10 14:46:14 EDT ---
Iain's quite right, don't know how I missed that.

Let's have another cycle round the loop and we can re-approve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590738] Review Request: lunatic-python - Two-way bridge between Python and Lua

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590738

--- Comment #4 from Jon Ciesla l...@jcomserv.net 2010-06-10 14:55:07 EDT ---
Can you post the build.log from the failed x86_64 build?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602348] Review Request: rubygem-net-ssh - A Ruby ssh client library

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602348

Shreyank Gupta shreya...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Shreyank Gupta shreya...@gmail.com 2010-06-10 15:00:29 
EDT ---
I will update that.
Meanwhile..

New Package CVS Request
===
Package Name: rubygem-net-ssh
Short Description: A Ruby ssh client library
Owners: shreyankg
Branches: F-13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602791] New: Review Request: xrootd - Extended ROOT file server

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: xrootd - Extended ROOT file server

https://bugzilla.redhat.com/show_bug.cgi?id=602791

   Summary: Review Request: xrootd - Extended ROOT file server
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mattias.ell...@fysast.uu.se
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.grid.tsl.uu.se/review/xrootd.spec
SRPM URL: http://www.grid.tsl.uu.se/review/xrootd-20100315-1.fc12.src.rpm

Description:
This package contains the xrootd services: xrootd, olbd and cmsd.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602598] Review Request: perl-Proc-WaitStat - Interpret and act on wait() status values

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602598

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |perl-libproc-waitstat - |perl-Proc-WaitStat -
   |Interpret and act on wait() |Interpret and act on wait()
   |status values   |status values

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598138] Review Request: rubygem-rmail - A MIME mail parsing and generation library

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598138

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version||rubygem-rmail-1.0.0-3.fc13
 Resolution|NEXTRELEASE |ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583102] Review Request: radiotray - Radio Tray is a streaming player for listening to online radios

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583102

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||radiotray-0.5.1-3.fc13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 468539] Review Request: sugar-jukebox - Media player activity for Sugar

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=468539

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 CC||pbrobin...@gmail.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #20 from Peter Robinson pbrobin...@gmail.com 2010-06-10 17:10:49 
EDT ---
Package Change Request
==
Package Name: sugar-jukebox
New Branches: EL-6
Owners: pbrobinson sdz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-Signal - Utility functions dealing with signals

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

Paul Howarth p...@city-fan.org changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #11 from Paul Howarth p...@city-fan.org 2010-06-10 16:14:07 EDT 
---
All fixed. APPROVED again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598980] Review Request: rubygem-lockfile - Ruby library for creating NFS safe lockfiles

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598980

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2010-06-10 15:21:57 EDT ---
rubygem-lockfile-1.4.3-4.fc13 has been pushed to the Fedora 13 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 481056] Review Request: squeak-vm - a Smalltalk interpreter

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481056

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 CC||pbrobin...@gmail.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #15 from Peter Robinson pbrobin...@gmail.com 2010-06-10 16:13:38 
EDT ---
Package Change Request
==
Package Name: squeak-vm
New Branches: EL-6
Owners: pbrobinson sdz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600637] Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600637

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?

--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-10 
16:58:39 EDT ---
Well, as some Japanese people said that it was said that
his favorite Same Gnome disappeared, I will review this...

Simple package. Some notes

* noarch handling

%patch1 -p1 -b .license

%build
# not using standard configure macro. Nothing is compiled,
# only prefix needed
./configure --prefix %{_prefix}

  - Why don't you just use the following?

%configure --libdir=%{_datadir}


* Timestamps
  - Trying to keep timestamps on installed files is appreciated
especially because this is based on recent autotools method
and this is noarch. Please consider to use below:

make install DESTDIR=$RPM_BUILD_ROOT INSTALL=install -p


* Cleanups
  - rpmlint may complain, however:
* On Fedora BuildRoot tag is no longer used:
  https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* On Fedora 13+, %clean is not needed:
  https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

And I guess you need this package only for F-13+.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 208034] Review Request: HippoDraw - Interactive and Python scriptable data analysis application

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=208034

Peter Robinson pbrobin...@gmail.com changed:

   What|Removed |Added

 CC||pbrobin...@gmail.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #88 from Peter Robinson pbrobin...@gmail.com 2010-06-10 16:06:07 
EDT ---
Package Change Request
==
Package Name: hippodraw
New Branches: EL-6
Owners: pbrobinson sdz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 598980] Review Request: rubygem-lockfile - Ruby library for creating NFS safe lockfiles

2010-06-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598980

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||rubygem-lockfile-1.4.3-4.fc
   ||13
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


  1   2   3   >