[Bug 563844] Update Zim to the upstream Python-based release

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563844

Robin Lee robinlee.s...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||Zim-0.47-1.fc14
 Resolution||RAWHIDE
   Flag|needinfo?(cw...@alumni.drew |
   |.edu)   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518857] Review Request: django-extensions - django command line extensions

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518857

Matthias Runge mru...@matthias-runge.de changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||INSUFFICIENT_DATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600238] Review Request: maven-dependency-plugin - Plugin to manipulate, copy and unpack local and remote artifacts

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600238

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

--- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2010-06-14 
02:51:22 EDT ---
Thanks.

Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=2248261

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603295] Review Request: guava - Guava (Google Common Libraries)

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603295

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||socho...@redhat.com
 AssignedTo|nob...@fedoraproject.org|socho...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Stanislav Ochotnicky socho...@redhat.com 2010-06-14 
03:08:54 EDT ---
I will do the review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 578135] Review Request: patcher - Quick creation of patches against a project source tree

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578135

--- Comment #7 from Michael Scherer m...@zarb.org 2010-06-14 03:36:23 EDT ---
I am, but I do not know what are the next steps, or if there is something I
need to do ( since that's the first time I submit a package, I may have
overlooked some part of the procedure ).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #10 from Shreyank Gupta shreya...@gmail.com 2010-06-14 03:50:22 
EDT ---
(In reply to comment #9)
 Some notes:
 
 * Naming
   - As this is based on sup gem, please name rpm as rubygem-sup
 anyway (because installed rpm can be used as sup gem).
 

I am of the opinion, that since this package is not a ruby library, it need not
be named as rubygem-sup. Also since this package is a application naming it sup
rather than rubygem-sup makes more sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 594744] Review Request: zint - A barcode generator and library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594744

--- Comment #16 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 03:58:40 EDT ---
zint-2.3.2-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/zint-2.3.2-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 594744] Review Request: zint - A barcode generator and library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594744

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 03:58:35 EDT ---
zint-2.3.2-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/zint-2.3.2-3.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602587] Review Request: perl-IPC-Signal - Utility functions dealing with signals

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602587

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 04:17:06 EDT ---
perl-IPC-Signal-1.00-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-IPC-Signal-1.00-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 563376] Revive from F11 branch: pcmanx-gtk2 - Telnet client designed for BBS browsing

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563376

--- Comment #9 from Chen Lei supercyp...@gmail.com 2010-06-14 04:23:40 EDT ---

New SRPM:
https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2-0.3.9-6.20100601svn.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603629] New: Review Request: cf-ofl-sorts-mill-goudy - Goudy Oldstyle and Italic fonts

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: cf-ofl-sorts-mill-goudy - Goudy Oldstyle and Italic 
fonts

https://bugzilla.redhat.com/show_bug.cgi?id=603629

   Summary: Review Request: cf-ofl-sorts-mill-goudy - Goudy
Oldstyle and Italic fonts
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/cf-sorts-mill-goudy-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/cf-sorts-mill-goudy-fonts-3.0-2.fc13.src.rpm
Description: 
Goudy Oldstyle and Italic (based on ATF foundry type)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603631] New: Review Request: moyogo-molengo-fonts - A Latin typeface for documents

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: moyogo-molengo-fonts - A Latin typeface for documents

https://bugzilla.redhat.com/show_bug.cgi?id=603631

   Summary: Review Request: moyogo-molengo-fonts - A Latin
typeface for documents
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/moyogo-molengo-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/moyogo-molengo-fonts-0.10-2.fc13.src.rpm
Description: 
Molengo is a Latin typeface for documents. It is multilingual and has some
features required by many minority languages such as non-spacing mark
placement.
The font is produced with Fontforge.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603632] New: Review Request: typemade-josefinsansstd-light-fonts - This typeface was to made for geometric, elegant titling and kind of vintage

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: typemade-josefinsansstd-light-fonts - This typeface 
was to made for geometric, elegant titling and kind of vintage

https://bugzilla.redhat.com/show_bug.cgi?id=603632

   Summary: Review Request: typemade-josefinsansstd-light-fonts -
This typeface was to made for geometric, elegant
titling and kind of vintage
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/typemade-josefinsansstd-light-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/typemade-josefinsansstd-light-fonts-1.000-2.fc13.src.rpm
Description: 
The idea for creating this typeface was to make it geometric, elegant and
kind of vintage, especially for titling. It is based on Rudolf Koch's
Kabel (1927), Rudolf Wolf's Memphis (1930),Paul Renner's Futura (1927?).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] New: Review Request: robofab -

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: robofab -

https://bugzilla.redhat.com/show_bug.cgi?id=603634

   Summary: Review Request: robofab -
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/robofab.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/robofab-1.2.0-1.svn200.fc13.src.rpm
Description: 
RoboFab is a Python library with objects that deal with data usually associated
with fonts and type design. RoboFab reads and writes UFO font files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603628] New: Review Request: aldusleaf-crimson-text-fonts - A latin font for the production of technical books and papers

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: aldusleaf-crimson-text-fonts - A latin font for the 
production of technical books and papers

https://bugzilla.redhat.com/show_bug.cgi?id=603628

   Summary: Review Request: aldusleaf-crimson-text-fonts - A latin
font for the production of technical books and papers
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/aldusleaf-crimson-text-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/aldusleaf-crimson-text-fonts-0-0.2.20100523.fc13.src.rpm
Description: 
A latin font for a quality typeface for the production of books and
papers, particularly technical ones.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603630] New: Review Request: impallari-lobster-fonts - Hand written font with various ligatures for better connecting of letters

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: impallari-lobster-fonts - Hand written font with 
various ligatures for better connecting of letters

https://bugzilla.redhat.com/show_bug.cgi?id=603630

   Summary: Review Request: impallari-lobster-fonts - Hand written
font with various ligatures for better connecting of
letters
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/impallari-lobster-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/impallari-lobster-fonts-1.3-2.fc13.src.rpm
Description: 
Hand written font with various ligatures for better connecting
of letters.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603633] New: Review Request: scholarsfonts-cardo-fonts - This is designed for classicists, Biblical scholars, medievalists, linguists

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: scholarsfonts-cardo-fonts - This is designed for 
classicists, Biblical scholars, medievalists, linguists

https://bugzilla.redhat.com/show_bug.cgi?id=603633

   Summary: Review Request: scholarsfonts-cardo-fonts - This is
designed for classicists, Biblical scholars,
medievalists, linguists
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/scholarsfonts-cardo-fonts.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/scholarsfonts-cardo-fonts-0.099-1.fc13.src.rpm
Description: 
Cardo is a large Unicode font specifically designed for the needs of
classicists, Biblical scholars, medievalists, and linguists.  Since it may be
used to prepare materials for publication, it also contains features that are
required for high-quality typography, such as ligatures, text figures (also
known as old style numerals), true small capitals and a variety of punctuation
and space characters.  It may also be used to document and discuss the features
of Unicode that are applicable to the these disciplines, as we work to help
colleagues understand the value (and limitations) of Unicode.
This font has been revived in modern times under several names (Bembo, Aetna,
Aldine 401).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: robofab -   |Review Request: robofab -
   ||reads and writes UFO font
   ||files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603233] Review Request: zeromq - Software library for fast, message-based applications

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603233

--- Comment #4 from Thomas Spura toms...@fedoraproject.org 2010-06-14 
04:26:24 EDT ---
Sorry, Peter, didn't notice your bug...

Are you interested in comaintaining?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603295] Review Request: guava - Guava (Google Common Libraries)

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603295

--- Comment #2 from Stanislav Ochotnicky socho...@redhat.com 2010-06-14 
04:32:43 EDT ---
I planned to start official review immediately, but due to problems with this
package noted below I will delay it until those issues are fixed.

NEEDSWORK: rpmlint must be run on every package. The output should be posted in
the review.
guava.src: W: name-repeated-in-summary C Guava
guava.src: W: spelling-error %description -l en_US google's - Google's,
goggle's, go ogle's
guava.src: W: spelling-error %description -l en_US io - oi, Io, ii
guava.src: W: spelling-error %description -l en_US javax - java, java x, Java
guava.src: W: invalid-url Source0: guava-r05.tar.bz2
guava.noarch: W: name-repeated-in-summary C Guava
guava.noarch: W: spelling-error %description -l en_US google's - Google's,
goggle's, go ogle's
guava.noarch: W: spelling-error %description -l en_US io - oi, Io, ii
guava.noarch: W: spelling-error %description -l en_US javax - java, java x,
Java
guava.noarch: W: non-conffile-in-etc /etc/maven/fragments/guava
guava.noarch: W: dangling-relative-symlink /usr/share/java/guava-r05.jar *-05*
3 packages and 0 specfiles checked; 0 errors, 11 warnings.

So let's go 1 by 1:
 - summary should normally not repeat name of package. So simplify it
 to something like Google Core Libraries for Java
 - Google's not google's
 - your symlink in /usr/share/java is completely wrong. You will have
 to play with it a bit.

BIG FAT WARNING:
I have noted this before in previous reviews (not sure if it was your
package). When you do:

 svn export http://guava-libraries.googlecode.com/svn/trunk/ guava-r05

You CAN NOT guarantee checked out sources will always be the same! In
fact checked out sources are very different from sources you'd get by doing:

 svn export http://guava-libraries.googlecode.com/svn/tags/release05 guava-r05

And that you should do. Trunk is always changing, so you cannot make releases
out of it without specifying at least revision number (if no tags exist).

NEEDSWORK: The package must meet the Packaging Guidelines .

Don't use:
 ln -s /usr/share/java/jsr-305.jar lib/jsr305.jar 

Instead use something like
export CLASSPATH=$(build-classpath jsr-305)

or if the build system really needs that jar file in lib/, see:

https://fedoraproject.org/wiki/Packaging:Java#build-jar-repository

I'll do full official review after these problems have been fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602597] Review Request: perl-Package-Stash - Routines for manipulating stashes

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602597

--- Comment #5 from Fedora Update System upda...@fedoraproject.org 2010-06-14 
04:43:03 EDT ---
perl-Package-Stash-0.03-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574627] Review request: sunpinyin - A statistical language model based Chinese input method

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574627

Chen Lei supercyp...@gmail.com changed:

   What|Removed |Added

  Status Whiteboard||Notready

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574627] Review request: sunpinyin - A statistical language model based Chinese input method

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574627

Chen Lei supercyp...@gmail.com changed:

   What|Removed |Added

  Status Whiteboard|Notready|NotReady

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602597] Review Request: perl-Package-Stash - Routines for manipulating stashes

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602597

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-06-14 
04:45:53 EDT ---
perl-Package-Stash-0.03-1.el4 has been submitted as an update for Fedora EPEL
4.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602597] Review Request: perl-Package-Stash - Routines for manipulating stashes

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602597

--- Comment #7 from Fedora Update System upda...@fedoraproject.org 2010-06-14 
04:45:48 EDT ---
perl-Package-Stash-0.03-1.el5 has been submitted as an update for Fedora EPEL
5.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603638] New: Review Request: defcon - A set of flexible objects for representing UFO data.

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: defcon -  A set of flexible objects for representing 
UFO data.

https://bugzilla.redhat.com/show_bug.cgi?id=603638

   Summary: Review Request: defcon -  A set of flexible objects
for representing UFO data.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/defcon.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/defcon-0.1-1.fc13.src.rpm
Description: 
A set of flexible objects for representing UFO data.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603641] New: Review Request: fontMath - A set of objects for performing math operations on font data

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: fontMath - A set of objects for performing math 
operations on font data

https://bugzilla.redhat.com/show_bug.cgi?id=603641

   Summary: Review Request: fontMath - A set of objects for
performing math operations on font data
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/fontMath.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/fontMath-0.2-1.fc13.src.rpm
Description: 
A set of objects for performing math operations on font data.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #12 from Shreyank Gupta shreya...@gmail.com 2010-06-14 04:47:45 
EDT ---
(In reply to comment #11)
 We already have some other example.
 - For example rails is not scrictly ruby library
But it still is a web framework. All rails applications have 
gem 'rails'
as inside config/boot.rb

 - Also we have merb (I don't know well, maintained by Kent), and
   (I think) this is not ruby library
I guess they will be merged into rails 3

 - haml is also an application
 
It is basically a library to parse views templates written in haml.

 But naming these packages as rubygem-foo anyway is preferred because
 we can track easily what packages are built from gem (i.e. it makes
 easier to maintain).

If that is the concern could we package sup as rubygem-sup and provide a
subpackage sup (something similar to
https://fedoraproject.org/wiki/Packaging:Ruby#Packaging_for_Gem_and_non-Gem_use)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602597] Review Request: perl-Package-Stash - Routines for manipulating stashes

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602597

--- Comment #9 from Paul Howarth p...@city-fan.org 2010-06-14 04:47:42 EDT ---
Built successfully on all branches, including dist-rawhide and
dist-f14-perltest tags for devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #13 from Shreyank Gupta shreya...@gmail.com 2010-06-14 04:48:56 
EDT ---
(In reply to comment #12)

 If that is the concern could we package sup as rubygem-sup and provide a
 subpackage sup (something similar to
 https://fedoraproject.org/wiki/Packaging:Ruby#Packaging_for_Gem_and_non-Gem_use)
 

Or maybe the other way round! :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #54 from Jaroslav Škarvada jskar...@redhat.com 2010-06-14 
04:49:19 EDT ---
Suggestions from comment 37 implemented in sendmail-8.14.4-8.fc14.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603634] Review Request: robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603633] Review Request: scholarsfonts-cardo-fonts - This is designed for classicists, Biblical scholars, medievalists, linguists

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603633

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603639] New: Review Request: ufo2fdk - A bridge between UFOs and the AFKDO

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: ufo2fdk - A bridge between UFOs and the AFKDO

https://bugzilla.redhat.com/show_bug.cgi?id=603639

   Summary: Review Request: ufo2fdk - A bridge between UFOs and
the AFKDO
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/ufo2fdk.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/ufo2fdk-0.1-1.fc13.src.rpm
Description: 
A bridge between UFOs and the AFKDO.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603640] New: Review Request: compositor - A simple OpenType GSUB and GPOS engine

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: compositor - A simple OpenType GSUB and GPOS engine

https://bugzilla.redhat.com/show_bug.cgi?id=603640

   Summary: Review Request: compositor - A simple OpenType GSUB
and GPOS engine
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/compositor.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/compositor-0.2b-1.fc13.src.rpm
Description: 
A simple OpenType GSUB and GPOS engine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603631] Review Request: moyogo-molengo-fonts - A Latin typeface for documents

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603631

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603638] Review Request: defcon - A set of flexible objects for representing UFO data.

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603638

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603630] Review Request: impallari-lobster-fonts - Hand written font with various ligatures for better connecting of letters

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603630

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603639] Review Request: ufo2fdk - A bridge between UFOs and the AFKDO

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603639

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603629] Review Request: cf-ofl-sorts-mill-goudy - Goudy Oldstyle and Italic fonts

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603629

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603628] Review Request: aldusleaf-crimson-text-fonts - A latin font for the production of technical books and papers

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603628

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603632] Review Request: typemade-josefinsansstd-light-fonts - This typeface was to made for geometric, elegant titling and kind of vintage

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603632

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603640] Review Request: compositor - A simple OpenType GSUB and GPOS engine

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603640

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599316] Review Request: input-pad - Input Pad

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599316

fujiwara tfuji...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

--- Comment #13 from fujiwara tfuji...@redhat.com 2010-06-14 04:58:40 EDT ---
Integrated in rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2248480

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603366] Review Request: coan - re-review due to package rename from sunifdef

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603366

Jonathan Underwood jonathan.underw...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

--- Comment #5 from Jonathan Underwood jonathan.underw...@gmail.com 
2010-06-14 05:15:02 EDT ---
Thanks Kevin.

coan packages built for devel and F-13 branches, closing bz.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602960] Review Request: maven-eclipse-plugin - Maven Eclipse Plugin

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602960

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-06-14 
05:20:08 EDT ---
Review:
OK: rpmlint must be run on every package. Output:
maven-eclipse-plugin.noarch: E: explicit-lib-dependency aqute-bndlib
This is not a lib package.

maven-eclipse-plugin.noarch: W: spelling-error %description -l en_US classpath
- class path, class-path, classmate
maven-eclipse-plugin.noarch: W: no-documentation
maven-eclipse-plugin.noarch: W: non-conffile-in-etc
/etc/maven/fragments/maven-eclipse-plugin

False positives. 

OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines .
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package must be included in %doc. There is no license file. 

Please ask upstream to include one.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. 
OK: The sources used to build the package must match the upstream source, as
provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that
are listed in the exceptions section of the Packaging Guidelines ; inclusion of
those as BuildRequires is optional. Apply common sense.
OK: Packages must NOT bundle copies of system libraries.
OK: A package must own all directories that it creates. If it does not create a
directory that it uses, then it should require a package which does create that
directory. 
OK: A Fedora package must not list a file more than once in the spec file's
%files listings. 
OK: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage. 
OK: If a package includes something as %doc, it must not affect the runtime of
the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: All filenames in rpm packages must be valid UTF-8. 

It may be better to do 
# Install necessary package to maven repository
mvn-jpp \
-e \
-Dmaven2.jpp.mode=true \
-Dmaven2.jpp.depmap.file=${MAVEN_DEPMAP} \
-Dmaven.repo.local=$MAVEN_REPO_LOCAL \
install:install-file \
-DgroupId=org.eclipse.core \
-DartifactId=resources \
-Dversion=3.5.2-v201004121342 \
-Dpackaging=jar \
   
-Dfile=/usr/lib/eclipse/plugins/org.eclipse.core.resources_3.5.2.201004121342.jar

in the %prep section.

Otherwise, package looks good.

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603640] Review Request: compositor - A simple OpenType GSUB and GPOS engine

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603640

Chen Lei supercyp...@gmail.com changed:

   What|Removed |Added

 CC||supercyp...@gmail.com

--- Comment #1 from Chen Lei supercyp...@gmail.com 2010-06-14 05:23:08 EDT ---
It'll be better to rename this package to python-$NAME to match package naming
guideline.

See
http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 505354] Review Request: php-captchaphp - PHP very user-friendly CAPTCHA solution

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=505354

--- Comment #8 from Patrick Monnerat p...@datasphere.ch 2010-06-14 05:24:38 
EDT ---
I thank you very much for the review, Spot: as ever, you are my savior :-)

 License: Public Domain or MIT

Change applied:
http://monnerat.fedorapeople.org/php-captchaphp.spec
http://monnerat.fedorapeople.org/php-captchaphp-2.2-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599316] Review Request: input-pad - Input Pad

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599316

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 05:28:36 EDT ---
input-pad-0.1.0.20100614-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/input-pad-0.1.0.20100614-1.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Chen Lei supercyp...@gmail.com changed:

   What|Removed |Added

 CC||supercyp...@gmail.com

--- Comment #1 from Chen Lei supercyp...@gmail.com 2010-06-14 05:28:44 EDT ---
This package should be renamed to python-robofab, the same reason with #603640

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 563376] Revive from F11 branch: pcmanx-gtk2 - Telnet client designed for BBS browsing

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563376

--- Comment #12 from Chen Lei supercyp...@gmail.com 2010-06-14 05:31:17 EDT 
---
(In reply to comment #10)
 Okay. Rawhide build succeeded:
 http://koji.fedoraproject.org/koji/taskinfo?taskID=2248524
 
 Now it is approved by cheeselee.

Thanks for the review!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 563376] Revive from F11 branch: pcmanx-gtk2 - Telnet client designed for BBS browsing

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563376

Chen Lei supercyp...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #11 from Chen Lei supercyp...@gmail.com 2010-06-14 05:30:58 EDT 
---
Package Change Request
==
Package Name: pcmanx-gtk2
New Branches: F-12 F-13
Owners: supercyper

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602597] Review Request: perl-Package-Stash - Routines for manipulating stashes

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602597

--- Comment #6 from Fedora Update System upda...@fedoraproject.org 2010-06-14 
04:44:24 EDT ---
perl-Package-Stash-0.03-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/perl-Package-Stash-0.03-1.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603640] Review Request: python-compositor - A simple OpenType GSUB and GPOS engine

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603640

Parag pnem...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: compositor  |Review Request:
   |- A simple OpenType GSUB|python-compositor - A
   |and GPOS engine |simple OpenType GSUB and
   ||GPOS engine

--- Comment #2 from Parag pnem...@redhat.com 2010-06-14 05:42:28 EDT ---
Following the python naming guidelines now.

Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/python-compositor.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-compositor-0.2b-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Blocks||603640

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603640] Review Request: python-compositor - A simple OpenType GSUB and GPOS engine

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603640

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Depends on||603634

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 471231] Review Request: WebCalendar - Single/multi-user web-based calendar application

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471231

--- Comment #27 from Patrick Monnerat p...@datasphere.ch 2010-06-14 05:43:13 
EDT ---
New Package CVS Request
===
Package Name: WebCalendar
Short Description: Single/multi-user web-based calendar application
Owners: monnerat
Branches: F-12 F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: python-robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Blocks||603638

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: python-robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: robofab -   |Review Request:
   |reads and writes UFO font   |python-robofab - reads and
   |files   |writes UFO font files

--- Comment #2 from Parag pnem...@redhat.com 2010-06-14 05:43:49 EDT ---
Following python naming guidelines now
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-robofab.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-robofab-1.2.0-1.svn200.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: python-robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Blocks||603639

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: python-robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Blocks||603641

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603639] Review Request: python-ufo2fdk - A bridge between UFOs and the AFKDO

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603639

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Depends on||603634
Summary|Review Request: ufo2fdk - A |Review Request:
   |bridge between UFOs and the |python-ufo2fdk - A bridge
   |AFKDO   |between UFOs and the AFKDO

--- Comment #1 from Parag pnem...@redhat.com 2010-06-14 05:46:38 EDT ---
Following python naming guidelines now.

Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-ufo2fdk.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-ufo2fdk-0.1-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603641] Review Request: python-fontMath - A set of objects for performing math operations on font data

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603641

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Depends on||603634
Summary|Review Request: fontMath -  |Review Request:
   |A set of objects for|python-fontMath - A set of
   |performing math operations  |objects for performing math
   |on font data|operations on font data

--- Comment #1 from Parag pnem...@redhat.com 2010-06-14 05:47:50 EDT ---
Following python naming guidelines.
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-fontMath.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-fontMath-0.2-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603634] Review Request: python-robofab - reads and writes UFO font files

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603634

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Blocks||603666

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603666] New: Review Request: python-defconAppKit - A collection of Vanilla objects for use in font editing applications.

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-defconAppKit - A collection of Vanilla objects 
for use in font editing applications.

https://bugzilla.redhat.com/show_bug.cgi?id=603666

   Summary: Review Request: python-defconAppKit - A collection of
Vanilla objects for use in font editing applications.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: pnem...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL:
http://paragn.fedorapeople.org/fedora-work/SPECS/python-defconAppKit.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-defconAppKit-0.1-1.fc13.src.rpm
Description: 
A collection of Vanilla objects for use in font editing applications.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603666] Review Request: python-defconAppKit - A collection of Vanilla objects for use in font editing applications.

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603666

Parag pnem...@redhat.com changed:

   What|Removed |Added

   Keywords||i18n
 CC||i18n-b...@lists.fedoraproje
   ||ct.org
 Depends on||603634

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #23 from Adam Tkac at...@redhat.com 2010-06-14 06:19:37 EDT ---
(In reply to comment #22)
 Well, nonetheless, you *are* going to get push-back if you remove the static
 library.  I know because it was tried once already, and not that long ago.  
 See
 bug #186060, bug #215537.  Fedora is used for other things than just building
 itself.

In my opinion it's long time since F7 (libjpeg-turbo will hit F14) so we can
retest if someone still needs the static libjpeg. I would rather see no
static libjpeg.a for now. It might be easily added in the future if someone
requests it, libjpeg-turbo project uses libtool so I will drop the
--disable-static configure flag in the specfile and add -static subpackage,
it's pretty simple. If we package -static libjpeg now we won't be able to
figure time when we can say noone uses the static libjpeg.a.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580169] Review Request: loggerhead - Web viewer for the Bazaar version control system

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580169

--- Comment #14 from Terje Røsten terje...@phys.ntnu.no 2010-06-14 06:25:37 
EDT ---
Why is this ticket still on ON_QA? 

The package have been pushed to stable several weeks ago?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603638] Review Request: python-defcon - A set of flexible objects for representing UFO data.

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603638

Parag pnem...@redhat.com changed:

   What|Removed |Added

 Depends on||603634
Summary|Review Request: defcon -  A |Review Request:
   |set of flexible objects for |python-defcon -  A set of
   |representing UFO data.  |flexible objects for
   ||representing UFO data.

--- Comment #1 from Parag pnem...@redhat.com 2010-06-14 05:45:35 EDT ---
Following python naming guidelines now.

Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-defcon.spec
SRPM URL:
http://paragn.fedorapeople.org/fedora-work/SRPMS/python-defcon-0.1-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #24 from Adam Tkac at...@redhat.com 2010-06-14 06:39:17 EDT ---
(In reply to comment #18)
 Hi Adam,
 Add -static subpackage and more documents to mainpackage and -devel 
 subpackage,
 I'll start to review this package.

As I wrote in the comment #23 I don't think the -static package is needed now.

I included the example.c documentation file in the devel subpackage and
extended description a little, it should be sufficient.

New spec + SRPM:
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo.spec
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo-0.0.93-6.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #25 from Chen Lei supercyp...@gmail.com 2010-06-14 06:51:39 EDT 
---
(In reply to comment #24)
 (In reply to comment #18)
  Hi Adam,
  Add -static subpackage and more documents to mainpackage and -devel 
  subpackage,
  I'll start to review this package.
 
 As I wrote in the comment #23 I don't think the -static package is needed now.
 
 I included the example.c documentation file in the devel subpackage and
 extended description a little, it should be sufficient.
 
 New spec + SRPM:
 http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo.spec
 http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo-0.0.93-6.fc14.src.rpm
 

How about to ask this on -devel? I found that many core libraries in fedora
provides static libs, e.g. glibc openssl zlib libpng. 

If we don't provide -static subpackage, we need to obsolete it in the main
package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 600243] Review Request: libjpeg-turbo - MMX/SSE accelerated libjpeg

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600243

--- Comment #26 from Adam Tkac at...@redhat.com 2010-06-14 07:29:18 EDT ---
(In reply to comment #25)
 How about to ask this on -devel? I found that many core libraries in fedora
 provides static libs, e.g. glibc openssl zlib libpng. 

Done. Check
http://lists.fedoraproject.org/pipermail/devel/2010-June/137604.html.

 If we don't provide -static subpackage, we need to obsolete it in the main
 package.

Right you are but it should be obsoleted in the -devel subpackage.

New spec + SRPM:
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo.spec
http://atkac.fedorapeople.org/libjpeg-turbo/libjpeg-turbo-0.0.93-7.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601160] Review Request: rubygem-rdiscount - Fast Implementation of Gruber's Markdown in C

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601160

--- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-14 
08:38:46 EDT ---
Please set fedora-cvs flag to ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602767] Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602767

--- Comment #2 from Marcela Mašláňová mmasl...@redhat.com 2010-06-14 08:42:53 
EDT ---
Both readme could stay in package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 537983] Review Request: python-visual - 3D Programming

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537983

ELMORABITY Mohamed pikachu.2...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602767] Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602767

Marcela Mašláňová mmasl...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mmasl...@redhat.com

--- Comment #1 from Marcela Mašláňová mmasl...@redhat.com 2010-06-14 08:42:23 
EDT ---
OK rpmlint checks return: 
[ma...@caladan SRPMS]$ rpmlint perl-MooseX-MarkAsMethods-0.08-1.fc13.src.rpm 
perl-MooseX-MarkAsMethods.src: W: spelling-error %description -l en_US
namespace - name space, name-space, names pace
perl-MooseX-MarkAsMethods.src: W: spelling-error %description -l en_US
autoclean - auto clean, auto-clean, autoclave
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
[ma...@caladan SRPMS]$ rpmlint
../RPMS/noarch/perl-MooseX-MarkAsMethods-0.08-1.fc13.noarch.rpm 
perl-MooseX-MarkAsMethods.noarch: W: spelling-error %description -l en_US
namespace - name space, name-space, names pace
perl-MooseX-MarkAsMethods.noarch: W: spelling-error %description -l en_US
autoclean - auto clean, auto-clean, autoclave
1 packages and 0 specfiles checked; 0 errors, 2 warnings.


OK package meets naming guidelines
OK package meets packaging guidelines
OK license (LGPLv2+) OK, text in %doc, matches source
OK spec file legible, in am. english
OK source matches upstream
OK package compiles on devel (x86)
OK no missing BR
OK no unnecessary BR
OK no locales
OK not relocatable
OK owns all directories that it creates
OK no duplicate files
OK permissions ok
OK %clean ok
OK macro use consistent
OK code, not content
OK no need for -docs
OK nothing in %doc affects runtime
OK no need for .desktop file 

New version 0.09 is available. Please update, the latest version is fixing
version of Moose in requirements.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 537983] Review Request: python-visual - 3D Programming

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=537983

ELMORABITY Mohamed pikachu.2...@gmail.com changed:

   What|Removed |Added

   Flag||needinfo?

--- Comment #29 from ELMORABITY Mohamed pikachu.2...@gmail.com 2010-06-14 
08:39:57 EDT ---
Just a few words about the license: it seems some files are under the MIT
license too. Maybe you could add it to the License field.

Moreover, in the license.txt file, the part relative to the Polygon module is
quite worrying (typically nonfree)... But I didn't find this module in the
sources, I suppose it was removed from previous versions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591730] Review Request: pyjamas - A python to Javascript compiler, Widget set, Framework and Toolkit

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591730

--- Comment #23 from luke kenneth casson leighton l...@lkcl.net 2010-06-14 
08:44:21 EDT ---
(In reply to comment #22)
 Excellent. Thanks for the info. :) 

 no problem.

 Happy to adjust or tweak the fedora package to work better. 

 cool.  i have to do a 0.7p1 or 0.7.1 soon, there's a couple of niggling bugs
in 0.7

 but the actual packaging itself?  it looks solid to me.

 Feel free to file bugs on it, or drop me email directly.

 willdo kevin.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590832] Review Request: iapetal - A 2D space rescue game

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590832

--- Comment #11 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 08:47:14 EDT ---
iapetal-1.0-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/iapetal-1.0-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590832] Review Request: iapetal - A 2D space rescue game

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590832

--- Comment #10 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 08:47:08 EDT ---
iapetal-1.0-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/iapetal-1.0-3.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-14 
08:50:54 EDT ---
I think just Provides: sup = %{version}-%{release} is the simplest.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603521] Review Request: pynetsnmp - Python ctypes bindings for NET-SNMP with Twisted integration

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603521

--- Comment #2 from Ian Weller i...@ianweller.org 2010-06-14 09:14:43 EDT ---
I disagree. python-py* is redundant. The packaging guidelines also state:

If the upstream source has py (or Py) in its name, you can use that name
for the package.

Users can run an rpm -ql to see what the namespace of the package is after the
fact.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601160] Review Request: rubygem-rdiscount - Fast Implementation of Gruber's Markdown in C

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601160

Gerd Pokorra g...@zimt.uni-siegen.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #13 from Gerd Pokorra g...@zimt.uni-siegen.de 2010-06-14 09:30:35 
EDT ---
New Package CVS Request
===
Package Name: rubygem-rdiscount
Short Description: Fast Implementation of Gruber's Markdown in C
Owners: gerd
Branches: F-12 F-13
InitialCC: gerd

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: rubygem-sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

Shreyank Gupta shreya...@gmail.com changed:

   What|Removed |Added

Summary|Review Request: sup - A |Review Request: rubygem-sup
   |console-based email client  |- A console-based email
   |written in ruby |client written in ruby

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: rubygem-sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #15 from Shreyank Gupta shreya...@gmail.com 2010-06-14 10:02:41 
EDT ---
Alright then.

UPDATED:
-

Spec URL: http://shreyankg.fedorapeople.org/packaging/sup/rubygem-sup.spec
SRPM URL:
http://shreyankg.fedorapeople.org/packaging/sup/rubygem-sup-0.10.2-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602574] Review Request: patchelf - a utility for patching ELF binaries

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602574

Martin Gieseking martin.giesek...@uos.de changed:

   What|Removed |Added

 CC||martin.giesek...@uos.de

--- Comment #1 from Martin Gieseking martin.giesek...@uos.de 2010-06-14 
10:37:51 EDT ---
Hi Jeremy,

here are some initial comments:

- according to file README, the license is GPLv3+, not GPLv3 only

- to simplify things, I suggest to replace the rm and rmdir line with 
  rm -rf %{buildroot}/usr/share/doc/

- remove %doc from %doc %{_mandir}/man1/patchelf.1*

- don't mix tabs and spaces for indentation

- The tarball contains a couple of tests. It's probably a good idea to run them
(with make check in a %check section).


$ rpmlint /var/lib/mock/fedora-13-i386/result/*.rpm
patchelf.i686: W: spelling-error %description -l en_US executables -
executable, executable s, executrices
patchelf.src: W: spelling-error %description -l en_US executables -
executable, executable s, executrices
patchelf.src: W: no-buildroot-tag
patchelf.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 10)
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

The missing buildroot tag can be ignored if you plan to maintain this package
for Fedora only. Otherwise, you should add one and also clean the buildroot in
%install.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602791] Review Request: xrootd - Extended ROOT file server

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #2 from Mattias Ellert mattias.ell...@fysast.uu.se 2010-06-14 
11:03:31 EDT ---
(In reply to comment #1)
 Summary and comments
 
 1) The 
 xrootd-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libXrdPosix.so.0.0.0
 _e...@glibc_2.2.5
 xrootd-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libXrdClient.so.0.0.0
 e...@glibc_2.2.5
 xrootd-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libXrdRootd.so.0.0.0
 _e...@glibc_2.2.5
  can you open a bug upstream.

I have now sent a mail with this issue to xrootd-b...@slac.stanford.edu, which
is indicated as the preferred way to report bugs in xrootd on
http://xrootd.slac.stanford.edu/Bug_Report.htm - it probably ends up in an
issue tracker somewhere - but I didn't get any reply yet, so I can not give a
reference. This could be due to grey listing.

 2) Source1: xrootd-manpages.tar.gz
   Can you ellaberate more on where this tar ball comes from so some one else
 could
   create it.

Added some comments to the spec file.

 3) Man pages are LGPL not BSD.

Added LGPLv2+ to the License tag

 4) Presumably  pthreads-win32 directory can be deleted, it's GPL so to be sure
 it's not being used 
delete it.

done

 5) src/XrdSecssl/libsslGridSite/* is ASL2.0/BSD but also is really just a copy
 of gridsite
source code as you know now packaged, can you use the ready packaged one.
Looking harder I see this may not actually be used, delete it to be sure.

done

 6) There is no LICENSE file, can you request upstream adds one.

done - to the same e-mail as above.

 7) I see you made some comments on the shared library .so and the module .so.
 
 Something to think about, do you want to library version the shared libs?
 Can the actual modules(or plugins) go in /usr/lib64/xrootd/modules with as
 necessary
 symlinks to the versioned sos in %{_libdir} . All depends on how hard it is to
 do.

The plugin handling in xrootd is not centralized to one place in the code, but
dlopen is called in very many places. I think this would be quite a lot of
work.

 8) The description of the package is a bit terse, can you add what xrootd can
actually be used for.

I have expanded the package description.

 9) You may want to increase the BR for java to bring in an openjdk rather than
just GCJ. My mock build did not build a .jar and only built a .so. 

I can not reproduce this. The jar built fine for me even with java-1.4.2-gcj on
RHEL 4.

   Steve.

New version:

Spec URL: http://www.grid.tsl.uu.se/review/xrootd.spec
SRPM URL: http://www.grid.tsl.uu.se/review/xrootd-20100315-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: rubygem-sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

Shreyank Gupta shreya...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs+

--- Comment #17 from Shreyank Gupta shreya...@gmail.com 2010-06-14 11:30:21 
EDT ---
New Package CVS Request
===
Package Name: rubygem-sup
Short Description: A console-based email client written in ruby
Owners: shreyankg
Branches: F-13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601633] Review Request: rubygem-sup - A console-based email client written in ruby

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601633

--- Comment #18 from Shreyank Gupta shreya...@gmail.com 2010-06-14 11:42:19 
EDT ---
UPDATED:
-

Spec URL: http://shreyankg.fedorapeople.org/packaging/sup/rubygem-sup.spec
SRPM URL:
http://shreyankg.fedorapeople.org/packaging/sup/rubygem-sup-0.10.2-5.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602767] Review Request: perl-MooseX-MarkAsMethods - Mark overload code symbols as methods

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602767

--- Comment #3 from Petr Pisar ppi...@redhat.com 2010-06-14 11:51:20 EDT ---
Both spelling errors are false; The words are literals (perl package name).

New version 0.09 does not provide fix. It still does not updates required
version in the module itself. Upstream noticed. Do you mind reviewing 0.08?
Both versions are almost identical.

The 0.08 spec includes both REAMDE files yet.

Marcela, could accept this package and set review flag to +?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

--- Comment #17 from Ankur Sinha sanjay.an...@gmail.com 2010-06-14 11:55:01 
EDT ---
(In reply to comment #16)
hey, 

Thank you for reviewing this :)

 Here's the formal review. The package looks almost fine to me, except one
 remaining aspect:
 - replace %{_includedir}/gexiv2/* with %{_includedir}/gexiv2/
   to make the package own the directory too (and not only the header files)
 ..
 ...
 [X] MUST: A package must own all directories that it creates.
 - directory %{_includedir}/gexiv2/ must be owned by the -devel package
 

Fixed it. 

new srpm :

http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2-0.0.91-2.fc13.src.rpm

new spec

http://ankursinha.fedorapeople.org/libgexiv2/libgexiv2.spec

rest of mock logs at 

http://ankursinha.fedorapeople.org/libgexiv2/

regards,
Ankur

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603269] Review Request: rubygem-plist - All-purpose Property List manipulation library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603269

--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-06-14 
12:21:10 EDT ---
Created an attachment (id=423896)
 -- (https://bugzilla.redhat.com/attachment.cgi?id=423896)
patch to make rake test succeed

Some notes:

* ruby(abi) dependency
  - ruby module packages must have R: ruby(abi) = 1.8.
https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines

* %prep, %build section:
  - From rpmlint

$ rpmlint -I 'no-%prep-section'
no-%prep-section:
The spec file does not contain a %prep section.  Even if some packages don't
directly need it, section markers may be overridden in rpm's configuration to
provide additional under the hood functionality.  Add the section, even if
empty.

i.e. (in the future) rpmbuild may do some additional needed procedure
before the contents written in %prep or %build begins.

So even if currently %prep or %build can be empty, please add them.

* %check
  - Doing rake test needs the attached patch.
( I guess that (although I have not checked it in detail)
  rdoc/task is in ruby 1.9. On Fedora rdoctask is in rake gem anyway )

* %doc in -doc subpackage
  - I think %doc attribute in -doc subpackage is redundant because
rpm's name already shows that this is for documentation.

! macros in comments
--
#export PATH=$PATH:%{buildroot}%{geminstdir}/lib/plist
#export LD_LIBRARY_PATH=$PATH:%{buildroot}%{geminstdir}/lib

--
  - These comment lines include macros and rpmlint warns for these:
--
rubygem-plist.src:51: W: macro-in-comment %{buildroot}
rubygem-plist.src:51: W: macro-in-comment %{geminstdir}
--

The reason rpmlint warns for macro-in-comment is that
during rpmbuild macros are expanded anyway, even in comment lines.
For this package this is safe, however if a defined macro contains
several lines, this can cause some strange behavior.
- For example, with #%configure, configure script is executed
  against expectation

So it is always recommended to excape macros in comment lines
using %% instead of %.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580169] Review Request: loggerhead - Web viewer for the Bazaar version control system

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580169

Toshio Ernie Kuratomi a.bad...@gmail.com changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||CURRENTRELEASE

--- Comment #15 from Toshio Ernie Kuratomi a.bad...@gmail.com 2010-06-14 
12:24:50 EDT ---
Looks like bodhi didn't close it... Closing now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

Martin Gieseking martin.giesek...@uos.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #18 from Martin Gieseking martin.giesek...@uos.de 2010-06-14 
12:49:14 EDT ---
(In reply to comment #17)
 Thank you for reviewing this :)

You're welcome.


  [X] MUST: A package must own all directories that it creates.
  - directory %{_includedir}/gexiv2/ must be owned by the -devel package
  
 Fixed it. 

OK, the package is ready now, and we can finish here. :)


Package APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601408] Review Request: techtalk-pse - Presentation software designed for technical people

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601408

Ian Weller i...@ianweller.org changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE

--- Comment #4 from Ian Weller i...@ianweller.org 2010-06-14 12:51:31 EDT ---
Files imported in CVS and are building now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603846] New: Review Request: libpeas - Plug-ins implementation convenience library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libpeas - Plug-ins implementation convenience library

https://bugzilla.redhat.com/show_bug.cgi?id=603846

   Summary: Review Request: libpeas - Plug-ins implementation
convenience library
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: bnoc...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://people.fedoraproject.org/~hadess/libpeas/libpeas.spec
SRPM URL:
http://people.fedoraproject.org/~hadess/libpeas/libpeas-0.5.0-1.fc13.src.rpm
Description: libpeas is a convenience library making adding plug-ins support to
GTK+ and glib-based applications.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

Ankur Sinha sanjay.an...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #19 from Ankur Sinha sanjay.an...@gmail.com 2010-06-14 13:06:00 
EDT ---
New Package CVS Request
===
Package Name: libgexiv2
Short Description: ligexiv2 is a GObject-based wrapper around the Exiv2 library
Owners: ankursinha
Branches: F-12 F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603846] Review Request: libpeas - Plug-ins implementation convenience library

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603846

--- Comment #1 from Bastien Nocera bnoc...@redhat.com 2010-06-14 13:06:52 EDT 
---
Updated to call ldconfig:
http://people.fedoraproject.org/~hadess/libpeas/libpeas-0.5.0-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581913] Review Request: python-simplegeneric - Simple generic functions (similar to Python's own len(), pickle.dump(), etc.)

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581913

--- Comment #12 from Fedora Update System upda...@fedoraproject.org 
2010-06-14 13:10:48 EDT ---
python-simplegeneric-0.6-2.fc12 has been pushed to the Fedora 12 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581913] Review Request: python-simplegeneric - Simple generic functions (similar to Python's own len(), pickle.dump(), etc.)

2010-06-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581913

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-simplegeneric-0.6-2.
   ||fc12
 Resolution||ERRATA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


  1   2   >