[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594806

--- Comment #10 from Stanislav Ochotnicky  2010-06-21 
02:38:47 EDT ---
(In reply to comment #9)
> Shouldn't this be named "jBCrypt" to match the case of the upstream project?
> 

>From packaging guidelines on naming:
While case sensitivity is not a mandatory requirement, case should only be used
where necessary. Keep in mind to respect the wishes of the upstream
maintainers. If they refer to their application as "ORBit", you should use
"ORBit" as the package name, and not "orbit". However, if they do not express
any preference of case, you should default to lowercase naming.


Upstream uses jBCrypt, but I am not sure how much they care about the case. Now
that I think about it I am leaning more towards jBCrypt too, but I would leave
it up to packager.


> Possibly you could run the TestBCrypt in %check section?

This is definitely a good idea, should have noticed too.


Sebastian? I suppose you don't mind the naming that much...so one more release
number with changed name and test run?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 542767] Review Request: ghemical - Molecular mechanics and quantum mechanics frontend for GNOME

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542767

--- Comment #5 from Carl Byington  2010-06-21 02:11:24 
EDT ---
http://www.five-ten-sg.com/ghemical.spec
http://www.five-ten-sg.com/ghemical-2.99.2-12.fc12.src.rpm 
http://koji.fedoraproject.org/koji/taskinfo?taskID=2261282

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 604695] Review Request: generatorrunner - Plugin-based application to run apiextractor-based generators

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604695

--- Comment #2 from Kalev Lember  2010-06-21 02:02:06 EDT 
---
* Mon Jun 21 2010 Kalev Lember  - 0.5.0-2
- Build html documentation and ship it in -devel subpackage
- Use Development/Tools for main package

Spec URL: http://kalev.fedorapeople.org/generatorrunner.spec
SRPM URL: http://kalev.fedorapeople.org/generatorrunner-0.5.0-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 550690] Review Request: libsurl - A library for generating shortened URLs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550690

Fabian Affolter  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #10 from Fabian Affolter  2010-06-21 
01:56:40 EDT ---
New Package CVS Request
===
Package Name: libsurl
Short Description: A library for generating shortened URLs
Owners: fab
Branches: F-12 F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 550690] Review Request: libsurl - A library for generating shortened URLs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550690

--- Comment #9 from Fabian Affolter  2010-06-21 
01:55:44 EDT ---
Thanks for your work, Michael.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606205] New: Review Request: halberd - Tool to discover HTTP load balancers

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: halberd - Tool to discover HTTP load balancers

https://bugzilla.redhat.com/show_bug.cgi?id=606205

   Summary: Review Request: halberd - Tool to discover HTTP load
balancers
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fab...@bernewireless.net
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fab.fedorapeople.org/packages/SRPMS/halberd.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/halberd-0.2.3-2.fc14.src.rpm

Project URL: http://halberd.superadditive.com

Description:
Halberd discovers HTTP load balancers. It is useful for web application
security auditing and for load balancer configuration testing.

This is a review request for an orphaned package.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2260381

rpmlint output:
[...@laptop011 SRPMS]$ rpmlint halberd-0.2.3-2.fc13.src.rpm 
halberd.src: W: spelling-error Summary(en_US) balancers -> balances, balance's,
balance rs
halberd.src: W: spelling-error %description -l en_US balancers -> balances,
balance's, balance rs
halberd.src: W: spelling-error %description -l en_US balancer -> balance,
balances, balanced
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[...@laptop011 noarch]$ rpmlint halberd-0.2.3-2.fc13.noarch.rpm
halberd.noarch: W: spelling-error Summary(en_US) balancers -> balances,
balance's, balance rs
halberd.noarch: W: spelling-error %description -l en_US balancers -> balances,
balance's, balance rs
halberd.noarch: W: spelling-error %description -l en_US balancer -> balance,
balances, balanced
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606205] Review Request: halberd - Tool to discover HTTP load balancers

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606205

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||563471(FE-SECLAB)
  Alias||halberd

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563471

Fabian Affolter  changed:

   What|Removed |Added

 Depends on||606205(halberd)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 604653] Review Request: perl-Test-NoTabs - Check the presence of tabs in your project

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604653

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+

--- Comment #1 from Parag AN(पराग)  2010-06-21 01:31:03 EDT 
---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261130
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
c76ac17b0988488f5b3a757fc119a8f2c8d6218e  Test-NoTabs-1.0.tar.gz.srpm
c76ac17b0988488f5b3a757fc119a8f2c8d6218e  Test-NoTabs-1.0.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=6, Tests=16,  1 wallclock secs ( 0.03 usr  0.00 sys +  0.48 cusr  0.07
csys =  0.58 CPU)
+ Package perl-Test-NoTabs-1.0-3.fc14.noarch =>
Provides: perl(Test::NoTabs) = 1.0
Requires: perl(File::Find) perl(File::Spec) perl(FindBin) perl(Test::Builder)
perl(strict) perl(vars) perl(warnings)
+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 604093] Review Request: perl-Test-Synopsis - Test your SYNOPSIS code

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604093

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+

--- Comment #1 from Parag AN(पराग)  2010-06-21 01:31:11 EDT 
---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2261162
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
7a72044c25cd4b2b15f44e131720f317b79e2c9a  Test-Synopsis-0.06.tar.gz.srpm
7a72044c25cd4b2b15f44e131720f317b79e2c9a  Test-Synopsis-0.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=7, Tests=8,  2 wallclock secs ( 0.04 usr  0.01 sys +  0.94 cusr  0.09
csys =  1.08 CPU)
+ Package perl-Test-Synopsis-0.06-4.fc14.noarch =>
Provides: perl(Test::Synopsis) = 0.06
Requires: perl >= 0:5.008_001 perl(base) perl(ExtUtils::Manifest) perl(strict)
rpmlib(VersionedDependencies) <= 3.0.3-1

+ Not a GUI application

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 578480] Review Request: spectrum - XMPP transport/gateway

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578480

Matej Cepl  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #45 from Matej Cepl  2010-06-21 01:29:36 EDT ---
(In reply to comment #44)
> CVS done (by process-cvs-requests.py).
> 
> Do you want a EL-6 branch as well? If so, add another change request and reset
> fedora-cvs again.

Yes, I do, sorry for forgetting that.

Package Change Request
==
Package Name: spectrum
New Branches: EL-6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606019] Review Request: python-distribute - Distribute is a drop-in replacement for Setuptools

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606019

--- Comment #4 from Toshio Ernie Kuratomi  2010-06-21 
01:01:21 EDT ---
The Debian package doesn't look like a good example to follow if I'm
understanding their package information page correctly.  They appear to have a
source package named distribute.  This builds binary packages for
python-setuptools.  It does not build a binary package for distribute at all.

If we replicated this in Fedora it would mean that things like reporting bugs
was confusing since the package name that everyone installed would have nothing
to do with the name of the component in bugzilla (similarly the cvs module to
checkout, srpm to download, pkgdb name to access ,etc).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 577152] Review Request: apiextractor - Library headers parser to extract API information

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577152

--- Comment #18 from Fedora Update System  
2010-06-21 00:53:56 EDT ---
apiextractor-0.6.0-4.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/apiextractor-0.6.0-4.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 604500] Review Request: ibus-input-pad - Input Pad for IBus

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604500

--- Comment #2 from fujiwara  2010-06-21 00:26:40 EDT ---
Any sponsors?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

--- Comment #21 from Fedora Update System  
2010-06-21 00:15:37 EDT ---
libgexiv2-0.0.91-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/libgexiv2-0.0.91-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #9 from Fedora Update System  2010-06-20 
23:48:06 EDT ---
xrootd-20100315-2.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/xrootd-20100315-2.el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #7 from Fedora Update System  2010-06-20 
23:47:46 EDT ---
xrootd-20100315-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/xrootd-20100315-2.fc12

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #8 from Fedora Update System  2010-06-20 
23:48:02 EDT ---
xrootd-20100315-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/xrootd-20100315-2.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #6 from Fedora Update System  2010-06-20 
23:47:42 EDT ---
xrootd-20100315-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/xrootd-20100315-2.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603295] Review Request: guava - Guava (Google Common Libraries)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603295

huwang  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

--- Comment #10 from huwang  2010-06-20 23:44:17 EDT ---
Built in koji : http://koji.fedoraproject.org/koji/buildinfo?buildID=178892

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 597597] Review Request: liblouis - A Braille translator and back-translator

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597597

--- Comment #4 from Chen Lei  2010-06-20 22:54:24 EDT ---
(In reply to comment #2)
> Thank you very much for your useful information!
> 
> The spec file found at  is now
> updated and should reflect the issues you mentioned. The release is
> increased, and accordingly the sources rpm is at
> .
> 
> While running rpmlint on the rpms, I get several warnings like this:
> 
>   liblouis-tools.i686: W: unstripped-binary-or-object
>   /usr/bin/lou_debug
> 
> However, building under mock, I don't get this problem. Why is it so?
> 
> Lars

Please install redhat-rpm-config/fedora-packager first.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 595637] Review Request: qoauth- Qt-based C++ library for OAuth authorization scheme

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595637

--- Comment #3 from Chen Lei  2010-06-20 22:46:49 EDT ---
(In reply to comment #1)
> 
> A few comments for now:
> - Is there a reason why you use %{?isa}? I don't think leaving them out will
> cause problems, but maybe I'm wrong...?
> This makes only sense, when using e.g:
> %ifarch %ix86
> Requires: %{name}.(i?86|athlon|geode)
> %endif
> %ifarch x86_64 amd64 ia32e
> Requires: %{name}.(x86_64|amd64|ia32e)
> %endif
> 
> Or is this common in KDE?
> (This is my first look at a KDE/qt package ever^^)
It's common in KDE packages, it's useless under most circumstance, but I still
suggest to use it when requires multiarch libs explicitly.

See https://fedoraproject.org/wiki/PackagingDrafts/ArchSpecificRequires

> 
> - You aren't consistend with tabbing:
>   4 Name:   qoauth
>   5 Version:1.0.1
>   6 Release:0.1.%{gitdate}git%{githash}%{?dist}
>   7 Summary:Qt-based C++ library for OAuth authorization 
> scheme
>   8 Group:  System Environment/Libraries
>   9 License:LGPLv2+
>  10 URL:http://github.com/ayoy/qoauth
> 
> Would be more readable otherwise.
> 
My Editor is wrong some days ago: ), will be fixed soon.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 595637] Review Request: qoauth- Qt-based C++ library for OAuth authorization scheme

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595637

Chen Lei  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Chen Lei  2010-06-20 22:38:39 EDT ---
New Package CVS Request
===
Package Name: qoauth
Short Description: Qt-based C++ library for OAuth authorization scheme
Owners: supercyper
Branches: F-12 F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 563481] Review Request: aduna-commons-i18n - Internationalization and localization utilities

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563481

Orcan 'oget' Ogetbil  changed:

   What|Removed |Added

   Flag||needinfo?(mefos...@gmail.co
   ||m)

--- Comment #9 from Orcan 'oget' Ogetbil  2010-06-20 
22:33:16 EDT ---
The package doesn't seem to be imported to cvs yet. Is there a problem?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

--- Comment #7 from Kevin Fenzi  2010-06-20 22:32:24 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605998] Review Request: python-pretty - Extensible pprint successor

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605998

--- Comment #3 from Kevin Fenzi  2010-06-20 22:32:50 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605853] Review Request: python-snpp - Simple Network Paging Protocol

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605853

--- Comment #7 from Kevin Fenzi  2010-06-20 22:31:04 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605808] Review Request: gtick - A Graphical Metronome Software

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605808

--- Comment #5 from Kevin Fenzi  2010-06-20 22:30:24 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

Mattias Ellert  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch
  QAContact|steve.tray...@cern.ch   |extras...@fedoraproject.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

--- Comment #12 from Kevin Fenzi  2010-06-20 22:28:44 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605329] Review Request: gnome-desktop3 - Shared code among gnome-panel, gnome-session, nautilus, etc

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605329

--- Comment #4 from Kevin Fenzi  2010-06-20 22:26:17 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603514] Review Request: libmodman - A simple library for managing C++ modules (plug-ins)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603514

--- Comment #23 from Kevin Fenzi  2010-06-20 22:23:24 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603521] Review Request: pynetsnmp - Python ctypes bindings for NET-SNMP with Twisted integration

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603521

--- Comment #13 from Kevin Fenzi  2010-06-20 22:25:36 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603518] Review Request: pyip - Python assembling/disassembling of raw ip packets

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603518

--- Comment #8 from Kevin Fenzi  2010-06-20 22:24:07 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602960] Review Request: maven-eclipse-plugin - Maven Eclipse Plugin

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602960

--- Comment #4 from Kevin Fenzi  2010-06-20 22:17:30 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603295] Review Request: guava - Guava (Google Common Libraries)

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603295

--- Comment #9 from Kevin Fenzi  2010-06-20 22:20:35 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603269] Review Request: rubygem-plist - All-purpose Property List manipulation library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603269

--- Comment #12 from Kevin Fenzi  2010-06-20 22:17:51 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 601160] Review Request: rubygem-rdiscount - Fast Implementation of Gruber's Markdown in C

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601160

--- Comment #14 from Kevin Fenzi  2010-06-20 22:15:43 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

--- Comment #20 from Kevin Fenzi  2010-06-20 22:14:42 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602791] Review Request: xrootd - Extended ROOT file server

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602791

--- Comment #5 from Kevin Fenzi  2010-06-20 22:16:34 EDT ---
CVS done (by process-cvs-requests.py).

Please remember to assign the review to the reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 594806] Review Request: jbcrypt - Strong password hashing for Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=594806

--- Comment #9 from Kevin Fenzi  2010-06-20 22:14:18 EDT ---
Shouldn't this be named "jBCrypt" to match the case of the upstream project?

Possibly you could run the TestBCrypt in %check section?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 600638] Review Request: seed - GNOME JavaScript interpreter

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600638

--- Comment #8 from Kevin Fenzi  2010-06-20 22:15:14 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 593841] Review Request: wicd - Wireless and wired network connection manager

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=593841

--- Comment #39 from Kevin Fenzi  2010-06-20 22:08:01 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 590387] Review Request: lcms2 - Color Management System

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590387

--- Comment #12 from Kevin Fenzi  2010-06-20 22:01:58 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 591011] Review Request: kfilefactory - An easy to use filefactory.com uploader

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591011

--- Comment #11 from Kevin Fenzi  2010-06-20 22:03:18 EDT ---
CVS done (by process-cvs-requests.py).

We are not yet doing F-14 branches.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 578480] Review Request: spectrum - XMPP transport/gateway

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=578480

--- Comment #44 from Kevin Fenzi  2010-06-20 22:00:16 EDT ---
CVS done (by process-cvs-requests.py).

Do you want a EL-6 branch as well? If so, add another change request and reset
fedora-cvs again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 463133] Review Request: perl-Log-Dispatch-Perl - Use core Perl functions for logging

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=463133

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #15 from Kevin Fenzi  2010-06-20 21:51:45 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 542765] Review Request: libghemical - Libraries for the Ghemical chemistry package

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542765

--- Comment #20 from Kevin Fenzi  2010-06-20 21:53:36 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 577152] Review Request: apiextractor - Library headers parser to extract API information

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577152

--- Comment #17 from Kevin Fenzi  2010-06-20 21:55:14 EDT ---
CVS done (by process-cvs-requests.py).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 485586] Review Request: perl-Test-Kwalitee - Test the Kwalitee of a distribution before you release it

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485586

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |

--- Comment #5 from Kevin Fenzi  2010-06-20 21:52:41 EDT ---
Should the package name be 'perl-Test-Kwalitee' ? 

Doublecheck and reset the fedora-cvs flag.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 191624] Review Request: perl-Test-Expect - Automated driving and testing of terminal-based programs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=191624

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #7 from Kevin Fenzi  2010-06-20 21:50:33 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 165906] Review Request: perl-Test-WWW-Mechanize - Testing-specific WWW::Mechanize subclass

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=165906

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #4 from Kevin Fenzi  2010-06-20 21:48:14 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 165650] Review Request: perl-WWW-Mechanize - Automates web page form & link interaction

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=165650

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #8 from Kevin Fenzi  2010-06-20 21:47:07 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 516281] Review Request: perl-Config-Model-TkUI - Tk GUI to edit config data through Config::Model

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516281

Emmanuel Seyman  changed:

   What|Removed |Added

  Status Whiteboard|NotReady BuildFails |
   Flag|fedora-review?  |fedora-review+

--- Comment #8 from Emmanuel Seyman  
2010-06-20 18:31:33 EDT ---

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2260663

 [x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
 The package is LGPLv2+ but the spec file says LGPLv2

 [-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
0defa093613382a28a89e5221c224df2  Config-Model-TkUI-1.306.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [-] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
 Tested on: 
 [x] Package should compile and build into binary rpms on all supported
architectures.
 Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2260663
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=3, Tests=10,  1 wallclock secs ( 0.02 usr  0.02 sys +  0.76 cusr  0.08
csys =  0.88 CPU)
Result: PASS

David, please put LGPLv2+ in the License field before check-in.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

Christian Krause  changed:

   What|Removed |Added

 CC||c...@plauener.de

--- Comment #11 from Christian Krause  2010-06-20 18:30:27 
EDT ---
*** Bug 606146 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606146] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606146

Christian Krause  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||DUPLICATE

--- Comment #2 from Christian Krause  2010-06-20 18:30:27 EDT 
---
ARGH - race condition: I checked the open reviews and the packagedb - since the
package just got approved but is not yet added to CVS I haven't found it...

*** This bug has been marked as a duplicate of bug 605784 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606146] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606146

--- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus)  
2010-06-20 18:18:53 EDT ---
Duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=605784 ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606146] New: Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: googlecl - Command line tools for the Google Data APIs

https://bugzilla.redhat.com/show_bug.cgi?id=606146

   Summary: Review Request: googlecl - Command line tools for the
Google Data APIs
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: c...@plauener.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://chkr.fedorapeople.org/review/googlecl.spec
SRPM URL: http://chkr.fedorapeople.org/review/googlecl-0.9.7-1.fc12.src.rpm
Description: 
GoogleCL brings Google services to the command line.

The following Google services are currently supported:
- Blogger
- Calendar
- Contacts
- Docs
- Picasa
- Youtube

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 600835] Review Request: modplugtools - Command line mod music players

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600835

Michael Schwendt  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com

--- Comment #1 from Michael Schwendt  2010-06-20 17:38:04 
EDT ---
* The format string warnings during build are low-hanging fruit.  Plus, in
modplug123.c, fixing the sprintf/printf leads to discovering that the value
"order" is an uninitialized array/C-string.

* "modplug123 --help" refers to itself also as "modplugplay", which is a tiny
bug.

* "License: GPL+" but files AUTHORS and COPYING refer to GPLv3 only.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 516281] Review Request: perl-Config-Model-TkUI - Tk GUI to edit config data through Config::Model

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516281

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|emmanuel.sey...@club-intern
   ||et.fr
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 532520] Review request: derby - An open source database implemented entirely in Java

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532520

Sebastian Dziallas  changed:

   What|Removed |Added

 CC||sebast...@when.com

--- Comment #4 from Sebastian Dziallas  2010-06-20 17:01:00 
EDT ---
Ping again? Etherpad also depends on this package
(http://fedoraproject.org/wiki/Etherpad) and hence I'm interested in seeing
this in Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 550690] Review Request: libsurl - A library for generating shortened URLs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550690

Michael Schwendt  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mschwe...@gmail.com
   Flag||fedora-review+

--- Comment #8 from Michael Schwendt  2010-06-20 16:32:40 
EDT ---
libsurl-0.7.1-2.fc12.src.rpm

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 573294] Review Request: kadu - An instant messanger compatile with the Gadu-Gadu protocol

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573294

--- Comment #13 from Radek L  2010-06-20 16:17:25 
EDT ---
Waiting for Dominik to finish this sponsor thing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606127] New: Review Request: colortool - useful tool for web-designers/graphic artists

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: colortool - useful tool for web-designers/graphic 
artists

https://bugzilla.redhat.com/show_bug.cgi?id=606127

   Summary: Review Request: colortool - useful tool for
web-designers/graphic artists
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: tobias.vo...@bluewin.ch
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://colortool.googlecode.com/files/colortool-0.99-20102006svn.fc13.spec
SRPM URL:
http://colortool.googlecode.com/files/colortool-0.99-20102006svn.fc13.src.rpm
Description: converts between color models, chooses web-safe colors & generates
color-charts
PLEASE NOTE: This is my first package and I am looking for a sponsor. Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606127] Review Request: colortool - useful tool for web-designers/graphic artists

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606127

Tobias Vogel  changed:

   What|Removed |Added

 Blocks||177841(FE-NEEDSPONSOR)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 573294] Review Request: kadu - An instant messanger compatile with the Gadu-Gadu protocol

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573294

--- Comment #12 from Julian Sikorski  2010-06-20 14:52:42 
EDT ---
ping

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

--- Comment #10 from Adam Goode  2010-06-20 13:21:17 EDT ---
(In reply to comment #8)
> Please do a "noarch" for everybody including fc10, fc11, etc... and NOT fc12,
> f13, etc.  From the site:
> 

Sorry, this is not allowed:
http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#New_Packages


You may be able to rebuild the packages yourself from the SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

--- Comment #9 from Adam Goode  2010-06-20 13:20:08 EDT ---
(In reply to comment #7)
> 0.9.7 is released

Ok, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 542765] Review Request: libghemical - Libraries for the Ghemical chemistry package

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542765

Carl Byington  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 567877] Review Request: vnc2flv - Screen recording tool that captures a VNC session and saves as FLV

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567877

--- Comment #2 from Chen Lei  2010-06-20 13:03:16 EDT ---
> Needswork:
> -
> https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
>   better use the new python defines from
> https://fedoraproject.org/wiki/Packaging:Python#Macros

I'll modify it against latest guideline.

> - Summary might be too long to display everywhere. How about
>   "VNC recording tool that saves session as FLV" ?
I copy this summary from PKG-INFO, I'll try to shorten it in next release.

> - Why so much R? xorg-x11-utils alsa-utils and gawk should be added
> automatically, when the *.so requires it. So it seems, it doesn't.
>   (Couldn't find something about this in a *.py file, can you give me a
> pointer?)
vnc2flv-recordwin.sh use those utilities.

> - %doc also needs to contain README.rst
> - add a %check section e.g.:
>   %check
>   PYTHONPATH=%{buildroot}%{python_sitearch} python flvscreen/test.py
> - %files contains hardcoded python version and version of this package
>   There will be likely a python 2.7, so this will fails building, please 
> change
> it to e.g.: %{python_sitearch}/vnc2flv-%{version}-py?.?.egg-info
Will be fixed in next release.

> ##
>  blocking FE-LEGAL ###
> - I'm unsure about the license. A comment from vnc2flv/d3des.py:
> # This is a Python rewrite of d3des.c by Richard Outerbridge.
> #
> # I referred to the original VNC viewer code for the changes that
> # is necessary to maintain the exact behavior of the VNC protocol.
> # Two constants and two functions were added to the original d3des
> # code.  These added parts were written in Python and marked
> # below.  I believe that the added parts do not make this program
> # a "derivative work" of the VNC viewer (which is GPL'ed and
> # written in C), but if there's any problem, let me know.
> #
> # Yusuke Shinyama (yusuke at cs dot nyu dot edu)
> #  D3DES (V5.09) -
> #
> #  A portable, public domain, version of the Data Encryption Standard.
> #
> #  Written with Symantec's THINK (Lightspeed) C by Richard Outerbridge.
> #  Thanks to: Dan Hoey for his excellent Initial and Inverse permutation
> #  code;  Jim Gillogly & Phil Karn for the DES key schedule code; Dennis
> #  Ferguson, Eric Young and Dana How for comparing notes; and Ray Lau,
> #  for humouring me on.
> #
> #  Copyright (c) 1988,1989,1990,1991,1992 by Richard Outerbridge.
> #  (GEnie : OUTER; CIS : [71755,204]) Graven Imagery, 1992.
> #
> -> "two functions were *ADDED* to the *ORIGINAL* d3des code" etc
>So I'd say this also needs to be GPL'ed like d3des and not MIT
> spot, what do you think?

The license is Okay, unless d3des.py has some patent issues, I won't think it's
a block for vnc2flv.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

Rick Richardson  changed:

   What|Removed |Added

 CC||rick.richard...@comcast.net
Version|rawhide |11

--- Comment #8 from Rick Richardson  2010-06-20 
11:52:30 EDT ---
Please do a "noarch" for everybody including fc10, fc11, etc... and NOT fc12,
f13, etc.  From the site:

"GoogleCL is a pure Python application".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 567877] Review Request: vnc2flv - Screen recording tool that captures a VNC session and saves as FLV

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567877

Thomas Spura  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||toms...@fedoraproject.org
 Blocks||182235(FE-Legal)
 AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org
   Flag||fedora-review?

--- Comment #1 from Thomas Spura  2010-06-20 
11:45:41 EDT ---
Review:

Good:
- group ok
- name ok (this is also a python module, but will mainly used from commandline)
- libs correctly packaged
- no *.la

Needswork:
-
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
  better use the new python defines from
https://fedoraproject.org/wiki/Packaging:Python#Macros

- Summary might be too long to display everywhere. How about
  "VNC recording tool that saves session as FLV" ?

- Why so much R? xorg-x11-utils alsa-utils and gawk should be added
automatically, when the *.so requires it. So it seems, it doesn't.
  (Couldn't find something about this in a *.py file, can you give me a
pointer?)

- %doc also needs to contain README.rst

- add a %check section e.g.:
  %check
  PYTHONPATH=%{buildroot}%{python_sitearch} python flvscreen/test.py

- %files contains hardcoded python version and version of this package
  There will be likely a python 2.7, so this will fails building, please change
it to e.g.: %{python_sitearch}/vnc2flv-%{version}-py?.?.egg-info


##
 blocking FE-LEGAL ###

- I'm unsure about the license. A comment from vnc2flv/d3des.py:
# This is a Python rewrite of d3des.c by Richard Outerbridge.
#
# I referred to the original VNC viewer code for the changes that
# is necessary to maintain the exact behavior of the VNC protocol.
# Two constants and two functions were added to the original d3des
# code.  These added parts were written in Python and marked
# below.  I believe that the added parts do not make this program
# a "derivative work" of the VNC viewer (which is GPL'ed and
# written in C), but if there's any problem, let me know.
#
# Yusuke Shinyama (yusuke at cs dot nyu dot edu)


#  D3DES (V5.09) -
#
#  A portable, public domain, version of the Data Encryption Standard.
#
#  Written with Symantec's THINK (Lightspeed) C by Richard Outerbridge.
#  Thanks to: Dan Hoey for his excellent Initial and Inverse permutation
#  code;  Jim Gillogly & Phil Karn for the DES key schedule code; Dennis
#  Ferguson, Eric Young and Dana How for comparing notes; and Ray Lau,
#  for humouring me on.
#
#  Copyright (c) 1988,1989,1990,1991,1992 by Richard Outerbridge.
#  (GEnie : OUTER; CIS : [71755,204]) Graven Imagery, 1992.
#

-> "two functions were *ADDED* to the *ORIGINAL* d3des code" etc
   So I'd say this also needs to be GPL'ed like d3des and not MIT

spot, what do you think?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 595637] Review Request: qoauth- Qt-based C++ library for OAuth authorization scheme

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595637

Thomas Spura  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||toms...@fedoraproject.org
 Blocks||595638
 AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org
   Flag||fedora-review+

--- Comment #1 from Thomas Spura  2010-06-20 
09:56:42 EDT ---
I have a slow internet connection atm.

Will do a full review, when I can download the qt stuff this week...

A few comments for now:
- Is there a reason why you use %{?isa}? I don't think leaving them out will
cause problems, but maybe I'm wrong...?
This makes only sense, when using e.g:
%ifarch %ix86
Requires: %{name}.(i?86|athlon|geode)
%endif
%ifarch x86_64 amd64 ia32e
Requires: %{name}.(x86_64|amd64|ia32e)
%endif

Or is this common in KDE?
(This is my first look at a KDE/qt package ever^^)

- You aren't consistend with tabbing:
  4 Name:   qoauth
  5 Version:1.0.1
  6 Release:0.1.%{gitdate}git%{githash}%{?dist}
  7 Summary:Qt-based C++ library for OAuth authorization scheme
  8 Group:  System Environment/Libraries
  9 License:LGPLv2+
 10 URL:http://github.com/ayoy/qoauth

Would be more readable otherwise.

- checksum does not match (which is excpected, because of the timestamps):
  diff -r is clean

- name ok
- koji successfull: http://koji.fedoraproject.org/koji/taskinfo?taskID=2259994
- rpmlint ok:
$ rpmlint ./qoauth-1.0.1-0.1.20100525gitec7e4d5.fc13.src.rpm ./x86_64/qoauth-*
qoauth.src:11: W: macro-in-comment %{version}
qoauth.src:11: W: macro-in-comment %{name}
qoauth.src:11: W: macro-in-comment %{version}
qoauth.src:14: W: macro-in-comment %h
qoauth.src:14: W: macro-in-comment %h
qoauth.src: W: no-cleaning-of-buildroot %install
qoauth.src: W: no-buildroot-tag
qoauth.src: W: invalid-url Source0: qoauth-ec7e4d5.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 8 warnings.

macro-in-comment could be avoided when using s/%/%%/g.

- libs correctly packaged
- no static libs
- no *.la
- parallel make is there
- BR/R ok
- doc is not too big, to need to split in a subpackage

#

Only cosmetic issues: macro-in-comment + tabbing + %{?isa}.

#

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 595638] Review Request: qwit- Qt4 cross-platform client for Twitter

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595638

Thomas Spura  changed:

   What|Removed |Added

 Depends on||595637

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

--- Comment #6 from Chen Lei  2010-06-20 09:19:44 EDT ---
(In reply to comment #4)
> Thanks for the fast review again :)
> (In reply to comment #2)
> > I suggest using python instead of %{__python} in python guideline, because 
> > __*
> > macros are rarely documented in all other fedora packging guidelines.
> > 
> > rpm --eval %__python
> > /usr/bin/python
> > 
> > rpm --eval %__rm
> > /bin/rm
> It's often used e.g. in:
> https://fedoraproject.org/wiki/Packaging:Python
> I guess almost every python program uses %{__python} instead of just python,
> because rpmdev-newspec is proposing this...
> I think, it would be inconsistend to use simply 'python'. Maybe the packaging
> commitee can decide something new, to not use such macros anymore...

I guess packaging python guideline is the only place to use those __* macros :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

--- Comment #4 from Thomas Spura  2010-06-20 
08:59:05 EDT ---
Thanks for the fast review again :)

(In reply to comment #2)
> I suggest using python instead of %{__python} in python guideline, because __*
> macros are rarely documented in all other fedora packging guidelines.
> 
> rpm --eval %__python
> /usr/bin/python
> 
> rpm --eval %__rm
> /bin/rm

It's often used e.g. in:
https://fedoraproject.org/wiki/Packaging:Python

I guess almost every python program uses %{__python} instead of just python,
because rpmdev-newspec is proposing this...

I think, it would be inconsistend to use simply 'python'. Maybe the packaging
commitee can decide something new, to not use such macros anymore...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

Thomas Spura  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Thomas Spura  2010-06-20 
08:59:59 EDT ---
New Package CVS Request
===
Package Name: python-mglob
Short Description: Enhanced file name globbing module
Owners: tomspur
Branches: F-12 F-13 EL-5 EL-6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605784] Review Request: googlecl - Command line tools for the Google Data APIs

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605784

--- Comment #7 from Chen Lei  2010-06-20 08:43:16 EDT ---
0.9.7 is released

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

Chen Lei  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #3 from Chen Lei  2010-06-20 08:22:25 EDT ---
This package is approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

--- Comment #2 from Chen Lei  2010-06-20 08:22:03 EDT ---
rpmlint python-mglob-0.4-1.fc14.noarch.rpm 
python-mglob.noarch: W: spelling-error Summary(en_US) globbing -> globing,
gobbing, lobbing
python-mglob.noarch: W: spelling-error %description -l en_US xargs -> Argus,
Argos, argals
python-mglob.noarch: W: spelling-error %description -l en_US backticks -> back
ticks, back-ticks, backtracks
python-mglob.noarch: W: spelling-error %description -l en_US globbing ->
globing, gobbing, lobbing
python-mglob.noarch: W: no-documentation
python-mglob.noarch: W: no-manual-page-for-binary mglob
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

All can be ignored.

mdsum matches upstream tarball
3d875720611ff4e73b402376e2b48f1b mglob-0.4.zip

I suggest using python instead of %{__python} in python guideline, because __*
macros are rarely documented in all other fedora packging guidelines.

rpm --eval %__python
/usr/bin/python

rpm --eval %__rm
/bin/rm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605993] Review Request: python-mglob - Enhanced file name globbing module

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605993

Chen Lei  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||supercyp...@gmail.com
 AssignedTo|nob...@fedoraproject.org|supercyp...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 604695] Review Request: generatorrunner - Plugin-based application to run apiextractor-based generators

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604695

--- Comment #1 from Chen Lei  2010-06-20 07:54:33 EDT ---
I think Group:  Development/Tools will be appopriate than
Development/Libraries for generatorrrunner

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Fabian Affolter  changed:

   What|Removed |Added

  Alias||vinetto

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 577152] Review Request: apiextractor - Library headers parser to extract API information

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577152

Chen Lei  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #16 from Chen Lei  2010-06-20 07:46:07 EDT 
---
(In reply to comment #14)
> (In reply to comment #13)
> > Group for apoextractor should be Group:  System 
> > Environment/Libraries,
> > Development/Libraries is for -devel only.
> I'll change that, thanks.
> By the way, do you know of any Fedora guidelines for choosing RPM groups? I
> guess there are none, since RPM groups are pretty much obsoleted by comps.
NO guideline as I known, but comps can not replace rpm group because most
libraries are not registerd in comps.

> > I noticed apiextractor rpm for opensuse patched the place of cmake modules 
> > from
> > %{_libdir}/cmake/ApiExtractor-%{version}/ to %{_libdir}/cmake/ApiExtractor, 
> > I'
> > not sure if it's needed.
> No idea why they would want to do that. CMake searches both directories for
> module configuration files, so there is really no advantage using one over
> other.
> Do you have a link to that opensuse package? 

No difference between the two places for cmake modules I think, but we still
need a convention to treat cmake modules.

See 
http://www.pyside.org/downloads/

http://download.opensuse.org/repositories/home:/cgoncalves:/pyside:/

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606073] Review Request: xmount - A on-the-fly convert for multiple hard disk image types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606073

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||563471(FE-SECLAB)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606073] Review Request: xmount - A on-the-fly convert for multiple hard disk image types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606073

Fabian Affolter  changed:

   What|Removed |Added

  Alias||xmount

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563471

Fabian Affolter  changed:

   What|Removed |Added

 Depends on||606073

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606073] Review Request: xmount - A on-the-fly convert for multiple hard disk image types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606073

Fabian Affolter  changed:

   What|Removed |Added

  Status Whiteboard||NotReady

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606073] New: Review Request: xmount - A on-the-fly convert for multiple hard disk image types

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: xmount - A on-the-fly convert for multiple hard disk 
image types

https://bugzilla.redhat.com/show_bug.cgi?id=606073

   Summary: Review Request: xmount - A on-the-fly convert for
multiple hard disk image types
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fab...@bernewireless.net
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fab.fedorapeople.org/packages/SRPMS/xmount.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/xmount-0.4.2-1.fc13.src.rpm

Project URL: https://www.pinguin.lu/index.php

Description:
xmount allows you to convert on-the-fly between multiple input
and output hard disk image types. xmount creates a virtual file
system using FUSE (Filesystem in Userspace) that contains a virtual
representation of the input image. The virtual representation can
be in raw DD, VirtualBox's virtual disk file format or in VmWare's
VMDK file format. Input images can be raw DD, EWF (Expert Witness
Compression Format) or AFF (Advanced Forensic Format) files. In
addition, xmount also supports virtual write access to the output
files that is redirected to a cache file. This makes it possible
to boot acquired hard disk images using QEMU, KVM, VirtualBox,
VmWare or alike.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2259722

rpmlint output:
[...@laptop011 SRPMS]$ rpmlint xmount-0.4.2-1.fc13.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[...@laptop011 x86_64]$ rpmlint xmount*
xmount-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xmount-0.4.2/xmount.h
xmount-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/xmount-0.4.2/xmount.c
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

At the moment there is an issue with the afflib stuff.
checking afflib.h usability... no
checking afflib.h presence... no
checking for afflib.h... no
configure: WARNING: No afflib.h header file found! AFF input support will be
disabled.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563471

Fabian Affolter  changed:

   What|Removed |Added

 Depends on||606071

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606071] New: Review Request: vinetto - A forensics tool to examine Thumbs.db files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: vinetto - A forensics tool to examine Thumbs.db files

https://bugzilla.redhat.com/show_bug.cgi?id=606071

   Summary: Review Request: vinetto - A forensics tool to examine
Thumbs.db files
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fab...@bernewireless.net
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fab.fedorapeople.org/packages/SRPMS/vinetto.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/vinetto-0.07-1.beta.fc13.src.rpm

Project URL: http://vinetto.sourceforge.net/

Description:
Vinetto is a forensics tool to examine Thumbs.db files.  It is
a console program to extract thumbnail images and their metadata
from those thumbs.db files generated under Microsoft Windows

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2259799

rpmlint output:
[...@laptop011 SRPMS]$ rpmlint vinetto-0.07-1.beta.fc13.src.rpm 
vinetto.src: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[...@laptop011 noarch]$ rpmlint vinetto-0.07-1.beta.fc13.noarch.rpm 
vinetto.noarch: W: spelling-error %description -l en_US metadata -> meta data,
meta-data, metatarsus
vinetto.noarch: W: no-manual-page-for-binary vinetto
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606071] Review Request: vinetto - A forensics tool to examine Thumbs.db files

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606071

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||563471(FE-SECLAB)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 605998] Review Request: python-pretty - Extensible pprint successor

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=605998

Thomas Spura  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Thomas Spura  2010-06-20 
07:04:22 EDT ---
Thanks, for the review :)

I intent to follow upstream a bit more closely, so hopefully, I'll notice, when
upstreams bundled lib is outdated in comparison with this one...

###

New Package CVS Request
===
Package Name: python-pretty
Short Description: Extensible pprint successor
Owners: tomspur
Branches: F-12 F-13 EL-5 EL-6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 577152] Review Request: apiextractor - Library headers parser to extract API information

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577152

--- Comment #15 from Kalev Lember  2010-06-20 07:01:29 EDT 
---
Updated owners list.

New Package CVS Request
===
Package Name: apiextractor
Short Description: Library headers parser to extract API information
Owners: kalev rdieter kkofler than ltinkl
Branches: F-13
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 606064] New: Review Request: libfc14audiodecoder - C wrapper library for Future Composer audio decoding

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libfc14audiodecoder - C wrapper library for Future 
Composer audio decoding

https://bugzilla.redhat.com/show_bug.cgi?id=606064

   Summary: Review Request: libfc14audiodecoder - C wrapper
library for Future Composer audio decoding
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mschwe...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://mschwendt.fedorapeople.org/libfc14audiodecoder.spec
SRPM URL:
http://mschwendt.fedorapeople.org/libfc14audiodecoder-1.0.0-1.fc13.src.rpm
Description: This library provides a C API for a Future Composer audio decoder,
which
has been used in several plug-ins for versatile audio players like XMMS,
BMP, Audacious and GStreamer.


This library will be needed for future updates of gstreamer-plugins-fc and
audacious-plugin-fc.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 577152] Review Request: apiextractor - Library headers parser to extract API information

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=577152

--- Comment #14 from Kalev Lember  2010-06-20 06:26:38 EDT 
---
(In reply to comment #13)
> Group for apoextractor should be Group:  System Environment/Libraries,
> Development/Libraries is for -devel only.

I'll change that, thanks.

By the way, do you know of any Fedora guidelines for choosing RPM groups? I
guess there are none, since RPM groups are pretty much obsoleted by comps.


> I noticed apiextractor rpm for opensuse patched the place of cmake modules 
> from
> %{_libdir}/cmake/ApiExtractor-%{version}/ to %{_libdir}/cmake/ApiExtractor, I'
> not sure if it's needed.

No idea why they would want to do that. CMake searches both directories for
module configuration files, so there is really no advantage using one over
other.

Do you have a link to that opensuse package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 603269] Review Request: rubygem-plist - All-purpose Property List manipulation library

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603269

Gerd Pokorra  changed:

   What|Removed |Added

URL||http://plist.rubyforge.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 516717] Review Request: viewnior - Elegant Image Viewer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516717

Christoph Wickert  changed:

   What|Removed |Added

 CC||talj...@fedoraproject.org

--- Comment #23 from Christoph Wickert  2010-06-20 
05:43:50 EDT ---
*** Bug 599230 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 601160] Review Request: rubygem-rdiscount - Fast Implementation of Gruber's Markdown in C

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601160

Gerd Pokorra  changed:

   What|Removed |Added

URL||http://github.com/rtomayko/
   ||rdiscount

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 599230] Review Request: viewnior - The Elegant Image Viewer

[bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599230

Christoph Wickert  changed:

   What|Removed |Added

 CC||cwick...@fedoraproject.org
 Resolution|NOTABUG |DUPLICATE

--- Comment #3 from Christoph Wickert  2010-06-20 
05:43:50 EDT ---


*** This bug has been marked as a duplicate of bug 516717 ***

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review