[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622272

Remi Collet  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #6 from Remi Collet  2010-08-10 00:56:30 
EDT ---
New Package SCM Request
===
Package Name: mysql-connector-c++
Short Description: MySQL database connector for C++ 
Owners: remi
Branches: F-13 F-14 EL-5 EL-6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622272

--- Comment #5 from Remi Collet  2010-08-10 00:53:29 
EDT ---
Thanks for the quick review.

I know about buildroot, but as far as EL-5 exists, as I like to keep the same
spec for all branch when possible, I prefer to keep it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621713

--- Comment #10 from Germán Racca  2010-08-09 23:58:18 EDT ---
(In reply to comment #9)
> https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
> 

"The first thing to consider is that you cannot use COPYING to determine
license versioning..."

You are right Mamoru, sorry :)

Regards,
Germán.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 592733] Review Request: turpial - Is cool twitter client with many features and very light

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592733

--- Comment #12 from Chen Lei  2010-08-09 23:57:04 EDT 
---
(In reply to comment #11)
> Thanks to feed back Chen:
> 
> 5.
> 
> %attr(0755,root,root) %{python_sitelib}/%{name}/main.py
> Why add excutable bit for main.py?
> 
> This is due to the error message that provides rpmlint:
> 
> turpial.noarch: E: non-executable-script
> /usr/lib/python2.6/site-packages/turpial/main.py 0644L /usr/bin/python
> 
> 
You should remove shebang from this file instead of adding excutable bit.

See http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_files

> 
> Now is required to place a manual page for each executable? :
> 
> turpial.noarch: W: no-manual-page-for-binary turpial

Just ignore this warnings, most rpmlint warnings can be safely ignored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622270] Review Request: elementary-icon-theme - icons from the Elementary Project

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622270

Germán Racca  changed:

   What|Removed |Added

 CC||gra...@gmail.com

--- Comment #5 from Germán Racca  2010-08-09 23:50:12 EDT ---
Add the following line:

%doc elementary/{AUTHORS,CONTRIBUTORS,COPYING}

(not tested!)

Regards,
Germán.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621713

--- Comment #9 from Mamoru Tasaka  2010-08-09 
23:49:31 EDT ---
(In reply to comment #8)
> Question:
> 
> I don't know why GPL+ if there is a file saying explicitly that the license is
> GPLv3+...who can explain me that?
> 

(In reply to comment #1)

> * License
>   - In the zip file I see only GPLv3 "COPYING.txt" is included
> and no other information cannot be found in the zip
> which specifies the version of GPL this zip is licensed under.
> 
> In this case we regard that this zip is licensed under "GPL+"
> (GPL at any version), see:
>
> https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621713

Germán Racca  changed:

   What|Removed |Added

 CC||gra...@gmail.com

--- Comment #8 from Germán Racca  2010-08-09 23:27:25 EDT ---
Question:

I don't know why GPL+ if there is a file saying explicitly that the license is
GPLv3+...who can explain me that?

Tarjidin:

You can contact upstream and ask him to put the version of each release in the
name of the zip file, as for example: Faenza_Icons_by_tiheum_0.5.zip

Also you can change:

%dir %{_datadir}/icons/Faenza
%{_datadir}/icons/Faenza/*
%dir %{_datadir}/icons/Faenza-Dark
%{_datadir}/icons/Faenza-Dark/*

by

%{_datadir}/icons/Faenza/
%{_datadir}/icons/Faenza-Dark/

so in that way you own directories and also the contents. I think it is more
compact :)

Regards,
Germán.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #7 from Chen Lei  2010-08-09 23:21:15 EDT ---
(In reply to comment #6)
> Ok. Everything seems reasonable except the perl dependency.
> 
> One cannot omit build requires just because they can be interfered from a
> package of the system build requires list (in this case the perl is pulled
> because of rpm-build and redhat-rpm-config).
> 
> The reason is the concrete base package implementation can change resulting on
> not pulling perl anymore. (Imagine some crazy man rewrites rpm-build from Perl
> into Python).

OK, apply those changes and keep perl as a BR, then I'll approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622272

Chen Lei  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Chen Lei  2010-08-09 23:18:03 EDT ---
OK, this package is approved.

FYI, you can also remove BuildRoot and rm -rf %{buildroot} in %install section
for all current fedora release and %clean section in F13 and above.

See http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 473348] Review Request: drraw - Web based presentation front-end for RRDtool

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473348

--- Comment #10 from Rafael Aquini  2010-08-09 22:50:53 EDT 
---
Xavier,

It's been a week since I've posted a formal review to this package of yours
without having a single reply from you. Please, let me know if you are facing
any difficulty to finish this work, and tell me how can I help you.

If you, for instance, just lost your interest in getting this work reviewed,
let me aware as well.

Regards.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 539989] Review Request: nettop - top-like program for network packets

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539989

Rafael Aquini  changed:

   What|Removed |Added

 CC||aqu...@linux.com

--- Comment #7 from Rafael Aquini  2010-08-09 22:33:17 EDT ---
PING

Since it's been more than six months with no progress; I guess this bug should
be closed soon if there is no response, shouldn't it?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 608069] Review Request: tango - standard library for D language of d1 specification

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608069

--- Comment #63 from Juan Carlos Castro y Castro  
2010-08-09 21:59:30 EDT ---
[r...@mycomputer ~]# yum --enablerepo=updates-testing install tango
Loaded plugins: fastestmirror, presto, refresh-packagekit
Loading mirror speeds from cached hostfile
 * fedora: fedora.c3sl.ufpr.br
 * livna: rpm.livna.org
 * rpmfusion-free: mirror.hiwaay.net
 * rpmfusion-free-updates: mirror.hiwaay.net
 * rpmfusion-nonfree: mirror.hiwaay.net
 * rpmfusion-nonfree-updates: mirror.hiwaay.net
 * updates: fedora.c3sl.ufpr.br
 * updates-testing: fedora.c3sl.ufpr.br
Setting up Install Process
No package tango available.
Error: Nothing to do

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 524119] Review Request: nmon - Nigel's performance MONitor for Linux

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=524119

--- Comment #19 from d. johnson  2010-08-09 21:55:45 EDT 
---
Created an attachment (id=437742)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=437742)
Corrected spec file

After using the attached spec file, rpmlint only complains a little:

$ rpmlint *.rpm
nmon.src: W: spelling-error %description -l en_US analyser -> analyzer,
analysis, analyst
nmon.x86_64: W: spelling-error %description -l en_US analyser -> analyzer,
analysis, analyst
nmon.x86_64: W: no-manual-page-for-binary nmon
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

The author really needs to include a copy of the license file, and a man page
of some sort in the package itself.

Archiving off
http://www.ibm.com/developerworks/wikis/display/WikiPtype/nmon+Manual would be
better than nothing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498194

Jason Tibbitts  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+

--- Comment #43 from Jason Tibbitts  2010-08-09 21:57:42 EDT 
---
pkgdb is supposed to take the summary from the package itself.  Not sure why
that's not happening, but it's being worked on.  I tried to change it manually
and it looks like it took.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 618155] Review Request: python-SciMath - Scientific and Mathematical calculations

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618155

Bug 618155 depends on bug 618137, which changed state.

Bug 618137 Summary: Review Request: python-TraitsBackendWX - WxPython backend 
for Traits and TraitsGUI (Pyface)
https://bugzilla.redhat.com/show_bug.cgi?id=618137

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||NEXTRELEASE
 Status|ASSIGNED|CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 618137] Review Request: python-TraitsBackendWX - WxPython backend for Traits and TraitsGUI (Pyface)

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618137

Chen Lei  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620738] Review Request: snoopy - A preload library to send shell commands to syslog

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620738

--- Comment #17 from Fedora Update System  
2010-08-09 21:31:40 EDT ---
snoopy-1.7.1-2.fc14 has been pushed to the Fedora 14 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snoopy'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599097] Review Request: libgexiv2 - Gexiv2 is a GObject-based wrapper around the Exiv2 library

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599097

--- Comment #25 from Fedora Update System  
2010-08-09 21:31:05 EDT ---
libgexiv2-0.1.90-2.fc14 has been pushed to the Fedora 14 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update libgexiv2'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/libgexiv2-0.1.90-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 619012] Review Request: cagibi - SSDP (UPnP discovery) cache/proxy daemon

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619012

--- Comment #13 from Fedora Update System  
2010-08-09 21:32:17 EDT ---
cagibi-0.1.0-2.fc14 has been pushed to the Fedora 14 testing repository.  If
problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cagibi'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/cagibi-0.1.0-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 608069] Review Request: tango - standard library for D language of d1 specification

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=608069

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|ON_QA

--- Comment #62 from Fedora Update System  
2010-08-09 21:29:39 EDT ---
tango-0.99.9-15.20100802svn5517.fc14 has been pushed to the Fedora 14 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update tango'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/tango-0.99.9-15.20100802svn5517.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583236] Review Request: vlc - The cross-platform open-source multimedia framework, player and server

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583236

Rex Dieter  changed:

   What|Removed |Added

 Depends on||518546

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 559552] Review Request: qca-pkcs11 - Smartcard integration for QCA

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559552

Rex Dieter  changed:

   What|Removed |Added

   Flag||needinfo?(t...@iki.fi)

--- Comment #10 from Rex Dieter  2010-08-09 18:12:18 EDT 
---
ping?  re: comment #9 ?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518546] Review Request: libva - VAAPI video playback acceleration

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

Rex Dieter  changed:

   What|Removed |Added

 Blocks||583236(vlc)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607405] Review Request: poppler-sharp - C Sharp Bindings for Poppler

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607405

Rex Dieter  changed:

   What|Removed |Added

 AssignedTo|rdie...@math.unl.edu|nob...@fedoraproject.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622173] Review Request: gappa - Prove programs with floating-point or fixed-point arithmetic

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622173

Jussi Lehtola  changed:

   What|Removed |Added

 CC||jussi.leht...@iki.fi

--- Comment #1 from Jussi Lehtola  2010-08-09 18:09:31 
EDT ---
URL should be http://gappa.gforge.inria.fr/ .

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 592770] Review Request: texmakerx - LaTex Editor

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592770

Rex Dieter  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #10 from Rex Dieter  2010-08-09 18:07:54 EDT 
---
naming: ok

scriptlets: ok

licensing: ok

sources: ok
0bf125729f39a22365bc33153a8e28a7  texmakerx-1.9.9a.tar.gz

rpmlint:
$ rpmlint *.rpm
texmakerx.src:33: W: macro-in-comment %patch1
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

(omit reference, or drop the %


APPROVED.


(what's your fas username?  given that, I can sponsor you)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 580422] Review Request: libdesktop-agnostic - Provides an extensible configuration API

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=580422

Rex Dieter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 542458] Review Request: libqt4pas - Wrapper library for Qt4

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542458

--- Comment #16 from Rex Dieter  2010-08-09 17:59:50 EDT 
---
Haven't heard back in awhile, please follow the next steps of the process, 

http://fedoraproject.org/wiki/PackageMaintainers/Join#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 539948] Review Request: fqterm ---BBS client based on Qt library in linux

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=539948

Rex Dieter  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #10 from Rex Dieter  2010-08-09 17:55:00 EDT 
---
OK, all looks good, APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 498194] Review Request: zarafa - Zarafa Outlook Sharing and Open Source Collaboration

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498194

Robert Scheck  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

Bug 498194 depends on bug 530824, which changed state.

Bug 530824 Summary: php_stream_filter_api.h:65: error: comma at end of 
enumerator list
https://bugzilla.redhat.com/show_bug.cgi?id=530824

   What|Old Value   |New Value

 Status|RELEASE_PENDING |CLOSED
 Resolution||ERRATA

--- Comment #42 from Robert Scheck  2010-08-09 17:47:43 
EDT ---
As far as I can see, our pkgdb isn't able to update the short description, so
let's do it here:


Package Change Request
==
Package Name: zarafa
Short Description: Open Source Edition of the Zarafa Collaboration Platform

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617056] Review Request: gnupg 1.4.10

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617056

Tomas Mraz  changed:

   What|Removed |Added

 CC||tm...@redhat.com

--- Comment #2 from Tomas Mraz  2010-08-09 17:13:24 EDT ---
I'll change gnupg2 when the gnupg-1 is reviewed and accepted.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 519521] Review Request: kompozer - Web Authoring System

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519521

--- Comment #12 from Ismael Olea  2010-08-09 16:54:41 EDT ---
(In reply to comment #8)

> Source0: should be a URL, so that spectool -g will work if possible.

Well, this is a sourceforge URI. Attending to
http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net the URI
supposed to be
http://downloads.sourceforge.net/projects/kompozer/kompozer-0.8b3-src.tar.bz2
but it don't works. 

Instead, the one SF generates is 
http://sourceforge.net/projects/kompozer/files/current/0.8b3/kompozer-0.8b3-src.tar.bz2/download

which confuses rpmbuild (it believes the file is named «download».

> I don't
> suppose there's a URL for the manpage, but if there is then you should inclide
> that as well.

I added the URL to the git web frontend to it.

> I'm not sure what the nvu-related Provides: and Obsoletes: is about; is nvu
> available in any Fedora repository currently?

No as far as I know. But you know: Kompozer is obsoleting it... 

> You have Requires(pre): desktop-file-utils, but no %pre scriptlet at all. 
> Similarly, you call update-desktop-database and ldconfig in %post and %postun,
> but have no dependencies for them.

Ok: I added the post and postun and removed the pre. I didn't added glibc (for
ldconfig) as a Requires(post) since feel is extremelly redundant. Hope I'm
right.


> This provides a whole lot of libraries that are also provided by xulrunner.  I
> think this is a significant problem.  Seamonkey manages to avoid this by
> turning off the dependency generator and managing some of the dependency
> generation itself.  I can't really offer any suggestions on how to do it
> properly, though I'd bet the firefox/xulrunner/seamonkey maintainers (all the
> same people) would have some suggestions.

I'll wait for it. I recognize Mozilla/Kompozer's makefile is a little hell to
manage.

> The correct set of Fedora compiler flags are not used, and the debuginfo
> package seems to be broken.  These are related.  You will need to get the
> propler set of compiler flags (from %{optflags}) passed to the compiler. 
> Seamonkey seems to do this properly.
> 
> The biggest issue I see, however, is that this is basically yet another 
> forked 
> mozilla.  Distributing a forked copy of something that's updated with security
> issues once a week isn't something we should go about lightly; I'd want to see
> discussion with the firefox/xulrunner maintainers and probably FESCo as well
> (the latter due to the requirements of the no-bundled-libraries policy).

I see your point for these thing. Again: Kompozer makefiles are a beast that
barely upstream can control. Maybe an experienced maintainer of Seamonkey or
similars would better guide us. I would be more than glad for enhancing the
compiling scripts. The same applies with the duplicated code from Mozilla:
upstream didn't be able to optimize it, or maybe they couldn't get the time for
it. And I currently don't have neither time or skills for it.

Obviously the best thing I can say about Kompozer in it's current presentation
is it's the best and only app available in its class AFAIK :-)

Suggestions are welcome!

Current release (uploading to server): 

http://olea.org/paquetes-rpm/fedora-13/kompozer-0.8-0.5.b3.fc13.src.rpm
http://olea.org/tmp/kompozer.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 622293] Review Request: erlang-erlydtl - Django Templates for Erlang

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622293

--- Comment #3 from Ilia Cheishvili  2010-08-09 
16:26:45 EDT ---
Hi Peter,

Thanks for reviewing.  My FAS name is icheishvili.

I backported the patch for R14A compatibility and have included it in the
updated SPEC file, as well owned the directory that you pointed out was
unowned.

Find the new links here:

http://github.com/icheishvili/rpms/raw/ae171c49edf1ffe78445cafe99b52007d7487c2d/erlang-erlydtl-0.6.0-1.fc13.src.rpm

http://github.com/icheishvili/rpms/raw/ae171c49edf1ffe78445cafe99b52007d7487c2d/erlang-erlydtl.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 575625] Review Request: emovix - MoviX is a light media distribution that supports streaming

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575625

--- Comment #2 from Jason Tibbitts  2010-08-09 14:34:21 EDT 
---
Age doesn't really have anything to do with it, and this ticket isn't very old
compared to many package review tickets.  If the submitter (which seems to be
you) still wants to submit the software then the ticket should remain open. 
What's needed is an interested reviewer.

However, the description, involving mplayer, does raise some question since
mplayer is not in Fedora.  Specifically, of what use is this package without
mplayer?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622270] Review Request: elementary-icon-theme - icons from the Elementary Project

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622270

--- Comment #4 from Tajidin Abdullah  2010-08-09 
15:22:40 EDT ---
made more corrections to the spec file cleaned a few issues in regards to the
prep and clarified issue with the version number

also still looking for guidance about the %doc i know in fedora documentation
is needed. but i couldnt get it to build with the documentation. any help on
this issue thank you 

spec url:
http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme.spec

srpm url:
http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme-2.4-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 571019] Review Request v2: libmtag - An advanced C music tagging library with a simple API

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=571019

--- Comment #2 from Felipe Contreras  2010-08-09 
15:19:17 EDT ---
This package has all the issues fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601577] Review Request: liblockfile - This library implements a number of functions found in -lmail on SysV systems

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

Matthias Runge  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #27 from Matthias Runge  2010-08-09 
14:53:31 EDT ---
New Package SCM Request
===
Package Name: liblockfile
Short Description: This library implements a number of functions found in
-lmail on SysV 
Owners: mrunge
Branches: F13 F14 EL5 EL6 devel

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622566] New: create slf4j branch in epel

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: create slf4j branch in epel

https://bugzilla.redhat.com/show_bug.cgi?id=622566

   Summary: create slf4j branch in epel
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: shug...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com,
akurt...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Package Change Request

==
Package Name: slf4j
New Branches: el5 el6
Owners: shug...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 519521] Review Request: kompozer - Web Authoring System

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519521

--- Comment #11 from Ismael Olea  2010-08-09 14:56:15 EDT ---
Excuse me all. I'm in a new job which keeps me really busy. Anyhow I advanced
the 0.8b3 release but didn't announced here.

My plan would be to include l10n packs inside the package. It's needed to test
if it's really working. I'll look for time but I can't promise anything.

Current release (uploading to server): 

http://olea.org/paquetes-rpm/fedora-13/kompozer-0.8-0.4.b3.fc13.src.rpm
http://olea.org/tmp/kompozer.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612719

--- Comment #21 from Jason Tibbitts  2010-08-09 14:56:54 EDT 
---
You should file a change request if the package already exists.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601577] Review Request: liblockfile - This library implements a number of functions found in -lmail on SysV systems

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

--- Comment #26 from Matthias Runge  2010-08-09 
14:47:26 EDT ---
Thank you both!

As far as I understand, make compiles liblockfile.so during make.

[mru...@sofja liblockfile-1.08]$ make liblockfile.so
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables -Wall -D_GNU_SOURCE -fPIC -D_REENTRANT -I. -DLIB
-DLOCKPROG=\"/usr/bin/dotlockfile\" \
   -c lockfile.c
lockfile.c: In function ‘lockfile_create’:
lockfile.c:279: warning: ignoring return value of ‘link’, declared with
attribute warn_unused_result
ar rv liblockfile.a lockfile.o
ar: creating liblockfile.a
a - lockfile.o
gcc -fPIC -shared -Wl,-soname,liblockfile.so.1 \
   -o liblockfile.so lockfile.o -lc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621713

--- Comment #7 from Tajidin Abdullah  2010-08-09 
14:49:54 EDT ---
I got the version number 0.5 from this URL
http://gnome-look.org/content/show.php/Faenza?content=128143 that is in the
spec file

if that is not the version please tell me what is then. No other information in
regards to version number. 

Spec Url:
http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme.spec

SRPM Url:
http://tajidinabd.fedorapeople.org/faenza-icon-theme/faenza-icon-theme-0.5-4.fc13.src.rpm

Thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612719

Terje Røsten  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #20 from Terje Røsten  2010-08-09 14:46:00 
EDT ---

Sorry, forgot F12 branch.


New Package SCM Request
===
Package Name: recoll
Short Description: Desktop full text search tool with Qt GUI
Owners: terjeros
Branches: F12
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 573802] Review Request: perl-Audio-Beep - Audio::Beep Perl module

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=573802

Bug 573802 depends on bug 573801, which changed state.

Bug 573801 Summary: beep is not beeping when run by non-privileged user
https://bugzilla.redhat.com/show_bug.cgi?id=573801

   What|Old Value   |New Value

 Status|NEW |CLOSED
 Resolution||WONTFIX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 575625] Review Request: emovix - MoviX is a light media distribution that supports streaming

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=575625

--- Comment #1 from Informer  2010-08-09 14:01:27 EDT ---
do i need to close this thread, since it's an old one?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581220

--- Comment #30 from Orcan 'oget' Ogetbil  2010-08-09 
13:37:45 EDT ---
Weird that I forgot to link the bodhi update request to this review request.

Thanks for keeping track.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620177] Review Request: uprof - Profiling toolkit

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620177

--- Comment #12 from Kevin Fenzi  2010-08-09 13:29:46 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617592] Review Request: libaccounts-qt - Library for handling the account storage

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617592

--- Comment #19 from Kevin Fenzi  2010-08-09 13:25:46 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620990] Review Request: itools - Command line tools for The Islamic Tools and Libraries Project

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620990

--- Comment #16 from Kevin Fenzi  2010-08-09 13:30:21 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 618137] Review Request: python-TraitsBackendWX - WxPython backend for Traits and TraitsGUI (Pyface)

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618137

--- Comment #7 from Kevin Fenzi  2010-08-09 13:29:14 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 610794] Review Request: meego-panel-zones - Meego zones panel

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=610794

--- Comment #16 from Kevin Fenzi  2010-08-09 13:24:02 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612719

--- Comment #19 from Kevin Fenzi  2010-08-09 13:24:44 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621713] Review Request: faenza-icon-theme - Icon theme designed for Equinox GTK theme

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621713

--- Comment #6 from Mamoru Tasaka  2010-08-09 
13:12:47 EDT ---
Well,

? Again I don't see how you identified the version number as 0.5.
  Would you write some notes in the spec file as comments what
  specifies the version number of the zip file?

? Also what is the purpose of defining %tarname macro and using
  it in "%setup -q -c" ? When "-c" option is passed to %setup, it
  creates a new directory before unpackaging source file (in this
  case zip file), and using additional "-n" option does not bear
  any difference
  (i.e. just "%setup -q -c" is enough).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 521707] Review Request: python-zc.buildout - System for managing Python development buildouts

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=521707

Kalev Lember  changed:

   What|Removed |Added

   Flag||needinfo?(jonathanstef...@g
   ||mail.com)

--- Comment #17 from Kalev Lember  2010-08-09 12:35:02 EDT 
---
Jonathan, are you still interested in this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 581220] Review Request: qtsingleapplication - Qt library to start applications only once per user

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=581220

Kalev Lember  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||qtsingleapplication-2.6.1-3
   ||.fc14
 Resolution||NEXTRELEASE

--- Comment #29 from Kalev Lember  2010-08-09 12:33:01 EDT 
---
Closing the ticket. qtsingleapplication-2.6.1-3 is in F-14 + rawhide and in
stable updates for F-12 and F-13.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 583327] Review Request: clementine - A music player and library organizer

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=583327

Bug 583327 depends on bug 581220, which changed state.

Bug 581220 Summary: Review Request: qtsingleapplication - Qt library to start 
applications only once per user
https://bugzilla.redhat.com/show_bug.cgi?id=581220

   What|Old Value   |New Value

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574627] Review request: sunpinyin - A statistical language model based Chinese input method

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574627

--- Comment #5 from Liang Suilong  2010-08-09 12:11:48 
EDT ---
(In reply to comment #4)
> Does this one require review? Or it is obsolete and not maintained?

The author is rewriting the building script. So we must wait for it until they
finish all the jobs and release a new version. 

At this time, I just can consider the development of sunpinyin.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622272] Review Request: mysql-connector-c++ - MySQL database connector for C++

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622272

--- Comment #3 from Remi Collet  2010-08-09 11:59:09 
EDT ---
1.
http://github.com/remicollet/remirepo/commit/aba1cbb079ca4e09c7b353f0388263a52ecbd604
2.
http://github.com/remicollet/remirepo/commit/e3490aaede60fc337cd2ecda319ed7a58a167b29
3.
http://github.com/remicollet/remirepo/commit/7dc4d1115d7881ddc52b9d27450b55cc736ccff7

About 3 : I have apply the solution of a cp before build, because, even without
building the examples, dir is dirty (various cmake files).

About 4 : this is just a reminder (for packager) to check this 3 functions in
the source code to check if the library version have change

Spec: http://remi.fedorapeople.org/mysql-connector-c++.spec
Srpm:
http://remi.fedorapeople.org/mysql-connector-c++-1.1.0-0.2.bzr888.remi.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574575] Review Request: log5j - Simple java logging library

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574575

Marek Mahut  changed:

   What|Removed |Added

 CC||mma...@redhat.com
 AssignedTo|den...@ausil.us |mma...@redhat.com
   Flag|fedora-review?  |fedora-review+

--- Comment #14 from Marek Mahut  2010-08-09 11:09:54 EDT ---
Looks sane to me. APPROVED.

Dennis, I will take care of Justin's sponsorship.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226407] Merge Review: sendmail

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226407

--- Comment #65 from Paul Howarth  2010-08-09 10:47:03 EDT 
---
(In reply to comment #64)
> >The "touch" and initial "chmod" parts of "create db ghosts" in %install are
> >redundant because the files were created in the immediately preceding part of
> >the spec, and with the correct permissions.
> 
> Looks OK for me (line 395+). The previous parts are for sources, these are for
> .db.

Quite right.

> >%description for the doc subpackage needs rewriting.
> 
> I did my best, but english is not my native language. Feel free to propose
> something more appropriate.

I'd suggest this:

  This package contains the Sendmail Installation and Operation Guide (PDF),
  text files containing configuration documentation, plus a number of
contributed
  scripts and tools for use with Sendmail.

A couple of other quick points:

 * the "README.redhat" (newconfig patch) describes changes that happened for
   sendmail 8.12.x back in July 2002 and reflects what is now standard
   practice in Sendmail installations. I wouldn't have thought it was
   needed any more.

 * README.sendmail doesn't appear to contain anything of use to people
   installing the package.

Robert, do you have any objections to this package being approved now?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574627] Review request: sunpinyin - A statistical language model based Chinese input method

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574627

Howard Ning  changed:

   What|Removed |Added

 CC||mrlhwlibe...@gmail.com

--- Comment #4 from Howard Ning  2010-08-09 10:36:39 
EDT ---
Does this one require review? Or it is obsolete and not maintained?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622293] Review Request: erlang-erlydtl - Django Templates for Erlang

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622293

--- Comment #2 from Peter Lemenkov  2010-08-09 09:50:00 EDT 
---
Notes:

* Since Erlang R14A is available in F-14/Rawhide, could you, please, add this
patch?

http://github.com/icheishvili/erlydtl/commit/a33b9d1789d0cf932ee96093697265590c159ad2

* Unowned directory - %{_libdir}/erlang/lib/erlydtl-%{version}. Please add the
following line to the %files section:

%dir %{_libdir}/erlang/lib/erlydtl-%{version}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 622293] Review Request: erlang-erlydtl - Django Templates for Erlang

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=622293

Peter Lemenkov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lemen...@gmail.com
 AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com

--- Comment #1 from Peter Lemenkov  2010-08-09 09:42:43 EDT 
---
I'll review it.
Ilia, what's your FAS name?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 601577] Review Request: liblockfile - This library implements a number of functions found in -lmail on SysV systems

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=601577

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #25 from Pavel Alexeev (aka Pahan-Hubbitus)  
2010-08-09 09:10:33 EDT ---
I do not see what you do with -fPIC option? rpmlint silent, but it still is not
there...

Mostly package fine to me. Till thank you for the help.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #6 from Petr Pisar  2010-08-09 09:02:02 EDT ---
Ok. Everything seems reasonable except the perl dependency.

One cannot omit build requires just because they can be interfered from a
package of the system build requires list (in this case the perl is pulled
because of rpm-build and redhat-rpm-config).

The reason is the concrete base package implementation can change resulting on
not pulling perl anymore. (Imagine some crazy man rewrites rpm-build from Perl
into Python).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 615577] Review Request: opencc - A library for conversion between traditional and simplified Chinese

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615577

--- Comment #14 from Chia-Pao Kuo  2010-08-09 09:01:30 
EDT ---
(In reply to comment #10)

> In view of sponsorship, I would also appreciate if you could do 1-2
> pre-reviews. thank you.

I've just done another review on
https://bugzilla.redhat.com/show_bug.cgi?id=607016 . What do I need to do to be
a packager? Thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617592] Review Request: libaccounts-qt - Library for handling the account storage

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617592

Chen Lei  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #18 from Chen Lei  2010-08-09 08:51:23 EDT 
---
New Package SCM Request
===
Package Name: libaccounts-qt
Short Description: Accounts framework
Owners: supercyper heliocastro 
Branches: f14 
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617592] Review Request: libaccounts-qt - Library for handling the account storage

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617592

--- Comment #17 from Chen Lei  2010-08-09 08:44:35 EDT 
---
(In reply to comment #16)
> Sorry for having been a bit nit-picking. However, I think the package is more
> consistent now. Since docs are usually added with %doc, the Fedora guidelines
> define the namespace of the doc files to be %{name}. It doesn't matter where
> upstream wants to put them. If the package provided only html docs and no qch
> file, you would have to add them with %doc and they would therefore be placed
> in %{_docdir}/%{name}-%{version}. A single additional doc variant (qch) should
> not lead to a change of the namespace. But maybe you can ask the upstream
> developer whether he might adapt the naming schemes of libaccounts-glib and
> libaccounts-qt.
I never mind of changing the place of docs, I just consider the locatation of
docs is a very trivial issue before Fedora package guideline has new changes :)

KDE-SIG seems want to talk docs issues again.

> Here comes the formal review. The package looks fine and is ready now. 
> You should update the referenced location of the upstream SRPM, though. 
> Release
> 4 of the package is no longer available, but the tarball of release 5 equals
> that of your package too.

I'll add a permanent link to upstream SRPM before importing to git, the
permanent link don't exist when I try to update this package to the latest
upstream SRPM.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #5 from Chen Lei  2010-08-09 08:24:39 EDT ---
(In reply to comment #4)
> > Some suggestions:
> > 1.Provides:   wbxml2 = %{version}-%{release} is not useful since no rpm 
> > is
> > actually depends wbxml2 explicitly.
> > 
> But it does not breaks anything. More ever think about third-party
> repositories.
> In addition, pure theoretically, there is a direct dependency:
> $ repoquery --requires wbxml2-devel | grep wbxml2
> libwbxml2.so.0
> wbxml2 = 0.9.2-16.fc12
> libwbxml2.so.0()(64bit)
> wbxml2 = 0.9.2-16.fc12
> One could say if wbxml2-devel is installed, wbxml2 is installed too. However
> who knows how much broken system can an user have.
This is not true, rpm should not try to depend on any shlibs explicitly.

See
http://fedoraproject.org/wiki/PackageNamingGuidelines#Renaming.2Freplacing_existing_packages
"For packages that are not usually pulled in by using the package name as the
dependency such as library only packages (which are pulled in through library
soname depenencies), there's usually no need to add the Provides. Note however
that the -devel subpackages of lib packages are pulled in as build dependencies
using the package name, so adding the Provides is often appropriate there."

> > 2.
> > BuildRequires:  cmake, expat-devel, perl
> > 
> > Requires:  libxml2-devel, pkgconfig
> > 
> > rpmbuild will add pkgconfig as a dependency automatically[1],
> What about EPEL-5? It's not supported currently, but I'd like to be prepared
> for future possibilities.
> > perl is on the exception list of Buildrequires[2]
> > [2]http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2
> >
> It's not listed.

wbxml2 is actually provided by some 3rd repos for rhel5, it'll better not to
introduce big update in rhel5. perl is a dependency to those exception.

See
http://kojipkgs.fedoraproject.org/packages/gzip/1.3.13/4.fc13/data/logs/i686/root.log
for a complete exception list.

> > 3.
> > 
> > %build
> > # Upstream does not support in-source-directory building
> > SRCDIR="$PWD"
> > %define builddir ../build
> > rm -rf %{builddir}
> > mkdir %{builddir}
> > cd %{builddir}
> > %cmake "$SRCDIR"
> > make %{?_smp_mflags}
> > 
> > ->
> > 
> >  %build
> >  mkdir -p %{_target_platform}
> >  pushd %{_target_platform}
> >  %{cmake} ..
> >  popd
> > 
> >  make %{?_smp_mflags} -C %{_target_platform}
> > 
> Why popd and then make -C if one can do make without -C and then popd?

Either way is OK, but using ways listed in guideline will keep our spec files
more clearly

> > 4.
> > 
> > %files devel
> > %defattr(-,root,root,-)
> > %doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS 
> > TODO
> > 
> > You should not try to add duplicate docs to -devel, rpmlint warnings can be
> > safely ignored.
> >
> Ok. I will remove them but COPYING and GNU-LGPL because it's new rule that
> every package must deliver license copy if some exists in sources.

This is incorrect, because -devel subpackage already depend on mainpackage(e.g.
a package which has -libs and -devel subpackages, then you just need to add
license Text to -libs subpackage, mainpackage and -devel subpackage don't need
this text).

See http://fedoraproject.org/wiki/Packaging/LicensingGuidelines

Subpackage Licensing 

If a subpackage is dependent (either implicitly or explicitly) upon a base
package (where a base package is defined as a resulting binary package from the
same source RPM which contains the appropriate license texts as %doc), it is
not necessary for that subpackage to also include those license texts as %doc. 

However, if a subpackage is independent of any base package (it does not
require it, either implicitly or explicitly), it must include copies of any
license texts (as present in the source) which are applicable to the files
contained within the subpackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #4 from Petr Pisar  2010-08-09 08:04:37 EDT ---
(In reply to comment #3)
> Some suggestions:
> 1.Provides:   wbxml2 = %{version}-%{release} is not useful since no rpm is
> actually depends wbxml2 explicitly.
> 
But it does not breaks anything. More ever think about third-party
repositories.

In addition, pure theoretically, there is a direct dependency:

$ repoquery --requires wbxml2-devel | grep wbxml2
libwbxml2.so.0
wbxml2 = 0.9.2-16.fc12
libwbxml2.so.0()(64bit)
wbxml2 = 0.9.2-16.fc12

One could say if wbxml2-devel is installed, wbxml2 is installed too. However
who knows how much broken system can an user have.

> 2.
> BuildRequires:  cmake, expat-devel, perl
> 
> Requires:  libxml2-devel, pkgconfig
> 
> rpmbuild will add pkgconfig as a dependency automatically[1],

What about EPEL-5? It's not supported currently, but I'd like to be prepared
for future possibilities.

> perl is on the exception list of Buildrequires[2]
> [2]http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2
>
It's not listed.

> 3.
> 
> %build
> # Upstream does not support in-source-directory building
> SRCDIR="$PWD"
> %define builddir ../build
> rm -rf %{builddir}
> mkdir %{builddir}
> cd %{builddir}
> %cmake "$SRCDIR"
> make %{?_smp_mflags}
> 
> ->
> 
>  %build
>  mkdir -p %{_target_platform}
>  pushd %{_target_platform}
>  %{cmake} ..
>  popd
> 
>  make %{?_smp_mflags} -C %{_target_platform}
> 
Why popd and then make -C if one can do make without -C and then popd?

> 4.
> 
> %files devel
> %defattr(-,root,root,-)
> %doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS 
> TODO
> 
> You should not try to add duplicate docs to -devel, rpmlint warnings can be
> safely ignored.
>
Ok. I will remove them but COPYING and GNU-LGPL because it's new rule that
every package must deliver license copy if some exists in sources.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 612719] Review Request: recoll - Desktop full text search tool with a qt gui

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612719

Terje Røsten  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #18 from Terje Røsten  2010-08-09 07:59:17 
EDT ---
Thanks guys!


New Package SCM Request
===
Package Name: recoll
Short Description: Desktop full text search tool with Qt GUI
Owners: terjeros
Branches: F13 F14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 602574] Review Request: patchelf - a utility for patching ELF binaries

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602574

--- Comment #6 from Martin Gieseking  2010-08-09 
06:20:56 EDT ---
OK, thanks for the feedback. I think we should wait for a comment from the
upstream developer before finishing the review. Maybe you can contact him again
and ask for a status update. If he doesn't respond, I suggest to exclude the
ppc archs for now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 619437] Review Request: bm - Rpm package building helper

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619437

Martin Gieseking  changed:

   What|Removed |Added

 CC||martin.giesek...@uos.de

--- Comment #11 from Martin Gieseking  2010-08-09 
06:07:03 EDT ---
Helio, here are some more things to consider:

- If you want to build the package for Fedora only (and not for EPEL), you can
remove the BuildRoot tag (and also 'rm -rf %{buildroot}' in %install) [1].
Otherwise, it's recommended to use one of the tags listed at [2].

- you can drop BR: python (it's added automatically as a dependency)

- add %dir %{_sysconfdir}/bash_completion.d/ to %files
  (the package should own this directory, see [3])


[1] http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

[2] http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#BuildRoot_tag

[3]
http://fedoraproject.org/wiki/Packaging/Guidelines#Multiple_packages_own_files_in_a_common_directory_but_none_of_them_needs_to_require_the_others.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620875] Review Request: wmfrog - A weather application, it shows the weather in a graphical way

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620875

--- Comment #7 from Petr Pisar  2010-08-09 05:30:59 EDT ---
I'll change it in GIT repository to be prepared for next release. Actually, I
inspired by wmCalClock, the only other wm* package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

Chen Lei  changed:

   What|Removed |Added

   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226156] Merge Review: mod_python

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226156

--- Comment #5 from Parag AN(पराग)  2010-08-09 05:25:28 EDT 
---
jorton ping

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #3 from Chen Lei  2010-08-09 05:19:57 EDT ---
Some suggestions:
1.Provides:   wbxml2 = %{version}-%{release} is not useful since no rpm is
actually depends wbxml2 explicitly.

2.
BuildRequires:  cmake, expat-devel, perl

Requires:  libxml2-devel, pkgconfig

rpmbuild will add pkgconfig as a dependency automatically[1], perl is on the
exception list of Buildrequires[2](There is no need to include the following
packages or their dependencies as BuildRequires).

[1]http://fedoraproject.org/wiki/PackagingGuidelines#Pkgconfig_Files
[2]http://fedoraproject.org/wiki/PackagingGuidelines#Exceptions_2

3.

%build
# Upstream does not support in-source-directory building
SRCDIR="$PWD"
%define builddir ../build
rm -rf %{builddir}
mkdir %{builddir}
cd %{builddir}
%cmake "$SRCDIR"
make %{?_smp_mflags}

->

 %build
 mkdir -p %{_target_platform}
 pushd %{_target_platform}
 %{cmake} ..
 popd

 make %{?_smp_mflags} -C %{_target_platform}

 %install
 rm -rf %{buildroot}
 make install/fast DESTDIR=%{buildroot} -C %{_target_platform}

See http://fedoraproject.org/wiki/SIGs/KDE, this is also suggested as the next
version cmake packaging guideline in Fedora.


4.

%files devel
%defattr(-,root,root,-)
%doc AUTHORS BUGS ChangeLog COPYING GNU-LGPL NEWS README References THANKS TODO

You should not try to add duplicate docs to -devel, rpmlint warnings can be
safely ignored.

5.

%files
%{_libdir}/libwbxml2.so.0*
->
%{_libdir}/libwbxml2.so.*

If upstream bumps soname, you don't need to modify %files again.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602574] Review Request: patchelf - a utility for patching ELF binaries

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602574

--- Comment #5 from Jeremy Sanders  2010-08-09 
05:18:43 EDT ---
Sorry for the delay. I've fixed the elf.h issue. I've also contacted upstream
about the second issue. He wanted some debugging data which I have provided.
Still no word from upstream for a several weeks.

Here are the versions that delete elf.h before building:
http://barmag.net/tmp/patchelf.spec
http://barmag.net/tmp/patchelf-0.5-4.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620875] Review Request: wmfrog - A weather application, it shows the weather in a graphical way

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620875

Chen Lei  changed:

   What|Removed |Added

 CC||supercyp...@gmail.com

--- Comment #6 from Chen Lei  2010-08-09 05:03:59 EDT ---
Maybe Amusements/Graphics is more suitable for the rpm GROUP since User
Interface/X seems not the right GROUP.

See 

rpm -qg 'Amusements/Graphics'

rpm -qg 'User Interface/X'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 603245] Review Request: python-zmq - Software library for fast, message-based applications

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=603245

Chen Lei  changed:

   What|Removed |Added

 CC||supercyp...@gmail.com

--- Comment #10 from Chen Lei  2010-08-09 04:43:30 EDT 
---
IMHO, the name python-zmq don't match Fedora naming guideline, though I think
the naming guideline for python modules isn't clearly enough and cause many
inconsistencies in the repo.

Currently, many existed py* packages(e.g. pygtk2) are already named as
python3-py*. Maybe we should adopt python modules naming guldeine from debian,
which seems more clear than ours.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 619462] Review Request: tyrion - A framework for systems automation

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619462

--- Comment #13 from Chen Lei  2010-08-09 04:04:32 EDT 
---
Another trival issue is you should not use deprecated macro %{_initrddir} in
spec. Also you can replace %{_datarootdir} with%{_datadir} which is much more
widely used.

See http://fedoraproject.org/wiki/Packaging/RPMMacros

Also, adding README.md to mutiple subpackages to avoid rpmlint warnings is
completely useless, many warnings can be safely ignored.

GROUPS: System Environment/Daemons will be more suitable for -node subpackage.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621898] Review Request: libwbxml - Library and tools to parse, encode and handle WBXML documents

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621898

--- Comment #2 from Petr Pisar  2010-08-09 04:03:52 EDT ---
Thanks for pointing out. I have rewritten the spec and SRPM files accordingly.

$ rpmlint libwbxml.spec ../SRPMS/libwbxml-0.10.8-1.fc13.src.rpm
../RPMS/x86_64/libwbxml-*
libwbxml.x86_64: W: no-manual-page-for-binary xml2wbxml
libwbxml.x86_64: W: no-manual-page-for-binary wbxml2xml
4 packages and 1 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 619462] Review Request: tyrion - A framework for systems automation

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=619462

Chen Lei  changed:

   What|Removed |Added

 CC||supercyp...@gmail.com

--- Comment #12 from Chen Lei  2010-08-09 03:51:54 EDT 
---
Actually, you should not try to compress man pages manually as Hicham
suggested, rpmbuild will do it automanually. It's entirely possible that fedora
will switch to xz format man pages instead of gzip files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 610980] Review Request: mspdebug - Debugger and gdb proxy for MSP430 MCUs

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=610980

Rakesh Pandit  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|rspan...@zepler.net

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 618137] Review Request: python-TraitsBackendWX - WxPython backend for Traits and TraitsGUI (Pyface)

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=618137

Rakesh Pandit  changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|mrlhwlibe...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620752] Review Request: update-ca-certificates - A tool to manage systemwide CA certificates

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620752

Rakesh Pandit  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|dw...@infradead.org

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 602574] Review Request: patchelf - a utility for patching ELF binaries

2010-08-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=602574

--- Comment #4 from Martin Gieseking  2010-08-09 
03:00:08 EDT ---
Jeremy, do you have any news on the above mentioned issues (comment #3)? Are
you still interested in this package?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review