[Bug 527402] Review Request: gmock - Google C++ Mocking Framework

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=527402

Orcan 'oget' Ogetbil  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com
   Flag||fedora-review?

--- Comment #7 from Orcan 'oget' Ogetbil  2010-08-30 
02:36:19 EDT ---
Here is the full review:

* rpmlint says:
   gmock.src: W: spelling-error %description -l en_US jMock -> j Mock, jock,
mock
   gmock.src: W: spelling-error %description -l en_US matchers -> marchers,
matcher, matches
   gmock.src: W: spelling-error %description -l en_US minGW -> mingy, Mingus,
mingle
   gmock.src: W: invalid-url Source0:
http://googlemock.googlecode.com/files/gmock-1.4.0.tar.bz2 HTTP Error 404: Not
Found
   gmock-devel.x86_64: W: no-manual-page-for-binary gmock-config
   gmock-devel.x86_64: W: no-manual-page-for-binary gmock_doctor.py
   gmock-devel.x86_64: W: no-documentation
These can be ignored. You can ask upstream about manpages.
   gmock.src: W: no-version-in-last-changelog
   gmock.src:86: W: macro-in-comment %{_datadir}
   gmock.src:86: W: macro-in-comment %{name}
   gmock.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1)
These need to be fixed.
   gmock.x86_64: W: shared-lib-calls-exit /usr/lib64/libgmock.so.0.0.0
_e...@glibc_2.2.5
Any explanation for this one?

! It looks like the Group for the main packages should be "System
Environment/Libraries"

! The lines
   %dir %{_includedir}/%{name}
   %{_includedir}/%{name}/*.h
   %{_includedir}/%{name}/internal
could be shortened to
   %{_includedir}/%{name}

! In the specfile you use "gmock" and "%{name}" interchangably, which breaks
marco consistency.

! The standard way of getting rid of rpath is via
   %configure
   sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g'
libtool
   sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
which will also save you a BR. The use of chrpath is left as a last resort.

? On the devel packages why do we have
   Requires:   automake

* The tests fail via
   g++ -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o
test/.libs/gmock-actions_test test/gmock-actions_test.o  -L/usr/lib64 -lgtest
lib/.libs/libgmock_main.so  -Wl,--rpath -Wl,/usr/lib64
   /usr/bin/ld: test/gmock-actions_test.o: undefined reference to symbol
'testing::internal::ExpectationBase::RetireAllPreRequisites()'
   /usr/bin/ld: note:
'testing::internal::ExpectationBase::RetireAllPreRequisites()' is defined in
DSO /builddir/build/BUILD/gmock-1.4.0/lib/.libs/libgmock.so.0 so try adding it
to the linker command line
   /builddir/build/BUILD/gmock-1.4.0/lib/.libs/libgmock.so.0: could not read
symbols: Invalid operation
   collect2: ld returned 1 exit status
The undefined reference error can be fixed by adding a lib/.libs/libgmock.so to
the compilation line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

--- Comment #8 from Martin Gieseking  2010-08-30 
02:33:22 EDT ---
(In reply to comment #7)
> I know the
> person who submitted the review request for extracc
> (https://bugzilla.redhat.com/show_bug.cgi?id=616881), namely Christophe. He is
> very busy and may not have time to further maintain the extracc package.
> Therefore, I may well maintain extracc as well, especially since it has been
> approved by Mamoru Tasaka
> (https://bugzilla.redhat.com/show_bug.cgi?id=616881#c3). So, I would submit
> extracc and stdair at the same time.

OK, if Christophe isn't interested in extracc any longer (he should leave a
comment about that in his review request), you can take his package once you're
sponsored.

> Besides, I indeed intend to maintain those package for EPEL. That's why I kept
> some %{?el5:FOO} and %{?rhel:BAR} macros.

That's fine, but you don't need these macros. Just add the BuildRoot tag and
the %clean section, and clean $RPM_BUILD_ROOT at the beginning of %install.
These additional lines work in EPEL and in Fedora. So, there's no need to
distinguish between EPEL and Fedora here.

BTW, are you still looking for a sponsor? If so, I'm willing to sponsor you. As
a member of the packager group, you will be allowed to approve other people's
packages. Thus, you should do two or three informal reviews before, in order to
familiarize with the review process and to show an understanding of the Fedora
guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 615192] Review Request: cjkuni-fonts-ghostscript -Chinese Unicode TrueType font ghostscript files

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615192

Peng Wu  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NOTABUG
Last Closed||2010-08-30 01:16:25

--- Comment #4 from Peng Wu  2010-08-30 01:16:25 EDT ---
This package has been renamed to ghostscript-chinese.
See: [Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese
fonts configuration files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589866] Review Request: darktable - Utility to organize and develop raw images

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589866

--- Comment #25 from Dmitrij S. Kryzhevich  2010-08-29 23:41:09 
EDT ---
Darktable 0.6 is out!


# rpmlint darktable-0.6-1.fc13.src.rpm darktable-0.6-1.fc13.x86_64.rpm
darktable-debuginfo-0.6-1.fc13.x86_64.rpm 
darktable.src: W: spelling-error %description -l en_US lighttable -> light
table, light-table, lighterage
darktable.src: W: spelling-error %description -l en_US zoomable -> zoom able,
zoom-able, fathomable
darktable.x86_64: W: spelling-error %description -l en_US zoomable -> zoom
able, zoom-able, fathomable
darktable.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/darktable.schemas
darktable.x86_64: W: dangerous-command-in-%pre rm
darktable.x86_64: W: dangerous-command-in-%post rm
3 packages and 0 specfiles checked; 0 errors, 6 warnings.

Spec: http://depositfiles.com/files/j6lwrecol
Srpm: http://depositfiles.com/files/krwpg7dm7

Patch is needed to truncate wrong space. Only one space, but is is an error.

I think, now is culd go further?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621037] Review Request: perl-MooseX-MultiMethods - Multi Method Dispatch based on Moose type constraints

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621037

Bug 621037 depends on bug 619332, which changed state.

Bug 619332 Summary: Review Request: perl-MooseX-Types-VariantTable - Type 
constraint based variant table
https://bugzilla.redhat.com/show_bug.cgi?id=619332

   What|Old Value   |New Value

 Resolution||ERRATA
 Status|ON_QA   |CLOSED

--- Comment #5 from Fedora Update System  2010-08-29 
23:19:01 EDT ---
perl-MooseX-MultiMethods-0.10-2.fc14 has been submitted as an update for Fedora
14.
https://admin.fedoraproject.org/updates/perl-MooseX-MultiMethods-0.10-2.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588472] Review Request:rubygem-rjb - Ruby to java Bridge

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588472

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #3 from Michael Stahnke  2010-08-29 23:12:58 
EDT ---
rpmlint is not silent.  There is probably more, but we can start with that. 



rpmlint ../RPMS/x86_64/rubygem-rjb-1.2.0-2.fc13.x86_64.rpm 
rubygem-rjb.x86_64: W: no-soname
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/lib/rjbcore.so
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/jp_co_infoseek_hp_arton_rjb_RBridge.h
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/rjbexception.c
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/load.c
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/rjb.h
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/rjb.c
rubygem-rjb.x86_64: E: wrong-script-interpreter
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/test/test.rb /usr/local/env
rubygem-rjb.x86_64: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/test/test.rb 0644L /usr/local/env
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/extconf.h
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/riconv.h
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/riconv.c
rubygem-rjb.x86_64: W: devel-file-in-non-devel-package
/usr/lib/ruby/gems/1.8/gems/rjb-1.2.0/ext/jniwrap.h
1 packages and 0 specfiles checked; 2 errors, 10 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588427] Review Request: rubygem-Antwrap - A Ruby module that wraps the Apache Ant build tool.

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588427

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #4 from Michael Stahnke  2010-08-29 23:06:43 
EDT ---
rpmlint rubygem-Antwrap-0.7.0-2.fc15.src.rpm 
rubygem-Antwrap.src: E: summary-too-long C A Ruby module that wraps the Apache
Ant build tool. Antwrap can be used to invoke Ant Tasks from a Ruby or a JRuby
script
rubygem-Antwrap.src:29: W: mixed-use-of-spaces-and-tabs (spaces: line 29, tab:
line 29)
1 packages and 0 specfiles checked; 1 errors, 1 warnings.


Can you double-check the license?  The website says LGPL.

Description is very long.  Appears to be malformatted rdoc items. 

No need for the /usr/share/doc creation and file movement. 

ruby_sitelib macro not used. Remove it.

create a %check please.  You will need rjb in the BR(check) for that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588442] Review Request: rubygem-heckle - unit test sadism(tm) at it's core

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588442

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 22:54:00 
EDT ---
warning: File listed twice: /usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3
warning: File listed twice:
/usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3/History.txt
warning: File listed twice:
/usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3/Manifest.txt
warning: File listed twice:
/usr/share/doc/usr/lib/ruby/gems/1.8-1.4.3/README.txt

 rpmlint rubygem-heckle-1.4.3-1.fc15.src.rpm 
rubygem-heckle.src: W: patch-not-applied Patch0: heckle-local.patch

rpmlint rubygem-heckle-1.4.3-1.fc15.noarch.rpm 
rubygem-heckle.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/lib/test_unit_heckler.rb 0444L
/usr/bin/env
rubygem-heckle.noarch: E: non-standard-executable-perm
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/bin/heckle 0555L
rubygem-heckle.noarch: W: hidden-file-or-dir
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/.autotest
rubygem-heckle.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/heckle-1.4.3/sample/test/test_heckled.rb 0444L
/usr/bin/env

Again, ruby_sitelib macro isn't used.  Remove that line.

No need for the /usr/share/doc setup again.  Please remove, if you do, the
Rakefile will work for rake test in %check.  You will also need to add a BR on
parse tree for the check.

Rather than patching, you could simply run sed to modify the path for ruby.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588433] Review Request: rubygem-echo - ruby gem pacaking tool

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588433

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 22:40:14 
EDT ---
%ruby_sitelib is not used or needed in this spec.  Please remove it. 


 rpmlint rubygem-echoe-4.3-1.fc15.src.rpm 
rubygem-echoe.src: E: summary-too-long C A Rubygems packaging tool that
provides Rake tasks for documentation, extension compiling, testing, and
deployment
rubygem-echoe.src:42: W: mixed-use-of-spaces-and-tabs (spaces: line 37, tab:
line 42)
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

 rpmlint rubygem-echoe-4.3-1.fc15.noarch.rpm 
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/compositepublisher.rb
0644L /usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/ftptools.rb
0644L /usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/rubyforgepublisher.rb
0644L /usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/sys.rb 0644L
/usr/bin/env
rubygem-echoe.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/echoe-4.3/vendor/rake/lib/rake/contrib/publisher.rb
0644L /usr/bin/env


This section is not needed, and it even breaks trying to run the Rakefile in a
%check (however this rakefile has no test/spec option)  Please remove it. 
Files can marked as %doc outside of /usr/share/doc.
mkdir -p %{buildroot}/usr/share/doc/%{gemdir}-%{version}
for DOC in LICENSE CHANGELOG README TODO
do mv  %{buildroot}%{geminstdir}/$DOC
%{buildroot}/usr/share/doc/%{gemdir}-%{version}
done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 459125] Review Request: FreeCAD - An extensible Open Source CAx program for Unix/X11

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459125

--- Comment #10 from Alex G.  2010-08-29 22:38:16 EDT ---
(In reply to comment #9)
> Such other repositories are however neither a part of Fedora nor affiliated
> with Fedora, and Fedora can for legal reasons not reference or endorse them -
> and hardly mention them.
>
I have seen other bug reports where "such other repositories" were being
mentioned, and quite freely. In the moovida review request (don't have the bug
number handy) it was discussed whether moovida should be included in Fedora or
moved to rpmfusion, with the word "rpmfusion" used freely and extensively.

> This is thus not the right place to continue this discussion. Just go 
> elsewhere
> and do it! ;-)

I apologize if I might have seen insistent, but I do not appreciate the tone
your last comment.

After a bit more research, I have found that FreeCAD is on rpmfusion's
wishlist, and thus, I rest my case.

Have a good day!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588436] Review Request: rubygem-httpclient - gives something like the functionality of libwww-perl (LWP) in Ruby

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588436

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 22:27:24 
EDT ---
%ruby_sitelib is not used.  The line can be removed.
Summary should be capitalized. (First letter)
Description should also be capitalized. (First letter)

builds cleanly in mock

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 553893] Review Request: rubygem-tiny_mce - TinyMCE in Ruby on Rails applications

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553893

Michael Stahnke  changed:

   What|Removed |Added

 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 22:29:54 
EDT ---
wget
http://www.kanarip.com/custom/f12/SRPMS/rubygem-tiny_mce-0.1.1-1.fc12.src.rpm
--2010-08-29 22:29:26-- 
http://www.kanarip.com/custom/f12/SRPMS/rubygem-tiny_mce-0.1.1-1.fc12.src.rpm
Resolving www.kanarip.com... 82.94.126.50
Connecting to www.kanarip.com|82.94.126.50|:80... connected.
HTTP request sent, awaiting response... 503 Service Temporarily Unavailable
2010-08-29 22:29:36 ERROR 503: Service Temporarily Unavailable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588428] Review Request: rubygem-addressable - Imporved URI/URL handling

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588428

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 22:16:51 
EDT ---
builds in mock
rpmlint is clean

%ruby_sitelib should be removed, as it is not used.


You could add a %check

%check
cd %{buildroot}%{geminstdir}
rake spec


There isn't really a reason to do this. You can simply mark the normally
installed README file a %doc.  
mkdir -p %{buildroot}/usr/share/doc/%{gemdir}-%{version}
mv  %{buildroot}%{geminstdir}/README
%{buildroot}/usr/share/doc/%{gemdir}-%{version}

I'd also encourage you to break this package into a separate -doc package. It
would allow someone wishing to use addressable as a dep to not install about
3/4 of the total files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588477] Review Request: rubygem-webmock - mock object support for web dev in ruby.

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588477

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #2 from Michael Stahnke  2010-08-29 21:52:19 
EDT ---
rubygem-sitelib is never used and should be removed. 

rubygem-webmock.noarch: E: version-control-internal-file
/usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.gitignore



This can be removed rubygem-webmock.noarch: W: hidden-file-or-dir
/usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.document

I'd like to have a full %check section, but it looks like the Rakefile requires
jeweler.  There is a review bug open on that gem, and hopefully it will be
included soon.  Until then, perhaps having a %check section that is commented
out would be ok.

%check
cd %{buildroot}%{geminstdir}
rake test
rake spec

I'll have more comments after I review addressable and httpclient.  I open this
one in the wrong order.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

--- Comment #7 from Daiki Ueno  2010-08-29 21:53:26 EDT ---
(In reply to comment #6)
> Please use single style of macro
> See
> http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

Aha.  Just done in Git.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588476] Review Request: rubygem-spork - A forking Drb spec server

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588476

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 21:41:58 
EDT ---
This package fails to build in mock on rawhide-i386 and I also couldn't get it
to build on a normal F13 box. 


>From the build attempt

/usr/bin/ruby mkrf_conf.rb
Actually, there aren't any native extensions. I'm just dynamically installing
dependencies based off of your operating system

>From mock
+ gem install --local --install-dir ./usr/lib/ruby/gems/1.8 --force --rdoc
/builddir/build/SOURCES/spork-0.8.2.gem
ERROR:  Error installing /builddir/build/SOURCES/spork-0.8.2.gem:
ERROR: Failed to build gem native extension.
/usr/bin/ruby mkrf_conf.rb
Actually, there aren't any native extensions. I'm just dynamically installing
dependencies based off of your operating system
Gem files will remain installed in
/builddir/build/BUILD/rubygem-spork-0.8.2/usr/lib/ruby/gems/1.8/gems/spork-0.8.2
for inspection.
Results logged to
/builddir/build/BUILD/rubygem-spork-0.8.2/usr/lib/ruby/gems/1.8/gems/spork-0.8.2/ext/gem_make.out
Building native extensions.  This could take a while...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 504476] Review Request: rubygem-newgem - Bundle Ruby libraries into a RubyGem

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=504476

Michael Stahnke  changed:

   What|Removed |Added

 CC||mastah...@gmail.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #25 from Michael Stahnke  2010-08-29 21:34:10 
EDT ---

New Package SCM Request
===
Package Name: rubygem-newgem
Short Description: Bundle Ruby libraries into a RubyGem
Owners: stahnma
Branches: EL5 EL6
InitialCC: mkent

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

--- Comment #6 from Parag AN(पराग)  2010-08-29 21:33:35 EDT 
---
Please use single style of macro
See
http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

--- Comment #5 from Fedora Update System  2010-08-29 
21:20:00 EDT ---
fontik-0-0.2.20100825git8e8cea81d.fc13 has been submitted as an update for
Fedora 13.
https://admin.fedoraproject.org/updates/fontik-0-0.2.20100825git8e8cea81d.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

--- Comment #4 from Fedora Update System  2010-08-29 
21:19:55 EDT ---
fontik-0-0.2.20100825git8e8cea81d.fc14 has been submitted as an update for
Fedora 14.
https://admin.fedoraproject.org/updates/fontik-0-0.2.20100825git8e8cea81d.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588446] Review Request: rubygem-sftp sftp support for Ruby

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588446

Michael Stahnke  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mastah...@gmail.com

--- Comment #1 from Michael Stahnke  2010-08-29 21:16:26 
EDT ---
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/CHANGELOG.rdoc
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/README.rdoc
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/constants.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/errors.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/operations/dir.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/operations/download.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/operations/file.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/operations/file_factory.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/operations/upload.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/packet.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/01/attributes.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/01/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/01/name.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/02/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/03/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/04/attributes.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/04/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/04/name.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/05/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/06/attributes.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/06/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/protocol/base.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/request.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/response.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/session.rb
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/net-sftp-2.0.4/lib/net/sftp/version.rb



It looks like you might want to break the package into the base package and a
-doc package.  This was discussed recently on the Ruby SIG list.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 553898] Review Request: rubygem-jeweler - Craft the perfect RubyGem

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553898

Michael Stahnke  changed:

   What|Removed |Added

 CC||mastah...@gmail.com

--- Comment #8 from Michael Stahnke  2010-08-29 21:10:36 
EDT ---
Should this review be canceled? I would like to have jeweler in Fedora/EPEL and
can package it up if this review is going nowhere.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 459125] Review Request: FreeCAD - An extensible Open Source CAx program for Unix/X11

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459125

--- Comment #9 from Mads Kiilerich  2010-08-29 20:24:17 EDT 
---
Using another rpm repository from another legal entity is certainly a
possibility. 

Such other repositories are however neither a part of Fedora nor affiliated
with Fedora, and Fedora can for legal reasons not reference or endorse them -
and hardly mention them.

This is thus not the right place to continue this discussion. Just go elsewhere
and do it! ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 459125] Review Request: FreeCAD - An extensible Open Source CAx program for Unix/X11

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459125

Alex G.  changed:

   What|Removed |Added

 CC||mr.nuke...@gmail.com

--- Comment #8 from Alex G.  2010-08-29 19:59:49 EDT ---
(In reply to comment #6)
> We would all like to see FreeCAD in Fedora, but Fedora can not do anything
> until Open CASCADE makes a clear statement whether the license is free and
> GPL-compatible or not. It do not depend on the Fedora release schedule.
>
While I would argue on the two arguments that classify OCTPL as non-free, I
understand and agree that, at the moment, it may not be included in the Fedora
repositories; however,

> Debian (and Ubuntu?) explicitly considers Open CASCADE non-free but apparently
> makes a compromise with their own principles. Fedora makes no compromises
> regarding non-free software.
>
Fedora does not need to make a compromise to its own principles. FreeCAD may be
distributed, indirectly, with Fedora, via rpmfusion. I am surprised that, since
this bug was started, no one suggested rpmfusion.

In all honesty, in order to get a fully-featured Fedora, packages from
rpmfusion are a must. For example, the nvidia driver is a must-have for the
type of work that I do. Personally, I see rpmfusion as part of Fedora.

So, please, let us put FreeCAD and OCC in rpmfusion. That way it _will_ be in
Fedora, and this will be the compromise that Fedora makes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

--- Comment #7 from Son Nguyen Kim  2010-08-29 17:48:01 
EDT ---
Thanks! The new specification and source RPM are:
SpecURL: http://subversion.assembla.com/svn/stdair/stdair.spec
SRPM Spec:
http://subversion.assembla.com/svn/stdair/stdair-0.3.0-2.fc13.src.rpm

> Unfortunately, that's not possible. Your package can't be approved as long as
> it bundles a library. Thus, you should prepare your package as if extracc was
> already available. As a consequence, extracc blocks stdair, and you have to
> wait until it's approved.

Yes, of course, I did not intend to violate the guideline
(https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries). I know the
person who submitted the review request for extracc
(https://bugzilla.redhat.com/show_bug.cgi?id=616881), namely Christophe. He is
very busy and may not have time to further maintain the extracc package.
Therefore, I may well maintain extracc as well, especially since it has been
approved by Mamoru Tasaka
(https://bugzilla.redhat.com/show_bug.cgi?id=616881#c3). So, I would submit
extracc and stdair at the same time.

Besides, I indeed intend to maintain those package for EPEL. That's why I kept
some %{?el5:FOO} and %{?rhel:BAR} macros.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627555] Review Request: tlomt-orbitron-fonts - Geometric sans-serif typeface

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627555

--- Comment #12 from Lameire Alexis  
2010-08-29 17:00:04 EDT ---
New Package SCM Request
===
Package Name: tlomt-orbitron-fonts
Short Description: Geometric sans-serif typeface
Owners: alexises
Branches: f13 f14
InitialCC: fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617141] Review Request: gupnp-dlna - A collection of helpers for building DLNA applications

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617141

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|needinfo?(ke...@tummy.com)  |

--- Comment #23 from Kevin Fenzi  2010-08-29 16:27:50 EDT ---
File a ticket in the fesco trac: 

https://fedorahosted.org/fesco/newtplticket

Add 'meeting' keyword and we will discuss it at the next meeting (tuesday).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 604331] Review Request: redshift - Adjusts the color temperature of your screen according to time of day

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604331

Mamoru Tasaka  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #14 from Mamoru Tasaka  2010-08-29 
15:28:14 EDT ---
Well, the URL of the srpm on bug 598315 returned 404, so I downloaded
Source0 by myself and your initial comments seem good.

-
This package (redshift) is APPROVED by mtasaka
-

I am going to sponsor you. However as far as I checked your FAS
account, the mail address you use on FAS and the one you are using
on this bugzilla differ, which must coincide. Please change the mail
address on your FAS, or create another account on bugzilla with the
same mail address on your FAS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627638] Review Request: git2cl - Converts git logs to GNU ChangeLog format.

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627638

--- Comment #4 from Steve Traylen  2010-08-29 15:22:46 
EDT ---
New versions:
 Contain the git hash in the release.
 Uses the --prefix to git archive to make a with top level directory tar ball.

http://cern.ch/straylen/rpms/git2cl/git2cl-2.0-0.1.git8373c9f.fc13.src.rpm

http://cern.ch/straylen/rpms/git2cl/git2cl.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617141] Review Request: gupnp-dlna - A collection of helpers for building DLNA applications

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617141

Peter Robinson  changed:

   What|Removed |Added

   Flag||needinfo?(ke...@tummy.com)

--- Comment #22 from Peter Robinson  2010-08-29 15:16:27 
EDT ---
How would i do that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620556] Review Request: folks - GObject contact aggregation library

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620556

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 620556] Review Request: folks - GObject contact aggregation library

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620556

--- Comment #18 from Fedora Update System  
2010-08-29 15:10:14 EDT ---
folks-0.1.14.1-1.fc14,libgee-0.5.2-2.fc14,vala-0.9.7-1.fc14 has been submitted
as an update for Fedora 14.
https://admin.fedoraproject.org/updates/folks-0.1.14.1-1.fc14,libgee-0.5.2-2.fc14,vala-0.9.7-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627682] Review Request: jarbundler

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627682

--- Comment #11 from Kevin Fenzi  2010-08-29 15:05:44 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627088] Review Request: fontik - A Configuration Tool for Font-wise, User-set Fontconfig Rules

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627088

--- Comment #3 from Kevin Fenzi  2010-08-29 15:02:58 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627555] Review Request: tlomt-orbitron-fonts - Geometric sans-serif typeface

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627555

--- Comment #11 from Kevin Fenzi  2010-08-29 15:04:59 EDT ---
Your request looks cut off. Can you add another comment with a full request?
The tool we use to process these can't find the request here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625678

--- Comment #3 from Kevin Fenzi  2010-08-29 15:00:48 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625939] Review Request: tintwizard - A GUI wizard which generates config files for tint2 panels

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625939

--- Comment #7 from Kevin Fenzi  2010-08-29 15:02:20 EDT ---
Git done (by process-git-requests).
(do remember to assign the review bug to the reviewer)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625855] Review Request: perl-EBook-EPUB - Perl module for generating EPUB documents

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625855

--- Comment #5 from Kevin Fenzi  2010-08-29 15:01:30 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625480] Review Request: libcollection - Collection data-type for C

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625480

--- Comment #3 from Kevin Fenzi  2010-08-29 14:59:07 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625482] Review Request: libini_config - INI file parser for C

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625482

--- Comment #3 from Kevin Fenzi  2010-08-29 15:00:06 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 565916] Review Request: php-ezc-Graph - A component for creating pie charts, line graphs and other kinds of diagrams

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565916

--- Comment #15 from Kevin Fenzi  2010-08-29 14:56:24 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617141] Review Request: gupnp-dlna - A collection of helpers for building DLNA applications

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617141

--- Comment #21 from Kevin Fenzi  2010-08-29 14:57:29 EDT ---
Well, in order to add it now you would need to request an exception from 
FESCo to allow the bundling. Or you could wait until it's no longer needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 528469] Review Request: php-ezc-EventLogDatabaseTiein - eZ Components EventLogDatabaseTiein

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528469

--- Comment #6 from Kevin Fenzi  2010-08-29 14:54:24 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 528473] Review Request: php-ezc-DatabaseSchema - eZ Components DatabaseSchema

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528473

--- Comment #17 from Kevin Fenzi  2010-08-29 14:54:36 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 528476] Review Request: php-ezc-PersistentObjectDatabaseSchemaTiein - eZ Components PersistentObjectDatabaseSchemaTiein

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528476

--- Comment #20 from Kevin Fenzi  2010-08-29 14:55:04 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 512506] Review Request: php-ezc-Feed - eZ Components Feed

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512506

--- Comment #11 from Kevin Fenzi  2010-08-29 14:53:55 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 512505] Review Request: php-ezc-AuthenticationDatabaseTiein - eZ Components AuthenticationDatabaseTiein

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512505

--- Comment #12 from Kevin Fenzi  2010-08-29 14:51:59 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490851] Review Request: php-ezc-SystemInformation - eZ Components SystemInformation

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490851

--- Comment #11 from Kevin Fenzi  2010-08-29 14:49:23 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 497736] Review Request: php-ezc-Mail - eZ Components Mail

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497736

--- Comment #13 from Kevin Fenzi  2010-08-29 14:51:15 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 498721] Review Request: php-ezc-Webdav - eZ Components Webdav

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498721

--- Comment #15 from Kevin Fenzi  2010-08-29 14:51:39 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 497735] Review Request: php-ezc-Cache - eZ Components Cache

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497735

--- Comment #13 from Kevin Fenzi  2010-08-29 14:50:46 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490592] Review Request: php-ezc-PersistentObject - eZ Components PersistentObject

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490592

--- Comment #12 from Kevin Fenzi  2010-08-29 14:48:09 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484567] Review Request: php-ezc-File - eZ Components File

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484567

--- Comment #16 from Kevin Fenzi  2010-08-29 14:46:22 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490849] Review Request: php-ezc-Archive- eZ Components Archive

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490849

--- Comment #13 from Kevin Fenzi  2010-08-29 14:48:52 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488549] Review Request: php-ezc-EventLog - eZ Components EventLog

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488549

--- Comment #14 from Kevin Fenzi  2010-08-29 14:47:44 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484563] Review Request: php-ezc-ConsoleTools - eZ Components ConsoleTools

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484563

--- Comment #15 from Kevin Fenzi  2010-08-29 14:46:06 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488539] Review Request: php-ezc-Configuration - eZ Components Configuration

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488539

--- Comment #14 from Kevin Fenzi  2010-08-29 14:46:48 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488542] Review Request: php-ezc-Database - eZ Components Database

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488542

--- Comment #15 from Kevin Fenzi  2010-08-29 14:47:28 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490591] Review Request: php-ezc-Template - eZ Components Template

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490591

--- Comment #14 from Kevin Fenzi  2010-08-29 14:47:56 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484509] Review Request: php-ezc-Base - eZ Components Base

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484509

--- Comment #14 from Kevin Fenzi  2010-08-29 14:45:53 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 471805] Review Request: aespipe - AES-based encryption tool for tar/cpio and loop-aes images

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471805

--- Comment #26 from Kevin Fenzi  2010-08-29 14:44:49 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488538] Review Request: php-ezc-Authentication - eZ Components Authentication

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488538

--- Comment #14 from Kevin Fenzi  2010-08-29 14:46:35 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484507] Review Request: php-channel-ezc - eZ Components

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484507

--- Comment #9 from Kevin Fenzi  2010-08-29 14:45:09 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

--- Comment #6 from Martin Gieseking  2010-08-29 
14:40:45 EDT ---
(In reply to comment #5)
> Thank you very much for your suggestions !

Hi Son, you're welcome. 


> the libextracppunit is not still removed. It permit
> someone who does not have libextracppunit can nevertheless use stdair. I'll
> remove it when libextracppunit is passed the review.

Unfortunately, that's not possible. Your package can't be approved as long as
it bundles a library. Thus, you should prepare your package as if extracc was
already available. As a consequence, extracc blocks stdair, and you have to
wait until it's approved.

Concerning your current spec file, you should replace %{?el5:FOO} and
%{?rhel:BAR} with FOO and BAR, respectively. And completely drop
%{?el5:BuildRequires: tetex-latex}

The virtual package tex(latex) ensures that the correct packages are referenced
(currently texlive-latex in Fedora, and tetex-latex in EPEL <= 5).
Explicitly adding the BuildRoot tag and cleaning %{buildroot} also doesn't
hurt. So if you plan to maintain this package for EPEL too, just add the
corresponding lines as requested by the EPEL guidelines. Fedora also still
accepts them.

You can drop
  rm -f $RPM_BUILD_ROOT%{_libdir}/lib%{name}.la
  rm -f $RPM_BUILD_ROOT%{_libdir}/libextracppunit.la
The preceding rm statement already removes all .la files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 429444] Review Request: libmspack - A library for compression and decomepression

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=429444

--- Comment #15 from Kevin Fenzi  2010-08-29 14:43:06 EDT ---
Should be unretired now. 
Please take ownership in pkgdb web interface.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607584] Review Request: wordgroupz - A vocabulary building application

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607584

--- Comment #13 from Mamoru Tasaka  2010-08-29 
14:15:03 EDT ---
For 0.3b-4:

* Source tarball
--
26340 wordgroupz-0.3b-1.fc13.src/wordgroupz-0.3b.tar.gz
50345 wordgroupz-0.3b-4.fc13.src/wordgroupz-0.3b.tar.gz
--
  - What happened here? Tarball itself must not be released
until the version number is changed. 

If you are the upstream
and you modified the source codes themselves, please change
the version number of the tarball to avoid confusion.

* Macros in comments
  - As I said in my previous comment, rpmlint still complaints:
--
wordgroupz.src:13: W: macro-in-comment %{_tmppath}
wordgroupz.src:13: W: macro-in-comment %{name}
wordgroupz.src:13: W: macro-in-comment %{version}
wordgroupz.src:13: W: macro-in-comment %{release}
wordgroupz.src:21: W: macro-in-comment %{name}
--
The lines 13 and 21 are no longer needed. Please remove these unneeded
comments.
- If you want to keep these comments, please use %% instead of %
  in comments so that macros won't be expanded.

* Requires
  - For "Requires: python-sqlite2"
wordgroupz.py says:
--
19  import sqlite3
--
This uses sqlite3, not sqlite2, so "Requires: python-sqlite2" is not
needed.
Also "sqlite3" module is already in python rpm.

  - For "Requires: python-matplotlib"
Why is this needed? It seems that the lines related to matplotlib are
all commented out.

* desktop file,
  - As I said before, "Application" in "Categories"
item in %_datadir/applications/%name.desktop is redundant and should
be removed.

* Unneeded shebangs
---
wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/espeak.py
0644L /bin/env
wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/games.py
0644L /usr/bin/evn
wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/get_fields.py
0644L /usr/bin/env
wordgroupz.noarch: E: non-executable-script /usr/share/wordgroupz/html2text.py
0644L /usr/bin/env
wordgroupz.noarch: W: no-manual-page-for-binary wordgroupz
---
  - Shebangs on these files are unneeded because these scripts don't have
exectuable
permission. Also some files have wrong shebangs, anyway these shebangs
should be removed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627638] Review Request: git2cl - Converts git logs to GNU ChangeLog format.

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627638

Terje Røsten  changed:

   What|Removed |Added

 CC||terje...@phys.ntnu.no

--- Comment #3 from Terje Røsten  2010-08-29 14:03:07 
EDT ---
Just a small tip, using --prefix option in git archive and xz (to save som
bytes):

$ git archive --format=tar --prefix=%{name}-%{version}/ | xz -c >
git2cl-2.0.tar.xz

the -c option to %setup can then be removed. 

mkdir can be removed (if you like) by adding the -D option to install:

install -p -D -m 755 git2cl $RPM_BUILD_ROOT%{_bindir}/git2cl

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 614036] Review Request: stdair - C++ Standard Airline IT Library - FE-NEEDSPONSOR

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=614036

--- Comment #5 from Son Nguyen Kim  2010-08-29 13:25:20 
EDT ---
Hello Martin, 

Thank you very much for your suggestions !

Here's the updated SPEC  and SRPM file after taking changing the SPEC file as
you suggested, except the libextracppunit is not still removed. It permit
someone who does not have libextracppunit can nevertheless use stdair. I'll
remove it when libextracppunit is passed the review.

SPEC file : http://subversion.assembla.com/svn/stdair/stdair.spec
SRPM file:
http://subversion.assembla.com/svn/stdair/stdair-0.3.0-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607873] Review Request: OTRS - Open Source Ticket Request System

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607873

--- Comment #4 from Jeroen van Meeuwen  2010-08-29 
10:11:25 EDT ---
Yes, I was aware of all that.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 617141] Review Request: gupnp-dlna - A collection of helpers for building DLNA applications

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=617141

Peter Robinson  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 589867] Review Request: logcheck - analyzes logfiles and sends email

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=589867

--- Comment #16 from Peter Robinson  2010-08-29 10:01:47 
EDT ---
(In reply to comment #15)
> lockfile-progs (as last remaining dependency) is in -testing now. All other
> dependencies are approved and hit the repositories.
> 
> Can we proceed with the review now?

Yes, I'll do it in the next day or two.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 604331] Review Request: redshift - Adjusts the color temperature of your screen according to time of day

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=604331

--- Comment #13 from Miloš Komarčević  2010-08-29 
09:02:25 EDT ---
Left some informal feedback in bug 598315, left the actual review checklist for
after these issues are fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 598315] Review Request: UrJTAG - A tool to flash/program/debug hardware via JTAG adapters

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=598315

Miloš Komarčević  changed:

   What|Removed |Added

 CC||miloskomarce...@netscape.ne
   ||t

--- Comment #2 from Miloš Komarčević  2010-08-29 
08:58:52 EDT ---
Hi Andrew, I'm not an official Fedora reviewer, but I'd like to offer some
feedback to help you move things along sice I think this would be a vrey useful
package for e.g. FEL:

- The spec file in your URL above contains some HTML tags so it is corrupt when
downloaded, please fix

- Looking at the actual code, license should be GPLv2+

- Please use sentence case in the description, and feel free to be more
verbose, e.g. a full paragraph from the web page...

- Add libusb-devel, libftdi-devel and readline-devel in BuildRequires to enable
all the features of the program, it's a bit useless without them...

- No need for BuildRoot tag for F10 and later; no need for %clean section for
F13 and later; maybe prefer using the %{buildroot} macro instead of
$RPM_BUILD_ROOT variable in the %install section, see
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

- %doc section is missing NEWS and perhaps ChangeLog

- %changelog section should list _your_ changes to the spec file, not the
program's changes, see
http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 620385] Review Request: BEDTools - A flexible suite of utilities for comparing genomic features

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=620385

Martin Gieseking  changed:

   What|Removed |Added

 CC||martin.giesek...@uos.de

--- Comment #3 from Martin Gieseking  2010-08-29 
08:57:12 EDT ---
Hi Adam,

some initial comments:

- the license seems to be GPLv2+ (according to the source file headers)

- file LICENSE is missing in %doc

- The package contains the "curl" sources (in src/utils/curl). You should
remove 
  them and rely on the corresponding Fedora package instead.

- set the file permissions of the data files to 644, e.g. with
  find %{buildroot}%{_datadir}/%{name} -type f -exec chmod 0644 {} \;

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 442714] Review Request: satsolver - Satisfiability Solver library which can be used to compute inter-package dependencies.

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442714

Lorenzo Villani  changed:

   What|Removed |Added

   Flag||needinfo?(debarshi@gmai
   ||l.com)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 442714] Review Request: satsolver - Satisfiability Solver library which can be used to compute inter-package dependencies.

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=442714

Lorenzo Villani  changed:

   What|Removed |Added

Summary|Review Request: sat-solver  |Review Request: satsolver -
   |- Satisfyability Solver |Satisfiability Solver
   |library which can be used   |library which can be used
   |to compute inter-package|to compute inter-package
   |dependencies.   |dependencies.

--- Comment #53 from Lorenzo Villani  2010-08-29 
08:48:39 EDT ---
SPEC URL: http://github.com/lvillani/RPMs/raw/master/satsolver/satsolver.spec
SRPM URL:
http://arbiter.fedorapeople.org/reviews/satsolver/satsolver-0.15.0-2.fc13.src.rpm

Changed package's name.
Also, I added some comments above PatchN and SourceN lines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624660] Review Request: rakudo-star - Rakudo, Perl6-modules, Blizkost and documentation

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624660

--- Comment #3 from Gerd Pokorra  2010-08-29 08:20:58 
EDT ---
The rakudo-star package compiles the perl6 executable und the perl modules. It
should replace the rakudo package.

URL of successful scratch build with F14:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2433586

URL of successful scratch build with F13:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2433589


I think the rpmlint output looks acceptable:

> rpmlint rakudo-star.spec
rakudo-star.spec: W: invalid-url Source1: rakudo.desk.in.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings. 

> rpmlint rakudo-star-0.0.2010.08_2.7.0-1.fc13.src.rpm
rakudo-star.src: W: invalid-url Source1: rakudo.desk.in.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

> rpmlint rakudo-star-0.0.2010.08_2.7.0-1.fc13.x86_64.rpm 
rakudo-star.x86_64: W: no-manual-page-for-binary parrot-blizkost
rakudo-star.x86_64: W: no-manual-page-for-binary ufo
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

> rakudo-star-debuginfo-0.0.2010.08_2.7.0-1.fc13.x86_64.rpm 
rakudo-star-debuginfo.x86_64: E: debuginfo-without-sources
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 628280] Review Request: apache-commons-collections - rename of jakarta-commons-collections

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=628280

--- Comment #2 from Alexander Kurtakov  2010-08-29 
08:06:59 EDT ---
First impressions:
* You don't need Source1 ... Source5 and %patch1. These are not needed nowadays
anymore we have a proper maven environment.
* You can also remove the following from the %build section:
export DEPCAT=$(pwd)/commons-collections-3.2-depcat.new.xml
echo '' > $DEPCAT
echo '' >> $DEPCAT
for p in $(find . -name project.xml); do
pushd $(dirname $p)
/usr/bin/saxon project.xml %{SOURCE1} >> $DEPCAT
popd
done
echo >> $DEPCAT
echo '' >> $DEPCAT
/usr/bin/saxon $DEPCAT %{SOURCE2} > commons-collections-3.2-depmap.new.xml

for p in $(find . -name project.xml); do
pushd $(dirname $p)
cp project.xml project.xml.orig
/usr/bin/saxon -o project.xml project.xml.orig %{SOURCE3} map=%{SOURCE4}
popd
done

It was needed for maven1 build which is something we don't do in Fedora
* rpmlint gives:
- apache-commons-collections-testframework-javadoc.noarch: W:
non-standard-group Development/Documentation
Should be Documentation
- apache-commons-collections-testframework.noarch: W: non-standard-group
Development/Testing
Maybe Development/Tools
- apache-commons-collections-testframework.noarch: W: no-documentation
Not a real problem.
- apache-commons-collections-testframework.noarch: W: empty-%post
- apache-commons-collections-testframework.noarch: W: empty-%postun
When you don't have what to put in these sections just remove them.
- apache-commons-collections.noarch: W: non-standard-group
Development/Libraries/Java
Should be Development/Libraries
- apache-commons-collections.noarch: W: non-conffile-in-etc
/etc/maven/fragments/apache-commons-collections
Not a problem
- apache-commons-collections-javadoc.noarch: W: non-standard-group
Development/Documentation
Should be Documentation
- apache-commons-collections-tomcat5.noarch: W: non-standard-group
Development/Libraries/Java
should be Development/Libraries
- apache-commons-collections-tomcat5.noarch: W: empty-%post
- apache-commons-collections-tomcat5.noarch: W: empty-%postun
Remove empty sections like this.

* file permissions is %defattr(0644,root,root,0755) but the preferred way is 
%defattr(-,root,root,-) so when/if defaults changes they will be picked up just
by a rebuild

Once these issues are fixed I'll do the official review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 628280] Review Request: apache-commons-collections - rename of jakarta-commons-collections

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=628280

Alexander Kurtakov  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||akurt...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Alexander Kurtakov  2010-08-29 
07:43:58 EDT ---
I'll do this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607584] Review Request: wordgroupz - A vocabulary building application

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607584

Ratnadeep Debnath  changed:

   What|Removed |Added

   Flag|needinfo?(rtn...@gmail.com) |

--- Comment #12 from Ratnadeep Debnath  2010-08-29 07:09:57 
EDT ---
Hi,

Today, I made an RPM for the latest wordgroupz codebase and included the above
mentioned changes.
SPEC: http://rtnpro.fedorapeople.org/Packages/SPECS/wordgroupz.spec
SRPM:
http://rtnpro.fedorapeople.org/Packages/SRPMS/wordgroupz-0.3b-4.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607873] Review Request: OTRS - Open Source Ticket Request System

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607873

--- Comment #3 from Jos Vos  2010-08-29 07:02:45 EDT ---
Also don't forget the var stuff (now /var/www/otrs/var/tmp) that is cache stuff
that should go to /var/cache/otrs or so.  Probably /var/www/otrs should be
minimized and mostly contain symlinks to other parts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607873] Review Request: OTRS - Open Source Ticket Request System

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607873

--- Comment #2 from Jeroen van Meeuwen  2010-08-29 
06:54:34 EDT ---
I've worked on the spec file a little, and come to think of it it needs a
complete overhaul...

1) The perl libraries should be in the OTRS* namespace, not the Kernel*
namespace.
2) Since the perl libraries have APIs, they should probably live in
%perl_vendorlib
3) A separate -doc subpackage is required for the many example scripts
4) The dummy perl requires and perl provides macros should go, and the
Kernel/cpan-lib/* directory should be removed entirely.

I'm on a different computer right now so I can't upload the spec but I'll pick
it up and throw it out somewhere soon. FWIW; this spec also works for OTRS
3.0.0 beta2, which, frankly, I don't like ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624660] Review Request: rakudo-star - Rakudo, Perl6-modules, Blizkost and documentation

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624660

Gerd Pokorra  changed:

   What|Removed |Added

Summary|Review Request: rakudo-star |Review Request: rakudo-star
   |- Modules and things around |- Rakudo, Perl6-modules,
   |Rakudo  |Blizkost and documentation

--- Comment #2 from Gerd Pokorra  2010-08-29 05:49:42 
EDT ---
new Description:
Rakudo Perl 6, or just Rakudo, is a Perl 6 compiler for the Parrot virtual
machine. Rakudo is an implementation of the Perl 6 specification that runs
on the Parrot VM. More information about Perl 6 is available from:
http://perl6.org
Rakudo Star is a collection of things around Rakudo. It installs Perl 6
modules.
Rakudo Star also includes Blizkost, which enables you to use Perl 5
modules from Perl 6.
The documentation includes a PDF-document that describes the using of Perl 6.

new SRPM URL:
ftp://ftp.uni-siegen.de/pub/review/rakudo-star-0.0.2010.08_2.7.0-1.fc13.src.rpm

the old Spec URL holds the current spec-file:
ftp://ftp.uni-siegen.de/pub/review/rakudo-star.spec

latest successful F15 scratch build URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2433421

- desktop files added

This is a build of the current Rakudo star sources which should go in the
Fedora 14 release if the review is done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627637] Review Request: qroneko - A front end of crontab application

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627637

Martin Gieseking  changed:

   What|Removed |Added

 CC||martin.giesek...@uos.de

--- Comment #4 from Martin Gieseking  2010-08-29 
05:13:54 EDT ---
Hi Praveen,

the tarball in the SRPM doesn't match the upstream one:
$ md5sum qroneko-0.5.4.tar.gz*
e223113fb16e96d6780da3d29eb4c214  qroneko-0.5.4.tar.gz
5e2e20d9ce40e076cbe79d64a21f6e6b  qroneko-0.5.4.tar.gz.1

You must use the unchanged upstream tarball to build you package. Also, don't
add a file containing the license text if it's not present in the tarball.
However, you should ask the upstream developer to add it to a future release.

If you need to change some source files, add patches to your package.

Here are some more comments:
- Drop BR: qt as it's automatically added as a dependency of qt-devel.

- I suggest to use the %description text from the upstream website:
  qroneko is a scheduling utility which uses crontab as the backend.

  Features and highlights:
  * Smart "Cron Time" Setting.
  * Lists expected execute time.
  * Enables to edit crontab by text

- In the %prep section, it's sufficient to use %setup -q

- Don't add full paths to install and qmake_qt4 since they may be different. 
  Just use "install" and %{_qt4_qmake}

- The tarball doesn't contain a .desktop file. Thus, you have to add one to 
  your package. See https://fedoraproject.org/wiki/Packaging/Guidelines#desktop
  (permissions of the .desktop file should be 0644)

- add a blank line between the %changelog entries to increase legibility

- The package fails building for x86_64. The Compilation aborts with error 
  messages like this:
  CronModel.cpp:248: error: cast from 'TCommand*' to 'int' loses precision

  This should be reported and fixed upstream. However, the upstream
  developer submitted the latest changes 4 years ago, so the project probably 
  isn't active any longer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 498721] Review Request: php-ezc-Webdav - eZ Components Webdav

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498721

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #14 from Guillaume Kulakowski  2010-08-29 
05:12:57 EDT ---
Package Change Request
==
Package Name: php-ezc-Webdav
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 528476] Review Request: php-ezc-PersistentObjectDatabaseSchemaTiein - eZ Components PersistentObjectDatabaseSchemaTiein

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528476

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #19 from Guillaume Kulakowski  2010-08-29 
05:10:56 EDT ---
Package Change Request
==
Package Name: php-ezc-PersistentObjectDatabaseSchemaTiein 
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 565916] Review Request: php-ezc-Graph - A component for creating pie charts, line graphs and other kinds of diagrams

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565916

Remi Collet  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #14 from Remi Collet  2010-08-29 05:09:49 
EDT ---
Package Change Request
==
Package Name: php-ezc-Graph
New Branches: EL-6
Owners: remi  llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490592] Review Request: php-ezc-PersistentObject - eZ Components PersistentObject

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490592

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #11 from Guillaume Kulakowski  2010-08-29 
05:10:32 EDT ---
Package Change Request
==
Package Name: php-ezc-PersistentObject
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490851] Review Request: php-ezc-SystemInformation - eZ Components SystemInformation

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490851

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #10 from Guillaume Kulakowski  2010-08-29 
05:11:40 EDT ---
Package Change Request
==
Package Name: php-ezc-SystemInformation 
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490591] Review Request: php-ezc-Template - eZ Components Template

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490591

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #13 from Guillaume Kulakowski  2010-08-29 
05:12:23 EDT ---
Package Change Request
==
Package Name: php-ezc-Template  
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 512506] Review Request: php-ezc-Feed - eZ Components Feed

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=512506

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #10 from Guillaume Kulakowski  2010-08-29 
05:07:31 EDT ---
Package Change Request
==
Package Name: php-ezc-Feed
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 528469] Review Request: php-ezc-EventLogDatabaseTiein - eZ Components EventLogDatabaseTiein

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528469

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #5 from Guillaume Kulakowski  2010-08-29 
05:06:58 EDT ---
Package Change Request
==
Package Name: php-ezc-EventLogDatabaseTiein
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 497736] Review Request: php-ezc-Mail - eZ Components Mail

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497736

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 497736] Review Request: php-ezc-Mail - eZ Components Mail

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497736

--- Comment #12 from Guillaume Kulakowski  2010-08-29 
05:09:38 EDT ---
Package Change Request
==
Package Name: php-ezc-Mail  
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488549] Review Request: php-ezc-EventLog - eZ Components EventLog

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488549

--- Comment #13 from Guillaume Kulakowski  2010-08-29 
05:05:59 EDT ---
Package Change Request
==
Package Name: php-ezc-EventLog
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 484567] Review Request: php-ezc-File - eZ Components File

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484567

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #15 from Guillaume Kulakowski  2010-08-29 
05:08:05 EDT ---
Package Change Request
==
Package Name: php-ezc-File
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488549] Review Request: php-ezc-EventLog - eZ Components EventLog

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488549

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 528473] Review Request: php-ezc-DatabaseSchema - eZ Components DatabaseSchema

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=528473

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #16 from Guillaume Kulakowski  2010-08-29 
05:00:09 EDT ---
Package Change Request
==
Package Name: php-ezc-DatabaseSchema
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488539] Review Request: php-ezc-Configuration - eZ Components Configuration

2010-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488539

Guillaume Kulakowski  changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #13 from Guillaume Kulakowski  2010-08-29 
04:57:20 EDT ---
Package Change Request
==
Package Name: php-ezc-Configuration
New Branches: EL-6
Owners: llaumgui

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


  1   2   >