[Bug 543154] Review Request: mingw32-SDL_mixer - Simple DirectMedia Layer's Sample Mixer Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543154 --- Comment #8 from Stefan Riemens 2010-09-27 02:44:31 EDT --- Thanks for taking on the review! Updated spec: http://riemens.mine.nu:8080/mingw32-SDL_mixer.spec Updated srpm: http://riemens.mine.nu:8080/mingw32-SDL_mixer-1.2.11-0.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 580447] Review Request: perl-Module-Build - Build and install Perl modules
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=580447 Marcela Mašláňová changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2010-09-27 02:23:59 --- Comment #24 from Marcela Mašláňová 2010-09-27 02:23:59 EDT --- (In reply to comment #23) > ok. I think I have 'undepreciated' this. Can you see if you can take owership > in the pkgdb web interface? > > Reset the flag if you need anything further. Thank you. I'm owner now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628524] Review Request: festival-freebsoft-utils - A collection of utilities that enhance Festival with some useful features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628524 Peter Robinson changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Peter Robinson 2010-09-27 02:27:17 EDT --- Thanks, will fix the above before initial commit. New Package GIT Request === Package Name: festival-freebsoft-utils Short Description: A collection of utilities that enhance Festival with some useful features Owners: pbrobinson Branches: F-14 F-13 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615692] Review Request: ghc-gtk - Haskell gtk binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615692 Jens Petersen changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615692] Review Request: ghc-gtk - Haskell gtk binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615692 --- Comment #11 from Jens Petersen 2010-09-27 00:57:37 EDT --- I have updated ghc-glib in F14 btw - it is in testing now: https://admin.fedoraproject.org/updates/ghc-pango-0.11.2-2.fc14,ghc-gio-0.11.1-2.fc14.1,ghc-glib-0.11.2-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615028] Review Request: php-phpunit-PHP-Timer - PHP Utility class for timing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615028 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System 2010-09-26 23:39:00 EDT --- php-phpunit-PHP-Timer-1.0.0-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-phpunit-PHP-Timer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/php-phpunit-PHP-Timer-1.0.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 633549] Review Request: rubygem-linode - Ruby wrapper for the Linode API
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=633549 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System 2010-09-26 23:38:55 EDT --- rubygem-linode-0.6.2-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-linode'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-linode-0.6.2-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622173] Review Request: gappa - Prove programs with floating-point or fixed-point arithmetic
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=622173 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System 2010-09-26 23:37:42 EDT --- gappa-0.13.0-4.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gappa'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/gappa-0.13.0-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 490940] Review Request: pubcookie - Open-source software for intra-institutional web authentication
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=490940 Gabriel Somlo changed: What|Removed |Added Flag||fedora-cvs? --- Comment #10 from Gabriel Somlo 2010-09-26 21:47:46 EDT --- New Package SCM Request === Package Name: mod_pubcookie Short Description: A solution for single sign-on authentication to websites Owners: somlo Branches: f12 f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615692] Review Request: ghc-gtk - Haskell gtk binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615692 Jens Petersen changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com Bug 615692 depends on bug 614024, which changed state. Bug 614024 Summary: Review Request: ghc-pango - Haskell pango binding https://bugzilla.redhat.com/show_bug.cgi?id=614024 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED Bug 615692 depends on bug 629551, which changed state. Bug 629551 Summary: Review Request: ghc-gio - Haskell binding to glib's gio https://bugzilla.redhat.com/show_bug.cgi?id=629551 What|Old Value |New Value Resolution||ERRATA Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630215] Review Request: ghc-MemoTrie - Trie-based memo functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630215 --- Comment #1 from Jens Petersen 2010-09-26 20:36:06 EDT --- Latest version is 0.4.9 btw. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632186] Review Request: erlang-log4erl - A logger for erlang in the spirit of Log4J
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=632186
--- Comment #2 from Peter Robinson 2010-09-26 17:38:59
EDT ---
Mostly OK. License needs to be fixed, and there's a few errors in rpmlint.
+ rpmlint output
rpmlint erlang-log4erl-0.9.0-2.fc14.x86_64.rpm
erlang-log4erl.x86_64: E: explicit-lib-dependency erlang-stdlib
erlang-log4erl.x86_64: E: no-binary
erlang-log4erl.x86_64: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 2 errors, 1 warnings.
+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
- license matches the actual package license
License is MPL-1.1 and BSD
+ latest version packaged
+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
6fb55aac281e5fdf61d6778a06bf8108 log4erl-0.9.0.tar.gz
+ package successfully builds on at least one architecture
tested using koji scratch build
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
+ package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
+ %defattr line
+ consistent use of macros
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8
Optional:
+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
+ scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
n/a Package should have man files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615028] Review Request: php-phpunit-PHP-Timer - PHP Utility class for timing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615028 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615028] Review Request: php-phpunit-PHP-Timer - PHP Utility class for timing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615028 --- Comment #5 from Fedora Update System 2010-09-26 16:36:46 EDT --- php-phpunit-PHP-Timer-1.0.0-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/php-phpunit-PHP-Timer-1.0.0-2.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636930] Review Request:projectcenter - The GNUstep IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636930 --- Comment #4 from Martin Gieseking 2010-09-26 15:24:34 EDT --- (In reply to comment #3) > questing: Which version of gnustep-back do you have on your system? It seems, gnustep-back isn't installed at all. Thus, you should probably add it as a dependency. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623604] Review Request: xneur - X Neural Switcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623604 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Flag||fedora-cvs? --- Comment #11 from Pavel Alexeev (aka Pahan-Hubbitus) 2010-09-26 14:57:17 EDT --- It's what I already forgot :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629873] Review Request: gnome-video-effects - Collection of GStreamer video effects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629873 --- Comment #5 from Kevin Fenzi 2010-09-26 14:49:59 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615028] Review Request: php-phpunit-PHP-Timer - PHP Utility class for timing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615028 --- Comment #4 from Kevin Fenzi 2010-09-26 14:49:40 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 622314] Review request: 3Depict- Valued point cloud visualisation and analysis
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=622314
--- Comment #7 from Martin Gieseking 2010-09-26
14:47:24 EDT ---
(In reply to comment #6)
> I have done this, but I was under the impression that %{_datadir}/%{name}
> automatically detected directory status, and was recursive? If I am wrong, I
> would like clarification, as this may impact other packages I maintain.
Yes, you're right. %{_datadir}/%{name}/ adds the directory and all its contents
recursively including sub-directories. Thus, this single line is sufficient.
The advantage of the more verbose variant is it prevents packaging of unwanted
files/folders that might have been in installed by accident.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 567348] Review Request: dreampie - A graphical cross-platform interactive Python shell
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=567348 --- Comment #26 from Kevin Fenzi 2010-09-26 14:48:09 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540885] Review Request: CableSwig - Create interfaces to interpreted languages for templated code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540885 --- Comment #16 from Kevin Fenzi 2010-09-26 14:47:22 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 589866] Review Request: darktable - Utility to organize and develop raw images
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=589866 --- Comment #53 from Kevin Fenzi 2010-09-26 14:49:10 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 606421] Review Request: quickfix - Open Source FIX Engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=606421 Martin Dengler changed: What|Removed |Added Flag|needinfo?(mar...@martindeng | |ler.com)| --- Comment #15 from Martin Dengler 2010-09-26 14:40:47 EDT --- Sorry for the delay...I'm using the already-packaged unittest now but I'm having to teach the build system more about autotools / automake than it and I know. It's getting there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636930] Review Request:projectcenter - The GNUstep IDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636930 --- Comment #3 from Jochen Schmitt 2010-09-26 14:42:26 EDT --- questing: Which version of gnustep-back do you have on your system? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 623604] Review Request: xneur - X Neural Switcher
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=623604 --- Comment #10 from Martin Gieseking 2010-09-26 14:19:22 EDT --- (In reply to comment #9) > Thank you very much for the review. You're welcome. Please don't forget to set the fedora-cvs flag. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637448] Review Request: rubygem-glib2 - Ruby binding of GLib-2.x
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637448 --- Comment #1 from Mamoru Tasaka 2010-09-26 14:08:15 EDT --- http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2.spec http://mtasaka.fedorapeople.org/Review_request/rubygem-glib/rubygem-glib2-0.90.2-2.fc.src.rpm * Mon Sep 27 2010 Mamoru Tasaka - 0.90.2-2 - 0.90.2 released, release bump -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #9 from elad 2010-09-26 13:44:34 EDT --- done. new src.rpm file: http://elad.fedorapeople.org/gnome-exe-thumbnailer-0.6-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #8 from Arun SAG 2010-09-26 12:52:25 EDT --- Once done, please go through http://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636819
--- Comment #7 from Arun SAG 2010-09-26 12:51:17 EDT ---
rpmlint issue:
gnome-exe-thumbnailer.noarch: W: non-conffile-in-etc
/etc/gconf/schemas/gnome-exe-thumbnailer.schemas
Mark your schemas file as config file in %config section
%config %{_sysconfdir}/gconf/schemas/%{name}.schemas
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630782] Rename request: meego-panel-applications - MeeGo Panel for launching Applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630782
--- Comment #2 from Peter Lemenkov 2010-09-26 12:00:53 EDT
---
This package also seems to be for F-15 only. Failed scratchbuild on F-14:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2490108
Koji scratch build for Rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2490111
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
Sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/meego-panel-applications-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license
(LGPLv2)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+/- The package successfully compiles and builds into binary rpms on at least
one primary architecture but only in Rawhide.
+ All build dependencies are listed in BuildRequires.
+ The spec file handles locales properly.
+ The package calls ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files
0 No static libraries
0 No library file that end in .so (without suffix)
0 No devel sub-package
+ The package does NOT contain any .la libtool archives.
+/- The package includes a %{name}.desktop file, and that file should properly
installed with desktop-file-install in the %install section but instead it is
placed into
%{_datadir}/mutter-meego/panels/meego-panel-applications.desktop
I don't know too much about Meego - is it intentional?
+ The package does not own files or directories already owned by other
packages.
+ All filenames in the package are valid UTF-8.
Please
* Explain whether this package is designed only for Rawhide or not
* Explain the situation with desktop file
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 540885] Review Request: CableSwig - Create interfaces to interpreted languages for templated code
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=540885 Mario Ceresa changed: What|Removed |Added Summary|Review Request: cableswig - |Review Request: CableSwig - |Create interfaces to|Create interfaces to |interpreted languages for |interpreted languages for |templated code |templated code Flag||fedora-cvs? --- Comment #15 from Mario Ceresa 2010-09-26 11:58:25 EDT --- Hello Kevin, sorry for the mispelling. Is this right now? Thanks Mario New Package SCM Request === Package Name: CableSwig Short Description: Create interfaces to interpreted languages for templated code Owners: mrceresa Branches: f12 f13 f14 el6 el5 InitialCC: mrceresa -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629247] Rename Request: meego-panel-myzone - MeeGo Panel for display of current social information
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=629247
--- Comment #2 from Peter Lemenkov 2010-09-26 11:42:11 EDT
---
FTBFS on F-14 - is this package designed only for F-15?
http://koji.fedoraproject.org/koji/taskinfo?taskID=2490065
Koji build for F-15:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2490068
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint not silent but its messages can be safely ignored in this case:
Sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/meego-panel-myzone-*
meego-panel-myzone.x86_64: W: spelling-error %description -l en_US chekck ->
check, Chekhov, Cheka
meego-panel-myzone.x86_64: W: self-obsoletion moblin-panel-myzone < 0.2.6
obsoletes moblin-panel-myzone = 0.2.5-1.fc15
meego-panel-myzone.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/meego-panel-myzone.desktop
meego-panel-myzone.x86_64: W: non-conffile-in-etc
/etc/gconf/schemas/meego-panel-myzone.schemas
meego-panel-myzone-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
Sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
- The License field in the package spec file must match the actual license!
Proper license tag is LGPLv2+
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+/- The package successfully compiles and builds into binary rpms on at least
one primary architecture but only in Rawhide.
+ All build dependencies are listed in BuildRequires.
+ The spec file handles locales properly.
+ The package calls ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
+ Header files are packaged in a -devel package.
0 No static libraries
+ The library file that end in .so (without suffix) packaged in a -devel
package.
+ The devel package requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
+/- The package includes a %{name}.desktop file, and that file should properly
installed with desktop-file-install in the %install section but instead it is
placed into
%{_sysconfdir}/xdg/autostart/meego-panel-myzone.desktop
%{_datadir}/mutter-meego/panels/meego-panel-myzone.desktop
I don't know too much about Meego - is it intentional? Also there is one more
*.desktop file:
/usr/share/applications/myzone.desktop
This one should be validated in the %install section using
desktop-file-validate (
https://fedoraproject.org/wiki/Packaging/Guidelines#desktop )
+ Packages does not own files or directories already owned by other packages.
+ All filenames in rpm packages are valid UTF-8.
So, please:
* Fix license tag
* Explain whether this package is designed only for Rawhide or not
* Add validation for desktop file(s) (at least for one, stored in
/usr/share/applications )
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #6 from elad 2010-09-26 11:27:59 EDT --- i've fixed more errors. new src.rpm link: http://elad.fedorapeople.org/gnome-exe-thumbnailer-0.6-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628524] Review Request: festival-freebsoft-utils - A collection of utilities that enhance Festival with some useful features
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=628524
Peter Lemenkov changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #2 from Peter Lemenkov 2010-09-26 10:50:23 EDT
---
Koji build for F-13:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2490061
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is silent
Sulaco ~/rpmbuild/SPECS: rpmlint
~/Desktop/festival-freebsoft-utils-0.10-1.fc13.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines.
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+/- The License field in the package spec file does not match the actual
license (should be GPLv2+, not simply GPLv2).
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.
Sulaco ~/rpmbuild/SOURCES: sha256sum festival-freebsoft-utils-0.10.tar.gz*
c16cbd1d5494b1b058b787ef936fa483ac2f3ce92657372c92b3dbf153750457
festival-freebsoft-utils-0.10.tar.gz
c16cbd1d5494b1b058b787ef936fa483ac2f3ce92657372c92b3dbf153750457
festival-freebsoft-utils-0.10.tar.gz.1
Sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture (see koji link above)
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files.
+ The package does NOT bundle copies of system libraries.
+ The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
0 No pkgconfig(.pc) files.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
0 No devel sub-package.
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Just three minor suggestions:
* Consider building docs also
* Use %{_datadir} macro in the %install section
* Fix licensing tag (GPLv2+ instead of GPLv2)
This package is
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629247] Rename Request: meego-panel-myzone - MeeGo Panel for display of current social information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629247 Peter Lemenkov changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629247] Rename Request: meego-panel-myzone - MeeGo Panel for display of current social information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629247 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com --- Comment #1 from Peter Lemenkov 2010-09-26 10:29:51 EDT --- I'll review it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628524] Review Request: festival-freebsoft-utils - A collection of utilities that enhance Festival with some useful features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628524 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com --- Comment #1 from Peter Lemenkov 2010-09-26 10:29:32 EDT --- I'll review it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 628524] Review Request: festival-freebsoft-utils - A collection of utilities that enhance Festival with some useful features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=628524 Peter Lemenkov changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630782] Rename request: meego-panel-applications - MeeGo Panel for launching Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630782 Peter Lemenkov changed: What|Removed |Added Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630782] Rename request: meego-panel-applications - MeeGo Panel for launching Applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630782 Peter Lemenkov changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com --- Comment #1 from Peter Lemenkov 2010-09-26 10:30:17 EDT --- I'll review it -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226339] Merge Review: Pyrex
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226339 Parag AN(पराग) changed: What|Removed |Added Status|MODIFIED|ASSIGNED CC||panem...@gmail.com AssignedTo|mbar...@redhat.com |panem...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226343] Merge Review: python-ldap
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226343 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Summary|Merge Review: python-ldap |Merge Review: python-ldap |(not started) | Flag||fedora-review? Bug 226343 depends on bug 451684, which changed state. Bug 451684 Summary: Can't build Pyrex modules with current setuptools, upgrade to 0.6c8 https://bugzilla.redhat.com/show_bug.cgi?id=451684 What|Old Value |New Value Status|NEW |ASSIGNED Status|ASSIGNED|ON_QA Resolution||CURRENTRELEASE Status|ON_QA |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533744] Review Request: ImageJ - Image Processing and Analysis in Java
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533744 --- Comment #14 from D Haley 2010-09-26 10:18:25 EDT --- Did this ever get uploaded?? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632186] Review Request: erlang-log4erl - A logger for erlang in the spirit of Log4J
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632186 Peter Robinson changed: What|Removed |Added Status|NEW |ASSIGNED CC||pbrobin...@gmail.com AssignedTo|nob...@fedoraproject.org|pbrobin...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632189] Review Request: erlang-misultin - Erlang library for building fast lightweight HTTP(S) servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632189 Peter Robinson changed: What|Removed |Added Status|NEW |ASSIGNED CC||pbrobin...@gmail.com AssignedTo|nob...@fedoraproject.org|pbrobin...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632190] Review Request: erlang-amf - Erlang Action Message Format Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632190 Peter Robinson changed: What|Removed |Added Status|NEW |ASSIGNED CC||pbrobin...@gmail.com AssignedTo|nob...@fedoraproject.org|pbrobin...@gmail.com Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 615028] Review Request: php-phpunit-PHP-Timer - PHP Utility class for timing
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=615028 Christof Damian changed: What|Removed |Added Flag||fedora-cvs? --- Comment #3 from Christof Damian 2010-09-26 09:47:27 EDT --- (In reply to comment #2) > > Perhaps you could fix the many awful date warning during build... ;) will do :-) that is one of the most annoying warnings of PHP, some sensible default would be nice. > > APPROVED Cheers New Package SCM Request === Package Name: php-phpunit-PHP-Timer Short Description: PHP Utility class for timing Owners: cdamian Branches: f14 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #5 from Arun SAG 2010-09-26 09:43:17 EDT --- Also, do not forget to run 'rpmlint' on your RPMS and try to remove common rpmlint warnings/errors https://fedoraproject.org/wiki/Common_Rpmlint_issues -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226332] Merge Review: pygobject2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226332 Parag AN(पराग) changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Summary|Merge Review: pygobject2|Merge Review: pygobject2 |(not started) | Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226336] Merge Review: pyorbit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226336 Parag AN(पराग) changed: What|Removed |Added CC||panem...@gmail.com AssignedTo|nob...@fedoraproject.org|panem...@gmail.com Summary|Merge Review: pyorbit (not |Merge Review: pyorbit |started)| Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636819
--- Comment #4 from Arun SAG 2010-09-26 09:28:05 EDT ---
(In reply to comment #3)
> I've updated the spec file and the src.rpm according to your review.
>
1. When you update a spec file, you need to increase (bump) the Release: by 1
and tell about your modifications in Changelog. This is how we track all the
modifications done to a spec file. You haven't done that.
2. Please update your SRPM as well, not just the spec file and provide the
links here.
your %install section is wrong,
>install -D gnome-exe-thumbnailer.sh
>$RPM_BUILD_ROOT%{_bindir}/gnome-exe-thumbnailer.sh
Why do you want above line?
> is it possible to use the %{name} maro in the files section of the spec?
yes you can use the macro anywhere in the spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 619593] Review Request: topgit - A different patch queue manager
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=619593
--- Comment #5 from Thomas Moschny 2010-09-26 09:18:23
EDT ---
(In reply to comment #4)
> [FAIL] MUST: The sources used to build the package must match the upstream
> source, as provided in the spec URL. Reviewers should use md5sum for this
> task.
> If no upstream URL can be specified for this package, please see the Source
> URL
> Guidelines for how to deal with this.
>
> % sha1sum 5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> ../SOURCES/5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> 1b38e02c8f55a9029c081562aaec3e787614689e
> 5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
> c0a1ea211a7eb4732987cc299c44095a7f41673d
> ../SOURCES/5aed7e7bad8c23080139b452adac75d2571b6dfa.tar.gz
>
> Tarball was fetched with `spectool -g`.
Yeah, the problem is gitweb, which seems to embed a datestamp or something like
this in the tarfile, causing it to have a different hash each time one
downloads it.
I changed the specfile to refer to the zipfile instead, which doesn't seem to
have that problem.
(Note that this problem would persist even when we don't packaged a git
snapshot, but a released version, as there currently is no real upstream
website other than gitweb.)
> [FAIL] MUST: A package must own all directories that it creates. If it does
> not
> create a directory that it uses, then it should require a package which does
> create that directory.
>
> /etc/bash_completion.d/ isn't owned. I'd recommend splitting off the bash
> completion into a separate file and Requires: topgit and Requires:
> bash-completion.
That's overkill imho. Following what other packages do, I simply own
/etc/bash_completion.d now.
> One weird thing I see is %doc at the end of %files.
Moved to the top of the %files section.
> I'd also recommend adding a
> trailing slash to the %{_libexecdir} and %{_datarootdir} lines to better
> indicate that they are directories.
Slashes added.
Spec URL: http://thm.fedorapeople.org/topgit/topgit.spec
SRPM URL:
http://thm.fedorapeople.org/topgit/topgit-0.8-2.git9404aa1a.fc13.src.rpm
%changelog
* Mon Sep 13 2010 Thomas Moschny <..> - 0.8-2.git9404aa1a
- Update to revision 9404aa1a.
- Specfile fixes as suggested in the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636819
--- Comment #3 from elad 2010-09-26 08:52:54 EDT ---
I've updated the spec file and the src.rpm according to your review.
is it possible to use the %{name} maro in the files section of the spec?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 543154] Review Request: mingw32-SDL_mixer - Simple DirectMedia Layer's Sample Mixer Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=543154 Erik van Pienbroek changed: What|Removed |Added Status|NEW |ASSIGNED CC||erik-fed...@vanpienbroek.nl Flag||fedora-review? --- Comment #7 from Erik van Pienbroek 2010-09-26 08:41:38 EDT --- I'll take this for review if you update the package to version 1.2.11 first (the native package is also at that version) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632189] Review Request: erlang-misultin - Erlang library for building fast lightweight HTTP(S) servers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632189 --- Comment #1 from Peter Lemenkov 2010-09-26 06:59:25 EDT --- New package: http://peter.fedorapeople.org/erlang-misultin.spec http://peter.fedorapeople.org/erlang-misultin-0.6.1-2.fc12.src.rpm %changelog - Narrow BuildRequires Koji scratchbuild for F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489901 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637521] Review Request: php-phpunit-DbUnit - DbUnit port for PHP/PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637521 Remi Collet changed: What|Removed |Added Depends on||637519 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet changed: What|Removed |Added Blocks||637521 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632190] Review Request: erlang-amf - Erlang Action Message Format Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632190 --- Comment #1 from Peter Lemenkov 2010-09-26 06:55:51 EDT --- New package: http://peter.fedorapeople.org/erlang-amf.spec http://peter.fedorapeople.org/erlang-amf-0-0.2.20100908git27329144.fc12.src.rpm %changelog - Narrowed BuildRequires. Koli scratchbuild for F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489895 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637521] New: Review Request: php-phpunit-DbUnit - DbUnit port for PHP/PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-phpunit-DbUnit - DbUnit port for PHP/PHPUnit https://bugzilla.redhat.com/show_bug.cgi?id=637521 Summary: Review Request: php-phpunit-DbUnit - DbUnit port for PHP/PHPUnit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@famillecollet.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://remi.fedorapeople.org/php-phpunit-DbUnit.spec SRPM URL: http://remi.fedorapeople.org/php-phpunit-DbUnit-1.0.0-1.fc14.src.rpm Description: DbUnit port for PHP/PHPUnit rpmlint php-phpunit-DbUnit.spec: I: checking-url http://pear.phpunit.de/get/DbUnit-1.0.0.tgz (timeout 10 seconds) php-phpunit-DbUnit.noarch: I: checking php-phpunit-DbUnit.noarch: I: checking-url http://pear.phpunit.de (timeout 10 seconds) php-phpunit-DbUnit.noarch: W: no-manual-page-for-binary dbunit php-phpunit-DbUnit.src: I: checking php-phpunit-DbUnit.src: I: checking-url http://pear.phpunit.de (timeout 10 seconds) php-phpunit-DbUnit.src: I: checking-url http://pear.phpunit.de/get/DbUnit-1.0.0.tgz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Koji : http://koji.fedoraproject.org/koji/taskinfo?taskID=2489892 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet changed: What|Removed |Added Blocks|637507, 637518 | Depends on||637507, 637518 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637518] Review Request: php-phpunit-PHPUnit-Selenium - Selenium RC integration for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637518 Remi Collet changed: What|Removed |Added Blocks||637519 Depends on|637519 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637507] Review Request: php-phpunit-Text-Template - Simple template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637507 Remi Collet changed: What|Removed |Added Blocks||637519 Depends on|637519 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] New: Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit https://bugzilla.redhat.com/show_bug.cgi?id=637519 Summary: Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@famillecollet.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://remi.fedorapeople.org/php-phpunit-PHPUnit-MockObject.spec SRPM URL: http://remi.fedorapeople.org/php-phpunit-PHPUnit-MockObject-1.0.0-1.fc14.src.rpm Description: Mock Object library for PHPUnit rpmlint php-phpunit-PHPUnit-MockObject.spec: I: checking-url http://pear.phpunit.de/get/PHPUnit_MockObject-1.0.0.tgz (timeout 10 seconds) php-phpunit-PHPUnit-MockObject.noarch: I: checking php-phpunit-PHPUnit-MockObject.noarch: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-PHPUnit-MockObject.noarch: W: no-documentation php-phpunit-PHPUnit-MockObject.src: I: checking php-phpunit-PHPUnit-MockObject.src: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-PHPUnit-MockObject.src: I: checking-url http://pear.phpunit.de/get/PHPUnit_MockObject-1.0.0.tgz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. Koji : http://koji.fedoraproject.org/koji/taskinfo?taskID=2489888 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637519] Review Request: php-phpunit-PHPUnit-MockObject - Mock Object library for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637519 Remi Collet changed: What|Removed |Added Blocks||637507, 637518 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637507] Review Request: php-phpunit-Text-Template - Simple template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637507 Remi Collet changed: What|Removed |Added Depends on||637519 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637518] Review Request: php-phpunit-PHPUnit-Selenium - Selenium RC integration for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637518 Remi Collet changed: What|Removed |Added Depends on||637519 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637518] New: Review Request: php-phpunit-PHPUnit-Selenium - Selenium RC integration for PHPUnit
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-phpunit-PHPUnit-Selenium - Selenium RC integration for PHPUnit https://bugzilla.redhat.com/show_bug.cgi?id=637518 Summary: Review Request: php-phpunit-PHPUnit-Selenium - Selenium RC integration for PHPUnit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@famillecollet.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://remi.fedorapeople.org/php-phpunit-PHPUnit-Selenium.spec SRPM URL: http://remi.fedorapeople.org/php-phpunit-PHPUnit-Selenium-1.0.0-1.fc14.src.rpm Description: Selenium RC integration for PHPUnit rpmlint php-phpunit-PHPUnit-Selenium.spec: I: checking-url http://pear.phpunit.de/get/PHPUnit_Selenium-1.0.0.tgz (timeout 10 seconds) php-phpunit-PHPUnit-Selenium.noarch: I: checking php-phpunit-PHPUnit-Selenium.noarch: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-PHPUnit-Selenium.noarch: W: no-documentation php-phpunit-PHPUnit-Selenium.src: I: checking php-phpunit-PHPUnit-Selenium.src: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-PHPUnit-Selenium.src: I: checking-url http://pear.phpunit.de/get/PHPUnit_Selenium-1.0.0.tgz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2489886 And you probably also need http://remi.fedorapeople.org/php-phpunit-PHPUnit-3.5.0-1.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=636819 --- Comment #2 from Arun SAG 2010-09-26 06:43:24 EDT --- Forgot! Instead of modifying the upstream sources. Do your deletion in %prep section. Avoid using macros for trivial commands like 'install' and 'rm' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=636819
Arun SAG changed:
What|Removed |Added
CC||saga...@gmail.com
--- Comment #1 from Arun SAG 2010-09-26 06:37:04 EDT ---
+ = OK
- = NA
? = issue
+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
? Spec has consistent macro usage.
+ Meets Packaging Guidelines.
+ License
? License field in spec matches
? License file included in package
+ Spec in American English
? Spec is legible.
- Sources match upstream md5sum:
- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
? Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
? Package has correct buildroot
%{_tmppath}/%{name}
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2489884
+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line. I also remove the rpmlib junk and
anything provided by glibc.)
X ISSUES XX
1. Spec has consistent macro usage.
All instances of gnome-exe-thumbnailer can be replaced by %{name} macro
2. License field in spec matches
The license is LGPLv2+
3. License file included in package
License file is not included in the package. Ask upstream to include license
files in next release.
4. Spec is legible.
Provide spaces/lines between %pre,%build,%install tags and %post %preun tags
5. Package has correct buildroot
Buildroot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
6. ? No rpmlint output.
-
[zer0c...@gnubox SPECS]$ rpmlint
~/rpmbuild/RPMS/noarch/gnome-exe-thumbnailer-0.6-0.fc13.noarch.rpm
#Fix the spelling
gnome-exe-thumbnailer.noarch: W: spelling-error Summary(en_US) thumnailes ->
thumbnails, thumbnail, thumbstalls
gnome-exe-thumbnailer.noarch: W: spelling-error %description -l en_US py -> pt,
p, y
#License is LGPLv2+
gnome-exe-thumbnailer.noarch: W: invalid-license LGPL
#Remove _executable_ permission from the all other files other than the
gnome-exe-thumbnailer.sh file
gnome-exe-thumbnailer.noarch: E: script-without-shebang
/etc/gconf/schemas/gnome-exe-thumbnailer.schemas
gnome-exe-thumbnailer.noarch: W: spurious-executable-perm
/usr/share/doc/gnome-exe-thumbnailer-0.6/README
Example:
--
install -pm 755 gnome-exe-thumbnailer.sh $RPM_BUILD_ROOT%{_bindir}/
install -pm 644 gnome-exe-thumbnailer.schemas
$RPM_BUILD_ROOT%{_sysconfdir}/gconf/schemas/
install -pm 644 README $RPM_BUILD_ROOT%{_datadir}/doc/%{name}-%{version}/
install -pm 644 gnome-exe-thumbnailer-template.png
$RPM_BUILD_ROOT%{_datadir}/pixmaps/
install -pm 644 gnome-exe-thumbnailer-generic-x.png
$RPM_BUILD_ROOT%{_datadir}/pixmaps/
install -pm 644 gnome-exe-thumbnailer-generic.png
$RPM_BUILD_ROOT%{_datadir}/pixmaps/
#can be ignored
gnome-exe-thumbnailer.noarch: W: no-manual-page-for-binary
gnome-exe-thumbnailer.sh
#This is Ok you can ignore the below warnings
gnome-exe-thumbnailer.noarch: W: dangerous-command-in-%pre rm
gnome-exe-thumbnailer.noarch: W: dangerous-command-in-%post rm
1 packages and 0 specfiles checked; 1 errors, 7 warnings.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637511] Review Request: php-phpunit-PHP-CodeCoverage - PHP code coverage information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637511 Remi Collet changed: What|Removed |Added Depends on||637517 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637511] Review Request: php-phpunit-PHP-CodeCoverage - PHP code coverage information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637511 Remi Collet changed: What|Removed |Added Depends on||637507 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637507] Review Request: php-phpunit-Text-Template - Simple template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637507 Remi Collet changed: What|Removed |Added Blocks||637511 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637511] New: Review Request: php-phpunit-PHP-CodeCoverage - PHP code coverage information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-phpunit-PHP-CodeCoverage - PHP code coverage information https://bugzilla.redhat.com/show_bug.cgi?id=637511 Summary: Review Request: php-phpunit-PHP-CodeCoverage - PHP code coverage information Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@famillecollet.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://remi.fedorapeople.org/php-phpunit-PHP-CodeCoverage.spec SRPM URL: http://remi.fedorapeople.org/php-phpunit-PHP-CodeCoverage-1.0.0-1.fc14.src.rpm Description: Library that provides collection, processing, and rendering functionality for PHP code coverage information. Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2489817 rpmlint php-phpunit-PHP-CodeCoverage.spec: I: checking-url http://github.com/sebastianbergmann/php-code-coverage/raw/master/README.markdown (timeout 10 seconds) php-phpunit-PHP-CodeCoverage.spec: I: checking-url http://pear.phpunit.de/get/PHP_CodeCoverage-1.0.0.tgz (timeout 10 seconds) php-phpunit-PHP-CodeCoverage.noarch: I: checking php-phpunit-PHP-CodeCoverage.noarch: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-PHP-CodeCoverage.noarch: W: no-manual-page-for-binary phpcov php-phpunit-PHP-CodeCoverage.src: I: checking php-phpunit-PHP-CodeCoverage.src: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-PHP-CodeCoverage.src: I: checking-url http://github.com/sebastianbergmann/php-code-coverage/raw/master/README.markdown (timeout 10 seconds) php-phpunit-PHP-CodeCoverage.src: I: checking-url http://pear.phpunit.de/get/PHP_CodeCoverage-1.0.0.tgz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 1 warnings. This package is needed by DbUnit (split of PHPUnit) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637507] Review Request: php-phpunit-Text-Template - Simple template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=637507 --- Comment #1 from Remi Collet 2010-09-26 05:25:16 EDT --- This packaged is needed by PHP_CodeCoverage which is needed by DbUnit which is needed by latest PHPUnit (3.5) ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630204] Review Request: ghc-mtlparse - Haskell mtlparse library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630204 Thomas Moschny changed: What|Removed |Added Status|NEW |ASSIGNED CC||thomas.mosc...@gmx.de --- Comment #3 from Thomas Moschny 2010-09-26 05:23:50 EDT --- Some remarks prior to a full review: * Seems https://fedoraproject.org/wiki/Packaging:Haskell is out of date. It does not mention %ghc_lib_build, %ghc_lib_install or %ghc_lib_package, and has broken links to cvs.fedoraproject.org and also broken links to git.fedorahosted.org. Nevertheless, the specfile is auto-generated, and thus mostly identical to spectemplate-ghc-lib.spec, so I'll assume it's ok. * The aforementioned wiki page says: "When packaging things out of Hackage or other sources, you may find that the summary or description is incomplete or lacks detail. Please try to include an appropriate summary and adequate description for Fedora of the library or program in the package so users will know what it does." This is clearly missing here. Not even all three lines of summary present in Hackage are included in the summary, but even those are a bit thin. * rpmlint says: ghc-mtlparse.x86_64: W: executable-stack /usr/lib64/ghc-6.12.1/mtlparse-0.0.1/libHSmtlparse-0.0.1-ghc6.12.1.so - Could that cause any problems, e.g. with selinux? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637507] New: Review Request: php-phpunit-Text-Template - Simple template engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: php-phpunit-Text-Template - Simple template engine https://bugzilla.redhat.com/show_bug.cgi?id=637507 Summary: Review Request: php-phpunit-Text-Template - Simple template engine Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: fed...@famillecollet.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://remi.fedorapeople.org/php-phpunit-Text-Template.spec SRPM URL: http://remi.fedorapeople.org/php-phpunit-Text-Template-1.0.0-1.remi.src.rpm Description: Simple template engine Koji scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=2489811 rpmlint php-phpunit-Text-Template.spec: I: checking-url http://github.com/sebastianbergmann/php-text-template/raw/master/README.markdown (timeout 10 seconds) php-phpunit-Text-Template.spec: I: checking-url http://pear.phpunit.de/get/Text_Template-1.0.0.tgz (timeout 10 seconds) php-phpunit-Text-Template.noarch: I: checking php-phpunit-Text-Template.noarch: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-Text-Template.src: I: checking php-phpunit-Text-Template.src: I: checking-url http://pear.phpunit.de/ (timeout 10 seconds) php-phpunit-Text-Template.src: I: checking-url http://github.com/sebastianbergmann/php-text-template/raw/master/README.markdown (timeout 10 seconds) php-phpunit-Text-Template.src: I: checking-url http://pear.phpunit.de/get/Text_Template-1.0.0.tgz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 632186] Review Request: erlang-log4erl - A logger for erlang in the spirit of Log4J
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=632186 --- Comment #1 from Peter Lemenkov 2010-09-26 05:15:22 EDT --- New package: http://peter.fedorapeople.org/erlang-log4erl.spec http://peter.fedorapeople.org/erlang-log4erl-0.9.0-2.fc12.src.rpm %changelog: - Narrow BuildRequires Koji scratchbuild for F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489808 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 629873] Review Request: gnome-video-effects - Collection of GStreamer video effects
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=629873 Yanko Kaneti changed: What|Removed |Added Status|NEW |ASSIGNED Flag||fedora-cvs? --- Comment #4 from Yanko Kaneti 2010-09-26 04:40:20 EDT --- New Package SCM Request === Package Name: gnome-video-effects Short Description: Collection of GStreamer video effects Owners: yaneti Branches: f13 f14 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 626458] Review Request: libmnetutil - A C++ library providing various network utilities
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=626458 Peter Lemenkov changed: What|Removed |Added Status Whiteboard|NotReady| --- Comment #1 from Peter Lemenkov 2010-09-26 04:30:31 EDT --- New build: http://peter.fedorapeople.org/libmnetutil.spec http://peter.fedorapeople.org/libmnetutil-0.8.0-0.2.20100629svn3775.fc12.src.rpm - Properly placed examples - Changed descriptions Finally cleaning up NotReady flag here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575940] Review Request: php-pluf - Pluf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575940 --- Comment #3 from Remi Collet 2010-09-26 03:56:56 EDT --- Could you tell (and probably add a comment in the spec) how do you find the version number ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 575940] Review Request: php-pluf - Pluf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=575940 Remi Collet changed: What|Removed |Added CC||fed...@famillecollet.com AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com Flag||fedora-review? --- Comment #2 from Remi Collet 2010-09-26 03:49:25 EDT --- Quick notes: Should not requires "php" but php-common (version 5.2.4 according to doc. and pci) According to doc, should requires php-pear(Mail) php-pear(Mail_Mime) As this package seems quite active, a refresh to more recent version seems usefull before review As upstream provides a PHPUnit test suite, I think it should be launch during RPM build. For now it crash (with 20100411 snapshot and with latest from website), this should be investigated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 637491] New: Review Request: perl-Params-Classify - Argument type classification
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: perl-Params-Classify - Argument type classification Alias: perl-Params-Classify https://bugzilla.redhat.com/show_bug.cgi?id=637491 Summary: Review Request: perl-Params-Classify - Argument type classification Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/Params-Classify/ OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: iarn...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://fedorapeople.org/~iarnell/review/perl-Params-Classify.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Params-Classify-0.011-1.fc13.src.rpm Description: This module provides various type-testing functions. These are intended for functions that, unlike most Perl code, care what type of data they are operating on. For example, some functions wish to behave differently depending on the type of their arguments (like overloaded functions in C++). Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489738 *rt-0.10_01 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
