[Bug 638422] Feature Request: xmlrpc3 update to 3.1.3 (for cloud package in bug #630179)

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638422

--- Comment #3 from Rudd-O DragonFear rud...@rudd-o.com 2010-09-29 02:04:37 
EDT ---
N/P duly noted will do so.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 225818] Merge Review: gnome-icon-theme

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225818

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mcla...@redhat.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 597755] Review Request: openmolar - Open Source Dental Practice Management Software

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597755

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NOTABUG
   Flag|needinfo?(imran...@gmail.co |
   |m)  |
Last Closed||2010-09-29 03:16:04

--- Comment #12 from Parag AN(पराग) panem...@gmail.com 2010-09-29 03:16:04 
EDT ---
Closing this as no response from submitter.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 225818] Merge Review: gnome-icon-theme

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225818

--- Comment #6 from Parag AN(पराग) panem...@gmail.com 2010-09-29 03:14:06 EDT 
---
Created attachment 450383
  -- https://bugzilla.redhat.com/attachment.cgi?id=450383
spec cleanup

This will fix this package and clean it as per guidelines.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 552855] Merge Review: anthy - Japanese character set input library

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552855

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
   Flag|fedora-review?  |fedora-review+
Last Closed||2010-09-29 03:17:38

--- Comment #5 from Parag AN(पराग) panem...@gmail.com 2010-09-29 03:17:38 EDT 
---
Thanks. APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 630179] Review Request: cloud - Cloud.com CloudStack

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630179

Bug 630179 depends on bug 638439, which changed state.

Bug 638439 Summary: Version update for this package
https://bugzilla.redhat.com/show_bug.cgi?id=638439

   What|Old Value   |New Value

 Resolution||RAWHIDE
 Status|NEW |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 630272] Review Request: ghc-tagsoup - Parsing HTML/XML documents library

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630272

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 630222] Review Request: ghc-colour - A model for human colour/color perception

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630222

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 630208] Review Request: ghc-csv - CSV loader and dumper

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630208

Jens Petersen peter...@redhat.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|d...@adsllc.com
   Flag||needinfo?(maths...@gmail.co
   ||m)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638418] Review Request: ehcache (for cloud package in bug #630179)

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638418

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 CC||akurt...@redhat.com

--- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-09-29 
04:20:31 EDT ---
I can review this one and sponsor you but I have few comments:
1. If we don't have a clear way where are the sources coming from or how to
generate the tarball it's a nogo.
2. Choose only one of the build systems either ant or maven.
3. Always provide a unversioned javadoc and remove these post/postun sections
for javadoc.
4. Drop gcj-support - we don't need it nowadays.
5. Ehcache has seen big restructuring -
http://svn.terracotta.org/svn/ehcache/tags/ and
http://ehcache.org/roadmap.html# and
http://oss.sonatype.org/content/repositories/sourceforge-releases/net/sf/ehcache/ehcache/
6. Update to latest version - 2.2.0
7. Fix file attributes to the defaults for fedora.

And this is only from the first sight :).
Also if you drop gcj you won't need gnu-crypto.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624471] Review Request: perl-Lingua-EN-Tagger - Part-of-speech tagger for English natural language processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624471

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
 AssignedTo|nob...@fedoraproject.org|ppi...@redhat.com
   Flag||fedora-review?

Bug 624471 depends on bug 624464, which changed state.

Bug 624464 Summary: Review Request: perl-Memoize-ExpireLRU - Expiry plug-in for 
Memoize that adds LRU cache expiration
https://bugzilla.redhat.com/show_bug.cgi?id=624464

   What|Old Value   |New Value

 Resolution||ERRATA
 Status|ON_QA   |CLOSED

Bug 624471 depends on bug 624465, which changed state.

Bug 624465 Summary: Review Request: perl-Lingua-Stem - Stemming of words
https://bugzilla.redhat.com/show_bug.cgi?id=624465

   What|Old Value   |New Value

 Status|ASSIGNED|MODIFIED
 Status|MODIFIED|ON_QA
 Resolution||ERRATA
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636209] Review Request: atinject - Dependency injection specification for Java (JSR-330)

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636209

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #9 from Stanislav Ochotnicky socho...@redhat.com 2010-09-29 
04:37:25 EDT ---
Package Change Request
==
Package Name: atinject
Short Description: Dependency injection specification for Java (JSR-330)
Owners: sochotni
Branches: f14 devel
InitialCC:


Change requested due to fedpkg bug 619979

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636209] Review Request: atinject - Dependency injection specification for Java (JSR-330)

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636209

--- Comment #10 from Stanislav Ochotnicky socho...@redhat.com 2010-09-29 
04:49:30 EDT ---
Ah, sorry...I got out of bed the wrong way I guess (disregard changes in
description and initial CC)

Package Change Request
==
Package Name: atinject
Owners: sochotni
Branches: f14 devel


Change requested due to fedpkg bug 619979

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637134] Review Request: bird - BIRD Internet Routing Daemon

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637134

Jan Vcelak jvce...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jvce...@redhat.com
 AssignedTo|nob...@fedoraproject.org|jvce...@redhat.com

--- Comment #1 from Jan Vcelak jvce...@redhat.com 2010-09-29 05:06:08 EDT ---
I will take this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624471] Review Request: perl-Lingua-EN-Tagger - Part-of-speech tagger for English natural language processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624471

--- Comment #1 from Petr Pisar ppi...@redhat.com 2010-09-29 05:27:08 EDT ---
Source file is original.
FIX: License is GPLv3, not a perl-like (verified from Tagger.pm).
Summary and Description tags Ok (verified from Tagger.pm).
TODO: Consider INSTALLDIRS=perl and %{perl_privlib}/* as this is the place we
want to move all perl packages in F15 (just formal issue as real path is
identic).
FIX: Add perl(File::Spec) = 0.84 (Build)Requires as the module can be
dual-lived (http://search.cpan.org/search?query=File%3A%3ASpecmode=all) in the
future.
FIX: Replace perl(HTML::Parser) Requires with versioned perl(HTML::TokeParser)
as HTML::TokeParser is used in code. File a bug to upstream to replace
perl(HTML::Parser) dependency with perl(HTML::TokeParser) in Makefile.PL.
FIX: (Build)Require perl(Momoize) = 1.01 (used by Tagger.pm, version specified
in META.yml)
FIX: (Build)Require perl(Storable) = 2.10 (used by Tagger.pm, version
specified in META.yml) as the module can be dual-lived
(http://search.cpan.org/search?query=Storablemode=all) in the future.
All tests pass.

$ rpmlint perl-Lingua-EN-Tagger.spec
../SRPMS/perl-Lingua-EN-Tagger-0.16-1.fc13.src.rpm
../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm 
perl-Lingua-EN-Tagger.spec: W: no-cleaning-of-buildroot %clean
perl-Lingua-EN-Tagger.spec: W: no-buildroot-tag
perl-Lingua-EN-Tagger.spec: W: no-%clean-section
perl-Lingua-EN-Tagger.src: W: spelling-error %description -l en_US lookup -
lockup, hookup, look up
perl-Lingua-EN-Tagger.src: W: no-cleaning-of-buildroot %clean
perl-Lingua-EN-Tagger.src: W: no-buildroot-tag
perl-Lingua-EN-Tagger.src: W: no-%clean-section
perl-Lingua-EN-Tagger.noarch: W: spelling-error %description -l en_US lookup -
lockup, hookup, look up
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

This is post-F12 spec file (no BuildRoot needed). rpmlint output Ok.
TODO: Correct description spelling (use `look-up' as compound adjective).

$ rpm -pqlv ../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm 
drwxr-xr-x2 rootroot0 zář 29 11:07
/usr/share/doc/perl-Lingua-EN-Tagger-0.16
-rw-r--r--1 rootroot 1605 kvě 11 19:39
/usr/share/doc/perl-Lingua-EN-Tagger-0.16/Changes
-rw-r--r--1 rootroot 3633 pro  9  2003
/usr/share/doc/perl-Lingua-EN-Tagger-0.16/README
-rw-r--r--1 rootroot 3556 zář 29 11:07
/usr/share/man/man3/Lingua::EN::Tagger.3pm.gz
drwxr-xr-x2 rootroot0 zář 29 11:07
/usr/share/perl5/Lingua
drwxr-xr-x2 rootroot0 zář 29 11:07
/usr/share/perl5/Lingua/EN
drwxr-xr-x2 rootroot0 zář 29 11:07
/usr/share/perl5/Lingua/EN/Tagger
-rw-r--r--1 rootroot31528 kvě 11 19:39
/usr/share/perl5/Lingua/EN/Tagger.pm
-rw-r--r--1 rootroot26267 zář 29 11:07
/usr/share/perl5/Lingua/EN/Tagger/pos_tags.hash
-rw-r--r--1 rootroot  1351373 zář 29 11:07
/usr/share/perl5/Lingua/EN/Tagger/pos_words.hash
-rw-r--r--1 rootroot23243 lis 13  2003
/usr/share/perl5/Lingua/EN/Tagger/tags.yml
-rw-r--r--1 rootroot  441 lis 13  2003
/usr/share/perl5/Lingua/EN/Tagger/unknown.yml
-rw-r--r--1 rootroot   977164 lis 14  2003
/usr/share/perl5/Lingua/EN/Tagger/words.yml

File permissions and location Ok.

$ rpm -pq --requires
../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm | sort | uniq -c  
  1 perl(Carp)  
  1 perl(FileHandle)  
  1 perl(File::Spec)  
  1 perl(HTML::Parser) = 3.45
  1 perl(HTML::TokeParser)  
  1 perl(Lingua::Stem::En)  
  1 perl(Lingua::Stem) = 0.81
  1 perl(Memoize)  
  1 perl(Memoize::ExpireLRU) = 0.55
  1 perl(:MODULE_COMPAT_5.10.1)  
  1 perl(Storable)  
  1 perl(strict)  
  1 perl(warnings)  
  1 rpmlib(CompressedFileNames) = 3.0.4-1
  1 rpmlib(FileDigests) = 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) = 4.0-1
  1 rpmlib(PayloadIsXz) = 5.2-1
  2 rpmlib(VersionedDependencies) = 3.0.3-1

Binary dependencies Ok.

$ rpm -pq --provides
../RPMS/noarch/perl-Lingua-EN-Tagger-0.16-1.fc13.noarch.rpm | sort | uniq -c  
  1 perl(Lingua::EN::Tagger) = 0.16
  1 perl-Lingua-EN-Tagger = 0.16-1.fc13

Binary provides Ok.

Builds on F15 (http://koji.fedoraproject.org/koji/taskinfo?taskID=2496256).

Spec file in line with packaging guidelines.

Please fix all `FIX:' prefixed comments and publish new spec file.
Consider `TODO:' prefixed comments.

Result: NOT APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

[Bug 587198] Review Request: jgraphx - Java Graph Drawing Component

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587198

--- Comment #15 from Lubomir Rintel lkund...@v3.sk 2010-09-29 06:02:07 EDT ---
SPEC: http://v3.sk/~lkundrak/SPECS/jgraphx.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/jgraphx-1.4.1.0-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 631898] Review Request: fatrat - Feature-rich download manager

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631898

--- Comment #8 from Fedora Update System upda...@fedoraproject.org 2010-09-29 
06:51:02 EDT ---
fatrat-1.1.3-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/fatrat-1.1.3-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 631898] Review Request: fatrat - Feature-rich download manager

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=631898

--- Comment #9 from Fedora Update System upda...@fedoraproject.org 2010-09-29 
06:52:13 EDT ---
fatrat-1.1.3-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/fatrat-1.1.3-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 633215] Review Request: SimplyHTML - Application and a java component for rich text processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633215

--- Comment #4 from hannes johannes.l...@googlemail.com 2010-09-29 07:59:28 
EDT ---
I fixed it and it builds in koji.

SRPM URL:
http://hannes.fedorapeople.org/SimplyHTML/SimplyHTML-0.13.1-2.fc14.src.rpm
SPEC URL: http://hannes.fedorapeople.org/SimplyHTML/SimplyHTML.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638582] New: Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: jpanoramamaker -

https://bugzilla.redhat.com/show_bug.cgi?id=638582

   Summary: Review Request: jpanoramamaker -
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: jva...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://jpanoramamaker.wz.cz/fedora/jpanoramamaker.spec
SRPM URL: http://jpanoramamaker.wz.cz/fedora/jpanoramamaker-5.1.src.tar.gz
(or https://koji.fedoraproject.org/koji/taskinfo?taskID=2496498)

Description: Tool for stitching photos to panorama in linear curved space

This is my first package and I'm looking for sponsor.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638582] Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638582

Alexander Kurtakov akurt...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||akurt...@redhat.com
 AssignedTo|nob...@fedoraproject.org|akurt...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Alexander Kurtakov akurt...@redhat.com 2010-09-29 
08:38:41 EDT ---
I'll take this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] New: Review Request: freemind - a mind-mapping software written in Java

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: freemind - a mind-mapping software written in Java

https://bugzilla.redhat.com/show_bug.cgi?id=638590

   Summary: Review Request: freemind - a mind-mapping software
written in Java
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: johannes.l...@googlemail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://hannes.fedorapeople.org/freemind/freemind.spec
SRPM URL:
http://hannes.fedorapeople.org/freemind/freemind-0.9.0.rc9-2.fc14.src.rpm
Description: FreeMind is a premier free mind-mapping software written in Java.
The 
recent development has hopefully turned it into high productivity tool. 
So you want to write a completely new metaphysics? Why don't you use 
FreeMind? You have a tool at hand that remarkably resembles the tray 
slips of Robert Pirsig, described in his sequel to Zen and the Art of 
Motorcycle Maintenance called Lila. Do you want to refactor your essays 
in a similar way you would refactor software? Or do you want to keep 
personal knowledge base, which is easy to manage? Why don't you try 
FreeMind? Do you want to prioritize, know where you are, where you've 
been and where you are heading, as Stephen Covey would advise you? Have 
you tried FreeMind to keep track of all the things that are needed for 
that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Depends on|633215  |636250

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636250] Review Request: HotEqn - Java Library to display LateX Code - Dependency for Freemind

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636250

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Blocks||638590

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 633215] Review Request: SimplyHTML - Application and a java component for rich text processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633215

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Blocks|638590  |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Depends on||633215

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 633215] Review Request: SimplyHTML - Application and a java component for rich text processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633215

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Blocks||638590

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 633215] Review Request: SimplyHTML - Application and a java component for rich text processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=633215

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Blocks||638590

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

hannes johannes.l...@googlemail.com changed:

   What|Removed |Added

 Depends on||501467(and,executable,smpla
   ||yer,stack), 633215

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638582] Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638582

--- Comment #2 from Alexander Kurtakov akurt...@redhat.com 2010-09-29 
08:58:24 EDT ---
Can you provide the src.rpm file?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627197] Review Request: bluedevil - Bluetooth stack for KDE

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627197

Jaroslav Reznik jrez...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #2 from Jaroslav Reznik jrez...@redhat.com 2010-09-29 08:58:32 
EDT ---
Thanks Radek,
bugs are reported upstream - it's still pre-release, it's not going to be
default BT stack now for released Fedoras but we need a lot of testing before
making it default in F15 (and stable release 1.0). So asking for GIT now before
fully sorted out.

New Package SCM Request
===
Package Name: bluedevil 
Short Description: Bluetooth stack for KDE
Owners: jreznik rdieter than kkofler ltinkl
Branches: f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226561] Merge Review: xjavadoc

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226561

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2010-09-29 08:58:07

--- Comment #4 from Stanislav Ochotnicky socho...@redhat.com 2010-09-29 
08:58:07 EDT ---
Nice, I consider this package clean and review finished. Closing

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488968] Review Request: fedora-app-install - Fedora application data

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488968

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com
 Blocks||182235(FE-Legal)

--- Comment #45 from Tom spot Callaway tcall...@redhat.com 2010-09-29 
09:00:26 EDT ---
The absurdity of the license string and the nature of this package having an
aggressively changing license with every new release makes it functionally
impossible to audit.

While an argument could be made that the .desktop files are not copyrightable,
the icons clearly are.

I'm blocking this against FE-Legal. I would strongly encourage you to work to
find a way to not need to bundle all of these icons within a single package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638582] Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638582

--- Comment #3 from jiri vanek jva...@redhat.com 2010-09-29 09:02:37 EDT ---
https://koji.fedoraproject.org/koji/getfile?taskID=2496498name=jpanoramamaker-5-1.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #12 from elad el...@doom.co.il 2010-09-29 09:13:27 EDT ---
(In reply to comment #11)
 Align your spec files. Adjust the tab position like in
Done.
 
 Suggest you to do unofficial reviews of other packages and post the link here.
I will.

In other news, upstream released a new version today. They include the license
now.
New src.rpm:
http://elad.fedorapeople.org/gnome-exe-thumbnailer-0.7-0.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638582] Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638582

--- Comment #4 from Alexander Kurtakov akurt...@redhat.com 2010-09-29 
09:25:55 EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[ ]  Rpmlint output:
jpanoramamaker.noarch: W: no-manual-page-for-binary jpanoramamaker
jpanoramamaker-javadoc.noarch: W: spelling-error Summary(en_US) Javadocs -
Java docs, Java-docs, Javanese
Not a problem.

[X]  Package is named according to the Package Naming Guidelines.
[X]  Spec file name must match the base package name, in the format
%{name}.spec.
[X]  Package meets the Packaging Guidelines.
[X]  Package successfully compiles and builds into binary rpms.
[X]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[X]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[X]  License field in the package spec file matches the actual license.
License type:
[X]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[X]  All independent sub-packages have license of their own
[X]  Spec file is legible and written in American English.
[X]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
[X]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[X]  Package must own all directories that it creates.
[X]  Package requires other packages for directories it uses.
[X]  Package does not contain duplicates in %files.
[X]  Permissions on files are set properly.
[X]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[X]  Package consistently uses macros.
[X]  Package contains code, or permissable content.
[X]  Fully versioned dependency in subpackages, if present.
[!]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[X]  Package does not own files or directories owned by other packages.
[X]  Javadoc documentation files are generated and included in -javadoc
subpackage
[X]  Packages have proper BuildRequires/Requires on jpackage-utils
[X]  Javadoc subpackages have Require: jpackage-utils
[X]  Package uses %global not %define
[X]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[X]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[X]  All filenames in rpm packages must be valid UTF-8.

=== Other suggestions ===
[X]  If possible use upstream build method (maven/ant/javac)
[X]  Javadocs are placed in %{_javadocdir}/%{name} with
%{_javadocdir}/%{name}-%{version} symlink
[X]  If package contains pom.xml files install it (including depmaps) even when
building with ant 
[X]  Avoid having BuildRequires on exact NVR unless necessary
[X]  Package has BuildArch: noarch (if possible)
[X]  Latest version is packaged.
[X]  Reviewer should test that the package builds in mock.


=== Issues ===
1. Missing desktop file for a GUI application.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 225719] Merge Review: efax

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225719

--- Comment #2 from Ngo Than t...@redhat.com 2010-09-29 09:36:28 EDT ---
(In reply to comment #1)
 - rpmlint: NOT OK!!!
 efax.src: W: summary-ended-with-dot A program for faxing using a Class 1, 2 or
 2.0 fax modem.
 efax.x86_64: W: log-files-without-logrotate /var/log/fax
 
fixed in efax-0.9a-8.001114.fc15

 - package version: release should start with 0., alpha tag should go to 
 release
 instead version
i don't want to add Epoch, please ignore

 according to Package Guidelines but as this package can be considered as
 successor to 0.9 (not
 pre 0.9) this is OK
 - requires: make and probably netpbm-progs (?) should be BuildRequires, not
 Requires, NOT OK!!!

make is required for Build - BuildRequires: make
netpbm-progs is required to convert to fax format - Requires: netpbm-progs


 - build flags: missing smp_mflags, custom build flags?, NOT OK!!!
fixed in efax-0.9a-8.001114.fc15
 
 Than, please fix/comment issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632051] Review Request: libmeegotouch - MeeGo Touch Framework

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632051

--- Comment #1 from Jaroslav Reznik jrez...@redhat.com 2010-09-29 09:39:14 
EDT ---
Name: ok
Summary: ok
Version  Release: ok
Group: ok
License: ok
URL: ok
Sources: caedf70a5851e2d1e1e9c282f40c841a ok
Patches: do we really need all patches? at least missing-Epoch-function is not
needed anymore as we have Qt 4.7, please update
Requires  BuildRequires: XXX
Description: ok
Build: not ok

+ ./configure -prefix /usr -libdir /usr/lib64 -release

QTDIR variable was set but could not find /usr/lib64/qt-3.3/bin/qmake\n
If your Qt is in a nonstandard location, try:
QTDIR=path to your Qt directory ./configure
error: Bad exit status from /var/tmp/rpm-tmp.bm6HwK (%build)


PS; could you add me as co-maintainer to MeeGo packages once reviewed? I'm Qt
co-maintainer and Fedora Mobility guy from Qt/Plasma Netbook side of evil.
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

elad el...@doom.co.il changed:

   What|Removed |Added

 CC||el...@doom.co.il

--- Comment #4 from elad el...@doom.co.il 2010-09-29 09:51:59 EDT ---
i will do an unofficial review.

+ = OK
- = NA
? = issue

+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistent macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.

+ Sources match upstream md5sum

- Package needs ExcludeArch
+ BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
+ Package is code or permissible content.
+ Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
Couldn't check on koji becuase i was unable to login because of an SSL error.
it compiles on my machine.

+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.

Seems that everything is OK with your package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636819] Review Request: gnome-exe-thumbnailer - gnome thumbnailer for exe files

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636819

--- Comment #13 from elad el...@doom.co.il 2010-09-29 09:57:49 EDT ---
i've done my first unofficial review:
https://bugzilla.redhat.com/show_bug.cgi?id=635788#c4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 457808] Review Request: gwibber - An open source microblogging client for GNOME developed with Python and GTK

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457808

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

 CC||tcall...@redhat.com
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #16 from Tom spot Callaway tcall...@redhat.com 2010-09-29 
10:04:11 EDT ---
Package Change Request
==
Package Name: gwibber
New Branches: el5 el6
Owners: spot

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635981] Review Request: mojo-signatures - Mojo API signatures project

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635981

Chris Spike chris.sp...@arcor.de changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||chris.sp...@arcor.de
   Flag||fedora-review?

--- Comment #1 from Chris Spike chris.sp...@arcor.de 2010-09-29 10:09:34 EDT 
---
I'll do this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624833] Review Request: dhcp_probe - Tool for discover DHCP and BootP servers

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624833

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624833] Review Request: dhcp_probe - Tool for discover DHCP and BootP servers

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624833

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-09-29 10:19:27 EDT ---
dhcp_probe-1.3.0-6.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635981] Review Request: mojo-signatures - Mojo API signatures project

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635981

Chris Spike chris.sp...@arcor.de changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Chris Spike chris.sp...@arcor.de 2010-09-29 10:35:53 EDT 
---
=== REQUIRED ITEMS ===
[x]  Rpmlint output:
mojo-signatures.src: W: invalid-url Source0: mojo-signatures-1.1.tar.xz
SPECS/mojo-signatures.spec: W: invalid-url Source0: mojo-signatures-1.1.tar.xz
- Both Ok, no upstream source releases

mojo-signatures.noarch: W: no-documentation
- Ok, src contains no license for doc

mojo-signatures.noarch: W: non-conffile-in-etc
/etc/maven/fragments/mojo-signatures
- false positive

2 packages and 1 specfiles checked; 0 errors, 4 warnings.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type:
[ ]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[ ]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[ ]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x]  Package consistently uses macros.
[x]  Package contains code, or permissable content.
[ ]  Fully versioned dependency in subpackages, if present.
[ ]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[ ]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[ ]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[x]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[ ]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of
%{_datadir}/maven2/poms
[ ]  If package uses -Dmaven.test.skip=true explain why it was needed in a
comment
[ ]  If package uses custom depmap -Dmaven2.jpp.depmap.file=* explain why
it's needed in a comment
[x]  Package uses %update_maven_depmap in %post/%postun
[x]  Packages have Requires(post) and Requires(postun) on jpackage-utils (for
%update_maven_depmap macro)

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[ ]  Javadocs are placed in %{_javadocdir}/%{name} with
%{_javadocdir}/%{name}-%{version} symlink
[x]  If package contains pom.xml files install it (including depmaps) even when
building with ant 
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.



*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638362] Review Request: mod_python26 - An embedded Python interpreter for the Apache HTTP Server

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638362

--- Comment #5 from Steve Traylen steve.tray...@cern.ch 2010-09-29 10:49:00 
EDT ---
Was looking at 
http://httpd.apache.org/docs/2.2/mod/core.html#ifmodule


If the python26.conf contians

IfModule !python_module
LoadModule python_module modules/mod_python26.so

... 

/IfModule


So long at /etc/httpd/conf.d/python.conf is processed before python26.conf
which is presumably is then the second will always be ignored
if the first one exists?

The point about if it's ever correct to load both versions is good
one. It's certainly confusing.

I think there was a thread about this approach somewhere on some list.
Will try and find it.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632858] Review Request: emacs-slime - The superior lisp interaction mode for emacs

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632858

Arun SAG saga...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 632858] Review Request: emacs-slime - The superior lisp interaction mode for emacs

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=632858

Arun SAG saga...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

Arun SAG saga...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||saga...@gmail.com

--- Comment #5 from Arun SAG saga...@gmail.com 2010-09-29 10:59:53 EDT ---
I will do the review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635981] Review Request: mojo-signatures - Mojo API signatures project

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635981

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #3 from Stanislav Ochotnicky socho...@redhat.com 2010-09-29 
11:08:50 EDT ---
Thank you for the review once again.

New Package CVS Request
===
Package Name: mojo-signatures
Short Description: Mojo API signatures project
Owners: sochotni
Branches: f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638647] New: Review Request: mom - Dynamically manage system resources on virtualization hosts

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: mom -  Dynamically manage system resources on 
virtualization hosts

https://bugzilla.redhat.com/show_bug.cgi?id=638647

   Summary: Review Request: mom -  Dynamically manage system
resources on virtualization hosts
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: a...@us.ibm.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://github.com/downloads/aglitke/mom/mom.spec
SRPM URL: http://github.com/downloads/aglitke/mom/mom-0.2.1-1.fc13.src.rpm

Description: MOM is a policy-driven tool that can be used to manage
overcommitment on KVM hosts. Using libvirt, MOM keeps track of active virtual
machines on a host. At a regular collection interval, data is gathered about
the host and guests. Data can come from multiple sources (eg. the /proc
interface, libvirt API calls, a client program connected to a guest, etc). Once
collected, the data is organized for use by the policy evaluation engine. When
started, MOM accepts a user-supplied overcommitment policy. This policy is
regularly evaluated using the latest collected data. In response to certain
conditions, the policy may trigger reconfiguration of the system’s
overcommitment mechanisms. Currently MOM supports control of memory ballooning
and KSM but the architecture is designed to accommodate new mechanisms such as
cgroups.

For more information see the slides and video from KVM Forum 2010 here:
Slides:
http://www.linux-kvm.org/wiki/images/e/e8/2010-forum-litke-kvmforum2010.pdf
Video: http://vimeo.com/15223652

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 637402] Review Request: sqlninja - A tool for SQL server injection and takeover

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637402

Dave Malcolm dmalc...@redhat.com changed:

   What|Removed |Added

 CC||dmalc...@redhat.com
 Blocks||182235(FE-Legal)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624833] Review Request: dhcp_probe - Tool for discover DHCP and BootP servers

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624833

--- Comment #17 from Fedora Update System upda...@fedoraproject.org 
2010-09-29 11:42:51 EDT ---
dhcp_probe-1.3.0-6.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638666] New: Review Request: whois - Improved WHOIS client

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: whois - Improved WHOIS client

https://bugzilla.redhat.com/show_bug.cgi?id=638666

   Summary: Review Request: whois - Improved WHOIS client
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: ppi...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://ppisar.fedorapeople.org/whois/whois.spec
SRPM URL: http://ppisar.fedorapeople.org/whois/whois-5.0.7-1.fc13.src.rpm
Description:
Searches for an object in a RFC 3912 database.

This version of the WHOIS client tries to guess the right server to ask for
the specified object. If no guess can be made it will connect to
whois.networksolutions.com for NIC handles or whois.arin.net for IPv4
addresses and network names.


Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2496900

$ rpmlint whois.spec ../SRPMS/whois-5.0.7-1.fc13.src.rpm
../RPMS/x86_64/whois-5.0.7-1.fc13.x86_64.rpm 
whois.spec: W: no-cleaning-of-buildroot %install
whois.spec: W: no-cleaning-of-buildroot %clean
whois.spec: W: no-buildroot-tag
whois.spec: W: no-%clean-section
whois.src: W: name-repeated-in-summary C WHOIS
whois.src: W: spelling-error %description -l en_US networksolutions - network
solutions, network-solutions, counterrevolutions
whois.src: W: spelling-error %description -l en_US arin - rain, ain, Darin
whois.src: W: no-cleaning-of-buildroot %install
whois.src: W: no-cleaning-of-buildroot %clean
whois.src: W: no-buildroot-tag
whois.src: W: no-%clean-section
whois.x86_64: W: name-repeated-in-summary C WHOIS
whois.x86_64: W: spelling-error %description -l en_US networksolutions -
network solutions, network-solutions, counterrevolutions
whois.x86_64: W: spelling-error %description -l en_US arin - rain, ain, Darin
2 packages and 1 specfiles checked; 0 errors, 14 warnings.

This is post-F12 spec file, thus no BuilRoot defined.
The `WHOIS' word is official name of Internet service coinciding with package
name.
`networksolutions' and  `arin' are literal domain names.

$ rpm -pqlv ../RPMS/x86_64/whois-5.0.7-1.fc13.x86_64.rpm
-rw-r--r--1 rootroot  343 čec 17  2008
/etc/whois.conf
-rwxr-xr-x1 rootroot0 zář 29 17:18
/usr/bin/whois
-rwxr-xr-x1 rootroot55016 zář 29 17:18
/usr/bin/whois.md
drwxr-xr-x2 rootroot0 zář 29 17:18
/usr/share/doc/whois-5.0.7
-rw-r--r--1 rootroot17992 bře 14  2003
/usr/share/doc/whois-5.0.7/COPYING
-rw-r--r--1 rootroot 1016 led 28  2010
/usr/share/doc/whois-5.0.7/README
-rw-r--r--1 rootroot36433 srp  9 00:58
/usr/share/doc/whois-5.0.7/changelog
-rw-r--r--1 rootroot  206 bře 23  2008
/usr/share/doc/whois-5.0.7/copyright
-rw-r--r--1 rootroot 9003 zář 29 17:18
/usr/share/locale/cs/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 8730 zář 29 17:18
/usr/share/locale/de/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 8368 zář 29 17:18
/usr/share/locale/el/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 9327 zář 29 17:18
/usr/share/locale/es/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 2297 zář 29 17:18
/usr/share/locale/eu/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 8234 zář 29 17:18
/usr/share/locale/fi/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 9355 zář 29 17:18
/usr/share/locale/fr/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 8349 zář 29 17:18
/usr/share/locale/it/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 6390 zář 29 17:18
/usr/share/locale/ja/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot  745 zář 29 17:18
/usr/share/locale/no/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 8620 zář 29 17:18
/usr/share/locale/pl/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 6516 zář 29 17:18
/usr/share/locale/pt_BR/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot1 zář 29 17:18
/usr/share/locale/ru/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot 6454 zář 29 17:18
/usr/share/locale/zh_CN/LC_MESSAGES/whois.mo
-rw-r--r--1 rootroot   20 zář 29 17:18
/usr/share/man/man1/whois.1.gz
-rw-r--r--1 rootroot 2045 zář 29 17:18

[Bug 638582] Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638582

--- Comment #5 from jiri vanek jva...@redhat.com 2010-09-29 11:47:15 EDT ---
updated SRPM
http://koji.fedoraproject.org/koji/getfile?taskID=2496851name=jpanoramamaker-5-1.fc15.src.rpm
 
in http://koji.fedoraproject.org/koji/taskinfo?taskID=2496850

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638582] Review Request: jpanoramamaker -

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638582

--- Comment #6 from Alexander Kurtakov akurt...@redhat.com 2010-09-29 
12:07:29 EDT ---
There are 2 problems:
1. You haven't added a changelog entry describing your change and haven't bump
Release. You have to do that on every change.
2. desktop file and icon are installed as exectables which is wrong. Please use
the default permissions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

Arun SAG saga...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|saga...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 634543] Review Request:animal-sniffer - Tools to assist verifying backward compatibility of Java classes

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634543

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Stanislav Ochotnicky socho...@redhat.com 2010-09-29 
12:38:47 EDT ---
Thank you for the review

New Package CVS Request
===
Package Name: animal-sniffer
Short Description: Tools to assist verifying backward compatibility of Java
classes
Owners: sochotni
Branches: f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638666] Review Request: whois - Improved WHOIS client

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638666

--- Comment #1 from Bill Nottingham nott...@redhat.com 2010-09-29 12:50:43 
EDT ---
... is there really a reason to have multiple alternatives here? Just pick one
and ship one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

Arun SAG saga...@gmail.com changed:

   What|Removed |Added

   Flag||fedora-review+

--- Comment #6 from Arun SAG saga...@gmail.com 2010-09-29 13:41:38 EDT ---
complete review:

+ = OK
- = NA
? = issue


+ Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistant macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.

+ Sources match upstream md5sum:
[zer0c...@gnubox SPECS]$ md5sum  nautilus-terminal_0.7_src.tar.gz 
68cecfb4cfb818a1dd0ffed759e7122d  nautilus-terminal_0.7_src.tar.gz
[zer0c...@gnubox SPECS]$ md5sum
~/rpmbuild/SOURCES/nautilus-terminal_0.7_src.tar.gz 
68cecfb4cfb818a1dd0ffed759e7122d 
/home/zer0c00l/rpmbuild/SOURCES/nautilus-terminal_0.7_src.tar.gz


- Package needs ExcludeArch
+ BuildRequires correct
+ Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
+ Package has a correct %clean section.
+ Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
+ Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

+ Package compiles and builds on at least one arch.
http://koji.fedoraproject.org/koji/taskinfo?taskID=2497104

+ Package has no duplicate files in %files.
+ Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
? No rpmlint output.

- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

+ Should build in mock.
+ Should build on all supported archs
+ Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
+ Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

rpmlint output:
-
[zer0c...@gnubox nautilus-terminal-0.7]$ rpmlint
~/rpmbuild/RPMS/i686/nautilus-terminal-0.7-1.fc13.i686.rpm 
nautilus-terminal.i686: E: no-binary
nautilus-terminal.i686: W: only-non-binary-in-usr-lib
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

This is not an issue.Looks good to me.


XX APPROVED XX

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

--- Comment #7 from Kalev Lember ka...@smartlink.ee 2010-09-29 14:00:21 EDT 
---
It might be better to avoid using %ifarch like that as it will break on other
64 bit multilib architectures.
Instead of:

%ifarch x86_64 ppc64
sed -i
's|/usr/lib/nautilus/extensions-2.0|/usr/lib64/nautilus/extensions-2.0|g'
install.sh
%endif

I'd use:

sed -i
's|/usr/lib/nautilus/extensions-2.0|%{_libdir}/nautilus/extensions-2.0|g'
install.sh

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638713] New: Review Request: php-igbinary - Replacement for the standard PHP serializer

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: php-igbinary - Replacement for the standard PHP 
serializer

https://bugzilla.redhat.com/show_bug.cgi?id=638713

   Summary: Review Request: php-igbinary - Replacement for the
standard PHP serializer
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: fed...@famillecollet.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://github.com/remicollet/remirepo/raw/master/php-igbinary/php-igbinary.spec
SRPM URL: http://remi.fedorapeople.org/php-igbinary-1.0.2-1.src.rpm
Description:
Igbinary is a drop in replacement for the standard PHP serializer.

Instead of time and space consuming textual representation, 
igbinary stores PHP data structures in a compact binary form. 
Savings are significant when using memcached or similar memory
based storages for serialized data.

-- 
Main goal is to enable this serializer in php-pecl-memcached extension.
http://github.com/remicollet/remirepo/commit/bdfbe7a7fa23894104cd0747fbe4a26e7ede491c

Koji : http://koji.fedoraproject.org/koji/taskinfo?taskID=2497271

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 457808] Review Request: gwibber - An open source microblogging client for GNOME developed with Python and GTK

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457808

--- Comment #17 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:35:58 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 470756] Review Request: ghc-HTTP - Haskell HTTP client library

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=470756

--- Comment #13 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:36:14 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 425882] Review Request: ghc-zlib - zlib bindings for ghc

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=425882

--- Comment #50 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:35:38 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 471003] Review Request: cabal-install - Haskell package utility

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=471003

--- Comment #15 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:36:52 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 550105] Review Request: ghc-parsec - Haskell parser library

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550105

--- Comment #8 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:41:14 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 550102] Review Request: ghc-mtl - Haskell Monad Transformer Library

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=550102

--- Comment #8 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:40:46 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 490940] Review Request: mod_pubcookie - A solution for single sign-on authentication to websites

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490940

--- Comment #12 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:39:55 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523884] Review Request: ghc-network - Haskell network library

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523884

--- Comment #9 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:40:33 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574531] Review Request: python26-nose - The nose testing package for the python26 EPEL5 package

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574531

--- Comment #11 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:42:06 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627197] Review Request: bluedevil - Bluetooth stack for KDE

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627197

--- Comment #3 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:46:24 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 606557] Review Request: python26-sqlalchemy - Modular and flexible ORM library for python26

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=606557

--- Comment #5 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:45:09 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 615692] Review Request: ghc-gtk - Haskell gtk binding

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615692

--- Comment #13 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:45:36 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 595603] Review Request: ghc-hslogger - Haskell logging framework

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=595603

--- Comment #38 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:44:28 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 634543] Review Request:animal-sniffer - Tools to assist verifying backward compatibility of Java classes

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634543

--- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:47:13 EDT ---
Git done (by process-git-requests).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635981] Review Request: mojo-signatures - Mojo API signatures project

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635981

--- Comment #4 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:48:02 EDT ---
Git done (by process-git-requests).

Please do remember to assign reviews to the reviewer.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636209] Review Request: atinject - Dependency injection specification for Java (JSR-330)

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636209

--- Comment #11 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:49:40 EDT ---
Git done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636947] Review Request: ding-libs - Ding is not Glib assorted utility libraries

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636947

--- Comment #6 from Kevin Fenzi ke...@tummy.com 2010-09-29 14:52:25 EDT ---
User dpal doesn't seem to be in the packager group?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636947] Review Request: ding-libs - Ding is not Glib assorted utility libraries

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636947

--- Comment #7 from Stephen Gallagher sgall...@redhat.com 2010-09-29 14:54:56 
EDT ---
(In reply to comment #6)
 User dpal doesn't seem to be in the packager group?

Sorry, please move dpal to the InitialCC instead

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 636947] Review Request: ding-libs - Ding is not Glib assorted utility libraries

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=636947

Stephen Gallagher sgall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 523540] Review Request: opentracker - BitTorrent Tracker

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=523540

--- Comment #63 from Simon Wesp cassmod...@fedoraproject.org 2010-09-29 
15:07:22 EDT ---
1 this makes sense
2 an error while i copy/paste phrases
3 you are right. i will keep it simple next time.

no new cvs checkout - just code cleaning and it won't build. Don't know why. I
will keep an eye on it.

http://cassmodiah.fedorapeople.org/opentracker/opentracker-0-0.13.20100414cvs.fc15.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574531] Review Request: python26-nose - The nose testing package for the python26 EPEL5 package

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574531

--- Comment #12 from Dave Malcolm dmalc...@redhat.com 2010-09-29 16:04:38 EDT 
---
Thanks!

Import done:
http://pkgs.fedoraproject.org/gitweb/?p=python26-nose.git;a=commitdiff;h=407f389baac432eb506efb7814e114a35a95ce84

Building python26-nose-0.11.1-3.el5 for dist-5E-epel-testing-candidate
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=2497504

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574531] Review Request: python26-nose - The nose testing package for the python26 EPEL5 package

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574531

--- Comment #13 from Fedora Update System upda...@fedoraproject.org 
2010-09-29 16:11:39 EDT ---
python26-nose-0.11.1-3.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/python26-nose-0.11.1-3.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 574531] Review Request: python26-nose - The nose testing package for the python26 EPEL5 package

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=574531

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |MODIFIED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

--- Comment #1 from hannes johannes.l...@googlemail.com 2010-09-29 16:29:37 
EDT ---
Spec URL: http://hannes.fedorapeople.org/freemind/freemind.spec
SRPM URL:
http://hannes.fedorapeople.org/freemind/freemind-0.9.0.rc9-3.fc14.src.rpm


Made an extra sub-directory for all freemind jars.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 488968] Review Request: fedora-app-install - Fedora application data

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488968

--- Comment #46 from Richard Hughes rhug...@redhat.com 2010-09-29 17:11:48 
EDT ---
(In reply to comment #45)
 I would strongly encourage you to work to find a way to not need to bundle
 all of these icons within a single package.

Such as...?

Richard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625242] Review Request: clustershell - Efficient cluster administration

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625242

--- Comment #22 from Fedora Update System upda...@fedoraproject.org 
2010-09-29 17:22:35 EDT ---
clustershell-1.3.2-1.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 625242] Review Request: clustershell - Efficient cluster administration

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625242

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|clustershell-1.3.2-1.fc12   |clustershell-1.3.2-1.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

--- Comment #9 from Hicham HAOUARI hicham.haou...@gmail.com 2010-09-29 
17:48:22 EDT ---
New Package SCM Request
===
Package Name: nautilus-terminal
Short Description: Terminal embedded in Nautilus
Owners: hicham
Branches: F-12 F-13 F-14
InitialCC: hicham

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635788] Review Request: nautilus-terminal - Terminal embedded in Nautilus

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635788

--- Comment #8 from Hicham HAOUARI hicham.haou...@gmail.com 2010-09-29 
17:46:19 EDT ---
(In reply to comment #7)
 It might be better to avoid using %ifarch like that as it will break on other
 64 bit multilib architectures.
 Instead of:
 
 %ifarch x86_64 ppc64
 sed -i
 's|/usr/lib/nautilus/extensions-2.0|/usr/lib64/nautilus/extensions-2.0|g'
 install.sh
 %endif
 
 I'd use:
 
 sed -i
 's|/usr/lib/nautilus/extensions-2.0|%{_libdir}/nautilus/extensions-2.0|g'
 install.sh

Yes, I already made that locally, thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637402] Review Request: sqlninja - A tool for SQL server injection and takeover

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637402

Hicham HAOUARI hicham.haou...@gmail.com changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|hicham.haou...@gmail.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637402] Review Request: sqlninja - A tool for SQL server injection and takeover

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637402

Hicham HAOUARI hicham.haou...@gmail.com changed:

   What|Removed |Added

 CC||hicham.haou...@gmail.com

--- Comment #1 from Hicham HAOUARI hicham.haou...@gmail.com 2010-09-29 
17:49:24 EDT ---
As per our discussion on IRC, I will look If the binary can be built on Fedora.
Otherwise, I don't think we can ship them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638786] New: Review Request: guessencoding - Guess encoding of files and return configured reader

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: guessencoding - Guess encoding of files and return 
configured reader

https://bugzilla.redhat.com/show_bug.cgi?id=638786

   Summary: Review Request: guessencoding - Guess encoding of
files and return configured reader
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: or...@cora.nwra.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.cora.nwra.com/~orion/fedora/guessencoding.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/guessencoding-1.2-1.fc13.src.rpm
Description:
The purpose of this library is to guess the encoding of files, and retrieve
a reader that is properly configured to use the right encoding as guessed.
The library is able to recognize the various Unicode encoding variants:

* UTF-8
* UTF-16LE - Low Endian
* UTF-16BE - Big Endian
* UTF-32

If a Unicode encoding isn't recognized, it's an 8-bit encoding. If the 8-bit
encoding is not US-ASCII, the default platform 8-bit encoding is assumed
whatever it is. However, the library cannot guess between different 8-bit
encodings. Only statistical analysis, n-grams and similar techniques specific
to each language used in those files can help guessing the encoding, but this
is not supported by the library.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 629326] Review Request: mysql-workbench - A MySQL visual database modeling, administration and querying tool.

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=629326

--- Comment #25 from Liang Suilong liangsuil...@gmail.com 2010-09-29 19:53:17 
EDT ---
OK. I can not find out you do not push mysql-connector-c++-1.1.0-bzr895 to
bodhi for F-13 and F-14. Could you push it now? We can not test to build
mysql-workbench on koji. 

Is rawhide buildroot fixed? I am waiting a new correct build on koji. If we
build mysql-workbench on koji, I think I can approve it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 615692] Review Request: ghc-gtk - Haskell gtk binding

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=615692

--- Comment #14 from Jens Petersen peter...@redhat.com 2010-09-29 20:17:27 
EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=2500217

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624471] Review Request: perl-Lingua-EN-Tagger - Part-of-speech tagger for English natural language processing

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624471

--- Comment #2 from Iain Arnell iarn...@gmail.com 2010-09-29 23:50:18 EDT ---
Thanks for the review Petr. I've fixed the license tag (not sure how I missed
that) and added the additional BuildRequires for core modules.

I'm not convinced that using INSTALLDIRS=perl is such a good idea; makes it
harder if we decide to change the location again in future.


Spec URL: http://fedorapeople.org/~iarnell/review/perl-Lingua-EN-Tagger.spec
SRPM URL:
http://fedorapeople.org/~iarnell/review/perl-Lingua-EN-Tagger-0.16-2.fc15.src.rpm

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2500587

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 629326] Review Request: mysql-workbench - A MySQL visual database modeling, administration and querying tool.

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=629326

--- Comment #26 from Remi Collet fed...@famillecollet.com 2010-09-30 01:03:28 
EDT ---
Ticket open for buildroot exception
https://fedorahosted.org/rel-eng/ticket/4146

Koji scratch build in rawhide (just launch, can't wait for the result)
http://koji.fedoraproject.org/koji/taskinfo?taskID=2500945

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 624833] Review Request: dhcp_probe - Tool for discover DHCP and BootP servers

2010-09-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=624833

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #18 from Fedora Update System upda...@fedoraproject.org 
2010-09-30 01:31:50 EDT ---
dhcp_probe-1.3.0-6.fc14 has been pushed to the Fedora 14 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dhcp_probe'.  You can provide
feedback for this update here:
https://admin.fedoraproject.org/updates/dhcp_probe-1.3.0-6.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review