[Bug 639652] Review Request: python-pika - AMQP client library for Python

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639652

--- Comment #10 from Ilia Cheishvili ilia.cheishv...@gmail.com 2010-10-20 
02:16:54 EDT ---
Package Change Request
==
Package Name: python-pika
New Branches: el5 el6
Owners: icheishvili

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639652] Review Request: python-pika - AMQP client library for Python

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639652

Ilia Cheishvili ilia.cheishv...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-cvs+ |fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644669] Review Request: ucviewer - A tool for browsing Unicode tables

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644669

--- Comment #2 from Parag AN(पराग) panem...@gmail.com 2010-10-20 02:17:51 EDT 
---
To silent the warning from desktop file installation, you may want to remove
comment line form desktop file.

Just want to know what made license for this package to GPL+ instead of GPLv2+
?

I am not sure about version. when I used upstream code and tried to generate
tarball using make dist, got UnicodeViewer1.0.0.tar.gz

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630932

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #11 from Parag AN(पराग) panem...@gmail.com 2010-10-20 02:35:51 
EDT ---
There looks some problem with translit database. Please look into fixing that
issue first.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 634091] Review Request: postgresql-plparrot - A PostgreSQL procedural language for the Parrot virtual machine

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634091

--- Comment #8 from Gerd Pokorra g...@zimt.uni-siegen.de 2010-10-20 03:29:13 
EDT ---
A typo is fixed in:

The specfile (postgres-plparrot.spec) is linked to the new SPEC file:
ftp://ftp.uni-siegen.de/pub/review/postgresql-plparrot.spec.3

The URL of the new SRPM is:
ftp://ftp.uni-siegen.de/pub/review/postgresql-plparrot-0.03-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644708] Review Request: pymongo - Python driver for MongoDB

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644708

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org

--- Comment #2 from Thomas Spura toms...@fedoraproject.org 2010-10-20 
03:43:05 EDT ---
Just some comments for now:

- There was a guidelines change, so you are not allowed to disable the internal
dependency generator (cvisualmodule is even not inside of this package ;-), but
it's:
pymongo.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/pymongo/_cmessage.so _cmessage.so()(64bit)
pymongo-gridfs.x86_64: W: no-documentation
python-bson.x86_64: W: private-shared-object-provides
/usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit)

- python-bson doesn't require the main package and contains no license. Either
include the appropriate license or require the main package.
  (didn't check for license issues yet)

- This package cleanly compiles with python3, could you enable python3
subpackages?
  See: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file
  (you need to run 2to3 --nobackups --write %{py3dir} thought)

- maybe you want to run nosetests and add a %check section...
  I don't know the internals of pymongo, but right now most tests are failing,
so are you sure this package will work, once imported?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644708] Review Request: pymongo - Python driver for MongoDB

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644708

--- Comment #3 from Thomas Spura toms...@fedoraproject.org 2010-10-20 
03:44:28 EDT ---
(In reply to comment #2)
 - There was a guidelines change, so you are not allowed to disable the 
 internal
 dependency generator (cvisualmodule is even not inside of this package ;-), 
 but
 it's:
 pymongo.x86_64: W: private-shared-object-provides
 /usr/lib64/python2.7/site-packages/pymongo/_cmessage.so _cmessage.so()(64bit)
 pymongo-gridfs.x86_64: W: no-documentation
 python-bson.x86_64: W: private-shared-object-provides
 /usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit)

Forgot to add a link here:
https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

This works:
%{?filter_setup:
%filter_provides_in %{python_sitearch}.*\.so$
%filter_setup
}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 642555] Review Request: qdigidoc - Estonian digital signature application

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642555

Peter Lemenkov lemen...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Peter Lemenkov lemen...@gmail.com 2010-10-20 04:46:07 EDT 
---
(In reply to comment #6)

 Added hicolor-icon-theme, but I'm not sure what to do with shared-mime-info as
 http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo recommends
 to avoid depending on shared-mime-info:
 
 Note that similarly to the gtk-update-icon-cache code, these scriptlets 
 should
 be run only if the user has update-mime-info installed and without a specific
 Requires: shared-mime-info.
 
 Any suggestions?

Well, the short answer - I wasn't aware of this strange (as it looks for me)
exception. I'll try to investigate this situation in details, but for now - I
think we should obey this particular rule. I gave up my claim to add
shared-mime-info as requires. 


Ok, I can't find any other issues, so this package is

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 642555] Review Request: qdigidoc - Estonian digital signature application

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642555

Kalev Lember ka...@smartlink.ee changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Kalev Lember ka...@smartlink.ee 2010-10-20 04:54:02 EDT 
---
New Package SCM Request
===
Package Name: qdigidoc
Short Description: Estonian digital signature application
Owners: kalev anttix tuju
Branches: f12 f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630932

--- Comment #12 from Naveen Kumar nku...@redhat.com 2010-10-20 05:09:38 EDT 
---
Thanks Parag! Yep I will try and fix it as soon as possible.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630932

--- Comment #13 from Naveen Kumar nku...@redhat.com 2010-10-20 05:22:06 EDT 
---
New Package CVS Request
===
Package Name: ibus-table-others
Short Description: The package contains various IBus-Tables which include
languages of Latin-America, Europe, Southeast Asia, as well as math and other
symbols
Owners: nkumar
Branches: F-13 F-14 rawhide
InitialCC: i18n-team

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=630932

Naveen Kumar nku...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644804] New: Review Request: apache-commons-parent - Apache Commons Parent Pom

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: apache-commons-parent - Apache Commons Parent Pom

https://bugzilla.redhat.com/show_bug.cgi?id=644804

   Summary: Review Request: apache-commons-parent - Apache Commons
Parent Pom
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: chris.sp...@arcor.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://spike.fedorapeople.org/apache-commons-parent/apache-commons-parent.spec
SRPM URL:
http://spike.fedorapeople.org/apache-commons-parent/apache-commons-parent-15-1.fc13.src.rpm
Description:
The Project Object Model files for the apache-commons packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639671] Review Request: apache-commons-validator - rename of jakarta-commons-validator

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639671

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||socho...@redhat.com
 AssignedTo|nob...@fedoraproject.org|socho...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Stanislav Ochotnicky socho...@redhat.com 2010-10-20 
07:22:39 EDT ---
I'll do the review

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644809] New: Review Request: rubygem-webrat - Ruby Acceptance Testing for Web applications

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-webrat - Ruby Acceptance Testing for Web 
applications

https://bugzilla.redhat.com/show_bug.cgi?id=644809

   Summary: Review Request: rubygem-webrat - Ruby Acceptance
Testing for Web applications
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mfoj...@redhat.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora
Target Release: ---


Spec URL: http://mifo.sk/RPMS/rubygem-webrat.spec
SRPM URL: http://mifo.sk/RPMS/rubygem-webrat-0.7.2-1.fc13.src.rpm

Description:

Webrat lets you quickly write expressive and robust acceptance tests
for a Ruby web application. It supports simulating a browser inside
a Ruby process to avoid the performance hit and browser dependency of
Selenium or Watir, but the same API can also be used to drive real
Selenium tests when necessary (eg. for testing AJAX interactions).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 643140] Review Request: autokey - A desktop automation utility

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=643140

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org
 Blocks||177841(FE-NEEDSPONSOR)

--- Comment #1 from Thomas Spura toms...@fedoraproject.org 2010-10-20 
07:43:14 EDT ---
I'm no sponsor anyway, so just some comments:

- non-executable-script, see:
 
http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
- explicit-lib-dependency is ignorable, because rpmlint just checks if there is
'lib' in the same of the dependencies. In this case it's false positive...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639874] Review Request: python-rocket - Modern, multi-threaded, comet-friendly WSGI web server

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639874

Thomas Spura toms...@fedoraproject.org changed:

   What|Removed |Added

 CC||toms...@fedoraproject.org

--- Comment #1 from Thomas Spura toms...@fedoraproject.org 2010-10-20 
07:45:31 EDT ---
(Didn't look much to this package...)

Why don't you build a python3 subpackage, if it's possible?
At least your description says so...

see:
https://fedoraproject.org/wiki/Packaging:Python

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 643140] Review Request: autokey - A desktop automation utility

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=643140

--- Comment #2 from Thomas Spura toms...@fedoraproject.org 2010-10-20 
07:58:57 EDT ---
(In reply to comment #1)
 - explicit-lib-dependency is ignorable, because rpmlint just checks if there 
 is
 'lib' in the same of the dependencies. In this case it's false positive...

same - name

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639671] Review Request: apache-commons-validator - rename of jakarta-commons-validator

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639671

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Stanislav Ochotnicky socho...@redhat.com 2010-10-20 
08:08:43 EDT ---
Package Review
==

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:
apache-commons-validator-javadoc.noarch: W: obsolete-not-provided
jakarta-commons-validator-javadoc
4 packages and 0 specfiles checked; 0 errors, 1 warnings.

No problem

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format
%{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot is correct
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x]  Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging
Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: ASL 2.0
[x]  If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided
in the spec URL.
MD5SUM this package:ac5b8d6f67982859fe77225ab7fe6548
MD5SUM upstream package:ac5b8d6f67982859fe77225ab7fe6548
[x]  All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates.
[x]  Package requires other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  Permissions on files are set properly.
[x]  Package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
[x]  Package consistently uses macros.
[x]  Package contains code, or permissable content.
[-]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc
subpackage
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[x]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that
tarball (svn export URL, git clone URL, ...)
[-]  If source tarball includes bundled jar/class files these need to be
removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.


=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
Nice comment on using maven build system when it's available

[x]  Javadocs are placed in %{_javadocdir}/%{name}-%{version} with
%{_javadocdir}/%{name} symlink
[-]  If package contains pom.xml files install it (including depmaps) even when
building with ant
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.
Tested on: fedora-rawhide-x86_64

Perhaps the only suggestion I can make: you can try moving test ant
run into %check section from %build, but just in case it won't repeat
a lot of work. But that's really just small thing.

Package is all good. Provides/obsoletes verified



*** APPROVED ***


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 479598] Review Request: aopalliance - AOP offers a better solution to many problems than do existing technologies

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=479598

Sandro Mathys s...@sandro-mathys.ch changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||WONTFIX
   Flag||fedora-review-
Last Closed||2010-10-20 08:24:26

--- Comment #28 from Sandro Mathys s...@sandro-mathys.ch 2010-10-20 08:24:26 
EDT ---
Dropping this review request because of the legal issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639671] Review Request: apache-commons-validator - rename of jakarta-commons-validator

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639671

Chris Spike chris.sp...@arcor.de changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #4 from Chris Spike chris.sp...@arcor.de 2010-10-20 08:30:44 EDT 
---
New Package SCM Request
===
Package Name: apache-commons-validator
Short Description: Apache Commons Validator
Owners: spike
Branches: F-14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639671] Review Request: apache-commons-validator - rename of jakarta-commons-validator

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639671

--- Comment #3 from Chris Spike chris.sp...@arcor.de 2010-10-20 08:29:16 EDT 
---
Thanks for reviewing.

(In reply to comment #2)
 Perhaps the only suggestion I can make: you can try moving test ant
 run into %check section from %build, but just in case it won't repeat
 a lot of work. But that's really just small thing.

Done. New spec and SRPM:
http://spike.fedorapeople.org/apache-commons-validator/apache-commons-validator.spec
http://spike.fedorapeople.org/apache-commons-validator/apache-commons-validator-1.3.1-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 570318] Review Request: gnuplot44 - A program for plotting mathematical expressions and data

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570318

--- Comment #14 from Jose Pedro Oliveira j...@di.uminho.pt 2010-10-20 
08:56:14 EDT ---
The EL4 and EL5 packages

 * https://admin.fedoraproject.org/updates/gnuplot44-4.4.2-2.el5

 * https://admin.fedoraproject.org/updates/gnuplot44-4.4.2-2.el4

have now negative karma.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644669] Review Request: ucviewer - A tool for browsing Unicode tables

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644669

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #4 from Parag AN(पराग) panem...@gmail.com 2010-10-20 09:33:42 EDT 
---
Ok APPROVED.

Please add i18n-team as InitialCC. Not sure if we want fonts-sig also as
InitialCC.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 627180] Review Request: django-paste - dpaste is a code pastebin application using Django.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627180

--- Comment #4 from David Riches davi...@ultracar.co.uk 2010-10-20 10:01:57 
EDT ---
Sorry for the delay

Ok, all non-trivial rpmlint issues fixed up. You will notice a rm line in the
spec file, this is due to a packaging error (not our end) which is due to be
fixed by the upstream. Once it is, I'll bump the spec and update - but for now
I think rm'ing the hidden files and backups should be ok.

revised links:

http://dcr226.fedorapeople.org/SPECS/django-dpaste.spec

http://dcr226.fedorapeople.org/SRPMS/django-dpaste-0.2.4-1.fc13.src.rpm


koji builds fine for me across 12/13/14/rawhide

Hope this works out this time ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644335] Review Request: rubygem-mustache - Mustache is a framework-agnostic way to render logic-free views

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644335

--- Comment #1 from Michal Fojtik mfoj...@redhat.com 2010-10-20 10:08:44 EDT 
---
Some notes for -1:

- Source0: http://rubygems.org/gems/%{gemname}-%{version}.gem

Please this URL to: Source0: http://rubygems.org/downloads/%{}-%{version}.gem

- Summary

Please remove Mustache is, it's unnecessarily here.

- Require

Please add rubygem-sinatra to requires:

./lib/mustache/sinatra.rb:require 'sinatra/base

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644669] Review Request: ucviewer - A tool for browsing Unicode tables

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644669

Tom spot Callaway tcall...@redhat.com changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Tom spot Callaway tcall...@redhat.com 2010-10-20 
10:21:04 EDT ---
New Package SCM Request
===
Package Name: ucviewer
Short Description: A tool for browsing Unicode tables
Owners: spot
Branches: f13 f14 devel
InitialCC: i18n-team fonts-sig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644708] Review Request: pymongo - Python driver for MongoDB

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644708

--- Comment #4 from Silas Sewell si...@sewell.ch 2010-10-20 10:21:28 EDT ---
SRPM:
http://github.com/downloads/silas/rpms/pymongo-1.9-2.fc13.src.rpm

(In reply to comment #2)
 Just some comments for now:
 
 - There was a guidelines change, so you are not allowed to disable the 
 internal
 dependency generator (cvisualmodule is even not inside of this package ;-), 
 but
 it's:
 pymongo.x86_64: W: private-shared-object-provides
 /usr/lib64/python2.7/site-packages/pymongo/_cmessage.so _cmessage.so()(64bit)
 pymongo-gridfs.x86_64: W: no-documentation
 python-bson.x86_64: W: private-shared-object-provides
 /usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit)

This should be fixed.

 - python-bson doesn't require the main package and contains no license. Either
 include the appropriate license or require the main package.
   (didn't check for license issues yet)

I added the license to the subpackage.

 - This package cleanly compiles with python3, could you enable python3
 subpackages?
   See: https://fedoraproject.org/wiki/Packaging:Python#Example_spec_file
   (you need to run 2to3 --nobackups --write %{py3dir} thought)

The package compiles without error but doesn't actually work. I added the code
so its easy to try at a later point, but without the python-nose package
supporting python3 I wouldn't be comfortable enabling a database driver with
auto-magic code conversion (esp one with lots of C code).

That said, if someone else is interested in maintaing a patch for the pymongo
code and all the tests (they import nose) I might be willing to include it.

Upstream has a ticket for python3 support:
http://jira.mongodb.org/browse/PYTHON-84

 - maybe you want to run nosetests and add a %check section...
   I don't know the internals of pymongo, but right now most tests are failing,
 so are you sure this package will work, once imported?

A bunch of the tests require an active MongoDB connection, I've created a check
section that excludes those tests (anything that imported get_connection) and
should at least pass now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 634911] Review Request: nodejs - Evented I/O for v8 JavaScript

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634911

Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

Summary|Review Request: node -  |Review Request: nodejs -
   |Evented I/O for v8  |Evented I/O for v8
   |JavaScript  |JavaScript

--- Comment #2 from Lubomir Rintel lkund...@v3.sk 2010-10-20 10:23:52 EDT ---
Damian, good catch. Thank you!

SPEC: http://v3.sk/~lkundrak/SPECS/nodejs.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/nodejs-0.2.1-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627180] Review Request: django-paste - dpaste is a code pastebin application using Django.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627180

--- Comment #5 from David Riches davi...@ultracar.co.uk 2010-10-20 10:31:25 
EDT ---
Also, if its relevant I have also submitted django-simple-captcha just now..

https://bugzilla.redhat.com/show_bug.cgi?id=644883

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] New: Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: django-simple-captcha - Django application to add 
captcha images to any Django form.

https://bugzilla.redhat.com/show_bug.cgi?id=644883

   Summary: Review Request: django-simple-captcha - Django
application to add captcha images to any Django form.
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: davi...@ultracar.co.uk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://dcr226.fedorapeople.org/SPECS/django-simple-captcha.spec
SRPM URL:
http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-1.fc13.src.rpm
Description: Django Simple Captcha is an extremely simple, yet highly
customizable 
Django application to add captcha images to any Django form.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532590

--- Comment #16 from Lubomir Rintel lkund...@v3.sk 2010-10-20 10:39:50 EDT ---
Okie, thank you. Here you are:

SPEC: http://v3.sk/~lkundrak/SPECS/yaws.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/yaws-1.89-1.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 587198] Review Request: jgraphx - Java Graph Drawing Component

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=587198

Lubomir Rintel lkund...@v3.sk changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 10:50:23

--- Comment #19 from Lubomir Rintel lkund...@v3.sk 2010-10-20 10:50:23 EDT ---
Imported and built. Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644899] New: Review Request: python-PyWavelets - Python wavelet transforms module

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: python-PyWavelets - Python wavelet transforms module

https://bugzilla.redhat.com/show_bug.cgi?id=644899

   Summary: Review Request: python-PyWavelets - Python wavelet
transforms module
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mrlhwlibe...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://helloworld1.fedorapeople.org/python-PyWavelets.spec
SRPM URL:
http://helloworld1.fedorapeople.org/python-PyWavelets-0.2.0-1.fc14.src.rpm
Description: 
PyWavelets is a Python wavelet transforms module that includes:
* 1D and 2D Forward and Inverse Discrete Wavelet Transform (DWT and IDWT)
* 1D and 2D Stationary Wavelet Transform (Undecimated Wavelet Transform)
* 1D and 2D Wavelet Packet decomposition and reconstruction
* Computing Approximations of wavelet and scaling functions
* Over seventy built-in wavelet filters and support for custom wavelets
* Single and double precision calculations
* Results compatibility with Matlab Wavelet Toolbox (tm)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532590

--- Comment #17 from Peter Lemenkov lemen...@gmail.com 2010-10-20 11:10:34 
EDT ---
Good. One minor note - you accidentally forgot to actually list erlang-ibrowse
as a dependency. 

I'll review it in a couple of hours.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

Hiemanshu Sharma hieman...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||hieman...@gmail.com
 AssignedTo|nob...@fedoraproject.org|hieman...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 627180] Review Request: django-paste - dpaste is a code pastebin application using Django.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=627180

--- Comment #6 from David Riches davi...@ultracar.co.uk 2010-10-20 11:31:15 
EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=2545122

koji scratch build

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #1 from David Riches davi...@ultracar.co.uk 2010-10-20 11:28:57 
EDT ---
http://koji.fedoraproject.org/koji/taskinfo?taskID=2544899

Koji scratch build link

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #2 from Hiemanshu Sharma hieman...@gmail.com 2010-10-20 11:34:04 
EDT ---
Taking this for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638906

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|erlang-gen_leader-0-0.2.fc1 |erlang-gen_leader-0-0.2.el5
   |3   |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638974] Review Request: erlang-protobuffs - A set of Protocol Buffers tools and modules for Erlang applications

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638974

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|erlang-protobuffs-0-0.2.201 |erlang-protobuffs-0-0.2.201
   |00930git58ff962.fc12|00930git58ff962.el5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638906] Review Request: erlang-gen_leader - A leader election behavior modeled after gen_server

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638906

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-10-20 12:31:21 EDT ---
erlang-gen_leader-0-0.2.el5 has been pushed to the Fedora EPEL 5 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638974] Review Request: erlang-protobuffs - A set of Protocol Buffers tools and modules for Erlang applications

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638974

--- Comment #14 from Fedora Update System upda...@fedoraproject.org 
2010-10-20 12:31:07 EDT ---
erlang-protobuffs-0-0.2.20100930git58ff962.el5 has been pushed to the Fedora
EPEL 5 stable repository.  If problems still persist, please make note of it in
this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 570318] Review Request: gnuplot44 - A program for plotting mathematical expressions and data

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=570318

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #15 from Fedora Update System upda...@fedoraproject.org 
2010-10-20 12:30:47 EDT ---
gnuplot44-4.4.2-2.el4 has been pushed to the Fedora EPEL 4 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update gnuplot44'.  You can provide
feedback for this update here:
https://admin.fedoraproject.org/updates/gnuplot44-4.4.2-2.el4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #3 from David Riches davi...@ultracar.co.uk 2010-10-20 12:47:11 
EDT ---
bumped spec, fixed folder permissions

new src.rpm..

http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-3.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644335] Review Request: rubygem-mustache - Mustache is a framework-agnostic way to render logic-free views

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644335

--- Comment #2 from Jozef Zigmund jzigm...@redhat.com 2010-10-20 12:56:09 EDT 
---
(In reply to comment #1)
 Some notes for -1:
 
 - Source0: http://rubygems.org/gems/%{gemname}-%{version}.gem
 
 Please this URL to: Source0: http://rubygems.org/downloads/%{}-%{version}.gem

I repair URL to Source0:
http://rubygems.org/downloads/%{gemname}-%{version}.gem, because in your URL
was typo.

 - Summary
 
 Please remove Mustache is, it's unnecessarily here.
 
Removed.

 - Require
 
 Please add rubygem-sinatra to requires:
 
 ./lib/mustache/sinatra.rb:require 'sinatra/base

Add to spec file, Require: rubygem(sinatra)

NEW SPEC URL: http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache.spec
NEW SRPM URL:
http://st.fri.uniza.sk/~zigmundj/fedorapkg/rubygem-mustache-0.11.2-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #4 from David Riches davi...@ultracar.co.uk 2010-10-20 13:02:35 
EDT ---
correction, src.rpm...

http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637985] Review Request: rubygem-pango - Ruby binding of pango-1.x

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637985

Bug 637985 depends on bug 635302, which changed state.

Bug 635302 Summary: Review Request: rubygem-cairo - Ruby bindings for cairo
https://bugzilla.redhat.com/show_bug.cgi?id=635302

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639638] Review Request: rubygem-rsvg2 - Ruby binding of librsvg-2.x

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639638

Bug 639638 depends on bug 635302, which changed state.

Bug 635302 Summary: Review Request: rubygem-cairo - Ruby bindings for cairo
https://bugzilla.redhat.com/show_bug.cgi?id=635302

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639636] Review Request: rubygem-poppler - Ruby binding of poppler-glib

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639636

Bug 639636 depends on bug 635302, which changed state.

Bug 635302 Summary: Review Request: rubygem-cairo - Ruby bindings for cairo
https://bugzilla.redhat.com/show_bug.cgi?id=635302

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639098] Review Request: rubygem-gtk2 - Ruby binding of GTK+-2.x

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639098

Bug 639098 depends on bug 635302, which changed state.

Bug 635302 Summary: Review Request: rubygem-cairo - Ruby bindings for cairo
https://bugzilla.redhat.com/show_bug.cgi?id=635302

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635302] Review Request: rubygem-cairo - Ruby bindings for cairo

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635302

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:02:02

--- Comment #5 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:02:02 EDT ---
Closing, thank you.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637939] Review Request: rubygem-gdk_pixbuf2 - Ruby binding of GdkPixbuf-2.x

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637939

Bug 637939 depends on bug 635302, which changed state.

Bug 635302 Summary: Review Request: rubygem-cairo - Ruby bindings for cairo
https://bugzilla.redhat.com/show_bug.cgi?id=635302

   What|Old Value   |New Value

 Resolution||NEXTRELEASE
 Status|ON_QA   |CLOSED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621015] Review Request: rubygem-authlogic - A simple ruby authentication solution

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621015

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:07:19

--- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:07:19 EDT ---
Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 621017] Review Request: rubygem-scruffy - A powerful, clean graphing library for Ruby

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=621017

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
   Flag|needinfo?(mmo...@redhat.com |
   |)   |
Last Closed||2010-10-20 13:05:31

--- Comment #14 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:05:31 EDT ---
Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637378] Review Request: rubygem-aws - Ruby gem for all Amazon Web Services

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637378

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:04:34

--- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:04:34 EDT ---
Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #5 from Hiemanshu Sharma hieman...@gmail.com 2010-10-20 13:11:30 
EDT ---
x OK
0 Needs to be fixed
- NA/Not checked

x Package meets naming and packaging guidelines
x Spec file matches base package name.
x Spec has consistant macro usage.
x Meets Packaging Guidelines.
x License
x License field in spec matches
x License file included in package
x Spec in American English
x Spec is legible.
x Sources match upstream md5sum:
638fbc8e135ec7d9be26a5c5cec8b48d  django-simple-captcha-0.2.0.tar.gz
- Package needs ExcludeArch
x BuildRequires correct
- Spec handles locales/find_lang
x Package is relocatable and has a reason to be.
x Package has %defattr and permissions on files is good.
x Package has a correct %clean section.
x Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
x Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.

- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.

- Package is a GUI app and has a .desktop file

- Package compiles and builds on at least one arch.
x Package has no duplicate files in %files.
x Package doesn't own any directories other packages own.
x Package owns all the directories it creates.
CHECK :
0 No rpmlint output.
rpmlint django-simple-captcha-0.2.0-1.fc13.x86_64.rpm 
django-simple-captcha.x86_64: I: enchant-dictionary-not-found en_US
django-simple-captcha.x86_64: W: summary-ended-with-dot C Django application to
add captcha images to any Django form.
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

x final provides and requires are sane:
django-simple-captcha-0.2.0-1.fc13.x86_64.rpm
django-simple-captcha = 0.2.0-1.fc13
django-simple-captcha(x86-64) = 0.2.0-1.fc13
=
python(abi) = 2.6

SHOULD Items:

x Should build in mock.
- Should build on all supported archs
- Should function as described.
x Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
x Should have dist tag
x Should package latest version
- check for outstanding bugs on package. (For core merge reviews)

Please fix issues marked 0.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639991] Review Request: rubygem-rb-inotify - A Ruby wrapper for Linux's inotify, using FFI

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639991

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:08:24

--- Comment #12 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:08:24 EDT ---
Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639619] Review Request: rubygem-simple-navigation - Ruby library for creating navigation for your Rails2 or Sinatra application

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639619

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:10:23

--- Comment #15 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:10:23 EDT ---
Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 641295] Review Request: rubygem-typhoeus - A library for interacting with web services at blinding speed

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641295

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:13:57

--- Comment #13 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:13:57 EDT ---
Closing this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639617] Review Request: rubygem-cucumber-rails - Cucumber Generators and Runtime for Rails

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639617

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
 Resolution|NEXTRELEASE |
   Keywords||Reopened

--- Comment #11 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:13:43 EDT ---
Oops, reverting (as F-14 is not built yet)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 639617] Review Request: rubygem-cucumber-rails - Cucumber Generators and Runtime for Rails

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=639617

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution||NEXTRELEASE
Last Closed||2010-10-20 13:12:51

--- Comment #10 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
13:12:51 EDT ---
Closing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #6 from David Riches davi...@ultracar.co.uk 2010-10-20 13:19:14 
EDT ---
Fixed

src.rpm :
http://dcr226.fedorapeople.org/SRPMS/django-simple-captcha-0.2.0-3.fc13.src.rpm

spec changed and bumped accordingly

thanks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 640889] Review Request: q4wine - Qt4 GUI for wine

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640889

Orion Poplawski or...@cora.nwra.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #5 from Orion Poplawski or...@cora.nwra.com 2010-10-20 13:30:03 
EDT ---
Much better.

First look:

- Need to rename q4wine1.spec to q4wine.spec in the src.rpm
- Source0 needs to be:

See https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net

- You need to fix the LICENSE file, either using iconv or getting the latest
from the git repository if upstream has indeed fixed it.

- Need to run update-desktop-database, see
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database

Otherwise looks pretty good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532590

--- Comment #18 from Peter Lemenkov lemen...@gmail.com 2010-10-20 14:13:46 
EDT ---
REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is not silent but all its messages may be ignored.

sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/yaws-*
yaws.ppc: W: no-soname /usr/lib/erlang/lib/yaws/priv/lib/setuid_drv.so
yaws.ppc: W: no-soname /usr/lib/erlang/lib/yaws/priv/lib/yaws_sendfile_drv.so

^^^ this doesn't affect the runtime of the application. These libraries are
designed to be dlopened. 

yaws.ppc: W: manual-page-warning /usr/share/man/man5/yaws_api.5.gz 201:
warning: `yaws' not defined
yaws.ppc: W: manual-page-warning /usr/share/man/man5/yaws.conf.5.gz 231:
warning: `pp' not defined
yaws.ppc: W: manual-page-warning /usr/share/man/man5/yaws.conf.5.gz 289:
warning: `..' not defined

^^^ I'll report upstream about these warnings.

yaws.ppc: E: zero-length /usr/lib/erlang/lib/yaws/src/charset.def

^^^ this file is autogenerated and should be removed. In fact I'd rather to
remove the entire %{_libdir}/erlang/lib/yaws/src contents - this is just a copy
of the original sources, but I'm leaving it to you to decide. Just removing
%{_libdir}/erlang/lib/yaws/src/charset.def would be enough to fix this
particular warning.

yaws-devel.ppc: W: spelling-error %description -l en_US config - con fig,
con-fig, configure

^^^ false positive

yaws-devel.ppc: W: no-documentation

^^^ exactly what it says - no documentation for this package so far.

3 packages and 0 specfiles checked; 1 errors, 7 warnings.
sulaco ~/rpmbuild/SPECS: 

+ The package is named according to the  Package Naming Guidelines.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.

- The package does not fully meet the Packaging Guidelines. You need 

a) Actually add erlang-ibrowse as a runtime dependency.
b) remove empty %{_libdir}/erlang/lib/yaws/examples directories
c) I just found that this package requires erlang = R13B (missing
httpc:request/1, httpc:request/4 and httpc:set_options/1 functions, and I'm not
sure that this can be fixed easily). So no luck for poor EL-5 users for now.
d) remove empty %{_libdir}/erlang/lib/yaws/src/charset.def (or even entire
%{_libdir}/erlang/lib/yaws/src/ )

+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package, match the upstream source, as provided
in the spec URL.

sulaco ~/rpmbuild/SOURCES: sha256sum yaws-1.89.tar.gz*
577c8adde339b700373b83b57b7eca952a41624fcf5f963e43977399de54f170 
yaws-1.89.tar.gz
577c8adde339b700373b83b57b7eca952a41624fcf5f963e43977399de54f170 
yaws-1.89.tar.gz.1
sulaco ~/rpmbuild/SOURCES: 

+ The package successfully compiles and builds into binary rpms on at least one
primary architecture (my ppc on F-12).
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 No shared library files in some of the dynamic linker's default paths.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files.
0 No static libraries.
+ The pkgconfig(.pc) file is stored in a -devel package.
0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1).
+ The -devel package requires the base package using a fully versioned
dependency: Requires: %{name} = %{version}-%{release}
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).


So, please, fix the remaining four issues and I'll finish this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588433] Review Request: rubygem-echoe - ruby gem pacaking tool

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588433

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |rubygem-echo - ruby gem |rubygem-echoe - ruby gem
   |pacaking tool   |pacaking tool

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 588433] Review Request: rubygem-echo - ruby gem pacaking tool

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588433

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

   Flag||needinfo?(ayo...@redhat.com
   ||)

--- Comment #4 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
14:46:25 EDT ---
What is the status of this bug? Although it is not strictly
needed, if rubygem-echoe is available on Fedora it is preferable
for bug 642572.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 642524] Review Request: rubygem-net-sftp - A pure Ruby implementation of the SFTP client protocol

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642524

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|mmo...@redhat.com

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 642572] Review Request: rubygem-commander - The complete solution for Ruby command-line executable

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=642572

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?

--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
15:09:31 EDT ---
Some notes:

* License
  - For this pacakge license tag should be MIT.

* Redundant version dependency
  - Please remove redundant explicit version dependency
For currently supported Fedora branches, all = foo parts
in current spec file are not needed.

  ! Also (Build)Requires: ruby is redundant for this
package (dependency for rubygems already exists)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 641018] Review Request: rubygem-nanoc3 - A web publishing system written in Ruby

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=641018

Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp changed:

   What|Removed |Added

 CC||mtas...@ioa.s.u-tokyo.ac.jp

--- Comment #1 from Mamoru Tasaka mtas...@ioa.s.u-tokyo.ac.jp 2010-10-20 
16:21:07 EDT ---
Some questions first:

* About Requires related to lib/nanoc3/filters/
  - Are Requires related to lib/nanoc3/filers always required
for this rpm? 
According to lib/nanoc3/filters.rb, filter scripts under lib/nanoc3/
are loaded only when actually using such filters, and when not
using such filters the listed rpms don't seem to be needed.

  - And for the same reason, do filters of which the dependencies
are not found on Fedora really have to be removed?
The filter scripts don't seem to be loaded automatically.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 634911] Review Request: nodejs - Evented I/O for v8 JavaScript

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=634911

Damian Wrobel dwro...@ertelnet.rybnik.pl changed:

   What|Removed |Added

 AssignedTo|nob...@fedoraproject.org|dwro...@ertelnet.rybnik.pl
   Flag||fedora-review?

--- Comment #3 from Damian Wrobel dwro...@ertelnet.rybnik.pl 2010-10-20 
16:31:36 EDT ---
Lubomir,
I'll take this review.

BTW, please also remember to update packages that requires the nodejs (e.g. bug
#635359).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

Hiemanshu Sharma hieman...@gmail.com changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #8 from Hiemanshu Sharma hieman...@gmail.com 2010-10-20 16:55:25 
EDT ---
Everything seems to be fine.
Package Approved.!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=644883

--- Comment #9 from David Riches davi...@ultracar.co.uk 2010-10-20 17:06:01 
EDT ---
New Package SCM Request
===
Package Name: django-simple-captcha
Short Description: Django application to add captcha images to any Django form
Owners: dcr226
Branches: f12 f13 f14 rawhide
InitialCC: hiemanshu

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645186] New: Review Request: xavante - Lua Web Server with WSAPI support

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: xavante - Lua Web Server with WSAPI support

https://bugzilla.redhat.com/show_bug.cgi?id=645186

   Summary: Review Request: xavante - Lua Web Server with WSAPI
support
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: t...@niemueller.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/luastuff/xavante.spec
SRPM URL: http://fedorapeople.org/~timn/luastuff/xavante-2.2.0-1.fc13.src.rpm
Description:
Xavante is a Lua HTTP 1.1 Web server that uses a modular architecture based
on URI mapped handlers. Xavante currently offers a file handler, a redirect
handler and a WSAPI handler. Those are used for general files, URI remapping
and WSAPI applications respectively.

URL: http://keplerproject.github.com/xavante/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2545657

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645181] New: Review Request: lua-coxpcall - Coroutine safe xpcall and pcall versions for Lua

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lua-coxpcall - Coroutine safe xpcall and pcall 
versions for Lua

https://bugzilla.redhat.com/show_bug.cgi?id=645181

   Summary: Review Request: lua-coxpcall - Coroutine safe xpcall
and pcall versions for Lua
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: t...@niemueller.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/luastuff/lua-coxpcall.spec
SRPM URL:
http://fedorapeople.org/~timn/luastuff/lua-coxpcall-1.13.0-1.fc13.src.rpm
Description:
Coxpcall encapsulates the protected calls with a coroutine based loop, so
errors can be handled without the usual pcall/xpcall issues with coroutines.

Using Coxpcall usually consists in simply loading the module and then
replacing Lua pcall and xpcall by copcall and coxpcall.
URL: http://coxpcall.luaforge.net/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2545648

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645184] New: Review Request: lua-wsapi - Lua Web Server API

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lua-wsapi - Lua Web Server API

https://bugzilla.redhat.com/show_bug.cgi?id=645184

   Summary: Review Request: lua-wsapi - Lua Web Server API
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: t...@niemueller.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/luastuff/lua-wsapi.spec
SRPM URL: http://fedorapeople.org/~timn/luastuff/lua-wsapi-1.3.4-1.fc13.src.rpm
Description:
WSAPI is an API that abstracts the web server from Lua web applications. By
coding against WSAPI your application can run on any of the supported servers
and interfaces (currently CGI, FastCGI and Xavante, on Windows and UNIX-based
systems).

WSAPI provides a set of helper libraries that help with request processing
and output buffering. You can also write applications that act as filters that
provide some kind of service to other applications, such as authentication,
file uploads, request isolation, or multiplexing.

WSAPI's main influence is Ruby's Rack framework, but it was also influenced by
Python's WSGI (PEP 333). It's not a direct clone of either of them, though,
and tries to follow standard Lua idioms.

URL: http://keplerproject.github.com/wsapi/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2545670

rpmlint: One error, non-executable script. It is correct that the script is
non-executable. I could patch out the first line, but then it doesn't harm
either. I'd rather like to keep this unpatched and will let upstream know about
it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645181] Review Request: lua-coxpcall - Coroutine safe xpcall and pcall versions for Lua

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645181

Tim Niemueller t...@niemueller.de changed:

   What|Removed |Added

 Blocks||645182

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645182] Review Request: lua-copas - Coroutine Oriented Portable Asynchronous Services for Lua

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645182

Tim Niemueller t...@niemueller.de changed:

   What|Removed |Added

 Depends on||645181

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645183] New: Review Request: lua-md5 - Cryptographic Library for MD5 hashes for Lua

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lua-md5 - Cryptographic Library for MD5 hashes for Lua

https://bugzilla.redhat.com/show_bug.cgi?id=645183

   Summary: Review Request: lua-md5 - Cryptographic Library for
MD5 hashes for Lua
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: t...@niemueller.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/luastuff/lua-md5.spec
SRPM URL: http://fedorapeople.org/~timn/luastuff/lua-md5-1.1.2-1.fc13.src.rpm
Description:
MD5 offers basic cryptographic facilities for Lua 5.1: a hash (digest)
function, a pair crypt/decrypt based on MD5 and CFB, and a pair crypt/decrypt
based on DES with 56-bit keys.

URL: http://www.keplerproject.org/md5/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2545651

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645182] New: Review Request: lua-copas - Coroutine Oriented Portable Asynchronous Services for Lua

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lua-copas - Coroutine Oriented Portable Asynchronous 
Services for Lua

https://bugzilla.redhat.com/show_bug.cgi?id=645182

   Summary: Review Request: lua-copas - Coroutine Oriented
Portable Asynchronous Services for Lua
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: t...@niemueller.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/luastuff/lua-copas.spec
SRPM URL: http://fedorapeople.org/~timn/luastuff/lua-copas-1.1.6-1.fc13.src.rpm
Description:
Copas is a dispatcher based on coroutines that can be used by TCP/IP servers.
It uses LuaSocket as the interface with the TCP/IP stack.

A server registered with Copas should provide a handler for requests and use
Copas socket functions to send the response. Copas loops through requests and
invokes the corresponding handlers. For a full implementation of a Copas HTTP
server you can refer to Xavante as an example.

URL: http://keplerproject.github.com/copas/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2545647

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645184] Review Request: lua-wsapi - Lua Web Server API

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645184

Tim Niemueller t...@niemueller.de changed:

   What|Removed |Added

 Blocks||645186

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645186] Review Request: xavante - Lua Web Server with WSAPI support

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645186

Tim Niemueller t...@niemueller.de changed:

   What|Removed |Added

 Depends on||645182, 645184

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645182] Review Request: lua-copas - Coroutine Oriented Portable Asynchronous Services for Lua

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=645182

Tim Niemueller t...@niemueller.de changed:

   What|Removed |Added

 Blocks||645186

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 645185] New: Review Request: lua-xmlrpc - Lua package to access and provide XML-RPC services

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: lua-xmlrpc - Lua package to access and provide XML-RPC 
services

https://bugzilla.redhat.com/show_bug.cgi?id=645185

   Summary: Review Request: lua-xmlrpc - Lua package to access and
provide XML-RPC services
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: t...@niemueller.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://fedorapeople.org/~timn/luastuff/lua-xmlrpc.spec
SRPM URL:
http://fedorapeople.org/~timn/luastuff/lua-xmlrpc-1.2.1-1.fc13.src.rpm
Description:
Lua XML-RPC is a library to make remote procedure calls using XML-RPC.
It also offers facilities to develop server-side software.

Lua XML-RPC provides a simple API and an abstraction layer over XML, thus
avoiding the complexity of having to deal with strings that represent data
structures.

URL: http://keplerproject.github.com/lua-xmlrpc/
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=2545655

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 225759] Merge Review: fontconfig

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225759

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=625602

Alex Lancaster al...@users.sourceforge.net changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #9 from Alex Lancaster al...@users.sourceforge.net 2010-10-21 
00:20:46 EDT ---
Looks good.  Please check my notes on things to fix post-checkin
(particularly the SourceURL stuff), otherwise:

APPROVED

Full review follows:

x   = passes review item
-   = fails review item, package approval blocked until resolution
?   = query that can be resolved after approval, not a blocker
N/A = not applicable to this package

MUST items:

[  ?   ] MUST: rpmlint must be run on every package
$ rpmlint RPMS/x86_64/libbluray-*
~/RPMS/SRPMS/libbluray-0.1-0.1.20100819.fc13.src.rpm 
libbluray.x86_64: W: spelling-error %description -l en_US bluray - blurry,
blurt, blurb
libbluray.x86_64: W: spelling-error %description -l en_US embeddable -
embedding, embedded, shreddable
libbluray.x86_64: W: spelling-error %description -l en_US mplayer - player, m
player, mp layer
libbluray.x86_64: W: spelling-error %description -l en_US vlc - vac, voc, Vlad
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdj/native 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdnav 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/hdmv 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/decoders 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/util 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/libbluray/bdj 0775L
libbluray-debuginfo.x86_64: E: non-standard-dir-perm
/usr/src/debug/libbluray-20100819/src/file 0775L
libbluray.src: W: spelling-error %description -l en_US bluray - blurry, blurt,
blurb
libbluray.src: W: spelling-error %description -l en_US embeddable - embedding,
embedded, shreddable
libbluray.src: W: spelling-error %description -l en_US mplayer - player, m
player, mp layer
libbluray.src: W: spelling-error %description -l en_US vlc - vac, voc, Vlad
libbluray.src:14: W: macro-in-comment %Y
libbluray.src:14: W: macro-in-comment %m
libbluray.src:14: W: macro-in-comment %d
libbluray.src:14: W: macro-in-comment %Y
libbluray.src:14: W: macro-in-comment %m
libbluray.src:14: W: macro-in-comment %d
libbluray.src: W: invalid-url Source0: libbluray-20100819.tar.bz2
4 packages and 0 specfiles checked; 10 errors, 15 warnings.

 Can you look into the debuginfo errors? not sure if they need to be
 fixed or not.  Regarding the macros-in-comment warning, can probably
 ignore that, as well the spelling-error's.

[   x  ] MUST: The package must be named according to the Package Naming 
 Guidelines
[   x  ] MUST: The spec file name must match the base package %{name} [...]
[   x  ] MUST: The package must meet the Packaging Guidelines
[   x  ] MUST: The package must be licensed with a Fedora approved license
 and meet the Licensing Guidelines
  Licensed under LGPLv2+, headers contain:

   * This library is free software; you can redistribute it and/or
   * modify it under the terms of the GNU Lesser General Public
   * License as published by the Free Software Foundation; either
   * version 2.1 of the License, or (at your option) any later version.
  so clearly LGPLv2+, which matches spec file

[  x   ] MUST: The License field in the package spec file must match the 
 actual license
  COPYING contains text of LGPL version 2.1

[  x   ] MUST: If (and only if) the source package includes the text of the 
 license(s) in its own file, then that file, containing the text of 
 the license(s) for the package must be included in %doc
[  x   ] MUST: The spec file must be written in American English.
[  x   ] MUST: The spec file for the package MUST be legible.
[  ?   ] MUST: The sources used to build the package must match the upstream 
 source, as provided in the spec URL. Reviewers should use md5sum for 
 this task. If no upstream URL can be specified for this package, 
 please see the Source URL Guidelines for how to deal with this.
  Can't test the MD5 checksums because the git command will check out
  a different version of the code than the one uploaded in the SRPM,
  unless the git command in 

[Bug 600361] Review Request: gobi_loader - Firmware loader for Qualcomm Gobi WWAN devices

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=600361

Sergei LITVINENKO sergei.litvine...@gmail.com changed:

   What|Removed |Added

 CC||sergei.litvine...@gmail.com

--- Comment #5 from Sergei LITVINENKO sergei.litvine...@gmail.com 2010-10-21 
01:05:28 EDT ---
It work, thanks
http://www.codon.org.uk/~mjg59/tmp/gobi/gobi_loader-0.7-1.src.rpm

EliteBook 2540p (WK304EA)

[serg...@ua-dudn0 ~]$ cat /etc/issue
Fedora release 14 (Laughlin)
Kernel \r on an \m (\l)

[serg...@ua-dudn0 ~]$ uname -r
2.6.35.6-45.fc14.i686.PAE

[serg...@ua-dudn0 ~]$ lsusb
Bus 002 Device 002: ID 8087:0020 Intel Corp. Integrated Rate Matching Hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 007: ID 03f0:251d Hewlett-Packard Gobi 2000 Wireless Modem
Bus 001 Device 006: ID 04f2:b163 Chicony Electronics Co., Ltd 
Bus 001 Device 005: ID 138a:0007 DigitalPersona, Inc Fingeprint Reader
Bus 001 Device 003: ID 03f0:231d Hewlett-Packard 
Bus 001 Device 002: ID 8087:0020 Intel Corp. Integrated Rate Matching Hub
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

PS: How quick rpm will be in standard repository or rpmfusion?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=582894

--- Comment #5 from Daiki Ueno du...@redhat.com 2010-10-21 01:32:22 EDT ---
Thanks, updated:

Spec URL:
http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk.spec
SRPM URL:
http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk-14.1-2.fc13.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=582894

--- Comment #6 from Daiki Ueno du...@redhat.com 2010-10-21 01:53:17 EDT ---
Sorry, the SRPM URL was wrong.  Updated with minor fix:

Spec URL:
http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk.spec
SRPM URL:
http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk-14.1-3.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 637134] Review Request: bird - BIRD Internet Routing Daemon

2010-10-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=637134

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

   Fixed In Version|bird-1.2.5-1.fc14   |bird-1.2.5-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review