[Bug 634091] Review Request: postgresql-plparrot - A PostgreSQL procedural language for the Parrot virtual machine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=634091 --- Comment #9 from Gerd Pokorra 2010-10-22 02:24:42 EDT --- - changed requires from postgresql to postgresql-contrib The specfile (postgres-plparrot.spec) is linked to the new SPEC file: ftp://ftp.uni-siegen.de/pub/review/postgresql-plparrot.spec.4 The URL of the new SRPM is: ftp://ftp.uni-siegen.de/pub/review/postgresql-plparrot-0.03-4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630339] Review Request: python-redis - A Python client for redis
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630339
Ruben Kerkhof changed:
What|Removed |Added
CC||ru...@rubenkerkhof.com
--- Comment #2 from Ruben Kerkhof 2010-10-22 02:00:12
EDT ---
Hi Silas,
You don't need the python_sitelib defines anymore in Fedora 13 and higher.
BuildRoot is also not needed anymore.
The same goes for %clean and rm -rf %{buildroot} in %install.
No tests, that's a pity. However I did a few tests against Redis and it works
fine.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226092] Merge Review: libXvMC
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226092 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:35:47 --- Comment #2 from Parag AN(पराग) 2010-10-22 00:35:47 EDT --- Committed the above patch and built in libXvMC-1.0.6-2.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225835] Merge Review: gnome-session
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225835 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:36:23 --- Comment #2 from Parag AN(पराग) 2010-10-22 00:36:23 EDT --- Committed the above patch and built in gnome-session-2.91.0-2.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226030] Merge Review: libiec61883
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226030 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:36:02 --- Comment #6 from Parag AN(पराग) 2010-10-22 00:36:02 EDT --- Committed the above patch and built in libiec61883-1.2.0-5.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226100] Merge Review: lksctp-tools
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226100 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:35:42 --- Comment #5 from Parag AN(पराग) 2010-10-22 00:35:42 EDT --- Committed the above patch and built in lksctp-tools-1.0.11-2.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226088] Merge Review: libxslt
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226088 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:35:55 --- Comment #4 from Parag AN(पराग) 2010-10-22 00:35:55 EDT --- Committed the above patch and built in libxslt-1.1.26-4.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226138] Merge Review: metacity
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226138 Parag AN(पराग) changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:36:31 --- Comment #6 from Parag AN(पराग) 2010-10-22 00:36:31 EDT --- Committed the above patch and built in metacity-2.30.3-2.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225840] Merge Review: gnome-themes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225840 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:36:16 --- Comment #2 from Parag AN(पराग) 2010-10-22 00:36:16 EDT --- Committed the above patch and built in gnome-themes-2.32.0-2.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225843] Merge Review: gnome-vfs2
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225843 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed||2010-10-22 00:36:09 --- Comment #7 from Parag AN(पराग) 2010-10-22 00:36:09 EDT --- Committed the above patch and built in gnome-vfs2-2.24.4-1.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226547] Merge Review: x86info
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226547 Parag AN(पराग) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ Last Closed|2010-08-11 15:26:15 |2010-10-22 00:31:58 --- Comment #21 from Parag AN(पराग) 2010-10-22 00:31:58 EDT --- Committed the above patch and built in x86info-1.27-2.fc15 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644708] Review Request: pymongo - Python driver for MongoDB
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644708 --- Comment #6 from Silas Sewell 2010-10-21 23:25:34 EDT --- SRPM: http://github.com/downloads/silas/rpms/pymongo-1.9-3.fc13.src.rpm (In reply to comment #5) > Now: > """ > Ran 0 tests in 0.453s > > OK > """ > ;-) Yeah, missed that, fixed now. > It would be nice, if an active MongoDB connection can be hacked together > somehow, so there is a testsuite to check (I know nothing about the internalls > if that's possible or not...). Not really, no. > -> NICE–TO–HAVE (not even a SHOULD^^) > > - Isn't the license ASL 2.0 and MIT? > See bson/time64* Fixed. > - BR might be wrong: > It would be better to use python2-devel, don't know if python-devel could > become python3-devel, when changing the default /usr/bin/python etc... Updated it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 Daiki Ueno changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-10-21 23:16:32 --- Comment #12 from Daiki Ueno 2010-10-21 23:16:32 EDT --- Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 --- Comment #10 from Fedora Update System 2010-10-21 23:15:53 EDT --- emacs-common-ddskk-14.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/emacs-common-ddskk-14.1-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 --- Comment #11 from Fedora Update System 2010-10-21 23:15:59 EDT --- emacs-common-ddskk-14.1-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/emacs-common-ddskk-14.1-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #13 from Alex Lancaster 2010-10-21 22:04:27 EDT --- (In reply to comment #10) > (In reply to comment #9) > I will rework this part to use the commit hash rather than the date. I'll also > fix the release tag to include the commit hash (at least the start of it), as > per the guideline on pre-releases. Got your updated spec, looks good. Thanks for fixing that. > > [ ? ] MUST: Static libraries must be in a -static package. > > Seems that generating a static package is optional, is this intentional? > > > Yes, this is intentional. Static libs are only needed to build some of the > small test programs that are included (but not built nor installed by default > Makefile). Check. > You can probably test with the BD iso from the link in comment #3. Actually, just after I submitted the review, I recompiled XBMC with libbluray support. It appears that xbmc dlopen()s libbluray.so.1 or otherwise doesn't link it into the binary, however it does correctly load. Unfortunately xbmc can't play an ISO directly, but I could loopback mount the ISO and then navigate to the folder and it did play the disc content (albeit with no Bluray menus, it just skipped to next playlist item), but seems to playback just fine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #47 from manuel wolfshant 2010-10-21 19:47:14 EDT --- As far as I remember, selinux was indeed active, but I am 90% positive that I also tried with it in permissive mode. If you want me to, I can perform any tests that you feel that could be useful, but only in Centos 5 ( the only computer at hand with Wi-Fi is a laptop which runs C5; switching to anything else is not an option). As a sidenote and probably not Fedora but RHEL related, on the very same laptop wicd from the Backtrack livecd performs WAY better. But this might be due to the newer kernel module for the Broadcom Wi-Fi chipset used in this oldish Dell. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 Xavier Bachelot changed: What|Removed |Added Flag||fedora-cvs? --- Comment #12 from Xavier Bachelot 2010-10-21 19:35:15 EDT --- New Package SCM Request === Package Name: libbluray Short Description: Library to access Blu-Ray disks for video playback Owners: xavierb Branches: f12 f13 f14 el5 el6 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #46 from David Cantrell 2010-10-21 19:33:06 EDT --- Interesting. I'm using the latest version I packaged up and it works fine for me, but out of curiosity do either of you have SELinux enabled? I have a feeling that wicd's daemon may be hitting some SELinux walls when it tries to remember settings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=625602 --- Comment #11 from Xavier Bachelot 2010-10-21 19:25:49 EDT --- New SRPM and spec addressing your comments : Spec URL: http://www.bachelot.org/fedora/SPECS/libbluray.spec SRPM URL : http://www.bachelot.org/fedora/SRPMS/libbluray-0.1-0.2.20101021git144a204c02687.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645603] New: Review Request: python-mox - Mock object framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-mox - Mock object framework https://bugzilla.redhat.com/show_bug.cgi?id=645603 Summary: Review Request: python-mox - Mock object framework Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: si...@sewell.ch QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec: http://github.com/silas/rpms/raw/master/python-mox/python-mox.spec SRPM: http://github.com/downloads/silas/rpms/python-mox-0.5.3-1.fc13.src.rpm Description: Mox is a mock object framework for Python based on the Java mock object framework EasyMock. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #45 from manuel wolfshant 2010-10-21 19:21:47 EDT --- FWIW, I've had issues similar to Reese's with wicd>=1.6.2.2 , too, on Centos 5. I ended by downgrading to 1.6.2.1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645604] New: Review Request: python-gflags - Commandline flags module for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-gflags - Commandline flags module for Python https://bugzilla.redhat.com/show_bug.cgi?id=645604 Summary: Review Request: python-gflags - Commandline flags module for Python Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: si...@sewell.ch QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec: http://github.com/silas/rpms/raw/master/python-gflags/python-gflags.spec SRPM: http://github.com/downloads/silas/rpms/python-gflags-1.4-1.fc13.src.rpm Description: This project is the python equivalent of google-gflags, a Google commandline flag implementation for C++. It is intended to be used in situations where a project wants to mimic the command-line flag handling of a C++ app that uses google-gflags, or for a Python app that, via swig or some other means, is linked with a C++ app that uses google-gflags. The gflags package contains a library that implements commandline flags processing. As such it's a replacement for getopt(). It has increased flexibility, including built-in support for Python types, and the ability to define flags in the source file in which they're used. (This last is its major difference from OptParse.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642856] Review Request: drupal6-flexifilter - Allows non-admins to create their own, configurable custom filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642856 Fedora Update System changed: What|Removed |Added Status|VERIFIED|MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642856] Review Request: drupal6-flexifilter - Allows non-admins to create their own, configurable custom filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642856 --- Comment #11 from Fedora Update System 2010-10-21 18:10:29 EDT --- drupal6-flexifilter-1.2-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/drupal6-flexifilter-1.2-2.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 634911] Review Request: nodejs - Evented I/O for v8 JavaScript
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=634911
--- Comment #4 from Damian Wrobel 2010-10-21
18:06:32 EDT ---
Lubomir, please find some initial comments:
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint nodejs-0.2.1-3.fc13.src.rpm.
nodejs.src: W: spelling-error Summary(en_US) Evented -> Vented, E vented,
Evened
nodejs.src:50: W: configure-without-libdir-spec
nodejs.src:70: E: hardcoded-library-path in %{_prefix}/lib/node
nodejs.src: W: invalid-url Source0:
http://s3.amazonaws.com/four.livejournal/20100203/node-v0.2.1.tar.gz HTTP Error
403: Forbidden
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
- The Source0: should point to the
http://nodejs.org/dist/node-v%{version}.tar.gz
- The %{_prefix}/lib should be replaced with %{_libdir}
NOT OK
- MUST: The package must meet the Packaging Guidelines.
- According to the guildeline[1] you can safely remove the BuildRoot from the
spec - if I'm not mistaken you're targeting only: >=F-14, >=el6.
- The package duplicates the waf[2] package which is already available in the
Fedora.
NOT OK
- MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
OK, MIT, Modern Style with sublicense
- MUST: The License field in the package spec file must match the actual
license.
NOT OK. IMHO the license of the package is MIT only (assuming that the
duplicated "waf" files will be removed).
- MUST: The spec file must be written in American English.
- An American English is not my native language, but maybe it's a good idea to
change the "Evented" to e.g. "Event based".
- The description doesn't provide a useful information about the program. The
second sentence seems to contain irrelevant copy-paste content.
NOT OK
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this pa...
Please consider to update to the latest available version[3].
NOT OK
Additional things worth considering:
- The provided /usr/bin/node will generate a clash with the /usr/sbin/node[4]
especially when the user will have in the PATH both /usr/bin/ and /usr/sbin/
and node[4] package installed.
- I'm not sure what is the purpose of the node-waf or node-repl?
- There is the following shebang in the /usr/bin/node-repl:
#!/usr/bin/env node
which can be resolved to the /usr/sbin/node from the node[4] package.
- The -devel package contains the node.h file which includes the following
additional headers:
#include
#include
#include
but there is no explicit "Requires" for: v8-devel, libev-devel, libeio-devel.
It might be difficult for user to guess from which packages the aforementioned
headers comes from.
References:
[1]. http://fedoraproject.org/wiki/Packaging/Guidelines
[2]. https://admin.fedoraproject.org/pkgdb/acls/name/waf
[3]. http://nodejs.org/dist/node-v0.2.3.tar.gz
[4]. https://admin.fedoraproject.org/pkgdb/acls/name/node
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 593841] Review Request: wicd - Wireless and wired network connection manager
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=593841 --- Comment #44 from Reese 2010-10-21 18:04:18 EDT --- I've experienced a variety of problems following wicd-1.6.2.1, the most consistent of which is an inability to remember, and therefore automatically connect to, hidden networks. 1.6.2.1 successfully accomplishes this while 1.6.2.2 and 1.7* do not. This applies to use with F11, F12, and F13. I've seen the devs pin these problems on wireless cards, but their old version works and the new ones don't, so this seems inaccurate. I recommend 1.6.2.1 for repository. wicd's overwhelming strength is consistency in that connections aren't dropped. networkmanager struggles with this, especially when dealing with hidden networks. Let's not make this feature obsolete with newer, inferior releases. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644708] Review Request: pymongo - Python driver for MongoDB
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644708 Thomas Spura changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|toms...@fedoraproject.org Flag||fedora-review? --- Comment #5 from Thomas Spura 2010-10-21 16:32:20 EDT --- (In reply to comment #4) > (In reply to comment #2) > > Just some comments for now: > > > > pymongo.x86_64: W: private-shared-object-provides > > /usr/lib64/python2.7/site-packages/pymongo/_cmessage.so > > _cmessage.so()(64bit) > > pymongo-gridfs.x86_64: W: no-documentation > > python-bson.x86_64: W: private-shared-object-provides > > /usr/lib64/python2.7/site-packages/bson/_cbson.so _cbson.so()(64bit) > > This should be fixed. It is. > > - python-bson doesn't require the main package and contains no license. > > Either > > include the appropriate license or require the main package. > > (didn't check for license issues yet) > > I added the license to the subpackage. Ok > Upstream has a ticket for python3 support: > http://jira.mongodb.org/browse/PYTHON-84 Sure, didn't check for upstream if it's already supported to be honest... > > - maybe you want to run nosetests and add a %check section... > > I don't know the internals of pymongo, but right now most tests are > > failing, > > so are you sure this package will work, once imported? > > A bunch of the tests require an active MongoDB connection, I've created a > check > section that excludes those tests (anything that imported get_connection) and > should at least pass now. Now: """ Ran 0 tests in 0.453s OK """ ;-) It would be nice, if an active MongoDB connection can be hacked together somehow, so there is a testsuite to check (I know nothing about the internalls if that's possible or not...). -> NICE–TO–HAVE (not even a SHOULD^^) - Isn't the license ASL 2.0 and MIT? See bson/time64* - BR might be wrong: It would be better to use python2-devel, don't know if python-devel could become python3-devel, when changing the default /usr/bin/python etc... Rest looks ok. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635450] Review Request: docky - MacOS-like docker app
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635450 Bug 635450 depends on bug 635451, which changed state. Bug 635451 Summary: Review Request: gio-sharp - Mono GIO API binding https://bugzilla.redhat.com/show_bug.cgi?id=635451 What|Old Value |New Value Resolution||WONTFIX Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635451] Review Request: gio-sharp - Mono GIO API binding
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635451 Lukáš Zapletal changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WONTFIX Last Closed||2010-10-21 16:25:13 --- Comment #7 from Lukáš Zapletal 2010-10-21 16:25:13 EDT --- Somebody else uploaded the spec and its already in Fedora. See bug 639350. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642985] Review Request: rubygem-timecop - Provides a unified method to mock Time.now, Date.today in a single call
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642985 --- Comment #4 from Mamoru Tasaka 2010-10-21 14:57:00 EDT --- Created attachment 454912 --> https://bugzilla.redhat.com/attachment.cgi?id=454912 Use nanosleep() instead of select() for ruby sleep() If bug 640608 is related to select(), the attached patch may worth trying. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 641018] Review Request: rubygem-nanoc3 - A web publishing system written in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641018 --- Comment #3 from Mamoru Tasaka 2010-10-21 13:41:52 EDT --- (In reply to comment #2) > (In reply to comment #1) > > Some questions first: > > > > * About Requires related to lib/nanoc3/filters/ > > - Are Requires related to lib/nanoc3/filers always required > > for this rpm? > > According to lib/nanoc3/filters.rb, filter scripts under lib/nanoc3/ > > are loaded only when actually using such filters, and when not > > using such filters the listed rpms don't seem to be needed. > > Yes that true. But to guarantee basic functionality for user, - So yes, we want to make rpms installed which is needed for "basic" functionality on this gem, however are all scripts under lib/nanoc3/filters classified as "basic" functionality for this rpm? For example, even without the rpms for the dependency of filters installed at all, $ ruby -rubygems -e 'require "nanoc3" ; puts Nanoc3::VERSION' works. > it's necessary to > include that gems. Otherwise functionality that is related > with those gems will be not available. - Just by default. So people can install the needed rpms afterwards when people wants to use the functionality. > And if they are already packaged for Fedora, I can't see the reason for > omitting them as a dependencies. - For people not using all of the filter functionality, not using unneeded rpms if possible is preferable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643595] Review Request: openeuclide - A plane geometry software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643595 --- Comment #9 from Fedora Update System 2010-10-21 12:58:34 EDT --- openeuclide-0.5-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/openeuclide-0.5-3.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643595] Review Request: openeuclide - A plane geometry software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643595 --- Comment #10 from Fedora Update System 2010-10-21 12:58:43 EDT --- openeuclide-0.5-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/openeuclide-0.5-3.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627180] Review Request: django-paste - dpaste is a code pastebin application using Django.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627180 --- Comment #8 from David Riches 2010-10-21 12:56:55 EDT --- Fixed dependency issue.. SRPM: http://dcr226.fedorapeople.org/SRPMS/django-dpaste-0.2.4-2.fc13.src.rpm SPEC: as above rpmlint output: clean against spec, rpm and src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643595] Review Request: openeuclide - A plane geometry software
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643595 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645484] New: Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal https://bugzilla.redhat.com/show_bug.cgi?id=645484 Summary: Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: davi...@ultracar.co.uk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://dcr226.fedorapeople.org/SPECS/django-mptt.spec SRPM URL: http://dcr226.fedorapeople.org/SRPMS/django-mptt-0.4.1-1.fc13.src.rpm Description: Utilities for implementing Modified Preorder Tree Traversal (MPTT) with your Django Model classes and working with trees of Model instances. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645484] Review Request: django-mptt - Utilities for implementing Modified Preorder Tree Traversal
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645484 --- Comment #1 from David Riches 2010-10-21 11:47:04 EDT --- Koji scratch build urls: http://koji.fedoraproject.org/koji/taskinfo?taskID=2546977 <- f13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2546980 <- f14 rpmlint output: clean across spec, src.rpm and rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 641018] Review Request: rubygem-nanoc3 - A web publishing system written in Ruby
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=641018 --- Comment #2 from Michal Fojtik 2010-10-21 11:40:24 EDT --- (In reply to comment #1) > Some questions first: > > * About Requires related to lib/nanoc3/filters/ > - Are Requires related to lib/nanoc3/filers always required > for this rpm? > According to lib/nanoc3/filters.rb, filter scripts under lib/nanoc3/ > are loaded only when actually using such filters, and when not > using such filters the listed rpms don't seem to be needed. Yes that true. But to guarantee basic functionality for user, it's necessary to include that gems. Otherwise functionality that is related with those gems will be not available. And if they are already packaged for Fedora, I can't see the reason for omitting them as a dependencies. > > - And for the same reason, do filters of which the dependencies > are not found on Fedora really have to be removed? > The filter scripts don't seem to be loaded automatically. That's correct. I will keep all those filters here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 225991] Merge Review: libbtctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225991 --- Comment #4 from Vojtech Vitek 2010-10-21 11:30:28 EDT --- I have commited patch from Parag AN and few other changes made by myself. Please, check out new rawhide build libbtctl-0.11.1-7.fc15 in master. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643199] Review Request: python-pymtp - A Pythonic wrapper around libmtp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643199 --- Comment #3 from Ville-Pekka Vainio 2010-10-21 10:48:13 EDT --- I tested this package on an x86_64 system with libmtp.i686 installed and it did not work. I see two options here. Either I have this package depending on "libmtp" (like it is now) and hope yum installs the correct arch version of libmtp and people don't already have the "wrong" version installed or I make this package arch-dependent. Opinions? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642555] Review Request: qdigidoc - Estonian digital signature application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642555 Kalev Lember changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||qdigidoc-0.4.0-3.fc15 Resolution||NEXTRELEASE Last Closed||2010-10-21 10:20:28 --- Comment #10 from Kalev Lember 2010-10-21 10:20:28 EDT --- Package imported and built for rawhide, closing the ticket. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566725] Review Request: gdcm - Grassroots DiCoM is a C++ library to reading/parsing and writing DICOM medical files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566725 Mario Ceresa changed: What|Removed |Added Summary|Review Request: GDCM - |Review Request: gdcm - |Grassroots DiCoM is a C++ |Grassroots DiCoM is a C++ |library to reading/parsing |library to reading/parsing |and writing DICOM medical |and writing DICOM medical |files |files Flag||fedora-cvs? --- Comment #18 from Mario Ceresa 2010-10-21 10:15:33 EDT --- New Package SCM Request === Package Name: gdcm Short Description: Grassroots DiCoM is a C++ library to reading/parsing and writing DICOM medical files Owners: mrceresa Branches: f12 f13 f14 el6 InitialCC: peter -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591388] Review Request: pbuilder - Personal package builder for Debian packages
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591388 --- Comment #1 from Jeroen van Meeuwen 2010-10-21 10:15:07 EDT --- New SPEC: http://git.kolabsys.com/rpm/pbuilder/plain/pbuilder.spec?h=f13/master New SRPM: http://mirror.kolabsys.com/pub/fedora/apt-utils/f13/SRPMS/pbuilder-0.196-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #13 from Fedora Update System 2010-10-21 10:16:06 EDT --- django-simple-captcha-0.2.0-4.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 624023] Review Request: reprepro - Debian package repository producer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=624023 --- Comment #1 from Jeroen van Meeuwen 2010-10-21 10:16:11 EDT --- New SPEC: http://git.kolabsys.com/rpm/reprepro/plain/reprepro.spec?h=f13/custom-kolabsys.com&id=7d314c2fe42a25231adee31b34ed24fa5df0ae96 New SRPM: http://mirror.kolabsys.com/pub/fedora/apt-utils/f13/SRPMS/reprepro-4.2.0-3.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #12 from Fedora Update System 2010-10-21 10:15:07 EDT --- django-simple-captcha-0.2.0-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc13 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #11 from Fedora Update System 2010-10-21 10:13:14 EDT --- django-simple-captcha-0.2.0-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/django-simple-captcha-0.2.0-4.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591389] Review Request: po-debconf - Tool for managing templates file translations with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591389 Jeroen van Meeuwen changed: What|Removed |Added Flag|needinfo?(kana...@kanarip.c | |om) | --- Comment #4 from Jeroen van Meeuwen 2010-10-21 10:11:18 EDT --- New SPEC: http://git.kolabsys.com/rpm/po-debconf/plain/po-debconf.spec?h=f13/master New SRPM: http://mirror.kolabsys.com/pub/fedora/apt-utils/f13/SRPMS/po-debconf-1.0.16-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 591332] Review Request: debconf - Debian configuration management system
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=591332 --- Comment #1 from Jeroen van Meeuwen 2010-10-21 10:13:58 EDT --- New SPEC: http://git.kolabsys.com/rpm/debconf/plain/debconf.spec?h=f13/master New SRPM: http://mirror.kolabsys.com/pub/fedora/apt-utils/f13/SRPMS/debconf-1.5.32-4.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 David Riches changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-10-21 10:11:41 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643391] Review Request: pytrailer - Python module to simplify access to movies on apple.com/trailers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643391 Stanislav Ochotnicky changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE Last Closed||2010-10-21 09:58:26 --- Comment #6 from Stanislav Ochotnicky 2010-10-21 09:58:26 EDT --- Thanks for review & scm. Package built, closing. http://koji.fedoraproject.org/koji/taskinfo?taskID=2546648 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 639671] Review Request: apache-commons-validator - rename of jakarta-commons-validator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639671 Chris Spike changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Last Closed||2010-10-21 09:58:01 --- Comment #6 from Chris Spike 2010-10-21 09:58:01 EDT --- Package built, closing. Koji build: https://koji.fedoraproject.org/koji/buildinfo?buildID=201342 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643392] Review Request: pyqtrailer - PyQt4 application to download trailers from apple.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643392 Bug 643392 depends on bug 643391, which changed state. Bug 643391 Summary: Review Request: pytrailer - Python module to simplify access to movies on apple.com/trailers https://bugzilla.redhat.com/show_bug.cgi?id=643391 What|Old Value |New Value Resolution||RAWHIDE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642856] Review Request: drupal6-flexifilter - Allows non-admins to create their own, configurable custom filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642856 --- Comment #10 from Kevin Fenzi 2010-10-21 09:29:57 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642555] Review Request: qdigidoc - Estonian digital signature application
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642555 --- Comment #9 from Kevin Fenzi 2010-10-21 09:29:21 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 643391] Review Request: pytrailer - Python module to simplify access to movies on apple.com/trailers
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=643391 --- Comment #5 from Kevin Fenzi 2010-10-21 09:30:22 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644669] Review Request: ucviewer - A tool for browsing Unicode tables
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644669 --- Comment #6 from Kevin Fenzi 2010-10-21 09:31:25 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 --- Comment #10 from Kevin Fenzi 2010-10-21 09:32:00 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 639652] Review Request: python-pika - AMQP client library for Python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639652 --- Comment #11 from Kevin Fenzi 2010-10-21 09:28:32 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 639671] Review Request: apache-commons-validator - rename of jakarta-commons-validator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=639671 --- Comment #5 from Kevin Fenzi 2010-10-21 09:28:57 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 566725] Review Request: GDCM - Grassroots DiCoM is a C++ library to reading/parsing and writing DICOM medical files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=566725 --- Comment #17 from Kevin Fenzi 2010-10-21 09:26:34 EDT --- WARNING: Invalid branch f15 requested WARNING: Requested package name gdcm doesn't match bug summary GDCM We are not yet doing f15 branches and can you correct the summary and/or package name in the scm request? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630932] Review Request: ibus-table-others- Various tables for IBus-Table
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630932 --- Comment #14 from Kevin Fenzi 2010-10-21 09:28:07 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 573264] Review Request: qt-assistant-adp - Compatibility version of Qt Assistant
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=573264 --- Comment #9 from Kevin Fenzi 2010-10-21 09:27:00 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 --- Comment #9 from Kevin Fenzi 2010-10-21 09:27:28 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532590 --- Comment #22 from Kevin Fenzi 2010-10-21 09:24:03 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 545047] Review Request: NearTree - An API for finding nearest neighbors
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=545047 --- Comment #20 from Kevin Fenzi 2010-10-21 09:25:02 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588433] Review Request: rubygem-echoe - ruby gem pacaking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588433 --- Comment #7 from Jesus M. Rodriguez 2010-10-21 09:20:36 EDT --- Current srpm can be found: http://jmrodri.fedorapeople.org/rubygem-echoe-4.3-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588433] Review Request: rubygem-echoe - ruby gem pacaking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588433 Jesus M. Rodriguez changed: What|Removed |Added Flag|needinfo?(ayo...@redhat.com | |) | --- Comment #6 from Jesus M. Rodriguez 2010-10-21 09:18:46 EDT --- (In reply to comment #4) > What is the status of this bug? Although it is not strictly > needed, if rubygem-echoe is available on Fedora it is preferable > for bug 642572. The status of the bug is not much movement has occurred. Current spec lives here: http://github.com/jmrodri/MySpecs/raw/master/rubygem-echoe/rubygem-echoe.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 641271] Review Request: openerp-client - Open Source ERP Client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=641271
--- Comment #3 from Dan Horák 2010-10-21 09:17:15 EDT ---
There is a problem that must be resolved with upstream before we can continue -
the files in bin/SpiffGtkWidgets are licensed as "GPLv2 only" making them
incompatible with the rest of the project that is GPLv3+
(https://fedoraproject.org/wiki/Licensing#GPL_Compatibility_Matrix)
Other issues found during my review are
- the uploaded file has the first character in upper-case, but the content of
the srpm itself is fine, should be all lower-case
- cli_dir macro is defined but not used anywhere, please remove
- I'd personally use %{name} macro instead of the openerp-client string inside
the %build/%install/%files sections
- build in mock for rawhide and F-14 fails with
...
+ /usr/bin/python setup.py build
Error: Can not find dsextras or gtk.dsextras
- the --vendor option shouldn't be used in new packages
(https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage)
- locales are not handled correctly, see
https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 588433] Review Request: rubygem-echoe - ruby gem pacaking tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=588433 --- Comment #5 from Jesus M. Rodriguez 2010-10-21 09:16:34 EDT --- (In reply to comment #3) > Please correct name of this package, it's 'echoe', not echo. Also there are > some typos as well: > > Review Request: rubygem-echo - ruby gem pacaking tool > > + if you are short of time, I can take this package. Yes, definitely short on time. If you would like to take this package, I can give you what I have already. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642856] Review Request: drupal6-flexifilter - Allows non-admins to create their own, configurable custom filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642856 Sven Lankes changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Sven Lankes 2010-10-21 08:42:19 EDT --- New Package SCM Request === Package Name: drupal6-flexifilter Short Description: Allows non-admins to create their own, configurable custom filters Owners: slankes limb Branches: f13 f14 el5 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532590 Lubomir Rintel changed: What|Removed |Added Flag||fedora-cvs? --- Comment #21 from Lubomir Rintel 2010-10-21 08:31:38 EDT --- Thanks a lot! New Package SCM Request === Package Name: yaws Short Description: Web server for dynamic content written in Erlang Owners: lkundrak peter Branches: f12 f13 f14 el6 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642856] Review Request: drupal6-flexifilter - Allows non-admins to create their own, configurable custom filters
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642856 Eric Christensen changed: What|Removed |Added Status|ASSIGNED|VERIFIED Flag|fedora-review? |fedora-review+ --- Comment #8 from Eric Christensen 2010-10-21 08:28:01 EDT --- Okay. Name changed to be inline with established rules. Spelling errors remedied. Source1 clarified and is good with existing rules. I'm happy. Review complete. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 627180] Review Request: django-paste - dpaste is a code pastebin application using Django.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=627180 --- Comment #7 from David Riches 2010-10-21 07:43:02 EDT --- also, submitted django-tracking : https://bugzilla.redhat.com/show_bug.cgi?id=645354 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645354] Review Request: django-tracking - Django site visitor tracking, including basic blacklisting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645354 --- Comment #1 from David Riches 2010-10-21 07:41:46 EDT --- Koji successful build links: http://koji.fedoraproject.org/koji/taskinfo?taskID=2546526 <- f12 http://koji.fedoraproject.org/koji/taskinfo?taskID=2546528 <- f13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2546524 <- f14 http://koji.fedoraproject.org/koji/taskinfo?taskID=2546530 <- rawhide rpmlint output (spec) django-tracking.spec: W: invalid-url Source0: http://django-tracking.googlecode.com/files/django-tracking-0.2.7.zip HTTP Error 404: Not Found 0 packages and 1 specfiles checked; 0 errors, 1 warnings. (I think this is more to do with rpmlint, as the url works fine in both browser and wget) rpmlint output (src.rpm) django-tracking.src: W: invalid-url Source0: http://django-tracking.googlecode.com/files/django-tracking-0.2.7.zip HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 1 warnings. rpmlint output (rpm) django-tracking.noarch: W: non-standard-dir-in-usr tracking 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Also submitted django-dpate : https://bugzilla.redhat.com/show_bug.cgi?id=627180 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645354] Review Request: django-tracking - Django site visitor tracking, including basic blacklisting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645354 --- Comment #2 from David Riches 2010-10-21 07:42:20 EDT --- typo, s/dpate/dpaste -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645354] New: Review Request: django-tracking - Django site visitor tracking, including basic blacklisting
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: django-tracking - Django site visitor tracking, including basic blacklisting https://bugzilla.redhat.com/show_bug.cgi?id=645354 Summary: Review Request: django-tracking - Django site visitor tracking, including basic blacklisting Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: davi...@ultracar.co.uk QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://dcr226.fedorapeople.org/SPECS/django-tracking.spec SRPM URL: http://dcr226.fedorapeople.org/SRPMS/django-tracking-0.2.7-1.fc13.src.rpm Description: django-tracking is a simple attempt at keeping track of visitors to Django-powered Web sites. It also offers basic blacklisting capabilities -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642985] Review Request: rubygem-timecop - Provides a unified method to mock Time.now, Date.today in a single call
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642985 --- Comment #3 from Mamoru Tasaka 2010-10-21 06:58:26 EDT --- By the way for bug 640608: It seems that $ ruby -e 'otime = Time.now ; sleep(1) ; ctime=Time.now ; puts ctime - otime' will call system calls: gettimeofday -> select -> gettimeofday. However it seems that select() sometimes sleeps less time than requested: http://lkml.org/lkml/2008/8/29/232 ... which seems fixed in kernel 2.6.28. So RHEL5 host may suffer from this issue? (and perl seems to be using nanosleep instead of select) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642985] Review Request: rubygem-timecop - Provides a unified method to mock Time.now, Date.today in a single call
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=642985
--- Comment #2 from Mamoru Tasaka 2010-10-21
06:52:13 EDT ---
Well,
When I try on my F-14 machine:
[tasa...@localhost ~]$ uname -a
Linux localhost.localdomain 2.6.35.6-43.fc14.i686 #1 SMP Wed Oct 13 21:36:03
UTC 2010 i686 i686 i386 GNU/Linux
[tasa...@localhost ~]$ rpm -q ruby
ruby-1.8.7.302-1.fc14.i686
I see one more failure (I am not using Xen or so)
$ ruby -I../lib ./test_time_stack_item.rb
Loaded suite ./test_time_stack_item
Started
FFF.F...
Finished in 0.113762 seconds.
1) Failure:
test_compute_dst_adjustment_for_dst_to_dst(TestTimeStackItem)
[./test_time_stack_item.rb:100]:
precondition.
is not true.
2) Failure:
test_compute_dst_adjustment_for_dst_to_non_dst(TestTimeStackItem)
[./test_time_stack_item.rb:118]:
precondition.
is not true.
3) Failure:
test_compute_dst_adjustment_for_non_dst_to_dst(TestTimeStackItem)
[./test_time_stack_item.rb:128]:
precondition.
is not true.
4) Failure:
test_datetime_for_dst_to_non_dst(TestTimeStackItem)
[./test_time_stack_item.rb:139]:
<#> expected but was
<#>.
I guess the first 3 test failures are because Japan does not use
DST at all (currently uses JST = UTC + 9 hour all year) so
for example
$ ruby -e "require 'time' ; puts Time.now.dst?"
always shows "false" (on Japan). Note that the line 100
in test_time_stack_item.rb says:
-
100 assert Time.now.dst?, "precondition"
-
4th test failure occurs on the line 139 in test_time_stack_item.rb:
132# Ensure DateTime's handle changing DST properly
133def test_datetime_for_dst_to_non_dst
134 Timecop.freeze(DateTime.parse("2009-12-1 00:38:00 -0500"))
135 t = DateTime.parse("2009-10-11 00:00:00 -0400")
136 tsi = Timecop::TimeStackItem.new(:freeze, t)
137 assert_date_times_equal t, tsi.datetime
138 # verify Date also 'moves backward' an hour to change the day
139 assert_equal Date.new(2009, 10, 10), tsi.date
140end
I have not investigated here yet, however I think the failure on
this also related to timezone issue.
So I am not sure if the test failures are really related to
bug 640608. It seems that you have to set TZ or DST setting or so to make
these tests pass (I guess simply disabling these tests is simpler).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645321] New: Review Request: python-orange - Orange data mining library for python
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: python-orange - Orange data mining library for python https://bugzilla.redhat.com/show_bug.cgi?id=645321 Summary: Review Request: python-orange - Orange data mining library for python Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: mrlhwlibe...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://helloworld1.fedorapeople.org/python-orange.spec SRPM URL: http://helloworld1.fedorapeople.org/python-orange-2.0-0.1.fc14.src.rpm Description: Open source data visualization and analysis for novice and experts. Data mining through visual programming or Python scripting. Components for machine learning. Extensions for bioinformatics and text mining. Packed with features for data analytics -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 625602] Review Request:libbluray - Library to access Blu-Ray disks for video playback
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=625602
--- Comment #10 from Xavier Bachelot 2010-10-21 05:20:34
EDT ---
(In reply to comment #9)
> [ ? ] MUST: rpmlint must be run on every package
> $ rpmlint RPMS/x86_64/libbluray-*
> ~/RPMS/SRPMS/libbluray-0.1-0.1.20100819.fc13.src.rpm
> libbluray.x86_64: W: spelling-error %description -l en_US bluray -> blurry,
> blurt, blurb
> libbluray.x86_64: W: spelling-error %description -l en_US embeddable ->
> embedding, embedded, shreddable
> libbluray.x86_64: W: spelling-error %description -l en_US mplayer -> player, m
> player, mp layer
> libbluray.x86_64: W: spelling-error %description -l en_US vlc -> vac, voc,
> Vlad
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm /usr/lib/debug 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/libbluray/bdj/native 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/libbluray/bdnav 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/libbluray/hdmv 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/libbluray/decoders 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/util 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/libbluray 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/libbluray/bdj 0775L
> libbluray-debuginfo.x86_64: E: non-standard-dir-perm
> /usr/src/debug/libbluray-20100819/src/file 0775L
> libbluray.src: W: spelling-error %description -l en_US bluray -> blurry,
> blurt,
> blurb
> libbluray.src: W: spelling-error %description -l en_US embeddable ->
> embedding,
> embedded, shreddable
> libbluray.src: W: spelling-error %description -l en_US mplayer -> player, m
> player, mp layer
> libbluray.src: W: spelling-error %description -l en_US vlc -> vac, voc, Vlad
> libbluray.src:14: W: macro-in-comment %Y
> libbluray.src:14: W: macro-in-comment %m
> libbluray.src:14: W: macro-in-comment %d
> libbluray.src:14: W: macro-in-comment %Y
> libbluray.src:14: W: macro-in-comment %m
> libbluray.src:14: W: macro-in-comment %d
> libbluray.src: W: invalid-url Source0: libbluray-20100819.tar.bz2
> 4 packages and 0 specfiles checked; 10 errors, 15 warnings.
>
> Can you look into the debuginfo errors? not sure if they need to be
> fixed or not. Regarding the macros-in-comment warning, can probably
> ignore that, as well the spelling-error's.
>
I'll look into the perms on the debuginfo, but this is likely coming from the
tarball generation.
> [ ? ] MUST: The sources used to build the package must match the upstream
> source, as provided in the spec URL. Reviewers should use md5sum for
> this task. If no upstream URL can be specified for this package,
> please see the Source URL Guidelines for how to deal with this.
> Can't test the MD5 checksums because the git command will check out
> a different version of the code than the one uploaded in the SRPM,
> unless the git command in the spec uses the same date as
> %{tarball_date}. Make sure that %{tarball_date} is adjusted
> correctly at the time of checkin.
>
I will rework this part to use the commit hash rather than the date. I'll also
fix the release tag to include the commit hash (at least the start of it), as
per the guideline on pre-releases.
> [ ? ] MUST: Static libraries must be in a -static package.
> Seems that generating a static package is optional, is this intentional?
>
Yes, this is intentional. Static libs are only needed to build some of the
small test programs that are included (but not built nor installed by default
Makefile).
> [ x ] SHOULD: The reviewer should test that the package functions as
> described. A package should not segfault instead of running, for
> example.
> xbmc (from RPM Fusion) correctly links against libbluray, don't have
> discs to test, unfortunately.
>
You can probably test with the BD iso from the link in comment #3.
Thanks a lot for the review.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645288] Review Request: erlang-xmlrpc - HTTP 1.1 compliant XML-RPC library for Erlang
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645288
--- Comment #2 from Peter Lemenkov 2010-10-21 05:18:37 EDT
---
rpmlint:
sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/ppc/erlang-xmlrpc-1.13-1.fc12.ppc.rpm
erlang-xmlrpc.ppc: E: no-binary
erlang-xmlrpc.ppc: W: only-non-binary-in-usr-lib
erlang-xmlrpc.ppc: W: file-not-utf8 /usr/share/doc/erlang-xmlrpc-1.13/LICENSE
1 packages and 0 specfiles checked; 1 errors, 2 warnings.
sulaco ~/rpmbuild/SPECS:
The first two messages indicating that erlang module is installed into
arch-specific directory (%{_libdir}) while it consists from arch-independent
data. Unfortunately this is how Erlang/OTP is designed.
The last warning exists because I believe that touching original project's
licenses is a generally bad idea. Anyway it doesn't harm anything.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645288] Review Request: erlang-xmlrpc - HTTP 1.1 compliant XML-RPC library for Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645288 --- Comment #1 from Peter Lemenkov 2010-10-21 05:14:42 EDT --- Koji scratch build for F-14 http://koji.fedoraproject.org/koji/taskinfo?taskID=2546432 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645288] New: Review Request: erlang-xmlrpc - HTTP 1.1 compliant XML-RPC library for Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: erlang-xmlrpc - HTTP 1.1 compliant XML-RPC library for Erlang https://bugzilla.redhat.com/show_bug.cgi?id=645288 Summary: Review Request: erlang-xmlrpc - HTTP 1.1 compliant XML-RPC library for Erlang Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: lemen...@gmail.com QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec URL: http://peter.fedorapeople.org/erlang-xmlrpc.spec SRPM URL: http://peter.fedorapeople.org/erlang-xmlrpc-1.13-1.fc12.src.rpm Description: HTTP 1.1 compliant XML-RPC library for Erlang -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532590 Peter Lemenkov changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #20 from Peter Lemenkov 2010-10-21 04:35:58 EDT --- Great. Now I don't see any other blocking issues so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635363] Review Request: nodejs-xmlrpc-c - XMLRPC library for v8 JavaScript
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635363 Lubomir Rintel changed: What|Removed |Added Summary|Review Request: |Review Request: |node-xmlrpc-c - XMLRPC |nodejs-xmlrpc-c - XMLRPC |library for v8 JavaScript |library for v8 JavaScript --- Comment #1 from Lubomir Rintel 2010-10-21 04:33:42 EDT --- SPEC: http://v3.sk/~lkundrak/SPECS/nodejs-xmlrpc-c.spec SRPM: http://v3.sk/~lkundrak/SRPMS/nodejs-xmlrpc-c-0-2.20101213git.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644335] Review Request: rubygem-mustache - Mustache is a framework-agnostic way to render logic-free views
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644335 Mamoru Tasaka changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|nob...@fedoraproject.org|mfoj...@redhat.com QAContact|mfoj...@redhat.com |extras...@fedoraproject.org -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 532590] Review Request: yaws - Web server for dynamic content written in Erlang
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=532590 --- Comment #19 from Lubomir Rintel 2010-10-21 04:31:53 EDT --- SPEC: http://v3.sk/~lkundrak/SPECS/yaws.spec SRPM: http://v3.sk/~lkundrak/SRPMS/yaws-1.89-2.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 635359] Review Request: nodejs-libxmljs - LibXML bindings for Google's v8 JavaScript engine
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=635359 Lubomir Rintel changed: What|Removed |Added Summary|Review Request: |Review Request: |node-libxmljs - LibXML |nodejs-libxmljs - LibXML |bindings for Google's v8|bindings for Google's v8 |JavaScript engine |JavaScript engine --- Comment #1 from Lubomir Rintel 2010-10-21 04:30:58 EDT --- SPEC: http://v3.sk/~lkundrak/SPECS/nodejs-libxmljs.spec SRPM: http://v3.sk/~lkundrak/SRPMS/nodejs-libxmljs-0.4.1-1.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 642572] Review Request: rubygem-commander - The complete solution for Ruby command-line executable
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=642572 --- Comment #2 from Michal Fojtik 2010-10-21 04:22:59 EDT --- (In reply to comment #1) > Some notes: > > * License > - For this pacakge license tag should be "MIT". Fixed. > > * Redundant version dependency > - Please remove redundant explicit version dependency > For currently supported Fedora branches, all ">= foo" parts > in current spec file are not needed. Fixed > ! Also "(Build)Requires: ruby" is redundant for this > package (dependency for rubygems already exists) Dependency removed == 4.0.3-3 == Spec URL: http://mifo.sk/RPMS/rubygem-commander.spec SRPM URL: http://mifo.sk/RPMS/rubygem-commander-4.0.3-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=582894 Daiki Ueno changed: What|Removed |Added Flag||fedora-cvs? --- Comment #8 from Daiki Ueno 2010-10-21 04:20:44 EDT --- Thanks for the review, Parag. New Package SCM Request === Package Name: emacs-common-ddskk Short Description: Daredevil SKK - Simple Kana to Kanji conversion program for Emacs Owners: ueno Branches: f14 f13 InitialCC: i18n-team -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645277] Review Request: puddletag - Feature rich, easy to use tag editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=645277 Terje Røsten changed: What|Removed |Added Depends on||495324 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 645277] New: Review Request: puddletag - Feature rich, easy to use tag editor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: puddletag - Feature rich, easy to use tag editor https://bugzilla.redhat.com/show_bug.cgi?id=645277 Summary: Review Request: puddletag - Feature rich, easy to use tag editor Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: terje...@phys.ntnu.no QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora spec: http://terjeros.fedorapeople.org/puddletag/puddletag.spec srpm: http://terjeros.fedorapeople.org/puddletag/puddletag-0.9.6-1.fc12.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2546420 Description: Puddletag is a audio tag editor similar program Mp3tag. Unlike most taggers, it uses a spreadsheet-like layout so that all the tags you want to edit by hand are visible and easily editable. The usual tag editor features are supported like extracting tag information from filenames, renaming files based on their tags by using patterns (that you define, not crappy, uneditable ones). Then there're Functions, which can do things like replace text, trim, change the case of tags, etc. Actions can automate repetitive tasks. You can import your QuodLibet library, lookup tags using MusicBrainz, FreeDB or Amazon (though it's only good for cover art) and more. Supported formats: ID3v1, ID3v2 (mp3), MP4 (mp4, m4a, etc.), VorbisComments (ogg, flac), Musepack (mpc), Monkey's Audio (.ape) and WavPack (wv). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 644883] Review Request: django-simple-captcha - Django application to add captcha images to any Django form.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644883 David Riches changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 582894] Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=582894
Parag AN(पराग) changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Parag AN(पराग) 2010-10-21 03:08:38 EDT
---
I don't think you need all the ChangeLog.* files. Just add ChangeLog file.
for macros, good to use curly brackets.
another issue directory ownership. This package need to own following directory
%{_xemacs_sitepkgdir}/etc
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
