[Bug 652403] Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652403

Marek Goldmann  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #8 from Marek Goldmann  2010-11-27 02:44:26 
EST ---
Thanks!

New Package SCM Request
===
Package Name:  rubygem-boxgrider-build-rpm-based-os-plugin
Short Description: Files required to build appliances based on RPMs
Owners:goldmann
Branches:  f13 f14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654374

Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de

--- Comment #11 from Ralf Corsepius  2010-11-27 01:20:56 
EST ---
Not a formal review, just some comments.

* I am not sure whether bundling this sample-map is a good idea, because most
users will want to remove it and replace it with a map which suites their needs

i.e. I'd propose to either
* entirely remove this map from this package.
* package it as a separate package.
* package it as a "noarch" subpackage of navit.


* I am observing an inpressive amount of warnings when running navit, similar
to this one:
navit:displayitem_draw:failed to load icon '/usr/share/navit/xpm/parking.png'


* Your package contains a larger number of *la's.
Are they really needed? I haven't checked, but I am having doubts.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

Eric Christensen  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #15 from Eric Christensen  2010-11-26 
22:26:20 EST ---
New Package SCM Request
===
Package Name: tudu
Short Description: A simple, command line interface to do list application
Owners: sparks
Branches: f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #14 from Kevin Fenzi  2010-11-26 21:59:03 EST ---
ok, I don't see any further blockers here... You should contact upstream about
the Makefile changes here and ask them to fix things so you don't need patches
moving forward. :) 

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599597] Review Request: amule - The all-platform eMule p2p client

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599597

Chen Lei  changed:

   What|Removed |Added

   Keywords||Reopened
 Status|CLOSED  |ASSIGNED
 Resolution|NOTABUG |

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

--- Comment #13 from Eric Christensen  2010-11-26 
20:50:32 EST ---
SPEC: http://sparks.fedorapeople.org/Packages/tudu/tudu.spec

SRPM: http://sparks.fedorapeople.org/Packages/tudu/tudu-0.7-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518546] Review Request: libva - VAAPI video playback acceleration

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

--- Comment #68 from Adam Williamson  2010-11-26 17:23:15 
EST ---
my suggestion is to have everything in the fedoraverse (so, mostly fusion
stuff) built against libva-sds and just have libva1 for chen's desired purpose
(testing external packages that are built against that libva version).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

--- Comment #12 from Kevin Fenzi  2010-11-26 17:18:40 EST ---
Eric: Care to post a final package with all the changes and changelogs, then we
can finish this up. ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518546] Review Request: libva - VAAPI video playback acceleration

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

--- Comment #67 from Nicolas Chauvet (kwizart)  2010-11-26 
17:16:54 EST ---
Since these two libva packages are binary incompatible, doesn't that mean two
FFmpeg built with one and the other ?
And then same for several vaapi capable players that need to be built with the
libva matching the ffmpeg built they rely upon, so it doesn't crash at runtime
because of one or another missing symbol ?

I don't think that's reliable at all.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657591] Review Request: rubygem-isolate - Very simple RubyGems sandbox

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657591

Mamoru Tasaka  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #3 from Mamoru Tasaka  2010-11-26 
16:34:57 EST ---
(In reply to comment #2)
> Package:
> * When requiring 'isolate/rake' (via README):

- Well, lib/isolate/rake.rb is perhaps a "plugin" for rake,
  and actually:

[tasa...@localhost ~]$ ruby -rubygems -e 'require "isolate/rake"'
/usr/lib/ruby/gems/1.8/gems/isolate-3.0.0/lib/isolate/rake.rb:1: undefined
method `namespace' for main:Object (NoMethodError)
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
`gem_original_require'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
 from -e:1
[tasa...@localhost ~]$ ruby -rubygems -e 'require "rake" ; require
"isolate/rake"'
[tasa...@localhost ~]$ 

  So maybe it is better that lib/isolate/rake.rb contains "require 'rake'"
  at the top, however I guess this is okay for now.


> Otherwise - looks good!
> 
> 
>This package (rubygem-isolate) is APPROVED by goldmann
> 

Thank you!

New Package SCM Request
===
Package Name:  rubygem-isolate
Short Description: Very simple RubyGems sandbox
Owners:mtasaka
Branches:  f13 f14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652403] Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652403

Mamoru Tasaka  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #7 from Mamoru Tasaka  2010-11-26 
16:13:49 EST ---
No blockers, approving.

--
This package (rubygem-boxgrider-build-rpm-based-os-plugin)
is APPROVED by mtasaka
--

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591447] Review Request: R-affydata - Affymetrix data for demonstration purpose

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591447

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|R-affydata-1.11.10-1.fc14   |R-affydata-1.11.10-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591447] Review Request: R-affydata - Affymetrix data for demonstration purpose

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591447

--- Comment #9 from Fedora Update System  2010-11-26 
16:11:20 EST ---
R-affydata-1.11.10-1.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591447] Review Request: R-affydata - Affymetrix data for demonstration purpose

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591447

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||R-affydata-1.11.10-1.fc14
 Resolution||ERRATA
Last Closed||2010-11-26 16:08:09

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 526805] Review Request: lua-loop - Class models for Lua

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526805

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|lua-loop-2.3-0.2.beta.fc13  |lua-loop-2.3-0.2.beta.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 526805] Review Request: lua-loop - Class models for Lua

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526805

--- Comment #12 from Fedora Update System  
2010-11-26 16:07:22 EST ---
lua-loop-2.3-0.2.beta.fc14 has been pushed to the Fedora 14 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591447] Review Request: R-affydata - Affymetrix data for demonstration purpose

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591447

--- Comment #8 from Fedora Update System  2010-11-26 
16:08:04 EST ---
R-affydata-1.11.10-1.fc14 has been pushed to the Fedora 14 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 526805] Review Request: lua-loop - Class models for Lua

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526805

--- Comment #11 from Fedora Update System  
2010-11-26 16:05:17 EST ---
lua-loop-2.3-0.2.beta.fc13 has been pushed to the Fedora 13 stable repository. 
If problems still persist, please make note of it in this bug report.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652396] Review Request: rubygem-boxgrinder-core - Core files required by BoxGrinder

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652396

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA

--- Comment #22 from Fedora Update System  
2010-11-26 16:05:40 EST ---
rubygem-boxgrinder-core-0.1.3-3.fc14 has been pushed to the Fedora 14 testing
repository.  If problems still persist, please make note of it in this bug
report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-boxgrinder-core'.  You
can provide feedback for this update here:
https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.3-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 526805] Review Request: lua-loop - Class models for Lua

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=526805

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||lua-loop-2.3-0.2.beta.fc13
 Resolution||ERRATA
Last Closed||2010-11-26 16:05:23

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 656938] Review Request: python-shapely - Geometric objects, predicates, and operations

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656938

Rex Dieter  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Rex Dieter  2010-11-26 16:01:03 EST 
---
* rpmlint clean

* sources: OK
$ md5sum *.gz
2cd0bab00a2c39d1ae6cd9ed648db904  Shapely-1.2.7.tar.gz

* naming ok

* license ok

* installs/runs ok (performed only very basic tests)

* %files ok  (but see next...)

* SHOULD: please document why
%exclude %{_bindir}/intersect.py
%exclude %{_bindir}/dissolve.py

* SHOULD: consider adding a %check section with:
$ python setup.py test
fwiw, I see 3 failures on my f14 box (once I installed numpy), though at least
one is due to some slight rounding differences.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657591] Review Request: rubygem-isolate - Very simple RubyGems sandbox

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657591

Marek Goldmann  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Marek Goldmann  2010-11-26 15:56:27 
EST ---
Spec file:

* Micro issue: BR: rubygems is not required

Package:

* When requiring 'isolate/rake' (via README):

irb(main):001:0> require 'rubygems'
=> true
irb(main):002:0> require 'isolate/rake'
NoMethodError: undefined method `namespace' for main:Object
 from /usr/lib/ruby/gems/1.8/gems/isolate-3.0.0/lib/isolate/rake.rb:1
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in
`gem_original_require'
 from /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:36:in `require'
 from (irb):2
 from :0

I confirmed it with the 3.0.0 gem alone (uninstalled your package). If you
require 'isolate/now' you still have the Rake tasks available. This is an
upstream issue. Most probably README is outdated. It doesn't prevent to package
it.

Otherwise - looks good!


   This package (rubygem-isolate) is APPROVED by goldmann


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654374

--- Comment #10 from viji  2010-11-26 15:57:12 EST 
---
Updated the packages, please review.

Spec URL: http://viji.fedorapeople.org/SPECS/navit.spec
SRPM URL : http://viji.fedorapeople.org/SRPMS/navit-0.2.0-1.fc14.src.rpm

F14 Scratch
---
http://koji.fedoraproject.org/koji/taskinfo?taskID=2628765

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 592772] Review Request: drobo-utils - Utilities for managing Drobo storage systems

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592772

--- Comment #4 from Jameson  2010-11-26 15:48:54 EST ---
Without the CFLAGS line, I get:
running install_scripts
error: cannot copy tree 'build/scripts-2.7': not a directory

Could this actually be compiling something?  The author said that it no longer
does.  This is my first Python package, so some of it is a bit strange.  I
think I have everything else cleaned up.

New SRPM:  http://imntreal.fedorapeople.org/drobo-utils-0.6.2.2-6.fc14.src.rpm
New SPEC:  http://imntreal.fedorapeople.org/drobo-utils.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518546] Review Request: libva - VAAPI video playback acceleration

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

--- Comment #66 from Adam Williamson  2010-11-26 15:45:27 
EST ---
possible, yeah. I still kind of favour the Two Package Solution though. What's
the advantage of your approach over that?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 656938] Review Request: python-shapely - Geometric objects, predicates, and operations

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656938

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|rdie...@math.unl.edu
   Flag||fedora-review?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657591] Review Request: rubygem-isolate - Very simple RubyGems sandbox

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657591

Marek Goldmann  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mgold...@redhat.com
 AssignedTo|nob...@fedoraproject.org|mgold...@redhat.com
   Flag||fedora-review?

--- Comment #1 from Marek Goldmann  2010-11-26 15:22:19 
EST ---
Taking this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 436479] Review Request: perl-Net-Amazon-EC2 - Perl interface to the Amazon Elastic Compute Cloud (EC2)

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=436479

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lkund...@v3.sk
   Flag|fedora-cvs+ |fedora-cvs?

--- Comment #6 from Lubomir Rintel  2010-11-26 15:13:21 EST ---
Package Change Request
==
Package Name: perl-Net-Amazon-EC2
New Branches: el6
Owners: lkundrak

Fedora maintainer was asked about willingness to maintain this in EPEL, no
response in 5 days. That might not be much, but I've a looked up a mail from
him about perl-Net-Amazon-S3 (a different but related package) in EPEL 5 and
his response was that he doesn't have much time to take care of it in el5. I
assume this could be a similar situation and proceeded with filing the VCS
request; if it turns out to be false and rrati objects (which is unlikely) it's
easy to switch maintainership to him.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652403] Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652403

--- Comment #6 from Marek Goldmann  2010-11-26 15:16:03 
EST ---
Updated files:

Spec URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/boxgrinder/rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-3.fc15.src.rpm

Koji scratch build for Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2628716

Changelog:

* Fri Nov 26 2010   - 0.0.8-3
- Removed clean section, updated URL, fixed attr for motd.init file

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654374

--- Comment #9 from viji  2010-11-26 15:12:28 EST ---
I have contacted the upstream developers and they are asking re-licensing the
same to GPLv2+ would be sufficient or not..

There are some compiling issues, working on it, will be updating the new
package soon.

Thank you so much for your support

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 656938] Review Request: python-shapely - Geometric objects, predicates, and operations

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=656938

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@math.unl.edu

--- Comment #1 from Rex Dieter  2010-11-26 15:11:24 EST 
---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2628711

$ rpmlint *.rpm python-shapely
python-shapely.src: W: no-buildroot-tag
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

--- Comment #16 from hannes  2010-11-26 15:08:28 
EST ---
Ok, once again ;-)
SRPM-URL:
http://hannes.fedorapeople.org/freemind/freemind-0.9.0-0.6.rc10.fc14.src.rpm
SPEC-URL:
http://hannes.fedorapeople.org/freemind/freemind.spec

It finally builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2628703

Yeah!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654374

--- Comment #8 from viji  2010-11-26 14:38:23 EST ---
I have contacted the upstream developers and they are asking re-licensing the
same to GPLv2+ would be sufficient or not..

There are some compiling issues, working on it, will be updating the new
package soon.

Thank you so much for your support

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 638590] Review Request: freemind - a mind-mapping software written in Java

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=638590

--- Comment #15 from hannes  2010-11-26 14:26:11 
EST ---
Ok, now I just added jibx as requirement and tried to fix also the other
things.
Hope this is everything. :-)
SRPM-URL:
http://hannes.fedorapeople.org/freemind/freemind-0.9.0-0.5.rc10.fc14.src.rpm
SPEC-URL:
http://hannes.fedorapeople.org/freemind/freemind.spec
rpmlint output:
rpmlint ../RPMS/noarch/freemind-0.9.0-0.5.rc10.fc14.noarch.rpm 
freemind.noarch: W: spelling-error %description -l en_US refactor -> redactor,
reactor, refractor
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-gvt.jar
/usr/share/java/batik/batik-gvt.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/SimplyHTML/gnu-regexp-1.1.4.jar
/usr/share/java/gnu-regexp-1.1.4.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/commons-lang-2.0.jar /usr/share/java/commons-lang.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-ext.jar
/usr/share/java/batik/batik-ext.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/lib/junit.jar
/usr/share/java/junit.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-gui-util.jar
/usr/share/java/batik/batik-gui-util.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-script.jar
/usr/share/java/batik/batik-script.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-awt-util.jar
/usr/share/java/batik/batik-awt-util.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-bridge.jar
/usr/share/java/batik/batik-bridge.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/lib/forms-1.0.5.jar
/usr/share/java/jgoodies-forms.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-extension.jar
/usr/share/java/batik/batik-extension.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-swing.jar
/usr/share/java/batik/batik-swing.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-dom.jar
/usr/share/java/batik/batik-dom.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/avalon-framework.jar
/usr/share/java/avalon-framework.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/lib/jibx/bcel.jar
/usr/share/java/bcel.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-xml.jar
/usr/share/java/batik/batik-xml.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/jarbundler-2.0.0.jar /usr/share/java/jarbundler.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-transcoder.jar
/usr/share/java/batik/batik-transcoder.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/lib/jibx/xpp3.jar
/usr/share/java/xpp3.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/jibx/commons-logging-1.0.4.jar
/usr/share/java/commons-logging.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/xml-apis.jar
/usr/share/java/xml-commons-apis-1.4.01.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-parser.jar
/usr/share/java/batik/batik-parser.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-util.jar
/usr/share/java/batik/batik-util.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/script/groovy-all-1.5.6.jar
/usr/share/java/groovy.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/SimplyHTML/SimplyHTML.jar
/usr/share/java/SimplyHTML/SimplyHTML.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/jibx/jaxme-js-0.3.jar /usr/share/java/jaxme/jaxmejs.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/pdf-transcoder.jar
/usr/share/java/pdf-transcoder.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-svg-dom.jar
/usr/share/java/batik/batik-svg-dom.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/lib/jibx/jibx-bind.jar
/usr/share/java/jibx/bind-1.2.2.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/plugins/help/jhall.jar
/usr/share/java/javahelp2.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-css.jar
/usr/share/java/batik/batik-css.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-squiggle.jar
/usr/share/java/batik-squiggle.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/xerces_2_5_0.jar /usr/share/java/xerces-j2.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/lib/jibx/log4j-1.2.8.jar /usr/share/java/log4j.jar
freemind.noarch: W: dangling-symlink /usr/share/freemind/plugins/svg/js.jar
/usr/share/java/js.jar
freemind.noarch: W: dangling-symlink
/usr/share/freemind/plugins/svg/batik-svggen.jar
/usr/share/java/batik/batik-svggen.jar
freemind.noarch: W: dangling-symlin

[Bug 646139] Review Request: KXStitch - tool that creates cross stitch patterns

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646139

Golo Fuchert  changed:

   What|Removed |Added

   Flag||fedora-cvs?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 646139] Review Request: KXStitch - tool that creates cross stitch patterns

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646139

--- Comment #11 from Golo Fuchert  2010-11-26 14:17:03 EST 
---
New Package SCM Request
===
Package Name: kxstitch
Short Description: Program to create cross stitch patterns
Owners: golfu
Branches: f13 f14
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518546] Review Request: libva - VAAPI video playback acceleration

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

--- Comment #65 from Nicolas Chauvet (kwizart)  2010-11-26 
14:00:34 EST ---
Would it be possible to keep the sd version for current fedora and import the
1.x only for rawhide ? 
That way, work can be done to enable moblin based on 1.x.
Even if psb isn't ready for the f15 timeline, we could forward these users to a
later release, targeting f16 if they want that functionality restored.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 518546] Review Request: libva - VAAPI video playback acceleration

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518546

--- Comment #64 from Adam Williamson  2010-11-26 12:49:25 
EST ---
so far it looks like getting libva 1.x to fly with psb is a no-go, which kind
of leaves us in an awkward position - honestly I packaged libva for the purpose
of working with psb and I'm not that interested in packaging 1.x if it won't
work with psb.

We could have two packages, I guess: libva and libva-sds or something like
that. If all you need the upstream version for is to test external packages
against, we could build Fedora / Fusion packages against the sds libva, and
that would probably make everyone happyish?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652403] Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652403

--- Comment #4 from Mamoru Tasaka  2010-11-26 
12:50:22 EST ---
By the way I would appreciate it if you have some time to review
my review request (bug 657591)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652403] Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652403

Mamoru Tasaka  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|mtas...@ioa.s.u-tokyo.ac.jp
   Flag||fedora-review?

--- Comment #3 from Mamoru Tasaka  2010-11-26 
12:49:42 EST ---
Some notes:

! Source
---
a440ee244f272cfa1a2ef680b8beb199 
Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem
e6d7d2503e9655bb36f73a1ff881cea4 
rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem
---
  - The source in your srpm does not match the one I could download
from the URL written as Source0. Would you explain why?

! No longer needed stuff
  - %clean section is no longer needed on Fedora:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

* rpmlint issue
---
rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script
/usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init
0664L /bin/sh
---
  - This warning comes because this script does not have executable permission
while the script has shebang. While I think this script need not have
executable
permission because this file seems something like a template, however I
think
0644 permission is more proper.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652403] Review Request: rubygem-boxgrinder-build-rpm-based-os-plugin - Files required to build appliances based on RPMs

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652403

--- Comment #5 from Marek Goldmann  2010-11-26 13:03:32 
EST ---
(In reply to comment #3)
> Some notes:
> 
> ! Source
> ---
> a440ee244f272cfa1a2ef680b8beb199 
> Downloaded/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem
> e6d7d2503e9655bb36f73a1ff881cea4 
> rubygem-boxgrinder-build-rpm-based-os-plugin-0.0.8-2.fc15.src/boxgrinder-build-rpm-based-os-plugin-0.0.8.gem
> ---
>   - The source in your srpm does not match the one I could download
> from the URL written as Source0. Would you explain why?

The src.rpm uses a regenerated gem, but from the same source as pushed to
rubygems.org. When checking into git I'm overriding the .gem with the proper
version (from rubygems.org). Currently - all my src.rpm have this issue. I'll
change the way I build my src.rpm for review for the next submissions.

Sorry for confusion!

> ! No longer needed stuff
>   - %clean section is no longer needed on Fedora:
> https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

Going to remove it, thanks!

> * rpmlint issue
> ---
> rubygem-boxgrinder-build-rpm-based-os-plugin.noarch: E: non-executable-script
> /usr/lib/ruby/gems/1.8/gems/boxgrinder-build-rpm-based-os-plugin-0.0.8/lib/boxgrinder-build-rpm-based-os-plugin/src/motd.init
> 0664L /bin/sh
> ---
>   - This warning comes because this script does not have executable permission
> while the script has shebang. While I think this script need not have
> executable
> permission because this file seems something like a template, however I
> think
> 0644 permission is more proper.

Yes this is just a template.

I'll post updated spec and review your package shortly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599597] Review Request: amule - The all-platform eMule p2p client

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599597

--- Comment #5 from Martin Gieseking  2010-11-26 
12:17:54 EST ---
OK, if this was the intention, then sorry for closing the review request. Chen
Lei, please reopen this ticket if you're still planning to move amule from
rpmfusion to Fedora.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599597] Review Request: amule - The all-platform eMule p2p client

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599597

--- Comment #4 from Felix Kaechele  2010-11-26 12:12:29 EST 
---
Well I think the point was moving aMule to Fedora as there's no reason to have
it in RPMFusion anymore. It used to be in RPMFusion due to cryptopp being
licensed incompatibly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657591] New: Review Request: rubygem-isolate - Very simple RubyGems sandbox

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: rubygem-isolate - Very simple RubyGems sandbox

https://bugzilla.redhat.com/show_bug.cgi?id=657591

   Summary: Review Request: rubygem-isolate - Very simple RubyGems
sandbox
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: mtas...@ioa.s.u-tokyo.ac.jp
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL:
http://mtasaka.fedorapeople.org/Review_request/rubygem-isolate/rubygem-isolate.spec
SRPM URL:
http://mtasaka.fedorapeople.org/Review_request/rubygem-isolate/rubygem-isolate-3.0.0-1.fc.src.rpm
Description: 
Isolate is a very simple RubyGems sandbox. It provides a way to
express and automatically install your project's Gem dependencies.

Koji scratch build
for F-15: http://koji.fedoraproject.org/koji/taskinfo?taskID=2628287
for F-14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2628289

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648987] Review Request: python-smbc - Python bindings for libsmbclient API from Samba

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648987

Jiri Popelka  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2010-11-26 12:01:56

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648986] Review Request: python-cups - Python bindings for CUPS

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648986

Jiri Popelka  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2010-11-26 12:01:52

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 544016] Review Request: cbpolicyd - Postfix anti-spam policy server

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544016

--- Comment #7 from Chris St. Pierre  2010-11-26 
11:26:42 EST ---
I've changed jobs since entering this review request and I no longer work with
Policyd.  Unless someone else wants to take this on it's probably safe to close
it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 562226] Review Request: ccl - Free Common Lisp implementation

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562226

--- Comment #15 from Alexander Kahl  2010-11-26 11:20:10 EST 
---
Spec URL: http://akahl.fedorapeople.org/ccl/ccl.spec
SRPM URL: http://akahl.fedorapeople.org/ccl/ccl-1.5-3.fc14.src.rpm

Changes:
- removed %%clean section
- removed explicit BuildRoot
- removed spurious executable bit from
  contrib/krueger/InterfaceProjects/Utilities/date.lisp
- added ExcludeArch ppc, ppc64

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 562226] Review Request: ccl - Free Common Lisp implementation

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562226

--- Comment #14 from Alexander Kahl  2010-11-26 11:11:24 EST 
---
Hey Jason, let's go:

(In reply to comment #12)
>   ccl.x86_64: W: executable-stack /usr/lib64/ccl/lx86cl64
> This implies that there will be selinux problems.
Sure? I can execute the kernel in enforcing mode without any prior policy
tampering :)

>   ccl.x86_64: E: non-standard-executable-perm /usr/lib64/ccl/lx86cl64 0775L
> I think this is due to a mock bug and is specific to some buildsystems; if it
> doesn't happen for you then it should probably be ignored.
Yeah, so it seems - local building doesn't seem to cause this.

>   ccl.x86_64: W: no-manual-page-for-binary ccl
> Nice to have a manual page for command line applications.  Not essential,
> though.
True.

>   ccl-contrib.x86_64: W: only-non-binary-in-usr-lib
>   ccl-examples.x86_64: W: only-non-binary-in-usr-lib
> Why aren't these noarch, with the content in /usr/share?  
Because it's loadable examples / contributed code with hardwired load paths in
the heap image, please see `ccl-1.5/linuxx86/ccl/l1-pathnames.lisp', global
variable *module-search-path*. 

> Or better yet, why
> are they not documentation instead?  
I could inject some code into the image that modifies the paths.. but loading
files from %_docdir feels wrong somehow.

%{_datadir}/ccl should be the way to go as %{_datadir}/common-lisp/source is CL
implementation-independent. 
Please share your thoughts - is using ccl's home in %_libdir really that
problematic?

> Also, are the examples actually useful? 
The FFI examples, definitely. The gtk clock looks ugly but works... what do you
actually mean by "useful"? :)

> The cocoa stuff is apple-specific, is it not?
Hmm right, I could leave that out if you want - have a note about this in >>
README.Fedora?

>   ccl-contrib.x86_64: W: devel-file-in-non-devel-package
>/usr/lib64/ccl/contrib/krueger/InterfaceProjects/Lisp
>IB Plugins/LispControllerPlugin/LispControllerPlugin.h
>   ccl-contrib.x86_64: W: devel-file-in-non-devel-package
>/usr/lib64/ccl/contrib/krueger/InterfaceProjects/Lisp
>IB Plugins/LispControllerPlugin/LispControllerInspector.h
>   ccl-contrib.x86_64: W: devel-file-in-non-devel-package
>/usr/lib64/ccl/contrib/krueger/InterfaceProjects/Lisp
>IB Plugins/LispControllerPlugin/LispController.h
>   ccl-examples.x86_64: W: devel-file-in-non-devel-package
>   
> /usr/lib64/ccl/examples/FFI/Allocating-foreign-data-on-the-lisp-heap/ptrtest.c
>   ccl-examples.x86_64: W: devel-file-in-non-devel-package
>/usr/lib64/ccl/examples/FFI/Using-basic-calls-and-types/typetest.c
> These are examples, so I expect this is OK, but see the previous complaint.
The C source files get compiled and their results directly accessed from the
lisp ones (-> FFI = Foreign Function Interface), moving them where they
probably belong (%_datadir) won't make the warnings go away anyway.

>   ccl-contrib.x86_64: E: script-without-shebang
>/usr/lib64/ccl/contrib/krueger/InterfaceProjects/Utilities/date.lisp
> Why is this executable?  How could it be run?
The executable bit is spurious, fixed in next release.

> Regarding PPC, it's still supported as a secondary arch, although I don't know
> how much is happening with it currently.  As a courtesy you can ExcludeArch:
> the ppc stuff so they won't have to do it for you.
You're right, added in next release.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

--- Comment #11 from Ken Nelson  2010-11-26 10:55:40 EST 
---
(In reply to comment #10)
> (In reply to comment #9)
> 
> Awesome work.  Would you like to co-maintain this package?  :)
> 
I have no sponsor, or mentor, or whatever it's called. I don't know beans about
the Fedora packaging mechanism, which I'm sure differs substantially from that
on my  Lenovo laptop ;)

Having said that, I'd be delighted to help. That enthusiasm > talent thing that
I have.

-k-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607584] Review Request: wordgroupz - A vocabulary building application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607584

--- Comment #45 from Fedora Update System  
2010-11-26 10:43:05 EST ---
wordgroupz-0.3.1-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/wordgroupz-0.3.1-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 607584] Review Request: wordgroupz - A vocabulary building application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=607584

--- Comment #44 from Fedora Update System  
2010-11-26 10:42:57 EST ---
wordgroupz-0.3.1-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/wordgroupz-0.3.1-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 552113] Review Request: libwiiuse - library to use wiiremotes via bluetooth

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552113

--- Comment #15 from Simo Sorce  2010-11-26 10:36:19 
EST ---
Ok now passing CFLAGS to make in %build and bumped up release number.
Let me know if there is anything else to change.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 640205] Review Request: visualvm - Lightweight profiler that integrates many command-line JDK tools

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640205

--- Comment #44 from Stanislav Ochotnicky  2010-11-26 
10:28:01 EST ---
I guess I should have known this is gonna happen...the package as it is can go
into Fedora so as far as I am concerned I am done here. I probably should have
waited with "+" until update to 1.3.1.

There is no "package review" for updates so no new review is going to happen.
If the maintainer decides he wants to push reviewed version into F-14, that's
up to him, he hasn't done anything against the rules/guidelines.

You can create a bug to track progress on update to 1.3.1, but it will have
nothing to do with this review. I (reviewer) am there to verify package is sane
before entering fedora repositories, reviewers can't watch updates for all
reviewed packages (I'd be watching ~50 additional packages in past 9 months if
that was the case).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657577] New: Review Request: sdlhack - Force full-screen games to minimize

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: sdlhack - Force full-screen games to minimize

https://bugzilla.redhat.com/show_bug.cgi?id=657577

   Summary: Review Request: sdlhack - Force full-screen games to
minimize
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: medium
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: hicham.haou...@gmail.com
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://hicham.fedorapeople.org/sdlhack/sdlhack.spec
SRPM URL: http://hicham.fedorapeople.org/sdlhack/sdlhack-1.1-1.fc14.src.rpm
Description:
SDLHack is a wrapper for SDL which lets you force full-screen games to
minimize.
It also allows you to disable joystick detection.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648945] Review Request: maven - Java project management and project comprehension tool

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648945

--- Comment #6 from Stanislav Ochotnicky  2010-11-26 
09:50:10 EST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > --
> > > 
> > > maven.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven
> > > 
> > > It is safe to mark the above as %config(noreplace). The user should never
> > > modify the above file anyway, and even if they do, it should be 
> > > overridden when
> > > the rpm is updated/re-installed.
> > 
> > %config(noreplace) does exactly the opposite as I understand it. If user
> > modifies the file it won't be replaced on update.
> > 
> 
> Doh! Sorry :( you are right. I mean it should be just %config

If you don't mind I'll defer the fix until next revision with more changes

> Alright so the package is largely fine. Since it cannot be used to build
> itself, I assume it can't build anything else either? Is there a way to test 
> it
> in that case, just to make sure all is ok?

Oh. I wasn't clear I guess. mvn3 script is actually vanilla maven and that
should work on any package. What can (and does) have problems is jpp mode.
Mostly caused by two things for now:
 * wrong pom filenames in several dependencies causing maven to bail
 * some as of yet unindentified problem with maven-plugin-tools (affecting
build of maven-surefire and animal-sniffer for example)

But I was nonetheless able to build several packages with mvn-jpp:
 * atinject
 * geronimo-jpa
 * several apache-commons-packages
 * probably a few more libs

So if you just want to test "vanilla" maven install you can install it on F-14
in parallel with maven2. I've been testing it like that. The script is called
mvn3.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

--- Comment #10 from Eric Christensen  2010-11-26 
09:48:28 EST ---
(In reply to comment #9)

Awesome work.  Would you like to co-maintain this package?  :)

rpmlint is happy:

[christens...@mini rpmbuild]$ rpmlint SPECS/tudu.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[christens...@mini rpmbuild]$ rpmlint SRPMS/tudu-0.7-1.fc14.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[christens...@mini rpmbuild]$ rpmlint RPMS/i686/tudu-0.7-1.fc14.i686.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[christens...@mini rpmbuild]$ rpmlint
RPMS/i686/tudu-debuginfo-0.7-1.fc14.i686.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.


And the package installs and runs without any problems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 640205] Review Request: visualvm - Lightweight profiler that integrates many command-line JDK tools

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640205

--- Comment #43 from jiri vanek  2010-11-26 09:43:56 EST ---
Yes. When new visualvm package will be prepared for going out, then I will ask
for new review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 552113] Review Request: libwiiuse - library to use wiiremotes via bluetooth

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=552113

--- Comment #14 from Jason Tibbitts  2010-11-26 09:38:40 EST 
---
Well, there is no default CFLAGS set in the koji environment.  The only
environment is what you specify in your spec file.  Note that usually the
%configure macro sets CFLAGS, which may be what you're used to, but of course
this software doesn't use autoconf.

So, you probably need to stick CFLAGS='%optflags' on your make line.

If you post an updated package I'll take a look.  All I see is the same release
0 package I already looked at.  (Of course, your release should start at 1, and
you should increment it whenever you update the package, even during review.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 599597] Review Request: amule - The all-platform eMule p2p client

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=599597

Martin Gieseking  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution||NOTABUG
Last Closed||2010-11-26 09:39:24

--- Comment #3 from Martin Gieseking  2010-11-26 
09:39:24 EST ---
Since amule is available via rpmfusion, I'm closing here for now.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590681] Review Request: objenesis - A library for instantiating Java objects

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590681

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||NotReady

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 646139] Review Request: KXStitch - tool that creates cross stitch patterns

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=646139

Martin Gieseking  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #10 from Martin Gieseking  2010-11-26 
09:33:51 EST ---
Hi Golo,

here's the formal review. Since I couldn't find any further blocking issues,
your package is ready to be added to the Fedora now.

The next step is to request a Git repository with the distro branches you're
planning to maintain. See the following wiki page for further information:
https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure


$ rpmlint /var/lib/mock/fedora-14-i386/result/*.rpm
kxstitch.src: W: no-cleaning-of-buildroot %clean
kxstitch.src: W: no-buildroot-tag
kxstitch.src: W: no-%clean-section
3 packages and 0 specfiles checked; 0 errors, 3 warnings.

The avove warnings can be ignored since this package is to be maintained for
Fedora only.

-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
GPLv2+ according to source file headers

[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
COPYING is present

[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
$ md5sum kxstitch-0.8.4.1.tar.gz*
7feeafd526a4ea2a563a8f183fbfd12e  kxstitch-0.8.4.1.tar.gz
7feeafd526a4ea2a563a8f183fbfd12e  kxstitch-0.8.4.1.tar.gz.1

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2628056

[.] MUST: If the package does not successfully compile, build or work ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[+] MUST: The spec file MUST handle locales properly.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[+] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates. 
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: library files with a suffix (e.g. libfoo.so.1.1), must go in a -devel
package.
[.] MUST: devel packages must require the base package using a fully versioned
dependency
[+] MUST: Packages must NOT contain any .la libtool archives.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[+] MUST: .desktop files must be properly installed with
desktop-file-install/-validate in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
separate file ...
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The package should compile and build into binary rpms on all
supported architectures.
[+] SHOULD: The reviewer should test that the package functions as described.
[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) should be placed in a -devel pkg. 
[+] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin consider requiring the package which provides the file
instead of the file itself.
[+] SHOULD: your package should contain man pages for binaries/scripts. 


Package APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
__

[Bug 640205] Review Request: visualvm - Lightweight profiler that integrates many command-line JDK tools

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=640205

--- Comment #42 from Andrew John Hughes  2010-11-26 
09:34:08 EST ---
Jason, thanks for a more reasoned response.

Stanislav, should we create a new bug to track the update to 1.3.1?

Jiri, nothing should be being pushed yet!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648945] Review Request: maven - Java project management and project comprehension tool

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648945

--- Comment #5 from Deepak Bhole  2010-11-26 09:23:25 EST ---
(In reply to comment #4)
> (In reply to comment #3)
> > --
> > 
> > maven.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven
> > 
> > It is safe to mark the above as %config(noreplace). The user should never
> > modify the above file anyway, and even if they do, it should be overridden 
> > when
> > the rpm is updated/re-installed.
> 
> %config(noreplace) does exactly the opposite as I understand it. If user
> modifies the file it won't be replaced on update.
> 

Doh! Sorry :( you are right. I mean it should be just %config

> > How does this hook into the new resolver, and where can I find the code for 
> > it?
> 
> I started working on new resolver in custom repository [1]. It will most
> probably be rolled into main maven package. Original idea was to have a
> separate package (something like maven-fedora), but maven package itself would
> still have to carry patches to actually use it[2]. So that's why it will be
> shipped similarly to how jpp resolver was packaged for maven2. The code is
> more-less copied from maven2 resolver, with changes needed because of maven
> architecture changes.
> 
> > Also, what are the plans to make it buildable with mvn3 itself?
> 
> mvn3 is actually buildable with mvn2 already. It won't be able to build itself
> unless all bugs in listed in [3] are closed (incorrect pom file names). mvn2
> seems to have used pom file from jar file itself if it was available. mvn3
> doesn't so pom files have to have correct filenames. 
> 
> Plan is to have maven (maven 3) and maven2 packages installable in parallel
> until time when we feel m3 is ready to Obsolete m2 (definitely not before
> F-16).
> 
> [1] git://fedorapeople.org/~sochotni/maven-javadir-resolver.git
> [2] http://sochotni.fedorapeople.org/0003-Use-custom-resolver.patch
> [3]
> https://bugzilla.redhat.com/buglist.cgi?quicksearch=installs+pom+with+incorrect+filename

Alright so the package is largely fine. Since it cannot be used to build
itself, I assume it can't build anything else either? Is there a way to test it
in that case, just to make sure all is ok?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657560] Review Request: anjuta - Update to 2.32.1.0

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657560

Jason Tibbitts  changed:

   What|Removed |Added

 CC|fedora-package-rev...@redha |debarshi@gmail.com,
   |t.com   |rpan...@redhat.com
  Component|Package Review  |anjuta
 AssignedTo|nob...@fedoraproject.org|debarshi@gmail.com

--- Comment #1 from Jason Tibbitts  2010-11-26 09:14:11 EST 
---
Umm, anjuta is already in the distribution; you cannot submit it again.  You
are welcome to file bugs against it, but there is no point at all in submitting
another package review ticket for it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 592504] Review Request: nodebrain - a declarative rule-based language for state and event monitoring

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=592504

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657040] Review Request: tudu - A simple, command line interface to do list application

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657040

--- Comment #9 from Ken Nelson  2010-11-26 09:13:16 EST 
---
The Makefile under src in the tarball needs to be patched.  My effort is rather
ham-fisted, but succeeds in quieting rpmlint on the debug package.
I applied this patch(Patch1) to src/Makefile:

diff --git a/Makefile b/Makefile
index 4a139fc..504854c 100644
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@ PROG=tudu
 SRCS=tudu.cc data.cc editor.cc interface.cc window.cc text.cc parser.cc
 SRCS+= config.cc date.cc screen.cc sched.cc cmd.cc
 CXX=g++
-CFLAGS=-Wall -O2 -DSHARE_DIR=\"$(SHARE_DIR)\" -DETC_DIR=\"$(ETC_DIR)\"
+CFLAGS+= -DSHARE_DIR=\"$(SHARE_DIR)\" -DETC_DIR=\"$(ETC_DIR)\"

 OBJS=$(SRCS:.cc=.o)

And then changed the prep section in the specfile to look like this:
%prep
%setup -q
%patch0 -p1
pushd src
%patch1 -p1
sed -i -e "1 i \
CFLAGS=%{optflags}
" Makefile
popd

---
And, after an rpmbuild, I have:
[knel...@zonker SPECS]$ rpmlint
/home/knelson/rpmbuild/RPMS/x86_64/tudu-debuginfo-0.7-2.fc14.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

which is the desired result.  I have zero doubt that there are vastly better
ways to change the Makefile than my clumsy attempt outlined above; I look
forward to seeing what those ways are, so I can further my education.

-k-

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 591365] Review Request: libexplain - Library functions to explain system call errors

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=591365

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 590245] Review Request: gecode - Generic constraint development environment

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=590245

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597596] Review Request: alsa-patch-bay - Simple GUI for ALSA sequencers

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597596

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 597322] Review Request: hts-preprocess - High-Throughput Sequencing preprocessing scripts

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=597322

Jason Tibbitts  changed:

   What|Removed |Added

  Status Whiteboard||StalledSubmitter

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 655601] Review Request: jing - RELAX NG validator in Java

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=655601

--- Comment #2 from Stanislav Ochotnicky  2010-11-26 
08:43:37 EST ---
I have a suggestion/question. Wouldn't it make more sense to actually use
upstream build system? You are using binary release with included sources that
you compile manually...thus possibly creating differences from upstream
(unknowingly). 

I know upstream doesn't do source releases, most packages I have seen/worked
with actually use SCM checkouts to get sources and build instructions in those
cases. Is there a good reason not to do that in this case?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657560] New: Review Request: anjuta - Update to 2.32.1.0

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: anjuta - Update to 2.32.1.0

https://bugzilla.redhat.com/show_bug.cgi?id=657560

   Summary: Review Request: anjuta - Update to 2.32.1.0
   Product: Fedora
   Version: rawhide
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: j...@jsschmid.de
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


Spec URL: http://www.jsschmid.de/fedora/anjuta.spec
SRPM URL: http://www.jsschmid.de/fedora/anjuta-2.32.1.0-2.fc14.src.rpm
Description:
(I need a sponsor according to the fedora rules)
Update anjuta to the latest stable upstream version. It just contains bug-fixes
according to the GNOME release schedule. Summary of the changes (copied from
the NEWS file):

Anjuta 2.32.1 "2.x, we will miss you" (12 Nov 2010) -- Johannes Schmid

This is a bug-fix (and probably the last) release of the Anjuta 2.32.x series.
It fixes several annoying bugs and all users are encouraged to update to this
version.

There have been improvements in the python and C/C++ support so coding should
be a lot more conveninent.

Bugs fixed:
language-support-cpp-java: bgo#621916 - check for brace
libanjuta: bgo#633042 New: Sensitivity off 'ok' button on the project import
dialog
language-support-cpp: Don't show duplicated results in autocompletion
build: bgo#633661 - vala support is automagic
language-support-cpp-java: bgo#633112 - Smart Brace Completion Quotation Mark
Crash
python-support: Fix bgo#631223 autointention causes anjuta to hang

Thanks to: Carles Ferrando, Daniel Nylander, Giannis Katsampirhs, Jens Georg,
Joan Duran, Jorge González, knight2000,
Pacho Ramos, Sébastien Granjoux, Takayuki KUSANO

Anjuta 2.32.0 "Goodbye Berlin" (27 Sep 2010) -- Johannes Schmid

This is our new stable release. Older releases won't see any bug-fixing,
support,
etc and master is now heading for GNOME 3.0 which will rock!

Bugs fixed:
bgo#630460 PackageKit integration is not working on all distros
project-wizard: Update default ui file to use gtk+-2.16

Various translation updates, Anjuta is now fully available in over 20 and more
languages. Thanks for your effort.

Thanks to (again, mostly translators):
Andika Triwidada, Andrea Zagli, Aron Xu, Bruce Cowan, Bruno Brouard,
Chao-Hsiung Liao, Christian Kirbach, Duarte Loreto, Fran Diéguez, Gabor
Kelemen,
Jonh Wendell, Jorge González, Kenneth Nielsen, Marek Černocký, Mario
Blättermann,
Matej Urbančič, Michael Kotsarinis, Milo Casagrande, Piotr Drąg, Takayuki
KUSANO,
Yuri Myasoedov

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 657366] Review Request: spacewalk-branding - Spacewalk branding data

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657529] New: Review Request: conkeror - Keyboard-driven, extensible web browser

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657531] New: Review Request: python-gzipstream - Streaming zlib (gzip) support for python

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657405] Review Request: lbzip2 - fast, multi-threaded bzip2 utility

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657531] Review Request: python-gzipstream - Streaming zlib (gzip) support for python

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652396] Review Request: rubygem-boxgrinder-core - Core files required by BoxGrinder

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 652396] Review Request: rubygem-boxgrinder-core - Core files required by BoxGrinder

2010-11-26 Thread bugzilla

___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 653407] Review Request: rubygem-hashery - A collection of Hash-like classes for Ruby

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653407

--- Comment #14 from Marek Goldmann  2010-11-26 05:59:50 
EST ---
Updated package after reporting "require 'hashery'" issues with upstream:
https://github.com/rubyworks/hashery/issues/5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 226156] Merge Review: mod_python

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226156

Lubomir Rintel  changed:

   What|Removed |Added

 CC||lkund...@v3.sk
   Flag||fedora-cvs?

--- Comment #10 from Lubomir Rintel  2010-11-26 06:01:44 EST ---
Package Change Request
==
Package Name: mod_python
New Branches: el6
Owners: lkundrak

mod_python was removed from el6 and Fedora maintainer (jorton) is not willing
to maintain it as he considers the package dead given very low upstream
development activity. I need the package for koji-{web,hub} thus I'm willing to
maintain it in epel for el6, Joe does not object.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657405] Review Request: lbzip2 - fast, multi-threaded bzip2 utility

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657405

--- Comment #4 from Lukáš Zapletal  2010-11-26 07:08:21 EST ---
@Jussi: Thank you. Will correct it and add comments.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 652396] Review Request: rubygem-boxgrinder-core - Core files required by BoxGrinder

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652396

--- Comment #21 from Fedora Update System  
2010-11-26 06:54:54 EST ---
rubygem-boxgrinder-core-0.1.3-3.fc13 has been submitted as an update for Fedora
13.
https://admin.fedoraproject.org/updates/rubygem-boxgrinder-core-0.1.3-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 648945] Review Request: maven - Java project management and project comprehension tool

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=648945

--- Comment #4 from Stanislav Ochotnicky  2010-11-26 
06:54:33 EST ---
(In reply to comment #3)
> --
> 
> maven.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven
> 
> It is safe to mark the above as %config(noreplace). The user should never
> modify the above file anyway, and even if they do, it should be overridden 
> when
> the rpm is updated/re-installed.

%config(noreplace) does exactly the opposite as I understand it. If user
modifies the file it won't be replaced on update.

> How does this hook into the new resolver, and where can I find the code for 
> it?

I started working on new resolver in custom repository [1]. It will most
probably be rolled into main maven package. Original idea was to have a
separate package (something like maven-fedora), but maven package itself would
still have to carry patches to actually use it[2]. So that's why it will be
shipped similarly to how jpp resolver was packaged for maven2. The code is
more-less copied from maven2 resolver, with changes needed because of maven
architecture changes.

> Also, what are the plans to make it buildable with mvn3 itself?

mvn3 is actually buildable with mvn2 already. It won't be able to build itself
unless all bugs in listed in [3] are closed (incorrect pom file names). mvn2
seems to have used pom file from jar file itself if it was available. mvn3
doesn't so pom files have to have correct filenames. 

Plan is to have maven (maven 3) and maven2 packages installable in parallel
until time when we feel m3 is ready to Obsolete m2 (definitely not before
F-16).

[1] git://fedorapeople.org/~sochotni/maven-javadir-resolver.git
[2] http://sochotni.fedorapeople.org/0003-Use-custom-resolver.patch
[3]
https://bugzilla.redhat.com/buglist.cgi?quicksearch=installs+pom+with+incorrect+filename

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 653407] Review Request: rubygem-hashery - A collection of Hash-like classes for Ruby

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653407

--- Comment #13 from Fedora Update System  
2010-11-26 05:56:13 EST ---
rubygem-hashery-1.3.0-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-hashery-1.3.0-3.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 653407] Review Request: rubygem-hashery - A collection of Hash-like classes for Ruby

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=653407

--- Comment #12 from Fedora Update System  
2010-11-26 05:55:19 EST ---
rubygem-hashery-1.3.0-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-hashery-1.3.0-3.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654374

--- Comment #6 from viji  2010-11-26 05:49:14 EST ---
I will be removing this "svn co" completely as the upstream released 0.2.0 day
before yesterday. Will be moving to the same.

will update the srpm and spec in a while.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 635381] Review Request: perl-Tk-GraphViz - Render an interactive GraphViz graph

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=635381

Lubomir Rintel  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #5 from Lubomir Rintel  2010-11-26 05:44:56 EST ---
Thank you!

New Package SCM Request
===
Package Name: perl-Tk-GraphViz
Short Description: Render an interactive GraphViz graph
Owners: lkundrak
Branches: f13 f14 el6

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 654374] Review Request: navit - Car navigation system with routing engine

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=654374

Michel Alexandre Salim  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|nob...@fedoraproject.org|michel+...@michelsylvain.in
   ||fo
   Flag||fedora-review?

--- Comment #5 from Michel Alexandre Salim  
2010-11-26 05:40:26 EST ---
Hi Viji,

We need the instructions to generate the tarball to have reproducible results;
so
the safest way is to use the particular VCS's archiving functionality, *and*
specify the desired revision.

In this case, the following works:

svn co https://navit.svn.sourceforge.net/svnroot/navit/trunk/navit
(cd navit ; svn export -r %%{svn} . ../%{name}-%%{svn})
tar cvjf %%{name}-%%{svn}.tar.bz2 %%{name}-%%{svn}

and adjust the %dirname accordingly; I had to add %{svn} otherwise it conflicts
with either the directory created by the checkout (navit) or the ./navit
subdirectory inside it -- it's quite annoying that SVN does not let one
output directly to stdout, and thus just pipe it directly to tar without having
to
create a temporary directory on the FS!

Right now, the MD5sums don't match between your tarball and the one I generate
(even if I output to a directory called "navit" without the SVN revision).
Creating the archive using svn export, while not guaranteed, would probably be
more reliable as the files would be exported in the same order, and so
hopefully the filesystem will list it in the same order for tar! Not as good as
being able to just stream the output to tar, definitely.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657519] New: Review Request: perl-Sys-Statistics-Linux - Front-end module to collect system statistics

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Sys-Statistics-Linux - Front-end module to 
collect system statistics

https://bugzilla.redhat.com/show_bug.cgi?id=657519

   Summary: Review Request: perl-Sys-Statistics-Linux - Front-end
module to collect system statistics
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: lkund...@v3.sk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SPEC: http://v3.sk/~lkundrak/SPECS/perl-Sys-Statistics-Linux.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/perl-Sys-Statistics-Linux-0.42-2.fc14.src.rpm

Description:

Sys::Statistics::Linux is a front-end module and gather different linux
system informations like processor workload, memory usage, network and disk
statistics and a lot more. Refer the documentation of the distribution
modules to get more informations about all possible statistics.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657520] New: Review Request: perl-Array-Utils - Small utils for array manipulation

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Array-Utils - Small utils for array manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=657520

   Summary: Review Request: perl-Array-Utils - Small utils for
array manipulation
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: lkund...@v3.sk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SPEC: http://v3.sk/~lkundrak/SPECS/perl-Array-Utils.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/perl-Array-Utils-0.3-2.fc14.src.rpm

Description:

A small pure-perl module containing list manipulation routines. The
module emerged because I was tired to include same utility routines in
numerous projects.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657518] New: Review Request: perl-Net-Amazon-EC2-Metadata - Retrieves data from EC2 Metadata service

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: perl-Net-Amazon-EC2-Metadata - Retrieves data from EC2 
Metadata service

https://bugzilla.redhat.com/show_bug.cgi?id=657518

   Summary: Review Request: perl-Net-Amazon-EC2-Metadata -
Retrieves data from EC2 Metadata service
   Product: Fedora
   Version: rawhide
  Platform: Unspecified
OS/Version: Unspecified
Status: NEW
  Severity: medium
  Priority: low
 Component: Package Review
AssignedTo: nob...@fedoraproject.org
ReportedBy: lkund...@v3.sk
 QAContact: extras...@fedoraproject.org
CC: nott...@redhat.com, fedora-package-rev...@redhat.com
   Estimated Hours: 0.0
Classification: Fedora


SPEC: http://v3.sk/~lkundrak/SPECS/perl-Net-Amazon-EC2-Metadata.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/perl-Net-Amazon-EC2-Metadata-0.10-3.fc14.src.rpm

Description:

This module queries Amazon's Elastic Compute Cloud Metadata service
It also fetches 'user_data' which follows the same API but is often no
considered part of the metadata service by Amazons documentation. The
module also ships with a command line tool ec2meta that provides the same
data.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657142] Review Request: ghc-syb - Scrap Your Boilerplate

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657142

Jens Petersen  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
Last Closed||2010-11-26 05:22:29

--- Comment #7 from Jens Petersen  2010-11-26 05:22:29 EST 
---
Thanks again

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657405] Review Request: lbzip2 - fast, multi-threaded bzip2 utility

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657405

Jussi Lehtola  changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+

--- Comment #2 from Jussi Lehtola  2010-11-26 04:59:28 
EST ---
rpmlint output as before in comment #0.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- No headers in code but README states GPLv2+.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
72ab7fbfd3804e4ef1a2030f51ac3825  lbzip2-0.23.tar.gz
72ab7fbfd3804e4ef1a2030f51ac3825  ../SOURCES/lbzip2-0.23.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A


Package APPROVED. Please address issues in comment #1 before git import.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 657405] Review Request: lbzip2 - fast, multi-threaded bzip2 utility

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=657405

Jussi Lehtola  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jussi.leht...@iki.fi
 AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi
   Flag||fedora-review?

--- Comment #1 from Jussi Lehtola  2010-11-26 04:51:16 
EST ---
What do Patch0 and Patch1 do? Please make relevant comments in the makefile.

Plase be more verbose in %files; there's no need to use wildcards.

%{_bindir}/%{name}
%{_bindir}/lbzcat
%{_bindir}/lbunzip2
%doc %{_mandir}/man1/%{name}.1*
%doc %{_mandir}/man1/lbzcat.1*
%doc %{_mandir}/man1/lbunzip2.1*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 554103] Review Request: fgrun - Graphical frontend for launching FlightGear flight simulator

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554103

Fabrice Bellet  changed:

   What|Removed |Added

   Flag||fedora-cvs?

--- Comment #19 from Fabrice Bellet  2010-11-26 03:46:47 
EST ---
New Package SCM Request
===
Package Name: fgrun
Short Description: Graphical front-end for launching FlightGear flight
simulator
Owners: bellet
Branches: f13 f14 el4 el5 el6
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647149] Review Request: perl-Test-Fatal - Incredibly simple helpers for testing code with exceptions

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647149

--- Comment #10 from Fedora Update System  
2010-11-26 03:09:13 EST ---
perl-Test-Fatal-0.003-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Test-Fatal-0.003-1.fc13

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Bug 647149] Review Request: perl-Test-Fatal - Incredibly simple helpers for testing code with exceptions

2010-11-26 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=647149

--- Comment #11 from Fedora Update System  
2010-11-26 03:09:20 EST ---
perl-Test-Fatal-0.003-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Test-Fatal-0.003-1.fc14

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review


  1   2   >