[Bug 666057] Review Request: weave-minimal - Minimal Firefox Sync Server
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666057
--- Comment #1 from Jussi Lehtola 2010-12-30 04:15:59
EST ---
Please ship %{name}.conf and README as additional sources instead of creating
them in the spec file.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 665995] Review Request: fmit - Free Music Instrument Tuner
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=665995 --- Comment #11 from Damian Wrobel 2010-12-30 04:52:10 EST --- (In reply to comment #9) I generally share this idea, but maybe it's worth to spread aforementioned guidelines among cmake based projects just to minimize the amount of potential modifications necessary to incorporate particular project into a distribution. In other words it looks that it's not so obvious how to write a fully portable c-makefiles based only on the cmake documentation. Updated spec with the patch as per comment #8. Spec URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/fmit.spec SRPM URL: http://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/fmit-0.98.1-3.fc13.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666190] Reviews Request: libofetion - Library files of Openfetion
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666190 --- Comment #1 from Liang Suilong 2010-12-30 05:29:45 EST --- I update spec files and build it again. SRPM: http://liangsuilong.fedorapeople.org/libofetion-2.1.0-2.fc13.src.rpm SPEC: http://liangsuilong.fedorapeople.org/libofetion.spec The changelog is here: - Clean up BuildRequires - Add serveral documents - Change Home URL Koji Result: http://koji.fedoraproject.org/koji/taskinfo?taskID=2693775 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630754] Review Request: mscgen - Message Sequence Chart Rendering tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630754
--- Comment #9 from Michael Schwendt 2010-12-30 05:32:24
EST ---
> %files
> %defattr(-,root,root,-)
> %{_defaultdocdir}/%{name}-%{version}/
As %files sections like this keep popping up lately, note that explicitly
including files in %_defaultdocdir conflicts with using %doc. It's advised to
add a comment about that. For example,
| %files
| %defattr(-,root,root,-)
| %{_defaultdocdir}/%{name}-%{version}/
| %doc TODO
with Fedora 14 would give an error, whereas with older dists it might empty the
contents of %_defaultdocdir and replace them with the %doc files without any
warning.
%files
%defattr(-,root,root,-)
# due to this entry, %doc must not be used to add any other files
%{_defaultdocdir}/%{name}-%{version}/
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666190] Reviews Request: libofetion - Library files of Openfetion
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666190
--- Comment #2 from Michael Schwendt 2010-12-30 05:53:22
EST ---
Same issues as in bug 653971 (OpenFetion review):
* Unowned directories:
%{_datadir}/openfetion/
%{_datadir}/openfetion/resource/
http://fedoraproject.org/wiki/Packaging:UnownedDirectories
> Summary:Library files of Openfetion
Rather terse and unclear, IMO. It's likely that a lib* package contains library
files, and obviously somebody who would search for "fetion" will find
libofetion. Is this library attractive to other people, too? What parts of the
Fetion protocol does it implement? E.g.
| Summary: Instant messaging client library for the Fetion protocol V4
> %description
> Fetion is an instant messaging (IM) client developed
> by China Mobile, [...]
But this is libofetion for OpenFetion, so the description ought to start with
explaining what _this_ package contains. A few sentences later it could comment
on the relationship with the original Fetion or the Fetion Protocol V4.
> %setup -q -n %{name}-%{version}
Option -n %{name}-%{version} is the default. No need to add it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666229] Review Request: swing-worker - Long running Swing GUI interacting tasks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666229 Alexander Kurtakov changed: What|Removed |Added CC||akurt...@redhat.com --- Comment #1 from Alexander Kurtakov 2010-12-30 07:12:40 EST --- What's the point in having this package? Why not using openjdk version shich all ready has SwingWorker? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666229] Review Request: swing-worker - Long running Swing GUI interacting tasks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666229 --- Comment #2 from Alexander Kurtakov 2010-12-30 07:17:30 EST --- FWIW, simply removing swing worker jar and everywhere it's mentioned in the build files should work. Same for activation.jar. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666190] Reviews Request: libofetion - Library files of Openfetion
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666190
--- Comment #3 from Liang Suilong 2010-12-30 09:35:47
EST ---
(In reply to comment #2)
> Same issues as in bug 653971 (OpenFetion review):
>
> * Unowned directories:
>
> %{_datadir}/openfetion/
> %{_datadir}/openfetion/resource/
>
> http://fedoraproject.org/wiki/Packaging:UnownedDirectories
>
I have suggested move city.xml and province.xml from
%{_datadir}/openfetion/resource/ to %{_datadir}/libofetion/resource/.
Openfetion and libofetion will not own the same directory. And I will fix the
issues in bug 653971.
>
> > Summary:Library files of Openfetion
>
> Rather terse and unclear, IMO. It's likely that a lib* package contains
> library
> files, and obviously somebody who would search for "fetion" will find
> libofetion. Is this library attractive to other people, too? What parts of the
> Fetion protocol does it implement? E.g.
>
> | Summary: Instant messaging client library for the Fetion protocol V4
>
>
> > %description
> > Fetion is an instant messaging (IM) client developed
> > by China Mobile, [...]
>
I have rewrote a new summary and description. You can read it in next version.
> But this is libofetion for OpenFetion, so the description ought to start with
> explaining what _this_ package contains. A few sentences later it could
> comment
> on the relationship with the original Fetion or the Fetion Protocol V4.
>
>
> > %setup -q -n %{name}-%{version}
>
> Option -n %{name}-%{version} is the default. No need to add it.
OK. I fix it.
I am waiting author's update. He says that he will push a new version.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666409] New: Review Request: t4k_common - Library for Tux4Kids applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: t4k_common - Library for Tux4Kids applications https://bugzilla.redhat.com/show_bug.cgi?id=666409 Summary: Review Request: t4k_common - Library for Tux4Kids applications Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: l...@jcomserv.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Description: library of code shared by tuxmath, tuxtype, and possibly other tux4kids apps in the future. SPEC: http://zanoni.jcomserv.net/fedora/t4k_common/t4k_common.spec SRPM: http://zanoni.jcomserv.net/fedora/t4k_common/t4k_common-0.0.3-1.fc14.src.rpm Needed to upgrade tuxmath to 1.9.0. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666229] Review Request: swing-worker - Long running Swing GUI interacting tasks
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666229 Ismael Olea changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Last Closed||2010-12-30 10:08:53 --- Comment #3 from Ismael Olea 2010-12-30 10:08:53 EST --- I'm not a java coder, but reading http://en.wikipedia.org/wiki/SwingWorker now I understand your point. Thanks! I close this request. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666301] Review Request: libLAS - Library and tools for the LAS LiDAR format
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666301
--- Comment #3 from Ed Hill 2010-12-30 10:53:36 EST ---
Hi Ralf, thank you for the very quick and helpful feedback! Here's an
updated SRPM:
http://eh3.com/libLAS-1.6.0-7.fc14.src.rpm
which does a better job of using the project-defined lib install
directory (fixes the one rpmlint error) and, as an interim measure,
removes the non-multilib-compliant /usr/bin/liblas-config from the
RPMs.
I recently got libLAS commit permission so, pending approval by the
project team, I'll add some CMake templates which create and install
multilib-compliant %{_libdir}/liblas.pc files as you describe above.
And if my bash skills aren't too pathetic I'll also write a new
liblas-config which, as you suggest, wraps pkg-config.
Would you be willing to approve the above version?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 533558] Review Request: gtkwhiteboard - GTK Wiimote Whiteboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=533558 --- Comment #10 from Paulo Roma Cavalcanti 2010-12-30 11:03:30 EST --- If I use this picture from wikipedia would that be acceptable? http://en.wikipedia.org/wiki/File:Wiimote.png I can also take my own picture of a real wii remote ... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 568315] Review Request: xapply - Parallel Execution tool ala xargs/apply
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=568315 --- Comment #12 from Paul P Komkoff Jr 2010-12-30 11:39:40 EST --- Sorry for the delay, finally some progress. I reuploaded the sources to http://stingray.fedorapeople.org/review/xapply/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662255] Review Request: php-pear-CodeGen - Framework to create code generators that operate on XML descriptions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662255 Remi Collet changed: What|Removed |Added CC||fed...@famillecollet.com AssignedTo|nob...@fedoraproject.org|fed...@famillecollet.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662255] Review Request: php-pear-CodeGen - Framework to create code generators that operate on XML descriptions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=662255
Remi Collet changed:
What|Removed |Added
Flag||fedora-review?
--- Comment #4 from Remi Collet 2010-12-30 12:19:01
EST ---
=== FORMAL REVIEW ===
-=N/A x=Check !=Problem, ?=Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the PHP specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: F-14 x86_64
[x] Rpmlint output:
php-pear-CodeGen.spec: I: checking-url
http://pear.php.net/get/CodeGen-1.0.7.tgz (timeout 10 seconds)
php-pear-CodeGen.src: I: checking
php-pear-CodeGen.src: I: checking-url http://pear.php.net/package/CodeGen
(timeout 10 seconds)
php-pear-CodeGen.src: I: checking-url http://pear.php.net/get/CodeGen-1.0.7.tgz
(timeout 10 seconds)
php-pear-CodeGen.noarch: I: checking
php-pear-CodeGen.noarch: I: checking-url http://pear.php.net/package/CodeGen
(timeout 10 seconds)
php-pear-CodeGen.noarch: W: no-documentation
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
Used : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: PHP
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
b5cfe51e7291535ee2b62dece0d20ee0 CodeGen-1.0.7.tgz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
[!] Final requires
php-common >= 4.3
php-pear(Console_Getopt) >= 1.0
php-pear(PEAR)
[x] Final provides
php-pear(CodeGen) = 1.0.7
php-pear-CodeGen = 1.0.7-2.fc14
=== SUGGESTED ITEMS ===
[x] Latest version is packaged.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: F14.i386
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: koji scratch build
http://koji.fedoraproject.org/koji/taskinfo?taskID=2694200
[-] Package functions as described.
[x] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[-] %check is present and the tests pass
>From PCI report
+-+-+---+++
| Files | Version | C | Extensions | Constants/Tokens |
+-+-+---+++
| /usr/share/pear/CodeGen/* | 5.0.0 | 0 | ctype | E_ALL |
| | | | date | E_COMPILE_ERROR|
| | | | pcre | E_COMPILE_WARNING |
| |
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Abdel Gadiel Martínez Lassonde changed: What|Removed |Added AssignedTo|nob...@fedoraproject.org|abdel.g.martine...@gmail.co ||m -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Abdel Gadiel Martínez Lassonde changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Abdel Gadiel Martínez Lassonde changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 --- Comment #3 from Juan Barba 2010-12-30 13:22:20 EST --- New Package SCM Request === Package Name: python-speaklater Short Description: implements a lazy string for python useful for use with gettext Owners: haks Branches: f13 f14 f15 el5 el6 InitialCC: potty gomix -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 498873] Review Request: thrift - A multi-language RPC and serialization framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498873 Jason Tibbitts changed: What|Removed |Added Blocks|182235(FE-Legal)|201449(FE-DEADREVIEW) Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630198] Review Request: ghc-safe - Library for safe (pattern match free) functions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=630198 --- Comment #3 from Lakshmi Narasimhan 2010-12-30 14:57:41 EST --- A new version of the package is available. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 630198] Review Request: ghc-safe - Library for safe (pattern match free) functions
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=630198
Lakshmi Narasimhan changed:
What|Removed |Added
Flag||fedora-review+
--- Comment #2 from Lakshmi Narasimhan 2010-12-30
14:56:04 EST ---
[+]MUST: rpmlint must be run on every package. The output should be posted in
the review.
rpmlint -i *.rpm ../ghc-safe.spec
ghc-safe.src: W: strange-permission safe-0.2.tar.gz 0640L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
ghc-safe.src: W: strange-permission ghc-safe.spec 0640L
A file that you listed to include in your package has strange permissions.
Usually, a file should have 0644 permissions.
ghc-safe-prof.x86_64: E: devel-dependency ghc-safe-devel
Your package has a dependency on a devel package but it's not a devel package
itself.
ghc-safe-prof.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.
ghc-safe-prof.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/ghc-6.12.3/safe-0.2/libHSsafe-0.2_p.a
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
4 packages and 1 specfiles checked; 1 errors, 4 warnings.
[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
Naming-Yes
Version-release - Matches
License - OK, BSD 3-clause
No prebuilt external bits - OK
Spec legibity - OK
Package template - OK
Arch support - OK
Libexecdir - OK
rpmlint - yes
changelogs - OK
Source url tag - OK, validated.
Buildroot is ignored - present anyway. OK
%clean is ignored - present anyway. OK
Build Requires list - OK
Summary and description - OK
API documentation - OK
[+]MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
BSD 3 clause
[+]MUST: The License field in the package spec file must match the actual
license.
[+]MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
LICENSE file included in base package under /usr/share/doc/
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream
source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum ghc-safe-0.2-1.fc14.src/safe-0.2.tar.gz
e5331578ea7e0b68ed1ea4df923a23ca ghc-safe-0.2-1.fc14.src/safe-0.2.tar.gz
md5sum ~/Downloads/safe-0.2.tar.gz
e5331578ea7e0b68ed1ea4df923a23ca ~/Downloads/safe-0.2.tar.gz
[+]MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
Built on x86_64
[+]MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[NA]MUST: The spec file MUST handle locales properly using the %find_lang macro
[NA]MUST: Packages stores shared library files must call ldconfig in %post and
%postun.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec
file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissable content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+]MUST: Header files must be in a -devel package.
[NA]MUST: Static libraries must be in a -static package.
[NA]MUST: If a package contains library files with a suffix
(e.g.libfoo.so.1.1), then library files that end in .so (without suffix) must
go in a -devel package.
[+]MUST: devel packages must require the base package using a fully versioned
dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-safe
error: Failed dependencies:
ghc-safe =
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 --- Comment #4 from Jason Tibbitts 2010-12-30 14:58:37 EST --- Something is a bit odd with this ticket. First, you should raise the fedora-cvs flag when submitting SCM requests so that they will be seen. Second, I cannot find any FAS account named "haks". I found "xhaksx", but that account is not part of the packager group and cannot own packages. Third, I cannot find any FAS account containing the string "Lassonde". Abdel, what is your FAS ID? I thought I knew most of the sponsors, but that name is not familiar to me. Are you really a sponsor? You cannot review Juan's package if you are not. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657577] Review Request: sdlhack - Force full-screen games to minimize
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657577 --- Comment #24 from Fedora Update System 2010-12-30 15:21:59 EST --- sdlhack-1.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657577] Review Request: sdlhack - Force full-screen games to minimize
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657577 --- Comment #23 from Fedora Update System 2010-12-30 15:20:18 EST --- sdlhack-1.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657577] Review Request: sdlhack - Force full-screen games to minimize
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657577 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||sdlhack-1.1-1.fc13 Resolution||ERRATA Last Closed||2010-12-30 15:20:25 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661810] Review Request: libcacard - Common Access Card emulation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661810 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libcacard-0.1.0-4.fc14 Resolution||ERRATA Last Closed||2010-12-30 15:21:52 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 657577] Review Request: sdlhack - Force full-screen games to minimize
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=657577 Fedora Update System changed: What|Removed |Added Fixed In Version|sdlhack-1.1-1.fc13 |sdlhack-1.1-1.fc14 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 661810] Review Request: libcacard - Common Access Card emulation library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=661810 --- Comment #11 from Fedora Update System 2010-12-30 15:21:47 EST --- libcacard-0.1.0-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664910] Review Request: perl-Plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664910 Emmanuel Seyman changed: What|Removed |Added Status|NEW |ASSIGNED CC||emmanuel.sey...@club-intern ||et.fr AssignedTo|nob...@fedoraproject.org|emmanuel.sey...@club-intern ||et.fr Flag||fedora-review? --- Comment #3 from Emmanuel Seyman 2010-12-30 15:36:03 EST --- Taking. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664910] Review Request: perl-Plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=664910
Emmanuel Seyman changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #4 from Emmanuel Seyman
2010-12-30 16:03:14 EST ---
- = N/A
x = Check
! = Problem
? = Not evaluated
=== REQUIRED ITEMS ===
[x] Package is named according to the Package Naming Guidelines.
[x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
[x] Package meets the Packaging Guidelines including the Perl specific items
[x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2694472
[x] Rpmlint output:
perl-Plack.noarch: W: spelling-error %description -l en_US middleware -> middle
ware, middle-ware, middleweight
perl-Plack.src: W: spelling-error %description -l en_US middleware -> middle
ware, middle-ware, middleweight
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
[x] Package is not relocatable.
[x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
[x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
[x] License field in the package spec file matches the actual license.
License type: GPL+ or Artistic
[-] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
bb07fdb9a02d182bf21a8d569a0e18b9 Plack-0.9959.tar.gz
[x] Package is not known to require ExcludeArch
[x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[-] The spec file handles locales properly.
[-] ldconfig called in %post and %postun if required.
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[-] Large documentation files are in a -doc subpackage, if required.
[-] Package uses nothing in %doc for runtime.
[-] Header files in -devel subpackage, if present.
[-] Static libraries in -devel subpackage, if present.
[-] Package requires pkgconfig, if .pc files are present.
[-] Development .so files in -devel subpackage, if present.
[-] Fully versioned dependency in subpackages, if present.
[-] Package does not contain any libtool archives (.la).
[-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
[x] Package does not own files or directories owned by other packages.
=== SUGGESTED ITEMS ===
[!] Latest version is packaged.
Plack 0.9960 came out on Christmas Day.
[x] Package does not include license text files separate from upstream.
[-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x] Reviewer should test that the package builds in mock.
Tested on: rawhide.x86-64
[x] Package should compile and build into binary rpms on all supported
architectures.
Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2694472
[x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
[?] Package functions as described.
[-] Scriptlets must be sane, if used.
[-] The placement of pkgconfig(.pc) files is correct.
[-] File based requires are sane.
[x] %check is present and the tests pass
All tests successful.
Files=112, Tests=810, 15 wallclock secs ( 0.25 usr 0.09 sys + 10.07 cusr 0.99
csys = 11.40 CPU)
Result: PASS
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666455] New: Review Request: sdcv - Console version of StarDict program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. Summary: Review Request: sdcv - Console version of StarDict program https://bugzilla.redhat.com/show_bug.cgi?id=666455 Summary: Review Request: sdcv - Console version of StarDict program Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nob...@fedoraproject.org ReportedBy: pa...@zhukoff.net QAContact: extras...@fedoraproject.org CC: nott...@redhat.com, fedora-package-rev...@redhat.com Estimated Hours: 0.0 Classification: Fedora Spec: http://repo.pclinuxos.su/fedora/rpm/sdcv.spec SRPM: http://repo.pclinuxos.su/fedora/rpm/sdcv-0.4.2-2.fc14.src.rpm Description: SDCV is simple, cross-platform text-base utility for work with dictionaries in StarDict's format. That this is my first package and I need a sponsor. Project Home Page: http://sdcv.sourceforge.net/ mock build - ok. koji build - ok, http://koji.fedoraproject.org/koji/taskinfo?taskID=2694521 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662255] Review Request: php-pear-CodeGen - Framework to create code generators that operate on XML descriptions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662255 --- Comment #5 from Robert Scheck 2010-12-30 17:25:30 EST --- Spec URL: http://labs.linuxnetz.de/bugzilla/php-pear-CodeGen.spec SRPM URL: http://labs.linuxnetz.de/bugzilla/php-pear-CodeGen-1.0.7-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666455] Review Request: sdcv - Console version of StarDict program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666455 landgraf changed: What|Removed |Added Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Abdel Gadiel Martínez Lassonde changed: What|Removed |Added Flag|fedora-review+ | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Abdel Gadiel Martínez Lassonde changed: What|Removed |Added Status|ASSIGNED|NEW -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=666222 Abdel Gadiel Martínez Lassonde changed: What|Removed |Added AssignedTo|abdel.g.martine...@gmail.co |nob...@fedoraproject.org |m | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 666222] Review Request: python-speaklater - implements a lazy string for python useful for use with gettext
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=666222
Toshio Ernie Kuratomi changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||a.bad...@gmail.com
AssignedTo|nob...@fedoraproject.org|a.bad...@gmail.com
--- Comment #5 from Toshio Ernie Kuratomi 2010-12-30
18:35:10 EST ---
NEEDSWORK
Good:
* rpmlint:
python-speaklater.noarch: W: spelling-error Summary(en_US) gettext -> get text,
get-text, getter
python-speaklater.src: W: spelling-error Summary(en_US) gettext -> get text,
get-text, getter
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Those are ignorable
* named according to the guidelines
* spec file matches package name
* license is BSD in spec and package itself which is an approved free software
license
* spec file is readable
* Source matches upstream and upstream URL is canonical
* No locales so no need for %find_lang
* Not a C library
* No bundled system libraries
* Not relocatable
* Package owns all files and directories it creates and nothing else
* Permissions set properly
* Macros used consistently
* Code, not content
* No large documentation files
* Not a GUI application
* All filenames valid UTF-8
MUST FIX:
* Package does not build in koji
: Package builds in koji
- The reason is related to the %install section that I'll explain below.
Should do:
* I see that upstream has a LICENSE and a README file in their git repository.
You should send them an email to have them include those in their releases.
They probably need a MANIFEST.in file that lists those (something like:
MANIFEST.in:
include README LICENSE
Notes:
There's a couple non-Fedora-standard things in here. One of those is
contributing to the build failure. This page
https://fedoraproject.org/wiki/Packaging:Python has the python-specific
guidelines for Fedora. If you take a look you'll see that your %install
section and %files section are a bit different. In this section, it recommends
not to use --record=INSTALLED_FILES
https://fedoraproject.org/wiki/Packaging:Python#Byte_compiling. In this
section, there's a simple example of what the install section should look like:
https://fedoraproject.org/wiki/Packaging:Python_Eggs#Providing_Eggs_using_Setuptools
(sorry it's hidden away and the more complex python2/python3 spec is on the
main page.)
Basically instead of this:
%{__python} setup.py install --single-version-externally-managed -O1
--root=%{buildroot} --record=INSTALLED_FILES
[..]
%files -f INSTALLED_FILES
You should have this:
%{__python} setup.py install --root=%{buildroot}
[..]]
%files
%{python_sitelib}/*
The reason that this is contributing to a build failure is that the setup.py
file is conditionally using setuptools to build. When it uses setuptools,
--single-version-externally-managed is a valid command line option. When it
only uses distutils, that option is not available. You could BuildRequire:
setuptools to fix that but it's simpler to just make the setup.py install line
reflect what the guidelines suggest which works with both distutils and
setuptools.
If you fix those things, I can try building in koji again and approve this
package. As discussed on IRC, you're also looking at reviewing a package and
then I'll sponsor you.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 664910] Review Request: perl-Plack - Perl Superglue for Web frameworks and Web Servers (PSGI toolkit)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=664910 Ralf Corsepius changed: What|Removed |Added Flag||fedora-cvs? --- Comment #5 from Ralf Corsepius 2010-12-30 21:47:35 EST --- Again, thanks for the review, Emmanuel! New Package SCM Request === Package Name: perl-Plack Short Description: Perl Superglue for Web frameworks and Web Servers (PSGI toolkit) Owners: corsepiu Branches: f13 f14 InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 648246] Review Request: ghc-data-default - A class for types with a default value
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=648246 Lakshmi Narasimhan changed: What|Removed |Added CC||lakshminaras2...@gmail.com AssignedTo|nob...@fedoraproject.org|lakshminaras2...@gmail.com -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 662255] Review Request: php-pear-CodeGen - Framework to create code generators that operate on XML descriptions
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=662255 Remi Collet changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #6 from Remi Collet 2010-12-31 02:15:50 EST --- Requires fixed. *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
